[koha-commits] main Koha release repository branch master updated. v3.20.00-541-gbdf4894

Mon Sep 7 17:23:54 CEST 2015

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  bdf4894c507f4bac6b2b79c7ca3b7a556d246ed5 (commit)
       via  9b8d7168beb27342c4c483a0812e3a6789fabced (commit)
       via  5b1c7e4c359e974e5aca801579db72b356741a0f (commit)
       via  46ac35f8e11c06a784ca309b0dc876aff9469edb (commit)
      from  73e9dcb70fcf24dc87af7c5af6f38102206863ae (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit bdf4894c507f4bac6b2b79c7ca3b7a556d246ed5
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Tue Sep 1 16:11:54 2015 +0200

    Bug 14683: [QA Follow-up] Similar change for staff

    Script memberentry.pl contained a similar line.
    Solution is simpler here.

    Test plan:
    [1] Add, change or clear the sms number at staff side.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit 9b8d7168beb27342c4c483a0812e3a6789fabced
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Aug 28 09:13:09 2015 +0200

    Bug 14683: [QA Follow-up] Mixup between mobile and smsalertnumber

    This is an issue discussed on older reports already in the past.
    Column mobile in borrowers is actually 'Other phone', not necessary a
    mobile number. The name of the field is confusing. (Renaming it is
    outside the scope of this report.)
    The field that we are editing here is smsalertnumber. It should not be
    compared with mobile at all.

    What could be the side-effect of this correction?
    ===
    First, the change is only relevant for libraries with pref SMSSendDriver
    enabled.
    In the past patrons editing their message preferences saw mobile (read:
    other phone) in their smsalertnumber field (if the latter was still empty).
    If they saved it, it was copied to smsalertnumber.
    This change does not affect these patrons. They just have the same number
    in two columns. No big deal.
    What if a patron does not yet have a smsalertnumber? In that case no sms
    is sent in Letters.pm. So no change in behavior. If he submits
    opac-messaging now, he will no longer copy his other phone to smsalert [we
    cannot assume that it was mobile anyway!]. If he enters a mobile number,
    it will be saved correctly in the right field.

    Conclusion: this change will not break things or hurt anyone. It only
    prevents unwanted copying other phone to smsalertnumber.

    Also modified the compare to prevent uninitialized warnings.
    And removed a commented warn.

    Test plan:
    [1] Add, edit or delete the SMS number on opac-messaging regardless of
        the value of Other Phone (in the badly named mobile field).

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit 5b1c7e4c359e974e5aca801579db72b356741a0f
Author: Joonas Kylmälä <j.kylmala at gmail.com>
Date:   Wed Aug 19 11:42:50 2015 +0000

    Bug 14683: Unable to clear SMS number

    Enables to clear SMS number.

    To test:
    1. Go to opac-messaging.pl
    2. Insert SMS number and submit
    3. Clear SMS number and submit
    4. Observe that the sms number did not change
    5. Apply patch
    6. Clear SMS number and submit
    7. Observe that the sms number changes

    Sponsored-by: Vaara-kirjastot

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Adding a follow-up.

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit 46ac35f8e11c06a784ca309b0dc876aff9469edb
Author: Lari Taskula <larit at student.uef.fi>
Date:   Thu Jul 30 18:34:49 2015 +0300

    Bug 14621: Messaging preferences table needs to be sorted

    I have been working with messaging preferences and I noticed a weird issue in Firefox on Ubuntu.

    On messaging preferences page, the table is unsorted and the content in rows are generated randomly
    on every page refresh. When you select/deselect checkboxes and refresh the page (without posting the changes),
    Firefox will remember your choices. Now the issue is that when the table is unsorted and the rows keep
    changing on page refresh, Firefox has trouble remembering your choices. This makes it appear as if the
    checkboxes are magically changing values on each page refresh.

    Here is a patch that prevents this problem by sorting the messaging settings.

    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-----------------------------------------------------------------------

Summary of changes:
 C4/Members/Messaging.pm |    3 +++
 members/memberentry.pl  |   14 +++++---------
 opac/opac-messaging.pl  |   10 ++++------
 3 files changed, 12 insertions(+), 15 deletions(-)

hooks/post-receive
-- 
main Koha release repository