[koha-commits] main Koha release repository branch 3.20.x updated. v3.20.03-1-g9a8c3cb

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.20.x has been updated
       via  9a8c3cb61c324ff90b2ab017dc42845b34cdc6c5 (commit)
      from  f38f8b8758654108386ac2ffa2446515c5f1b041 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 9a8c3cb61c324ff90b2ab017dc42845b34cdc6c5
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Aug 22 13:29:28 2014 -0400

    Bug 12632: Hold limits ignored for record level holds with item level itemtypes
    
    The crux of the issue is that if you are using item level itemtypes, but
    are allowing biblio levels holds, those holds do not have items.
    
    So, in CanItemBeReserved, when Koha counts the number of holds to
    compare against the given rule, it will always give 0 ( except of course
    for found holds, and the occasional item-level hold ).
    
    So the query is saying "link each of these reserves to the reserved
    item, and count the number of reserves this patron where the itemtype is
    DVD". However, since these are all record level reserves, there are no
    items to link to, and so when it looks for all reserves this and item
    whose itemtype is DVD, it finds zero reserves!
    
    This patch solves the problem by looking first at the item level
    itemtype, and if it does not exist, then it looks at the record
    level itemtype. For installations using record level itemtypes, the
    behavior remains unchanged.
    
    Test plan:
    1) Enable item level itemtypes
    2) Create two records with one item each of a given itemtype
    3) Create a single issuing rule and limit the holds allowed for that
       itemtype to 1
    4) Place a record level hold on your first record
    5) Attempt to place a record level hold for the same patron on your
       second record. You should not be able to but you can!
    6) Apply this patch
    7) Repeat step 5, note you can no longer place the hold!
    
    Signed-off-by: Paola Rossi <paola.rossi at cineca.it>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    (cherry picked from commit 6f95acd1a6cf5113992d28173dece96e8afc6cef)
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-----------------------------------------------------------------------

Summary of changes:
 C4/Reserves.pm         |   10 ++++++++--
 t/db_dependent/Holds.t |   38 +++++++++++++++++++++++++++++++++-----
 2 files changed, 41 insertions(+), 7 deletions(-)


hooks/post-receive
-- 
main Koha release repository