[koha-commits] main Koha release repository branch 3.22.x updated. v3.22.05-23-g60e601b

Git repo owner gitmaster at git.koha-community.org
Wed Apr 6 16:39:35 CEST 2016


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.22.x has been updated
       via  60e601bf5f485a46b36bf14d2145adf9c25fe098 (commit)
      from  7212c9f41e635a3be54dc2356696b1e9ce6a370f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 60e601bf5f485a46b36bf14d2145adf9c25fe098
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Feb 9 17:02:05 2016 +0000

    Bug 15773: Fix and standardise checkboxes code in framework
    
    When creating a new subfield for an authority framework, the checkboxes
    don't behave as they should.
    If you click on the 'repeatable', 'mandatory' or 'is url' checkbox's
    label, the checkbox from the second tab will be checked/unchecked.
    This is caused by a non-unique id of the input element.
    
    I have found this bug when working on the removal of CGI::checkbox in
    both admin/auth_subfields_structure.pl and
    admin/marc_subfields_structure.pl scripts.
    
    This patch remove the use of CGI::checkbox as well as the generation of
    html code from these 2 pl scripts (which should be avoided).
    The code these scripts are now pretty similar.
    
    Test plan:
    Add/modify/remove subfield for a MARC framework and an Authority
    framework.
    Use as many field as possible and confirm that the values are correctly
    inserted/displayed.
    
    Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
    Works as advertised
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
    (cherry picked from commit 39597b86ae299a9b4c0c1e8221f51f9e8dd300ed)
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 admin/auth_subfields_structure.pl                  |  179 ++++++-------------
 admin/marc_subfields_structure.pl                  |  183 ++++++--------------
 .../en/modules/admin/auth_subfields_structure.tt   |   99 +++++++----
 .../en/modules/admin/marc_subfields_structure.tt   |   74 +++++---
 4 files changed, 209 insertions(+), 326 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list