[koha-commits] main Koha release repository branch 3.22.x updated. v3.22.05-68-ga965702
Git repo owner
gitmaster at git.koha-community.org
Thu Apr 21 10:05:16 CEST 2016
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 3.22.x has been updated
via a965702c08f84d8d770fb81e09f13bee8e922bba (commit)
from 3f1b17441ea6037ed50aa55895184494445be16a (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit a965702c08f84d8d770fb81e09f13bee8e922bba
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Apr 4 14:45:48 2016 +0100
Bug 16179: Do not crash if "rate me" is clicked and not rate selected
If JS is disabled and a user clicks on the "Rate me" button, Koha will
crashes with:
DBIx::Class::ResultSet::create(): Column 'rating_value' cannot be null
at /usr/share/koha/lib/C4/Ratings.pm line 208
To avoid that, opac-ratings.pl will check if a rate has been selected.
Test plan:
Disable JS
On a record detail page, click on the "Rate me" button
TESTED PLAN:
1) go to /cgi-bin/koha/opac-ratings.pl?biblionumber=1
-- kaboom as above.
2) apply patch
3) refresh
-- either login screen (don't know why)
-- or if already logged in, detail page.
4) koha qa test tool
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
I tested successfully by temporarily removing the modification made by
Bug 16210.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Brendan Gallagher <bredan at bywatersolutions.com>
(cherry picked from commit b679cac96409b7248f8e224e10c73dafa4c82890)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
-----------------------------------------------------------------------
Summary of changes:
opac/opac-ratings.pl | 7 +++++++
1 file changed, 7 insertions(+)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list