[koha-commits] main Koha release repository branch master updated. v3.22.00-1166-g2e7df30

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  2e7df304500d75efa3cab81635d90a2b209e668a (commit)
       via  769728015cea465bbb47d27f69077962a8f2429d (commit)
       via  d46a664ef6b79f6ceee2c00629f5933b4eaedfc3 (commit)
       via  d83aff33c603d1ba4d16de53ad926bd93a09629b (commit)
      from  a96adaadb2c4bbf54ad8440164b73aa74a38cc96 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 2e7df304500d75efa3cab81635d90a2b209e668a
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Wed Apr 20 22:03:11 2016 +0000

    Bug 15757 [QA Followup] - Having EDI configured will make unit tests fail
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Brendan Gallagher <bredan at bywatersolutions.com>

commit 769728015cea465bbb47d27f69077962a8f2429d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Apr 7 09:45:58 2016 +0100

    Bug 15757: Make GetLoanLength defaults to 0 instead of 21
    
    GetLoanLength arbitrary defaulted to 21. The expected behavior seems to
    be to default on 0 (loan will be dued today).
    
    IMPORTANT NOTE: This patch will introduce a change in the behaviors for
    configuration with a 0 in issuelength. Before this patch, the rule with
    a issuelength==0 was skipped, now it's used!
    
    Test plan:
    1/ Do not define any rule: the due date will be today (before this patch
    was +21 days)
    2/ Define some rules which does not match the patron category, itemtype
    or branchcode: the due date will be today (before this patch was +21
    days).
    3/ Modify a rule to match the checkout and set issuelength=0: the due
    date will be today (before this patch, the rule was skipped)
    4/ Modify this rule and set the issuelength to something > 0: the due
    date will be adjusted (same behavior as before this patch)
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Works ok, checked 1-4
    All test pass
    No koha-qa errors
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit d46a664ef6b79f6ceee2c00629f5933b4eaedfc3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Apr 7 10:13:43 2016 +0100

    Bug 15757: Make issuelength default to null instead of 0
    
    When editing circ rules, if the Loan period "issuelength" is not defined
    (empty string), the default value was 0, not it's inserted in the DB as
    NULL.
    
    Test plan:
    1/ Create or edit a circ rule
    2/ Do not fill the Loan period column
    3/ Save
    => Without this patch, the value was 0
    => With this patch it's now an empty string (in the DB it's set to NULL)
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Works as described.
    No errors
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit d83aff33c603d1ba4d16de53ad926bd93a09629b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Apr 7 09:44:51 2016 +0100

    Bug 15757: Add one test for GetLoanLength
    
    The usual call (3 params) of this subroutine was not tested.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm                         |   22 ++++++-------
 admin/smart-rules.pl                      |    1 +
 t/db_dependent/Circulation_Issuingrule.t  |   49 +++++++++++++++--------------
 t/db_dependent/Circulation_issuingrules.t |    4 +--
 4 files changed, 39 insertions(+), 37 deletions(-)


hooks/post-receive
-- 
main Koha release repository