[koha-commits] main Koha release repository branch master updated. v3.22.00-1473-g52d30fb

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  52d30fba7b469c8f879a22af6cb9b0c5643f81ae (commit)
      from  51be8ecd9d7a1d260fd2b1788cb6d54d8da53f31 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 52d30fba7b469c8f879a22af6cb9b0c5643f81ae
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Mon Jan 18 11:48:14 2016 +0100

    Bug 15543: Use another notice in membership_expiry.pl
    
    This patch adds a letter parameter to the cron job membership_expiry.
    It is used to substitute the default notice by another one.
    This could be handy if you e.g. send a reminder after the first notice.
    In any case, it allows for more flexibility.
    
    Apart from this new parameter, this patch removes the sub parse_letter from
    the code. The call to GetPreparedLetter is moved to the for loop and the
    call to getletter is removed (no longer needed). If there is no letter
    found, the Letter module already warns you. So we just exit the loop.
    
    Test plan:
    [1] Run membership_expiry.pl -c -n -v -let NOT_EXIST
        Check if you see a warning (coming from Letters.pm)
    [2] Check if you have some soon expiring patrons or add before/after
        parameter to include some.
        Run membership_expiry.pl -c -n -v [-before ?] [-after ?]
    [3] Create a new notice MEMBERSHIP2. Copy the text from the original notice
        and make some adjustments.
    [4] Run membership_expiry.pl -c -v -let MEMBERSHIP2 [-before ?] [-after ?].
        Be aware that this call generates email messages.
        Verify that the email contained the adjusted text.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    
    On top of Bug 14834
    Work as described, tested using '-n' to see messages on terminal, e.g.
    membership_expiry.pl -v -n -c -before 3 -branch BC -after 2 --letter MEMEXP2
    No errors
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 misc/cronjobs/membership_expiry.pl |   70 +++++++++++++-----------------------
 1 file changed, 25 insertions(+), 45 deletions(-)


hooks/post-receive
-- 
main Koha release repository