[koha-commits] main Koha release repository branch master updated. v16.05.00-507-g6cd1891

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  6cd1891ffe5903a09e2deb04e852e967a2187ba0 (commit)
       via  8c5cb134ee75aad77a9ba9b9fd84005fc0a9feb3 (commit)
      from  8a7266cd0d12f8933e9598a4e954ecd2977b89b8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 6cd1891ffe5903a09e2deb04e852e967a2187ba0
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Aug 8 15:11:56 2016 +0100

    Bug 16996: (follow-up) Do not explode if mandatory fields are missing
    
    When registering a new patron, if something went wrong, the form is
    resent to the template but without the categorycode (not a dropdown list
    anymore, but just displayed as a readonly value # TODO LATER).
    
    Signed-off-by: Marc <veron at veron.ch>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 8c5cb134ee75aad77a9ba9b9fd84005fc0a9feb3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Aug 3 16:28:24 2016 +0100

    Bug 16996: Do not explode if mandatory fields are missing
    
    At the OPAC, if a patron modify his/her information and at least 1
    mandatory field is missing, Koha will crash with
      Template process failed: undef error - Can't call method "description"
    
    It is raised by Koha::Template::Plugin::Categories::GetName called with
    an undefined categorycode.
    The problem is that the values sent originaly are not sent back to the
    template if the user missed something.
    This patch makes that all info are resent to the template in order to
    show the same form to the user.
    
    Test plan:
    0. Apply patch
    
    1. Make sure that the categorycode is not hidden in the OPAC in:
         PatronSelfRegistrationBorrowerUnwantedField or PatronSelfModificationBorrowerUnwantedField
    
    2. Add a required field in PatronSelfRegistrationBorrowerMandatoryField, for example email.
    
    3. Go to Your Personal Details in the OPAC (opac-memberentry.pl) and leave blank the required field of point 2
    
    4. Press "Submit update request"
    
    There should be no software error.
    
    NOTE: The warns will be floody on the logs.
    
    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    
    Signed-off-by: Marc <veron at veron.ch>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt |    1 +
 opac/opac-memberentry.pl                                     |    3 +++
 2 files changed, 4 insertions(+)


hooks/post-receive
-- 
main Koha release repository