From gitmaster at git.koha-community.org Fri Dec 2 11:13:29 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 02 Dec 2016 10:13:29 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-13-g13bffe7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 13bffe7347502cdd66593098af7d512dd8a8b28e (commit) from 9191246b87da14fd0c2098bc3e9b189845dd68a4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 13bffe7347502cdd66593098af7d512dd8a8b28e Author: Kyle M Hall Date: Thu Dec 1 20:11:41 2016 +0000 Bug 17709 - Article request broken - 'internal server error' Article requsts from OPAC and from intranet are showing an 'internal server error'. I am testing in 16.11 with Plack. Test Plan: 1) Set circ rule to record only article requests 2) Attempt to place a request on a record with no items 3) Note the error 4) Apply this patch 5) You should now be able to place the request! Signed-off-by: Mirko Tietgen Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/Biblio.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Dec 2 11:14:43 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 02 Dec 2016 10:14:43 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-14-g24102a7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 24102a7787ebbbccce2a8c8f013e2c79b33cce62 (commit) from 13bffe7347502cdd66593098af7d512dd8a8b28e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 24102a7787ebbbccce2a8c8f013e2c79b33cce62 Author: phette23 Date: Tue Nov 29 12:16:23 2016 -0800 Bug 17696: Add 2 missing periods in opac-suggestions.tt Problem: - two missing trailing periods in template Test plan: - configure MaxOpenSuggestions with a low limit (e.g. 1) - visit opac-suggestions.pl?op=add, login if necessary - note that the period is missing from the second sentence of the leading paragraph under the "Enter a new purchase suggestion" heading - continue to submit suggestions until you've reached the MaxOpenSuggestions limit - observe the missing period in the "TooManySuggestionsText" paragraph - apply patch - revisit opac-suggestions.pl?op=add - note that the period is now present in the second sentence of the leading paragraph under the "Enter a new purchase suggestion" heading - note that the period is also present at the end of the "TooManySuggestionsText" paragraph Signed-off-by: Alex Buckley Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Dec 2 11:20:59 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 02 Dec 2016 10:20:59 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-15-g4716c49 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 4716c495e091cb9cf6e867bfaa993fd5aeb8ccae (commit) from 24102a7787ebbbccce2a8c8f013e2c79b33cce62 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4716c495e091cb9cf6e867bfaa993fd5aeb8ccae Author: Petter Goks?yr ?sen Date: Wed Nov 23 11:12:24 2016 +0100 Bug 17671: Remove unused variables in C4::Reserves I was reading through Reserves.pm trying to figure out a bug - found some unused variables instead. Signed-off-by: Alex Buckley Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Reserves.pm | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Dec 2 20:17:32 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 02 Dec 2016 19:17:32 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-22-g9d0c436 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 9d0c436cb4e6f6866957cdfd9623a10df07126f7 (commit) via 6bea1c641f8adf69b34205282e4318263e771d40 (commit) via ac281a12910df8d4cc9116d9c4748d028402f67a (commit) via c48646e956b2ec8105f818be9ee6cc275372cc6f (commit) via e5ea08beadb9185f2b34dcf8f1830f01efc563b8 (commit) via 57fd09f45c4372438b10cf6779a42def51c77960 (commit) via 57eb834ba74a0f440e38e2eea94e9ce315d1a62d (commit) from 4716c495e091cb9cf6e867bfaa993fd5aeb8ccae (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9d0c436cb4e6f6866957cdfd9623a10df07126f7 Author: Marcel de Rooy Date: Fri Dec 2 11:25:29 2016 +0100 Bug 17583: [QA Follow-up] Final polishing Number of tests in Patrons.t corrected. Method is_going_to_expired (no english!) renamed to is_going_to_expire. Adding a negative duration replaced by a subtract. Reads easier. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 6bea1c641f8adf69b34205282e4318263e771d40 Author: Jonathan Druart Date: Tue Nov 15 11:16:03 2016 +0000 Bug 17583: Mock the pref before tests Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit ac281a12910df8d4cc9116d9c4748d028402f67a Author: Jonathan Druart Date: Wed Nov 9 13:24:09 2016 +0000 Bug 17583: Make sure we are comparing 2 dates Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit c48646e956b2ec8105f818be9ee6cc275372cc6f Author: Jonathan Druart Date: Wed Nov 9 11:25:16 2016 +0000 Bug 17583: Fix tests Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit e5ea08beadb9185f2b34dcf8f1830f01efc563b8 Author: Josef Moravec Date: Wed Nov 9 09:59:50 2016 +0000 Bug 17583: Add test for is_going_to _expired to be true Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 57fd09f45c4372438b10cf6779a42def51c77960 Author: Jonathan Druart Date: Tue Nov 8 15:01:55 2016 +0000 Bug 17583: Add the Koha::Patron->is_going_to_expired method In order to be consistent, we need to create this method as well. Test plan: Make sure the pref NotifyBorrowerDeparture works as expected Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 57eb834ba74a0f440e38e2eea94e9ce315d1a62d Author: Jonathan Druart Date: Tue Nov 8 12:26:00 2016 +0100 Bug 17583: Use Koha::Patron->is_expired from the circulation page Bug 17579 introduces a Koha::Patron->is_expired method. Let's use it from this script. Test plan: Confirm that you see the message on the interface from the circulation page for an expired patron Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/Patron.pm | 20 +++++++++++++++++++ circ/circulation.pl | 14 ++------------ t/db_dependent/Koha/Patrons.t | 43 ++++++++++++++++++++++++++++++++++++++++- 3 files changed, 64 insertions(+), 13 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Dec 2 20:25:11 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 02 Dec 2016 19:25:11 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-23-g4643251 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 46432511a600f0f22b35d004ee47eb573a33f94f (commit) from 9d0c436cb4e6f6866957cdfd9623a10df07126f7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 46432511a600f0f22b35d004ee47eb573a33f94f Author: Jonathan Druart Date: Tue Nov 8 12:16:49 2016 +0000 Bug 17580: Add the Koha::Patron->get_overdues method This method will be used by several patches later. Test plan: prove t/db_dependent/Koha/Patrons.t should return green Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/Patron.pm | 23 ++++++++++++++ t/db_dependent/Koha/Patrons.t | 68 +++++++++++++++++++++++++++++++++++++++++ 2 files changed, 91 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sun Dec 4 22:37:20 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sun, 04 Dec 2016 21:37:20 +0000 Subject: [koha-commits] main Koha release repository branch 16.11.x updated. v16.11.00-13-g2289c1c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 16.11.x has been updated via 2289c1caed83a5f0ffc1f685cb36669274d2bbb4 (commit) via 60fc30dcc6b14e6d0fcaad911daa45d10ee0de3c (commit) via 51eeb4ac89293f6c21d0fa90fec514d20ecb0d1a (commit) via 07978782f9345928e1faac7919ed6b76d140c80d (commit) via 7300cf784ae3c7a8f594f10cff46ee3e6a7bf5de (commit) from 53528e15802859ec49e9a908c2a6cf164da278b4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2289c1caed83a5f0ffc1f685cb36669274d2bbb4 Author: phette23 Date: Tue Nov 29 12:16:23 2016 -0800 Bug 17696: Add 2 missing periods in opac-suggestions.tt Problem: - two missing trailing periods in template Test plan: - configure MaxOpenSuggestions with a low limit (e.g. 1) - visit opac-suggestions.pl?op=add, login if necessary - note that the period is missing from the second sentence of the leading paragraph under the "Enter a new purchase suggestion" heading - continue to submit suggestions until you've reached the MaxOpenSuggestions limit - observe the missing period in the "TooManySuggestionsText" paragraph - apply patch - revisit opac-suggestions.pl?op=add - note that the period is now present in the second sentence of the leading paragraph under the "Enter a new purchase suggestion" heading - note that the period is also present at the end of the "TooManySuggestionsText" paragraph Signed-off-by: Alex Buckley Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer commit 60fc30dcc6b14e6d0fcaad911daa45d10ee0de3c Author: Kyle M Hall Date: Thu Dec 1 20:11:41 2016 +0000 Bug 17709 - Article request broken - 'internal server error' Article requsts from OPAC and from intranet are showing an 'internal server error'. I am testing in 16.11 with Plack. Test Plan: 1) Set circ rule to record only article requests 2) Attempt to place a request on a record with no items 3) Note the error 4) Apply this patch 5) You should now be able to place the request! Signed-off-by: Mirko Tietgen Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer commit 51eeb4ac89293f6c21d0fa90fec514d20ecb0d1a Author: Aleisha Amohia Date: Wed Nov 23 01:25:23 2016 +0000 Bug 17670: Grammar mistakes - effect vs affect In two places: 1. Administration -> Preferences -> Circulation -> AllowMultipleIssuesOnABiblio: says effect, should say affect 2. Reports -> Lost Items -> Help (top-right corner): says effect, should say affect To test, navigate to these two places and confirm charges have been made and are correct. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer commit 07978782f9345928e1faac7919ed6b76d140c80d Author: Katrin Fischer Date: Mon Nov 7 23:16:06 2016 +0100 Bug 17577: Improve sample notices for article requests - Adds "Dear..." - Fixes capitalization - Removes 'E-mail' from the description as you could also have a print template To test: - Make sure the SQL has no errors - Install the letters and proof read them If you agree - sign off! Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer commit 7300cf784ae3c7a8f594f10cff46ee3e6a7bf5de Author: Fridolin Somers Date: Tue Oct 4 12:52:46 2016 +0200 Bug 17395 - exporting checkouts in CVS generates a file with wrong extension In checkouts table, the is an export form (when some exports syspref are enabled). Export using a CSV profile will create a file with name koha.mrc (same as ISO2709 export). It would be better with koha.csv. Bug 14647 manages the export page, this but will only manage for export from checkouts table where file name is hard-coded. Test plan : - Enable checkouts exports by setting syspref ExportWithCsvProfile with a profile for record export - Go to circ page of a patron with checkouts : /cgi-bin/koha/circ/circulation.pl?borrowernumber=xxx - Show checkouts table - Select some checkboxes in "Export" column - Select "CSV" in export format combo-box - Click on "Export" => Without patch, the generated file is koha.mrc => With patch, the generated file is koha.csv - Check ISO2709 export generates a file named koha.mrc Signed-off-by: Dani Elder Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer ----------------------------------------------------------------------- Summary of changes: Koha/Biblio.pm | 6 +++--- installer/data/mysql/en/mandatory/sample_notices.sql | 12 ++++++------ installer/data/mysql/es-ES/mandatory/sample_notices.sql | 10 +++++----- installer/data/mysql/fr-CA/obligatoire/sample_notices.sql | 10 +++++----- .../data/mysql/fr-FR/1-Obligatoire/sample_notices.sql | 10 +++++----- installer/data/mysql/it-IT/necessari/notices.sql | 10 +++++----- .../data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql | 10 +++++----- installer/data/mysql/pl-PL/mandatory/sample_notices.sql | 10 +++++----- installer/data/mysql/ru-RU/mandatory/sample_notices.sql | 10 +++++----- .../prog/en/modules/admin/preferences/circulation.pref | 2 +- .../prog/en/modules/help/reports/itemslost.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-suggestions.tt | 4 ++-- tools/export.pl | 2 +- 13 files changed, 49 insertions(+), 49 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Dec 5 15:23:16 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 Dec 2016 14:23:16 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-24-g59a322a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 59a322ae7014820603ac807de7234a13c06ad696 (commit) from 46432511a600f0f22b35d004ee47eb573a33f94f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 59a322ae7014820603ac807de7234a13c06ad696 Author: Kyle M Hall Date: Mon Dec 5 14:19:35 2016 +0000 DBRev 16.12.00.000 - Update Koha.pm Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Dec 5 16:22:59 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 Dec 2016 15:22:59 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-25-g8edb7f6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 8edb7f6fb94a72f7ebc0b1d0ade031f0bed651cf (commit) from 59a322ae7014820603ac807de7234a13c06ad696 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8edb7f6fb94a72f7ebc0b1d0ade031f0bed651cf Author: Jonathan Druart Date: Mon Dec 5 08:17:21 2016 +0000 Bug 17720: CSRF - Handle unicode characters From the pod of Digest::MD5: """ Since the MD5 algorithm is only defined for strings of bytes, it can not be used on strings that contains chars with ordinal number above 255 (Unicode strings). The MD5 functions and methods will croak if you try to feed them such input data. What you can do is calculate the MD5 checksum of the UTF-8 representation of such strings. """ Test plan: - Set a MySQL/MariaDB password with unicode characters: UPDATE user SET password=PASSWORD('?') WHERE USER='koha_kohadev'; FLUSH PRIVILEGES - Update your $KOHA_CONF file - Restart Memcached - Hit the files modified by this patch => Without this patch, you will get a software error (with "Wide character in subroutine entry" in the logs). => With this patch, everything will go fine Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Edit: removed debugging leftover Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: basket/sendbasket.pl | 4 ++-- members/deletemem.pl | 5 +++-- members/member-password.pl | 5 +++-- members/memberentry.pl | 5 +++-- members/moremember.pl | 3 ++- opac/opac-memberentry.pl | 9 +++++---- opac/opac-sendbasket.pl | 4 ++-- tools/import_borrowers.pl | 6 +++--- tools/picture-upload.pl | 7 ++++--- 9 files changed, 27 insertions(+), 21 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Dec 5 16:26:19 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 Dec 2016 15:26:19 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-26-g0b71fda Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 0b71fda3d591266fb02a11c9fbbaff04de1aafa6 (commit) from 8edb7f6fb94a72f7ebc0b1d0ade031f0bed651cf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0b71fda3d591266fb02a11c9fbbaff04de1aafa6 Author: Jonathan Druart Date: Fri Dec 2 15:10:51 2016 +0000 Bug 17713: Fix Members.t tests If the category_type is 'S', GetBorrowersToExpunge won't return the patron. Test plan: t/db_dependent/Members.t should always return green Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Members.t | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Dec 5 16:31:34 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 Dec 2016 15:31:34 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-27-g2dd4ecb Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2dd4ecb4c7e0c9b717d6b6dec42ec3ad735236be (commit) from 0b71fda3d591266fb02a11c9fbbaff04de1aafa6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2dd4ecb4c7e0c9b717d6b6dec42ec3ad735236be Author: Tomas Cohen Arazi Date: Fri Dec 2 14:19:22 2016 -0300 Bug 17714: Remove itemtype-related t/db_dependent/Members/* warnings This patch makes t/db_dependent/Members/* create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Members/* => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Members/* => SUCCESS: Tests are green, and no warnings. - Sign off :-D Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Members/GetAllIssues.t | 45 ++++++++++++++++++++-------- t/db_dependent/Members/GetOverdues.t | 41 +++++++++++++++++-------- t/db_dependent/Members/GetPendingIssues.t | 46 +++++++++++++++++++++-------- 3 files changed, 94 insertions(+), 38 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Dec 5 16:34:40 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 Dec 2016 15:34:40 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-28-gb74d045 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b74d04543593bc4ead9da839c6692bf2d1841712 (commit) from 2dd4ecb4c7e0c9b717d6b6dec42ec3ad735236be (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b74d04543593bc4ead9da839c6692bf2d1841712 Author: Tomas Cohen Arazi Date: Fri Dec 2 14:32:30 2016 -0300 Bug 17715: Remove itemtype-related t/db_dependent/Holds/RevertWaitingStatus.t warnings This patch makes t/db_dependent/Holds/RevertWaitingStatus.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Holds/RevertWaitingStatus.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Holds/RevertWaitingStatus.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Holds/RevertWaitingStatus.t | 38 +++++++++++++++++++++------- 1 file changed, 29 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Dec 5 16:36:06 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 Dec 2016 15:36:06 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-30-g15ed138 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 15ed13845ff1c54605434a8f3100a72534af2351 (commit) via c275cf490fae608d9eec17d5ed55e5cd3f73c350 (commit) from b74d04543593bc4ead9da839c6692bf2d1841712 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 15ed13845ff1c54605434a8f3100a72534af2351 Author: Tomas Cohen Arazi Date: Fri Dec 2 15:32:13 2016 -0300 Bug 17716: (followup) Remove dep on existing data and tidy This patch removes the requirement for this tests for the DB to include at least 10 borrowers to pass. Borrowers are now created on each run using t::lib::TestBuilder and a loop. Bonus: some tiny changes to tidy the file. To test: - Run: $ prove t/db_dependent/CourseReserves.t SUCCESS => Tests pass with and without the patch. - Sign off :-D Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit c275cf490fae608d9eec17d5ed55e5cd3f73c350 Author: Tomas Cohen Arazi Date: Fri Dec 2 15:21:58 2016 -0300 Bug 17716: Remove itemtype-related t/db_dependent/CourseReserves.t This patch makes t/db_dependent/CourseReserves.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/CourseReserves.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/CourseReserves.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: t/db_dependent/CourseReserves.t | 48 +++++++++++++++++++++++++++------------ 1 file changed, 33 insertions(+), 15 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Dec 5 17:14:05 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 Dec 2016 16:14:05 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-31-gd0b6197 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d0b6197709f468aac6157c9901acc89be48e304f (commit) from 15ed13845ff1c54605434a8f3100a72534af2351 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d0b6197709f468aac6157c9901acc89be48e304f Author: Kyle M Hall Date: Mon Dec 5 16:11:04 2016 +0000 Bug 17586 [QA Followup] - Correct the number of unit tests Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Koha/Patrons.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Dec 5 21:29:43 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 Dec 2016 20:29:43 +0000 Subject: [koha-commits] main Koha release repository branch 16.11.x updated. v16.11.00-19-g4b2dfed Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 16.11.x has been updated via 4b2dfed916567b13ddc406695858963ebf2aae6b (commit) via 1ee1b7bbc46b92e655a69d248176401580ccdacd (commit) via 8be6a14c6284ecbb5ae938f71ad6706458c08e63 (commit) via bb312ded2a9217053929ba9e973842456d6d1aec (commit) via 94e4155a8d7621ffe888116560fd9c8fa8c4d27e (commit) via 0d94f259840ee8023513a0b060a0a9cb631da661 (commit) from 2289c1caed83a5f0ffc1f685cb36669274d2bbb4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4b2dfed916567b13ddc406695858963ebf2aae6b Author: Tomas Cohen Arazi Date: Fri Dec 2 15:32:13 2016 -0300 Bug 17716: (followup) Remove dep on existing data and tidy This patch removes the requirement for this tests for the DB to include at least 10 borrowers to pass. Borrowers are now created on each run using t::lib::TestBuilder and a loop. Bonus: some tiny changes to tidy the file. To test: - Run: $ prove t/db_dependent/CourseReserves.t SUCCESS => Tests pass with and without the patch. - Sign off :-D Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer commit 1ee1b7bbc46b92e655a69d248176401580ccdacd Author: Tomas Cohen Arazi Date: Fri Dec 2 15:21:58 2016 -0300 Bug 17716: Remove itemtype-related t/db_dependent/CourseReserves.t This patch makes t/db_dependent/CourseReserves.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/CourseReserves.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/CourseReserves.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer commit 8be6a14c6284ecbb5ae938f71ad6706458c08e63 Author: Tomas Cohen Arazi Date: Fri Dec 2 14:32:30 2016 -0300 Bug 17715: Remove itemtype-related t/db_dependent/Holds/RevertWaitingStatus.t warnings This patch makes t/db_dependent/Holds/RevertWaitingStatus.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Holds/RevertWaitingStatus.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Holds/RevertWaitingStatus.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer commit bb312ded2a9217053929ba9e973842456d6d1aec Author: Tomas Cohen Arazi Date: Fri Dec 2 14:19:22 2016 -0300 Bug 17714: Remove itemtype-related t/db_dependent/Members/* warnings This patch makes t/db_dependent/Members/* create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Members/* => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Members/* => SUCCESS: Tests are green, and no warnings. - Sign off :-D Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer commit 94e4155a8d7621ffe888116560fd9c8fa8c4d27e Author: Jonathan Druart Date: Fri Dec 2 15:10:51 2016 +0000 Bug 17713: Fix Members.t tests If the category_type is 'S', GetBorrowersToExpunge won't return the patron. Test plan: t/db_dependent/Members.t should always return green Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer commit 0d94f259840ee8023513a0b060a0a9cb631da661 Author: Jonathan Druart Date: Mon Dec 5 08:17:21 2016 +0000 Bug 17720: CSRF - Handle unicode characters From the pod of Digest::MD5: """ Since the MD5 algorithm is only defined for strings of bytes, it can not be used on strings that contains chars with ordinal number above 255 (Unicode strings). The MD5 functions and methods will croak if you try to feed them such input data. What you can do is calculate the MD5 checksum of the UTF-8 representation of such strings. """ Test plan: - Set a MySQL/MariaDB password with unicode characters: UPDATE user SET password=PASSWORD('?') WHERE USER='koha_kohadev'; FLUSH PRIVILEGES - Update your $KOHA_CONF file - Restart Memcached - Hit the files modified by this patch => Without this patch, you will get a software error (with "Wide character in subroutine entry" in the logs). => With this patch, everything will go fine Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Edit: removed debugging leftover Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer ----------------------------------------------------------------------- Summary of changes: basket/sendbasket.pl | 4 +-- members/deletemem.pl | 5 +-- members/member-password.pl | 5 +-- members/memberentry.pl | 5 +-- members/moremember.pl | 3 +- opac/opac-memberentry.pl | 9 +++--- opac/opac-sendbasket.pl | 4 +-- t/db_dependent/CourseReserves.t | 48 +++++++++++++++++++--------- t/db_dependent/Holds/RevertWaitingStatus.t | 38 ++++++++++++++++------ t/db_dependent/Members.t | 6 ++-- t/db_dependent/Members/GetAllIssues.t | 45 ++++++++++++++++++-------- t/db_dependent/Members/GetOverdues.t | 41 +++++++++++++++++------- t/db_dependent/Members/GetPendingIssues.t | 46 ++++++++++++++++++-------- tools/import_borrowers.pl | 6 ++-- tools/picture-upload.pl | 7 ++-- 15 files changed, 186 insertions(+), 86 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Dec 9 16:28:17 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 09 Dec 2016 15:28:17 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-33-g32354d8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 32354d8322afd05704d87cb38d9bc032ce8c4ec1 (commit) via c6a0848ff0b7acbec4d7bf817447d7cc84c0615e (commit) from d0b6197709f468aac6157c9901acc89be48e304f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 32354d8322afd05704d87cb38d9bc032ce8c4ec1 Author: David Cook Date: Mon May 23 11:57:04 2016 +1000 Bug 16376 - Koha::Calendar->is_holiday date truncation creates fatal errors for TZ America/Santiago Using a DateTime object with a timezone of America/Santiago was causing fatal errors for Koha::Calendar->is_holiday and Koha::Calendar->exception_holidays, when the objects were truncated to an invalid local time. Using a floating zone allows us to use the same day, month, year for comparison purposes without running into the possibility of creating an invalid local time and thus a fatal software error. Edit: While the changes to is_holiday and single_holiday make sense (Jonathan agrees too) I didn't manage to have them fail, because truncate is not failing in my trials, but days_between. So to me, it narrows down to have exception_holiday return floating tz datetime objects so it doesn't break days_between. Anyway, it is ok to push this patch, and the regression test I provide covers this scenario I'm describing. To test: - Apply the regression tests patch - Run: $ prove t/db_dependent/Holidays.t => FAIL: Unexpected error due to bad timezone/date combination - Apply this patch - Run: $ prove t/db_dependent/Holidays.t => SUCCESS: Tests pass Signed-off-by: Chris Cormack Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall commit c6a0848ff0b7acbec4d7bf817447d7cc84c0615e Author: Tomas Cohen Arazi Date: Tue Dec 6 11:29:08 2016 -0300 Bug 16376: (regression tests) This patch introduces a regression test for exception_holidays. This routine returns a list of datetimes to be used in date comparison and some datetimes don't exist in some timezones, so floating timezones should be used instead. To test: - Apply the patch on master - Run: $ prove t/db_dependent/Holidays.t => FAIL: The new test fails Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/Calendar.pm | 6 ++++-- t/db_dependent/Holidays.t | 50 +++++++++++++++++++++++++++++++++++++++++---- 2 files changed, 50 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Dec 9 17:25:17 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 09 Dec 2016 16:25:17 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-34-g167c74b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 167c74bfd386287783e101989b804077b1020369 (commit) from 32354d8322afd05704d87cb38d9bc032ce8c4ec1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 167c74bfd386287783e101989b804077b1020369 Author: Jonathan Druart Date: Wed Nov 23 10:06:04 2016 +0000 Bug 15822: Fix 500 error when searching if items.onloan=0000-00-00 The calls output_pref({ dt => dt_from_string( $date ) }) are wrong and should be replaced with output_pref({ str => $date }) For better error handling. Here we fix the problem of items.onloan when searching Test plan: - Set items.onloan=0000-00-00 (UPDATE items SET onloan='0000-00-00') This can come from old data or bad migration - Execute a search => Without this patch you get Can't locate object method "ymd" via package "dateonly" (perhaps you forgot to load "dateonly"?) at /home/vagrant/kohaclone/Koha/DateUtils.pm line 225. => With this patch you won't get the error Signed-off-by: Alex Buckley Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Search.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Dec 9 17:26:42 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 09 Dec 2016 16:26:42 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-35-g3e112f3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 3e112f3837346b500ce863a248920d3207e27131 (commit) from 167c74bfd386287783e101989b804077b1020369 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3e112f3837346b500ce863a248920d3207e27131 Author: Jonathan Druart Date: Tue Nov 22 15:28:04 2016 +0000 Bug 17668: Fix typo in parcel.pl - listinct vs listincgst This typo has been introduced by commit eed14b080db8691f371b4c19f1a190b87fcc396a Bug 13001: Refactor VAT and price calculation - parcel page So before the tax rewrite (13321, 13323). It sounded weird to me that testers did not catch the bug on this page. To understand the logic: Conditions are listincgst, invoiceincgst Conditions | Before this patch | If we fix the typo | After this patch 0 0 | excluded | excluded | excluded 0 1 | included | included | included 1 0 | excluded | excluded | excluded 1 1 | included | included | included Test plan: Create 4 vendors with the difference combinations Create a basket, add an order (with a tax) and receive it Confirm that the different values displayed on the parcel page are correct Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: acqui/parcel.pl | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Dec 9 17:32:41 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 09 Dec 2016 16:32:41 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-37-g36c608a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 36c608ab846c97aa76ea2fd721c7ce09f2c638ed (commit) via cb3d6625e87fbc861c11e181cea36f9f9cd329cc (commit) from 3e112f3837346b500ce863a248920d3207e27131 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 36c608ab846c97aa76ea2fd721c7ce09f2c638ed Author: Nick Clemens Date: Thu Dec 8 17:19:03 2016 +0000 Bug 14541 (QA followup) Add warning to gist system preference Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit cb3d6625e87fbc861c11e181cea36f9f9cd329cc Author: Jonathan Druart Date: Wed Nov 9 09:13:27 2016 +0000 Bug 14541: Do not truncate tax rate values Tax rates are stored in decimal(6,4) fields which means that 4 decimals are allowed. If a tax rate is 8.42%, it is stored as 0.0842 If a tax rate has more precision than that, Koha won't deal correctly with it. We will need to update the DB structure. With this patch, the tax rate will be displayed with the same precision as in the DB. So if you enter 8.42, you will see 8.42% instead of 8.4% without this patch. Test plan: Do a full acquisition workflow with a tax rate like 8.42% and confirm that it is correctly displayed. Signed-off-by: Alex Buckley Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt | 6 +++--- koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt | 4 ++-- koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt | 4 ++-- koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt | 4 ++-- koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt | 6 +++--- .../prog/en/modules/admin/preferences/acquisitions.pref | 1 + 7 files changed, 14 insertions(+), 13 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Dec 9 18:53:39 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 09 Dec 2016 17:53:39 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-38-g427ba8b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 427ba8b0c7f7a976e3c90a4f811836532e0f3875 (commit) from 36c608ab846c97aa76ea2fd721c7ce09f2c638ed (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 427ba8b0c7f7a976e3c90a4f811836532e0f3875 Author: Tomas Cohen Arazi Date: Mon Dec 5 11:19:12 2016 -0300 Bug 17722: Make PatronLists.t run inside a transaction This patch makes t/db_dependent/PatronLists.t run inside a transaction. It also makes it generate its own data using t::lib::TestBuilder instead of relying on sample patrons on the DB. To test: - Run: $ prove t/db_dependent/PatronLists.t => SUCCESS: Tests pass - Apply the patch - Run: $ prove t/db_dependent/PatronLists.t => SUCCESS: Tests pass - Sign off :-D Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: t/db_dependent/PatronLists.t | 43 +++++++++++++++++++++++++++++++++--------- 1 file changed, 34 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Dec 9 19:00:10 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 09 Dec 2016 18:00:10 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-45-g2fcceb7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2fcceb7f402abdc7ca30d72d11e1815a1309b41b (commit) via 4b0f08e0e1bb785fc08a1f63e99ebcdbbc75a50e (commit) via 8ed2cd10bebf5df7cbc4834aada7e6b266e37507 (commit) via b6d5748c001febc5acd67938d12ba25844d11fbc (commit) via ed9cf81c3aa8fd82f9347556364e9d2e6cef8a82 (commit) via 30dd8f99204837e2e76015badd93025599cd552c (commit) via e716299c32e201e2cf442a937a7fa7a6a47f6907 (commit) from 427ba8b0c7f7a976e3c90a4f811836532e0f3875 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2fcceb7f402abdc7ca30d72d11e1815a1309b41b Author: Kyle M Hall Date: Fri Dec 9 12:56:49 2016 -0500 Bug 15896 [QA Followup] - Supress warn when running unit tests Signed-off-by: Kyle M Hall commit 4b0f08e0e1bb785fc08a1f63e99ebcdbbc75a50e Author: Marcel de Rooy Date: Fri Nov 4 13:05:18 2016 +0100 Bug 15896: [QA Follow-up] Fix parameter name in POD Also adjust typo feees. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 8ed2cd10bebf5df7cbc4834aada7e6b266e37507 Author: Kyle M Hall Date: Fri Nov 4 10:40:38 2016 +0000 Bug 15896 - Unit Tests Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit b6d5748c001febc5acd67938d12ba25844d11fbc Author: Marcel de Rooy Date: Fri Nov 4 11:39:12 2016 +0100 Bug 15896: [QA Follow-up] Add accountlines_id parameter in paycollect We can solve the minor problem reported on 15906 now by using the accountlines_id parameter of this report. Test plan: [1] Add two manual fines (say 20 and 30). [2] Pay the second one in full, and check that the first one is not paid first. So the 20 should remain and not the 30 with 20 outstanding. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit ed9cf81c3aa8fd82f9347556364e9d2e6cef8a82 Author: Kyle M Hall Date: Wed Feb 24 12:36:20 2016 +0000 Bug 15896 - Use Koha::Account::pay internally for makepayment This is the second patch in a series to unify all payment functions into a single mathod Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay" button Signed-off-by: Josef Moravec Followed test plan, works as expected. Signed-off-by: Marc Veron Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 30dd8f99204837e2e76015badd93025599cd552c Author: Marcel de Rooy Date: Fri Nov 4 09:46:08 2016 +0100 Bug 15906: [QA Follow-up] Correct a partial payment The amount in accountlines should be saved as a negative amount, but amount outstanding is correct. Note: This routine is actually used only once (in paycollect.pl). And is only cosmetically tested in Accounts.t. Test plan: [1] Create a manual invoice, Fine, say 20. [2] Click on the Pay button next to this fine, and pay 1. [3] Pay again, using 'Pay amount' button, and pay 2. [4] Pay again, using 'Pay' on the same line, the full remaining amount. [5] Verify that you see -1, -2 and -17 on the Accounts tab. [6] Run t/db_dependent/Accounts.t Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit e716299c32e201e2cf442a937a7fa7a6a47f6907 Author: Kyle M Hall Date: Wed Feb 24 15:51:07 2016 +0000 Bug 15906 - Remove use of makepayment in paycollect.pl Test plan: 1) Apply this patch 2) Make a payment in full using the "Pay" button 3) Note payment succeeds Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Accounts.pm | 92 ++------------------------------------------- Koha/Account.pm | 81 ++++++++++++++++++++++++++++++++++----- members/paycollect.pl | 8 +++- t/db_dependent/Accounts.t | 14 ++++++- 4 files changed, 92 insertions(+), 103 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Dec 9 19:16:25 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 09 Dec 2016 18:16:25 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-47-gcb3c3a5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via cb3c3a57949d732e0a11182922e816d0611e9bf7 (commit) via 10a0f53fb6f4413a23e5836c14567c23e8284774 (commit) from 2fcceb7f402abdc7ca30d72d11e1815a1309b41b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit cb3c3a57949d732e0a11182922e816d0611e9bf7 Author: Jonathan Druart Date: Wed Nov 23 09:23:19 2016 +0000 Bug 17416: Fix audio alerts Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 10a0f53fb6f4413a23e5836c14567c23e8284774 Author: Owen Leonard Date: Mon Oct 10 05:52:51 2016 -0400 Bug 17416 - Move javascript in doc-head-close.inc into a separate include In order to prepare to move staff client javascript assets into the footer, this patch creates a new include file containing all