[koha-commits] main Koha release repository branch 16.11.x updated. v16.11.00-19-g4b2dfed

Mon Dec 5 21:29:43 CET 2016

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 16.11.x has been updated
       via  4b2dfed916567b13ddc406695858963ebf2aae6b (commit)
       via  1ee1b7bbc46b92e655a69d248176401580ccdacd (commit)
       via  8be6a14c6284ecbb5ae938f71ad6706458c08e63 (commit)
       via  bb312ded2a9217053929ba9e973842456d6d1aec (commit)
       via  94e4155a8d7621ffe888116560fd9c8fa8c4d27e (commit)
       via  0d94f259840ee8023513a0b060a0a9cb631da661 (commit)
      from  2289c1caed83a5f0ffc1f685cb36669274d2bbb4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4b2dfed916567b13ddc406695858963ebf2aae6b
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Dec 2 15:32:13 2016 -0300

    Bug 17716: (followup) Remove dep on existing data and tidy

    This patch removes the requirement for this tests for the DB to include
    at least 10 borrowers to pass. Borrowers are now created on each run
    using t::lib::TestBuilder and a loop.

    Bonus: some tiny changes to tidy the file.

    To test:
    - Run:
      $ prove t/db_dependent/CourseReserves.t
    SUCCESS => Tests pass with and without the patch.
    - Sign off :-D

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

commit 1ee1b7bbc46b92e655a69d248176401580ccdacd
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Dec 2 15:21:58 2016 -0300

    Bug 17716: Remove itemtype-related t/db_dependent/CourseReserves.t

    This patch makes t/db_dependent/CourseReserves.t create
    good sample data for its tests. It does so by creating a random
    itemtype.

    To test:
    - Run
      $ prove t/db_dependent/CourseReserves.t
    => FAIL: lots of warnings about "item-level_itypes set but no itemtype
      set for item"
    - Apply the patch
    - Run:
      $ prove t/db_dependent/CourseReserves.t
    => SUCCESS: Tests are green, and no warnings.
    - Sign off :-D

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

commit 8be6a14c6284ecbb5ae938f71ad6706458c08e63
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Dec 2 14:32:30 2016 -0300

    Bug 17715: Remove itemtype-related t/db_dependent/Holds/RevertWaitingStatus.t warnings

    This patch makes t/db_dependent/Holds/RevertWaitingStatus.t create
    good sample data for its tests. It does so by creating a random
    itemtype.

    To test:
    - Run
      $ prove t/db_dependent/Holds/RevertWaitingStatus.t
    => FAIL: lots of warnings about "item-level_itypes set but no itemtype
    set for item"
    - Apply the patch
    - Run:
      $ prove t/db_dependent/Holds/RevertWaitingStatus.t
    => SUCCESS: Tests are green, and no warnings.
    - Sign off :-D

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

commit bb312ded2a9217053929ba9e973842456d6d1aec
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Dec 2 14:19:22 2016 -0300

    Bug 17714: Remove itemtype-related t/db_dependent/Members/* warnings

    This patch makes t/db_dependent/Members/* create
    good sample data for its tests. It does so by creating a random
    itemtype.

    To test:
    - Run
      $ prove t/db_dependent/Members/*
    => FAIL: lots of warnings about "item-level_itypes set but no itemtype
    set for item"
    - Apply the patch
    - Run:
      $ prove t/db_dependent/Members/*
    => SUCCESS: Tests are green, and no warnings.
    - Sign off :-D

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

commit 94e4155a8d7621ffe888116560fd9c8fa8c4d27e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Dec 2 15:10:51 2016 +0000

    Bug 17713: Fix Members.t tests

    If the category_type is 'S', GetBorrowersToExpunge won't return the
    patron.

    Test plan:
      t/db_dependent/Members.t
    should always return green

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

commit 0d94f259840ee8023513a0b060a0a9cb631da661
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Dec 5 08:17:21 2016 +0000

    Bug 17720: CSRF - Handle unicode characters

    From the pod of Digest::MD5:
    """
    Since the MD5 algorithm is only defined for strings of bytes, it can not
    be used on strings that contains chars with ordinal number above 255
    (Unicode strings). The MD5 functions and methods will croak if you try
    to feed them such input data.
    What you can do is calculate the MD5 checksum of the UTF-8
    representation of such strings.
    """

    Test plan:
    - Set a MySQL/MariaDB password with unicode characters:
      UPDATE user SET password=PASSWORD('❤') WHERE USER='koha_kohadev';
      FLUSH PRIVILEGES
    - Update your $KOHA_CONF file
    - Restart Memcached
    - Hit the files modified by this patch

    => Without this patch, you will get a software error (with "Wide
    character in subroutine entry" in the logs).
    => With this patch, everything will go fine

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Edit: removed debugging leftover

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-----------------------------------------------------------------------

Summary of changes:
 basket/sendbasket.pl                       |    4 +--
 members/deletemem.pl                       |    5 +--
 members/member-password.pl                 |    5 +--
 members/memberentry.pl                     |    5 +--
 members/moremember.pl                      |    3 +-
 opac/opac-memberentry.pl                   |    9 +++---
 opac/opac-sendbasket.pl                    |    4 +--
 t/db_dependent/CourseReserves.t            |   48 +++++++++++++++++++---------
 t/db_dependent/Holds/RevertWaitingStatus.t |   38 ++++++++++++++++------
 t/db_dependent/Members.t                   |    6 ++--
 t/db_dependent/Members/GetAllIssues.t      |   45 ++++++++++++++++++--------
 t/db_dependent/Members/GetOverdues.t       |   41 +++++++++++++++++-------
 t/db_dependent/Members/GetPendingIssues.t  |   46 ++++++++++++++++++--------
 tools/import_borrowers.pl                  |    6 ++--
 tools/picture-upload.pl                    |    7 ++--
 15 files changed, 186 insertions(+), 86 deletions(-)

hooks/post-receive
-- 
main Koha release repository