[koha-commits] main Koha release repository branch 16.05.x updated. v16.05.05-01-93-g44df780
Git repo owner
gitmaster at git.koha-community.org
Mon Dec 12 03:01:29 CET 2016
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 16.05.x has been updated
via 44df78078777deda85bee69127e5d8ded6b2ba4c (commit)
via 4b06a7d34be30640713cf1f1c7a76b487634248a (commit)
via bec53db4e93caede0dd8149728325c404ceb46ac (commit)
via 8e72fc1dfafa4a600612e2139811c63379241cc4 (commit)
via 60299c731c55f08a5baf70b7aa3837da57aee359 (commit)
via 834d2d827cc9a9e45c97bca70d74b111ca685d12 (commit)
via 7c804558c24201d4209cdf07cc73fd113a64bc27 (commit)
via c30742cc7be2591fbae3577d73b8584d22d1de65 (commit)
via 04ac2b45003da220b8d0572557cda641bf5bf7b5 (commit)
via 7a7a9c7958e21112c6d18313b41c6605ec1b3d08 (commit)
via 1a27bd10dabe4905c115d4caf7ea566b2a19c073 (commit)
via 6391564606507c6edf80b2e5425cee57cb7e1db5 (commit)
via d02b7cf5297b4efbc763e5e79fc8e7d8e4088918 (commit)
via cb640e0dbfa2d440ae98411e845a6cc20bfcc7e7 (commit)
via 8f76a7d16488005e3710a5b4020ee8341805dc0f (commit)
via cf840b694a1e4d2f6fad1812a07bd9395f89be86 (commit)
via b3bdd760be3dcd702fe5cce080b693fe51b6c6ca (commit)
via 36ead4dee52b2ef7b887d4c88feefa7207251a89 (commit)
via 8de7d30fc153407b2c6d14183a6b76253b08eaf9 (commit)
via 8b205c907c138465738c2a7fd38eacf87a5b4546 (commit)
via ad7ccbd61f9ab5d7a1d8d36b99675f3713abccfa (commit)
via 044b67ce21dbc6edff7744778e2ced0036efb1c0 (commit)
via d51ee0f22b63879f5cb6f939d95e5767446504fe (commit)
via 07ec2afd993e26d98f86850759e3e219457c26cd (commit)
via 12a1b3263c4710e3c30b3d8c95f5d6ea3af16d13 (commit)
via 5c42820652f1aac0254cceb449b68902f9d36e02 (commit)
via 5bab59b1bbc311ec898c9794d8a540c989b03011 (commit)
via 4c46f0c017324a02e33209f1945dcdb58d3be940 (commit)
via 33b1ab4440d91deb374d2a1bf5391944e359a025 (commit)
via a84ba9d0217045bcca5f7e13ca616962a510726d (commit)
via 1111faedddfd31dbee5139903785e2f9bc28a7f3 (commit)
via 79b1553b17ca72861144bf38a714f46105abb22b (commit)
via 8c14c3b32a57fd9a3be4c7e44a79e1a4b8cc8acf (commit)
via 9f247faaed3275931222a81f20c007ee07ac2dbd (commit)
via 1938a0df4307e1239fcef2ae038a524bf65b2e6d (commit)
via b0124b321a57264fcb949f142e6a2a3b001530e7 (commit)
via 192cd465121c6683b3aa4451dfc77e37d93c657e (commit)
via cdfabce1b8b3f6a0915f9d13057269847695b9d7 (commit)
via c9433c56385946d14a29dd67a771a5bb5186aecb (commit)
via 8a919ef2bd216483b5e388c4eecab9075ec39aac (commit)
via c28704e5731ad0da1dd26757fa8fa19c39653fcc (commit)
via 8cf09aec3da545b6d9427e44a1a410e3aed06a72 (commit)
via 575bbbeaba5a2c808725697b1db263dcef9520da (commit)
via f8e2e2f1e25a9838300a160a094f4c0b3dcfa710 (commit)
via db99e5ff04298683a4b6651f0b906de0336b5646 (commit)
via 22cbe4618555a0fa07c321abdfebe0fa8cd0dd3f (commit)
via 2bc7fc1551e2c4b37fd054a733e36494adda02e3 (commit)
via 8c571a7aa60d92a37dd0a04a90f08c895be4b4e5 (commit)
via d92252a6a384dca5c0c16867dbf6754b68f2c267 (commit)
via 9307d43a10a043820e237e68ee5197607ecd03f7 (commit)
via faa9b66a72fd973fcfbf3ca91a5c0962edf73418 (commit)
via 78ae5d237eb1913e19e19030da7557d1ff8ef823 (commit)
via 4d9dc278fddcccb0d64dacd8665c9a1d061f9b08 (commit)
via 6c19b6dbc1746f4d0c616ed6544264078e1de667 (commit)
via ebaaf40e5fac16b388fffa0fe26849dc23f058b7 (commit)
via 0f19991ac1c4daeda9b0789b9fe022d0eb033c09 (commit)
via 0b307dc70cdc8c7a047eb31f9395e56361915fac (commit)
via b0494f85e64eec9a6e8bc9eda48709d37f9b0e0f (commit)
via fe296ace75312b427e839b88f5e7da57711f2da1 (commit)
via 1a9e5046607cec6dff54eef486dd86f40b0a16ed (commit)
via 92e5bbe6f215ceb956e73d498ebe1502f593b51a (commit)
via c3dc361739f915140db4a168c0a25f87fdca6eb4 (commit)
via f6c177db882785b21447d8aae3ec41fe160ade0b (commit)
via 54aee78d6afb0cd1bcb26fc7c7a65e46c372cd0f (commit)
via d4c22caabd6b45b84c17487189123d647ac8f679 (commit)
via 7f51f341856bc58f040d4be2076ee8331b5c4776 (commit)
via 6215b80fbbcd0abe25ce46394e8cff71adfe1c56 (commit)
via 9a301836714924581b806cd7c728695625ddf3cc (commit)
via d76cd8a63946572508f4a7d8b8ee8d06c63ddb09 (commit)
via 5f160f675b1de4a12db6717b297c3d7b0a7a5d3d (commit)
via c3177f41adb60a03b7683ba8e82be43e4375c449 (commit)
via 8afa5e550f4add3f451c4dfaf4bfad6703b3e1c3 (commit)
via 6155325b7f1cd2615e2ec8f1bf6ebfe96db60881 (commit)
via 81f56f959d873d95be4402da425dd2c908abe89e (commit)
via 5a8ae34a4ae24f68b946ef8132f5f251497bcb44 (commit)
via a2dd8a8428c940a5f1a78baa632e9fe89c6e7fdd (commit)
from d73fa3abf03be3111adf89228298540b8ec85c48 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 44df78078777deda85bee69127e5d8ded6b2ba4c
Author: Mason James <mtj at kohaaloha.com>
Date: Thu Dec 8 06:36:41 2016 +1300
Version 16.05.06
commit 4b06a7d34be30640713cf1f1c7a76b487634248a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Oct 27 14:15:57 2016 +0000
Bug 17513: Create GRANT for user at localhost in koha-create
See the bug description for the details.
Test plan:
Use this script to create a new koha installation, using MariaDB
You should not display
"user koha_kohadev doesn't have enough privilege on database koha_kohadev "
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Confirm that this still works (with MySQL).
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit bec53db4e93caede0dd8149728325c404ceb46ac
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Nov 18 15:26:17 2016 +0000
Bug 17660: #adv is considered as an ad by adblock
So let's rename it!
Test plan:
Edit a $t in any framework, you should be able to unfold the "Advanced
constraints" part
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 8e72fc1dfafa4a600612e2139811c63379241cc4
Author: Lari Taskula <lari.taskula at jns.fi>
Date: Mon Oct 10 17:06:07 2016 +0300
Bug 17419: Fix smsalertnumber and mobile confusion in moremember.pl
members/moremember.pl will set mobile number as smsalertnumber in template if
smsalertnumber is not defined. This will cause incorrect display for SMS number
in patron's Details-tab. This confusion between smsalertnumber and mobile is
already fixed in Bug 14683, but members/moremember.pl was not fixed yet.
This is a minor issue since it won't occur for manually added new patrons due to
fixes already pushed in Bug 14683, but in case patron's smsalertnumber is null
in database, this bug can be replicated:
To test:
1. Set EnhancedMessagingPreferences to "Allow" and make sure SMSSendDriver
has been set.
2. Add a new patron, give it a mobile/other phone number.
3. Run a SQL query:
update koha.borrowers set smsalertnumber=NULL where borrowernumber=XXX;
(replace XXX with your new patron's borrowernumber)
4. Go to patron's details tab and observe that SMS number shows the mobile/
other phone you provided earlier.
5. Apply patch.
6. Refresh patron's details tab.
7. Observe that smsalertnumber is now empty, as it should be.
Followed test plan, works as expected.
Signed-off-by: Marc <veron at veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 60299c731c55f08a5baf70b7aa3837da57aee359
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Nov 8 17:26:36 2016 +0000
Bug 17590 - Exporting reports as CSV with 'delimiter' SysPref set to 'tabulation' creates files with 't' as separator
To test:
Set 'delimiter' system preference to 'tabs'
Export a report as csv
Open the file in text editor and note fields separated by character 't'
Apply patch
Export report as CSV
Open file in text editor and note tabs are used to separate fields
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
tabs now, no errors.
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 834d2d827cc9a9e45c97bca70d74b111ca685d12
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed Aug 24 11:13:48 2016 +0000
Bug 14736 - AllowRenewalIfOtherItemsAvailable slows circulation down in case of a record with many items and many holds
If the AllowRenewalIfOtherItemsAvailable sys pref is set to allow, and a
borrower has an item checked out that has many items {30+} AND many
holds {70+) on it, loading the checkouts table for this borrower takes
FOREVER to load. The load time takes forever, because of the
factoring that happens to determine if an item is truly
available for renewal.
This patch swaps the use of GetMemberDetails for GetMember
and reorders the subroutine calls to check each items' renewability
from fastest to slowest.
In a test case, the results of pre patch were:
Start of loop: 2016-08-24T11:05:14
End of loop: 2016-08-24T11:05:29
Resulting in 15 seconds being spent in the loop
Post patch results were:
Start of loop: 2016-08-24T11:08:43
End of loop: 2016-08-24T11:08:48
Resulting in only 5 seconds being spent in the loop!
Test Plan:
1) Apply this patch
2) Note there are no changes in functionality for the renewals column of
the patron checkouts table.
If you wish to go further and test the performance benefit:
1) Create a record with 50 items and 100 holds ( 50 waiting, 50 unfilled )
2) Check out one of the waiting holds to a patron
3) Time the amount of time it takes for the checkouts table to load
4) Apply this patch
5) Repeat step 3, you should see an improvement in load time
Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 7c804558c24201d4209cdf07cc73fd113a64bc27
Author: Koha Team Lyon 3 <koha at univ-lyon3.fr>
Date: Tue Oct 25 13:37:47 2016 +0200
Bug_17484 Search with date range limit (lower and upper) does not work
If the period is entered without spaces wrapping the hyphen
You can't get any result
Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
I can't reproduce the error, search still works after applying the patch
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit c30742cc7be2591fbae3577d73b8584d22d1de65
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed Jun 8 10:53:25 2016 +0000
Bug 16493: [QA Followup] Restore title and author match as an option, make it the default
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit 04ac2b45003da220b8d0572557cda641bf5bf7b5
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed May 11 14:19:41 2016 +0000
Bug 16493: acq matching on title and author
When you order from a staged file you're getting duplicate warnings that
are inaccurate. For example, when you order a file of 50 DVDs for
example and they don't have ISBNs they're matching on the books. And
then you have to order them one by one.
This patch replaces the use of FindDuplicates with Koha's match point
system. This means you can select from the same match points defined
and used in the batch record importer, or you can opt to skip matching
altogether!
Test Plan:
1) Import a record with a title, isbn and author.
2) Delete the from the record and stage it again
3) Attempt to add it to a basket via the staged record
4) You should note the gives you the "No records imported" message
5) Apply this patch
6) Create a matcher for ISBN
7) Create a matcher for Author/Title
8) Attempt to add the record to your basket using the ISBN matcher
8) Koha should find no match and import the record to the basket
9) Stage the record again
10) Attempt to add the record to your basket using the Title/Author matcher
11) You should recieve the "No records imported" message.
Signed-off-by: Barbara Fondren <bfondren at roundrocktexas.gov>
Signed-off-by: Nicole C Engard <nengard at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 7a7a9c7958e21112c6d18313b41c6605ec1b3d08
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Nov 22 07:33:50 2016 +0000
Bug 17278: Fix test compilation errors
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 1a27bd10dabe4905c115d4caf7ea566b2a19c073
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Oct 3 12:27:21 2016 +0100
Bug 17278: Fix "show all items" link
Then we need to remove the "available" part from the query.
They are really awkward patches...
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 6391564606507c6edf80b2e5425cee57cb7e1db5
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Oct 3 10:45:13 2016 +0100
Bug 17278: Use available limit when requesting zebra when ccl query is used
When a ccl query is used, the buildQuery subroutine does not handle
the available limit (not an index).
This available limit is handle later in the subroutine.
This affect the author links on the detail page for instance (an=xx).
A much better solution would be to keep an 'available' zebra index up-to-date.
Test plan:
(OPAC or staff interface, it does not matter)
- Launch a search, click on a result and then on an author link to
launch another query (an:xx)
- Limit to available items without the 'facet'
=> Without this patch you won't get any results
=> With this patch applied you should get relevant result (regarding the
known bugs 16970, 13715, 13658, 5463, etc.)
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit d02b7cf5297b4efbc763e5e79fc8e7d8e4088918
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Sun Nov 20 16:35:53 2016 +0100
Bug 17663: Forgotten userpermissions from bug 14686
Bug 14686 added in a dbrev:
(13, 'upload_general_files', 'Upload any file'),
(13, 'upload_manage', 'Manage uploaded files');
But these were not added in userpermissions.sql somehow :)
So, what now?
This patch:
[1] adds them to userpermissions.sql as should have been done,
[2] adds a dbrev to add them for newer installs that did not run the
14686 dbrev.
Test plan:
[1] Run this sql statement:
DELETE FROM permissions WHERE code = 'upload_general_files' OR
code = 'upload_manage'
[2] Run the db rev.
[3] Check if you see Tools/Upload (with sufficient perms).
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit cb640e0dbfa2d440ae98411e845a6cc20bfcc7e7
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Nov 22 10:45:56 2016 +0000
Bug 17626 (QA followup)
Fix SAX parser error pointing to INSTALL docs
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 8f76a7d16488005e3710a5b4020ee8341805dc0f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Nov 15 08:55:04 2016 +0000
Bug 17626: Remove existing install instructions and link to the wiki pages instead
Since we are pretty bad to maintain INSTALL files, I'd suggest to point
to the wiki.
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit cf840b694a1e4d2f6fad1812a07bd9395f89be86
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Nov 15 08:54:45 2016 +0000
Bug 17626: Remove INSTALL.distri files
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit b3bdd760be3dcd702fe5cce080b693fe51b6c6ca
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Aug 15 18:12:44 2016 +0000
Bug 17132 - Availability search broken when using Elastic
Elastic appears to be indexing onloan as a string, but our code assumes
it is a boolean.
Test Plan:
1) Ensure you are set up using Elastic as your search engine
2) Search only for available items from the advanced search
3) Note you get no results
4) Apply this patch
5) Re-run the search
6) You should now get results!
Signed-off-by: Jennifer Schmidt <jschmidt at switchinc.org>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 36ead4dee52b2ef7b887d4c88feefa7207251a89
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Nov 16 11:40:21 2016 -0300
Bug 17638: Make sure t/db_dependent/Search.t doesn't use a cached koha-conf.xml
This patch makes the tests clean the 'config' namespace for cache before
it runs any tests.
To test:
- Run:
$ prove t/db_dependent/Search.t
=> FAIL: Self explanatory
- Apply the patch
- Run:
$ prove t/db_dependent/Search.t
=> SUCCESS: All green
- Sign off :-D
Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
All test pass successfuly
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Cannot reproduce, but I trust everyone telling me it's failing ; )
No regressions spotted
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 8de7d30fc153407b2c6d14183a6b76253b08eaf9
Author: Radek Šiman <rbit at rbit.cz>
Date: Thu Nov 3 14:45:43 2016 +0100
Bug 17559: Fixed HTML element ID of B_streetnumber
There is a duplicate ID in HTML code, because of this:
<input type="text" id="B_address" name="B_streetnumber" size="5"
value="" />
<input type="text" id="B_address" name="B_address" size="40" value="" />
Test plan:
1) Edit a patron and look into its HTML code
2) Find input: name="B_streetnumber"
3) Its ID is B_address - a duplicate within the code in fact
4) Apply the patch
5) Repeat steps 1 and 2
6) The ID is unique now: B_streetnumber
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 8b205c907c138465738c2a7fd38eacf87a5b4546
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Nov 16 08:22:08 2016 -0500
Bug 17645 - Remove obsolete interface customization images
This patch removes three files which are obsolete following the removal
of the OPAC prog template.
To test, apply the patch and confirm that these files no longer exist in
misc/interface_customization:
- koha3-opac-button-background.png
- koha3-opac-button-background.psd
- koha3-opac-button-background.svg
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit ad7ccbd61f9ab5d7a1d8d36b99675f3713abccfa
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Nov 4 09:34:12 2016 -0400
Bug 17545 [Revised] Make "Add biblio" not hidden by language chooser
This alternate patch changes the menu direction so that it "drops" up
instead of down. This avoids the problem of overlapping or being hidden
by the language chooser.
The disadvantage of this patch is that it is not global. However, I
think it's a better long-term solution to the problem.
To test, apply the patch and follow the issue description:
- Make sure more than one language is active for the staff client, so
that the language chooser bar shows at the bottom of each page
- Do one or more Z39.50 searches, to make sure you have some records in
the reservoir
- Go to "Cataloging" and do a "Catalog search", so that the reservoir is
searched. Make sure your search is broad enough that some results from
the reservoir is shown "below the fold"
- Scroll to the last result and click on the "Actions" menu
The direction of the menu should be up instead of down.
Signed-off-by: Magnus Enger <magnus at libriotech.no>
Popup menus on the cataloging search page now pop up instead
of down, which means they avoid being hidden by the language
chooser. Mission accimplished!
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 044b67ce21dbc6edff7744778e2ced0036efb1c0
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Nov 18 08:23:16 2016 +0000
Bug 17657: Fix locations of item types images
Koha::ItemType->image_location takes the interface in parameter or
default to OPAC.
From the item types admin page, we need to specify the intranet
interface to retrieve the correct image's url
Test plan:
Go on the item types admin page, see the source of the page and find the
image' urls.
=> Without this patch, they point to the OPAC
=> With this patch, the location is correct
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit d51ee0f22b63879f5cb6f939d95e5767446504fe
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Nov 17 12:29:14 2016 -0300
Bug 17653: Remove itemtype-related t/db_dependent/Circulation* warnings
This patch makes t/db_dependent/Circulation* create
good sample data for its tests. It does so by creating a random
itemtype.
To test:
- Run
$ prove t/db_dependent/Circulation*
=> FAIL: lots of warnings about "item-level_itypes set but no itemtype
set for item"
- Apply the patch
- Run:
$ prove t/db_dependent/Circulation*
=> SUCCESS: Tests are green, and no warnings.
- Sign off :-D
Sponsored-by: ByWater Solutions
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 07ec2afd993e26d98f86850759e3e219457c26cd
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Nov 16 16:44:44 2016 -0300
Bug 17647: Remove itemtype-related CancelReceipt.t warnings
This patch makes t/db_dependent/Acquisition/CancelReceipt.t create
good sample data for its tests. It does so by creating a random
itemtype.
To test:
- Run
$ prove t/db_dependent/Acquisition/CancelReceipt.t
=> FAIL: lots of warnings about "item-level_itypes set but no itemtype
set for item"
- Apply the patch
- Run:
$ prove t/db_dependent/Acquisition/CancelReceipt.t
=> SUCCESS: Tests are green, and no warnings.
- Sign off :-D
Sponsored-by: ByWater Solutions
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 12a1b3263c4710e3c30b3d8c95f5d6ea3af16d13
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Mon Nov 10 20:23:45 2014 +0100
Bug 12359: Add HidePatronName functionality to the holds queue
This changes the Holds Queue page to not show the patron's name
and phone number, but only the cardnumber, when HidePatronName
is set to 'Don't show'
This also changes the link to the patron account to use
the borrowernumber instead of the cardnumber, which seems
more consistent.
Fixes a tiny capitalization error: Only item...
To test:
- Look at the holds queue page with holds displayed
- Toggle HidePatronName system preference and observe the change
- Make sure the link works correctly
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Rebased 2016-10-16
Signed-off-by: Chris Kirby <christopherlawrencekirby at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 5c42820652f1aac0254cceb449b68902f9d36e02
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Sep 29 16:08:36 2016 +0100
Bug 17377: ES - Take control fields into account
There is a bug in Koha::SearchEngine::Elasticsearc::Search->json2marc, it
assumes that the MARC::Field constructor always takes >= 5 parameters.
This assumption is wrong for control fields, to create a control field you
need to call the constructor with:
MARC::Field->new($tag, $value);
Note that I got "Too much data for control field" in the _warning value of my
MARC::Field because too many parameters were passed, and the value was undef.
That broke the result search links (on the staff interface) for DB with
biblio.biblionumber mapped with 001.
Other bugs will certainly be fixed by this patch.
For instance I got:
GetMarcBiblio called with undefined biblionumber at /home/koha/src/opac/opac-search.pl line 664.
GetCOinSBiblio called with undefined record at /home/koha/src/opac/opac-search.pl line 665.
in my logs, with this patch I don't get them anymore.
Test plan:
You can try to recreate the different issues and confirm than this patch
fixes them.
Or just run the tests
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 5bab59b1bbc311ec898c9794d8a540c989b03011
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Sep 29 16:41:53 2016 +0100
Bug 17377: Add tests for json2marc
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 4c46f0c017324a02e33209f1945dcdb58d3be940
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Nov 15 17:40:22 2016 -0300
Bug 17636: Remove itemtype-related GetIssues.t warnings
This patch makes t/db_dependent/Circulation/GetIssues.t create
good sample data for its tests. It does so by creating a random
itemtype.
To test:
- Run
$ prove t/db_dependent/Circulation/GetIssues.t
=> FAIL: lots of warnings about "item-level_itypes set but no itemtype
set for item"
- Apply the patch
- Run:
$ prove t/db_dependent/Circulation/GetIssues.t
=> SUCCESS: Tests are green, and no warnings.
- Sign off :-D
Sponsored-by: ByWater Solutions
Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
All test pass successfuly
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 33b1ab4440d91deb374d2a1bf5391944e359a025
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Nov 16 10:59:26 2016 -0300
Bug 17646: Remove itemtype-related IssueSlip.t warnings
This patch makes t/db_dependent/Members/IssueSlip.t create
good sample data for its tests. It does so by creating a random
itemtype.
To test:
- Run
$ prove t/db_dependent/Members/IssueSlip.t
=> FAIL: lots of warnings about "item-level_itypes set but no itemtype
set for item"
- Apply the patch
- Run:
$ prove t/db_dependent/Members/IssueSlip.t
=> SUCCESS: Tests are green, and no warnings.
- Sign off :-D
Sponsored-by: ByWater Solutions
Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
All test pass successfuly
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit a84ba9d0217045bcca5f7e13ca616962a510726d
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed Nov 16 12:40:31 2016 +0000
Bug 17644 - t/db_dependent/Exporter/Record.t fails
Test Plan:
1) prove t/db_dependent/Exporter/Record.t fails
2) Apply this patch
3) prove t/db_dependent/Exporter/Record.t succeeds!
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 1111faedddfd31dbee5139903785e2f9bc28a7f3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Nov 16 07:44:03 2016 +0000
Bug 17637: Fix tests Auth_with_ldap.t
Koha::Patron->delete create a transaction and so we need to use
txn_begin to have nested txn
DBD::mysql::db begin_work failed: Already in a transaction
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 79b1553b17ca72861144bf38a714f46105abb22b
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Nov 8 12:40:45 2016 -0300
Bug 17587: Remove itemtype-related IsItemIssued.t warnings
This patch makes t/db_dependent/Circulation/IsItemIssued.t create
good sample data for its tests. It does so by creating a random
itemtype.
To test:
- Run
$ prove t/db_dependent/Circulation/IsItemIssued.t
=> FAIL: lots of warnings about "item-level_itypes set but no itemtype
set for item"
- Apply the patch
- Run:
$ prove t/db_dependent/Circulation/IsItemIssued.t
=> SUCCESS: Tests are green, and no warnings.
- Sign off :-D
Sponsored-by: ByWater Solutions
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 8c14c3b32a57fd9a3be4c7e44a79e1a4b8cc8acf
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Oct 28 09:54:20 2016 +0200
Bug 14598: [QA Follow-up] Small changes
[1] Renames the dbrev version to XXX; adding a my for $sth, although
not strictly necessary it feels better.
[2] Circulation.t stumbles over:
Undefined subroutine &C4::Circulation::GetItem called at ... line 1283.
Somehow this is related to use_ok instead of a regular use.
Worked around this by require_ok and adding a regular use.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 9f247faaed3275931222a81f20c007ee07ac2dbd
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Apr 7 12:03:49 2016 +0100
Bug 14598: Fix warning from effective_itemtype
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 1938a0df4307e1239fcef2ae038a524bf65b2e6d
Author: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
Date: Wed Apr 6 11:34:26 2016 -0300
Bug 14598: (QA followup) use deleted{items|biblioitems} during upgrade
If the 'statistics' table contains circulation information about items
that are no longer on the DB it will raise a warning. This patch
makes the updatedatabase.pl script use the deleteditems and deletedbiblioitems
tables to get information for those items on the statistics table.
To reproduce:
- Have your sample DB contain some circulation data on the statistics table
- Make sure some of them have NULL itemtype:
> UPDATE statistics SET itemtype = NULL WHERE type='return';
- Check the upgrade query catches them:
> SELECT s.itemnumber, i.itype, b.itemtype FROM ( SELECT DISTINCT itemnumber FROM statistics WHERE ( type = "return" OR type = "localuse" ) AND itemtype IS NULL ) s LEFT JOIN ( SELECT itemnumber,biblionumber, itype FROM items UNION SELECT itemnumber,biblionumber, itype FROM deleteditems ) i ON (s.itemnumber=i.itemnumber) LEFT JOIN ( SELECT biblionumber, itemtype FROM biblioitems UNION SELECT biblionumber, itemtype FROM deletedbiblioitems ) b ON (i.biblionumber=b.biblionumber);
+------------+-------+----------+
| itemnumber | itype | itemtype |
+------------+-------+----------+
| 732 | BK | BK |
| 731 | BK | BK |
+------------+-------+----------+
2 rows in set (0.00 sec)
- Delete the items, and some biblio too.
- Re-run the query
=> SUCCESS: Same results
- Go reset to NULL the itemtypes
> UPDATE statistics SET itemtype = NULL WHERE type='return';
- Run the updatedatabase.pl script:
$ sudo koha-shell koahdev ; cd kohaclone
$ perl installer/data/mysql/updatedatabase.pl
=> SUCCESS: No warnings
Note: It is possible that on production sites, if the sysadmin is cleaning the
deleted{items|biblioitems|biblio} tables, there will be warnings. This is expected
as they need to know some data lacks information.
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit b0124b321a57264fcb949f142e6a2a3b001530e7
Author: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
Date: Fri Apr 1 12:25:39 2016 -0300
Bug 14598: (followup) Remove unused and non-existent C4::ItemType include
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 192cd465121c6683b3aa4451dfc77e37d93c657e
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Jan 19 14:34:20 2016 +0000
Bug 14598 [QA Followup] - Update localuse statistics also
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit cdfabce1b8b3f6a0915f9d13057269847695b9d7
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Jan 12 16:04:55 2016 +0000
Bug 14598 [QA Followup] - Make unit test pass
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit c9433c56385946d14a29dd67a771a5bb5186aecb
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Dec 18 14:59:02 2015 +0000
Bug 14598 [QA Followup] - Correct the behavior of GetItem
Currently GetItem sets itemtype to the biblio itemtype if no item level
itemtype exists. Instead, it should only do this if item_level-itypes
is not set.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 8a919ef2bd216483b5e388c4eecab9075ec39aac
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Nov 20 14:23:22 2015 +0000
Bug 14598 [QA Followup] - Only fetch bib data if needed
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit c28704e5731ad0da1dd26757fa8fa19c39653fcc
Author: Brendan A Gallagher <brendan at bywatersolutions.com>
Date: Thu Nov 19 21:13:05 2015 +0000
Bug 14598 - QA Followup touching CanBookBeIssued subroutine
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 8cf09aec3da545b6d9427e44a1a410e3aed06a72
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Sep 1 11:52:17 2015 -0300
Bug 14598: (DB update) fix NULL itemtypes in statistics on 'return' rows
This patch introduces an updatedatabase.pl entry that takes care of
updating existing statistics rows.
It does so by looping on the statistics rows, collecting itemnumber occurences
that are have NULL itemtypes.
It then chooses the right itemtype following what is proposed on bug 14651, and
then updates the rows in statistics using the calculated itemtype.
Regards
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 575bbbeaba5a2c808725697b1db263dcef9520da
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Jul 27 11:16:56 2015 -0400
Bug 14598: (QA followup) Don't die on bad barcode
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit f8e2e2f1e25a9838300a160a094f4c0b3dcfa710
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Jul 27 11:40:38 2015 -0300
Bug 14598: Make C4::Circulation::AddReturn store the right itemtype
This patch makes C4::Circulation::AddReturn correctly store the itemtype
on the 'statistics' table.
To reproduce:
- Checkout master.
- Make a checkout.
- Check the 'statistics' table and notice the itemtype is correctly set
> SELECT * FROM statistics;
- Check the item in.
- Check the 'statistics' table and notice the itemtype is not set
> SELECT * FROM statistics WHERE type="return";
=> FAIL: itemtype is set to NULL
To test:
- Apply the regression tests patch
- Run the tests:
$ prove t/db_dependent/Circulation/Returns.t
=> FAIL: Tests fail
- Apply this patch
- Run the regression tests:
$ prove t/db_dependent/Circulation/Returns.t
=> SUCCESS: Tests now pass.
- Repeat the 'To reproduce' steps
=> SUCCESS: itemtype is now correctly set (in real life)
- Happily sign off :-D
Sponsored-by: Universidad Empresarial Siglo 21
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit db99e5ff04298683a4b6651f0b906de0336b5646
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Sun Jul 26 02:05:16 2015 -0300
Bug 14598: (regression tests) AddReturn should store itemtype on 'statistics' table
This patch adds tests for C4::Circulation::AddReturn(). Both tests are wrapped
inside a subtest, and look for AddReturn storing the right itemtype on the
'statistics' table.
Note: It also refactors the file a bit, to avoid side effects. And uses TestBuilder
to make it independent on already-present db data. It also removes warnings by mocking
C4::Context::userenv
To test:
- Apply the patch
- Run the tests:
$ prove t/db_dependent/Circulation/Returns.t
=> FAIL: Tests fail bacause AddReturn is not storing the itemtype
- Sign off :-D
Sponsored-by: Universidad Empresarial Siglo 21
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 22cbe4618555a0fa07c321abdfebe0fa8cd0dd3f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Oct 21 07:01:30 2016 +0000
Bug 17476: Add a way to bypass dt_from_string processing time for slow servers
We already change this value from 1 to 2 but apparently it's not enough
So let's switch it back to on and add a flag (env var SLOW_SERVER) and skip these tests
if set
Test plan:
prove t/DateUtils.t
and
SLOW_SERVER=1 prove t/DateUtils.t
should return green
Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 2bc7fc1551e2c4b37fd054a733e36494adda02e3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Nov 16 09:49:20 2016 +0000
Bug 17641: Fix t/Biblio/Isbd.t
On commit cadf5aea814636ccccd85fcc38aa30f751d779c0
Bug 11592: MARCView and ISBD followup
The prototype of C4::Biblio::GetISBDView has been changed to take a
hashref in parameter.
But the tests have not been updated
Test plan:
prove t/Biblio/Isbd.t
should return green
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
https://bugs.koha-community.org/show_bug.cgi?id=17637
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 8c571a7aa60d92a37dd0a04a90f08c895be4b4e5
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Wed Sep 14 15:14:02 2016 -0400
Bug 15690: Hardcoded 16 is uncool
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Followed test plan in comment #7, works as expectd.
Signed-off-by: Marc <veron at veron.ch>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit d92252a6a384dca5c0c16867dbf6754b68f2c267
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Sep 13 15:43:50 2016 +0100
Bug 15690: CardnumberLength should not be bigger than 16
borrowers.cardnumber is a varchar(16), so CardnumberLength should not
have a max > 16
Test plan:
Test different value in CardnumberLength ("20", "20,30", "40,")
Edit a patron a make sure the text display under the cardnumber input is
correct
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Marc <veron at veron.ch>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 9307d43a10a043820e237e68ee5197607ecd03f7
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Nov 8 14:43:46 2016 +0000
Bug 17582: Fix authority framework edition
Step to recreate:
Admin>Authority types > Actions > Marc structure
Test plan
Confirm that this patch fixes the issue
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Fix the issue, no errors.
Can edit auth marc structure
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit faa9b66a72fd973fcfbf3ca91a5c0962edf73418
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Nov 9 16:45:38 2016 -0300
Bug 17603: Remove itemtype-related Borrower_Discharge.t warnings
This patch makes t/db_dependent/Patron/Borrower_Discharge.t create
good sample data for its tests. It does so by creating a random
itemtype.
To test:
- Run
$ prove t/db_dependent/Patron/Borrower_Discharge.t
=> FAIL: lots of warnings about "item-level_itypes set but no itemtype
set for item"
- Apply the patch
- Run:
$ prove t/db_dependent/Patron/Borrower_Discharge.t
=> SUCCESS: Tests are green, and no warnings.
- Sign off :-D
Sponsored-by: ByWater Solutions
Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 78ae5d237eb1913e19e19030da7557d1ff8ef823
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Nov 8 16:28:07 2016 -0300
Bug 17592: Remove itemtype-related maxsuspensiondays.t warnings
This patch makes t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t create
good sample data for its tests. It does so by creating a random
itemtype.
To test:
- Run
$ prove t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t
=> FAIL: lots of warnings about "item-level_itypes set but no itemtype
set for item"
- Apply the patch
- Run:
$ prove t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t
=> SUCCESS: Tests are green, and no warnings.
- Sign off :-D
Sponsored-by: ByWater Solutions
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 4d9dc278fddcccb0d64dacd8665c9a1d061f9b08
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Nov 8 12:40:45 2016 -0300
Bug 17587: Remove itemtype-related IsItemIssued.t warnings
This patch makes t/db_dependent/Circulation/IsItemIssued.t create
good sample data for its tests. It does so by creating a random
itemtype.
To test:
- Run
$ prove t/db_dependent/Circulation/IsItemIssued.t
=> FAIL: lots of warnings about "item-level_itypes set but no itemtype
set for item"
- Apply the patch
- Run:
$ prove t/db_dependent/Circulation/IsItemIssued.t
=> SUCCESS: Tests are green, and no warnings.
- Sign off :-D
Sponsored-by: ByWater Solutions
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 6c19b6dbc1746f4d0c616ed6544264078e1de667
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Nov 7 16:08:02 2016 -0300
Bug 17575: (followup) Remove missing fine type warnings
Sponsored-by: ByWater Solutions
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit ebaaf40e5fac16b388fffa0fe26849dc23f058b7
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Nov 7 16:00:21 2016 -0300
Bug 17575: Remove itemtype-related warnings from Circulation.t
To test:
- Run:
$ prove t/db_dependent/Circulation.t
=> FAIL: Lots of warnings
- Apply the patch
- Run:
$ prove t/db_dependent/Circulation.t
=> SUCCESS: All green and no itemtype warnings
- Sign off :-D
Sponsored-by: ByWater Solutions
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 0f19991ac1c4daeda9b0789b9fe022d0eb033c09
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Nov 7 15:31:53 2016 -0300
Bug 17574: Remove itemtype-related warnings from LocalHoldsPriority.t
To test:
- Run:
$ prove t/db_dependent/Holds/LocalHoldsPriority.t
=> FAIL: Tests raise lots of warnings
- Apply the patch
- Run:
$ prove t/db_dependent/Holds/LocalHoldsPriority.t
=> SUCCESS: Tests pass, and no warnings!
- Sign off :-D
Sponsored-by: ByWater Solutions
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 0b307dc70cdc8c7a047eb31f9395e56361915fac
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Nov 7 15:24:34 2016 -0300
Bug 17573: Remove itemtype-related warnings from DecreaseLoanHighHolds.t
To test:
- Run:
$ prove t/db_dependent/DecreaseLoanHighHolds.t
=> FAIL: Lots of warnings
- Apply the patch
- Run:
$ prove t/db_dependent/DecreaseLoanHighHolds.t
=> SUCCESS: All green and no warnings.
- Sign off :-D
Sponsored-by: ByWater Solutions
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit b0494f85e64eec9a6e8bc9eda48709d37f9b0e0f
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Nov 11 09:27:12 2016 +0100
Bug 17572: [QA Follow-up] Cosmetic changes
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit fe296ace75312b427e839b88f5e7da57711f2da1
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Nov 7 15:09:24 2016 -0300
Bug 17572: (followup) Remove test's hardcoded values
This patch makes the tests use t::lib::TestBuilder instead of
hardcoding values.
Test plan:
- Run:
$ prove t/db_dependent/Circulation/issue.t
=> SUCCESS: All tests return green with and without the patch
- Sign off :-D
Sponsored-by: ByWater Solutions
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 1a9e5046607cec6dff54eef486dd86f40b0a16ed
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Nov 7 14:55:41 2016 -0300
Bug 17572: Remove itemtype-related warnings from issue.t
This patch makes t/db_dependent/Circulation/issue.t create
good sample data for its tests. It does so by creating a random
itemtype.
To test:
- Run
$ prove t/db_dependent/Circulation/issue.t
=> FAIL: lots of warnings about "item-level_itypes set but no itemtype
set for item"
- Apply the patch
- Run:
$ prove t/db_dependent/Circulation/issue.t
=> SUCCESS: Tests are green, and no warnings.
- Sign off :-D
Sponsored-by: ByWater Solutions
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 92e5bbe6f215ceb956e73d498ebe1502f593b51a
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Mon Nov 7 16:07:01 2016 +0100
Bug 17420 - record export fails when itemtype on biblio - followup
Same as previous patch for misc/export_records.pl.
Test plan :
- Use syspref item-level_itypes = biblio record
- Run misc/export_records.pl
=> Without patch you get an error : DBD::mysql::st execute failed: Unknown column 'biblioitems.itemtype' in 'where clause' ...
=> With patch you get a correct export file
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Export Ok, no errors.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit c3dc361739f915140db4a168c0a25f87fdca6eb4
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Mon Oct 10 16:46:04 2016 +0200
Bug 17420 - record export fails when itemtype on biblio
In Tools, Export data, you can export with a filter on item type.
When item type is on biblio record, you get the error :
export.pl: DBIx::Class::ResultSet::next(): Unknown column 'biblioitems.itemtype' in 'where clause' at /home/koha/src/Koha/Objects.pm line 150
Looks like its because this code use to be a SQL Select and is now a DBIx call :
C4::Context->preference('item-level_itypes')
? ( 'items.itype' => $itemtype )
: ( 'me.itemtype' => $itemtype )
This patch corrects by using "me.itemtype"
Test plan :
- Use syspref item-level_itypes = biblio record
- Go to Tools > Export data : /cgi-bin/koha/tools/export.pl
- Select an item type
- Click on "Export biblio records"
=> Without patch you get an error 500
=> With patch you get a correct export file
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Fix the issue, no errors.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit f6c177db882785b21447d8aae3ec41fe160ade0b
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Aug 26 15:04:12 2016 +0000
Bug 17204: Rancor Z39.50 search fails under plack
MetaSearcher.pm forks children to handle searching each server. When the
process waits for the children it never continues.
The simplest solution here is to exclude the metasearcher service from
running under plack
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 54aee78d6afb0cd1bcb26fc7c7a65e46c372cd0f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Nov 7 11:10:04 2016 +0000
Bug 17564: Fix t/db_dependent/Acquisition/OrderUsers.t
ModReceiveOrder takes now a 'order' parameter and is mandatory.
This new test file has been added after the first submission of bug
13321 and has not been updated during the rebases.
Test plan:
prove t/db_dependent/Acquisition/OrderUsers.t
should return green
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit d4c22caabd6b45b84c17487189123d647ac8f679
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Nov 8 17:12:27 2016 +0000
Bug 17589 - Improper method type in Koha::ItemType(s)
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 7f51f341856bc58f040d4be2076ee8331b5c4776
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Tue Oct 4 12:36:11 2016 +0200
Bug 17394 - exporting checkouts with items selects without items in combo-box
In checkouts table, the is an export form (when some exports syspref are enabled).
When selecting some checkouts and selecting "ISO2709 with items" in export format combo-box, clicking on "Export" will select "ISO2709 without items" in the export format combo-box.
This is quite strange.
Its because the form as 2 inputs with same name and id "output_format" : an hidden input (the wanted arg for tools/export.pl) and a select (the export format combo-box).
So an action meant on the hidden input impacts the select.
This patch corrects by changing id and name of the export format combo-box : issues-table-output-format
TEST plan :
- Enable checkouts exports by setting syspref ExportWithCsvProfile with a profile
- Go to circ page of a patron with checkouts : /cgi-bin/koha/circ/circulation.pl?borrowernumber=xxx
- Show checkouts table
- Select some checkboxes in "Export" column
- Select "ISO2709 with items" in export format combo-box
- Click on "Export"
=> Without patch, the export format combo-box changes to "ISO2709 without items"
=> With patch, the export format combo-box does not changes
- Check the export file contains the items
- Check exports "ISO2709 without items" and "CSV" are OK
Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 6215b80fbbcd0abe25ce46394e8cff71adfe1c56
Author: Matthias Meusburger <matthias.meusburger at biblibre.com>
Date: Fri Oct 21 17:04:58 2016 +0200
Bug 17481: Fix incorrect merge of bug 11048 (logout redirection for CAS authentication)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 9a301836714924581b806cd7c728695625ddf3cc
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Nov 4 12:18:57 2016 -0300
Bug 17494: (QA followup) Fix exception name
This patch changes the exception name to match the package name. And
also adds a test for the thrown exception message.
Also creates a general Koha::Exception::Patron::Modification exception
to make the new one inherit from it, following the common use in the codebase.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit d76cd8a63946572508f4a7d8b8ee8d06c63ddb09
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Oct 31 11:15:02 2016 +0000
Bug 17494: Prevent duplicate tokens from getting stored
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 5f160f675b1de4a12db6717b297c3d7b0a7a5d3d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Oct 27 10:04:30 2016 +0200
Bug 17494: Make sure the same verification token won't be generated twice
Well, this patch does not enforce the unique constraint but mimic what
is already done in C4::ImportExportFramework and Koha::Upload where
md5_hex is used.
Test plan:
Have a look at the code and confirm that it adds more randomness to the
hashed string
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit c3177f41adb60a03b7683ba8e82be43e4375c449
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed Jun 8 10:53:25 2016 +0000
Bug 16493: [QA Followup] Restore title and author match as an option, make it the default
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 8afa5e550f4add3f451c4dfaf4bfad6703b3e1c3
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed May 11 14:19:41 2016 +0000
Bug 16493: acq matching on title and author
When you order from a staged file you're getting duplicate warnings that
are inaccurate. For example, when you order a file of 50 DVDs for
example and they don't have ISBNs they're matching on the books. And
then you have to order them one by one.
This patch replaces the use of FindDuplicates with Koha's match point
system. This means you can select from the same match points defined
and used in the batch record importer, or you can opt to skip matching
altogether!
Test Plan:
1) Import a record with a title, isbn and author.
2) Delete the from the record and stage it again
3) Attempt to add it to a basket via the staged record
4) You should note the gives you the "No records imported" message
5) Apply this patch
6) Create a matcher for ISBN
7) Create a matcher for Author/Title
8) Attempt to add the record to your basket using the ISBN matcher
8) Koha should find no match and import the record to the basket
9) Stage the record again
10) Attempt to add the record to your basket using the Title/Author matcher
11) You should recieve the "No records imported" message.
Signed-off-by: Barbara Fondren <bfondren at roundrocktexas.gov>
Signed-off-by: Nicole C Engard <nengard at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 6155325b7f1cd2615e2ec8f1bf6ebfe96db60881
Author: Hector Castro <hector.hecaxmmx at gmail.com>
Date: Tue Jun 21 13:24:20 2016 -0600
Bug 16792: Add Font Awesome Icon and mini button to Keyword to MARC mapping section
Improve Admin > Keyword to MARC mapping to fit with others interfaces in Koha.
This bug change "Delete" link with a mini-button and introduce the trash icon.
To test:
-Apply patch
-Goto Admin > Keyword to MARC mapping
-Select one framework
-Add some mappings
-Notice about the new button with trash icon
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 81f56f959d873d95be4402da425dd2c908abe89e
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Nov 3 10:17:32 2016 -0300
Bug 17544 - : Remove t::lib::Mocks dependency from populate_db.pl
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 5a8ae34a4ae24f68b946ef8132f5f251497bcb44
Author: Nightly Build Bot <nightly at abunchofthings.net>
Date: Sat Oct 29 00:59:58 2016 +0200
Bug 17084 - Automatic debian/control updates (unstable)
Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit a2dd8a8428c940a5f1a78baa632e9fe89c6e7fdd
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Aug 9 10:14:02 2016 -0400
Bug 16991: Add subtitle to holds to pull report
This patch adds output of subtitle to the holds to pull report using
keyword to MARC mapping information.
To test, apply the patch and go to Circulation -> Holds to pull. The
list of holds to pull should display subtitles.
Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Subtitle added using keyword to MARC mapping with default framework.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Mason James <mtj at kohaaloha.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Auth_with_cas.pm | 1 -
C4/Circulation.pm | 41 +-
C4/Items.pm | 37 +-
C4/Members.pm | 6 +
C4/Search.pm | 13 +-
INSTALL | 161 +--
INSTALL.debian | 396 ------
INSTALL.fedora7 | 1267 ------------------
INSTALL.opensuse | 1375 --------------------
INSTALL.ubuntu | 699 ----------
Koha.pm | 2 +-
Koha/AudioAlert.pm | 23 +-
Koha/Exceptions/Patron/Modification.pm | 16 +
Koha/ItemType.pm | 4 -
Koha/ItemTypes.pm | 4 -
Koha/Schema/Result/Item.pm | 2 +-
Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 2 +-
Koha/SearchEngine/Elasticsearch/Search.pm | 12 +-
acqui/addorderiso2709.pl | 15 +-
catalogue/search.pl | 7 +-
circ/pendingreserves.pl | 6 +
debian/control | 2 +
debian/scripts/koha-create | 2 +
debian/templates/apache-shared-intranet-plack.conf | 1 +
installer/data/mysql/atomicupdate/bug17663.perl | 26 +
installer/data/mysql/updatedatabase.pl | 57 +
installer/data/mysql/userpermissions.sql | 2 +
.../prog/en/includes/checkouts-table.inc | 4 +-
.../en/includes/member-alt-address-style-de.inc | 2 +-
.../en/includes/member-alt-address-style-us.inc | 2 +-
.../prog/en/modules/acqui/addorderiso2709.tt | 36 +-
.../prog/en/modules/admin/auth_tag_structure.tt | 4 +-
.../prog/en/modules/admin/fieldmapping.tt | 2 +-
.../prog/en/modules/admin/itemtypes.tt | 12 +-
.../en/modules/admin/marc_subfields_structure.tt | 4 +-
.../prog/en/modules/admin/preferences/patrons.pref | 2 +-
.../prog/en/modules/cataloguing/addbooks.tt | 4 +-
.../prog/en/modules/circ/pendingreserves.tt | 2 +-
.../prog/en/modules/circ/view_holdsqueue.tt | 12 +-
.../intranet-tmpl/prog/js/pages/circulation.js | 3 +-
members/moremember.pl | 2 +-
misc/devel/populate_db.pl | 1 -
misc/export_records.pl | 2 +-
.../koha3-opac-button-background.png | Bin 29387 -> 0 bytes
.../koha3-opac-button-background.psd | Bin 39476 -> 0 bytes
.../koha3-opac-button-background.svg | 120 --
misc/sax_parser_print.pl | 2 +-
opac/opac-memberentry.pl | 7 +-
opac/opac-search.pl | 6 +-
reports/guided_reports.pl | 1 +
t/Biblio/Isbd.t | 4 +-
t/DateUtils.t | 23 +-
t/Members/cardnumber.t | 19 +-
t/db_dependent/Acquisition/CancelReceipt.t | 27 +-
t/db_dependent/Acquisition/OrderUsers.t | 12 +-
t/db_dependent/Auth_with_ldap.t | 10 +-
t/db_dependent/Circulation.t | 53 +-
t/db_dependent/Circulation/CheckIfIssuedToPatron.t | 26 +-
t/db_dependent/Circulation/GetIssues.t | 84 +-
t/db_dependent/Circulation/IsItemIssued.t | 25 +-
.../Circulation/IssuingRules/maxsuspensiondays.t | 8 +-
t/db_dependent/Circulation/Returns.t | 284 +++-
t/db_dependent/Circulation/issue.t | 183 ++-
t/db_dependent/Circulation/transfers.t | 91 +-
t/db_dependent/DecreaseLoanHighHolds.t | 8 +-
t/db_dependent/Exporter/Record.t | 7 +-
t/db_dependent/Holds/LocalHoldsPriority.t | 33 +-
t/db_dependent/Items.t | 86 +-
.../Koha_SearchEngine_Elasticsearch_Search.t | 24 +-
t/db_dependent/Koha_borrower_modifications.t | 21 +-
t/db_dependent/Members/IssueSlip.t | 42 +-
t/db_dependent/Patron/Borrower_Discharge.t | 19 +-
t/db_dependent/Search.t | 36 +-
tools/export.pl | 2 +-
74 files changed, 1072 insertions(+), 4464 deletions(-)
delete mode 100644 INSTALL.debian
delete mode 100644 INSTALL.fedora7
delete mode 100644 INSTALL.opensuse
delete mode 100644 INSTALL.ubuntu
create mode 100644 Koha/Exceptions/Patron/Modification.pm
create mode 100644 installer/data/mysql/atomicupdate/bug17663.perl
delete mode 100644 misc/interface_customization/koha3-opac-button-background.png
delete mode 100644 misc/interface_customization/koha3-opac-button-background.psd
delete mode 100644 misc/interface_customization/koha3-opac-button-background.svg
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list