[koha-commits] main Koha release repository branch 16.11.x updated. v16.11.00-26-g10755f1

Mon Dec 12 23:46:50 CET 2016

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 16.11.x has been updated
       via  10755f1c74b442289c1229caf4cfdda6a3bb32ad (commit)
       via  317bd60f18b3ceaec91709ec56f26c27f16359b9 (commit)
       via  ff33093591f903c22e251ba694ed59d8a0fb7500 (commit)
       via  c6b0b9cf1b46027e44cee0730befa8d8ac40efbd (commit)
       via  a5ce343c9d7d8790a8dbd98b3833ea6cf155c180 (commit)
       via  5e9056a99cf37acad6c2d4fe5f3ebd1f61171327 (commit)
       via  aa5c67486f297dbdaa1ba7b6665916a3d2cc05f5 (commit)
      from  4b2dfed916567b13ddc406695858963ebf2aae6b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 10755f1c74b442289c1229caf4cfdda6a3bb32ad
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Dec 5 11:19:12 2016 -0300

    Bug 17722: Make PatronLists.t run inside a transaction

    This patch makes t/db_dependent/PatronLists.t run inside a transaction.
    It also makes it generate its own data using t::lib::TestBuilder instead
    of relying on sample patrons on the DB.

    To test:
    - Run:
      $ prove t/db_dependent/PatronLists.t
    => SUCCESS: Tests pass
    - Apply the patch
    - Run:
      $ prove t/db_dependent/PatronLists.t
    => SUCCESS: Tests pass
    - Sign off :-D

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    (cherry picked from commit 427ba8b0c7f7a976e3c90a4f811836532e0f3875)
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

commit 317bd60f18b3ceaec91709ec56f26c27f16359b9
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Dec 8 17:19:03 2016 +0000

    Bug 14541 (QA followup) Add warning to gist system preference

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    (cherry picked from commit 36c608ab846c97aa76ea2fd721c7ce09f2c638ed)
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

commit ff33093591f903c22e251ba694ed59d8a0fb7500
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Nov 9 09:13:27 2016 +0000

    Bug 14541: Do not truncate tax rate values

    Tax rates are stored in decimal(6,4) fields which means that 4 decimals
    are allowed.
    If a tax rate is 8.42%, it is stored as 0.0842
    If a tax rate has more precision than that, Koha won't deal correctly
    with it. We will need to update the DB structure.

    With this patch, the tax rate will be displayed with the same precision
    as in the DB. So if you enter 8.42, you will see 8.42% instead of 8.4%
    without this patch.

    Test plan:
    Do a full acquisition workflow with a tax rate like 8.42% and confirm
    that it is correctly displayed.

    Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    (cherry picked from commit cb3d6625e87fbc861c11e181cea36f9f9cd329cc)
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

commit c6b0b9cf1b46027e44cee0730befa8d8ac40efbd
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Nov 22 15:28:04 2016 +0000

    Bug 17668: Fix typo in parcel.pl - listinct vs listincgst

    This typo has been introduced by
      commit eed14b080db8691f371b4c19f1a190b87fcc396a
        Bug 13001: Refactor VAT and price calculation - parcel page
    So before the tax rewrite (13321, 13323).
    It sounded weird to me that testers did not catch the bug on this page.

    To understand the logic:
    Conditions are listincgst, invoiceincgst
    Conditions | Before this patch |  If we fix the typo  | After this patch
     0     0   |    excluded       |    excluded          |   excluded
     0     1   |    included       |    included          |   included
     1     0   |    excluded       |    excluded          |   excluded
     1     1   |    included       |    included          |   included

    Test plan:
    Create 4 vendors with the difference combinations
    Create a basket, add an order (with a tax) and receive it
    Confirm that the different values displayed on the parcel page are correct

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    (cherry picked from commit 3e112f3837346b500ce863a248920d3207e27131)
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

commit a5ce343c9d7d8790a8dbd98b3833ea6cf155c180
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Nov 23 10:06:04 2016 +0000

    Bug 15822: Fix 500 error when searching if items.onloan=0000-00-00

    The calls
      output_pref({ dt => dt_from_string( $date ) })
    are wrong and should be replaced with
      output_pref({ str => $date })
    For better error handling.

    Here we fix the problem of items.onloan when searching

    Test plan:
    - Set items.onloan=0000-00-00 (UPDATE items SET onloan='0000-00-00')
    This can come from old data or bad migration
    - Execute a search
    => Without this patch you get
    Can't locate object method "ymd" via package "dateonly" (perhaps you forgot to load "dateonly"?) at /home/vagrant/kohaclone/Koha/DateUtils.pm line 225.
    => With this patch you won't get the error

    Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    (cherry picked from commit 167c74bfd386287783e101989b804077b1020369)
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

commit 5e9056a99cf37acad6c2d4fe5f3ebd1f61171327
Author: David Cook <dcook at prosentient.com.au>
Date:   Mon May 23 11:57:04 2016 +1000

    Bug 16376 - Koha::Calendar->is_holiday date truncation creates fatal errors for TZ America/Santiago

    Using a DateTime object with a timezone of America/Santiago
    was causing fatal errors for Koha::Calendar->is_holiday
    and Koha::Calendar->exception_holidays, when the objects
    were truncated to an invalid local time.

    Using a floating zone allows us to use the same day, month, year
    for comparison purposes without running into the possibility of
    creating an invalid local time and thus a fatal software error.

    Edit:

    While the changes to is_holiday and single_holiday make sense (Jonathan agrees too)
    I didn't manage to have them fail, because truncate is not failing in my trials, but
    days_between. So to me, it narrows down to have exception_holiday return floating tz
    datetime objects so it doesn't break days_between.

    Anyway, it is ok to push this patch, and the regression test I provide covers this scenario
    I'm describing.

    To test:
    - Apply the regression tests patch
    - Run:
      $ prove t/db_dependent/Holidays.t
    => FAIL: Unexpected error due to bad timezone/date combination
    - Apply this patch
    - Run:
      $ prove t/db_dependent/Holidays.t
    => SUCCESS: Tests pass

    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    (cherry picked from commit 32354d8322afd05704d87cb38d9bc032ce8c4ec1)
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

commit aa5c67486f297dbdaa1ba7b6665916a3d2cc05f5
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Tue Dec 6 11:29:08 2016 -0300

    Bug 16376: (regression tests)

    This patch introduces a regression test for exception_holidays. This routine
    returns a list of datetimes to be used in date comparison and some datetimes don't exist
    in some timezones, so floating timezones should be used instead.

    To test:
    - Apply the patch on master
    - Run:
      $ prove t/db_dependent/Holidays.t
    => FAIL: The new test fails

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    (cherry picked from commit c6a0848ff0b7acbec4d7bf817447d7cc84c0615e)
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-----------------------------------------------------------------------

Summary of changes:
 C4/Search.pm                                       |    2 +-
 Koha/Calendar.pm                                   |    6 ++-
 acqui/parcel.pl                                    |   16 +++----
 .../intranet-tmpl/prog/en/modules/acqui/basket.tt  |    6 +--
 .../intranet-tmpl/prog/en/modules/acqui/invoice.tt |    4 +-
 .../prog/en/modules/acqui/neworderempty.tt         |    4 +-
 .../prog/en/modules/acqui/orderreceive.tt          |    4 +-
 .../intranet-tmpl/prog/en/modules/acqui/parcel.tt  |    2 +-
 .../prog/en/modules/acqui/supplier.tt              |    6 +--
 .../en/modules/admin/preferences/acquisitions.pref |    1 +
 t/db_dependent/Holidays.t                          |   50 ++++++++++++++++++--
 t/db_dependent/PatronLists.t                       |   43 +++++++++++++----
 12 files changed, 105 insertions(+), 39 deletions(-)

hooks/post-receive
-- 
main Koha release repository