[koha-commits] main Koha release repository branch master updated. v16.11.00-83-g430542a
Git repo owner
gitmaster at git.koha-community.org
Fri Dec 16 15:42:23 CET 2016
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 430542ad55368ffeb038c0425dafd5fb2477c292 (commit)
via 631d3006bc2a9e5f876bb9cefb5dbc0f44c9dd11 (commit)
via b59df2bce788bc5cc3b184c9c74688dd745a2fb0 (commit)
via 69018a7930928c141b3bc1a192f450b1dd5bf6a7 (commit)
via 43dda643817b6bb83c27fd257532d2b4a2593592 (commit)
via 5a0a2ce584dec74808f471b0f92b2114c3d6029e (commit)
via 41493004f69caf471e8d73b7db2a64e433f57465 (commit)
via 4e78f1000de2cfa6a9cc434a4605d3e4ed6742d1 (commit)
via d1e7bbc602039da4443405cf710d2203fc7685ce (commit)
via fbb50b517f38682ce0f95ccc5a73604969463e4b (commit)
via 492280102fdc61568e1c7fbf9f464a852ac12c2c (commit)
from ca5fb693627a46aac06b40d6bc2ee1d7f3781340 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 430542ad55368ffeb038c0425dafd5fb2477c292
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Dec 16 13:14:50 2016 +0000
Bug 17578 [QA Followup] - Update number of tests
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 631d3006bc2a9e5f876bb9cefb5dbc0f44c9dd11
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Nov 29 19:20:13 2016 +0100
But 17578: (followup) amountoutstanding
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit b59df2bce788bc5cc3b184c9c74688dd745a2fb0
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Nov 8 11:03:54 2016 +0100
Bug 17578: GetMemberDetails - Remove GetMemberDetails
All the values different from the ones GetMember returned has been
managed outside of GetMemberDetails.
It looks safe to replace all the occurrences of GetMemberDetails with
GetMember.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 69018a7930928c141b3bc1a192f450b1dd5bf6a7
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Nov 8 09:47:53 2016 +0000
Bug 17578: GetMemberDetails - Remove enrolmentperiod
This value is not used anywhere
Test plan:
git grep enrolmentperiod| grep -v installer| grep -v translator|vim -
should show you that I am right
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 43dda643817b6bb83c27fd257532d2b4a2593592
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Nov 8 09:46:15 2016 +0000
Bug 17578: GetMemberDetails - Remove reservefee
Same as other patches, reservefee is only used in opac-reserve.pl
Test plan;
Set reserve fee for a patron category
Place a hold at the OPAC with one of these patrons.
You must get a message about the reserve fee.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 5a0a2ce584dec74808f471b0f92b2114c3d6029e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Nov 7 18:14:49 2016 +0100
Bug 17578: GetMemberDetails - Remove is_expired
The is_expired value is used in 2 places, let's use
Koha::Patron->is_expired instead.
Test plan:
Depending on the different value of BlockExpiredPatronOpacActions for
the patron category, a patron must be blocked if he has expired.
Confirm that behavior from opac-renew and opac-reserve scripts
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 41493004f69caf471e8d73b7db2a64e433f57465
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Nov 7 16:52:54 2016 +0000
Bug 17578: GetMemberDetails - Remove flags
Same as authflags, a flags key is set containing all the patron flags.
It is only used in a few places and it's better to call
C4::Members::patronflags when we need it.
Test plan:
Look at the diff and confirm that the change make sense
Use git grep to confirm we do not use the flags somewhere else.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 4e78f1000de2cfa6a9cc434a4605d3e4ed6742d1
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Nov 7 16:16:04 2016 +0000
Bug 17578: GetMemberDetails - Remove amountoutstanding
The amountoutstanding value set by GetMemberDetails was only used in a
few places. In that case it makes sense to only retrieve it when needed.
Test plan:
1/ Add fines to a patron, on the OPAC patron info page, you should see a
"Fines" tab
2/ Add credit to a patron, you should see the credit displayed
3/ Set the pref maxoutstanding to 3
4/ Add a fine of 4 to a patron
5/ Try to place an hold for this patron
=> You should get a "too much oweing" message
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit d1e7bbc602039da4443405cf710d2203fc7685ce
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Nov 7 17:01:03 2016 +0100
Bug 17578: GetMemberDetails - Remove authflags - 2
This script is not used from the Koha codebase and does not seem very
useful.
We could rewrite it if needed later (ie. if someone complains I will
rewrite it).
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit fbb50b517f38682ce0f95ccc5a73604969463e4b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Nov 7 17:02:55 2016 +0100
Bug 17578: GetMemberDetails - Remove authflags - 1
GetMemberDetails create a authflags key, but this key is only used from
2 different places.
One is a very simple script, which does not seem very usefull
C4/SIP/interactive_members_dump.pl. I propose to simply remove it.
The other one is the member-flags.pl script. What is done in this one is
a bit weird since we a doing twice the same query (it was not highlighted
before this patch). We will need to fix that later.
At the moment the goal it to remove the GetMemberDetails subroutine
without introducing any regressions (and so without adding big changes)
Test plan:
Select/unselect permissions for a patron, save and edit again.
The behavior of the permission checkboxes should be ok
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 492280102fdc61568e1c7fbf9f464a852ac12c2c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Nov 7 15:53:25 2016 +0000
Bug 17578: GetMemberDetails - Remove BlockExpiredPatronOpacActions
The correct way to get the value of BlockExpiredPatronOpacActions from a
patron object is to get the patron category then call the
effective_BlockExpiredPatronOpacActions:
$patron->category->effective_BlockExpiredPatronOpacActions
So this patch applies this change and remove this value from the
GetMemberDetails subroutine.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Circulation.pm | 24 ++---
C4/ILSDI/Services.pm | 18 ++--
C4/Members.pm | 103 --------------------
C4/SIP/ILS/Patron.pm | 10 +-
C4/SIP/interactive_members_dump.pl | 22 -----
circ/circulation.pl | 8 +-
.../opac-tmpl/bootstrap/en/modules/opac-user.tt | 12 +--
members/deletemem.pl | 4 +-
members/member-flags.pl | 22 +++--
members/purchase-suggestions.pl | 2 +-
members/routing-lists.pl | 2 +-
members/statistics.pl | 2 +-
misc/export_borrowers.pl | 7 +-
opac/opac-account-pay-paypal-return.pl | 2 +-
opac/opac-readingrecord.pl | 2 +-
opac/opac-renew.pl | 9 +-
opac/opac-reserve.pl | 19 ++--
opac/opac-showreviews.pl | 4 +-
opac/opac-suggestions.pl | 2 +-
opac/opac-user.pl | 16 +--
opac/sco/sco-main.pl | 6 +-
t/db_dependent/Acquisition/OrderUsers.t | 2 +-
t/db_dependent/Members.t | 26 +----
t/db_dependent/rollingloans.t | 2 +-
tools/viewlog.pl | 4 +-
25 files changed, 103 insertions(+), 227 deletions(-)
delete mode 100755 C4/SIP/interactive_members_dump.pl
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list