[koha-commits] main Koha release repository branch master updated. v16.11.00-106-g4c5f495

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  4c5f495f0e0f2b7852908d84764b3be0ac02a90f (commit)
      from  8e68e41df448e9bde7baf69ebab2646d2138cca4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4c5f495f0e0f2b7852908d84764b3be0ac02a90f
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date:   Fri Dec 2 04:08:45 2016 +0000

    Bug 17208: Checking if classification source or filing rule already exists before adding
    
    To test:
    1) Go to Admin -> Classification sources
    2) Attempt to reproduce bug before applying patch. Notice the message
    saying the add was successful, but was not added to the table
    3) Apply patch and refresh page (restart plack if necessary)
    4) Add new classification source with same code as existing one. Notice
    you are now told that the add failed.
    5) Confirm adding new classification source with unique code works
    6) Add new classification filing rule with same code as existing one.
    Notice you are told that add failed.
    7) Confirm adding new classification filing rule with unique code works
    
    Sponsored-by: Catalyst IT
    
    Followed test plan, works as expected.
    Signed-off-by: Marc Véron <veron at veron.ch>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    This is not the way to go, we should use an eval instead.
    But since we do not have RaiseError set, it will not work.
    This module will need to be moved to Koha::Objects to be implemented
    correctly.
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/ClassSource.pm                                      |   12 ++++++++++--
 admin/classsources.pl                                  |   16 ++++++++++++----
 .../prog/en/modules/admin/classsources.tt              |    6 ++++++
 3 files changed, 28 insertions(+), 6 deletions(-)


hooks/post-receive
-- 
main Koha release repository