[koha-commits] main Koha release repository branch master updated. v16.11.00-120-g2fe2ef4

Fri Dec 23 13:07:44 CET 2016

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  2fe2ef41bd8bf2f142597e39f493edbdbf75c8a3 (commit)
       via  c5ca94df995ee7543350bf1bab3a1c80b923340f (commit)
       via  401f01125c23fe54e7697b0c22619c4d8e728b12 (commit)
       via  1ad30e63ea5e1d574d7cf82e86948ef501920d64 (commit)
       via  5b35c8e038a49a4e998656c60ba08e88dd982498 (commit)
       via  f708b2e8d1f52efbbca9728d1cd7262a6fc0722c (commit)
      from  7ecd9e330481389d523da27f962e8e5242c1bbfa (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 2fe2ef41bd8bf2f142597e39f493edbdbf75c8a3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Dec 20 18:07:40 2016 +0100

    Bug 17783: Replace ok with is

    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit c5ca94df995ee7543350bf1bab3a1c80b923340f
Author: Lari Taskula <lari.taskula at jns.fi>
Date:   Tue Dec 20 16:54:44 2016 +0200

    Bug 17783: Prevent crash when providing an undefined value

    When calling the proposed version of get_effective_issuing_rule with undefined
    parameter values, a following crash occurs:

    SQL::Abstract::puke(): [SQL::Abstract::__ANON__] Fatal: SQL::Abstract before v1.75
    used to generate incorrect SQL when the -IN operator was given an undef-containing
    list: !!!AUDIT YOUR CODE AND DATA!!! (the upcoming Data::Query-based version of
    SQL::Abstract will emit the logically correct SQL instead of raising this
    exception) at /home/ubuntu/kohaclone/Koha/Objects.pm line 182

    This patch adds a test to cover this problem and fixes the issue.

    To test:
    1. Run t/db_dependent/Koha/IsssuingRules.t

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 401f01125c23fe54e7697b0c22619c4d8e728b12
Author: Lari Taskula <lari.taskula at jns.fi>
Date:   Thu Dec 15 19:31:30 2016 +0200

    Bug 17783: Optimize Koha::IssuingRules->get_effective_issuing_rule

    This patch modifies method get_effective_issuing_rule in Koha::IssuingRules
    aiming to optimize the search for matching issuing rule.

    Before this patch, in worst case scenario, we have had to make a SELECT query
    eight times. This will have a negative impact on performance where-ever we need
    to find matching issuing rule multiple times, if the search is not directly
    matching an issuing rule on the first query.

    This patch makes get_effective_issuing_rule have a stable performance on both
    best and worst case, whereas the old method was really fast on the best case
    and really slow on the worst case.

    However, this patch slightly lowers the performance for best case, where matching
    issuing rule is found instantly before (branchcode, categorycode and itemtype all
    are specifically defined in issuing rules). For all other cases this patch offers
    a performance improvement.

    To test:
    1. Run t/db_dependent/Koha/IssuingRules.t and compare the results with previous
       tests.

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 1ad30e63ea5e1d574d7cf82e86948ef501920d64
Author: Lari Taskula <lari.taskula at jns.fi>
Date:   Thu Dec 15 19:28:38 2016 +0200

    Bug 17783: Add Koha::Objects->single

    Returns one and only one object that is part of this set.
    Returns undef if there are no objects found.

    ->single is faster than ->search->next

    This is optimal as it will grab the first returned result without instantiating
    a cursor.

    It is useful for this Bug as we only want to select the top row of found issuing
    rules.

    To test:
    1. Run t/db_dependent/Koha/Objects.t

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 5b35c8e038a49a4e998656c60ba08e88dd982498
Author: Lari Taskula <lari.taskula at jns.fi>
Date:   Thu Dec 15 18:35:13 2016 +0200

    Bug 17783: Test to print performance of get_effective_issuing_rule

    This test prints the amount of issuing rule matches per second for
    1. worst case, when non-existent branchcode, categorycode and itemtype is
       being searched (currently 8 queries)
    2. mid case (rule found on 4th query)
    3. 2nd best case (rule found on 2nd query)
    4. best case, when an issuing rule is defined for exactly those branchcode,
       categorycode and itemtype (currently 1 query)

    To test:
    1. Run t/db_dependent/Koha/IssuingRules.t
    2. Write down the per-second amount to compare with next patch

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit f708b2e8d1f52efbbca9728d1cd7262a6fc0722c
Author: Lari Taskula <lari.taskula at jns.fi>
Date:   Thu Dec 15 17:58:39 2016 +0200

    Bug 17783: Test to confirm correct effective issuing rule selection

    This patch adds a test to cover the validity of effective issuing rule selection
    in correct order.

    To test:
    1. Run t/db_dependent/Koha/IssuingRules.t

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/IssuingRules.pm               |   92 ++++---------
 Koha/Objects.pm                    |   26 +++-
 t/db_dependent/Koha/IssuingRules.t |  253 ++++++++++++++++++++++++++++++++++++
 t/db_dependent/Koha/Objects.t      |   13 +-
 4 files changed, 315 insertions(+), 69 deletions(-)
 create mode 100644 t/db_dependent/Koha/IssuingRules.t

hooks/post-receive
-- 
main Koha release repository