[koha-commits] main Koha release repository branch master updated. v16.11.00-124-gea7bd9c

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  ea7bd9c4ada6eb6f03d37e43cce89d1431293761 (commit)
      from  0747a11b2648a20fcca9d3f5e02a4b3b9270b3f3 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit ea7bd9c4ada6eb6f03d37e43cce89d1431293761
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Sep 5 09:54:35 2016 +0100

    Bug 17246: Do no support arrayref to define multiple FK
    
    Currently you can call GetPreparedLetter like:
    
    $prepared_letter = GetPreparedLetter(
        (
            module      => 'test',
            letter_code => 'TEST_HOLD',
            tables      => {
                reserves => [ $fk1, $fk2 ],
            },
        )
    );
    
    It assumes that $fk1 is a borrowernumber and $fk2 a biblionumber.
    It seems hazardous to do this guess.
    
    I suggest to remove this feature and only allow hashref indeed.
    
    Test plan:
    Use different way to generate letters and make sure you do not reach the croak
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Letters.pm                            |    5 +----
 t/db_dependent/Letters/TemplateToolkit.t |   19 +++++++++++++++++--
 2 files changed, 18 insertions(+), 6 deletions(-)


hooks/post-receive
-- 
main Koha release repository