[koha-commits] main Koha release repository branch master updated. v16.11.00-129-g2c67648

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  2c67648093b9e7479b1dd1135c80ada2d46aee7c (commit)
      from  853d355576698d1643080ef37b797e937338a1f8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 2c67648093b9e7479b1dd1135c80ada2d46aee7c
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Dec 22 14:00:37 2016 +0000

    Bug 17781 - Improper branchcode set during renewal
    
    For no discernable reason, when AddIssue calls AddRenewal, it passes the
    branchcode generated from _GetCircControlBranch. Assume
    _GetCircControlBranch is set to return items.homebranch. So:
    1) If an item owned by LibraryA is checked out at LibraryB, the
      statistic line branchcode will be LibraryB
    2) If an item is renewed via the ajax datatables renewal function, the
      statistic line branchcode will be LibraryB the
    3) If an item is renewed via scanning the item into the checkout again,
      statistic line branchcode will be *LibraryA*
    
    This is clearly improper behavior. The renewal is taking place at
    LibraryB, so the branchcode passed to AddRenewal should be LibraryB,
    the logged in library. This also jives with the documentation for
    the subroutine.
    
    Test Plan:
    1) Set CircControl to "the library the item is from" aka ( ItemHomeLibrary )
    2) Set HomeOrHoldingBranch to 'The library the items is from" ( aka homebranch )
    3) Create item with homebranch of LibraryA and holdingbranch of LibraryB
    4) Set the logged in library to LibraryB
    4) Check the item out to a patron at LibraryB
    5) Note the statistics line has a branchcode of LibraryB
    6) Check the item out again to trigger a renewal, renew the item
    7) Note the statistic line has a branchcode of LibraryA!
    8) Apply this patch
    9) Repeat step 6
    10) Note the statistics line has a branchcode of LibraryB!
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: David Kuhn <kuhn at monterey.org>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm                  |   22 +++++++++++++---------
 t/db_dependent/Circulation/issue.t |   26 +++++++++++++++++++++-----
 2 files changed, 34 insertions(+), 14 deletions(-)


hooks/post-receive
-- 
main Koha release repository