[koha-commits] main Koha release repository branch master updated. v16.11.00-137-g02e2a42

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  02e2a4261c4691f37f3abe086ff990e0ab505282 (commit)
      from  8f8e908061c07cb9f22ad338bb05bc95cb691bf6 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 02e2a4261c4691f37f3abe086ff990e0ab505282
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Nov 25 11:52:11 2016 +0100

    Bug 17679: C4::Circulation - Remove unused GetItemIssues
    
    Ready for an archaeology course?
    
    C4::Circulation::GetItemIssues is only used once, from
    catalogue/issuehistory.pl
    This call has been added by
      commit 95d6452462a560ba0c0ac859a2cfb7783c25c925
        Adding some more information on issuehistory.
    which says "Adding itemnumber to issuehistory.pl API so that one could search
    for issuehistory of a specific item."
    So it added the ability to see the item issue history but did not
    provide a way to access it via the interface.
    It's ok so far but this subroutine is broken since
      commit aa114f53499b9cffde0571fe7e08622f9c9a332a
        Bug 5549 : Only use DateTime for issues table
    because of this change:
    -    my $today = C4::Dates->today('iso');
    +    my $today = DateTime->now( time_zome => C4::Context->tz);
    
    I let you catch the typo ;)
    And since this commit the subroutine explodes with "The following
    parameter was passed in the call to DateTime::from_epoch but was not
    listed in the validation options: time_zome"
    
    Since it has never been raised by someone and that the feature is
    hidden, I'd recommend to simply remove it.
    
    Note that the "Checked out from" column would have been wrong even if we
    fixed all the previous issue.
    
    Test plan:
    Just dig into the code and confirm what this commit message tells
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Looks fine for me.
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm                  |   48 ------------------------------------
 catalogue/issuehistory.pl          |   22 +++--------------
 t/db_dependent/Circulation/issue.t |    5 ----
 3 files changed, 3 insertions(+), 72 deletions(-)


hooks/post-receive
-- 
main Koha release repository