[koha-commits] main Koha release repository branch master updated. v16.11.00-153-gf43a735
Git repo owner
gitmaster at git.koha-community.org
Fri Dec 30 12:59:30 CET 2016
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via f43a73597e17687cfcf3ca0069d621b712eff57c (commit)
via 4c00190250b8c290b6a03e4621ee6c282be0be62 (commit)
via f91fe7da2cf6ead81efcff49fbc7361229b99e6d (commit)
via 4f48dcc9f86e5fc3edbb4c22b7cc2ad2a87e1f04 (commit)
via c1e62ceaf7f6344460417a452bc5a013a41b1da9 (commit)
via da064f1387f255086249ad968632618695e9c008 (commit)
from d8cdceb2613bad6e43826233f0c635c0e34d718b (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit f43a73597e17687cfcf3ca0069d621b712eff57c
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Dec 2 10:30:55 2016 +0100
Bug 17569: [QA Follow-up] Small changes
Patron.pm: Adds two missing semicolons at the last statement. Not strictly
needed, but strongly recommended.
Patrons.t: Add a test description, remove two comments that refer to
previously hardcoded dates.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 4c00190250b8c290b6a03e4621ee6c282be0be62
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Nov 8 08:07:02 2016 +0000
Bug 17569: Do not limit by branch if option is not passed
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit f91fe7da2cf6ead81efcff49fbc7361229b99e6d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Nov 8 08:02:38 2016 +0000
Bug 17569: Remove C4::Members::GetUpcomingMembershipExpires
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 4f48dcc9f86e5fc3edbb4c22b7cc2ad2a87e1f04
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Nov 7 14:38:17 2016 +0000
Bug 17569: Koha::Patrons - Move GetUpcomingMembershipExpires to search_upcoming_membership_expires
This patchset moves the C4::Members::GetUpcomingMembershipExpires
subroutine code to the Koha::Patrons->search_upcoming_membership_expires
method.
This subroutine was used from only 1 place, so it's an easier to move.
Test plan:
Use the membership_expiry.pl cronjob script using the different
options.
The behavior should be the same as prior to this patch.
prove t/db_dependent/Koha/Patrons.t
should return green
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit c1e62ceaf7f6344460417a452bc5a013a41b1da9
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Nov 7 15:34:32 2016 +0100
Bug 17569: Move tests to the patron module test file
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit da064f1387f255086249ad968632618695e9c008
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Nov 7 13:18:54 2016 +0000
Bug 17569: Rewrite existing tests to make them reusable and more robust
In order not to cheat you, I am rewriting the tests in a separate
commit.
You can confirm that they pass with the other patches.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Members.pm | 49 -------
Koha/Patron.pm | 4 +-
Koha/Patrons.pm | 33 +++++
misc/cronjobs/membership_expiry.pl | 22 ++--
t/db_dependent/Koha/Patrons.t | 74 ++++++++++-
.../Members/GetUpcomingMembershipExpires.t | 136 --------------------
6 files changed, 122 insertions(+), 196 deletions(-)
delete mode 100644 t/db_dependent/Members/GetUpcomingMembershipExpires.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list