, matching other fields in the entry form which offer details about entry guidelines. To test, apply the patch and open the new patron entry form. Test for various values of CardnumberLength, and with 'cardnumber' mandatory or not mandatory as defined in BorrowerMandatoryField. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/members/memberentrygen.tt | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Feb 23 23:43:24 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 23 Feb 2016 22:43:24 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-551-gd9dc8be Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d9dc8be41780c3a4332f2fd50f80961d1653c49e (commit) from 9f172a3c1bc8c7cd1664eabac81c5b66877b3952 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d9dc8be41780c3a4332f2fd50f80961d1653c49e Author: Owen Leonard Date: Thu Feb 11 08:56:42 2016 -0500 Bug 15670 - Rename "Cancel" to "Cancel hold" when checking in a waiting item When checking in an on-hold item which is waiting, the "Cancel" button cancels the hold, so it should say so. This patch changes the text. This patch also moves the 'cancel hold' button to the middle, on the theory that buttons on the left should default to 'confirm' and buttons on the right should generally imply 'cancel'--as in 'do nothing.' Moving it to the middle seems like a good place to put it where users will have to think about clicking it. To test: 1. Find an hold which has been made 'waiting,' or check in an confirm a pending hold at your library. 2. Check in that item again and verify that the 'Hold found' dialog contains a 'Cancel hold' button which works to cancel the waiting hold. 3. Repeat the process and confirm that the functionality of the other buttons is unchanged. Followed test plan, works as expected. Signed-off-by: Marc Veron Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Feb 23 23:48:23 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 23 Feb 2016 22:48:23 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-552-g4bf881d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 4bf881d32c41b54357949e4d37b1401b1324bc8e (commit) from d9dc8be41780c3a4332f2fd50f80961d1653c49e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4bf881d32c41b54357949e4d37b1401b1324bc8e Author: Aleisha Date: Tue Jan 26 02:57:38 2016 +0000 Bug 15663: Fix 'remove selected items', add a 'delete batch' button In this patch I have fixed the 'Remove selected items' button. I have also added a 'Delete batch' button like there is in the Patron Card Creator. To test: 1) Go to Tools -> Label creator -> New label batch 2) Add 2 items 3) Select the checkbox next to an item you just added and click 'Remove selected items' 4) A pop-up will say that you are yet to select an item. (Please ignore the mistake in the pop-up message, this is being fixed in Bug 15662) 5) Apply patch and refresh. Confirm there is now a 'Delete batch' button in the toolbar 6) Select one item and click 'Remove selected items' 7) Confirm the item is deleted from the batch 8) Select the final item and click 'Remove selected items' 9) Pop-up message will tell you that deleting this item will delete the batch. Click 'Okay' 10) Click 'Delete batch' then 'Okay' 11) Confirm you are redirected to the Labels page and the batch has been deleted. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/labels/label-edit-batch.tt | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 00:00:07 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 23 Feb 2016 23:00:07 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-553-g32e80f4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 32e80f456e62548b9dac7087908a6d72533fa0c8 (commit) from 4bf881d32c41b54357949e4d37b1401b1324bc8e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 32e80f456e62548b9dac7087908a6d72533fa0c8 Author: Lyon3 Team Date: Mon Jan 25 16:52:37 2016 +0100 Bug 15657 (follow-up bug 15501): add missing semi-colon Signed-off-by: Hector Castro The semicolon it's added Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 00:01:15 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 23 Feb 2016 23:01:15 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-555-geffe1e2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via effe1e27819a3b7d156e4abf5c96dd34d529246f (commit) via c76549dd7b4a090844a5a51664409417f9838923 (commit) from 32e80f456e62548b9dac7087908a6d72533fa0c8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit effe1e27819a3b7d156e4abf5c96dd34d529246f Author: Jonathan Druart Date: Wed Jan 27 10:33:24 2016 +0000 Bug 15605: Remove the cursor:pointer style. Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit c76549dd7b4a090844a5a51664409417f9838923 Author: Natasha Date: Wed Jan 20 02:11:37 2016 +0000 Bug 15605 - Accessibility: Can't tab to add link in serials routing list add user popup To Test - 1. Go to Serials and search for a title and then click on it. 2. Click routing list and then Add recipients. 3. Search for a patron. 4. Using the tab key try to navigate onto the Add link. 5. Notice it skips Add. 6. Apply the patch and then repeat steps 1-4, notice the Add link can now be accessed through using the keyboard. Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/serials/tables/members_results.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 00:08:00 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 23 Feb 2016 23:08:00 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-559-ge061b2b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e061b2b65cd0cfa1f9e1b51e9d7ea0550c2b6a4f (commit) via 100d800060c26378b91b465926a5993cb5596300 (commit) via 8b2573e24e50d2911d88aa6d9ec969b51f37284b (commit) via f4f307230ab0aeb3d28566dd0e5e9f7b851800b0 (commit) from effe1e27819a3b7d156e4abf5c96dd34d529246f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e061b2b65cd0cfa1f9e1b51e9d7ea0550c2b6a4f Author: Brendan Gallagher Date: Tue Feb 23 23:13:08 2016 +0000 DBRev for Bug 15517 - Tables borrowers and deletedborrowers differ again commit 100d800060c26378b91b465926a5993cb5596300 Author: Jonathan Druart Date: Mon Jan 11 08:35:11 2016 +0000 Bug 15517: Change wording for tests Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit 8b2573e24e50d2911d88aa6d9ec969b51f37284b Author: Jonathan Druart Date: Thu Jan 7 15:26:15 2016 +0000 Bug 15517: deleted* tables won't never differ anymore! These tests will ensure that the 4 deleted* tables won't never differ anymore. Test plan: 0/ Do not execute the update DB entry 1/ prove t/db_dependent/db_structure.t should fail 2/ Execute the update DB entry and update the schema with misc/devel/update_dbix_class_files.pl 3/ prove t/db_dependent/db_structure.t should now be happy Signed-off-by: Hector Castro Test pass successfuly. Works as advertised Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit f4f307230ab0aeb3d28566dd0e5e9f7b851800b0 Author: Jonathan Druart Date: Thu Jan 7 15:24:05 2016 +0000 Bug 15517: Resync borrowers and deletedborrowers tables The 2 columns password and userid are not sync and could cause errors when deleting patrons. Signed-off-by: Hector Castro Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/kohastructure.sql | 4 +-- installer/data/mysql/updatedatabase.pl | 12 +++++++++ t/db_dependent/db_structure.t | 43 ++++++++++++++++++++++++++++++++ 4 files changed, 58 insertions(+), 3 deletions(-) create mode 100644 t/db_dependent/db_structure.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 00:13:30 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 23 Feb 2016 23:13:30 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-560-g53a0812 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 53a081278d505b76efbd7c08dbe7d45649779740 (commit) from e061b2b65cd0cfa1f9e1b51e9d7ea0550c2b6a4f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 53a081278d505b76efbd7c08dbe7d45649779740 Author: Jesse Weaver Date: Wed Jan 27 16:39:22 2016 -0700 Bug 15514: Fix error with certain repeatable fields in Rancor Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/lib/koha/cateditor/koha-backend.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 00:19:43 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 23 Feb 2016 23:19:43 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-563-gd268d42 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d268d428fd984aeb76f617e0e93ef6fdea543230 (commit) via df4b1552211aae130b2ac31b44f45892c342e28c (commit) via 203659ee60b25614eecd01f69e23e3be57952707 (commit) from 53a081278d505b76efbd7c08dbe7d45649779740 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d268d428fd984aeb76f617e0e93ef6fdea543230 Author: Kyle M Hall Date: Thu Feb 11 04:29:55 2016 +0000 Bug 15479 [QA Followup] - Tidy sub to remove tabs causing qa script to fail Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit df4b1552211aae130b2ac31b44f45892c342e28c Author: Colin Campbell Date: Thu Jan 21 11:30:31 2016 +0000 Bug 15479 Add tests for ILS.pm This patch specifically adds a test for the sub added to resolve Bug 15479. As no test script existed to add this two added one which also tests that ILS objects can be instantiated correctly and offer the required interface NOTE: This does not apply without the first patch. Comment #3 suggested a unit test that would fail before and pass after. So while this code is good, it missed the before case. -- mtompset Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit 203659ee60b25614eecd01f69e23e3be57952707 Author: Colin Campbell Date: Wed Jan 6 12:56:24 2016 +0000 Bug 15479 Make ILS cardnumber comparison case insensitive The borrowers table is defined COLLATE=utf8_unicode_ci which means that cardnumbers may be saved in either lowercase or uppercase and these are considered equivalent. The server was performing a case sensitive comparison between the incoming patron identifier and that retrieved from the db As a result some renewals were rejected as being on loan to another borrower if the stored cardnumber differed in case. Make code comparison comply with db. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: C4/SIP/ILS.pm | 92 +++++++++++++++++++++++++++++++++++---------------------- t/SIPILS.t | 56 +++++++++++++++++++++++++++++++++++ 2 files changed, 113 insertions(+), 35 deletions(-) create mode 100755 t/SIPILS.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 00:56:05 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 23 Feb 2016 23:56:05 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-564-gadef1d1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via adef1d1020255373ec6f954bcd1a02e382305047 (commit) from d268d428fd984aeb76f617e0e93ef6fdea543230 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit adef1d1020255373ec6f954bcd1a02e382305047 Author: Jonathan Druart Date: Thu Jan 7 12:34:54 2016 +0000 Bug 15306: Do not display the translate link if only 1 language is installed It doesn't make sense to offer the option to translate an item type description into another language if there is only one language installed. Test plan: Generates templates for only 1 language Edit an item type and confirm that the link "translate into..." is not displayed. Generates templates for another language Confirm that the link is now displayed. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: admin/itemtypes.pl | 2 ++ koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 00:58:12 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 23 Feb 2016 23:58:12 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-568-gd929b0f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d929b0faa67808b98dbe28bdefef386c33dcf19a (commit) via d0950e61944628645c51b912e02f49732c599dd3 (commit) via 243b797dd11bc0ac1f475195ab765ffbf2220f8b (commit) via 2e4bf9f40e4523e29d241dceb22a114cc70d95ee (commit) from adef1d1020255373ec6f954bcd1a02e382305047 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d929b0faa67808b98dbe28bdefef386c33dcf19a Author: Jonathan Druart Date: Fri Jan 15 10:01:54 2016 +0000 Bug 15285: Fix conflict with the treetable plugin The tables using the treetable plugin don't display correctly (with JS error). The lazy way to fix it is to redefine the dom of the table and remove the button area (B). Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit d0950e61944628645c51b912e02f49732c599dd3 Author: Jonathan Druart Date: Mon Dec 14 12:18:33 2015 +0000 Bug 15285: Update for 3 specific tables The checkouts, currency and items lost tables redefine the dom/sDom and the older C(olvis) should be replaced with the current B(utton). Test plan: To test the whole patch set, you will have to test the 4 tables impacted by this patch as well as the others using the columns settings. The additem has specific code and should be tested keeping that in mind. Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit 243b797dd11bc0ac1f475195ab765ffbf2220f8b Author: Jonathan Druart Date: Mon Dec 14 12:17:43 2015 +0000 Bug 15285: Update common files This patch moves the Button area all tables which does not redefine the dom/sDom DT parameter. Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit 2e4bf9f40e4523e29d241dceb22a114cc70d95ee Author: Jonathan Druart Date: Mon Dec 14 12:15:58 2015 +0000 Bug 15285: Upgrade DataTables to 1.10.10 The ColVis DataTables plugin is now retired. We need to upgrade the plugin to 1.10.10 and use the column visibility module for Buttons. Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: C4/Utils/DataTables/ColumnsSettings.pm | 13 +- .../lib/jquery/plugins/buttons.colVis.min.js | 5 + .../lib/jquery/plugins/dataTables.buttons.min.js | 35 + .../lib/jquery/plugins/jquery.dataTables.colvis.js | 1013 -------------------- .../lib/jquery/plugins/jquery.dataTables.min.js | 319 +++--- .../prog/en/css/buttons.dataTables.min.css | 1 + .../prog/en/css/datatables.colvis.css | 77 -- .../prog/en/includes/columns_settings.inc | 18 +- .../intranet-tmpl/prog/en/includes/datatables.inc | 2 + koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js | 2 +- koha-tmpl/intranet-tmpl/prog/en/js/datatables.js | 2 +- .../prog/en/modules/acqui/acqui-home.tt | 1 + .../prog/en/modules/admin/aqbudgets.tt | 1 + .../prog/en/modules/admin/currency.tt | 10 +- .../prog/en/modules/reports/itemslost.tt | 2 +- 15 files changed, 240 insertions(+), 1261 deletions(-) create mode 100644 koha-tmpl/intranet-tmpl/lib/jquery/plugins/buttons.colVis.min.js create mode 100644 koha-tmpl/intranet-tmpl/lib/jquery/plugins/dataTables.buttons.min.js delete mode 100644 koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.dataTables.colvis.js create mode 100644 koha-tmpl/intranet-tmpl/prog/en/css/buttons.dataTables.min.css delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/css/datatables.colvis.css hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 01:02:02 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 00:02:02 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-570-g655e356 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 655e35649c1877224d184de2baf82e3a505ec999 (commit) via 47e78f5c290f14c2af53e747ebae7ec317a0dbbd (commit) from d929b0faa67808b98dbe28bdefef386c33dcf19a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 655e35649c1877224d184de2baf82e3a505ec999 Author: Kyle M Hall Date: Thu Jan 28 23:09:43 2016 +0000 Bug 14930 [QA Followup] - Allow OpacFineNoRenewals to be 0 Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit 47e78f5c290f14c2af53e747ebae7ec317a0dbbd Author: Gus Date: Tue Jan 19 03:12:48 2016 +0000 Bug 14930 - Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature To Test - Borrower has some fines and checkouts - Leave OPACFineNoRenewals empty/blank - Try to renew items in the OPAC - notice error message - Add a big value to OpacFineNoRenewals - notice renewals work Leaving the OPACFineNoRenewals empty will disable the feature. Patch works as expected.(Amended to format the commit message and to remove a warn on line 112 / MV) Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: opac/opac-user.pl | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 01:05:17 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 00:05:17 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-572-gf56ad87 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f56ad87648ddef5cba66a4cbae9efb53a221c09a (commit) via 0810027bfadd50fe4b93088e9939327fd4c7f6e9 (commit) from 655e35649c1877224d184de2baf82e3a505ec999 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f56ad87648ddef5cba66a4cbae9efb53a221c09a Author: Kyle M Hall Date: Fri Feb 19 12:51:21 2016 +0000 Bug 14507 [QA Followup] - Restore comment, tidy sub Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit 0810027bfadd50fe4b93088e9939327fd4c7f6e9 Author: Colin Campbell Date: Wed Aug 5 12:55:41 2015 +0100 Bug 14507 Use checkpw to check password in Patron Info Some devices are using patron information responses to validate patron passwords to govern access to facilities as we were using C4::Auth::checkpw_hash this only worked in a db password context not other authentication routines. The C4::Auth routines are not very consistent and there isnt a dropin replacement for checkpw_hash this calls checkpw instead. In a password only environment this behaves as the old version did returning field CQ as Y if a valid password or no password is passed in the patron info request and N if an incorrect password is supplied It should also test against the appropriate authentication sources if othere autrhentication schemes are in use Signed-off-by: Liz Rea Tested this with a client who reports that this enables SIP authentication to work correctly with their LDAP server. Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: C4/SIP/ILS/Patron.pm | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 01:58:47 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 00:58:47 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-574-g818b187 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 818b1871519f0348cc54a60c76e2c8192f36bb3c (commit) via e8c5fb11fbebc86742325aea745bc7253d9110d8 (commit) from f56ad87648ddef5cba66a4cbae9efb53a221c09a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 818b1871519f0348cc54a60c76e2c8192f36bb3c Author: Jonathan Druart Date: Mon Jan 25 10:31:34 2016 +0000 Bug 14244: Does not display patron's info in the checkout history if not authorised The librarian needs CAN_user_circulate_circulate_remaining_permissions to see the checkouts patron's information. Test plan: The "Patron" column of the checkout history page should only be displayed of you have the circulate > circulate_remaining_permissions permission. Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit e8c5fb11fbebc86742325aea745bc7253d9110d8 Author: Thomas Misilo Date: Wed Sep 16 13:43:28 2015 -0400 Bug 14244: viewing a bib item's circ history requires circulation permissions On issuehistory.pl you have: flagsrequired => { circulate => "circulate_remaining_permissions" }, But that really doesn't make sense. People should be able to view the history of circulation without having permission to circulate items themselves This patch changes the required permissions from circulate to catalogue. Test Plan: 1. Login as user without the circulate_remaining_permissions 2. Attempt to view Circulation History of an Item 3. Does not work 4. Apply Patch 5. Attempt to view circulation history with a user that has access to the staff side. 6. Can view circulation history now Signed-off-by: Nicole Engard Signed-off-by: Jonathan Druart Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: catalogue/issuehistory.pl | 2 +- .../intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 02:00:57 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 01:00:57 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-576-g002d7f4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 002d7f45e5de35d2b052bf99d6d0dbc329775a3d (commit) via 8c9fe6b2ddb7d9ba2113750d89c0be1e855e9b5d (commit) from 818b1871519f0348cc54a60c76e2c8192f36bb3c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 002d7f45e5de35d2b052bf99d6d0dbc329775a3d Author: Tomas Cohen Arazi Date: Tue Feb 16 10:17:34 2016 -0300 Bug 12549: (QA followup) missing newline in CLI dialog Signed-off-by: Tomas Cohen Arazi Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit 8c9fe6b2ddb7d9ba2113750d89c0be1e855e9b5d Author: Nicholas van Oudtshoorn Date: Tue Dec 22 12:25:47 2015 +0800 Bug 12549: Hard coded font Paths ( DejaVu ) cause problems for non-Debian systems Allows for selection of DejaVu font path when installing from the command line. This is useful for non-debian distributions that don't store the fonts in the same place. Adds a new configuration variable to Makefile.PL: FONT_DIR Defaults to the Debian install location for the fonts. Test plan: 1. Run a CLI install, accepting the defaults. 2. Compare the generated koha-conf.xml to a previous install - the font path for DejaVu fonts should be the same. 3. Run another CLI install, this time choosing a custom path for the fonts 4. Check that the path selected is reflected in the koha-conf.xml file. NOTE: 'perl Makefile.pl' and 'make' generates blib/KOHA_CONF_DIR/koha-conf.xml ran with a weird string for the font dir copied that koha-conf.xml to my home dir reran with all defaults compared the two, and only the font paths differed. Also, I cleaned up the tabs that snuck in. :) Signed-off-by: Mark Tompsett Signed-off-by: Tomas Cohen Arazi Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: Makefile.PL | 12 ++++++++++-- etc/koha-conf.xml | 24 ++++++++++++------------ rewrite-config.PL | 1 + 3 files changed, 23 insertions(+), 14 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 02:27:32 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 01:27:32 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-577-g2374c04 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2374c0498544803693bf0d833ad982174e21ed73 (commit) from 002d7f45e5de35d2b052bf99d6d0dbc329775a3d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2374c0498544803693bf0d833ad982174e21ed73 Author: Owen Leonard Date: Wed Feb 17 12:17:17 2016 -0500 Bug 15847: Correct JSHint errors in basket.js in the staff client This patch corrects minor errors in the staff client's basket.js according to warnings raised by JSHint. To test, apply the patch and run JSHint on basket.js. No warnings should be raised. To confirm that the behavior of the JS is not changed, clear your browser cache if necessary and: - Test adding multiple titles to the Cart from staff client search results. - Confirm that adding titles to the Cart triggers a message by the Cart link. - Test clicking the "Cart" link in the header menu when the Cart popup is open but behind the main window. - Testing emptying the Cart. Signed-off-by: Hector Castro Works as described. No warnigns raised with jshint tool Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/js/basket.js | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 02:28:55 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 01:28:55 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-578-g9a7c6f6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 9a7c6f695c4dd0fe5a1a92534ad0af79adbf1122 (commit) from 2374c0498544803693bf0d833ad982174e21ed73 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9a7c6f695c4dd0fe5a1a92534ad0af79adbf1122 Author: Owen Leonard Date: Wed Feb 17 09:54:28 2016 -0500 Bug 15844 - Correct JSHint errors in staff-global.js This patch corrects minor errors in staff-global.js according to warnings raised by JSHint. To test, apply the patch and run JSHint on staff-global.js. No warnings should be raised. To confirm that the behavior of the JS is not changed, clear your browser cache if necessary and: - Confirm that the "Help" link opens the help window. - Confirm that audio alerts work with local and remote sound files - Confirm that the format() method is still working correctly by, for instance, opening the detail page for a bibliographic record with multiple items and choosing 'Edit -> Delete record' from the menu. The error message should read like "2 item(s) are attached to this record..." Signed-off-by: Hector Castro Works as described. No errors with JSHint CLI (6 errors fixed) Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 02:38:16 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 01:38:16 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-579-g20989b7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 20989b76b9507bc128c980e4eeebc5891f72e2ff (commit) from 9a7c6f695c4dd0fe5a1a92534ad0af79adbf1122 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 20989b76b9507bc128c980e4eeebc5891f72e2ff Author: Owen Leonard Date: Wed Feb 17 09:33:28 2016 -0500 Bug 15843: Move MARC subfields structure JavaScript into separate file The JavaScript embedded in the MARC subfields structure template is not dependent on template processing and can safely be moved to a separate file. This patch does so. Removed in the process is some lines which were commented out. To test, apply the patch and go to Administration -> MARC framworks. - Click 'MARC structure' for a framework you can edit. - Click 'subfields' for a tag you can edit. - Click 'Edit' for a subfield you can edit. - Confirm that tabs and accordian sections work correctly. - Make changes under Advanced constraints -> Visibility and confirm that they are saved correctly. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: .../prog/en/js/marc_subfields_structure.js | 143 +++++++++++++++++ .../en/modules/admin/marc_subfields_structure.tt | 160 +------------------- 2 files changed, 144 insertions(+), 159 deletions(-) create mode 100644 koha-tmpl/intranet-tmpl/prog/en/js/marc_subfields_structure.js hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 02:39:55 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 01:39:55 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-580-gd9b39d2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d9b39d2553271814527de58be23da6d8f28e0f78 (commit) from 20989b76b9507bc128c980e4eeebc5891f72e2ff (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d9b39d2553271814527de58be23da6d8f28e0f78 Author: Jonathan Druart Date: Fri Feb 12 15:26:49 2016 +0000 Bug 15811: follow-up Bug 4912: Redirect to the appropriate view after editing/deleting a list Test plan: 1/ At the opac, go on the the list home page (opac-shelves.pl) 2/ Click on 'new list', create a list and save => You should be redirect to the list 3/ Click on edit, save => You should be redirect to the list 4/ Delete the list => You should be redirect to the list 5/ Edit a list from the list view, save => You should be redirect to the list 6/ Click on a list link (op=view) 7/ Edit the list, save => You should be redirect to the 'show' view 8/ Delete list => You should be redirect to the list Signed-off-by: Hector Castro Works as advertised Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 1 + opac/opac-shelves.pl | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 02:42:49 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 01:42:49 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-581-g34b7993 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 34b79932f79f83fbca528083cacbb61f157c05cb (commit) from d9b39d2553271814527de58be23da6d8f28e0f78 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 34b79932f79f83fbca528083cacbb61f157c05cb Author: Marc V?ron Date: Fri Feb 12 10:19:00 2016 +0100 Bug 15808 - Remove "Return to where you were before" from sysprefs This patch removes the link 'return to where you were before' from syspref search result page after failing search. To test: - Apply patch - Go to System preferences in staff client, do a search with something that does not exist - Verify that a message pops up that does not contain the link. Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 02:45:13 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 01:45:13 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-582-g35ea672 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 35ea672e7af39e3e54ef0822b85da4ba19ed21bf (commit) from 34b79932f79f83fbca528083cacbb61f157c05cb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 35ea672e7af39e3e54ef0822b85da4ba19ed21bf Author: Owen Leonard Date: Wed Feb 3 08:40:20 2016 -0500 Bug 15784: Library deletion warning is incorrectly styled When deleting a library in Administration -> Libraries and groups, the deletion confirmation message is not styled with the standard "dialog alert"

. This patch modifies the confirmation markup to match the standard. Revised to include Font Awesome icons. Depends on Bug 15785. To test, apply the patch and go to Administration -> Libraries and groups. - Try deleting a library. The confirmation box should have the standard "dialog alert" class. - Test the 'confirm' and 'cancel' actions and make sure both complete correctly. Signed-off-by: Owen Leonard Buttons display as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/admin/branches.tt | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 02:53:33 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 01:53:33 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-585-g0195a2a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 0195a2af99d9e7cd15e39e5cb08d9be4b0ea1759 (commit) via 84ca3db6c70c8e7dc3e568c6cdee7cdadd3bd85a (commit) via 3b875d3a2f57557d31a569a8d9a6aadc45e86f84 (commit) from 35ea672e7af39e3e54ef0822b85da4ba19ed21bf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0195a2af99d9e7cd15e39e5cb08d9be4b0ea1759 Author: Mark Tompsett Date: Thu Feb 11 23:30:36 2016 -0500 Bug 15777 - Refactor and fix the RecordProcessor class TEST PLAN --------- 1) Apply all three patches 2) prove -v t/RecordProcessor.t -- all should be successful 3) run koha qa test tools Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit 84ca3db6c70c8e7dc3e568c6cdee7cdadd3bd85a Author: Mark Tompsett Date: Thu Feb 11 23:23:27 2016 -0500 Bug 15777 - Fix base class to prove refactor and fix required TEST PLAN --------- 1) Apply the testing patch and this patch 2) prove -v t/RecordProcess.t -- will complain about string use with "use strict". This is because it is using the module name, instead of the object instantiated with new(). 3) run koha qa test tools. Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit 3b875d3a2f57557d31a569a8d9a6aadc45e86f84 Author: Mark Tompsett Date: Wed Feb 10 11:18:40 2016 -0500 Bug 15777 - Test to prove initialization isn't working correctly. TEST PLAN --------- 1) Apply this testing patch 2) prove -v t/RecordProcessor.t -- tests will fail. 3) run koha qa test tools Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: Koha/RecordProcessor.pm | 13 +++++++------ Koha/RecordProcessor/Base.pm | 2 +- t/RecordProcessor.t | 11 +++++++++-- 3 files changed, 17 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 02:55:45 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 01:55:45 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-586-gd9c19c6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d9c19c6d45ad3f62119e3a29f37e227f635cb85c (commit) from 0195a2af99d9e7cd15e39e5cb08d9be4b0ea1759 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d9c19c6d45ad3f62119e3a29f37e227f635cb85c Author: Jonathan Druart Date: Fri Feb 12 11:47:22 2016 +0000 Bug 15747: Do not use CGI->param in list context - Auth.pm Test plan: Log you in! Without this patch applied, you will get a warning "Fetching the value or values of a single named parameter" With this patch applied, the warning from C4::Auth line 401 should not appear anymore in the log file. Signed-off-by: Marcel de Rooy Note: no warnings for older CGI versions. Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 02:57:14 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 01:57:14 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-587-g2a43195 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2a43195322c228795b08ebbc165e360c725c2b56 (commit) from d9c19c6d45ad3f62119e3a29f37e227f635cb85c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2a43195322c228795b08ebbc165e360c725c2b56 Author: Julian Maurice Date: Thu Feb 4 17:42:42 2016 +0100 Bug 15743: Allow plugins to embed Perl modules This patch allows plugins to embed Perl modules by ignoring Perl modules in plugins directory that don't inherit from Koha::Plugins::Base TEST PLAN --------- 1) Edit koha-conf.xml to have enable_plugins set to 1, and the pluginsdir set to a particular path. 2) Create a dummy plugin file. (e.g. {that path}/Koha/Plugin/Kaboom.pm) Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: Koha/Plugins.pm | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 03:02:57 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 02:02:57 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-589-ga84264c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a84264c92f4c34607fba09f109610e40611078a9 (commit) via 701f427587daa4530041014fae8bf3674351283c (commit) from 2a43195322c228795b08ebbc165e360c725c2b56 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a84264c92f4c34607fba09f109610e40611078a9 Author: Mark Tompsett Date: Mon Feb 1 18:12:44 2016 -0500 Bug 15719: Silence warning in C4/Language.pm during web install This problem was discovered the hard way: - Drop DB - Create DB - Webinstaller run until the screen is: We are ready to do some basic configuration. Please install basic configuration settings to continue the installation. -- The error log file will end with an error about splitting an uninitialized value. TEST PLAN --------- 0) First patch already applied 1) prove -v t/Languages.t -- success, but warn prints 2) Apply this patch 3) prove -v t/Languages.t -- success without warning messages 4) run koha qa test tools Signed-off-by: Hector Castro Works as described. QA test tools run OK Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit 701f427587daa4530041014fae8bf3674351283c Author: Mark Tompsett Date: Mon Feb 1 18:26:41 2016 -0500 Bug 15719: Silence warning in C4/Language.pm during web install - tests Test empty database case. TEST PLAN --------- 1) prove -v t/Languages.t -- success (because test case is missing) 2) Apply this patch 3) prove -v t/Languages.t -- success, but warning printed. 4) run koha qa test tools Signed-off-by: Hector Castro Works as advertised. QA test tools rus OK Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: C4/Languages.pm | 6 +++++- t/Languages.t | 10 ++++++++-- 2 files changed, 13 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 03:06:16 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 02:06:16 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-591-gad63a6b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ad63a6b8da1cd91f2e03ec4093d76b00cd3045d2 (commit) via 4dba088549d1add43cfd575ebdd3d21689c4a700 (commit) from a84264c92f4c34607fba09f109610e40611078a9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ad63a6b8da1cd91f2e03ec4093d76b00cd3045d2 Author: Nick Clemens Date: Mon Feb 1 15:57:56 2016 +0000 Bug 15699 [QA followup] - Only display firstname if present Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit 4dba088549d1add43cfd575ebdd3d21689c4a700 Author: Nick Clemens Date: Thu Jan 28 21:58:37 2016 +0000 Bug 15699 - Course reserves instructors should be in form "Surname, Firstname" for sorting purposes This patch changes the order of the name fields and adds a span class around each in case of library wanting to customize further To test: 1 - Enable course reserves 2 - Add some courses with instrcutors 3 - Note they are of form "Firstname Surname" 4 - Apply patch 5 - Note the change 6 - Note span tags 7 - Note you can hide firstname by adding to intranet user js: $(".instr_firstname, instr_separator").hide(); Sing-off note: This patch displays the names as advertised on cgi-bin/koha/opac-course-reserves.pl Sorting the names would need some more actions but seems not to be intended by this patch. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-reserves.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 03:08:46 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 02:08:46 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-592-g004727f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 004727fbbf396382a3b3217969928207e75906d7 (commit) from ad63a6b8da1cd91f2e03ec4093d76b00cd3045d2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 004727fbbf396382a3b3217969928207e75906d7 Author: Owen Leonard Date: Thu Jan 28 10:20:07 2016 -0500 Bug 15692 - Move some patron entry form JavaScript into members.js We should strive to keep as much JavaScript as possible out of templates in order to keep things modular and maximize the benefits of browser caching. This patch moves JavaScript out of the patron entry template Two other minor edits: Missing semicolons added on the advice of JSHint. To test, apply the patch and confirm that the following interactions still work on the patron entry form: 1. clear_entry(): With ExtendedPatronAttributes enabled, the "Clear" link next to any attribute form field should work to clear the field. 2. clone_entry(): With ExtendedPatronAttributes enabled and a repeatable attribute defined, it should be possible to click the "New" link to add another instance of that attribute's entry field. 3. update_category_code(): With ExtendedPatronAttributes enabled and an attribute defined which is limited to a single patron category, changing the patron category selection should correctly show or hide the attribute entry form. 4. select_user(): When adding or editing a patron with a "Child" category it should be possible to search for and select a guarantor to add to the record by clicking the "Set to patron" button. Selecting a new guarantor should change the text of the button from "Set to patron" to "Change." 5. noEnterSubmit(): This function should be correctly preventing you from hitting "ENTER" in any form field to submit the form. 6. guarantordelete(): When adding or editing a patron with a "Child" category, it should be possible to clear existing guarantor information by clicking the "Delete" button. Clicking the "Delete" button should change the text of the adjacent button to "Set to patron." 7. select_city(): With one or more cities defined it should be possible to use the drop-down menu of cities to populate the city, state, zip, and country fields. 8. Date of birth entry should have a maximum date limit of yesterday. The drop-down menu of years should go back 100 years. 9. Client-side validation rules should be in effect, requiring that a valid email address be entered in the primary email, secondary email, and alternate address email fields. 10.When editing a patron, the "Add manual restriction" link should display the form for adding a manual restriction, and clicking the "Cancel" link should hide it. Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/js/members.js | 135 +++++++++++++++++++- .../prog/en/modules/members/memberentrygen.tt | 131 +------------------ 2 files changed, 136 insertions(+), 130 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 03:10:15 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 02:10:15 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-593-g015e201 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 015e20138a7a400d0da30b0a771a94eede673c05 (commit) from 004727fbbf396382a3b3217969928207e75906d7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 015e20138a7a400d0da30b0a771a94eede673c05 Author: Marc V?ron Date: Tue Jan 26 16:33:49 2016 +0100 Bug 15667: Fix date and branch formatting of messages in patron account display This patch fixes the date and branch formatting of messages in patron account display. To verify: Add a new message to a patron account from the 'checkouts' tab in staff, the displayed date is not correctly formatted and the branch displays as code instead as branch name To test: Apply patch, verify that the messages and branch names are properly formatted. Signed-off-by: Hector Castro Works as described. The message dates in checkouts tab follow dateformat sypref Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 03:12:07 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 02:12:07 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-594-g7ce721e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 7ce721ebefc13d99ff527fad26b39b7064bd2e11 (commit) from 015e20138a7a400d0da30b0a771a94eede673c05 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7ce721ebefc13d99ff527fad26b39b7064bd2e11 Author: Marc V?ron Date: Mon Jan 25 18:58:54 2016 +0100 Bug 15658: Browse system logs: Add more actions to action filter list The following actions were missing in the action filter list on cgi-bin/koha/tools/viewlog.pl: 'ADDCIRCMESSAGE' 'CHANGE PASS' 'DELCIRCMESSAGE' 'RENEW' 'Run' To test: - Apply patch - Go to Tools > Logs (viewlog.pl) - Verify that the actions appear in the list 'Actions' - Verify that the new entries filter the list as appropriate (in combination with Modules: All or with a meaningful selection in list 'Modules') Note for testing: You have to set a date in 'Display from' to get results Signed-off-by: Hector Castro Logs work as advertised, translated in bug 13474 Signed-off-by: Jonathan Druart "Run" could be more explicit. Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 03:13:19 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 02:13:19 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-595-g904a358 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 904a358da38e2945125170c3e9896193f0c288ce (commit) from 7ce721ebefc13d99ff527fad26b39b7064bd2e11 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 904a358da38e2945125170c3e9896193f0c288ce Author: Marcel de Rooy Date: Mon Jan 25 13:14:56 2016 +0100 Bug 15652: Allow current date in datepicker on opac-reserve If you enable AllowHoldDateInFuture (and its OPAC variant), you get an additional "Hold starts on date". In that field and in "Hold not needed after" it was not possible to enter the current date. Although it does not really make any difference if you leave the startdate empty or put the current date in it, we concluded that it still makes a psychological difference. Some patrons were confused when placing a hold because the first date to select was tomorrow. Instead of telling them "Yes, but you can leave it empty", we should just allow the current date as well. The expiration date ("not needed after") also started on tomorrow. (This field can really be empty.) But there is actually no reason not to allow today here too. If the patron only wants it today, why force tomorrow? How is this arranged? Well, this is one of the simplest Koha patches ever written. It only changes the minDate option of both date pickers in one line from 1 to 0. Test plan: [1] Allow future hold dates via systempreferences. [2] Verify that you can enter today in both fields. [3] Put today in start and expiration date. Place the hold and verify that you can confirm the hold, check out and check in again. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 03:14:31 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 02:14:31 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-596-g5bbeab4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 5bbeab483ebc4016fe2c1503b95b8bf84e719c54 (commit) from 904a358da38e2945125170c3e9896193f0c288ce (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5bbeab483ebc4016fe2c1503b95b8bf84e719c54 Author: Owen Leonard Date: Thu Feb 18 10:06:41 2016 -0500 Bug 15600: System preferences broken toolbar looks broken This patch reverts some deletions made to staff-global.css in Bug 11559. The deletions broke the appearance of the floating toolbar in system preferences. To test, apply the patch and clear your browser cache if necessary. - Go to Administration -> System preferences and view a tab with enough content to allow you to scroll and test the appearance of the floating toolbar. Confirm that it looks correct. - Open the advanced cataloging editor and confirm that its toolbar looks correct. - Open the normal cataloging editor and confirm that the floating toolbar looks correct and works correctly. Signed-off-by: Hector Castro Works as advertised. Tollbar looks correct Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 03:25:26 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 02:25:26 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-598-g7220b27 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 7220b2798d27493fe36320d73ecef803237a00e7 (commit) via 37b02253899ff294b0b3275c15a488e5ef98807b (commit) from 5bbeab483ebc4016fe2c1503b95b8bf84e719c54 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7220b2798d27493fe36320d73ecef803237a00e7 Author: Brendan Gallagher Date: Wed Feb 24 02:17:53 2016 +0000 DBrev Bug 15526 - Drop nozebra database table Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit 37b02253899ff294b0b3275c15a488e5ef98807b Author: Jonathan Druart Date: Mon Jan 11 10:26:33 2016 +0000 Bug 15526: drop table nozebra This table is not used anymore and can be removed. Test plan: In your sql cli: SHOW TABLES; should return nozebra if your DB has been created before bug 7440. Apply this patch and execute the update DB entry. Now the table should have been dropped. Signed-off-by: Aleisha Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/updatedatabase.pl | 10 ++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 03:53:27 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 02:53:27 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-600-g4f9f596 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 4f9f596203ff5222ba40272f16fb328cd63dd8b0 (commit) via 6679515f713f150c80bcf8e4313f14f67577b2ce (commit) from 7220b2798d27493fe36320d73ecef803237a00e7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4f9f596203ff5222ba40272f16fb328cd63dd8b0 Author: Jonathan Druart Date: Fri Feb 12 15:56:56 2016 +0000 Bug 13778: Only the last column is not sortable Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit 6679515f713f150c80bcf8e4313f14f67577b2ce Author: Aleisha Date: Wed Feb 10 20:43:27 2016 +0000 Bug 13778: Putting patron lists buttons into a dropdown menu To test: 1) Go to Tools -> Patron lists 2) If there are no lists, confirm there is a message box saying 'There are no patron lists.' 3) Create a list if you do not already have one. 4) Confirm that in the 'Actions' drop down menu next to the list, the options to 'Add patrons', 'Edit', 'Delete', and 'Print patron cards' are all there and work as expected. Sponsored-by: Catalyst IT Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/patron_lists/lists.tt | 39 +++++++++----------- 1 file changed, 17 insertions(+), 22 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 03:56:53 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 02:56:53 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-601-gd1ead73 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d1ead7313cf78581e31c4a210f01709ff228fdb6 (commit) from 4f9f596203ff5222ba40272f16fb328cd63dd8b0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d1ead7313cf78581e31c4a210f01709ff228fdb6 Author: Juan Romay Sieira Date: Tue Feb 9 17:39:32 2016 +0100 Bug 11937 - opac link doesn't open in new window Signed-off-by: Juan Romay Sieira Patch works as expected. From a biblio detail page, the link 'OPAC view: Open in new window' opens a new browser window. Signed-off-by: Marc Veron Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/js/browser.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 03:58:08 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 02:58:08 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-603-g4f12b22 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 4f12b2287e21287418edb6380a16799c8e0a96ec (commit) via 393308907ca332339d1be05ee99463dc783126d4 (commit) from d1ead7313cf78581e31c4a210f01709ff228fdb6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4f12b2287e21287418edb6380a16799c8e0a96ec Author: Jonathan Druart Date: Mon Feb 22 10:49:15 2016 +0000 Bug 15845: Do not import Add_Delta_YM from circulation.pl This subroutine is no longer used in this script. Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit 393308907ca332339d1be05ee99463dc783126d4 Author: Marcel de Rooy Date: Wed Feb 17 16:32:03 2016 +0100 Bug 15845: Renewal date in circulation.pl is not always correct and not even used If you have a patron category with a hard renewal date, the enrolllment period will be zero. You cannot calculate the renewal date as is done in the script currently. Even more, the renewaldate template var is not even used. Test plan: [1] Verify that checkin/checkout works as expected. [2] Git grep on renewaldate [3] Check the code in circulation.pl for "$renew" Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: circ/circulation.pl | 9 --------- 1 file changed, 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 03:59:32 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 02:59:32 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-604-g5170c91 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 5170c91f493aaa82d111a6a5215faf0ed53be72b (commit) from 4f12b2287e21287418edb6380a16799c8e0a96ec (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5170c91f493aaa82d111a6a5215faf0ed53be72b Author: Colin Campbell Date: Wed Feb 17 12:47:56 2016 +0000 Bug 15841 Circulation module's true value misplaced 1; was not at the end of the module as it should be to ensure compilation returns true return it to last line of code where it should be This patch fixes an ovious mistake. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 04:03:45 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 03:03:45 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-605-gb52cbec Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b52cbecbfd282060a2a444252d83d263c0783f14 (commit) from 5170c91f493aaa82d111a6a5215faf0ed53be72b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b52cbecbfd282060a2a444252d83d263c0783f14 Author: Mark Tompsett Date: Wed Feb 10 21:51:26 2016 -0500 Bug 15795: C4/Members.pm is floody (Norwegian Patron DB) From the mailing list: "I'm working on 3.22.02 and my logs are FILLED with the following warnings: Members.pm: Unable to load Koha::NorwegianPatronDB at /blurred/C4/Members.pm line 46., referer: http://blurred/cgi-bin/koha/acqui/booksellers.pl admin-home.pl: Unable to load Koha::NorwegianPatronDB at /blurred/C4/Members.pm line 46., referer: http://blurred/cgi-bin/koha/admin/preferences.pl" I agree. Looking at C4/Members.pm other warns are all prepended with $debug. TEST PLAN --------- 1) rm Koha/NorwegianPatronDB.pm -- quickest and dirtiest way to get the load to fail. 2) echo > ~/koha-dev/var/log/koha-error_log -- so it will be easy to spot the log changes. -- back up the log file if you really want it. 3) log into the staff client and go to patrons. -- Check the log file. "Unable to load ..." will be there. 4) echo > ~/koha-dev/var/log/koha-error_log 5) sudo vi /etc/apache2/sites-enabled/{your koha site file} -- Find your staff client entry in your apache configuration file and add: SetEnv DEBUG 1 6) sudo service apache2 restart 7) apply the patch 8) refresh the patron page -- "Unable to load..." will still be there. 9) change the DEBUG value in your apache config to 0 10) sudo sevice apache2 restart 11) echo > ~/koha-dev/var/log/koha-error_log 12) refresh the patron page -- "Unable to load..." will NOT be there. 13) git checkout origin/master -- Koha/NorwegianPatronDB.pm -- to bring it back. 14) refresh the patron page -- "Unable to load..." will still not be there. 15) run koha qa test tools Signed-off-by: Philippe Blouin Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: C4/Members.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 04:08:24 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 03:08:24 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-606-ga9a10c5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a9a10c57807a91f550ffc73f6fb32e631d4bdb3f (commit) from b52cbecbfd282060a2a444252d83d263c0783f14 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a9a10c57807a91f550ffc73f6fb32e631d4bdb3f Author: Hector Castro Date: Thu Jan 28 10:40:34 2016 -0600 Bug 15693: Unnecessary punctuation mark when check-in an item in a library other than the home branch To test: 1-Checkin an item in a library other than the home branch. 2-A message will display asking to return the item to the home branch 3-You will see the phrase "Print slip )" 4-Apply patch 5-Reproduce or repeat steps 1-2 and verify the punctuation mark is no longer displayed Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 04:09:41 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 03:09:41 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-607-gfdd66bc Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via fdd66bc830e8974be67ca43379e4ae3156b0e9cb (commit) from a9a10c57807a91f550ffc73f6fb32e631d4bdb3f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fdd66bc830e8974be67ca43379e4ae3156b0e9cb Author: Gus Date: Wed Jan 20 02:50:13 2016 +0000 15622 - Spelling mistake in printfeercpt.pl writen -> written Search the file for writen, when not found change sucsessful Signed-off-by: Mirko Tietgen Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: members/printfeercpt.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 04:10:42 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 03:10:42 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-608-g17c7c68 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 17c7c685f12dd09186d369f84cc725984328c5fa (commit) from fdd66bc830e8974be67ca43379e4ae3156b0e9cb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 17c7c685f12dd09186d369f84cc725984328c5fa Author: Aleisha Date: Mon Jan 18 03:30:44 2016 +0000 Bug 15416: Warns on guided_reports.pl Initialising $phase variable to be '' if not defined. To test: 1) Go to Reports -> Guided Reports Wizard 2) Notice warns 3) Apply patch 4) Refresh page 5) Confirm warns are gone and page still works as it should Signed-off-by: Hector Castro Warns are gone. Page still works as expected Signed-off-by: Jonathan Druart Amended patch: -my $phase = $input->param('phase'); -$phase //= ''; +my $phase = $input->param('phase') // ''; Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: reports/guided_reports.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 04:13:03 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 03:13:03 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-616-g5f71faf Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 5f71faf97185efbfad69e4f2237c9e2d38e7a812 (commit) via 9ac68128d99aff4b8d3cabb98c3e84d0f0658b3a (commit) via e3e507be9e9f90ff075fafba8013c8e54fa1fa00 (commit) via 3387a6114b70cf8de021c4cdf84a687e629efc82 (commit) via afe9d02a819adfeec9468600805ee06df6082b21 (commit) via acf2e684bd4118d40e3bc89b09c0852bc8732d04 (commit) via ae5a199a551aa8a08f5d0c5b2338aeb194aba0c7 (commit) via b44b7224e079a983c991aa06eaae11c350871814 (commit) from 17c7c685f12dd09186d369f84cc725984328c5fa (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5f71faf97185efbfad69e4f2237c9e2d38e7a812 Author: Mark Tompsett Date: Mon Jan 4 01:16:59 2016 -0500 Bug 14097: Fixed missing test cases Fixed AllowPkiAuth issue caused by 15101. Added missing AudioAlerts TEST PLAN --------- 1) prove -v t/db_dependent/UsageStats.t -- should pass after applying patch 2) Run koha qa test tools Signed-off-by: Indranil Das Gupta (L2C2 Technologies) Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit 9ac68128d99aff4b8d3cabb98c3e84d0f0658b3a Author: Julian FIOL Date: Mon Aug 24 13:51:16 2015 +0200 Bug 14097 : Changing AddReserve prototype call In response of Joubu comment #19 Signed-off-by: Indranil Das Gupta (L2C2 Technologies) Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit e3e507be9e9f90ff075fafba8013c8e54fa1fa00 Author: Julian FIOL Date: Mon Aug 24 13:50:16 2015 +0200 Bug 14097 : Avoid issue if the number of syspref shared is modified Signed-off-by: Indranil Das Gupta (L2C2 Technologies) Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit 3387a6114b70cf8de021c4cdf84a687e629efc82 Author: Mark Tompsett Date: Sat May 23 00:22:26 2015 -0400 Bug 14097 - Correct noise under Debian The first four patches do not create any noise under Ubuntu 14.04 LTS. Running on Debian Jessie: [SNIP] keys on reference is experimental at t/db_dependent/UsageStats.t line 88. keys on reference is experimental at t/db_dependent/UsageStats.t line 106. keys on reference is experimental at t/db_dependent/UsageStats.t line 119. keys on reference is experimental at t/db_dependent/UsageStats.t line 136. keys on reference is experimental at t/db_dependent/UsageStats.t line 153. keys on reference is experimental at t/db_dependent/UsageStats.t line 162. keys on reference is experimental at t/db_dependent/UsageStats.t line 587. [SNIP] Instead of having 'keys $foo->{bar}', 'keys %{$foo->{bar}}' was used. TEST PLAN --------- 1) On a DEBIAN system (Jessie gives above messages) apply the first 4 patches interactively. 2) $ prove t/db_dependent/UsageStats.t -- trigger noise like above. 3) apply this patch 4) $ prove t/db_dependent/UsageStats.t -- no noise triggered. 5) koha qa test tools Signed-off-by: Indranil Das Gupta (L2C2 Technologies) Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit afe9d02a819adfeec9468600805ee06df6082b21 Author: Julian FIOL Date: Tue May 12 14:28:56 2015 +0200 Bug 14097: Rollback issue and warning corrected The rollback issue came from '_count' testing. It used a 'DROP TABLE' and 'CREATE TABLE' which implicitly do autocommit. That's why the final rollback could not be. This patch no longer uses t::lib::TestBuilder either because it was the cause of the warning on Comment #1 : "DBIx::Class::Storage::txn_rollback(): A txn_rollback in nested transaction is ineffective! (depth 1) at t/lib/TestBuilder.pm line 308" Signed-off-by: Bernardo Gonzalez Kriegel Now data is preserved, no errors. Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit acf2e684bd4118d40e3bc89b09c0852bc8732d04 Author: Julian FIOL Date: Mon May 4 15:20:01 2015 +0200 Bug 14097: changing verif_systempreferences_values subroutine It's saving a large number of lines Signed-off-by: Bernardo Gonzalez Kriegel All tests run, no koha-qa errors Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit ae5a199a551aa8a08f5d0c5b2338aeb194aba0c7 Author: Julian FIOL Date: Mon May 4 11:08:14 2015 +0200 Bug 14097: Delete table issues before testing If we delete all biblio DB, we could have some troubles with foreign keys Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit b44b7224e079a983c991aa06eaae11c350871814 Author: Julian FIOL Date: Fri Apr 10 11:07:39 2015 +0200 Bug 14097: Testing C4::UsageStats DESCRIPTION ----------- Add unit tests to C4::UsageStats Subroutine : (V : tested, X : Not tested) V NeedUpdate V BuiltReport X ReportToCommunity V _count TEST PLAN --------- 1. Apply patch 2. prove -v t/db_dependent/UsageStats.t -- All tests should run successfully /!\ I have 1 warning but I don't know where it can come /!\ (in cleanup) DBIx::Class::Storage::txn_rollback(): A txn_rollback in nested transaction is ineffective! (depth 1) at t/lib/TestBuilder.pm line 308 TEST PLAN OPTIONAL ------------------ Go check bug 13899 to see the coverage of this module. Coverage BEFORE this patch : Statement : 40,5% Branch : 0,0% Condition : 0,0% Subroutine : 55,6% Coverage AFTER this patch : Statement : 81,0% Branch : 100,0% Condition : 100,0% Subroutine : 88,8% Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: C4/UsageStats.pm | 10 +- t/db_dependent/UsageStats.t | 595 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 600 insertions(+), 5 deletions(-) create mode 100644 t/db_dependent/UsageStats.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 04:14:17 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 03:14:17 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-617-g4c87b50 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 4c87b50ac32a00fd1056ab3923ecb11bde5c2b51 (commit) from 5f71faf97185efbfad69e4f2237c9e2d38e7a812 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4c87b50ac32a00fd1056ab3923ecb11bde5c2b51 Author: Aleisha Date: Tue Jan 19 20:29:24 2016 +0000 Bug 13474: Adding untranslatable log actions to viewlog.tt Added 'Run' Signed-off-by: Aleisha (Amended to remove tab chars to make qa tools happy) Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt | 5 +++++ 1 file changed, 5 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 04:17:43 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 03:17:43 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-619-g05be0f2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 05be0f29cd2d7175acdf2ddf4a8805ec5b3df15e (commit) via 17190de524c58b8abeca5c65506fe44bfdd93adc (commit) from 4c87b50ac32a00fd1056ab3923ecb11bde5c2b51 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 05be0f29cd2d7175acdf2ddf4a8805ec5b3df15e Author: Kyle M Hall Date: Wed Feb 3 15:22:40 2016 +0000 Bug 12920 [QA Followup] - Show override option below checkouts table when allowed Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit 17190de524c58b8abeca5c65506fe44bfdd93adc Author: Natasha Date: Tue Jan 19 00:56:56 2016 +0000 bug 12920 - Remove AllowRenewalLimitOverride from pl scripts and tt files, use Koha.Preference instead Test Plan: 1) Apply this patch 2) Go to circulation.pl 3) Ensure you can still override renewal limits with pref enabled 4) Ensure you can not override renewal limits with pref disabled 5) Go to moremember.pl 6) Repeat steps 3-4 Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: circ/circulation.pl | 1 - koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table.inc | 3 ++- koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt | 2 +- members/moremember.pl | 1 - 5 files changed, 4 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 04:18:58 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 03:18:58 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-620-g901b7f9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 901b7f964b7c2f93a22b41f0fd9a470796cb2fdc (commit) from 05be0f29cd2d7175acdf2ddf4a8805ec5b3df15e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 901b7f964b7c2f93a22b41f0fd9a470796cb2fdc Author: Owen Leonard Date: Thu Feb 18 11:44:52 2016 -0500 Bug 15859: Move some basic MARC editor controls into settings menu This patch moves the following options into a "Settings" menu inspired by the one in the advanced editor: - Switch to advanced editor - Show MARC tag documentation links - Show tags - Change framework To test, apply the patch and open a new or existing record in the standard MARC editor. - Test that the 'Switch to advanced editor' button option works. - Test that the 'Show MARC tag documenation links' option works (and that your choice persists across sessions). - Test that the initial settings for 'Show tags' respects the 'hide_marc' system preference. - Test that the 'Show tags' option works (and that your choice persists across sessions). - Test that framework switching works correctly and that the menu correctly reflects your choice. - Confirm that other toolbar functions work as expected, both in regular editing mode and Fast Cataloging. Signed-off-by: Hector Castro Works as expected. Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/cataloguing/addbiblio.tt | 176 ++++++++++---------- 1 file changed, 92 insertions(+), 84 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 04:20:33 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 03:20:33 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-621-g6656f6b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6656f6b704e2a0175e5b4cf2c08bd29eb201d946 (commit) from 901b7f964b7c2f93a22b41f0fd9a470796cb2fdc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6656f6b704e2a0175e5b4cf2c08bd29eb201d946 Author: Hector Castro Date: Thu Feb 18 14:54:53 2016 -0600 Bug 15858: Use Font Awesome icons in dialog alert for addorder.tt A warning is raised when order amount exceed budget or fund this dialog needs to be styled with Font Awesome icons. To test: -Add orders to a basket -Exceed a fund or budget -Notice about the dialog alert -Apply patch -Exceed again and see the new icons Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorder.tt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 04:21:44 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 03:21:44 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-622-gf40b542 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f40b5426441dceed1f27d0f4ebf6d2a2243fb072 (commit) from 6656f6b704e2a0175e5b4cf2c08bd29eb201d946 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f40b5426441dceed1f27d0f4ebf6d2a2243fb072 Author: Aleisha Date: Tue Feb 16 04:01:13 2016 +0000 Bug 15830 - Move Rotating Collections actions into a drop-down list To test: 1) Go to Tools -> Rotating Collections 2) Confirm actions (Add or remove items, Transfer, Edit, Delete) have moved into a drop down menu 3) Confirm all of the actions work as expected Sponsored-by: Catalyst IT Signed-off-by: Marc V?ron Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: .../rotating_collections/rotatingCollections.tt | 47 +++++++++++++------- 1 file changed, 32 insertions(+), 15 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 04:23:44 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 03:23:44 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-623-g44c522c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 44c522ce53c239b5c0f4f6e58fa122a5c2a14a8d (commit) from f40b5426441dceed1f27d0f4ebf6d2a2243fb072 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 44c522ce53c239b5c0f4f6e58fa122a5c2a14a8d Author: Aleisha Date: Tue Feb 16 03:22:46 2016 +0000 Bug 15829 - Rotating Collections is under Patrons on Tools Home - Should be Catalog To test: 1) Notice Rotating Collections is under Patrons & Circ on tools-home.pl 2) Apply patch and refresh page 3) Notice it is now under Catalog and is in the same position it is in on the tools sidebar menu Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/tools/tools-home.tt | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 04:29:58 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 03:29:58 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-625-g768e8cc Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 768e8cc6d4af9fe7c5d0d71bd4f3367786d475a1 (commit) via 0a39acec824b8156d414cb9c9effc48b3dfb953a (commit) from 44c522ce53c239b5c0f4f6e58fa122a5c2a14a8d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 768e8cc6d4af9fe7c5d0d71bd4f3367786d475a1 Author: Jonathan Druart Date: Mon Feb 22 11:09:37 2016 +0000 Bug 15828: Remove the required class on label Otherwise the label is red and a bit agressive :) Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit 0a39acec824b8156d414cb9c9effc48b3dfb953a Author: Owen Leonard Date: Tue Feb 16 12:49:02 2016 -0500 Bug 15828: Upload patron images is hard to read The styling of the patron image upload form causes the text to be smaller than it should be for the main body of a page. This patch revises the form style and cleans up the markup a bit. This patch also adds client-side validation of the form so that a file upload is required, and a card number is required if an image file is selected. To test, apply the patch and go to Tools -> Upload patron images. 1. Confirm that the text in the form is the correct size. 2. With "Zip file" selected, confirm that submitting the form is blocked and the file upload marked as required. 3. With "Image file" selected, confirm that submitting the form with an empty card number field is blocked and the card number field is marked as required. 4. Confirm that uploading zip files and single images still works correctly. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/tools/picture-upload.tt | 47 ++++++++++++++------ 1 file changed, 33 insertions(+), 14 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 04:31:17 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 03:31:17 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-626-g915c811 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 915c81191ac01efcc50e58b72aebe140bff3dd98 (commit) from 768e8cc6d4af9fe7c5d0d71bd4f3367786d475a1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 915c81191ac01efcc50e58b72aebe140bff3dd98 Author: Aleisha Date: Tue Feb 16 02:49:33 2016 +0000 Bug 15827 - Unfriendly message when saving overdue notice/status triggers To test: 1) Go to Tools -> Overdue notice/status triggers 2) Click Save changes (you don't have to change anything) 3) Confirm message now says 'Changes saved.' which is much nicer Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 04:32:24 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 03:32:24 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-627-g3f6a933 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 3f6a9330bb4d6d40b51391e13f558a865a4a6232 (commit) from 915c81191ac01efcc50e58b72aebe140bff3dd98 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3f6a9330bb4d6d40b51391e13f558a865a4a6232 Author: Aleisha Date: Tue Feb 16 04:29:59 2016 +0000 Bug 15826 - Use Font Awesome icons in confirmation dialogs - Tools I only found one confirmation dialog, all the others use javascript. To test: Go to Tools -> Notices and Slips Click Delete on a notice Confirm Yes and No options still work as expected Check Tools module in case I missed any confirm dialogs Sponsored-by: Catalyst IT Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 04:33:47 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 03:33:47 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-628-gf4241d1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f4241d1a49f8bf4ec151bce580112c4c3ab10094 (commit) from 3f6a9330bb4d6d40b51391e13f558a865a4a6232 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f4241d1a49f8bf4ec151bce580112c4c3ab10094 Author: Jesse Weaver Date: Wed Jan 6 13:19:10 2016 -0700 Bug 15813: Fix list-context call to ...->guarantor in opac-memberentry.pl (was: Bug 14658: (followup) fix issue with list context on DBIC call) While working on bug 14659, it was discovered that the call to ...->guarantor in list context will cause the hash to be misaligned if there is no guarantor. Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: opac/opac-memberentry.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 04:39:11 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 03:39:11 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-629-gb1ea7d7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b1ea7d70689cd9d9088badc101dbdaef1e9fd01a (commit) from f4241d1a49f8bf4ec151bce580112c4c3ab10094 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b1ea7d70689cd9d9088badc101dbdaef1e9fd01a Author: Jonathan Druart Date: Wed Feb 10 15:51:02 2016 +0000 Bug 15797: Remove C4::Koha::GetKohaImageurlFromAuthorisedValues This subroutine is no longer in used and can be remove. Test plan: git grep GetKohaImageurlFromAuthorisedValues should not return any results. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: C4/Koha.pm | 20 -------------------- t/db_dependent/Koha.t | 5 ++--- 2 files changed, 2 insertions(+), 23 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 04:40:20 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 03:40:20 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-630-g50c6991 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 50c6991f499242838057534e2e22cdd39d26e911 (commit) from b1ea7d70689cd9d9088badc101dbdaef1e9fd01a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 50c6991f499242838057534e2e22cdd39d26e911 Author: Jonathan Druart Date: Thu Feb 11 13:50:42 2016 +0000 Bug 15796: Remove C4::Koha::get_itemtypeinfos_of This subroutine is no longer in use. Test plan: git grep get_itemtypeinfos_of should not return any results. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Trivial and needed removal. Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: C4/Koha.pm | 17 ----------------- 1 file changed, 17 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 04:41:31 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 03:41:31 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-632-g2ea901c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2ea901c6411063f9b3d245674241c7f012d709cb (commit) via adff231a6763bd57defa9b5036c6df61f9eef99f (commit) from 50c6991f499242838057534e2e22cdd39d26e911 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2ea901c6411063f9b3d245674241c7f012d709cb Author: Jonathan Druart Date: Wed Feb 10 10:32:52 2016 +0000 Bug 15783: AddAuthorisedValue - Remove the subroutine Test plan: prove t/db_dependent/Koha.t should return green git grep AddAuthorisedValue should not return any results Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit adff231a6763bd57defa9b5036c6df61f9eef99f Author: Jonathan Druart Date: Wed Feb 10 10:20:01 2016 +0000 Bug 15783: AddAuthorisedValue - Replace existing calls The C4::Koha::AddAuthorisedValue is only called twice from reports/guided_reports.pl and insert an authorised value. This job can be achieve easily using the Koha::AuthorisedValue module. Test plan: 1/ Create a new guided report 2/ Use an existing group and/or subgroup of reports 3/ Save 4/ Update an existing report 5/ Use an existing group and/or subgroup of reports 6/ Save 7/ Create or update an existing report 8/ Remove its assigned group and subgroup 9/ Save Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: C4/Koha.pm | 21 ---------------- reports/guided_reports.pl | 14 +++++++++-- t/db_dependent/Koha.t | 58 ++++++++++++++++++++++++++++++++++++++------- 3 files changed, 61 insertions(+), 32 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 04:43:09 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 03:43:09 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-633-gad8d063 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ad8d063ffae574a050a0cdc54dcdf26b23df1350 (commit) from 2ea901c6411063f9b3d245674241c7f012d709cb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ad8d063ffae574a050a0cdc54dcdf26b23df1350 Author: Jonathan Druart Date: Tue Feb 9 13:40:01 2016 +0000 Bug 15769: Remove outdated C4::Koha::slashifyDate subroutine This subroutine does not make sense anymore (Koha::DateUtils should be used) and is no longer used. It can be removed safely. Test plan: git grep slashifyDate should not return any results prove t/Koha.t and prove t/db_dependent/Koha.t should return green Signed-off-by: Hector Castro slashifyDate removed, all test pass successfully Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: C4/Koha.pm | 18 ------------------ t/Koha.t | 9 +-------- t/db_dependent/Koha.t | 13 +++---------- 3 files changed, 4 insertions(+), 36 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 04:44:07 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 03:44:07 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-634-ge51fe4a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e51fe4a8f1a604453302b68cb2ff8bf1b0fb3fc7 (commit) from ad8d063ffae574a050a0cdc54dcdf26b23df1350 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e51fe4a8f1a604453302b68cb2ff8bf1b0fb3fc7 Author: Jonathan Druart Date: Wed Feb 3 16:04:38 2016 +0000 Bug 15731: Remove C4::Reports::Guided::build_authorised_value_list This subroutine has been added by commit 42acfbf75b7bb4ee53c6a6f035e258a0b522ce10 Bug 7993: Save reports with Group/Subgroup hierarchy But it has never been used (or git grep cheats me). Test plan: 1/ git grep build_authorised_value_list should not return any result 2/ Create a report, execute it Everything should work fine. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: C4/Reports/Guided.pm | 67 +------------------------------------------------- 1 file changed, 1 insertion(+), 66 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 04:45:45 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 03:45:45 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-637-gaf6488b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via af6488b157f85f3f12a84ac70da5524b4b4119b3 (commit) via 741252362450aedc8903ef75658b4c5342f8e6f9 (commit) via dbb24a676e8a8d96f20a9c1c66fdf5fd08ba1d4c (commit) from e51fe4a8f1a604453302b68cb2ff8bf1b0fb3fc7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit af6488b157f85f3f12a84ac70da5524b4b4119b3 Author: Marcel de Rooy Date: Wed Feb 3 15:59:02 2016 +0100 Bug 15714: Add zebra_loglevels to koha-conf.xml This patch adds a commented zebra_loglevels line to the config file. Behavior does not change, but an admin can easily edit the variable. Test plan: Nothing really changed. But if you are not so sure about that, apply the change to /etc/koha/koha-conf-site.xml.in and run koha-create. Check that the new koha-conf contains the line and is not messed up. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit 741252362450aedc8903ef75658b4c5342f8e6f9 Author: Marcel de Rooy Date: Tue Feb 2 16:40:06 2016 +0100 Bug 15714: Remove zebra.log and add loglevels The file zebra.log is actually not used, because daemon's --output parameter sends all message to zebra-output (making that stdout goes there too and --stdout does nothing). We do not need any differentiation (if any at all) here; behavior does not change. Note: zebra-error will only contain the daemon's error messages and not the zebra error messages! So you will probably only find messages about stopping zebra in zebra-error. The loglevels are by default none,fatal,warn and can be changed via the zebra_loglevels config variable (read by koha-functions.sh). If you remove 'none', you will have request-messages in the log. You can also keep 'none' and add 'request' to achieve something similar (undocumented however). Some of the parameters passed to daemon when stopping zebra are superfluous and have been removed. Test plan: [1] Remove the file zebra.log. Look at last lines in zebra-error and zebra-output. [2] Remove zebra_loglevels from koha-conf (if present). Start/restart Zebra. Search to verify if Zebra runs. Stop Zebra and check zebra-error for a new line (killed by signal 15). [3] Add fatal,warn in koha-conf:zebra_loglevels (do not include 'none'). Start Zebra. Check zebra-output for a line "[log] zebra_start". Do a search and check zebra-output for lines with "[request]". [4] Verify that zebra.log did not appear again. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit dbb24a676e8a8d96f20a9c1c66fdf5fd08ba1d4c Author: Marcel de Rooy Date: Mon Feb 1 15:36:26 2016 +0100 Bug 15714: Add get_loglevels to koha-functions.sh Preparing for including different log levels in koha-start-zebra. Note that the default response is none,fatal,warn; this is equal to the options passed to zebrasrv in koha-start-zebra (for now). Test plan: [1] Run on the command line: source koha-functions.sh [2] Type get_loglevels [your_instance] By default, you should see: none,fatal,warn [3] Add this line to your koha-conf: how,are,you [4] Run get_loglevels [your_instance] again. Remove the nonsense log levels again.. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: debian/scripts/koha-functions.sh | 12 ++++++++++++ debian/scripts/koha-start-zebra | 8 ++++---- debian/scripts/koha-stop-zebra | 8 -------- debian/templates/koha-conf-site.xml.in | 5 +++++ 4 files changed, 21 insertions(+), 12 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 04:48:25 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 03:48:25 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-638-gaf47f00 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via af47f00636848e1115b08652abcaec6b789bf672 (commit) from af6488b157f85f3f12a84ac70da5524b4b4119b3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit af47f00636848e1115b08652abcaec6b789bf672 Author: Marcel de Rooy Date: Mon Feb 1 13:48:06 2016 +0100 Bug 15713: Restart zebra when rotating logfiles Somehow, it may happen that Zebra keeps writing to the old rotated logfile with extension .log.1. I must add that although I saw that happen (a new log was created and was empty, while Zebra kept writing to log.1 for weeks), I cannot reproduce it every time. By stopping the zebra server in prerotate and starting it again in postrotate, this should not happen at all. In practice, this implies that your Zebra server is restarted once a week. Note: The existing sharedscripts directive makes sure that these actions are not executed for all individual logfiles but once for all matching logfiles (even when running multiple instances). Test plan: [1] Apply the change in koha-common.logrotate to the file /etc/logrotate.d/koha-common. [2] Run logrotate -f /etc/logrotate.conf (forcing a logrotate). [3] Check in zebra-error.log that your zebra server was stopped ('killed by signal 15'). [4] Verify that your Zebra server runs (read: has been restarted). (Do a search..) Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: debian/koha-common.logrotate | 4 ++++ 1 file changed, 4 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 04:49:27 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 03:49:27 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-639-gd05ca42 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d05ca42c75759c5f05fd7818201381cc2468ca50 (commit) from af47f00636848e1115b08652abcaec6b789bf672 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d05ca42c75759c5f05fd7818201381cc2468ca50 Author: Owen Leonard Date: Wed Feb 17 18:27:11 2016 -0500 Bug 15671 - Show branch name instead of branch code in checkout history When viewing the checkout history for a title the branchcode is displayed. This patch alters the template to show the library name instead. To test, apply the patch and locate a title in the staff client which has been checked out at least once. From the detail page, click "Checkout history" in the sidebar. The "Checked out from" column of the checkout history table should show the library name instead of the branchcode. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 04:50:42 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 03:50:42 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-640-g628a769 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 628a769a00647a8c9a32b15dbdd20e2bfe46e8f2 (commit) from d05ca42c75759c5f05fd7818201381cc2468ca50 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 628a769a00647a8c9a32b15dbdd20e2bfe46e8f2 Author: Aleisha Date: Tue Jan 26 04:45:51 2016 +0000 Bug 15665: Better wording of error messages when importing MARC frameworks UPDATE: Making error messages the same To test: 1) Go to Admin -> MARC frameworks 2) Click Import next to any framework. You won't actually be overwriting or importing anything as this is only a string fix, so it can be an existing framework 3) Click the Import button without attaching any file. Confirm it says "Please select a spreadsheet (.csv, .ods, .xml) file." and that this makes sense to you 4) Attempt to attach a file that is not a .csv, .ods or .xml file. You should instantly get an error message saying "Please select a CSV (.csv), ODS (.ods) or XML (.xml) file." Confirm this shows up and makes sense to you Signed-off-by: Hector Castro Rewording Ok. Works as described Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 04:51:50 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 03:51:50 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-641-gf66e675 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f66e6755ee85eaf32ccc0d91d72d0f1717e0bc84 (commit) from 628a769a00647a8c9a32b15dbdd20e2bfe46e8f2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f66e6755ee85eaf32ccc0d91d72d0f1717e0bc84 Author: Aleisha Date: Tue Jan 26 02:12:38 2016 +0000 Bug 15662: String and translatability fix to Label Creator To test: 1) Go to Tools -> Label Creator -> New label batch 2) Add an item 3) Click 'Remove selected items' button. Confirm message now reads "Please select at least one label to delete." 4) Click 'Remove duplicates' button. Confirm message now reads "Duplicate item(s) removed from batch number X: Y", all in bold. Signed-off-by: Hector Castro Rewording Ok for translatability purpose Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-batch.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 04:54:21 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 03:54:21 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-642-g3dcef67 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 3dcef671726b94067d6905beb1886c627f035f1f (commit) from f66e6755ee85eaf32ccc0d91d72d0f1717e0bc84 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3dcef671726b94067d6905beb1886c627f035f1f Author: Aleisha Date: Wed Jan 27 22:25:08 2016 +0000 Bug 15640: Removing title for links on circulation-home.tt To test: Go to Circulation and ensure there are no titles on hover over the links Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/circ/circulation-home.tt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 05:01:13 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 04:01:13 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-644-g07f85e7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 07f85e7f88a971648449df56c644a0fdbfabce8d (commit) via fdc224e1025529726007e345990c682073920aa8 (commit) from 3dcef671726b94067d6905beb1886c627f035f1f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 07f85e7f88a971648449df56c644a0fdbfabce8d Author: Jonathan Druart Date: Wed Jan 20 15:00:33 2016 +0000 Bug 15631: Koha::Cities - remove getidcity and GetCities C4::Members::getidcity and C4::Members::GetCities simply retrieved cities info from the cities table. The job done in members/memberentry.pl looked really weird and complicated. Either I have missed something, or this patch can simplify it. The expected behavior is: 1. Create a new patron => No city selected 2. Edit an existing patron => The borrowers.city value is selected 3. Add a guarantee => The borrowers.city of the guarantor is selected 4. Edit a guarantee => The borrowers.city of the guarantee is selected Test plan: Confirm that the expected behaviors are the ones before and after this patch. Signed-off-by: Natasha Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit fdc224e1025529726007e345990c682073920aa8 Author: Jonathan Druart Date: Wed Jan 20 14:59:48 2016 +0000 Bug 15631: Koha::Cities - remove getzipnamecity C4::Members::getzipnamecity was not used and can be remove safely. Test plan: git grep getzipnamecity should not return any result. Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: C4/Members.pm | 67 -------------------- .../en/includes/member-main-address-style-de.inc | 19 +++--- .../en/includes/member-main-address-style-us.inc | 19 +++--- members/memberentry.pl | 32 ++-------- 4 files changed, 26 insertions(+), 111 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 05:02:30 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 04:02:30 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-652-g3b8f35d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 3b8f35de7924c48d8d6290b114bcb71f39453d48 (commit) via 578b5fef61ff20124f77b96a98b2688796e51b31 (commit) via d564d3732d95455b4626dfa8ca711cd658003c17 (commit) via a007178b873cc84171549f7a93c63a391a1740ca (commit) via 4f5217314cefded2aaa82e9bda0dd1ce6d81a88e (commit) via f4d6c1cd50702011d72ac8cea76065fe319588ba (commit) via 0c7d6db8d7ed1f7158a7210bd0e6f916f720a842 (commit) via d6651ab9490d710d62dfe87d63d70e9ffcbdb040 (commit) from 07f85e7f88a971648449df56c644a0fdbfabce8d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3b8f35de7924c48d8d6290b114bcb71f39453d48 Author: Kyle M Hall Date: Fri Feb 5 00:29:22 2016 +0000 Bug 15629 [QA Followup] * Use ->id instead of ->branchcode when possible to eliminate use of that nomenclature * Fix bad use of ->branchcode to ->{branchcode} for unblessed hashref version of Koha::Library Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit 578b5fef61ff20124f77b96a98b2688796e51b31 Author: Jonathan Druart Date: Tue Feb 2 13:58:16 2016 +0000 Bug 15629: Fix tests - Koha::Library does not have ->categories but ->get_categories Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit d564d3732d95455b4626dfa8ca711cd658003c17 Author: Jonathan Druart Date: Wed Jan 20 13:22:48 2016 +0000 Bug 15629: Koha::Libraries - Remove GetBranchInfo C4::Branch::GetBranchInfo was only used once in opac/opac-suggestions.pl The occurrence can easily be replaced by a call to Koha::Libraries->find Test plan: 1/ Create a suggestion for library A 2/ Enable OPACViewOthersSuggestions 3/ Use a patron from library B to see the suggestions 4/ The "Suggested for" value should be correctly filled with the library A name. Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit a007178b873cc84171549f7a93c63a391a1740ca Author: Jonathan Druart Date: Wed Jan 20 13:13:14 2016 +0000 Bug 15629: Koha::Libraries - Remove ModBranch This subroutine was only used in tests to add/update a library. Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit 4f5217314cefded2aaa82e9bda0dd1ce6d81a88e Author: Jonathan Druart Date: Wed Jan 20 12:17:43 2016 +0000 Bug 15629: Koha::Libraries - Remove GetBranchDetail C4::Branch::GetBranchDetail retrieved library infos, it could be easily replaced with Koha::Libraries->find When this change needs other big changes, the unblessed method is called, to manipulate a hashref (as before) instead of a Koha::Library object (for instance when $library is sent to GetPreparedLetter). Test plan: 1/ Print a basket group, the library names should be correctly displayed. 2/ Enable emailLibrarianWhenHoldIsPlaced and place a hold, a HOLDPLACED notice will be generated (focus on the library name) 3/ Edit a patron and change his/her library 4/ Generate the advanced notices (misc/cronjobs/advance_notices.pl) and have a look at the generated notices 5/ Same of overdues notices 6/ Set IndependentBranches and use a non superlibrarian user to place a hold. The "pickup at" should be correctly filled. Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit f4d6c1cd50702011d72ac8cea76065fe319588ba Author: Jonathan Druart Date: Wed Jan 20 11:22:19 2016 +0000 Bug 15629: Koha::Libraries - Remove GetBranchesInCategory (3) C4::Branch::GetBranchesInCategory is not used anymore and can be removed. Test plan: git grep GetBranchesInCategory should not return any result. Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit 0c7d6db8d7ed1f7158a7210bd0e6f916f720a842 Author: Jonathan Druart Date: Wed Jan 20 11:22:07 2016 +0000 Bug 15629: Koha::Libraries - Remove GetBranchesInCategory (2) C4::Branch::GetBranchesInCategory can be replaced with Koha::LibraryCategory->libraries Test plan: 1/ Define some 1+ group of libraries with 1+ libraries each 2/ Go on the advanced search (OPAC and Staff) and select a group of libraries 3/ The result should be consistent and only include record from these libraries Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit d6651ab9490d710d62dfe87d63d70e9ffcbdb040 Author: Jonathan Druart Date: Wed Jan 20 11:21:12 2016 +0000 Bug 15629: Koha::Libraries - Remove GetBranchesInCategory (1) For consistency, the branchcodes method of Koha::LibraryCategory should be named libraries. At the moment, there is only one occurrence, in admin/branches.pl Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: C4/Acquisition.pm | 7 +- C4/Branch.pm | 196 -------------------- C4/Circulation.pm | 3 +- C4/Letters.pm | 28 +-- C4/Reserves.pm | 14 +- Koha/LibraryCategory.pm | 2 +- acqui/addorderiso2709.pl | 1 - acqui/pdfformat/layout2pages.pm | 32 ++-- acqui/pdfformat/layout2pagesde.pm | 32 ++-- acqui/pdfformat/layout3pages.pm | 32 ++-- acqui/pdfformat/layout3pagesfr.pm | 32 ++-- admin/branches.pl | 2 +- catalogue/ISBDdetail.pl | 1 - catalogue/search.pl | 4 +- members/members-home.pl | 9 +- members/moremember.pl | 5 +- misc/cronjobs/advance_notices.pl | 3 +- misc/cronjobs/notice_unprocessed_suggestions.pl | 5 +- misc/cronjobs/overdue_notices.pl | 9 +- opac/opac-search.pl | 4 +- opac/opac-suggestions.pl | 3 +- reserve/request.pl | 3 +- t/db_dependent/Branch.t | 127 +++---------- t/db_dependent/Circulation/CheckIfIssuedToPatron.t | 4 +- t/db_dependent/Circulation/CheckValidBarcode.t | 4 +- t/db_dependent/Circulation/GetIssues.t | 3 +- t/db_dependent/Circulation/MarkIssueReturned.t | 4 +- t/db_dependent/Circulation_Branch.t | 8 +- t/db_dependent/Circulation_Issuingrule.t | 8 +- t/db_dependent/Circulation_OfflineOperation.t | 5 +- t/db_dependent/Circulation_issue.t | 8 +- t/db_dependent/ILSDI_Services.t | 6 +- t/db_dependent/Items.t | 14 +- t/db_dependent/Koha/Libraries.t | 2 +- t/db_dependent/Letters.t | 12 +- t/db_dependent/Members/GetAllIssues.t | 4 +- t/db_dependent/Members/GetOverdues.t | 4 +- t/db_dependent/Members/GetPendingIssues.t | 4 +- t/db_dependent/Members/IssueSlip.t | 4 +- t/db_dependent/RotatingCollections.t | 5 +- t/db_dependent/Suggestions.t | 7 +- t/db_dependent/Template/Plugin/Branches.t | 7 +- t/db_dependent/Utils/Datatables_Members.t | 6 +- t/db_dependent/Utils/Datatables_Virtualshelves.t | 5 +- 44 files changed, 199 insertions(+), 479 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 05:08:10 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 04:08:10 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-654-g8e997fb Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 8e997fbafcc635b275c6ca1211e47a4cd38c8140 (commit) via fdc06dec2a6e827a5c04c048a0478a2f80d2cd76 (commit) from 3b8f35de7924c48d8d6290b114bcb71f39453d48 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8e997fbafcc635b275c6ca1211e47a4cd38c8140 Author: Kyle M Hall Date: Thu Feb 4 22:13:55 2016 +0000 Bug 15471 [QA Followup] - Fix error causing visibility button to not display Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit fdc06dec2a6e827a5c04c048a0478a2f80d2cd76 Author: Julian Maurice Date: Tue Jan 5 12:24:57 2016 +0100 Bug 15471: Add column settings and filters to Holds queue table Add column visibility menu using DataTables Buttons Add a text filter on top of each column Also extend page width so that the large table is better centered Depends on bug 15285 Test plan 1. Go to Holds queue page (circ/view_holdsqueue.pl) 2. Check that table sorting and filtering work well and that you can hide each column 3. Go to Admin > Configure columns and change the settings for this table (Circulation > view_holdsqueue > holds-table). Verify that the settings work by going again to the Holds queue page 4. Check that filters continue to work after hiding some columns Tested on top of 15285, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: admin/columns_settings.yml | 25 ++++++ koha-tmpl/intranet-tmpl/prog/en/css/datatables.css | 4 +- .../prog/en/modules/circ/view_holdsqueue.tt | 95 ++++++++++++++++++-- 3 files changed, 113 insertions(+), 11 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 05:09:43 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 04:09:43 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-656-g3a45020 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 3a450208b720d7f11dd89901a920222cb3e7d945 (commit) via beef718a0795623da94931b6879be6b1ee1c6f4d (commit) from 8e997fbafcc635b275c6ca1211e47a4cd38c8140 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3a450208b720d7f11dd89901a920222cb3e7d945 Author: Kyle M Hall Date: Thu Feb 4 22:38:32 2016 +0000 Bug 15465 [QA Followup] - Update wording, switch logo, add links * Changed wording to not be github-centric * Added suggested links * Switched to more traditional logo Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit beef718a0795623da94931b6879be6b1ee1c6f4d Author: Gus Date: Wed Jan 20 20:44:00 2016 +0000 Bug 15465 - Created README.md file for github Signed-off-by: Mirko Tietgen Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: README.md | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) create mode 100644 README.md hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 05:11:59 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 04:11:59 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-660-g0e58904 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 0e5890475e90711b9f4232d6c380291cb3f3cee4 (commit) via 21745ec3f7c84e1868144733714a0e7d99c0bcfc (commit) via 7d8b1ce26944345e4b1a9726065a9846c4a46cac (commit) via 714899c7f8535f6f970726c784a0074722c86665 (commit) from 3a450208b720d7f11dd89901a920222cb3e7d945 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0e5890475e90711b9f4232d6c380291cb3f3cee4 Author: Nick Clemens Date: Fri Feb 5 16:01:17 2016 +0000 Bug 15343 [QA Followup] * Check for leading/trailing spaces in password * Check hashed password in tests Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit 21745ec3f7c84e1868144733714a0e7d99c0bcfc Author: Nick Clemens Date: Fri Jan 15 15:53:30 2016 +0000 Bug 15343 [QA Follow up] Fix captcha display Make captcha visible even if password field is hidden Remove password confirmation field before submitting modification Signed-off-by: Jesse Weaver Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit 7d8b1ce26944345e4b1a9726065a9846c4a46cac Author: Kyle M Hall Date: Fri Dec 18 19:30:13 2015 +0000 Bug 15343 [QA Followup] - Fix issues 1) "Contact information" should be "Password" 2) Don't pass sysprefs from the script to the template, use Koha.Preference() 3) minPasswordLength is optional, we cannot always assume it is set 4) Password field when does not follow convention completely when mandatory Signed-off-by: Nick Clemens Signed-off-by: Jesse Weaver Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit 714899c7f8535f6f970726c784a0074722c86665 Author: Nick Clemens Date: Sat Dec 12 02:10:06 2015 +0000 Bug 15343 - Allow user to set password on opac-memberentry.pl This patch allows patrons to create thier own password during OPAC self registration. It sets the password field to be hidden by default, and allows for a system generated password if no password is supplied and field is not mandatory 1 - Apply patch 2 - run updatedatabase.pl 3 - Check syspref "PatronSelfRegistrationBorrowerUnwantedField" - it should contain 'password' 4 - Check self registration on opac - there should be no change 5 - Remove 'password' from PatronSelfRegistrationBorrowerUnwantedField 6 - Password field should now be visible in OPAC self registration 7 - Register a patron: If no passwor is supplied you should get a system generated password 8 - Register a patron with a password, your password should be used 9 - Add 'password' to PatronSelfRegistrationBorrowerMnadatoryField 10 - Attempt to register a patron with no password - it should fail 11 - Try all combinations if mismatched/short/missing passwords and view correct error messages 12 - prove t/db_dependent/Members.t Sponsored by : Do Space (www.dospace.org) Signed-off-by: Jesse Weaver Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: C4/Members.pm | 13 +++--- ...RegistrationBorrowrUnwantedField_by_default.sql | 1 + .../bootstrap/en/modules/opac-memberentry.tt | 44 +++++++++++++++++++- opac/opac-memberentry.pl | 13 +++++- t/db_dependent/Members.t | 14 ++++++- 5 files changed, 76 insertions(+), 9 deletions(-) create mode 100644 installer/data/mysql/atomicupdate/bug_15343-add_password_to_PatronSelfRegistrationBorrowrUnwantedField_by_default.sql hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 05:17:02 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 04:17:02 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-661-gdcae2ad Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via dcae2ad7b411d9040a76413db68922253a6aa400 (commit) from 0e5890475e90711b9f4232d6c380291cb3f3cee4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit dcae2ad7b411d9040a76413db68922253a6aa400 Author: Brendan Gallagher Date: Wed Feb 24 04:09:36 2016 +0000 DBRev Bug 15343 - Allow patrons to choose their own password on self registration Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- ..._PatronSelfRegistrationBorrowrUnwantedField_by_default.sql | 1 - installer/data/mysql/updatedatabase.pl | 9 +++++++++ 3 files changed, 10 insertions(+), 2 deletions(-) delete mode 100644 installer/data/mysql/atomicupdate/bug_15343-add_password_to_PatronSelfRegistrationBorrowrUnwantedField_by_default.sql hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 14:28:45 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 13:28:45 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-663-gf0d8e0d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f0d8e0d6575e68a1ce4978cb09edd7273acb728e (commit) via e146afa93acc51c0613467dd488f8d6918c80ac5 (commit) from dcae2ad7b411d9040a76413db68922253a6aa400 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f0d8e0d6575e68a1ce4978cb09edd7273acb728e Author: Kyle M Hall Date: Wed Feb 24 13:34:09 2016 +0000 Bug 15891 [Followup] Signed-off-by: Kyle M Hall commit e146afa93acc51c0613467dd488f8d6918c80ac5 Author: Marcel de Rooy Date: Wed Feb 24 13:39:38 2016 +0100 Bug 15891: Fix errors on updatedatabase Two curly braces.. Test plan: Run the update. Signed-off-by: Marcel de Rooy Signed-off-by: Julian Maurice Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/updatedatabase.pl | 26 +++++++++++++++----------- 1 file changed, 15 insertions(+), 11 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 24 17:46:15 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 24 Feb 2016 16:46:15 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-666-g2114fd6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2114fd67e00f000080d1fad44d5d15289996b3cd (commit) via 635bc98ab89847dbd25625a64eb3fa14f28f95eb (commit) via 4270c1443f1a66de2c9ba7f781176c8c3914c88b (commit) from f0d8e0d6575e68a1ce4978cb09edd7273acb728e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2114fd67e00f000080d1fad44d5d15289996b3cd Author: Kyle M Hall Date: Wed Feb 24 16:45:36 2016 +0000 Bug 15071 [QA Followup] - Update compiled css again Signed-off-by: Kyle M Hall commit 635bc98ab89847dbd25625a64eb3fa14f28f95eb Author: Owen Leonard Date: Wed Feb 17 21:19:30 2016 -0500 Bug 15071 - In OPAC search results, "checked out" status should be more visible - Compiled CSS Compiled CSS file. Signed-off-by: Nicole C Engard