[koha-commits] main Koha release repository branch master updated. v3.22.00-498-g5fec490
Git repo owner
gitmaster at git.koha-community.org
Fri Feb 12 20:43:25 CET 2016
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 5fec49009342c77860b054996008f8ef5269af68 (commit)
via 7ef9c1b6f5d490c3e3d9ac8f201410e30ac847cc (commit)
via 7cb660c665010c056e9e2c6ccddaebfdd3033a00 (commit)
via 1427cacfe74e4cdc3a4aa4d400e3b02305dfc6ec (commit)
via de3289506dcda91510dc9c7a867558a29ebefd57 (commit)
via bd7e79940d548c417580bb79a2f250751fc4575c (commit)
from 71d4942c30f30fdbdf89a93f59e89a4f28e0dd3f (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 5fec49009342c77860b054996008f8ef5269af68
Author: Jesse Weaver <jweaver at bywatersolutions.com>
Date: Fri Feb 12 12:43:32 2016 -0700
Bug 15446 - DBrev 3.23.000.018
Signed-off-by: Jesse Weaver <jweaver at bywatersolutions.com>
commit 7ef9c1b6f5d490c3e3d9ac8f201410e30ac847cc
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Feb 11 10:02:56 2016 +0000
Bug 15446 [QA Followup] - Update new classes
Signed-off-by: Jesse Weaver <jweaver at bywatersolutions.com>
commit 7cb660c665010c056e9e2c6ccddaebfdd3033a00
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jan 5 15:24:46 2016 +0000
Bug 15446: (follow-up) Rename Koha::Object[s]->type with _type
Some occurrences have been pushed in the meantime.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jesse Weaver <jweaver at bywatersolutions.com>
commit 1427cacfe74e4cdc3a4aa4d400e3b02305dfc6ec
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Dec 30 17:19:02 2015 +0000
Bug 15446: Update systempreferences rows where type=YesNo and value=''
Signed-off-by: Marc Véron <veron at veron.ch>
Amended to fix typo in sql statement.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jesse Weaver <jweaver at bywatersolutions.com>
commit de3289506dcda91510dc9c7a867558a29ebefd57
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Dec 30 17:15:31 2015 +0000
Bug 15446: Rename Koha::Object[s]->type with _type
In a few case (at least systempreferences and export_format (csv profiles),
the type method of Koha::Object and Koha::Objects can be in conflict with the
column names.
Indeed systempreferences.type exists and so the method will return
'Systempreference' (the name of the module) instead of the value of the row in
DB.
I have found at least 1 place where it can cause issue:
In C4::Context->set_preference:
601 my $syspref = Koha::Config::SysPrefs->find( $var );
602 my $type = $syspref ? $syspref->type() : undef;
603
604 $value = 0 if ( $type && $type eq 'YesNo' && $value eq '' );
type will always be 'Systempreference' and the YesNo pref will be set to an
empty string '' instead of 0.
I am not sure about the consequences of this, but it is preferable to
fix it ASAP.
To reproduce:
0/ Do not apply this patch
1/ Edit a YesNo prefs, AutoEmailOpacUser for instance
2/ Set it to "Don't sent"
3/ Check the value in DB, it should be set to an empty string, instead
of 0
4/ Apply this patch and try again. Now the value should be 0
Followed test plan, value is now 0 as expected.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jesse Weaver <jweaver at bywatersolutions.com>
commit bd7e79940d548c417580bb79a2f250751fc4575c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Dec 30 17:11:45 2015 +0000
Bug 15446: Add tests
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jesse Weaver <jweaver at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
Koha.pm | 2 +-
Koha/AudioAlert.pm | 2 +-
Koha/AudioAlerts.pm | 2 +-
Koha/AuthorisedValue.pm | 2 +-
Koha/AuthorisedValues.pm | 2 +-
Koha/Authorities.pm | 2 +-
Koha/Authority.pm | 2 +-
Koha/Authority/Type.pm | 2 +-
Koha/Authority/Types.pm | 2 +-
Koha/Biblio.pm | 2 +-
Koha/BiblioFramework.pm | 2 +-
Koha/BiblioFrameworks.pm | 2 +-
Koha/Biblioitem.pm | 2 +-
Koha/Biblioitems.pm | 2 +-
Koha/Biblios.pm | 2 +-
Koha/Borrower.pm | 2 +-
Koha/Borrowers.pm | 2 +-
Koha/Cities.pm | 2 +-
Koha/City.pm | 2 +-
Koha/Config/SysPref.pm | 2 +-
Koha/Config/SysPrefs.pm | 2 +-
Koha/Hold.pm | 2 +-
Koha/Holds.pm | 2 +-
Koha/IssuingRule.pm | 2 +-
Koha/IssuingRules.pm | 2 +-
Koha/Item.pm | 2 +-
Koha/ItemType.pm | 2 +-
Koha/ItemTypes.pm | 2 +-
Koha/Items.pm | 2 +-
Koha/Libraries.pm | 2 +-
Koha/Library.pm | 2 +-
Koha/LibraryCategories.pm | 2 +-
Koha/LibraryCategory.pm | 2 +-
Koha/Localization.pm | 2 +-
Koha/Localizations.pm | 2 +-
Koha/Object.pm | 22 +++++++++++-----------
Koha/Objects.pm | 14 ++++++--------
Koha/Patron/Categories.pm | 2 +-
Koha/Patron/Category.pm | 2 +-
Koha/Serial.pm | 2 +-
Koha/Serials.pm | 2 +-
Koha/Subscription.pm | 2 +-
Koha/Subscription/Histories.pm | 2 +-
Koha/Subscription/History.pm | 2 +-
Koha/Subscriptions.pm | 2 +-
Koha/Virtualshelf.pm | 2 +-
Koha/Virtualshelfcontent.pm | 2 +-
Koha/Virtualshelfcontents.pm | 2 +-
Koha/Virtualshelfshare.pm | 2 +-
Koha/Virtualshelfshares.pm | 2 +-
Koha/Virtualshelves.pm | 2 +-
installer/data/mysql/updatedatabase.pl | 10 ++++++++++
t/db_dependent/Context.t | 5 +++++
53 files changed, 81 insertions(+), 68 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list