[koha-commits] main Koha release repository branch master updated. v3.22.00-652-g3b8f35d
Git repo owner
gitmaster at git.koha-community.org
Wed Feb 24 05:02:30 CET 2016
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 3b8f35de7924c48d8d6290b114bcb71f39453d48 (commit)
via 578b5fef61ff20124f77b96a98b2688796e51b31 (commit)
via d564d3732d95455b4626dfa8ca711cd658003c17 (commit)
via a007178b873cc84171549f7a93c63a391a1740ca (commit)
via 4f5217314cefded2aaa82e9bda0dd1ce6d81a88e (commit)
via f4d6c1cd50702011d72ac8cea76065fe319588ba (commit)
via 0c7d6db8d7ed1f7158a7210bd0e6f916f720a842 (commit)
via d6651ab9490d710d62dfe87d63d70e9ffcbdb040 (commit)
from 07f85e7f88a971648449df56c644a0fdbfabce8d (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 3b8f35de7924c48d8d6290b114bcb71f39453d48
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Feb 5 00:29:22 2016 +0000
Bug 15629 [QA Followup]
* Use ->id instead of ->branchcode when possible to eliminate use of that nomenclature
* Fix bad use of ->branchcode to ->{branchcode} for unblessed hashref version of Koha::Library
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
commit 578b5fef61ff20124f77b96a98b2688796e51b31
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Feb 2 13:58:16 2016 +0000
Bug 15629: Fix tests - Koha::Library does not have ->categories but ->get_categories
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
commit d564d3732d95455b4626dfa8ca711cd658003c17
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jan 20 13:22:48 2016 +0000
Bug 15629: Koha::Libraries - Remove GetBranchInfo
C4::Branch::GetBranchInfo was only used once in opac/opac-suggestions.pl
The occurrence can easily be replaced by a call to Koha::Libraries->find
Test plan:
1/ Create a suggestion for library A
2/ Enable OPACViewOthersSuggestions
3/ Use a patron from library B to see the suggestions
4/ The "Suggested for" value should be correctly filled with the library
A name.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
commit a007178b873cc84171549f7a93c63a391a1740ca
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jan 20 13:13:14 2016 +0000
Bug 15629: Koha::Libraries - Remove ModBranch
This subroutine was only used in tests to add/update a library.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
commit 4f5217314cefded2aaa82e9bda0dd1ce6d81a88e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jan 20 12:17:43 2016 +0000
Bug 15629: Koha::Libraries - Remove GetBranchDetail
C4::Branch::GetBranchDetail retrieved library infos, it could be easily
replaced with Koha::Libraries->find
When this change needs other big changes, the unblessed method is
called, to manipulate a hashref (as before) instead of a Koha::Library
object (for instance when $library is sent to GetPreparedLetter).
Test plan:
1/ Print a basket group, the library names should be correctly
displayed.
2/ Enable emailLibrarianWhenHoldIsPlaced and place a hold, a HOLDPLACED
notice will be generated (focus on the library name)
3/ Edit a patron and change his/her library
4/ Generate the advanced notices (misc/cronjobs/advance_notices.pl) and
have a look at the generated notices
5/ Same of overdues notices
6/ Set IndependentBranches and use a non superlibrarian user to place a
hold. The "pickup at" should be correctly filled.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
commit f4d6c1cd50702011d72ac8cea76065fe319588ba
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jan 20 11:22:19 2016 +0000
Bug 15629: Koha::Libraries - Remove GetBranchesInCategory (3)
C4::Branch::GetBranchesInCategory is not used anymore and can be
removed.
Test plan:
git grep GetBranchesInCategory
should not return any result.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
commit 0c7d6db8d7ed1f7158a7210bd0e6f916f720a842
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jan 20 11:22:07 2016 +0000
Bug 15629: Koha::Libraries - Remove GetBranchesInCategory (2)
C4::Branch::GetBranchesInCategory can be replaced with
Koha::LibraryCategory->libraries
Test plan:
1/ Define some 1+ group of libraries with 1+ libraries each
2/ Go on the advanced search (OPAC and Staff) and select a group of
libraries
3/ The result should be consistent and only include record from these
libraries
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
commit d6651ab9490d710d62dfe87d63d70e9ffcbdb040
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jan 20 11:21:12 2016 +0000
Bug 15629: Koha::Libraries - Remove GetBranchesInCategory (1)
For consistency, the branchcodes method of Koha::LibraryCategory should be
named libraries.
At the moment, there is only one occurrence, in admin/branches.pl
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
-----------------------------------------------------------------------
Summary of changes:
C4/Acquisition.pm | 7 +-
C4/Branch.pm | 196 --------------------
C4/Circulation.pm | 3 +-
C4/Letters.pm | 28 +--
C4/Reserves.pm | 14 +-
Koha/LibraryCategory.pm | 2 +-
acqui/addorderiso2709.pl | 1 -
acqui/pdfformat/layout2pages.pm | 32 ++--
acqui/pdfformat/layout2pagesde.pm | 32 ++--
acqui/pdfformat/layout3pages.pm | 32 ++--
acqui/pdfformat/layout3pagesfr.pm | 32 ++--
admin/branches.pl | 2 +-
catalogue/ISBDdetail.pl | 1 -
catalogue/search.pl | 4 +-
members/members-home.pl | 9 +-
members/moremember.pl | 5 +-
misc/cronjobs/advance_notices.pl | 3 +-
misc/cronjobs/notice_unprocessed_suggestions.pl | 5 +-
misc/cronjobs/overdue_notices.pl | 9 +-
opac/opac-search.pl | 4 +-
opac/opac-suggestions.pl | 3 +-
reserve/request.pl | 3 +-
t/db_dependent/Branch.t | 127 +++----------
t/db_dependent/Circulation/CheckIfIssuedToPatron.t | 4 +-
t/db_dependent/Circulation/CheckValidBarcode.t | 4 +-
t/db_dependent/Circulation/GetIssues.t | 3 +-
t/db_dependent/Circulation/MarkIssueReturned.t | 4 +-
t/db_dependent/Circulation_Branch.t | 8 +-
t/db_dependent/Circulation_Issuingrule.t | 8 +-
t/db_dependent/Circulation_OfflineOperation.t | 5 +-
t/db_dependent/Circulation_issue.t | 8 +-
t/db_dependent/ILSDI_Services.t | 6 +-
t/db_dependent/Items.t | 14 +-
t/db_dependent/Koha/Libraries.t | 2 +-
t/db_dependent/Letters.t | 12 +-
t/db_dependent/Members/GetAllIssues.t | 4 +-
t/db_dependent/Members/GetOverdues.t | 4 +-
t/db_dependent/Members/GetPendingIssues.t | 4 +-
t/db_dependent/Members/IssueSlip.t | 4 +-
t/db_dependent/RotatingCollections.t | 5 +-
t/db_dependent/Suggestions.t | 7 +-
t/db_dependent/Template/Plugin/Branches.t | 7 +-
t/db_dependent/Utils/Datatables_Members.t | 6 +-
t/db_dependent/Utils/Datatables_Virtualshelves.t | 5 +-
44 files changed, 199 insertions(+), 479 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list