[koha-commits] main Koha release repository branch master updated. v3.22.00-256-g6cf157f

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  6cf157f9930fc1deb47da2d5c3b7f3abc3e7e3c4 (commit)
      from  d4c5bce132964a1b789cd84da2d5fefb43a1de35 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 6cf157f9930fc1deb47da2d5c3b7f3abc3e7e3c4
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Jan 5 15:08:23 2016 +0000

    Bug 15473: Make Koha::Objects->find accepts 0 and '' as a key
    
    This bug has been found after bug 15381 was pushed:
    If you go on authorities/authorities.pl, you expect a form to create a
     authorities with a "Default" authority type.
    Now, it explodes:
        Can't call method "authtypetext" on an undefined value at
        /home/koha/src/authorities/authorities.pl line 665.
    
    Koha::Objects->find does not want to search if the key does not exist
    (undef, '', 0). But actually it should only be a coward if it is not defined.
    
    Moreover this is the default behavior of the DBIx::Class find method.
    
    Test plan:
      prove t/db_dependent/Koha/Objects.t
    should return green
    and
      GET /cgi-bin/koha/authorities/authorities.pl
    should not make everything explode.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Find this after signing 15470 :)
    Test pass, new auth (Default) created, no errors.
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com

-----------------------------------------------------------------------

Summary of changes:
 Koha/Objects.pm                                    |    2 +-
 .../Koha/Objects.t}                                |   20 +++++++++++++-------
 2 files changed, 14 insertions(+), 8 deletions(-)
 copy t/{RotatingCollections.t => db_dependent/Koha/Objects.t} (63%)
 mode change 100755 => 100644


hooks/post-receive
-- 
main Koha release repository