[koha-commits] main Koha release repository branch master updated. v3.22.00-314-gd10adb2
Git repo owner
gitmaster at git.koha-community.org
Wed Jan 27 01:56:58 CET 2016
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via d10adb26aa661a6b5f6dc9b2fd6f8ab966f98918 (commit)
via 31ffdbf49af617db29c8b6bfcaf01566d84f2a33 (commit)
from 65895285d9c47e7fab13b0f67d0d0f7409c0673d (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit d10adb26aa661a6b5f6dc9b2fd6f8ab966f98918
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Jan 8 17:00:36 2016 +0000
Bug 15530 - Editing a course item via a disabled course disables it even if it is on other enabled courses
It appears that if the course item is edited by clicking the edit link
from an active course, the course item will be set to enabled and the
fields will be swapped, if the same course item is edited from a course
that is *not* active, the course item will be set to *not* enabled, and
the original fields will be swapped back in!
The short term work-around is to only edit course items from an enabled
course if the item has a course that is enabled. If all the courses it
is on are disabled, it doesn't matter what course the item is edited
from.
Test Plan:
1) Create two courses, 1 enabled and 1 disabled
2) Add an item as a course reserve to both courses
3) Edit the course reserve data for the item via the enabled course
4) Note the course item is enabled ( easy way is to check the database )
5) Edit the same course reserve data, but via the disabled course
6) Note the course item is now disabled even though it is part of
an enabled course!
7) Apply this patch
8) Repeat steps 1 through 5
9) Note the course item is still enabled
Signed-off-by: Margaret Holt <mholt at bastyr.edu>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
commit 31ffdbf49af617db29c8b6bfcaf01566d84f2a33
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Jan 8 17:00:18 2016 +0000
Bug 15530 - Add Unit Test
Signed-off-by: Margaret Holt <mholt at bastyr.edu>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/CourseReserves.pm | 22 ++++++++++------------
t/db_dependent/CourseReserves.t | 24 +++++++++++++++++++++++-
2 files changed, 33 insertions(+), 13 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list