[koha-commits] main Koha release repository branch master updated. v3.22.00-325-g372881e
Git repo owner
gitmaster at git.koha-community.org
Wed Jan 27 03:05:36 CET 2016
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 372881ebfd5552ecb83450c7afea6a76f2df1a0b (commit)
via c273e888b0468c6d8e943f9989f6680dc63203fa (commit)
via 960458dee4a9c09506f48fa73950c0e2da3611e7 (commit)
from dcce65c8fd6f6d4963a3dd0e8b73a79548a2aa8b (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 372881ebfd5552ecb83450c7afea6a76f2df1a0b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Dec 28 15:47:01 2015 +0000
Bug 15209: Check the parameter at the beginning of the subroutines
It seems better to check if parameters exist at the beginning of a
subroutine.
It makes the code easier to read and there is 1 indentation level less.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
commit c273e888b0468c6d8e943f9989f6680dc63203fa
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Dec 28 15:46:59 2015 +0000
Bug 15209: Add tests
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
commit 960458dee4a9c09506f48fa73950c0e2da3611e7
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date: Wed Nov 18 14:53:58 2015 +0000
Bug 15209 Validate passed MARC::Record objs in C4::Koha
Ensure that a passed MARC::Record is defined before calling
its methods. Otherwise you are open to occurences of the
error 'Can't call method "field" on an undefined value'
In a CGI environment you can live with such sloppiness but
in a persistent environment the error can cause the instance
to abort.
Made all routines passed a MARC::Record validate it before calling
its methods. Changed the parameter name from the meaningless
record to marcrecord to indicate its content. Added an explicit return
for all cases where no valid data returned. Cleaned up some logic for
clarity. I think we can assume that GetNormalizedOCLCNumber meant to
look at all 035s till it found an OCLC number not just the first.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Koha.pm | 64 ++++++++++++++++++++++++++++--------------------------------
t/Koha.t | 7 ++++++-
2 files changed, 36 insertions(+), 35 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list