[koha-commits] main Koha release repository branch master updated. v3.22.00-327-g581759e

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  581759e985c170db0edb4a895cda641930e5ac11 (commit)
      from  560bc790db6d3f8f2ff6b4e70db148445ff645e4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 581759e985c170db0edb4a895cda641930e5ac11
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Aug 21 10:43:13 2015 +0100

     Bug 14133: Print notices should be generated with the print template
    
    If the overdue notice to send is an email or a SMS and the patron does
    not provided such information, a print notice is generated.
    But it will be generated with the email or sms template, which is not
    useful, especially in the SMS case.
    
    The template to use should be the print one.
    
    Test plan:
    0/ Does not apply this patch and Correctly define the overdue rules to generate
    an overdue notice to the message_queue table.
    Check email + SMS
    1/ Define an email address and a SMS number for a patron
    2/ Generate the overdue notices (misc/cronjobs/overdue_notices.pl [-t])
    3/ 2 notices should have been generated:
        mtt=email with the email template used
        mtt=sms   with the sms template used
    4/ Truncate the message_queue table
    5/ Remove the email address and repeat 2
    6/ Only 1 notice should have been generated:
        mtt=print with the email template used
    7/ Truncate the message_queue table
    8/ Remove the sms alert number and repeat 2
    9/ 2 notices should have been generated:
        mtt=print with the email template used (or sms I suppose)
    
    10/ Apply this patch and repeat previous steps.
    The print notices should be generated with the print template.
    
    IMPORTANT NOTE: This test plan does not take into account the notices
    generated for the staff ("These messages were not sent directly to the
    patrons."). However the behavior will also change, the print template
    will be used in all cases. Is it what we want?
    
    Signed-off-by: Chris <chris at bigballofwax.co.nz>
    
    Seems fine by me
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 misc/cronjobs/overdue_notices.pl |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository