[koha-commits] main Koha release repository branch master updated. v3.22.00-441-g8ec7572

Wed Jan 27 07:41:48 CET 2016

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  8ec7572d0ccd0aec27a8900725118e4da9a9a25a (commit)
       via  45d8575e3a15dfe871595afd561681a636d5f407 (commit)
       via  563688050cf590a3a136d3644256192d37265b7c (commit)
       via  76d1509838cb14dbdcaaa8ec495ebe72fb5db34e (commit)
       via  70898717c19676f7568b7c7c1cb5e1d250e3b38d (commit)
       via  0f2aea716a9cbdb3431872a8bff2002b3e2e77be (commit)
       via  b99f1dcbfcc1f3a6736a3f1bcc0a2debaba0cefb (commit)
       via  d5abcbc8f3afef9272a93b455e3e8516c833067a (commit)
      from  192239fd79cacfdcc9d0fccc497773107b9752ab (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8ec7572d0ccd0aec27a8900725118e4da9a9a25a
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Jan 22 10:18:29 2016 +0100

    Bug 8753: [QA Follow-up] Primary key and collation

    This patch includes:
    [1] Adds primary key borrowernumber to new table.
    [2] Fixes collation.
    [3] Removes manual PK in DBIx schema file.
    [4] Fixes typo CompletePasswordRevovery.
    [5] Removes use strict from opac-password-recovery; Modern::Perl is used.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

commit 45d8575e3a15dfe871595afd561681a636d5f407
Author: Charles Farmer <charles.farmer at inlibro.com>
Date:   Mon Nov 30 09:20:57 2015 -0500

    Bug 8753 - propagating the changes to kohastructure.sql and sysprefs.sql

    Signed-off-by: Liz Rea <liz at catalyst.net.nz>
    Looks good with a new install.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

commit 563688050cf590a3a136d3644256192d37265b7c
Author: Liz Rea <liz at catalyst.net.nz>
Date:   Wed Oct 7 15:08:10 2015 +1300

    Bug 8753 - Various little things - removing new dependency, changes to errors, textual updates

    Koha already has a sub that creates salts, so lets use that instead of math::Random::secure, so as not to add a new dependency.

    Made the references to "Forgotten password" consistent, including adding it to the title of the page.

    Also removed the individual error for "this email doesn't belong to this account" as that could expose the existence of a login, which I think we'd rather not do.

    Made some of the text more grammatically correct, and more library specific.

    To test:

    Apply on top of all of the other patches.

    All the usual checks, plus make sure there are no typos in any text references.

    Signed-off-by: Marc Veron <veron at veron.ch>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

commit 76d1509838cb14dbdcaaa8ec495ebe72fb5db34e
Author: Charles Farmer <charles.farmer at inlibro.com>
Date:   Wed Sep 30 10:03:05 2015 -0400

    Bug 8753 - Smartmatch substitute, Math::Random::Secure, Perltidy, Passwordrecovery.t

    This is a collection of changes taken from different comments (but mostly comment 21 and comment 122).

    Passes qa and prove, on my machine at least.

    There's also a new test file, Passwordrecovery.t, which covers every method of C4::Passwordrecovery.

    To test:

    All normal checks plus :

        1/ Receive the email
        2/ Click on the link
        3/ Change the pwd
        4/ Click again on the link
        5/ You should immediately get an error message

    Problems with Math/Random/Secure.pm, is solved in following patch, signing off
    Signed-off-by: Marc Veron <veron at veron.ch>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

commit 70898717c19676f7568b7c7c1cb5e1d250e3b38d
Author: Liz Rea <liz at catalyst.net.nz>
Date:   Thu Aug 20 10:52:59 2015 +1200

    Bug 8753 - [followup] POD cleanup

    Check to make sure the messages from the qa checker are gone.

    Note I'm not sure about this one because my test tools are apparently broken, and I can't get the error to manifest.

    Amended patch by Jonathan Druart: Add a blank line before =head2
    It now passes.

    Signed-off-by: Marc Veron <veron at veron.ch>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

commit 0f2aea716a9cbdb3431872a8bff2002b3e2e77be
Author: mxbeaulieu <maxime.beaulieu at inlibro.com>
Date:   Fri Jul 24 16:16:03 2015 -0400

    Bug 8753 - Use Koha::Borrowers instead of C4::Members

    Use the new library to search for borrowers.
    Changed how the $borrower variable is used since it is now a Koha::Borrower object.

    Removed the $protocol parameter from the generated link. It should be included in the OPACBaseURL syspref.

    	modified:   C4/Passwordrecovery.pm
    	modified:   opac/opac-password-recovery.pl

    Signed-off-by: Marc Veron <veron at veron.ch>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

commit b99f1dcbfcc1f3a6736a3f1bcc0a2debaba0cefb
Author: Liz Rea <liz at catalyst.net.nz>
Date:   Thu May 14 10:31:01 2015 +1200

    Bug 8753 - Followup - change value text on syspref

    Followup changes text from "The user can reset | can not reset their password on OPAC" to "Library users are allowed | not allowed to recover their password via e-mail in the OPAC"

    This change more clearly differentiates the purpose of this new preference from OpacPasswordChange.

    Bug 8753 - followup - update text for link to match common UI paradigms, fixes OpacPublic disabled view

    Also corrects OpacNav being included on the reset page on private catalogues.

    Updated the link for forgotten passwords to more closely match common UI paradigms, i.e. Facebook and Twitter

    To test:
    apply all patches, link should now be the less verbose "Forgot your password?"
    disable OpacPublic, anything in opacnav should not appear (you may need to add something to opacnav to test properly)

    Bug 8753 - [followup] fix the title on opac-password-recovery.tt

    The title stanza was missing a <title></title> around it, causing the extra text to appear.

    To test, apply all patches and make sure it looks ok and there is no extra text at the top or bottom of the page.

    Bug 8753 - [followup} Correcting spelling mistakes

    Make sure it all still works

    Bug 8753 - [followup] fix error when no information is provided

    To test:

    All normal checks plus make sure that a nice error is displayed when no data is provided.

    fixing the deprecated thing

    Signed-off-by: Marc Veron <veron at veron.ch>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

commit d5abcbc8f3afef9272a93b455e3e8516c833067a
Author: Maxime Beaulieu <maxime.beaulieu at inlibro.com>
Date:   Wed Mar 11 13:52:59 2015 -0400

    Bug 8753 - Add forgot password link to OPAC

     I've addressed a lot of Liz Rea's points.

    1.  I have moved the code from updatedatabase.pl and kohastructure.sql to a file in the atomicupdates directory.
    1a. The feature is now off by default when the atomicupdate is run.

    2.  The password reset link is now visible on the home page, in the modal box and on opac-user.pl .

    3.  The password recovery pages now use bootstrap markup.

    4.  I am unsure here. I see "New Password:" and "Confirm new password:".

    5.  This should still work :).

    6.  I could not reproduce.

    7.  I have added the userid field.
        You can now reset the password by submitting either your useid or email address.
        Both fields can be filled, but the email address must be one of the borrower's (email, emailpro or b_email).
        When entering only the email address and two borrowers use that same address, the system tells the user to try with another address or to specify his userid.

    8.  The text is in the atomicupdate file. Have at it, anyone.

    Concerning the email. It is inconvenient for the use to have to wait X minutes for the message queue the be processed.
    Maybe we could add a sub in Letters.pm that:
        Takes the same argments as EnqueueLetter
        Sends the letter.
        Saves the letter in the message queue with a 'sent' status.

     TEST PLAN:

    Setup)
        1) apply the patch
        2) go to system preferences OPAC>>Privacy and set 'OpacResetPassword' to ON.
        2b) make sure that OpacPasswordChange is also ON.
    A)
        1) refresh front page, click on 'Forgot your password' and enter a VALID address
        1b) Also try an INVALID address (valid yet not in your koha db).  An error message will show up.
        2) An email should be received at that address with a link.
        3) Follow the link in the mail to fill the new password.
        Until a satisfactory new password is entered, the old password is not reset.
        4) Go to main page try the new password.
    B)
        1) Repeat the password reset, this time use the userid (username) field.
        2) Try to reset the password using a userid and an email not linked to the account. An error appears.
        3) Make sure the borrower has many available email addresses.
        4) For each email, reset the password using both the userid and the email. The link should be sent to the specified address
    C)
        1) Make sure two borrowers use the same email.
        2) Repeat the reset procedure in test case A). An error message appears

    http://bugs.koha-community.org/show_bug.cgi?id=13068

     Author:    Maxime Beaulieu <maxime.beaulieu at inlibro.com>

    Followed test plan. Works as described.
    Signed-off-by: Marc Veron <veron at veron.ch>

    New sign-off after testing all patches together
    Signed-off-by: Marc Veron <veron at veron.ch>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-----------------------------------------------------------------------

Summary of changes:
 C4/Passwordrecovery.pm                             |  184 +++++++++++++++++++
 Koha/Schema/Result/BorrowerPasswordRecovery.pm     |   79 +++++++++
 .../bug_8753-Add_forgot_password_link_to_OPAC.sql  |   13 ++
 .../data/mysql/en/mandatory/sample_notices.sql     |    4 +
 installer/data/mysql/kohastructure.sql             |   13 ++
 installer/data/mysql/sysprefs.sql                  |    1 +
 .../prog/en/modules/admin/preferences/opac.pref    |    8 +
 .../opac-tmpl/bootstrap/en/includes/masthead.inc   |    5 +
 .../opac-tmpl/bootstrap/en/modules/opac-auth.tt    |    5 +
 .../opac-tmpl/bootstrap/en/modules/opac-main.tt    |    5 +
 .../bootstrap/en/modules/opac-password-recovery.tt |  127 +++++++++++++
 opac/opac-password-recovery.pl                     |  186 ++++++++++++++++++++
 t/db_dependent/Passwordrecovery.t                  |  157 +++++++++++++++++
 13 files changed, 787 insertions(+)
 create mode 100644 C4/Passwordrecovery.pm
 create mode 100644 Koha/Schema/Result/BorrowerPasswordRecovery.pm
 create mode 100644 installer/data/mysql/atomicupdate/bug_8753-Add_forgot_password_link_to_OPAC.sql
 create mode 100644 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt
 create mode 100755 opac/opac-password-recovery.pl
 create mode 100755 t/db_dependent/Passwordrecovery.t

hooks/post-receive
-- 
main Koha release repository