From gitmaster at git.koha-community.org Fri Jul 1 08:20:36 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 01 Jul 2016 06:20:36 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.08-4-g64d2995 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 64d29957894e67b0dfbd0599887eac355772a6b9 (commit) via 341343a8605dd6e9e099cde61ac5fe8024702cd3 (commit) via b49dddc04a301ce8360a5ec66c79daa5c247e672 (commit) via 15041b7b3faae8cef0fcb392cc0934081f05a93d (commit) from 978f8aedf3dddb26cbbc44455c239ab10d3f7dd2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 64d29957894e67b0dfbd0599887eac355772a6b9 Author: Julian Maurice Date: Fri Jul 1 08:19:50 2016 +0200 Bug 10459: Update DB rev (3.22.08.001) commit 341343a8605dd6e9e099cde61ac5fe8024702cd3 Author: Jonathan Druart Date: Tue Jun 7 10:20:53 2016 +0100 Bug 10459: Add tests for borrowers.updated_on Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall (cherry picked from commit ff9de4138a7544f08f835acae93aca124c8efa89) Signed-off-by: Fr?d?ric Demians (cherry picked from commit b68e1038feffc75b1c81cee193e80564213f30d3) Signed-off-by: Julian Maurice commit b49dddc04a301ce8360a5ec66c79daa5c247e672 Author: Mark Tompsett Date: Wed May 25 21:57:34 2016 -0400 Bug 10459 renamed timestamp to updated_on Signed-off-by: Joy Nelson Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall (cherry picked from commit f863e478b994f2631d79821473c773099dc78172) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 947690e2324c72cba4ceca8790a98bcdf30752a8) Signed-off-by: Julian Maurice commit 15041b7b3faae8cef0fcb392cc0934081f05a93d Author: Marcel de Rooy Date: Mon Nov 10 14:17:40 2014 +0100 Bug 10459: Borrowers should have a timestamp This patch adds a timestamp column to the borrowers table in kohastructure and updatedatabase. (And also to the deletedborrowers table.) A timestamp may be useful in synchronizing with external systems (among other reasons). Test plan: Run updatestructure on an existing database, or install a new one. Verify that the borrowers table has a timestamp now. Signed-off-by: Marcel de Rooy Tested updatestructure and running kohastructure.sql. Passed t/db_dependent/Members.t. updatedatabase.pl did not apply. I edited and then run it. Columns were added as expected. Signed-off-by: Marc Veron Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Mark Tompsett Signed-off-by: Joy Nelson Bug 10459: Follow up to update to atomic update methodology Signed-off-by: Bernardo Gonzalez Kriegel New column created, no errors. Signed-off-by: Mark Tompsett Signed-off-by: Joy Nelson Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall (cherry picked from commit 255596ae6c483caf5746745f3656b56e0ea011b4) Signed-off-by: Fr?d?ric Demians (cherry picked from commit b4d40f7d00b38eeb006da58f016a109abae6235b) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- Koha/Schema/Result/Borrower.pm | 18 ++++++++++++++++-- Koha/Schema/Result/Deletedborrower.pm | 18 ++++++++++++++++-- installer/data/mysql/kohastructure.sql | 2 ++ installer/data/mysql/updatedatabase.pl | 18 ++++++++++++++++++ t/db_dependent/Borrowers.t | 17 ++++++++++++++--- 6 files changed, 67 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 1 08:25:59 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 01 Jul 2016 06:25:59 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.08-9-gf44389f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via f44389f3a96f64b43b7cd896a7502550687338d6 (commit) via 3943b8ca4436762ed5ba9d2b51d6e1a4324792fb (commit) via f2156852a78d19c248fb8f8a6e42abb9adc04b19 (commit) via a3557bba8bb71d84aa8e8ce21626c33166450327 (commit) via ee4607cda1f30cb524b69b4cdb07a08e5a95ac7e (commit) from 64d29957894e67b0dfbd0599887eac355772a6b9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f44389f3a96f64b43b7cd896a7502550687338d6 Author: Jonathan Druart Date: Tue Jun 14 10:49:41 2016 +0100 Bug 12748: findSerialByStatus has been renamed with findSerialsByStatus Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 30946eff3cda31d0cc97c6c1c4f1e757dbc4c366) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 9710f07575ea7a56000058a687b1a9e835396b86) Signed-off-by: Julian Maurice commit 3943b8ca4436762ed5ba9d2b51d6e1a4324792fb Author: Jonathan Druart Date: Tue Jun 14 10:43:14 2016 +0100 Bug 12748: Code tidy Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 44062c07b7703190b46701a3fa31665d998eadfb) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 69e4c39c213192b46c4e231d40b7a34d676e6b4a) Signed-off-by: Julian Maurice commit f2156852a78d19c248fb8f8a6e42abb9adc04b19 Author: Jonathan Druart Date: Tue Jun 14 10:39:08 2016 +0100 Bug 12748: Remove warning 'masks earlier declaration in same scope' Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 273d5e53289536797281ca5eb323d5c373d9ea41) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 67b4f25a69b370bb441ed09555ef49e0dd2a1e10) Signed-off-by: Julian Maurice commit a3557bba8bb71d84aa8e8ce21626c33166450327 Author: remi Date: Mon Feb 8 15:04:07 2016 -0500 Bug 12748 - Add test for step 7 and 8 and rename findSerialByStatus https://bugs.koha-community.org/show_bug.cgi?id=12478 Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 1bd5a177d0870332a959e9c773aaec80beeba74b) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 2351db01d32726809e2a00b2c8020e497c2c3931) Signed-off-by: Julian Maurice commit ee4607cda1f30cb524b69b4cdb07a08e5a95ac7e Author: remi Date: Tue Aug 11 11:10:45 2015 -0400 Bug 12748 - Fixes duplicate serials with an "expected" status bug Added a new sub to Serials.pm to be able to get serials with their statuses. Now the sub ModSerialStatus checks for other serials with an "expected" status before doing anything. Also modified Serials.t to be able to test those changes. Test Plan 1) Apply patch 2) Run ./t/db_dependent/Serials.t 3) Validate that there are no errors 4) Go on "Serial collection information" page for a serial of your choice 5) Click on "Generate next" 6) Change the status of the original serial from "late" to "expected" 7) Change the newly generated serial from "expected" to "delete" 8) Validate that there are no new serials created by instruction 7 and that the serial was deleted 9) Run ./t/db_dependent/Serials.t With QA Fixes - Use the constant instead of the code (1 vs EXPECTED) - Avoid interpolation in query - use selectall_arrayref instead of fetchall_arrayref Signed-off-by: Liz Rea Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 10fd9f5ec0d5faa7b54b0bfaf5a7b8fccd665f0a) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 695dc4c370d4d170b41447c583c8bfe91b0609e2) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Serials.pm | 24 ++++++++++++++++++++++-- t/db_dependent/Serials.t | 30 +++++++++++++++++++++++++++++- 2 files changed, 51 insertions(+), 3 deletions(-) mode change 100644 => 100755 t/db_dependent/Serials.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 1 08:33:41 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 01 Jul 2016 06:33:41 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.08-11-gc2ef39e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via c2ef39e66ee6db874d2c15e5c0f48c70b42b1d05 (commit) via 6a6a6e40c32cd60c7fc8844c2d138285be20dd94 (commit) from f44389f3a96f64b43b7cd896a7502550687338d6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c2ef39e66ee6db874d2c15e5c0f48c70b42b1d05 Author: Tomas Cohen Arazi Date: Mon May 9 11:13:38 2016 -0300 Bug 13074: (followup) remove useless diag On running all Items-related tests some useless diag showed up. Removing it. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit de6c1375f76b562970d7515192a002af8babc740) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 5185adc1bae9241f919c8ecd5fc98c4b0b6bd6a4) Signed-off-by: Julian Maurice commit 6a6a6e40c32cd60c7fc8844c2d138285be20dd94 Author: Jonathan Druart Date: Tue May 3 11:08:47 2016 +0100 Bug 13074: Use Koha::Cache to cache the defaults values of a MARC record With the global %default_values_for_mod_from_marc variable, the changes made to the marc_subfield_structure table and especially the links between MARC and DB fields are not safe and might be outdated (if a field is linked/unlinked) Test plan: Under Plack: - Link the barcode field, edit a record and set a barcode. - Remove the mapping for the barcode field and then update again the barcode of the record. The items.barcode DB field must not have been updated. Without this patch, the field should have been updated. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit 8c14c25521eac92a2cb62ab5330deac2e2d5343d) Signed-off-by: Fr?d?ric Demians (cherry picked from commit a50e5f141b14c1ba6f9c491a40db1270a8c7be99) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Items.pm | 17 ++-- admin/biblio_framework.pl | 2 + admin/marc_subfields_structure.pl | 2 + admin/marctagstructure.pl | 3 + t/db_dependent/Items.t | 116 ++++++++++++++++++++++++++- t/db_dependent/Items/GetItemsForInventory.t | 2 - 6 files changed, 132 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 1 08:40:02 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 01 Jul 2016 06:40:02 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.08-15-gb58e864 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via b58e8642b0d6b98a9e59a6e53d21472cb38a1e42 (commit) via d1dff4c3bde88c2b7c2bb6722ef07d1fcf5f5cce (commit) via e41863bfa9bf73066d2ec43a3b8e843fa1f0222f (commit) via 752e31425efa34fa6f21446fb18cf34ba31fc441 (commit) from c2ef39e66ee6db874d2c15e5c0f48c70b42b1d05 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b58e8642b0d6b98a9e59a6e53d21472cb38a1e42 Author: Marcel de Rooy Date: Mon May 23 09:03:23 2016 +0200 Bug 16502: Replace a few other ok-calls by is-calls Trivial changes that speak for themselves.. Signed-off-by: Marcel de Rooy Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 8204024f1c21102c0649dec70d10398131aab953) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 2b7a9479b601e224ff6cdbdcc3162426a4727406) Signed-off-by: Julian Maurice commit d1dff4c3bde88c2b7c2bb6722ef07d1fcf5f5cce Author: Marcel de Rooy Date: Mon May 23 08:58:02 2016 +0200 Bug 16502: Adjust test for GetPlugins The current test assumes that GetPlugins will return the test plugin as the first one in the array. This is not correct. This patch adjusts the test to a grep. Test plan: Run the test. Bonus: Add additional plugins. Run the test again. Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 6ad5770786c6646ce68ffdfec9080645fc25772e) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 64382be0d45ad6d43bb86bda095ca1a3699d1265) Signed-off-by: Julian Maurice commit e41863bfa9bf73066d2ec43a3b8e843fa1f0222f Author: Marcel de Rooy Date: Mon May 16 19:00:16 2016 +0200 Bug 16502: Add additional test to Plugins.t In order to verify if the delete now really works, we add one test in Plugins.t. Test plan: [1] Run the test. [2] Bonus: Comment line 63 in Plugins.t where delete is called. Run the test again. It should fail now. Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 959d69fa0107423ed31e20f4a6afb46d1e5c771c) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 0632256c1aca919ec055dd5f170ac10d84cc8ec7) Signed-off-by: Julian Maurice commit 752e31425efa34fa6f21446fb18cf34ba31fc441 Author: Marcel de Rooy Date: Mon May 16 17:19:54 2016 +0200 Bug 16502: Table koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped after running Plugin.t If you run Plugin.t, the above table will still be present (when you did not enable UseKohaPlugins). This would trigger a warning when running the test a second time. Why? The uninstall call does its work not completely due to a small inconsistency in Koha::Plugins::Handler::delete when calling run without the enable_plugins parameter. This patch resolves that inconsistency and also removes an unneeded skip in Plugin.t in case the KitchenSink module already exists. Note: This is a small fix. But I wonder if the Handler routines run and delete should not have been implemented in Koha::Plugins::Base. Also note that plugins/plugins-uninstall.pl will not be affacted by this change, since it checks whether the pref is enabled before calling the delete method. Test plan: [1] Do not yet install this patch. [2] Verify that plugins are enabled in koha-conf.xml. [3] Disable UseKohaPlugins in System Preferences! [4] Run t/db_dependent/Plugins.t. [5] Verify that table koha_plugin_com_bywatersolutions_kitchensink_mytable still exists. (It should have been deleted.) Remove it manually. [6] Apply this patch. [7] Run the test again. [8] Verify that the table does not exist. [9] Run the test again (without warnings). Signed-off-by: Marcel de Rooy Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 4263ac2b92737024d8d620a751babf72b904b73a) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 4ebe7b489c9798d2456bd3de1d95ec6e027b2b21) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: Koha/Plugins/Handler.pm | 9 ++++++++- t/db_dependent/Plugins.t | 26 +++++++++++++++----------- 2 files changed, 23 insertions(+), 12 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 1 08:43:07 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 01 Jul 2016 06:43:07 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.08-16-g6c65a1d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 6c65a1dce8f0ac1807ff03047584daaaf14ad650 (commit) from b58e8642b0d6b98a9e59a6e53d21472cb38a1e42 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6c65a1dce8f0ac1807ff03047584daaaf14ad650 Author: Jonathan Druart Date: Mon Jun 6 13:31:29 2016 +0100 Bug 16670: (bug 15823 follow-up) CGI->param should not be called in list context Signed-off-by: Jacek Ablewicz Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit 58207446755cb2533fac48252c3b70154b164feb) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 302ac5e2a88d73601ee36fcc7460beca281b6fb7) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: circ/circulation.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 1 08:50:16 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 01 Jul 2016 06:50:16 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.08-17-gffd86f2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via ffd86f218e50124ff0090bb4e41fc4a32cb51b99 (commit) from 6c65a1dce8f0ac1807ff03047584daaaf14ad650 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ffd86f218e50124ff0090bb4e41fc4a32cb51b99 Author: Tomas Cohen Arazi Date: Mon Jun 13 13:04:25 2016 -0300 Bug 16720: Remove DBIx ActionLogs.pm The update_dbix_class_files.pl script generates ActionLog.pm instead, which is already on the source tree. To test: - Apply the patch => SUCCESS: Koha/Schema/Result/ActionLogs.pm is removed - Run: $ mysql -uroot > CREATE DATABASE dbic; \q $ mysql -uroot dbic < kohaclone/installer/data/mysql/kohastructure.sql $ misc/devel/update_dbix_class_files.pl --db_name dbic --db_user root => SUCCESS: Koha/Schema/Result/ActionLogs.pm is not re-generated - Run: $ git grep ActionLogs => SUCCESS: There's no code using it - Sign off Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit b8c950a4c1b1ead8a58686b27c95f9891cdccbae) Signed-off-by: Fr?d?ric Demians (cherry picked from commit c0d3e6db1191e2bb63da70cf1d3280f25efe7bfa) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: Koha/Schema/Result/ActionLogs.pm | 90 -------------------------------------- 1 file changed, 90 deletions(-) delete mode 100644 Koha/Schema/Result/ActionLogs.pm hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 1 09:03:57 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 01 Jul 2016 07:03:57 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.08-19-gbcb1ecb Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via bcb1ecbb0917c549c8c48a8938e508ee61aa0ffa (commit) via 772cde5e55022207c5d165ee27b240ee9690acf5 (commit) from ffd86f218e50124ff0090bb4e41fc4a32cb51b99 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bcb1ecbb0917c549c8c48a8938e508ee61aa0ffa Author: Jonathan Druart Date: Tue Jun 14 11:18:32 2016 +0100 Bug 16717: Improve variable naming $category was a categorycode, to help the readability it's better to name it $categorycode or assign a Category to $category Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit f8b73deaec5c7f55d66d52c2ca05d419f4a7c178) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 8ebe3a0a42b8b63a3ef8b1486a30cd3b335d12b9) Signed-off-by: Julian Maurice commit 772cde5e55022207c5d165ee27b240ee9690acf5 Author: Marcel de Rooy Date: Fri May 27 13:48:10 2016 +0200 Bug 16717: Remove hardcoded category from Holds.t There is actually no need to use the hardcoded patron category S in this test. Test plan: Run t/db_dependent/Holds.t. Signed-off-by: Marcel de Rooy Test passes OK Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit a4690353d9a20a7c991787a1ffe3040eb3834a5a) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 5321959b458b39860192846cd466a05df893aa53) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Holds.t | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 1 09:10:30 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 01 Jul 2016 07:10:30 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.08-20-g2d3af77 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 2d3af770dbb704607d2201bf6d346c7e6aae3fb0 (commit) from bcb1ecbb0917c549c8c48a8938e508ee61aa0ffa (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2d3af770dbb704607d2201bf6d346c7e6aae3fb0 Author: Owen Leonard Date: Tue May 31 10:08:03 2016 -0400 Bug 16127 - Add discharge menu item to patron toolbar This patch changes the "Discharge" menu in the patron sidebar to read "Discharges," and adds a "Discharge" menu item to the patron toolbar. This adds some redunancy, but fits with the pattern of including "views" in the sidebar and "actions" in the menu. The discharge feature can be thought of either way. To test you must have the 'useDischarge' system preference enabled. - View the detail page for any patron. - Confirm that the sidebar menu reads "Discharges." - Confirm that the "More" menu contains a "Discharge" link which works correctly. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 981302a47322857b080107a71c47db2345ef5286) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 43b4a740dcc5a13e1726a15da14493b57366a0e8) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc | 2 +- koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 1 09:39:31 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 01 Jul 2016 07:39:31 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.08-21-g500ab63 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 500ab63cb7e928f4c45bdbfdda26d091d2d5dd96 (commit) from 2d3af770dbb704607d2201bf6d346c7e6aae3fb0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 500ab63cb7e928f4c45bdbfdda26d091d2d5dd96 Author: Owen Leonard Date: Wed May 25 10:56:13 2016 -0400 Bug 16541 - Make edit and delete links styled buttons in cities administration This patch modifies the cities administration page, converting edit and delete links to Bootstrap buttons with Font Awesome icons. To test, apply the patch and go to Administration -> Cities and towns. The 'Edit' and 'Delete' buttons should look correct and work correctly. Signed-off-by: rainer Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 51a11d279457f97ac1b30e99d1af38a344d01725) Signed-off-by: Fr?d?ric Demians (cherry picked from commit ef948191c6a44d2ef896e40b7f71bdfcfc7d0cfc) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 1 09:40:17 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 01 Jul 2016 07:40:17 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.08-22-gf29b93e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via f29b93e3ab2f5df11dcae821bf1199f3a39ba8e2 (commit) from 500ab63cb7e928f4c45bdbfdda26d091d2d5dd96 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f29b93e3ab2f5df11dcae821bf1199f3a39ba8e2 Author: Owen Leonard Date: Wed May 25 10:49:26 2016 -0400 Bug 16543 - Make edit and delete links styled buttons in patron attribute types administration This patch modifies the Patron attribute types page, converting edit and delete links to Bootstrap buttons with Font Awesome icons. To test, apply the patch and go to Administration -> Patron attribute types. The 'Edit' and 'Delete' buttons should look correct and work correctly. Signed-off-by: Jan Kissig Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit ae4be45444dd8e6a65dc7170cfc43c60de328f38) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 1dfbe758c22fa117814142c5eb0532274d7582fa) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 1 09:41:33 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 01 Jul 2016 07:41:33 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.08-23-g3788402 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 3788402fd2c67c776216b5e0c74b20e42d72bfe5 (commit) from f29b93e3ab2f5df11dcae821bf1199f3a39ba8e2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3788402fd2c67c776216b5e0c74b20e42d72bfe5 Author: Julian Maurice Date: Wed Jun 8 13:47:58 2016 +0200 Bug 16693: Remove reserve/renewscript.pl It is not used since bug 11703 Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit c92d0823f8b79c1bb8f01b4a429961e5f3e5574c) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 5fd657a8fcb8445bc510260c8e28813da3687098) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: reserve/renewscript.pl | 142 ------------------------------------------------ 1 file changed, 142 deletions(-) delete mode 100755 reserve/renewscript.pl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 1 09:47:34 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 01 Jul 2016 07:47:34 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.08-24-ga9cdbad Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via a9cdbade43a980eb859ea8a5e826ea7bb5368c33 (commit) from 3788402fd2c67c776216b5e0c74b20e42d72bfe5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a9cdbade43a980eb859ea8a5e826ea7bb5368c33 Author: Marc V?ron Date: Tue Jun 14 07:07:05 2016 +0200 Bug 16729: Use member-display-address-style*-includes when printing user summary This patch replaces the address part in moremember-print.tt to print identical address information as displayed on the screen (including street numer, formatted as required by syspref 'AddressFormat' To test: - Apply patch - Search for a user with all address information filled - Verify that 'Print summmary' displays the same information as displayed on the screen. - Change value of syspref 'AdressFormat' - Verify that address format on 'Print summary' changes as appropriate Signed-off-by: mehdi Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 555f40626ab34eccadec66091e54e203a9be4440) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 546b95aee4fd4065090f4337a2e3e910f2767b39) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/members/moremember-print.tt | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jul 7 19:02:46 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 07 Jul 2016 17:02:46 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-228-g0fda22b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 0fda22b824a2e7c13e9b633325748d422e98e2a3 (commit) via 0bb144bbaf578ef7e4a131d640b3866bfe05fdf5 (commit) via 1887b7ab3ea50f9721eba070bc156c7f268d966a (commit) via c24fc83eee88771c36a0475165619c96fe54ebf2 (commit) via e657345fd7493816f1713fd825fac1e1f2f757a7 (commit) via 22f727f30e33227be449bef6d73861ae36b31ad5 (commit) via 86e998cc418e01e115054c1da3912680b38847cf (commit) via d4d550237a654257f0cf7932a74098cec11781f7 (commit) via d8e186a7a932869c7d6766aa7d9c5066518d128d (commit) via 523cdcee044c87dd886e3364f65fac5b2a2c294a (commit) via b1b61c60735a4afaec48da2e199cf673942d2683 (commit) via e85b2e4f94ccbcc62bbe516d6ce1fdab9e626cfa (commit) via 262b9344cd395dd9209a0aabd457b63a0207523e (commit) via 65558f20801dc7245de385af29fc7c650a8211f3 (commit) from 4747e6155efc9902003ae3ae4c14535fc7ece015 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0fda22b824a2e7c13e9b633325748d422e98e2a3 Author: Jesse Weaver Date: Thu Jul 7 11:02:53 2016 -0600 Bug 14048: (RM followup) DB version 16.06.00.006 Signed-off-by: Jesse Weaver commit 0bb144bbaf578ef7e4a131d640b3866bfe05fdf5 Author: Tomas Cohen Arazi Date: Mon Jun 27 10:17:20 2016 -0300 Bug 14048: (QA followup) Default to 1 if no default rule This patch answers Jonathan's request to simplify this patchset a bit. It removes the need for the .sql file, as _default_rule now defaults to a fixed value (1, which was set by the removed .sql file). This allowed to remove the overloaded ->delete method. The tests have been adjusted to reflect this changes, including tests for the new 'default'-if-absent situation. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Jesse Weaver commit 1887b7ab3ea50f9721eba070bc156c7f268d966a Author: Jonathan Druart Date: Sun Jun 26 08:19:12 2016 +0100 Bug 14048: Use mock_preference in tests Signed-off-by: Jonathan Druart Signed-off-by: Jesse Weaver commit c24fc83eee88771c36a0475165619c96fe54ebf2 Author: Tomas Cohen Arazi Date: Sat Jun 25 12:37:15 2016 -0300 Bug 14048: (QA folloup) C4::Context->preference should be used Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Jesse Weaver commit e657345fd7493816f1713fd825fac1e1f2f757a7 Author: Tomas Cohen Arazi Date: Tue Jun 21 15:18:51 2016 -0300 Bug 14048: (followup) Use the original holding branch This patch picks the item's holding branch *before* it gets fixed by using the checkin library instead. This way the RefundLostOnReturnControl syspref set to ItemHoldingBranch is respected (otherwise, as Nick explained this behaves just like if CheckinLibrary was set) Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Jason Robb Signed-off-by: Jennifer Schmidt Signed-off-by: Margaret Thrasher Signed-off-by: Jonathan Druart Signed-off-by: Jesse Weaver commit 22f727f30e33227be449bef6d73861ae36b31ad5 Author: Tomas Cohen Arazi Date: Fri Jun 17 10:33:22 2016 -0300 Bug 14048: (QA followup) Fix typo on syspref value Signed-off-by: Nick Clemens Signed-off-by: Jason Robb Signed-off-by: Jennifer Schmidt Signed-off-by: Margaret Thrasher Signed-off-by: Jonathan Druart Signed-off-by: Jesse Weaver commit 86e998cc418e01e115054c1da3912680b38847cf Author: Tomas Cohen Arazi Date: Wed Jun 15 16:18:38 2016 -0300 Bug 14048: (QA followup) Update syspref name for HEA Signed-off-by: Nick Clemens Signed-off-by: Jason Robb Signed-off-by: Jennifer Schmidt Signed-off-by: Margaret Thrasher Signed-off-by: Jonathan Druart Signed-off-by: Jesse Weaver commit d4d550237a654257f0cf7932a74098cec11781f7 Author: Kyle M Hall Date: Mon Jun 13 11:17:42 2016 +0000 Bug 14048 [QA Followup] - Delete only the removed system preference Signed-off-by: Nick Clemens Signed-off-by: Jason Robb Signed-off-by: Jennifer Schmidt Signed-off-by: Margaret Thrasher Signed-off-by: Jonathan Druart Signed-off-by: Jesse Weaver commit d8e186a7a932869c7d6766aa7d9c5066518d128d Author: Tomas Cohen Arazi Date: Fri Jun 3 11:24:07 2016 -0300 Bug 14048: Add syspref and atomic update This patch introduces the changes to the sysprefs and the atomic update that creates the new table. It picks the syspref value for RefundLostItemFeeOnReturn and uses it to create a default (branchcode='*') rule on the new table. Sponsored-by: DoverNet Sponsored-by: South-East Kansas Library System Sponsored-by: SWITCH Library Consortium Signed-off-by: Nick Clemens Signed-off-by: Jason Robb Signed-off-by: Jennifer Schmidt Signed-off-by: Margaret Thrasher Signed-off-by: Jonathan Druart Signed-off-by: Jesse Weaver commit 523cdcee044c87dd886e3364f65fac5b2a2c294a Author: Kyle M Hall Date: Thu Jun 9 16:48:07 2016 +0000 Bug 14048: [QA Followup] Signed-off-by: Nick Clemens Signed-off-by: Jason Robb Signed-off-by: Jennifer Schmidt Signed-off-by: Margaret Thrasher Signed-off-by: Jonathan Druart Signed-off-by: Jesse Weaver commit b1b61c60735a4afaec48da2e199cf673942d2683 Author: Tomas Cohen Arazi Date: Fri Jun 3 11:26:42 2016 -0300 Bug 14048: Hook new rules into C4::Circulation This patch makes AddIssue and AddReturn use the new implementation The behaviour should respect the specification. Sponsored-by: DoverNet Sponsored-by: South-East Kansas Library System Sponsored-by: SWITCH Library Consortium Signed-off-by: Nick Clemens Signed-off-by: Jason Robb Signed-off-by: Jennifer Schmidt Signed-off-by: Margaret Thrasher Signed-off-by: Jonathan Druart Signed-off-by: Jesse Weaver commit e85b2e4f94ccbcc62bbe516d6ce1fdab9e626cfa Author: Tomas Cohen Arazi Date: Fri Jun 3 11:26:11 2016 -0300 Bug 14048: Add a refund rules setting form in smart-rules This patch introduces the CRUD UI for managing the refund lost item fee rules on the general 'Circulation and fines rules' page. Verify that rules can be added and changed. Rules are correctly associated to the chosen branch (or the general default rule). To test: - Apply the patch - Open smart-rules.pl => SUCCESS: The text and refund rules section correctly refers to default global rules. The policy can be set to Yes and No, and works as expected. - Pick a specific branch => SUCCESS: The rule refers to the specific branch => SUCCESS: It detects the default rule is picked => SUCCESS: On changing the rules values are correctly retrieved if entering again to the page. => SUCCESS: The 'Use default' text is suffixed with the correct value set by the user in the 'All libraries' scenario. => Sign off :-D Sponsored-by: DoverNet Sponsored-by: South-East Kansas Library System Sponsored-by: SWITCH Library Consortium Signed-off-by: Nick Clemens Signed-off-by: Jason Robb Signed-off-by: Jennifer Schmidt Signed-off-by: Margaret Thrasher Signed-off-by: Jonathan Druart Signed-off-by: Jesse Weaver commit 262b9344cd395dd9209a0aabd457b63a0207523e Author: Tomas Cohen Arazi Date: Fri Jun 3 11:25:15 2016 -0300 Bug 14048: Unit tests This patch introduces unit tests for the feature. To test: - Have all patches from this bug applied - Run: $ prove -v t/db_dependent/RefundLostItemFeeRule.t => SUCCESS: All tests pass! Sponsored-by: DoverNet Sponsored-by: South-East Kansas Library System Sponsored-by: SWITCH Library Consortium Signed-off-by: Nick Clemens Signed-off-by: Jason Robb Signed-off-by: Jennifer Schmidt Signed-off-by: Margaret Thrasher Signed-off-by: Jonathan Druart Signed-off-by: Jesse Weaver commit 65558f20801dc7245de385af29fc7c650a8211f3 Author: Tomas Cohen Arazi Date: Fri Jun 3 11:23:20 2016 -0300 Bug 14048: Add RefundLostItemFeeRule table and classes This patch introduces new classes for handling refund lost item fee rules. It introduces a new table for storing this rules. It is designed so it is possible to define a global rule, and then branch-specific ones. The specific is prefered if available. This behaviour is fully tested by unit tests introduced by the following patches. This cannot be tested on its own. Sponsored-by: DoverNet Sponsored-by: South-East Kansas Library System Sponsored-by: SWITCH Library Consortium Signed-off-by: Nick Clemens Signed-off-by: Jason Robb Signed-off-by: Jennifer Schmidt Signed-off-by: Margaret Thrasher Signed-off-by: Jonathan Druart Signed-off-by: Jesse Weaver ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 34 ++- C4/Installer.pm | 1 + C4/UsageStats.pm | 2 +- Koha.pm | 2 +- Koha/Exceptions.pm | 11 +- ...ualshelfcontent.pm => RefundLostItemFeeRule.pm} | 10 +- Koha/RefundLostItemFeeRules.pm | 147 ++++++++++ Koha/Schema/Result/RefundLostItemFeeRule.pm | 66 +++++ admin/smart-rules.pl | 34 +++ installer/data/mysql/kohastructure.sql | 11 + installer/data/mysql/sysprefs.sql | 2 +- installer/data/mysql/updatedatabase.pl | 32 +++ .../en/modules/admin/preferences/circulation.pref | 9 +- .../prog/en/modules/admin/smart-rules.tt | 81 ++++++ t/db_dependent/RefundLostItemFeeRule.t | 283 ++++++++++++++++++++ t/db_dependent/UsageStats.t | 2 +- 16 files changed, 708 insertions(+), 19 deletions(-) copy Koha/{Virtualshelfcontent.pm => RefundLostItemFeeRule.pm} (83%) create mode 100644 Koha/RefundLostItemFeeRules.pm create mode 100644 Koha/Schema/Result/RefundLostItemFeeRule.pm create mode 100755 t/db_dependent/RefundLostItemFeeRule.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jul 7 20:35:51 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 07 Jul 2016 18:35:51 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-234-g6398d1b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6398d1b24216b07cb424e4b084ecf60329e0db86 (commit) via da083863ee813b8303f6d8181b935aa0f3f15b86 (commit) via 5595e92ec723c4437f1549cbea7e9e1215cb4211 (commit) via a8ebff202dfe23b848a05f81060f436f1ea6bc60 (commit) via 486758d1361ffcd9b70de14e009bcf3363c4220f (commit) via 71d1e1727c5fd7671bbbce6e6085b829b957253d (commit) from 0fda22b824a2e7c13e9b633325748d422e98e2a3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6398d1b24216b07cb424e4b084ecf60329e0db86 Author: Kyle M Hall Date: Thu Jul 7 18:36:25 2016 +0000 Bug 3534 - DBRev 16.06.00.007 Signed-off-by: Kyle M Hall commit da083863ee813b8303f6d8181b935aa0f3f15b86 Author: Jonathan Druart Date: Thu Jul 7 15:36:47 2016 +0100 Bug 3534: Force margin-left: 0 for second button When quick adding a new patron, both button are in the DOM and the second button has a margin-left (from .btn-toolbar > .btn + .btn). This patch force the margin-left to 0 to avoid the button to move when toggling them. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 5595e92ec723c4437f1549cbea7e9e1215cb4211 Author: Nick Clemens Date: Tue Jun 28 12:57:00 2016 -0400 Bug 3534 (QA Followup) Rebase and change floating save Bug 3534 - (QA Followup) Use single toolbar for regular/quickadd forms Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit a8ebff202dfe23b848a05f81060f436f1ea6bc60 Author: Nick Clemens Date: Wed Jun 8 13:39:02 2016 -0400 Bug 3534 (QA Followup) Fix indentation, show guarantor form, ignore bad data in pref Switch incorrect == to != when checking skipped fields Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 486758d1361ffcd9b70de14e009bcf3363c4220f Author: Nick Clemens Date: Wed May 11 11:17:12 2016 -0400 Bug 3534 - QA Followup - use floating save I am not sure if this is desired, it makes sense for consistency but floats in a wierd place for a short form. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 71d1e1727c5fd7671bbbce6e6085b829b957253d Author: Nick Clemens Date: Fri Mar 4 21:34:07 2016 +0000 Bug 3534 - Patron quick add form This patch adds a new system preference: PatronQuickAddFields When either this pref or BorrowerMandatoryField is populated this will add a new dropdown to the bew patron toolbar. When a category is chosen from this dropdown the fields in PatronQuickAddFields and BorrowerMandatoryField will be displayed. There will be a button allowing a user to switch from the quickadd to the full form and fields will be copied between the forms when toggling. The Quick add will only be displayed on add of a new patron, future edits should display the full form. Test plan: 1 - Apply patch 2 - run updatedatabase.pl 3 - Add a new patron and ensure nothing has changed 4 - Populate either PatronQuickAddFields or BorrowerMandatory fields and note the new button for adding a patron 5 - Click the Quick add and choose a type 6 - Only required or quick add fields should be displayed 7 - Verify toggling forms copies information 8 - Ensure you cannot save patron without filling required fields (quick add fields should be optional) 9 - Ensure you can save patron with fields filled out 10 - Ensure that a duplicate patron brings up the duplicate/add new buttons with full form displayed 11 - Verify that subsequent edits use only full form 12 - Verify that data on form submitted is the data saved to patron 13 - Test with various values in both MandatoryBorrowerFields and PatronQuickAddFields Sponsored by: VOKAL (Vermont Organization of Koha Automated Libraries) Followed test plan, works as expected. Re-tested together with followup, works as expected (2016-06-02) Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 11 ++ .../prog/en/includes/patron-toolbar.inc | 10 ++ .../prog/en/modules/admin/preferences/patrons.pref | 5 + .../prog/en/modules/members/memberentrygen.tt | 135 ++++++++++++++++---- koha-tmpl/intranet-tmpl/prog/js/members.js | 8 ++ members/memberentry.pl | 2 + 8 files changed, 150 insertions(+), 24 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 01:07:24 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 07 Jul 2016 23:07:24 +0000 Subject: [koha-commits] main Koha release repository branch 3.20.x updated. v3.20.12-4-ge3381d0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.20.x has been updated via e3381d00710c29e706a797db6c7d844839013c25 (commit) via e7fa1842a4c4d0389b31aa88d04659abe7f90155 (commit) via ec5aa1a7de855345e35be16fd8ef07a9d5307d5e (commit) via 6a06f60a1ee928c2b6859b2e14e959dc98df2ce5 (commit) from 402c827fb9eca20089ecf328b576785298377545 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e3381d00710c29e706a797db6c7d844839013c25 Author: Marcel de Rooy Date: Mon May 23 09:03:23 2016 +0200 Bug 16502: Replace a few other ok-calls by is-calls Trivial changes that speak for themselves.. Signed-off-by: Marcel de Rooy Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 8204024f1c21102c0649dec70d10398131aab953) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 2b7a9479b601e224ff6cdbdcc3162426a4727406) Signed-off-by: Julian Maurice (cherry picked from commit b58e8642b0d6b98a9e59a6e53d21472cb38a1e42) Signed-off-by: Chris Cormack commit e7fa1842a4c4d0389b31aa88d04659abe7f90155 Author: Marcel de Rooy Date: Mon May 23 08:58:02 2016 +0200 Bug 16502: Adjust test for GetPlugins The current test assumes that GetPlugins will return the test plugin as the first one in the array. This is not correct. This patch adjusts the test to a grep. Test plan: Run the test. Bonus: Add additional plugins. Run the test again. Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 6ad5770786c6646ce68ffdfec9080645fc25772e) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 64382be0d45ad6d43bb86bda095ca1a3699d1265) Signed-off-by: Julian Maurice (cherry picked from commit d1dff4c3bde88c2b7c2bb6722ef07d1fcf5f5cce) Signed-off-by: Chris Cormack commit ec5aa1a7de855345e35be16fd8ef07a9d5307d5e Author: Marcel de Rooy Date: Mon May 16 19:00:16 2016 +0200 Bug 16502: Add additional test to Plugins.t In order to verify if the delete now really works, we add one test in Plugins.t. Test plan: [1] Run the test. [2] Bonus: Comment line 63 in Plugins.t where delete is called. Run the test again. It should fail now. Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 959d69fa0107423ed31e20f4a6afb46d1e5c771c) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 0632256c1aca919ec055dd5f170ac10d84cc8ec7) Signed-off-by: Julian Maurice (cherry picked from commit e41863bfa9bf73066d2ec43a3b8e843fa1f0222f) Signed-off-by: Chris Cormack commit 6a06f60a1ee928c2b6859b2e14e959dc98df2ce5 Author: Marcel de Rooy Date: Mon May 16 17:19:54 2016 +0200 Bug 16502: Table koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped after running Plugin.t If you run Plugin.t, the above table will still be present (when you did not enable UseKohaPlugins). This would trigger a warning when running the test a second time. Why? The uninstall call does its work not completely due to a small inconsistency in Koha::Plugins::Handler::delete when calling run without the enable_plugins parameter. This patch resolves that inconsistency and also removes an unneeded skip in Plugin.t in case the KitchenSink module already exists. Note: This is a small fix. But I wonder if the Handler routines run and delete should not have been implemented in Koha::Plugins::Base. Also note that plugins/plugins-uninstall.pl will not be affacted by this change, since it checks whether the pref is enabled before calling the delete method. Test plan: [1] Do not yet install this patch. [2] Verify that plugins are enabled in koha-conf.xml. [3] Disable UseKohaPlugins in System Preferences! [4] Run t/db_dependent/Plugins.t. [5] Verify that table koha_plugin_com_bywatersolutions_kitchensink_mytable still exists. (It should have been deleted.) Remove it manually. [6] Apply this patch. [7] Run the test again. [8] Verify that the table does not exist. [9] Run the test again (without warnings). Signed-off-by: Marcel de Rooy Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 4263ac2b92737024d8d620a751babf72b904b73a) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 4ebe7b489c9798d2456bd3de1d95ec6e027b2b21) Signed-off-by: Julian Maurice (cherry picked from commit 752e31425efa34fa6f21446fb18cf34ba31fc441) Signed-off-by: Chris Cormack ----------------------------------------------------------------------- Summary of changes: Koha/Plugins/Handler.pm | 9 ++++++++- t/db_dependent/Plugins.t | 26 +++++++++++++++----------- 2 files changed, 23 insertions(+), 12 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 01:25:30 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 07 Jul 2016 23:25:30 +0000 Subject: [koha-commits] main Koha release repository branch 3.20.x updated. v3.20.12-5-gfe45e8a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.20.x has been updated via fe45e8a83d2583a13d9f8c4b239c9416d90f274b (commit) from e3381d00710c29e706a797db6c7d844839013c25 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fe45e8a83d2583a13d9f8c4b239c9416d90f274b Author: Tomas Cohen Arazi Date: Mon Jun 13 13:04:25 2016 -0300 Bug 16720: Remove DBIx ActionLogs.pm The update_dbix_class_files.pl script generates ActionLog.pm instead, which is already on the source tree. To test: - Apply the patch => SUCCESS: Koha/Schema/Result/ActionLogs.pm is removed - Run: $ mysql -uroot > CREATE DATABASE dbic; \q $ mysql -uroot dbic < kohaclone/installer/data/mysql/kohastructure.sql $ misc/devel/update_dbix_class_files.pl --db_name dbic --db_user root => SUCCESS: Koha/Schema/Result/ActionLogs.pm is not re-generated - Run: $ git grep ActionLogs => SUCCESS: There's no code using it - Sign off Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit b8c950a4c1b1ead8a58686b27c95f9891cdccbae) Signed-off-by: Fr?d?ric Demians (cherry picked from commit c0d3e6db1191e2bb63da70cf1d3280f25efe7bfa) Signed-off-by: Julian Maurice (cherry picked from commit ffd86f218e50124ff0090bb4e41fc4a32cb51b99) Signed-off-by: Chris Cormack ----------------------------------------------------------------------- Summary of changes: Koha/Schema/Result/ActionLogs.pm | 90 -------------------------------------- 1 file changed, 90 deletions(-) delete mode 100644 Koha/Schema/Result/ActionLogs.pm hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 14:40:32 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 12:40:32 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-235-ga1285ba Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a1285ba9c0f9a7020ba5f6e982dd2a5891ab9f63 (commit) from 6398d1b24216b07cb424e4b084ecf60329e0db86 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a1285ba9c0f9a7020ba5f6e982dd2a5891ab9f63 Author: Morgane Alonso Date: Mon Jun 6 12:24:56 2016 +0000 Bug 12509 - Fix Untranslatable Restriction added by overdues process Changes the value of the "comment" column in "borrower_debarments" table from "Restriction added by overdues process yyyy-mm-dd hh:mm:ss" to "OVERDUE_PROCESS yyyy-mm-dd hh:mm:ss" in the overdue_notices.pl. Then in the templates "moremember.tt", "circulation.tt", "memberentrygen.tt", "opac-reserve.tt" and "opac-user.tt" the value of "comment" is check, if it's an automatical comment due to overdue process it'll write "Restriction added by overdues process yyyy-mm-dd hh:mm:ss", then if there is a customizable comment it will be written without modification. Like this, the comment "Restriction added by overdues process" is written in the po files and can be translated later. To test: 1) create a patron with automatical restriction due to overdue process; 2) apply patch; 3) run misc/cronjobs/overdue_notices.pl; 4) verify if the comment "Restriction added by overdues process" is well written and translatable on the following page : - opac patron home page (opac-user.tt); - opac item reservation page (opac-reserve.tt); - pro patron page (moremember.tt); - reservation item for a patron (circulation.tt, memberentrygen.tt); 5) try to translate the comment in po files; 6) sign off. Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/includes/borrower_debarments.inc | 8 +++++++- koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 7 ++++++- .../intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 8 +++++++- .../intranet-tmpl/prog/en/modules/members/moremember.tt | 7 ++++++- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 10 +++++++++- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 11 ++++++++++- misc/cronjobs/overdue_notices.pl | 3 +-- 7 files changed, 46 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 14:42:22 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 12:42:22 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-237-g1509322 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 1509322c9a813809ca453b476ea1163bbc9303ca (commit) via 83328c1061af0ae82d8a2086e298375875e2dfa9 (commit) from a1285ba9c0f9a7020ba5f6e982dd2a5891ab9f63 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1509322c9a813809ca453b476ea1163bbc9303ca Author: Alex Arnaud Date: Wed Jun 15 16:11:07 2016 +0200 Bug 14968 - Provides unit test Signed-off-by: Broust Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 83328c1061af0ae82d8a2086e298375875e2dfa9 Author: Lyon3 Team Date: Tue Oct 6 15:42:15 2015 +0200 Bug 14968 - found shouldn't be set to null when cancelling holds Signed-off-by: JM Broust Signed-off-by: Broust Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Reserves.pm | 1 - t/db_dependent/Reserves.t | 5 ++++- 2 files changed, 4 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 14:44:04 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 12:44:04 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-238-g172ebfe Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 172ebfe520d34f8106ec011b7d707c0560d65760 (commit) from 1509322c9a813809ca453b476ea1163bbc9303ca (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 172ebfe520d34f8106ec011b7d707c0560d65760 Author: Jonathan Druart Date: Tue May 3 14:34:33 2016 +0100 Bug 16431: Use Koha::Cache to cache marc subfield structure The marc subfield structure is currently cached using a global variable of C4::Context. The infos are retrieved every time a new context is created. This patch suggests to use Koha::Cache instead. To achieve this goal, a new subroutine is created C4::Biblio::GetMarcSubfieldStructure, it will be called from code which needs to get the marc subfield structure. GetMarcFromKohaField, GetMarcSubfieldStructureFromKohaField, TransformKohaToMarc and _get_inverted_marc_field_map are modified accordingly and the cache is cleared when the table is updated (from the 3 pl scripts modified by this patch). The caching done in C4::Context (marcfromkohafield) is removed. Test plan: Play with the marc subfield structure (in the administration module), then add and edit records and make sure everything went fine. Signed-off-by: Tomas Cohen Arazi Everything works as expected on my functional tests. I'm really happy to see the patch introduces relevant tests for previously untested functions. Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/AuthoritiesMarc.pm | 1 - C4/Biblio.pm | 115 ++++++++++++++++++----------------- C4/Context.pm | 40 ------------ admin/biblio_framework.pl | 2 + admin/marc_subfields_structure.pl | 2 + admin/marctagstructure.pl | 3 + t/db_dependent/Biblio.t | 121 +++++++++++++++++-------------------- t/db_dependent/Items.t | 37 ++++++------ 8 files changed, 144 insertions(+), 177 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 14:45:03 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 12:45:03 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-239-g3bb51d0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 3bb51d038639c7b197022a2c7c6ae864c834060f (commit) from 172ebfe520d34f8106ec011b7d707c0560d65760 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3bb51d038639c7b197022a2c7c6ae864c834060f Author: Jonathan Druart Date: Fri May 6 15:55:31 2016 +0100 Bug 16459: Add patron to a patron card requires catalogue permission Currently, serials => 'routing' is required, which does not make any sense. It's a copy/paste error when this file has been created (you can blame me). Note that I am not sure catalogue is the correct permission, but it's the one used almost everywhere in this module Test plan: Confirm that catalogue is enough to search for patrons to add to a patron card. Signed-off-by: Srdjan Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: patroncards/add_user_search.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 14:46:13 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 12:46:13 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-242-gc7596a4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via c7596a489473bc294e04690f21b7a9d612f34abd (commit) via eddc0a0e0a72264151e39f8a5d87d638a4208369 (commit) via 8f42c681b0208ace7ed7858cafdd8c9777debd96 (commit) from 3bb51d038639c7b197022a2c7c6ae864c834060f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c7596a489473bc294e04690f21b7a9d612f34abd Author: Marcel de Rooy Date: Tue Jun 28 15:21:53 2016 +0200 Bug 16671: [QA Follow-up] Replace remaining itemtype lines Instead of relying on existing data, we use new TestBuilder recs. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit eddc0a0e0a72264151e39f8a5d87d638a4208369 Author: Marcel de Rooy Date: Mon Jun 27 09:24:14 2016 +0200 Bug 16671: [QA Follow-up] Add new itemtype and remove bailout No need to bail out, if we are using TestBuilder. Somehow, this test passes with me if we add a new record, and if we do not, it fails (using BK as the first itemtype with notforloan is 0). Looking further, we should imo remove the Koha::ItemTypes searches here and not depend on existing data. Just add some item types. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 8f42c681b0208ace7ed7858cafdd8c9777debd96 Author: Jonathan Druart Date: Mon Jun 6 14:00:56 2016 +0100 Bug 16671: (bug 14828 follow-up) Pick the right itemtypes Looking at commit aafe73eefb5151454fa8957bf188768324d23955 Bug 14828: Use Koha::ItemType[s] everywhere C4::ItemType was used -my @item_types = C4::ItemType->all; -my @for_loan = grep { $_->{notforloan} == 0 } @item_types - or BAIL_OUT("No adequate itemtype"); -my $itemtype = $for_loan[0]->{itemtype}; +my $itemtype = Koha::ItemTypes->search({ notforloan => 1 })->next; +$itemtype or BAIL_OUT("No adequate itemtype"); #FIXME Should be $itemtype = $itemtype->itemtype It seems that the tests expect itemtypes for loan. Test plan: prove t/db_dependent/HoldsQueue.t should still return green Signed-off-by: Hector Castro Works as advertised. No qa test tool errors Signed-off-by: Marcel de Rooy Adding follow-up. Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: t/db_dependent/HoldsQueue.t | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 14:47:08 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 12:47:08 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-243-g8ca55a7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 8ca55a7fb37ac50103de978f82408776fc06b7bb (commit) from c7596a489473bc294e04690f21b7a9d612f34abd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8ca55a7fb37ac50103de978f82408776fc06b7bb Author: Galen Charlton Date: Tue Jul 5 16:22:39 2016 +0000 Bug 16760: fix Circulation Statistics wizard under Plack This patch fixes some variable scoping problems when running the circulation statistics wizard under Plack. For example, when using the item type as a row header, with this patch the item type description is displayed rather than "UKNOWN VALUE". This patch also enables warnings and fixes a couple variable initialization issues. (Note that turning on warnings across the board would make it easier to identify Plack variable scoping issues, as "Variable "$foo" is not available at' errors would be recorded in the Plack error log). To test ------- [1] Run the staff interface under Plack. [2] Go to the Circulation Statistics Wizard and run a report using item type as the row. Note that the row labels display as "UNKNOWN VALUE" rather than the item type. [3] Apply the patch and restart Plack. [4] Run step #2 again; this time, the item type descriptions should be used as the row labels. Signed-off-by: Galen Charlton Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: reports/issues_stats.pl | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 14:48:46 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 12:48:46 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-244-gffcb360 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ffcb360321f6abe111c3352606b4c641ac48950a (commit) from 8ca55a7fb37ac50103de978f82408776fc06b7bb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ffcb360321f6abe111c3352606b4c641ac48950a Author: Owen Leonard Date: Fri Jun 17 11:33:41 2016 -0400 Bug 16762: Record matching rules: Remove match check link removes too much My patch for Bug 5006 introduced a lot of markup changes to the record matching rules template. I missed a change in one are though, which caused a bug with the way the 'Remove match check' link works. To reproduce: - Go to Administration -> Record matching rules. - Edit a matching rule which includes at least one match check. - Click a 'Remove match check' link. The entire "Required match checks" block is removed. To test, apply the patch and repeat the steps above. Clicking any 'Remove match check' link should remove only the corresponding rule. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/matching-rules.tt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 14:50:18 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 12:50:18 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-245-g7c89f78 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 7c89f78f3bef1cdebb51dcb41fdda7a8dc252b94 (commit) from ffcb360321f6abe111c3352606b4c641ac48950a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7c89f78f3bef1cdebb51dcb41fdda7a8dc252b94 Author: Kyle M Hall Date: Fri Jun 24 10:35:25 2016 +0000 Bug 16780 - Specify due date always sets time as AM when using 12 hour time format This regression is occurs because the time format for the checkout date/time widget is only meant to be given in 24 hour format. The time due should not be converted to 12 hr time even if the library has 12 hour set as their preferred time format. Test Plan: 1) Performat a backdated checkout with a date due that has a PM time 2) Note the date/time picker on the confirmition screen shows the time in AM/PM 2) Note the time is not stored correctly 3) Apply this patch 4) Repeate step 1 5) Note the confirmation date/time picker now show the time in 24hr format 6) Note the time was stored correctly Signed-off-by: Claire Gravely Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: circ/circulation.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 14:51:30 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 12:51:30 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-246-g44092cb Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 44092cbafd1641ef865497183b8368db83bb62a7 (commit) from 7c89f78f3bef1cdebb51dcb41fdda7a8dc252b94 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 44092cbafd1641ef865497183b8368db83bb62a7 Author: Marc V?ron Date: Mon Jul 4 03:48:40 2016 +0200 Bug 16854: request.tt: Logic to display messages broken This patch fixes broken logic in koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt To verify, see initial comment. To test: - Apply patch - Have a patron with a restricion and with outstanding fines greater than defined in syspref 'maxoutstanding' - Place a hold for this patron and verify, that messages 'Patron has restrictions' and 'Patron has outstanding fines...' appear Signed-off-by: Hector Castro Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 14:54:19 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 12:54:19 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-247-ga44bb07 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a44bb07b88ba9d5049a64f88610a8bb8e82efe3a (commit) from 44092cbafd1641ef865497183b8368db83bb62a7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a44bb07b88ba9d5049a64f88610a8bb8e82efe3a Author: Nick Clemens Date: Tue Jul 5 14:49:35 2016 -0400 Bug 16855 - Poor performance due to high overhead of SQL call in export.pl This patch eliminates all columns retrieved in the biblioitems query except for biblionumber. To test: 1 - Go to tools->Export data 2 - Export using various filters and note you get expected records 3 - Apply patch 4 - Ensure exported results match results before patch Signed-off-by: Srdjan Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: tools/export.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 14:56:55 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 12:56:55 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-248-g00960f1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 00960f196482bb8dda3ddac8d9361ca1ffc5af93 (commit) from a44bb07b88ba9d5049a64f88610a8bb8e82efe3a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 00960f196482bb8dda3ddac8d9361ca1ffc5af93 Author: Marcel de Rooy Date: Wed Jul 6 15:52:54 2016 +0200 Bug 16859: Fix wrong item field name in export.pl Field callnumber should be itemcallnumber. For completeness, prefixing the joined fields with items table prefix. Note: You should expect Tools/Export to export only the items within a given itemcallnumber range, but if the biblio has one item in that range, the biblionumber is selected for export with ALL items. The script is designed that way (first select biblio numbers based on criteria, and run export with those biblio numbers). Test plan: [1] Select a biblio N with one item with say itemcallnumber X. [2] Goto Tools/Export. Select biblio range N,N and no itemcallnumber range. The biblio should be exported. [3] Select biblio range N,N and itemcallnumber range A,B. No output. [4] Select biblio range N,N and itemcallnumber range A,. Output. [5] Select biblio range N,N and itemcallnumber range ,X. Output. Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: tools/export.pl | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 15:00:54 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 13:00:54 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-249-ga12d3d1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a12d3d1bfa00499a0b16d39f01136050de537449 (commit) from 00960f196482bb8dda3ddac8d9361ca1ffc5af93 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a12d3d1bfa00499a0b16d39f01136050de537449 Author: Bouzid Fergani Date: Tue Apr 12 09:27:18 2016 -0400 Bug 15636 - DataTables Warning: Requested unknown parameter from opac-detail.tt Signed-off-by: Srdjan Signed-off-by: Jonathan Druart This patch adds the same tests in the aoColumns DT definition than the ones in the creation of the table. That's sound good. Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 15:02:03 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 13:02:03 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-250-gb6ccd83 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b6ccd8366dca9fc17d381d5fdf487bd8e2e1e045 (commit) from a12d3d1bfa00499a0b16d39f01136050de537449 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b6ccd8366dca9fc17d381d5fdf487bd8e2e1e045 Author: Owen Leonard Date: Thu May 26 09:35:26 2016 -0400 Bug 16600 - Remove some obsolete references to Greybox in some templates This patch removes unused Greybox markup from two templates. To test, apply the patch and go to Authorities. - Perform an authority search which will return multiple results. - Select two records to merge. - On the "merging records" page, an earlier version used Greybox to show a preview of the selected authority records. Confirm that authority number link for the two records triggers a pop-up window instead. - From the authorities home page, choose 'New from Z39.50' - Perform a search which will return multiple results. - Confirm that there is only a 'MARC' preview link. A forever-commented-out 'Card' link has been removed. Signed-off-by: Hector Castro Works as advertised. Obsolete comment on 'Card' removed Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/authorities/merge.tt | 1 - .../intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt | 2 -- 2 files changed, 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 15:03:12 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 13:03:12 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-251-g11dc97c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 11dc97cfae96676ff1cc242e8a43ad513c36c6ef (commit) from b6ccd8366dca9fc17d381d5fdf487bd8e2e1e045 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 11dc97cfae96676ff1cc242e8a43ad513c36c6ef Author: Marc V?ron Date: Sun Jun 19 17:43:19 2016 +0200 Bug 16774: Format date on 'Transfers to receive' page to dateformat system preference To test: - Apply patch - Go to Home > Circulation > Transfers to receive - Verify that in title (Transfer made to your library as of...) is is formatted as defined in syspref dateformat Additionaly, the patch changes page title and breadcrumb from: Home > Circulation > Transfers to your library to: Home > Circulation > Transfers to receive ...to make them consistent with the link text on the Circulation home page (Transfers to receive) Signed-off-by: Hector Castro Works as advertised Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 15:04:27 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 13:04:27 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-253-g10d4d2fd Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 10d4d2fd3139c74a1dcc0c643ca00be264e1a526 (commit) via d17085ea0361f8581a796e5f17d0413b37b7b598 (commit) from 11dc97cfae96676ff1cc242e8a43ad513c36c6ef (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 10d4d2fd3139c74a1dcc0c643ca00be264e1a526 Author: Nick Clemens Date: Fri Jun 24 12:04:43 2016 -0400 Bug 16807 - Use Koha::BiblioFrameworks instead of GetFrameWorkLoop Refactor code to use work from 14889 Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall commit d17085ea0361f8581a796e5f17d0413b37b7b598 Author: Nick Clemens Date: Fri Jun 24 09:57:07 2016 -0400 Bug 16807: Frameworks unordered in dropdown when adding/editing a biblio To test: Start to add or edit a biblio Open the dropdown to change framework Notice the order Refresh the page - notice the order changes Apply patch Order is alphabetical Refresh the page Order does not change Signed-off-by: Hector Castro Works as described Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: cataloguing/addbiblio.pl | 19 +++---------------- .../prog/en/modules/cataloguing/addbiblio.tt | 4 ++-- 2 files changed, 5 insertions(+), 18 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 15:05:24 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 13:05:24 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-254-g5f147cc Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 5f147cc6bb8a018fd0af8b23789e795bf57ede72 (commit) from 10d4d2fd3139c74a1dcc0c643ca00be264e1a526 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5f147cc6bb8a018fd0af8b23789e795bf57ede72 Author: Marc V?ron Date: Sun Jun 19 16:40:09 2016 +0200 Bug 16562 - Translatability: Issue in opac-user.tt (separated word 'item') Alternate patch with wording as proposed in comment #12 Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 15:06:44 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 13:06:44 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-255-g5ec641f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 5ec641fbbb67501e2a71be64b12c9224caee1b55 (commit) from 5f147cc6bb8a018fd0af8b23789e795bf57ede72 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5ec641fbbb67501e2a71be64b12c9224caee1b55 Author: Mark Tompsett Date: Thu Jul 7 02:34:28 2016 -0400 Bug 16869: Silence and catch warnings in t/db_dependent/SuggestionEngine_ExplodedTerms.t By properly defining a opachtdocs (intranethtdocs was done too) in the mock function, uninitialized variable warnings are eliminated. Given that we can check if $KOHA_CONF is defined or not, we can catch the warning as part of testing, so the output of the test is cleaner. TEST PLAN --------- 1) unset KOHA_CONF 2) prove t/db_dependent/SuggestionEngine_ExplodedTerms.t -- lots of noise 3) apply patch 4) prove t/db_dependent/SuggestionEngine_ExplodedTerms.t -- no noise 5) prove -v t/db_dependent/SuggestionEngine_ExplodedTerms.t -- see the warnings were caught and not just ignored. 6) run koha qa test tools Signed-off-by: Hector Castro No warnings. Works as advertised Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: t/db_dependent/SuggestionEngine_ExplodedTerms.t | 59 ++++++++++++++++++----- 1 file changed, 46 insertions(+), 13 deletions(-) mode change 100755 => 100644 t/db_dependent/SuggestionEngine_ExplodedTerms.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 15:07:35 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 13:07:35 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-256-gcae7e29 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via cae7e29cf27b3a751211dc71e1aeebe723153433 (commit) from 5ec641fbbb67501e2a71be64b12c9224caee1b55 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit cae7e29cf27b3a751211dc71e1aeebe723153433 Author: Claire Gravely Date: Tue Jun 14 00:25:03 2016 +0200 Bug 15929 - typo in explanation for MaxSearchResultsItemsPerRecordStatusCheck There's a typo in the explanation for the new MaxSearchResultsItemsPerRecordStatusCheck sys pref that was added in 3.22.2. "If a record has more than this number of items, they availability statuses ..." I have re-worded the description so it reads a bit better. Test plan: 1. Check the description for syspref MaxSearchResultsItemsPerRecordStatusCheck. 2. Apply patch 3. Check syspref MaxSearchResultsItemsPerRecordStatusCheck description to make sure it makes sense. Signed-off-by: Mirko Tietgen Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/admin/preferences/searching.pref | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 15:08:31 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 13:08:31 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-257-geb77861 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via eb77861750cb3a2720e4a3a8003d526fa7d61552 (commit) from cae7e29cf27b3a751211dc71e1aeebe723153433 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit eb77861750cb3a2720e4a3a8003d526fa7d61552 Author: Marc V?ron Date: Mon Jun 20 15:27:39 2016 +0200 Bug 16779: Move road type after address in US style address formatting (main address) To verify: - Create a patron with address, streettype, streetnumber defined - Set syspref 'AddressFormat' to US style - Go to patron's detail page (in staff client) - In main address, road type preceeds address (e.g. 25 Drive Euclid) To test: - Apply patch - Refrexh patron's detail page - Verify that main address displays correctly (e.g. 25 Euclid Drive) Signed-off-by: Hector Castro Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../prog/en/includes/member-display-address-style-us.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 15:10:09 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 13:10:09 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-258-g90da601 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 90da601783e9f368939d41affb250289dd10204b (commit) from eb77861750cb3a2720e4a3a8003d526fa7d61552 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 90da601783e9f368939d41affb250289dd10204b Author: Hector Castro Date: Tue Jun 21 15:19:40 2016 -0600 Bug 16793: Use Font Awesome for arrows instead of images in audio_alerts.tt This changes fit with bug 16148 for marc modification template management To test -Apply patch -Goto Admin->Audio alerts -Verify that green arrows have disappeared now in blue Awesome Icons Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall https://bugs.koha-community.org/show_bug.cgi?id=16794 Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/admin/audio_alerts.tt | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 15:10:57 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 13:10:57 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-259-g68c0c94 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 68c0c94b94227a9d73456a50f08a735ee9746af7 (commit) from 90da601783e9f368939d41affb250289dd10204b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 68c0c94b94227a9d73456a50f08a735ee9746af7 Author: Hector Castro Date: Mon Jun 20 13:12:22 2016 -0600 Bug 16781: Add Font Awesome Icons to "Select/Clear all" links to modborrows.tt and result.tt Add Font Awesome Icons to "Select/Clear all" links to: modborrows.tt (Batch patron modification) and result.tt (Search results) To test: -Apply on top bugs 16469 and 16494 -Goto Batch patron modification -Create a new batch patron or select one patron list -See the new icons for "Select all" and "Clear all" -Do a search and see the new icons in Search results page Followed test plan, icons display as expected Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt | 4 ++-- koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 15:13:12 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 13:13:12 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-261-g9b399a8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 9b399a806100eb9568ae43d71b257f0801185072 (commit) via a50eb52a425dbe8ec774e2664fe9df179d32ceaa (commit) from 68c0c94b94227a9d73456a50f08a735ee9746af7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9b399a806100eb9568ae43d71b257f0801185072 Author: Jonathan Druart Date: Sun Jul 3 16:07:33 2016 +0100 Bug 16794: Group the 2 action buttons into the same column Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit a50eb52a425dbe8ec774e2664fe9df179d32ceaa Author: Hector Castro Date: Wed Jun 22 09:22:11 2016 -0600 Bug 16794: Revise layout for Admistration > Patron categories Add Bootstrap buttons and Font Awesome Icons to "Delete" and "Edit" links To test - Go to Administration -> Patron categories - Confirm that two button appear instead of links for "Edit" and "Delete" - Edit an existing category and confirm that works as expected - Delete a category and confirm that works properly. Patch fix it according with QA comment 3 Fix copy and paste according with QA comment 6 Fix column "Default privacy" to be sorted again according with comment 8 Patch set squashed Buttons appear now as requested in comment #3 (2 buttons, no action menu) Re-tested, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/js/categories.js | 4 ++-- koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt | 9 +++++---- 2 files changed, 7 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 15:14:09 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 13:14:09 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-262-ge3002ee Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e3002eea202a50b68e96650f37bcacc37843872e (commit) from 9b399a806100eb9568ae43d71b257f0801185072 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e3002eea202a50b68e96650f37bcacc37843872e Author: Marc V?ron Date: Wed Jun 22 07:57:06 2016 +0200 Bug 16795 - Patron categories: Accept integers only for enrolment period and age limits To test: - Apply patch - Clear browser cache - Go to Home > Administration > Patron categories - Create or edit a category - Verify that field 'In months', 'Age required' and 'Upperage limit' accept digits only Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/js/categories.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 15:22:35 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 13:22:35 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-263-g3c80818 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 3c80818f680278e595cf2a890b311db7866766a6 (commit) from e3002eea202a50b68e96650f37bcacc37843872e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3c80818f680278e595cf2a890b311db7866766a6 Author: Hector Castro Date: Thu Jun 23 10:35:24 2016 -0600 Bug 16803: Add Font Awesome Icons to "Select/Clear all" links to shelves.tt Add Font Awesome Icons to "Select/Clear all" links to shelves.tt (Public and private lists) To test: -Apply patch -Go to More -> Lists -Create some Public and Private Lists -See the contents of the list and notice about the new icons in "Select/Clear all" Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 15:25:28 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 13:25:28 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-264-g6663974 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 666397446f1af6a5fb2f71ed590c55c2fc7d84d1 (commit) from 3c80818f680278e595cf2a890b311db7866766a6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 666397446f1af6a5fb2f71ed590c55c2fc7d84d1 Author: Magnus Enger Date: Tue Jun 28 10:45:08 2016 +0200 Bug 16823 - Comment out koha-rebuild-zebra in koha-common.cron.d Bug 16190 enabled the indexer daemon by default for package installations. This means that it is no longer necessary to set up koha-rebuild-zebra as a cron job. This patch comments it out, so that people who might run into bug 16814 can easily activate the cronjob again after de-activating the indexer daemon. To test: Just read the diff and check that it makes sense. Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: debian/koha-common.cron.d | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 15:26:11 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 13:26:11 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-266-gf38bcf5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f38bcf5505e1196c3ae4d2e9d5df523bb07ef281 (commit) via abb7980004ad75de4a51d06815f5e98e1cbb0f6d (commit) from 666397446f1af6a5fb2f71ed590c55c2fc7d84d1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f38bcf5505e1196c3ae4d2e9d5df523bb07ef281 Author: Jonathan Druart Date: Thu Jul 7 16:40:47 2016 +0100 Bug 16857: Check on item.branches makes more sense The test should be on the existence of the item.branches method/attribute Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit abb7980004ad75de4a51d06815f5e98e1cbb0f6d Author: Marc V?ron Date: Mon Jul 4 11:37:33 2016 +0200 Bug 16857 - patron-attr-types.tt: Get rid of warnings "Argument "" isn't numeric" To vrify: - Go to Home > Administration > Patron attribute types - Make sure you have some patron attribute types with no branches limitation - For each attribute type you get a warning in intranet-error.log: patron-attr-types.pl: Argument "" isn't numeric in numeric gt (>) at (...)/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt line 284. To test: - Appy patch - Verify that warnings no longer appear in intranet-error.log Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 15:28:44 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 13:28:44 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-268-gc19f342 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via c19f342bb1a8eaae25db979e94dc23efa4bc8a26 (commit) via b80318f1b7441328d818dfe67a4cb8cd345f585e (commit) from f38bcf5505e1196c3ae4d2e9d5df523bb07ef281 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c19f342bb1a8eaae25db979e94dc23efa4bc8a26 Author: Jonathan Druart Date: Thu Jul 7 16:52:10 2016 +0100 Bug 16860: Remove the comment about the warning It is no longer necessary. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit b80318f1b7441328d818dfe67a4cb8cd345f585e Author: Mark Tompsett Date: Wed Jul 6 11:51:40 2016 -0400 Bug 16860: Catch warning t/db_dependent/ClassSource.t $ prove t/db_dependent/ClassSource.t t/db_dependent/ClassSource.t .. 3/24 attempting to use non-existent class sorting routine routine1 t/db_dependent/ClassSource.t .. ok All tests successful. Files=1, Tests=24, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.66 cusr 0.02 csys = 0.70 CPU) Result: PASS The above warning might be scary to those unfamiliar with the test. Add a test to catch the warning. TEST PLAN --------- 1) prove t/db_dependent/ClassSource.t -- as above 2) apply patch 3) prove t/db_dependent/ClassSource.t -- no message 4) prove -v t/db_dependent/ClassSource.t -- test 13 is the new test 5) run koha qa test tools Signed-off-by: Hector Castro Workas as advertised Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: t/db_dependent/ClassSource.t | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 15:39:40 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 13:39:40 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-273-g46b7d5e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 46b7d5e4c66d5eff732187dd25c5d3bc79305c8b (commit) via ffc4adcfb94d0932c159e1cb8af0a7903a1f728c (commit) via da8123326ef82e35c3369b700c62f6747618eced (commit) via 58501eb4d451ca73fc2cab50db4077cdb63ef625 (commit) via 6a493842cf85e025aa215391b4ef4166e4491546 (commit) from c19f342bb1a8eaae25db979e94dc23efa4bc8a26 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 46b7d5e4c66d5eff732187dd25c5d3bc79305c8b Author: Kyle M Hall Date: Fri Jul 8 13:36:32 2016 +0000 Bug 6906 - DBRev 16.06.00.008 Signed-off-by: Kyle M Hall commit ffc4adcfb94d0932c159e1cb8af0a7903a1f728c Author: Alex Sassmannshausen Date: Mon Jul 4 19:22:51 2016 +0200 Bug 6906: Follow coding guidelines in terminology. * Koha/Patron.pm (wantsCheckPrevCheckout, doCheckPrevCheckout): Rename to... (wants_check_for_previous_checkout, do_check_for_previous_checkout): ...this. * C4/Circulation.pm: Use new names. * t/db_dependent/Patron/CheckPrevCheckout.t: Renamed to... * t/db_dependent/Patron/Borrower_PrevCheckout.t: ...this. Bug 6906: Fix POD reference to old method name. * Koha/Patron.pm (wants_check_for_previous_checkout): Fix POD. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit da8123326ef82e35c3369b700c62f6747618eced Author: Jonathan Druart Date: Sun Jun 12 11:42:48 2016 +0100 Bug 6906: Add the warning message to the batch checkout Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 58501eb4d451ca73fc2cab50db4077cdb63ef625 Author: Jonathan Druart Date: Sun Jun 12 11:41:41 2016 +0100 Bug 6906: Tests - Do not assume CPL exists Since bug 14878, tests must create the data they need to pass and not assume they exist. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 6a493842cf85e025aa215391b4ef4166e4491546 Author: Alex Sassmannshausen Date: Fri Mar 11 15:00:01 2016 +0100 Bug 6906 - show 'Borrower has previously issued... New feature: provide granular means to configure warnings about items that have been issued to a particular borrower before, according to their checkout history. - Global syspref ('CheckPrevCheckout'), set to 'hardno' by default, allows users to enable this feature library wide. - Per patron category pref allows libraries to create overrides per category, falling back on the global setting by default. - Per patron pref allows switching the functionality on at the level of patron. Fall-back to category settings by default. * Koha/Patron (wantsCheckPrevCheckout, doCheckPrevCheckout): New methods. * C4/Circulation.pm (CanBookBeIssued): Introduce CheckPrevCheckout check. * admin/categories.pl: Pass along checkprevcheckout. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt: Expose CheckPrevCheckout per category setting. * koha-tmpl/intranet-tmpl/prog/en/modules/preferences/patrons.pref: Expose CheckPrevCheckout syspref. * koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt: Expose per patron CheckPrevCheckout preference. * koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt: Expose per patron CheckPrevCheckout preference. * koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: Add 'CHECKPREVCHECKOUT' confirmation message. * installer/data/mysql/kohastructure.sql: Modify structure of 'categories', 'borrowers', 'oldborrowers'. * installer/data/mysql/sysprefs.sql: Add 'CheckPrevCheckout'. * installer/data/mysql/atomicupdate/checkPrevCheckout.sql: New file. * t/db_dependent/Patron/CheckPrevCheckout.t: New file with unit tests. Test plan: - Apply patch. - Run updatedatabase. - Regenerate Koha Schema files. - Run the unit tests. - Verify 'CheckPrevCheckout' is visible in Patrons sysprefs and can be switched to 'hardyes', 'softyes', 'softno' and 'hardno'. + Check out previously checked out items to a patron, checking the message appears as expected. - Verify no 'Check previous checkouts' setting appears on the borrower category pages if the syspref is set to a 'hard' option. - Verify 'Check previous checkouts' setting appears on the borrower category pages and can be modified per borrower category. + Issue previously issued items to a borrower, checking the message appears as expected (This setting should override the default setting if that is set to a 'soft' option). - Verify no 'Check previous checkouts' setting appears on the individual borrower pages if the syspref is set to a 'hard' option. - Verify 'Check previous checkouts' setting appears on individual borrower pages and can be modified. + Issue previously issued items to a borrower, checking the message appears as expected (This setting should override the category setting and the default setting if the latter is set to a 'soft' option). Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 8 + Koha.pm | 2 +- Koha/Patron.pm | 76 +++- Koha/Schema/Result/Borrower.pm | 18 +- Koha/Schema/Result/Category.pm | 18 +- Koha/Schema/Result/Deletedborrower.pm | 18 +- admin/categories.pl | 3 + installer/data/mysql/kohastructure.sql | 3 + installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 26 ++ .../prog/en/modules/admin/categories.tt | 53 +++ .../prog/en/modules/admin/preferences/patrons.pref | 9 + .../prog/en/modules/circ/circulation.tt | 4 + .../en/modules/circ/circulation_batch_checkouts.tt | 4 + .../prog/en/modules/members/memberentrygen.tt | 21 +- .../prog/en/modules/members/moremember.tt | 11 + t/db_dependent/Patron/Borrower_PrevCheckout.t | 448 ++++++++++++++++++++ 17 files changed, 714 insertions(+), 9 deletions(-) create mode 100644 t/db_dependent/Patron/Borrower_PrevCheckout.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 15:42:27 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 13:42:27 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-275-gdf57c8e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via df57c8e864aefe0e90b49aa15fc95b6dcaafda7b (commit) via 08e448ee4bfbd7a85dfbfd6d0d77f8d59dd93b8e (commit) from 46b7d5e4c66d5eff732187dd25c5d3bc79305c8b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit df57c8e864aefe0e90b49aa15fc95b6dcaafda7b Author: Jonathan Druart Date: Wed Jul 6 16:57:05 2016 +0100 Bug 9259: Use is instead of is_deeply Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 08e448ee4bfbd7a85dfbfd6d0d77f8d59dd93b8e Author: Aleisha Date: Tue Mar 29 00:04:36 2016 +0000 Bug 9259: Ability to delete a staged file once it has been cleaned To test: 1) Go to Tools -> Staged MARC Management and clean a file. If you have no files to clean, go to 'Stage MARC for import' and upload one to clean following the necessary steps. 2) Confirm that once the file has been cleaned, the Action column now shows a Delete button. Confirm this button only shows for cleaned files. 3) Click the Delete button. 4) Confirm that clicking Cancel exits the pop-up message and does not delete the file. 5) Confirm that clicking OK refreshes the list of staged records and the one you just deleted is no longer on it (has been deleted). You can confirm this by checking for the file in mysql (SELECT * FROM import_batches WHERE import_batch_id = X;) 6) Run prove -v t/db_dependent/ImportBatch.t (have written unit tests for CleanBatch and DeleteBatch) Sponsored-by: Catalyst IT Signed-off-by: Liz Rea Catalyst sign off, so needs another one but YAY this is great. Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/ImportBatch.pm | 19 +++++++++++++ .../prog/en/modules/tools/manage-marc-import.tt | 16 +++++++++-- t/db_dependent/ImportBatch.t | 29 +++++++++++++++++++- tools/manage-marc-import.pl | 6 ++++ 4 files changed, 67 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 15:44:23 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 13:44:23 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-278-g9e1542e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 9e1542eb84a0c8b02eae6ca3ff3616d0a5d412da (commit) via 03795b65d59d1e0bed9e6860e0309643b3bb13a6 (commit) via 3e576f65b2dff4616d8b57d8f31dea1a3a402ffc (commit) from df57c8e864aefe0e90b49aa15fc95b6dcaafda7b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9e1542eb84a0c8b02eae6ca3ff3616d0a5d412da Author: Marc V?ron Date: Mon Jun 20 14:59:11 2016 +0200 Bug 10760: (followup) Move street type after address As of comment #7 Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall commit 03795b65d59d1e0bed9e6860e0309643b3bb13a6 Author: Marc V?ron Date: Tue Jun 14 10:57:52 2016 +0200 Bug 10760: Alternate Address: Display street number and street type This patch displays alternate streetnumber and street type on patron's detail page. To test: - Apply patch - Verify that the alternate address information displays follwing the setting in syspref AddressFormat and contains street type and street number (as appropriate) Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall commit 3e576f65b2dff4616d8b57d8f31dea1a3a402ffc Author: Marc V?ron Date: Tue Jun 14 10:14:29 2016 +0200 Bug 10760: Alternate Address: Make street number and street type editable Table 'borrowers' contain columns B_streetnumber and B_streettype. This patch makes them editable for alternate address. To test: - Apply patch - Edit a patron's details - Verify that in edit mode for Alternate address, the fields 'street type' and 'street number' appear and follow the settings in sysprefs AddressFormat, BorrowerMandatoryField, BorrowerUnwantedField - Verify that the values are saved correctly. Note: A second patch will follow to manage the display of street number and street type Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../en/includes/member-alt-address-style-de.inc | 36 ++++++++++++++++++++ .../en/includes/member-alt-address-style-us.inc | 35 +++++++++++++++++++ .../member-display-alt-address-style-de.inc | 16 +++++++++ .../member-display-alt-address-style-us.inc | 16 +++++++++ .../prog/en/modules/members/moremember.tt | 14 ++++---- 5 files changed, 111 insertions(+), 6 deletions(-) create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/member-display-alt-address-style-de.inc create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/member-display-alt-address-style-us.inc hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 15:49:02 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 13:49:02 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-283-g0527388 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 0527388924b20bb63f38a2a4eccf9cf794faaac7 (commit) via 32b1d0386acac268fb65d81a66ffe1561f830c2d (commit) via e82e4bfc073be6c419fe79f3653bb01c72bd2135 (commit) via fd622dc73d5b0d37aa588fbcaa0e5ed6e84610f0 (commit) via 7276a38c2b67b7ef48b85f544527648b358efa6d (commit) from 9e1542eb84a0c8b02eae6ca3ff3616d0a5d412da (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0527388924b20bb63f38a2a4eccf9cf794faaac7 Author: Jonathan Druart Date: Tue Jun 28 14:37:57 2016 +0100 Bug 14757: Remove obsolete occurrence of is_tt Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 32b1d0386acac268fb65d81a66ffe1561f830c2d Author: Kyle M Hall Date: Mon Jun 27 13:43:59 2016 +0000 Bug 14757 [QA Followup] - Don't overload new for Modifications Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit e82e4bfc073be6c419fe79f3653bb01c72bd2135 Author: Jonathan Druart Date: Fri Jun 24 15:28:43 2016 +0100 Bug 14757: Add tests for new modules Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit fd622dc73d5b0d37aa588fbcaa0e5ed6e84610f0 Author: Kyle M Hall Date: Fri Jan 22 12:43:12 2016 +0000 Bug 14757 [QA Followup] - Add Unit Tests Signed-off-by: Sean McGarvey Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 7276a38c2b67b7ef48b85f544527648b358efa6d Author: Kyle M Hall Date: Wed Dec 2 13:32:44 2015 +0000 Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices This bug is the beginning of a conversion from our current bespoke syntax for slips and notices to Template Toolkit syntax. This patch is the initial seed which will evolve over time. With this addition, we can take advantage of our Koha Objects to greatly simplify the processing of Slips and Notices over time. Test Plan: 1) Apply this patch 2) Ensure you have the default CHECKOUT notice 3) Check out and return an item for a patron 4) Note the text of the CHECKOUT notice 5) Replace your CHECKOUT notice with the following: The following items have been checked out: ---- [% biblio.title %] ---- Thank you for visiting [% branch.branchname %]. 6) Repeat step 3 7) Note the CHECKOUT notice text matches the previous CHECKOUT notice text Signed-off-by: Bernardo Gonzalez Kriegel New notice syntax works, no koha-qa errors Signed-off-by: Sean McGarvey Bug 14757 [QA Followup] - Change method type() to _type() for Koha objects Signed-off-by: Sean McGarvey Bug 14757 [QA Followup] - Change all references to Koha::Borrower to Koha::Patron Signed-off-by: Sean McGarvey Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Letters.pm | 163 +++++++++++++- Koha/{Serial.pm => Checkout.pm} | 6 +- Koha/{Serials.pm => Checkouts.pm} | 14 +- Koha/{Serials.pm => News.pm} | 14 +- Koha/{Subscription.pm => NewsItem.pm} | 8 +- Koha/{Subscription.pm => Patron/Modification.pm} | 8 +- Koha/Patron/Modifications.pm | 18 +- Koha/{Serial.pm => Suggestion.pm} | 6 +- Koha/{Serials.pm => Suggestions.pm} | 14 +- t/db_dependent/Koha/Checkouts.t | 63 ++++++ t/db_dependent/Koha/News.t | 56 +++++ t/db_dependent/Koha/Suggestions.t | 60 ++++++ t/db_dependent/Letters/TemplateToolkit.t | 249 ++++++++++++++++++++++ 13 files changed, 641 insertions(+), 38 deletions(-) copy Koha/{Serial.pm => Checkout.pm} (91%) copy Koha/{Serials.pm => Checkouts.pm} (85%) copy Koha/{Serials.pm => News.pm} (86%) copy Koha/{Subscription.pm => NewsItem.pm} (85%) copy Koha/{Subscription.pm => Patron/Modification.pm} (86%) copy Koha/{Serial.pm => Suggestion.pm} (90%) copy Koha/{Serials.pm => Suggestions.pm} (84%) create mode 100644 t/db_dependent/Koha/Checkouts.t create mode 100644 t/db_dependent/Koha/News.t create mode 100644 t/db_dependent/Koha/Suggestions.t create mode 100644 t/db_dependent/Letters/TemplateToolkit.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 15:55:09 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 13:55:09 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-287-ge68f620 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e68f620188b792a4ed5bfe13e0fce7f22f6a81d5 (commit) via 600786e7f1d0577a50f154ffead7b89f3505c977 (commit) via 1fcdef312be42c673d4ae017e3abe7722aba6048 (commit) via 2cc6e67204cfc8c4864e7a4ad938b3859ae57fbe (commit) from 0527388924b20bb63f38a2a4eccf9cf794faaac7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e68f620188b792a4ed5bfe13e0fce7f22f6a81d5 Author: Kyle M Hall Date: Thu Jun 23 14:45:34 2016 +0000 Bug 14790 [QA Followup] - Don't show links unless OPACBaseURL is set Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 600786e7f1d0577a50f154ffead7b89f3505c977 Author: Kyle M Hall Date: Wed Jun 15 14:30:18 2016 +0000 Bug 14790 - Add OPAC view link to Serials detail Test Plan: 1) Apply this patch 2) Browse to subscription-detail.pl for a given serial 3) Note the new "OPAC view" link 4) Click the link, a new tab should open up showing the record details for that record in the OPAC Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 1fcdef312be42c673d4ae017e3abe7722aba6048 Author: Kyle M Hall Date: Wed Jun 15 13:55:28 2016 +0000 Bug 14790 - Add OPAC view link to items editor Test Plan: 1) Apply this patch 2) Find a record and open the items editor for it 3) Click the "Actions" button for an item 4) Choose the option "OPAC view" 5) A new browser tab should open to the OPAC details page for the record whose items you are editing. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 2cc6e67204cfc8c4864e7a4ad938b3859ae57fbe Author: Kyle M Hall Date: Wed Jun 15 12:27:40 2016 +0000 Bug 14790 - Add Opac view link to search results Test Plan: 1) Apply this patch 2) Perform a staff catalog search 3) Note the new "OPAC view" link 4) Click the link, it should open a new tab to the OPAC details for that record. This works fine except that it doesn't open in a new tab. I don't think it's the fault of the patch, but of browser.js messing with links again (See Bug 11937). Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt | 10 +++++++++- .../intranet-tmpl/prog/en/modules/cataloguing/additem.tt | 4 ++++ .../prog/en/modules/serials/subscription-detail.tt | 7 +++++++ 3 files changed, 20 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 16:03:22 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 14:03:22 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-290-gf65cf57 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f65cf574d0ad0aa1264dd78bdb7b5baeb09e5e95 (commit) via 80921b10f547ceb7491178b9e9233867e43e2429 (commit) via 99acd38edb0ab7efea33aa206ec62bd04a8f1570 (commit) from e68f620188b792a4ed5bfe13e0fce7f22f6a81d5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f65cf574d0ad0aa1264dd78bdb7b5baeb09e5e95 Author: Kyle M Hall Date: Fri Jul 8 14:01:41 2016 +0000 Bug 14902 - Fix issues with updatedatabase.pl Signed-off-by: Kyle M Hall commit 80921b10f547ceb7491178b9e9233867e43e2429 Author: Kyle M Hall Date: Fri Jul 8 13:59:37 2016 +0000 Bug 14902 - DBRev 16.06.00.009 Signed-off-by: Kyle M Hall commit 99acd38edb0ab7efea33aa206ec62bd04a8f1570 Author: Nick Clemens Date: Fri Jun 3 12:52:01 2016 -0400 Bug 14902 - Add qualifier menu to staff side "Search the Catalog" To test: 1 - Apply patch and update dabase 2 - Check that Search the Catalog links throughout the staff interface have not changed 3 - Set "IntranetCatalogSearchPulldown" to 'Show' 4 - Verify that 'Search the catalog' links through staff client now have a dropdwon to select search index I think viewing one file each that includes updated header should be sufficient, but please check as many as you can: cgi-bin/koha/admin/aqbudgetperiods.pl cgi-bin/koha/admin/admin-home.pl cgi-bin/koha/cataloguing/addbooks.pl cgi-bin/koha/circ/returns.pl cgi-bin/koha/circ/circulation-home.pl cgi-bin/koha/admin/cities.pl cgi-bin/koha/admin/aqcontract.pl cgi-bin/koha/admin/currency.pl cgi-bin/koha/mainpage.pl cgi-bin/koha/tools/letter.pl cgi-bin/koha/members/members-home.pl cgi-bin/koha/admin/categories.pl cgi-bin/koha/admin/preferences.pl cgi-bin/koha/admin/printers.pl cgi-bin/koha/serials/serials-home.pl cgi-bin/koha/acqui/newordersuggestion.pl cgi-bin/koha/admin/z3950servers.pl Sponsored by: Northeast Kansas Library System (http://nekls.org/) Signed-off-by: Heather Braum Signed-off-by: Barton Chittenden Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 14 ++++++++++++-- .../prog/en/includes/budgets-admin-search.inc | 2 ++ koha-tmpl/intranet-tmpl/prog/en/includes/cat-search.inc | 2 ++ .../intranet-tmpl/prog/en/includes/cataloging-search.inc | 3 ++- .../intranet-tmpl/prog/en/includes/checkin-search.inc | 2 ++ koha-tmpl/intranet-tmpl/prog/en/includes/circ-search.inc | 2 ++ .../prog/en/includes/cities-admin-search.inc | 2 ++ .../prog/en/includes/contracts-admin-search.inc | 2 ++ .../prog/en/includes/currencies-admin-search.inc | 2 ++ koha-tmpl/intranet-tmpl/prog/en/includes/home-search.inc | 2 ++ .../intranet-tmpl/prog/en/includes/letters-search.inc | 2 ++ .../intranet-tmpl/prog/en/includes/patron-search.inc | 3 ++- .../prog/en/includes/patrons-admin-search.inc | 2 ++ .../prog/en/includes/prefs-admin-search.inc | 2 ++ .../prog/en/includes/printers-admin-search.inc | 2 ++ .../intranet-tmpl/prog/en/includes/serials-search.inc | 2 ++ .../prog/en/includes/suggestions-add-search.inc | 2 ++ .../prog/en/includes/z3950-admin-search.inc | 2 ++ .../prog/en/modules/admin/preferences/staff_client.pref | 6 ++++++ 21 files changed, 54 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 16:10:57 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 14:10:57 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-300-gd951ba6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d951ba620cafc132ea8a9f083c1f997f64148629 (commit) via 1b89150d42548304d37fdb1def5ffd727d719f69 (commit) via 2c2efbf4a66fb3f8c0d1212d960d5d202518bc7b (commit) via 7cde3e216bc4ca120ed1cfe983b690a4f3f6944c (commit) via 074a3ee3383b6038f29f8859cf6c96accc6fa072 (commit) via b6a774028adb8c64dcf904e7fc76290fb82c569b (commit) via 9ebeb9acb3f186969bccba95a88f72665e8769d7 (commit) via 1bfe7c7512ca7979afc27dca520fba062543e34c (commit) via 5aa3313239840e43495e9355adf76feef8db737f (commit) via 7445b8f897718306340aeac6cc4427b05f0eeaf1 (commit) from f65cf574d0ad0aa1264dd78bdb7b5baeb09e5e95 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d951ba620cafc132ea8a9f083c1f997f64148629 Author: Kyle M Hall Date: Fri Jul 8 14:11:42 2016 +0000 Bug 15128 - DBRev 15128 Signed-off-by: Kyle M Hall commit 1b89150d42548304d37fdb1def5ffd727d719f69 Author: Jonathan Druart Date: Fri Jul 1 17:00:39 2016 +0100 Bug 15128: Do not display "New suggestion" if limit has just been reached If limit is X and patrons has X-1 pending suggestions, when a new one is added, the "New suggestion" should not been added. to avoid another call to SearchSuggestions, we assume than the suggestion has been correctly added. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 2c2efbf4a66fb3f8c0d1212d960d5d202518bc7b Author: Jonathan Druart Date: Fri Jul 1 16:55:39 2016 +0100 Bug 15128: Revert Display all purchase suggestions whether or not suggestion was added This does not work correctly and should be handle on another bug report. The behavior existed prior to this patchset. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 7cde3e216bc4ca120ed1cfe983b690a4f3f6944c Author: Nick Clemens Date: Fri Jul 1 11:39:00 2016 -0400 Bug 15128 - (QA Followup) Don't get patrons suggestions if limit not set Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 074a3ee3383b6038f29f8859cf6c96accc6fa072 Author: Nick Clemens Date: Fri Jul 1 11:36:02 2016 -0400 Bug 15128 - (QA Followup) Fix use of 'my' variable causing loss of data Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit b6a774028adb8c64dcf904e7fc76290fb82c569b Author: Nick Clemens Date: Thu Jun 30 10:20:39 2016 -0400 Bug 15128 (QA Followup) Display all purchase suggestions whether or not suggestion was added Correct enforcement of 0 limit Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 9ebeb9acb3f186969bccba95a88f72665e8769d7 Author: Nick Clemens Date: Mon Jun 20 16:04:21 2016 -0400 Bug 15128 - Followup Only check limit for signed in borrower Show all suggestions after a new one is added Signed-off-by: Barbara Walters Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 1bfe7c7512ca7979afc27dca520fba062543e34c Author: Kyle M Hall Date: Mon Jun 20 19:25:12 2016 +0000 Bug 15128 [QA Followup 2] - Only count pending suggestions for the limit Signed-off-by: Barbara Walters Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 5aa3313239840e43495e9355adf76feef8db737f Author: Kyle M Hall Date: Mon Jun 20 16:44:38 2016 +0000 Bug 15128 [QA Followup] - Make suggestion display after being added Also fixes the issue that the add suggestion link would sometimes show even if the patron could not make an additional suggestion. Signed-off-by: Barbara Walters Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 7445b8f897718306340aeac6cc4427b05f0eeaf1 Author: Nick Clemens Date: Tue Jun 14 16:47:43 2016 -0400 Bug 15128 - Add ability to limit patrons open purchase suggestions To test: 1 - Define a number of MaxOpenSuggestions 2 - Add some suggestions for a patron 3 - Note they cannot add any more suggestions if limit is reached 4 - Delete a suggestion and note you can add another 5 - Add them to limit again 6 - Accept a suggestion in the staff client and note user can add more 7 - Repeat above with rejecting or deleting 8 - Sign off. Sponsored by: North Central Regional Library (http://ncrl.org/) Signed-off-by: Barbara Walters Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 11 +++ .../prog/en/modules/admin/preferences/opac.pref | 6 +- .../bootstrap/en/modules/opac-suggestions.tt | 19 ++++- opac/opac-suggestions.pl | 74 +++++++++++++------- 6 files changed, 83 insertions(+), 30 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 16:12:41 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 14:12:41 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-302-g74ce643 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 74ce643b89f3c49f163b9a553c74f45104c6130b (commit) via 1d6c235addcb290fcee091c3e2273b089631ad86 (commit) from d951ba620cafc132ea8a9f083c1f997f64148629 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 74ce643b89f3c49f163b9a553c74f45104c6130b Author: Hector Castro Date: Wed Dec 2 10:56:25 2015 -0600 Bug 15172: (follow-up)Serial enumchron/sequence not visible when returning/checking in Items Display br and span tag only if the value enumchron exists. To test -Apply patches -Follow the previous test plan -Checkin whichever material (e.g., book) without sequence or enumchrom -Open up source code for checkin page, search under title and verify that b and span tags do not appear Signed-off-by: Alain et Aur?lie Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 1d6c235addcb290fcee091c3e2273b089631ad86 Author: Olli-Antti Kivilahti Date: Wed Nov 11 13:23:15 2015 +0200 Bug 15172: Serial enumchron/sequence not visible when returning/checking in Items Displays the items.enumchron-column in returns.pl when checking in Items. Rewording commit To test: -Checkout a barcode for serial with items generated in Serials > New subscription or item in DB with items.enumchron-column -Checkin the same barcode, the table Checked-in items will appear without information about "Publications details (Vol. 400, No. 32)" -Apply patch -Checkout and checkin another item of the same serial title -Notice about the Vol. 400, No. 32 below the serial title. Signed-off-by: Hector Castro items.enumchron-column display successful in returns.pl (Home>Circulation> Check in) NOTE: Patch rebased on master Signed-off-by: Alain et Aur?lie Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: circ/returns.pl | 1 + koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 8 +++++++- 2 files changed, 8 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 16:16:52 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 14:16:52 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-303-g975be0a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 975be0aef051d1131c39a02cbf7b6efe2f67d113 (commit) from 74ce643b89f3c49f163b9a553c74f45104c6130b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 975be0aef051d1131c39a02cbf7b6efe2f67d113 Author: Julian Maurice Date: Fri Apr 15 10:49:29 2016 +0200 Bug 16271: Allow more filters on /api/v1/holds borrowernumber parameter is no longer required and you can filter on every column of reserves table Some example requests - GET /api/v1/holds - GET /api/v1/holds?biblionumber=123 - GET /api/v1/holds?borrowernumber=456 - GET /api/v1/holds?priority=0&found=W Signed-off-by: Benjamin Rokseth Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/REST/V1/Hold.pm | 14 +++--- api/v1/swagger.json | 103 ++++++++++++++++++++++++++++++++++++++++- t/db_dependent/api/v1/holds.t | 19 ++++++-- 3 files changed, 125 insertions(+), 11 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 16:18:08 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 14:18:08 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-304-g90b3241 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 90b3241fb8d92a1217a001606b4f2bd23f3b0176 (commit) from 975be0aef051d1131c39a02cbf7b6efe2f67d113 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 90b3241fb8d92a1217a001606b4f2bd23f3b0176 Author: Aleisha Date: Thu Apr 21 22:49:29 2016 +0000 Bug 16324: Move item search into header This patch makes the Search button in the header into a dropdown that holds the Advanced search and the Item search. I have rewritten this patch to be independent of Bug 16323 since that patch is so controversial. To test: 1) Confirm that Advanced search and Item search are both under the 'Search' dropdown menu in the header and both links work as expected Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely Signed-off-by: Jonathan Druart Note that the CAN_user_catalogue test is useless. If a librarian does not have it, (s)he cannot access to the staff interface. Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/header.inc | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 16:25:26 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 14:25:26 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-305-ge29de99 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e29de9967b40bbdb959f8c0123db8974fff68cdc (commit) from 90b3241fb8d92a1217a001606b4f2bd23f3b0176 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e29de9967b40bbdb959f8c0123db8974fff68cdc Author: Owen Leonard Date: Mon May 23 11:03:48 2016 -0400 Bug 16566 [Revised] 'Print slip' button formatting inconsistent This patch modifies the style of some "print slip" links on the checkin page to make them consistent with other buttons shown in dialogs. This patch also removes the use of "onclick" in some places in favor of defining events in the JavaScript. To test apply the patch and go to Circulation -> Check in. - Check in an item which belongs at another branch. You should see a dialog which asks the user to transfer the item. Confirm that the "Print slip" button looks correct and works correctly. - Check in the same item again. You should see a different dialog which has both a "Print transfer slip" and "Cancel transfer" button. The "Print transfer slip" button should look correct and work correctly. - Check in an item which is part of a rotating collection. (Or, if Bug 16570 is still open, check in any item) You should see a dialog which notifies you that the item is part of a rotating collection. The "Print slip" button in this dialog should look correct and work correctly. Followed test plan. Buttons appear as expected. Signed-off-by: Marc V?ron Revision following QA: Removed redundant class attribute from the print button tested in step 1. Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 16:26:40 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 14:26:40 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-306-gb9e47f1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b9e47f135e036232b00cd3b24bb25ea0c6a9291e (commit) from e29de9967b40bbdb959f8c0123db8974fff68cdc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b9e47f135e036232b00cd3b24bb25ea0c6a9291e Author: Fridolin Somers Date: Tue Jun 7 09:27:15 2016 +0200 Bug 16677 - Use abbr for authorities linked headings In authorities search results, UNIMARC flavour, linked headings are displayed with a link type : BT, NT, UF, RT. This patch adds a abbr tag around those acronyms to know there meaning : BT = Broader Term NT = Narrower Term UF = Used For RT = Related Term Acronyms are used because there can be a lot of linked headings, using abbr will display the complete text on mouse over. Test plan : - Use UNIMARC database - Create an authority with : 250 $a Heading250a 450 $a Heading450a 550 $5 a $a Heading550a 550 $5 g $a Heading550g 550 $5 h $a Heading550h - Save an index zebraqueue - Go to intranet authorities search - Search for "Heading250a" - You see : Heading250a Heading250a UF: Heading450a RT: Heading550a ; BT: Heading550g ; NT: Heading550h - Move your mouse over the acronyms, you see a tip with the complete text - Same with opac authorities search Signed-off-by: Fr?d?ric Demians Works as described. Translatable. Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../prog/en/includes/authorities-search-results.inc | 8 ++++---- .../bootstrap/en/includes/authorities-search-results.inc | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 16:40:04 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 14:40:04 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-307-gf542ce5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f542ce5a82a40b503b10c709b8b960ace2637f7d (commit) from b9e47f135e036232b00cd3b24bb25ea0c6a9291e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f542ce5a82a40b503b10c709b8b960ace2637f7d Author: Marc V?ron Date: Tue Jun 14 08:41:03 2016 +0200 Bug 16730 - Use member-display-address-style*-includes in moremember-brief.tt To test: - Apply patch - Create a new patron with the same first and last name as an existing patron. This should trigger a duplicate warning message. Click the "View existing record" link to trigger a pop-up window with a patron detail brief view. - Verify that the address information displays the same way as on the patron details screen (moremember.pl). - Change syspref 'AddressFormat' and verify that the address displays as appropriate. Signed-off-by: Fr?d?ric Demians Works as described: AddressFormat is taken into account on 'view exiting record' dialog box. Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/members/moremember-brief.tt | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 16:40:45 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 14:40:45 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-308-g0716da9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 0716da922eb867603a500f6c6b67b1d00652d964 (commit) from f542ce5a82a40b503b10c709b8b960ace2637f7d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0716da922eb867603a500f6c6b67b1d00652d964 Author: Owen Leonard Date: Wed Jun 1 10:54:09 2016 -0400 Bug 16778: Replace usage of Greybox modals with Bootstrap modals This patch is a proof-of-concept for replacing Greybox modals in situations where in-modal page transitions happen. This one addresses patron card export from the patron lists page. To test you must have at least one patron lists containing patrons. - Apply the patch and go to Patrons -> Patron lists. - In the 'Actions' menu associated with your list, choose 'Print patron cards.' A modal window should be triggered. - In the modal window, change settings as necessary and click the "Export" button. - The modal should reload and display a link to download a PDF. Confirm that the PDF download works correctly and that the correct patron batch was processed. - Repeat the process and confirm at each step that clicking the 'X' button or the 'Cancel' link dismisses the modal window. To confirm that changes to the patron card print template has not adversely affected printing patron cards from the patron card creator page: - Go to Tools -> Patron card creator. - Choose Manage -> Card batches. - Click 'Export' for any batch. - Confirm that the Greybox modal still works correctly for patron card export. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/patron_lists/lists.tt | 46 ++++++++++++++++++-- .../prog/en/modules/patroncards/print.tt | 4 +- 2 files changed, 44 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 16:41:54 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 14:41:54 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-309-gc9bb9dc Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via c9bb9dc14064ddecf767145b7a2bb26794ca090e (commit) from 0716da922eb867603a500f6c6b67b1d00652d964 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c9bb9dc14064ddecf767145b7a2bb26794ca090e Author: Hector Castro Date: Wed Jun 22 11:11:03 2016 -0600 Bug 16801 - Include Font Awesome Icons to check/unchek all in Administration > Library transfer limits For purpose to uniformity and leave just one entry in .po files, this patch change: Check all/Uncheck all -> to -> Select all/Clear all. Also added Font Awesome icons. To test: -Go to Administration > Library transfer limits -Notice about Check all/Uncheck all for "For all items types" and "Policy for:" -Apply patch and refresh the screen -Notice about the new Select all/Clear all links with their icons -Confirm that all links work as expected Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 16:43:38 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 14:43:38 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-312-gdee29d9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via dee29d9f0b2b43bc762cb82a2212cd8a3d243f45 (commit) via c57655d4ad69f82831b7f1b54b31a69d0d8275ee (commit) via 5821ff3867c5291558238e54686c6834caa266c6 (commit) from c9bb9dc14064ddecf767145b7a2bb26794ca090e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit dee29d9f0b2b43bc762cb82a2212cd8a3d243f45 Author: Mark Tompsett Date: Thu Jun 23 14:51:26 2016 -0400 Bug 16805: Log in with database admin user breaks OPAC TEST PLAN --------- 1) Apply Jonathan's test patch 2) prove t/db_dependent/Letters.t -- dies before finishing tests 3) Apply second test patch 4) prove t/db_dependent/Letters.t -- dies before finishing tests -- 'addalert' is changed to 'getalert' 5) Log into OPAC with database admin user. -- see error given in comment #0 6) Apply this patch 7) prove t/db_dependent/Letters.t -- says 'getalert' -- all tests pass. 8) Log into OPAC with database admin user. -- logs in, but gives warning with a nice logout button. 9) run koha qa test tools. Signed-off-by: Hector Castro No kaha qa errors In debian display diferent error: Can't use an undefined value as an ARRAY reference at /usr/lib/perl5/DBI.pm line 2054. Works as advertised NOTE: Revised test plan, as Jonathan added useful test case. Works as I've tested above. Hector tested older test plan which was steps 5,6,8 and 9. Revised test plan again while tweaking to address comment #9. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit c57655d4ad69f82831b7f1b54b31a69d0d8275ee Author: Mark Tompsett Date: Fri Jun 24 12:28:27 2016 -0400 Bug 16805: Tweak new test message to say getalert It said 'addalert', which is likely a cut-paste typo. Plus, let's keep running the other tests if that one goes bad. TEST PLAN --------- 1) Apply Jonathan's test patch 2) prove t/db_dependent/Letters.t -- dies before finishing tests 3) Apply this test patch 4) prove t/db_dependent/Letters.t -- still dies before finished tests, 'addalert' now is 'getalert' in message. 5) run koha qa test tools. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 5821ff3867c5291558238e54686c6834caa266c6 Author: Jonathan Druart Date: Fri Jun 24 17:02:59 2016 +0100 Bug 16805: Add test to getalert (no param passed) TEST PLAN --------- 1) apply patch 2) prove t/db_dependent/Letters.t -- fails 3) run koha qa test tools Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Letters.pm | 9 ++++----- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 12 ++++++++++++ opac/opac-user.pl | 4 ++++ t/db_dependent/Letters.t | 10 ++++++---- 4 files changed, 26 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 16:47:42 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 14:47:42 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-315-g1aa9f7b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 1aa9f7b92fa831c943f7bccf470dbed72eba3c17 (commit) via b7f15db41ae83654387a2191fa72bde60450b0b0 (commit) via 13bf3686c5d0fd3a3a192db961118535ece41a4c (commit) from dee29d9f0b2b43bc762cb82a2212cd8a3d243f45 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1aa9f7b92fa831c943f7bccf470dbed72eba3c17 Author: Jonathan Druart Date: Sun Jul 3 15:58:16 2016 +0100 Bug 16819: Remove use of map Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit b7f15db41ae83654387a2191fa72bde60450b0b0 Author: Tomas Cohen Arazi Date: Tue Jun 28 10:18:48 2016 -0300 Bug 16819: C4::Members::DelMember should use Koha::Holds to delete holds This patch makes C4::Members::DelMember proprely use Koha::Holds to delete holds. This is important as holds actions are started to be logged. To reproduce: - Apply the patch - Run: $ prove t/db_dependent/Members.t => SUCCESS: Tests pass - Sign off :-D Sponsored-by: NEKLS Signed-off-by: Hector Castro All tests pass successfully Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 13bf3686c5d0fd3a3a192db961118535ece41a4c Author: Tomas Cohen Arazi Date: Tue Jun 28 10:57:38 2016 -0300 Bug 16819: Unit tests for C4::Members::DelMember The C4::Members::DelMember function actually deletes reserves, and it is not properly tested. To test: - Apply the patch - Run: $ prove t/db_dependent/Members.t => SUCCESS: Tests pass - Sign off Sponsored-by: NEKLS Signed-off-by: Hector Castro Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Members.pm | 13 ++++++------- t/db_dependent/Members.t | 15 +++++++++++++-- 2 files changed, 19 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 16:48:51 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 14:48:51 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-316-g042e8cf Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 042e8cf24bf3de4192b4c7cf0ca4e5f1da6c3ce9 (commit) from 1aa9f7b92fa831c943f7bccf470dbed72eba3c17 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 042e8cf24bf3de4192b4c7cf0ca4e5f1da6c3ce9 Author: Mark Tompsett Date: Wed Jul 6 15:19:46 2016 -0400 Bug 16866: Catch warning t/db_dependent/Languages.t TEST PLAN --------- 1) prove t/db_dependent/Languages.t -- noisy output 2) apply patch 3) prove t/db_dependent/Languages.t -- no noise 4) run koha qa test tools. Signed-off-by: Hector Castro No noisy output Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Languages.t | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 16:58:36 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 14:58:36 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-317-g94441be Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 94441be435d9be074fc0f93bbec2c2e9122a5d67 (commit) from 042e8cf24bf3de4192b4c7cf0ca4e5f1da6c3ce9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 94441be435d9be074fc0f93bbec2c2e9122a5d67 Author: Colin Campbell Date: Fri Mar 6 11:57:09 2015 +0000 Bug 13807 Rework main input loop in SIPServer Debugging various problems in SIPServer and control of it, found it could loop on unread buffers (e.g. the LF of a CRLF if it was only expecting CR) making it unresponsive to signals. Reworked the input loop with an eye to removing unnecessary whiles and replacing the while(1) by a while( connection valid) Enhanced the timeout code by wapping in an eval. Moved the logic from SIP_read_packet into the server itself Hopefully this makes the already baroque code easier to navigate and it did seem the server was the logical place for this Removed no longer iused SIP_read_packet from Sip.pm Signed-off-by: Srdjan Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/SIP/SIPServer.pm | 107 +++++++++++++++++++++++++++++++++++---------------- C4/SIP/Sip.pm | 56 +-------------------------- 2 files changed, 74 insertions(+), 89 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 8 22:36:27 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 Jul 2016 20:36:27 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-320-gfa70b5b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via fa70b5b4c705aa671e1ec57a3509f6372917f808 (commit) via 4e415da44c546ba1aae21b40b8c7fb0054a7e0d2 (commit) via 73ace7513b18c9b8b2d5b594614d5c251d06d1f2 (commit) from 94441be435d9be074fc0f93bbec2c2e9122a5d67 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fa70b5b4c705aa671e1ec57a3509f6372917f808 Author: Jonathan Druart Date: Fri Mar 25 17:04:14 2016 +0000 Bug 13691: Add changes for 3.22 To test: Run the tests t/db_dependent/selenium/basic_workflow.t After you have set up selenium following the tests in the previous patch Signed-off-by: Chris Cormack Signed-off-by: Tomas Cohen Arazi Signed-off-by: Brendan Gallagher commit 4e415da44c546ba1aae21b40b8c7fb0054a7e0d2 Author: Jonathan Druart Date: Tue Feb 10 16:07:31 2015 +0100 Bug 13691: Add basic selenium script This script has been used to compare 3.16.x and 3.18.x performances on bug 13690. What it does: - Go on the mainpage and process a log in - Create a patron category - Create a patron - Add 3 items - check the 3 items out to the patron - check the 3 items in How to use it? $ wget https://selenium-release.storage.googleapis.com/2.53/selenium-server-standalone-2.53.0.jar $ vim /etc/apt/sources.list.d/firefox.list deb http://packages.linuxmint.com debian import $ apt-get update $ apt-get install firefox $ sudo apt-get install xvfb $ SELENIUM_PATH=/home/koha/tools/selenium-server-standalone-2.53.0.jar $ Xvfb :1 -screen 0 1024x768x24 2>&1 >/dev/null & $ DISPLAY=:1 java -jar $SELENIUM_PATH perl t/db_dependent/selenium/basic_workflow.t Signed-off-by: Chris Cormack Note the pages have changed so the tests will not all pass. Also you need Selenium::Remote::Driver installed and staffClientBaseURL must be set I will change the tests in a follow up patch. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Brendan Gallagher commit 73ace7513b18c9b8b2d5b594614d5c251d06d1f2 Author: Jonathan Druart Date: Tue Feb 10 16:07:16 2015 +0100 Bug 13691: Remove existing selenium scripts They are not usable. Signed-off-by: Chris Cormack Signed-off-by: Tomas Cohen Arazi Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: selenium/KohaTests | 18 --- selenium/Members/AddMember | 72 ----------- selenium/Members/DeletMember | 32 ----- selenium/Members/SearchMember | 67 ----------- selenium/Members/filter_members | 82 ------------- selenium/PERL/Members/AddMember.pl | 24 ---- selenium/PERL/Members/FilterMembers.pl | 30 ----- selenium/PERL/Members/Searchmember.pl | 25 ---- t/db_dependent/selenium/basic_workflow.t | 190 ++++++++++++++++++++++++++++++ 9 files changed, 190 insertions(+), 350 deletions(-) delete mode 100644 selenium/KohaTests delete mode 100644 selenium/Members/AddMember delete mode 100644 selenium/Members/DeletMember delete mode 100644 selenium/Members/SearchMember delete mode 100644 selenium/Members/filter_members delete mode 100644 selenium/PERL/Members/AddMember.pl delete mode 100644 selenium/PERL/Members/FilterMembers.pl delete mode 100644 selenium/PERL/Members/Searchmember.pl create mode 100644 t/db_dependent/selenium/basic_workflow.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 11 23:29:08 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 11 Jul 2016 21:29:08 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-322-g62f4e6b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 62f4e6bed2b74f1bc66a8aa0a32ba80263ae30f8 (commit) via 2b39cc7fffbc0376190bf4b53fd70085dc5df03f (commit) from fa70b5b4c705aa671e1ec57a3509f6372917f808 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 62f4e6bed2b74f1bc66a8aa0a32ba80263ae30f8 Author: Jacek Ablewicz Date: Tue Apr 26 09:04:17 2016 +0200 Bug 16166: Fix t/Cache.t tests Thou shalt not forget to include changes made in the t/Cache.t in the patch set. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Jesse Weaver commit 2b39cc7fffbc0376190bf4b53fd70085dc5df03f Author: Jacek Ablewicz Date: Tue Apr 26 08:43:12 2016 +0200 Bug 16166: Improve L1 cache performance and safety Bug 16044 introduced two-level caching mechanism to Koha::Cache. By default, get_from_cache() returns a deep copy of the data structures stored in L1 cache (aka "safe mode"). For extremely big and/or complex data structures (like MARC framework hash-of-hashes-of-hashes returned by GetMarcStructure() ), deep-cloning is currently sub-optimal; this patch addresses that particular issue. It also provides an ability to intermix "safe" and "unsafe" cache feches, in such way that they don't interfere with each other (i.e., eliminating the risk involved with "unsafe" calls possibly compromising further "safe" calls). Test plan: 1) apply patch 2) flush L2 cache if necessary (restart memcached daemon) 3) profile GetMarcStructure() calls before / after patch, e.g. by running some script which calls it often (like catalogue search w/ XSLT processing turned on, etc.) - GetMarcStructure() should be faster than before, in all possible circumstances (eg. 18 msec per call -> 10 msec p/call) 4) after testing, before returning to the master branch, flush L2 cache again (restart memcached daemon) - otherwise all system preferences returned from L2 cache would be suffixed with '-CF0' Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Jesse Weaver ----------------------------------------------------------------------- Summary of changes: Koha/Cache.pm | 77 +++++++++++++++++++++++++++++++++++---------------------- t/Cache.t | 15 +++++------ 2 files changed, 53 insertions(+), 39 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 15 16:02:28 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 Jul 2016 14:02:28 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-323-gf8eb5e7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f8eb5e7f0e4afea791d17692561fb10162aee78c (commit) from 62f4e6bed2b74f1bc66a8aa0a32ba80263ae30f8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f8eb5e7f0e4afea791d17692561fb10162aee78c Author: Kyle M Hall Date: Wed Jul 13 15:41:30 2016 +0000 Bug 16917 - Error when importing patrons, Column 'checkprevcheckout' cannot be null Error: DBIx::Class::Storage::DBI::_dbh_execute(): Column 'checkprevcheckout' cannot be null at C4/Members.pm line 697 Test Plan: 1) Attempt to import a patron via csv 2) Note the error 3) Apply this patch 4) Repeat the import 5) No error! NOTE: Given that all the other tests ran (comment #2), except those in comment #3, I resorted to following the test plan above using the attachment provided in comment #5. I believe the issues in comment #3 constitute other bugs which need fixing and are unrelated this bug. Applying the patch does resolve the error triggered, and the code is good. Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Members.pm | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 15 16:03:16 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 Jul 2016 14:03:16 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-324-gbfac6c29 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via bfac6c29e4d3ea16919bb1f7319f50b23e8faad2 (commit) from f8eb5e7f0e4afea791d17692561fb10162aee78c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bfac6c29e4d3ea16919bb1f7319f50b23e8faad2 Author: Mark Tompsett Date: Wed Jul 13 22:46:17 2016 -0400 Bug 16920: sysprefs.sql - missing comma for MaxOpenSuggestions TEST PLAN --------- 1) back up DB 2) drop database koha_library; 3) create database koha_library; 4) run web browser install, choose ALL defaults -- notice the SQL syntax warning. 5) apply patch 6) repeat steps 2-4 -- notice SQL syntax warning is gone. 7) run koha qa test tools 8) restore db Signed-off-by: Chris Cormack Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/sysprefs.sql | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 15 16:04:43 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 Jul 2016 14:04:43 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-326-g199c00c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 199c00c7ba4edb78bcf0d022cfedc4e891316071 (commit) via de2df0dfe85bc8ac33375ad5b436ac247c3875d6 (commit) from bfac6c29e4d3ea16919bb1f7319f50b23e8faad2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 199c00c7ba4edb78bcf0d022cfedc4e891316071 Author: Jonathan Druart Date: Thu Jun 9 16:42:27 2016 +0100 Bug 2735: CSS changes Signed-off-by: Nicole C Engard Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall commit de2df0dfe85bc8ac33375ad5b436ac247c3875d6 Author: Jonathan Druart Date: Thu Jun 9 16:39:56 2016 +0100 Bug 2735: Fix authority search pagination at the OPAC The authority search pagination displays only 15 pages, even when there are more. To fix that, this patch mimic the authorities-home.pl intranet script to manage the pagination. Test plan: Without this patch, do some authority search and click on different pages. Apply this patch, redo the same search and make sure the same records are displayed (i.e. confirm that the pagination still works as before). Signed-off-by: Nicole C Engard Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +- .../en/modules/opac-authoritiessearchresultlist.tt | 36 ++------ koha-tmpl/opac-tmpl/bootstrap/less/opac.less | 4 +- opac/opac-authorities-home.pl | 93 ++++++++------------ 4 files changed, 46 insertions(+), 89 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 15 16:06:01 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 Jul 2016 14:06:01 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-329-ge75d9be Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e75d9befca13c2f74706e5eb7874a27bdc1928f1 (commit) via c765d105096ac8c0bc5afd51eb212db54c7901e0 (commit) via b416ac16b5c67d902444041882c31a99e0525fa0 (commit) from 199c00c7ba4edb78bcf0d022cfedc4e891316071 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e75d9befca13c2f74706e5eb7874a27bdc1928f1 Author: Jonathan Druart Date: Tue Jun 21 12:31:40 2016 +0100 Bug 12178: Fix tests not to depend on dateformat syspref Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall commit c765d105096ac8c0bc5afd51eb212db54c7901e0 Author: Florent Mara Date: Tue May 24 14:10:32 2016 +1200 Bug 12178: Tests for changes to claimed serial status Signed-off-by: Jonathan Druart Amended patch: Remove trailing spaces Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall commit b416ac16b5c67d902444041882c31a99e0525fa0 Author: Jonathan Druart Date: Tue Apr 28 17:00:44 2015 +0200 Bug 12178: Update serial status to "claimed" when exporting to CSV On the same way as late issues, the serial status should be updated to 'claimed' when the issues as exported as csv. QA note: The updateClaim and UpdateClaimdateIssues subroutine did almost the same thing, I kick the second on off to centralize the code. Test plan: 1/ Export some late issues as CSV (serials/claims.pl). 2/ Refresh the page (the export does not do it) and confirm that the status, the claim date and the claim count have been updated. 3/ Select some others issues, select a notice and send the notification. Confirm that the behavior is the same. Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Serials.pm | 47 +++++++++----------------------------- serials/claims.pl | 2 +- t/db_dependent/Serials.t | 48 +++++++++++++++++++++++++++++++++++++-- t/db_dependent/Serials/Claims.t | 14 +++++++++++- 4 files changed, 71 insertions(+), 40 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 15 16:09:32 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 Jul 2016 14:09:32 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-336-ge465d1a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e465d1aa4b16d7392950b2b682f99eb0c58c1ffd (commit) via 64fe6e350074db48cf337dcf1794b40a58d7e606 (commit) via 4ad4ab6396af26bed9dceb442adf4aad6687f362 (commit) via eb8666357ce72e910569843f8acce674a332f4b0 (commit) via b27da7e0ce25c806612743100609255ace48257c (commit) via 2b725b6728ea4156562aa6225b2323861f616885 (commit) via 4f0fd3db556652f961710c64b9806512a491a7d3 (commit) from e75d9befca13c2f74706e5eb7874a27bdc1928f1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e465d1aa4b16d7392950b2b682f99eb0c58c1ffd Author: Marcel de Rooy Date: Wed Jul 13 11:59:28 2016 +0200 Bug 15006: [QA Follow-up] Only handle login requests in raw_transport Although mainly hypothetical, it would still be possible to get response from the server for an acs resend request. (This exception is allowed in MsgType::handle.) I also noticed that the response may well be a message from an older session still. This patch just removes that exception by only passing login requests to sub handle in the raw_transport loop. Test plan: [1] Verify normal login procedure for raw. [2] Check a few acs resend requests in raw. They should terminate without a response. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 64fe6e350074db48cf337dcf1794b40a58d7e606 Author: Marcel de Rooy Date: Tue Jul 12 15:48:34 2016 +0200 Bug 15006: [QA Follow-up] Satisfy qa tools with one tab less Signed-off-by: Marcel de Rooy Signed-off-by: Srdjan Signed-off-by: Kyle M Hall commit 4ad4ab6396af26bed9dceb442adf4aad6687f362 Author: Colin Campbell Date: Wed Jul 6 15:25:21 2016 +0100 Bug 15006 Correct indentation of EXPORTs in Sip.pm Removed tabs and used spaces consistently Used 'use base' to remove unnecessary BEGIN sub and explicit setting of ISA at application level Signed-off-by: Srdjan Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit eb8666357ce72e910569843f8acce674a332f4b0 Author: Marcel de Rooy Date: Wed Jul 6 15:14:45 2016 +0100 Bug 15006: Centralize timeout logic and allow zero client timeout Moving timeout logic to one routine (with unit test). This further implements two suggestions from Kyle and Larry: [1] You could use a client_timeout of 0 to specify no timeout at all. [2] Have the client_timeout default to the timeout if not defined. Test plan: [1] Run t/db_dependent/SIP/SIPServer.t. [2] Test login timeout for raw and telnet. [3] Check ACS status message for timeout value. Should match policy timeout from institution. [4] Test client timeout (zero and non-zero). [5] Remove client timeout. Test fallback to service. [6] Remove service timeout too. Test fallback to 30 at login. Signed-off-by: Srdjan Signed-off-by: Marcel de Rooy Amended to incorporate Srdjan's suggestion to move get_timeout to SIPServer.pm; this requires some additional mocking in the unit test. And even makes the test db dependent, as documented. Signed-off-by: Kyle M Hall commit b27da7e0ce25c806612743100609255ace48257c Author: Colin Campbell Date: Fri Nov 20 12:12:48 2015 +0000 Bug 15006: Introduce client_timeout in SIPconfig.xml Most selfchecks have persistent connections and send a periodic status request at intervals (approx every 5mins appears the norm) The timeout was dropping connections by default every 30secs which for the client appears as a very flakey network. This patch adds a separate parameter client_timeout that can be used if you do want to force a disconnect if the client sends no requests for a period. The sample config sets it to 600, but you can also define a 0 value meaning no timeout. If the parameter is not defined, it will fallback to service timeout. Signed-off-by: Marcel de Rooy Restored this patch from Colin in order to separate it from the get_timeout patch. Adjusted the commit message slightly. The original value of 600 from Colin's earlier patch may give less discussion than setting to 0 (no timeout) in a later proposal. Signed-off-by: Srdjan Signed-off-by: Kyle M Hall commit 2b725b6728ea4156562aa6225b2323861f616885 Author: Colin Campbell Date: Tue Jul 5 10:36:31 2016 +0100 Bug 15006 Remove tabs from sip_protocol_loop Remove the tabs causing inconsistent indentation of sip_protocol_loop and replace with spaces Reimplements the renaining parts of Marcel de Rooy's original QA patch No logic changes in this patch - layout only Signed-off-by: Srdjan Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 4f0fd3db556652f961710c64b9806512a491a7d3 Author: Colin Campbell Date: Mon Jul 4 16:13:16 2016 +0100 Bug 15006 Drop raw connection if login fails raw_connection was not behaving correctly if an invalid string was passed or a login failed. It was not checking that the login succeeded ( it checked that account existed not that it contained data and it existed even if login failed) and so failed logins instead of aborting immediately fell through into the sip_protocol_loop, forcing that to timeout invalid connections. It now checks that account has id set and returns if not. The timeout alarm is now set on the while loop, in normal running this should not be triggered as the socket is opened and the first data should be a login message and the while loop should only iterate once, but lets not go into an infinite loop due to unforeseen circumstances. I have reindented the routine as the flow was not clear (the while was not indented at all. Also if using Net::Server::PreFork when a new connection comes in you may be handed the the successful login parameters from a preceding call. Because of this you could successfully transmit transactions and Koha would carry them out without having received a valid login ( and possibly with the wrong account details!) We now delete any existing account for new connections. NB: This patch requires that the patch for bug 13807 has been applied Signed-off-by: Srdjan Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/SIP/SIPServer.pm | 108 +++++++++++++++++++++++++++++++--------- C4/SIP/Sip.pm | 28 +++++------ C4/SIP/Sip/MsgType.pm | 7 +-- etc/SIPconfig.xml | 8 +++ t/{SIP_Sip.t => SIP/Sip.t} | 0 t/db_dependent/SIP/SIPServer.t | 78 +++++++++++++++++++++++++++++ 6 files changed, 183 insertions(+), 46 deletions(-) rename t/{SIP_Sip.t => SIP/Sip.t} (100%) create mode 100755 t/db_dependent/SIP/SIPServer.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 15 16:10:55 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 Jul 2016 14:10:55 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-338-g5a1f3ac Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 5a1f3acaabf235733a3e7a98d16d0395df1980b8 (commit) via c0d420f42a293e68228bbe7fa95545a08fd2c964 (commit) from e465d1aa4b16d7392950b2b682f99eb0c58c1ffd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5a1f3acaabf235733a3e7a98d16d0395df1980b8 Author: Marc V?ron Date: Wed Jul 6 00:27:30 2016 +0200 Bug 16682: (followup) Fix display if Batch patron modification tool does not get any patrons Format message as proposed in comment #8 Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit c0d420f42a293e68228bbe7fa95545a08fd2c964 Author: Marc V?ron Date: Tue Jul 5 02:10:55 2016 +0200 Bug 16682: Fix display if Batch patron modification tool does not get any patrons To reproduce: - Go to Tools->Batch patron modification - Submit without filling any of "Use a file", "Or use a patron list", "Or list card numbers..." or use a patron lists with zero members Result: Screen without any information To test: - Apply patch - Repeat steps above - Verify that you get a nice message - Verify that the tool works as before - with invalid card numbers only - with valid and invalid card numbers - with valid card numbers only Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/tools/modborrowers.tt | 11 +++++++++++ 1 file changed, 11 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 15 16:11:47 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 Jul 2016 14:11:47 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-339-ga353fe5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a353fe5d988d64f52d0a530b1d507f8f8eab2a5a (commit) from 5a1f3acaabf235733a3e7a98d16d0395df1980b8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a353fe5d988d64f52d0a530b1d507f8f8eab2a5a Author: Marc V?ron Date: Mon Jul 4 14:30:24 2016 +0200 Bug 16810: Fines note not showing on checkout Fines did not show on patron checkout and detail pages unless amout was greater than syspref NoIssueCharges. This patch fixes the logic in koha-tmpl/intranet-tmpl/prog/en/includes/blocked-fines.inc Additionally, it changes links to buttons and makes some small text changes to ease translation. To test: - Apply patch - Display checkout or detail page and verify proper display for a patron who has - no fines (no message) - fines not exceeding syspref NoissueCharges (message) - fines exceeding syspref NoIssueCharges (message) Signed-off-by: Hector Castro Works as advertised Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../prog/en/includes/blocked-fines.inc | 21 ++++++-------------- 1 file changed, 6 insertions(+), 15 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 15 16:56:53 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 Jul 2016 14:56:53 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-340-g58138e9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 58138e93d709b953f00cc126318d2cc4a9e102f4 (commit) from a353fe5d988d64f52d0a530b1d507f8f8eab2a5a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 58138e93d709b953f00cc126318d2cc4a9e102f4 Author: Jonathan Druart Date: Mon Jul 4 13:22:18 2016 +0100 Bug 16845: Remove unused C4::Members::ModPrivacy This subroutine is no longer in used and can be removed safely Test plan: git grep ModPrivacy should not return any occurrences. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Members.pm | 21 --------------------- 1 file changed, 21 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 15 16:58:14 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 Jul 2016 14:58:14 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-341-g06fa67d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 06fa67d75a10adcc5ac8cbefad498f0e0d254b03 (commit) from 58138e93d709b953f00cc126318d2cc4a9e102f4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 06fa67d75a10adcc5ac8cbefad498f0e0d254b03 Author: Jonathan Druart Date: Sat Jul 9 15:56:32 2016 +0100 Bug 16890: Make TestBuilder generate date for date columns (and not datetime) TestBuilder should not generate datetime for date columns, but only for datetime and timestamp columns. Test plan: Make sure the change in t/db_dependent/TestBuilder.t are consistent. Before this patch, 1 of the 2 tests should fail. After this patch applied, they both should pass. Signed-off-by: Srdjan Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: t/db_dependent/TestBuilder.t | 13 ++++++++++++- t/lib/TestBuilder.pm | 9 +++++++-- 2 files changed, 19 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 15 16:59:27 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 Jul 2016 14:59:27 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-342-gb51f2ba Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b51f2baa7c1035657594f90d17c7c9eeedf4ea84 (commit) from 06fa67d75a10adcc5ac8cbefad498f0e0d254b03 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b51f2baa7c1035657594f90d17c7c9eeedf4ea84 Author: Marc V?ron Date: Tue Jul 5 19:23:59 2016 +0200 Bug 14138: Patroncard: Warn user if PDF creation fails Change patroncards/create-pdf.pl to redirect with an error message instead of writing an invalid pdf that does not open in pdf viewer. To test: - Apply patch - Test that pdf creator behaves as before (with valid batches and patron lists) - While testing, copy pdf link address from window with title 'Click the following link(s) to download...' - Open another staff client browser tab - Paste link to browser address field, change batch id rsp. patron list id to an invalid value and submit - The window should redirect to cgi-bin/koha/patroncards/create-pdf.pl and display an error message - Bonus test 1: Create an empty patron list and test patron card creation. You should get an error message as appropriate. - Bonus test 2: Use a link with params like the following: ...create-pdf.pl?borrower_number=61&template_id=2&layout_id=1&start_card=1 Verify that you can create a pdf with a valid borrower_number and that you get the error message with an invalid borrower number Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../prog/en/includes/patroncards-errors.inc | 13 +++++- .../prog/en/modules/patroncards/manage.tt | 1 + patroncards/create-pdf.pl | 45 +++++++++++++++----- 3 files changed, 47 insertions(+), 12 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 15 17:00:23 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 Jul 2016 15:00:23 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-343-ge9b6a5e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e9b6a5e31e1bc225a6e620dcefbd9545bb6d98bf (commit) from b51f2baa7c1035657594f90d17c7c9eeedf4ea84 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e9b6a5e31e1bc225a6e620dcefbd9545bb6d98bf Author: Jonathan Druart Date: Mon Jun 27 13:32:31 2016 +0100 Bug 16813: Allow empty string for OPACBaseURL The pref is prefixed by 'http://', but it should not when the pref is set to an empty string. This will fix the bug raised on bug 14790 comment 14. Test plan: Empty OPACBaseURL and confirm that it's save as it in DB Signed-off-by: Hector Castro OPACBaseURL is saved up empty. Prefix http:// is not saved anymore Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Context.pm | 2 +- t/db_dependent/Context.t | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 15 17:01:12 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 Jul 2016 15:01:12 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-344-g24a32e9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 24a32e975c964caa99bc9f8ebe31f7bd53cdd13e (commit) from e9b6a5e31e1bc225a6e620dcefbd9545bb6d98bf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 24a32e975c964caa99bc9f8ebe31f7bd53cdd13e Author: Jonathan Druart Date: Mon Jul 4 12:25:16 2016 +0100 Bug 16844: (follow-up of 15656) Remove export of GetMemberRelatives from C4::Members Bug 15656 removed the C4::Members::GetMemberRelatives subroutine but the module still exports it. Test plan: git grep GetMemberRelatives should not return any results. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Members.pm | 1 - 1 file changed, 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 15 17:02:16 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 Jul 2016 15:02:16 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-346-g93aff1f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 93aff1fe37f7a9142958f11b45cfbcb62d646f62 (commit) via 27a7cdef1a6187fe7814a75e4fc5cee636ed77fa (commit) from 24a32e975c964caa99bc9f8ebe31f7bd53cdd13e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 93aff1fe37f7a9142958f11b45cfbcb62d646f62 Author: Katrin Fischer Date: Mon Jul 11 22:56:11 2016 +0200 Bug 16893 - Missing closing tag disrupts patron checkouts page style Same fix as for the details page: checkouts page is very italic when there is a restriction with a comment on the patron account. Signed-off-by: Kyle M Hall commit 27a7cdef1a6187fe7814a75e4fc5cee636ed77fa Author: Owen Leonard Date: Mon Jul 11 08:51:12 2016 -0400 Bug 16893: Missing closing tag disrupts patron detail page style A missing closing causes the the patron detail page to be in all italics if the patron has a restriction message. This patch corrects it. To test, apply the patch and locate a patron who has a restriction message. The restriction message should be in italics but the rest of the page should display normally. Signed-off-by: Hector Castro Rest of the page displayed normally Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 15 17:03:43 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 Jul 2016 15:03:43 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-347-gfcf2e13 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via fcf2e1325e6cf056b5b7e5e95545adcd322d1b52 (commit) from 93aff1fe37f7a9142958f11b45cfbcb62d646f62 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fcf2e1325e6cf056b5b7e5e95545adcd322d1b52 Author: Fridolin Somers Date: Mon Jul 11 16:31:18 2016 +0200 Bug 16897 - Re-focus on "Add item" in Lists Bug 11325 add solved a focus on "Add item" missing in Lists page. Since revamping of this page, the add item form exists both in page. The one corrected by Bug 11325 is not visible because it checks a bad var allowaddingitem instead of can_add_biblios. This patch removes the first form and corrects the second form. It moves the form at left part of page so that it is always shown (usefull when there are a lot of items). It does not add the list name after "Add item" besause it whould be huggly for long names and because listname already exists in breadscrumbs and on top of the table. It also adds autocomplete="off" on barcode input because there can be problems with a scanning device. Test instructions: 1. Create a list 2. Make sure you have an object with an assigned barcode 3. Go to the list => The barcode entry interface should be at left and has the focus 4. Enter the barcode and press enter (or use a scanner) => The item is added to the list Signed-off-by: Owen Leonard This is a nice improvement, thanks! Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/virtualshelves/shelves.tt | 35 +++++--------------- 1 file changed, 8 insertions(+), 27 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 15 17:04:56 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 Jul 2016 15:04:56 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-348-g6c711e6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6c711e6cda36ab339fc52d63ec1fd99d1f39fe99 (commit) from fcf2e1325e6cf056b5b7e5e95545adcd322d1b52 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6c711e6cda36ab339fc52d63ec1fd99d1f39fe99 Author: Owen Leonard Date: Mon Jul 11 15:03:37 2016 -0400 Bug 16900 - Hold suspend button incorrectly styled in patron holds list This patch updates the style of the suspend/resume button in the list of holds displayed on the checkout page and on the patron detail page. The button is now a Bootstrap-styled button with a Font Awesome icon. To test, apply the patch and locate a patron who has holds. - On the checkout page, view the 'Holds' tab and confirm that there is a correctly-styled 'Suspend' button for each hold. - Verify that the button works correctly and looks correct when a hold has been suspended. Signed-off-by: Arslan Farooq Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/js/holds.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 15 17:07:12 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 Jul 2016 15:07:12 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-349-gdc1ff4e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via dc1ff4efff70cabfad5b8e2e69e7a9448cc61e16 (commit) from 6c711e6cda36ab339fc52d63ec1fd99d1f39fe99 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit dc1ff4efff70cabfad5b8e2e69e7a9448cc61e16 Author: Marc V?ron Date: Fri Jun 10 10:25:54 2016 +0200 Bug 16621: Translatability: Issues in opac-user.tt (sentence splitting) This patch fixes issues due to sentence splitting in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt Note: This is a string patch. It does not add or change functionallity. To test: - Examine code and verify that the text changes remove sentence splitting and that the changes make sense. - Log in to OPAC and verify that messages look correct - with blocked /debarred user (with and without comment and date) - with user who has to much fines (needs syspref OpacRenewalAllowed and syspref OPACFineNoRenewals) - with user who has his card marked as lost - with user with an account that is about to expire - with user with expired account - with user with uncertain address information (with and without syspref OPACPatronDetails set to Allow) Note: Amended to make patch apply 2016-07-10 mv Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../opac-tmpl/bootstrap/en/modules/opac-user.tt | 34 +++++++++----------- opac/opac-user.pl | 7 ++-- 2 files changed, 18 insertions(+), 23 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 15 17:18:39 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 Jul 2016 15:18:39 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-351-g4f2dba1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 4f2dba105e45446448f250356b5ec1cb74085dfd (commit) via a83d75b6f2d59c3c2ac8d1b549b364fa79f52efe (commit) from dc1ff4efff70cabfad5b8e2e69e7a9448cc61e16 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4f2dba105e45446448f250356b5ec1cb74085dfd Author: Hector Castro Date: Thu Jul 7 09:13:30 2016 -0600 Bug 16701: (follow-up) improve some changes Add missing quote in line 152 Modify title of the page and breadcrumbs section wrong "searchfield" used should be instead "currency.currency" To test -Try to delete the active and used currency, for example, my case USD, look that appear USD' with the initial single quote missing in message Confirm deletion of currency USD' -Notice about the breadcrumbs section appear: Confirm deletion of currency '' Should appear the currency -Try to delete another currency see the pharese look the same -Notice about the title in both cases, there is missing the currency name -Apply follow-up and re-test Sing-off on followup Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall commit a83d75b6f2d59c3c2ac8d1b549b364fa79f52efe Author: Marc V?ron Date: Tue Jun 21 09:08:06 2016 +0200 Bug 16701: Translatability: Fix problem with isolated ' in currency.tt This patch moves markup into template variables to avoid sentence splitting. To test: - Apply patch - Verify that currency administration works as before (Home > Administration > Currencies & Exchange rates > Currencies) - Examine code changes Signed-off-by: Hector Castro Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 15 17:22:04 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 Jul 2016 15:22:04 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-352-g3fe6abc Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 3fe6abc9d57fc1dc9968af0b25644f4cdb2289e0 (commit) from 4f2dba105e45446448f250356b5ec1cb74085dfd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3fe6abc9d57fc1dc9968af0b25644f4cdb2289e0 Author: Marcel de Rooy Date: Mon Jun 20 14:57:25 2016 +0200 Bug 16777: Correct intranet search alias A long-standing typo in our apache config files: [intranet]/search refers to search.pl (which does not exist) This patch refers it to catalogue/search.pl Test plan: Run an install or copy the change from apache-shared-intranet.conf or koha-httpd.conf to your apache config. Restart Apache and check if http://[your staff client]/search works. Signed-off-by: Owen Leonard Tested by making manual changes according to the patch. Did not test a new installation. Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: debian/templates/apache-shared-intranet.conf | 2 +- etc/koha-httpd.conf | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 15 17:23:11 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 Jul 2016 15:23:11 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-353-gf240a91 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f240a91640234bf0f4e3bf6162c8fe3389db4ec2 (commit) from 3fe6abc9d57fc1dc9968af0b25644f4cdb2289e0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f240a91640234bf0f4e3bf6162c8fe3389db4ec2 Author: Hector Castro Date: Fri Jun 24 15:55:40 2016 -0600 Bug 16812: Revise JS script for z3950_search.tts and remove onclick events Modify JS script to all templates for z3950_search.tt and reduce the redundant code This patch propose: -z3950_auth_search.tt has various onclick events used in links. Also fix: acqui/z3950_search.tt and cataloguing/z3950_search.tt -Trigger onclick events via JQuery .on() -Make a separate .js and .inc file -Reduce the number of line and redundant code -Also add Font Awesome Icons to "Select/Clear all" and "Clear search form" links To test: 1-Apply bug 16600 on top 2-Apply patch 3-Go to Authorities > click New from Z39.50 4-Fill some fields and click in "Clear search form" link 5-Search under "Dalton" or another author that launch too many headings 6-Clic in some heading and notice the dialog open, test: "Preview MARC", ISBD (when showed), "Import" and close the dialog "X". Use the "Import" from table too. 7-Use the "next/previous page" button, change "Go to page" to number in and out of the range presented, also test whit a letter, etc. Go to Cataloging > New from Z39.50/SRU Repeat steps 3 to 6. But this time with bib records. Go to Adquisition > Open or Create a basket and choose to "Add to basket" button. A modal appear, chose the option "Order from external source" Repeat steps 3 to 6. But this thime with bib records. NOTE: The icon trash for "Clear search form" has been selected according with module "Advanced search" there is an icon trash with link "Clear fields" that has the same fuctionality. For some reason the image loading-small.gif does not charge all times when the code is get out of the template. (Fixed with this new patch) DataTable it is specific for each template Sponsored-by: Universidad de El Salvador Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../prog/en/includes/z3950_search.inc | 28 ++++++ .../prog/en/modules/acqui/z3950_search.tt | 63 ++----------- .../en/modules/cataloguing/z3950_auth_search.tt | 78 +++------------- .../prog/en/modules/cataloguing/z3950_search.tt | 77 +++------------ koha-tmpl/intranet-tmpl/prog/js/z3950_search.js | 98 ++++++++++++++++++++ 5 files changed, 158 insertions(+), 186 deletions(-) create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/z3950_search.inc create mode 100644 koha-tmpl/intranet-tmpl/prog/js/z3950_search.js hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 15 20:01:23 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 Jul 2016 18:01:23 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-355-gdba6cfe Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via dba6cfe441a3ee14183287795c0c4293c74b2989 (commit) via ae4195207726fb01cebad0d809addaefffe37975 (commit) from f240a91640234bf0f4e3bf6162c8fe3389db4ec2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit dba6cfe441a3ee14183287795c0c4293c74b2989 Author: Hector Castro Date: Mon Jul 11 08:34:38 2016 -0600 Bug 16888: (follow-up)Add Font Awesome Icons to Members Remove fa-ban according with QA comment 4 Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall commit ae4195207726fb01cebad0d809addaefffe37975 Author: Hector Castro Date: Fri Jul 8 15:52:06 2016 -0600 Bug 16888: Add Font Awesome Icons to Members Add Font Awesome Icons to: - "Select/Clear all" links to pay.tt (Pay fines tab) - "Filter icon" in "filter paid transactions" to Accout tab (boraccount.tt) - "Trash icon" to Remove option in "Manual restrictions" (borrower_debarments.inc) also add "Ban and plus icon" to "Add manual restriction" To test: -Apply patch -Select a patron who has fines -Go to "Fines->Pay fines" tabs and see the icons in "Select/Clear all" -Choose the "Account" tab and sse the icon in "Filter paid transactions" -Select the "Check out" tab and go to "Restrictions" -Add a manual restriction and notice about the two new icons fa-plus and fa-band -See the new button btn-mini and the fa-trash icon -Verify that all works as expected Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/borrower_debarments.inc | 6 +++--- koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt | 6 +++--- koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 15 20:02:18 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 Jul 2016 18:02:18 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-356-gb89a601 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b89a601e5742b3067fa6ed508313acfce4e73e73 (commit) from dba6cfe441a3ee14183287795c0c4293c74b2989 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b89a601e5742b3067fa6ed508313acfce4e73e73 Author: Nick Clemens Date: Fri Jun 3 14:49:25 2016 -0400 Bug 15853 - Add author and link columns to opac course reserves table To test: 1 - Add some course reserves 2 - View the table in staff and opac, there is no column for author or link 3 - Apply patch 4 - You shoudl see these columns 5 - Link should contain item uri if present, fallback to title 856$u, then be blank if niether Sponsored by: Southeastern Wisconsin Information Technology Exchange, Inc (SWITCH) (http://caspian.switchinc.org/) Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Might be good to add this table to the column visibility tool if you plan to add more columns. Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/course_reserves/course-details.tt | 10 ++++++++++ .../opac-tmpl/bootstrap/en/modules/opac-course-details.tt | 9 +++++++++ 2 files changed, 19 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 15 20:03:29 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 Jul 2016 18:03:29 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-357-gb7c61a5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b7c61a5d128cc3580ea3ee67bc29e02571923dd3 (commit) from b89a601e5742b3067fa6ed508313acfce4e73e73 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b7c61a5d128cc3580ea3ee67bc29e02571923dd3 Author: Aleisha Date: Tue May 17 04:46:31 2016 +0000 Bug 16531: Circ overdue report is showing an empty table if no overdues EDIT: Comment 2 EDIT2: using noreport variable (Comment 5) To test: 1) Ensure you have no items overdue 2) Go to Circ -> Circulation reports -> Overdues 3) Notice empty table, '0 items overdue' heading 4) Ensure syspref FilterBeforeOverdueReport is set to 'Don't require' 5) Apply patch and refresh page 6) Notice empty table is no longer showing and page says "There are no overdues" 7) Apply a filter to search 8) Page now says "There are no overdues matching your search" with a link to reset filter. 9) Click Reset filter -> confirm any filters you applied are cleared. 10) Set FilterBeforeOverdueReport to 'Require' and refresh overdue report 11) Page should say "Please choose one or more filters to proceed" 12) Check out an item to a member, ensure due date is a date that has passed (i.e. yesterday) 13) Refresh overdue report page 14) Page should still say "Please choose one or more filters to proceed" 15) Set FilterBeforeOverdueReport to 'Don't require' 16) Confirm table now shows correctly with '1 items overdue' heading etc. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/circ/overdue.tt | 86 +++++++++++--------- 1 file changed, 48 insertions(+), 38 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 15 20:04:25 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 Jul 2016 18:04:25 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-358-g65b2da0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 65b2da08c9edaa6d2afe83ca7a5b72000128ecbe (commit) from b7c61a5d128cc3580ea3ee67bc29e02571923dd3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 65b2da08c9edaa6d2afe83ca7a5b72000128ecbe Author: Owen Leonard Date: Tue May 17 11:18:14 2016 -0400 Bug 16538: Improve the style of progress bars This patch updates the style of progress bars to make them a little nicer. Progress bars in the staff client are not built in a consisten way. Some have been updated to use the element and some have not. This patch improves some styling common to both kinds. Other changes: - Redundant in-page CSS has been removed from many pages. - An invalid "min" attribute has been removed from several instances of . - Corrected capitalization. - Fixed incorrectly quoted attributes. - Added missing form "action" attributes. To test, clear your browser cache if necessary. Apply the patch and test uploads on the following pages: - Circulation -> Offline circulation file upload - Tools -> Batch item modification - Tools -> Batch record modification - Tools -> Stage MARC records for import - Tools -> Manage staged MARC records - Tools -> Upload local cover image - Tools -> Upload In all cases, progress bars should look improved and work correctly. Test Tools -> Batch item deletion. Unused background job handling markup has been removed. Deletion processing should work correctly. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 24 +++++++++++++++++++- .../prog/en/modules/offline_circ/process_koc.tt | 6 +---- .../prog/en/modules/tools/batchMod-del.tt | 13 ++++------- .../prog/en/modules/tools/batchMod-edit.tt | 2 +- .../en/modules/tools/batch_record_modification.tt | 2 +- .../prog/en/modules/tools/manage-marc-import.tt | 6 ++--- .../prog/en/modules/tools/stage-marc-import.tt | 8 +++---- .../prog/en/modules/tools/upload-images.tt | 16 ++++--------- .../intranet-tmpl/prog/en/modules/tools/upload.tt | 2 +- 9 files changed, 41 insertions(+), 38 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 15 20:05:39 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 Jul 2016 18:05:39 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-359-g81a9e7c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 81a9e7c88ee44fdfdd2f4f19b52150ce7176b1b7 (commit) from 65b2da08c9edaa6d2afe83ca7a5b72000128ecbe (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 81a9e7c88ee44fdfdd2f4f19b52150ce7176b1b7 Author: Nick Clemens Date: Thu Jul 14 11:45:54 2016 -0400 Bug 16681 - Allow update of opacnote via batch patron modification tool To test: 1 - Select a batch of patrons (via list, saved file, and cardnumber entry) 2 - Verify you cannot edit 'opacnotes' field, nor can you see 'borrowernotes' field in table, though you can edit it 3 - Verify editing works as expected 4 - Apply patch 5 - Select a batch via each method as above 6 - Note both note columns display in table 7 - Note that you can edit or clear the opacnotes field as expected 8 - Verify other feautres work as previously Sponsored by: Lancaster Theological Seminary (https://lancasterseminary.edu/) Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt | 6 ++++++ tools/modborrowers.pl | 8 +++++++- 2 files changed, 13 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 15 20:06:51 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 Jul 2016 18:06:51 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-360-ge1e3889 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e1e38896bb6a6cb5bcc9fd4b6fc129f143d7406a (commit) from 81a9e7c88ee44fdfdd2f4f19b52150ce7176b1b7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e1e38896bb6a6cb5bcc9fd4b6fc129f143d7406a Author: Jonathan Druart Date: Mon Jul 4 11:29:16 2016 +0100 Bug 16849: Move IsDebarred to Koha::Patron->is_debarred In order to move IsMemberBlocked to Koha::Patron it makes sense to move the code from Koha::Patron::Debarments::IsDebarred to Koha::Patron->is_debarred. Test plan: 1/ Add a restriction to a patron 2/ make sure he is not able to checkout items any more 3/ Make sure he cannot get a discharge 4/ Put a hold and make sure you get "Patron has restrictions" Signed-off-by: Marc V?ron Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 7 ++++--- C4/Members.pm | 4 ++-- Koha/Patron.pm | 20 ++++++++++++++++++++ Koha/Patron/Debarments.pm | 23 ----------------------- Koha/Patron/Discharge.pm | 4 ++-- Koha/Template/Plugin/Borrowers.pm | 4 ++-- circ/circulation.pl | 4 ++-- members/moremember.pl | 4 ++-- opac/opac-reserve.pl | 4 ++-- opac/opac-user.pl | 3 +-- reserve/request.pl | 4 ++-- t/db_dependent/Patron/Borrower_Debarments.t | 7 ++++--- t/db_dependent/Patron/Borrower_Discharge.t | 4 ++-- 13 files changed, 45 insertions(+), 47 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 15 20:07:37 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 Jul 2016 18:07:37 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-361-gafc008b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via afc008b2fa8cf5b409407b4d46585800467b39d3 (commit) from e1e38896bb6a6cb5bcc9fd4b6fc129f143d7406a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit afc008b2fa8cf5b409407b4d46585800467b39d3 Author: Jonathan Druart Date: Mon Jul 4 14:00:58 2016 +0100 Bug 16853: Move changepassword to Koha::Patron->update_password This patch moves the code from C4::Members::changepassword to Koha::Patron->update_password Test plan: Change your password at the OPAC and the staff interface This should work as before Signed-off-by: Marc V?ron Signed-off-by: Tomas Cohen Arazi I rebased this on top of 16849 because they were conflicting. Tests pass, code looks good (as usual) and I checked both OPAC and staff password change work as expected. Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Auth_with_ldap.pm | 5 +++-- C4/Members.pm | 29 ----------------------------- Koha/Patron.pm | 20 ++++++++++++++++++++ members/member-password.pl | 2 +- opac/opac-password-recovery.pl | 4 ++-- t/db_dependent/Auth.t | 3 ++- t/db_dependent/Koha/Patrons.t | 31 ++++++++++++++++++++++++++++++- 7 files changed, 58 insertions(+), 36 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 15 20:08:51 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 Jul 2016 18:08:51 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-362-g59d8f3f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 59d8f3f8617070ec29159ee3c2e0400e9214e4d4 (commit) from afc008b2fa8cf5b409407b4d46585800467b39d3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 59d8f3f8617070ec29159ee3c2e0400e9214e4d4 Author: Aleisha Date: Thu Jul 7 23:40:29 2016 +0000 Bug 16876: Remove Full Heading column from OPAC Auth search results To test: 1) Go to Authority Search and do a search 2) Notice that there is a Full Heading column that has 'View full heading' links. These take up a lot of space and don't mean a lot to the user 3) Apply patch and refresh 4) Notice that the the Full Heading column is gone and there is now a Details column next to the authorities. Confirm the link takes you to the expected authority detail page. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../bootstrap/en/modules/opac-authoritiessearchresultlist.tt | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 15 20:11:13 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 Jul 2016 18:11:13 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-366-gdc78583 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via dc78583de113bb9d24e29c2ca1c7d4033951fd59 (commit) via e6aa7d65dab9bfbe2dc616e3a1180f647888ceff (commit) via c97e04e8e79261a5dc2ac78f92a5b331ad6a8b30 (commit) via 5eba0ab027b7cb7c7bc9f3973c0700d4d64e5b12 (commit) from 59d8f3f8617070ec29159ee3c2e0400e9214e4d4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit dc78583de113bb9d24e29c2ca1c7d4033951fd59 Author: Jonathan Druart Date: Sat Jul 9 14:37:46 2016 +0100 Bug 16889: Remove C4::Items::biblioitems_columns and use Koha::Biblioitems->columns instead Test plan: Add new rule to the "Automatic item modifications by age" tools (tools/automatic_item_modification_by_age.pl) and make sure the columns of the biblioitems table are correctly displayed in the 'Conditions' dropdown list. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall commit e6aa7d65dab9bfbe2dc616e3a1180f647888ceff Author: Jonathan Druart Date: Sat Jul 9 14:35:02 2016 +0100 Bug 16889: Remove C4::Items::columns and use Koha::Items->columns instead Test plan: Add new rule to the "Automatic item modifications by age" tools (tools/automatic_item_modification_by_age.pl) and make sure the columns of the items table are correctly displayed. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall commit c97e04e8e79261a5dc2ac78f92a5b331ad6a8b30 Author: Jonathan Druart Date: Sat Jul 9 14:35:08 2016 +0100 Bug 16889: Remove C4::Members::columns and use Koha::Patrons->columns instead Test plan: Import some patrons (tools/import_borrowers.pl) and make sure it imports the patrons correctly. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall commit 5eba0ab027b7cb7c7bc9f3973c0700d4d64e5b12 Author: Jonathan Druart Date: Sat Jul 9 14:32:40 2016 +0100 Bug 16889: Add Koha::Objects->columns Currently we have 3 subroutines to retrieve the columns of tables: C4::Members::columns, C4::Items::columns and C4::Items::biblioitems_columns. It is easier to have a Koha::Objects->columns method to provide the different classes to retrieve their related column names. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Items.pm | 35 +++------------------------ C4/Members.pm | 35 --------------------------- Koha/Objects.pm | 15 ++++++++++++ t/db_dependent/Koha/Objects.t | 7 +++++- t/db_dependent/Members/columns.t | 24 ------------------ tools/automatic_item_modification_by_age.pl | 7 ++++-- tools/import_borrowers.pl | 3 ++- 7 files changed, 32 insertions(+), 94 deletions(-) delete mode 100644 t/db_dependent/Members/columns.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 15 20:13:14 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 Jul 2016 18:13:14 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-367-g1c61729 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 1c61729e840655bfea7123d0c826a0cffa9bd1bc (commit) from dc78583de113bb9d24e29c2ca1c7d4033951fd59 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1c61729e840655bfea7123d0c826a0cffa9bd1bc Author: Jonathan Druart Date: Mon Jul 11 23:07:34 2016 +0100 Bug 16909: Koha::Patrons - Remove checkuniquemember C4::Members::checkuniquemember was not really nicely written, was only used once and was not covered by tests. I think it does not make sense to keep such complexity and have this code in the subroutine/method. Looking at this patch it seems that what this subroutine did can be done easily in the pl script in few lines. Test plan: 1/ Create 2 organisations with the same "surname": you should get a warning. 2/ Create 2 patrons (non-organisation) with the same surname/firstname/date of birth, you should get a warning Signed-off-by: Marc V?ron Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Members.pm | 39 --------------------------------------- members/memberentry.pl | 22 +++++++++------------- 2 files changed, 9 insertions(+), 52 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 15 20:16:45 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 Jul 2016 18:16:45 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-368-g358010a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 358010afa525c26067ef69a8077d95ab5fc016d2 (commit) from 1c61729e840655bfea7123d0c826a0cffa9bd1bc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 358010afa525c26067ef69a8077d95ab5fc016d2 Author: Jonathan Druart Date: Tue Jul 12 08:37:33 2016 +0100 Bug 16913: Koha::Patrons - Remove GetBorrowersNamesAndLatestIssue This subroutine has been added by commit 5904681faca77c87ff8071414d66e123a2d3baa9 Date: Wed Mar 19 10:11:12 2008 -0500 CleanBorrowers fixing. but has never been used. It can be removed safely. Test plan: git grep GetBorrowersNamesAndLatestIssue should not return any results. Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Members.pm | 26 -------------------------- 1 file changed, 26 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 22 19:05:21 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 22 Jul 2016 17:05:21 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-369-gd7754b7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d7754b70a21d0cfef933a54e24f212ed04e3a0e5 (commit) from 358010afa525c26067ef69a8077d95ab5fc016d2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d7754b70a21d0cfef933a54e24f212ed04e3a0e5 Author: Marc V?ron Date: Thu Jul 14 15:50:22 2016 +0200 Bug 16941: Can not add new patron in staff client To reproduce: - Go to staff client Home > Patron - New patron - Choose a category and fill form, submit Result: Form reloads, patron data are not saved. To test: - Apply patch - Repeat steps above - Verify that patron data are saved and the new patron's detail page displays - Try to enter a duplicate patron (e.g. same surname, firstname and birthday as above) - Verify that a duplicate message appears Signed-off-by: Hector Castro Works as advertised Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: members/memberentry.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 22 19:06:47 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 22 Jul 2016 17:06:47 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-370-gb01aa59 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b01aa596abb91f8679c64e89197fbb2b3d9309cc (commit) from d7754b70a21d0cfef933a54e24f212ed04e3a0e5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b01aa596abb91f8679c64e89197fbb2b3d9309cc Author: Jesse Weaver Date: Wed Jul 20 16:51:45 2016 -0600 Bug 15974: Rancor: Correctly select existing authorized value Test plan: 1) Open up a record in Rancor with an itemtype besides the first in the list ('BK' in the sample itemtypes). 2) It will show "Book" instead of the correct itemtype. 3) Apply patch, reload the page. 4) The correct itemtype should now show. NOTE: The scope is only 942$c. This corrects that. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 22 19:08:09 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 22 Jul 2016 17:08:09 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-371-g52ac9a1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 52ac9a1ca3990102c3c635e3d9af06aae29f73e1 (commit) from b01aa596abb91f8679c64e89197fbb2b3d9309cc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 52ac9a1ca3990102c3c635e3d9af06aae29f73e1 Author: Srdjan Date: Mon Jun 13 15:35:56 2016 +1200 Bug 16716: Replaced wrong GROUP BY with DISTINCT Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Koha.pm | 5 ++--- C4/Members.pm | 6 +++--- 2 files changed, 5 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 22 19:08:56 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 22 Jul 2016 17:08:56 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-372-g87d96b9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 87d96b973aa19e0808070d4b0fdd6485e5c83181 (commit) from 52ac9a1ca3990102c3c635e3d9af06aae29f73e1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 87d96b973aa19e0808070d4b0fdd6485e5c83181 Author: Marc Date: Thu Jul 21 10:22:57 2016 +0200 Bug 16947: Can not modify patron messaging preferences To verify: - Set syspref 'EnhancedMessagingPreferences' to 'Allow' - In staff client, go to a patron's detail page - Edit Patron messaging preferences (using link below table) - Save Result: Form does not save, stays open JavaScript error in intranet-tmpl/prog/js/members.js line 107 TypeError: document.form.password is undefined To test: - Apply patch - Repeat steps above - Verify that messaging preferences save as expected - Verify that other patron modifications work as before NOTE: remember to force reload of the javascripts. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/js/members.js | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 22 19:09:50 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 22 Jul 2016 17:09:50 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-373-g65918b1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 65918b146cd88f38a9d894be8175d049ea70d05f (commit) from 87d96b973aa19e0808070d4b0fdd6485e5c83181 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 65918b146cd88f38a9d894be8175d049ea70d05f Author: Jonathan Druart Date: Fri Jul 22 08:14:27 2016 +0100 Bug 16958: Fix XSS in opac-imageviewer.pl Test plan: Trigger /opac-imageviewer.pl?biblionumber=14&imagenumber=7">