[koha-commits] main Koha release repository branch 3.22.x updated. v3.22.08-9-gf44389f
Git repo owner
gitmaster at git.koha-community.org
Fri Jul 1 08:25:59 CEST 2016
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 3.22.x has been updated
via f44389f3a96f64b43b7cd896a7502550687338d6 (commit)
via 3943b8ca4436762ed5ba9d2b51d6e1a4324792fb (commit)
via f2156852a78d19c248fb8f8a6e42abb9adc04b19 (commit)
via a3557bba8bb71d84aa8e8ce21626c33166450327 (commit)
via ee4607cda1f30cb524b69b4cdb07a08e5a95ac7e (commit)
from 64d29957894e67b0dfbd0599887eac355772a6b9 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit f44389f3a96f64b43b7cd896a7502550687338d6
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jun 14 10:49:41 2016 +0100
Bug 12748: findSerialByStatus has been renamed with findSerialsByStatus
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 30946eff3cda31d0cc97c6c1c4f1e757dbc4c366)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
(cherry picked from commit 9710f07575ea7a56000058a687b1a9e835396b86)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
commit 3943b8ca4436762ed5ba9d2b51d6e1a4324792fb
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jun 14 10:43:14 2016 +0100
Bug 12748: Code tidy
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 44062c07b7703190b46701a3fa31665d998eadfb)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
(cherry picked from commit 69e4c39c213192b46c4e231d40b7a34d676e6b4a)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
commit f2156852a78d19c248fb8f8a6e42abb9adc04b19
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jun 14 10:39:08 2016 +0100
Bug 12748: Remove warning 'masks earlier declaration in same scope'
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 273d5e53289536797281ca5eb323d5c373d9ea41)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
(cherry picked from commit 67b4f25a69b370bb441ed09555ef49e0dd2a1e10)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
commit a3557bba8bb71d84aa8e8ce21626c33166450327
Author: remi <remi.mayrand-provencher at inLibro.com>
Date: Mon Feb 8 15:04:07 2016 -0500
Bug 12748 - Add test for step 7 and 8 and rename findSerialByStatus
https://bugs.koha-community.org/show_bug.cgi?id=12478
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 1bd5a177d0870332a959e9c773aaec80beeba74b)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
(cherry picked from commit 2351db01d32726809e2a00b2c8020e497c2c3931)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
commit ee4607cda1f30cb524b69b4cdb07a08e5a95ac7e
Author: remi <remi.mayrand-provencher at inLibro.com>
Date: Tue Aug 11 11:10:45 2015 -0400
Bug 12748 - Fixes duplicate serials with an "expected" status bug
Added a new sub to Serials.pm to be able to get serials with their statuses.
Now the sub ModSerialStatus checks for other serials with an "expected" status before doing anything.
Also modified Serials.t to be able to test those changes.
Test Plan
1) Apply patch
2) Run ./t/db_dependent/Serials.t
3) Validate that there are no errors
4) Go on "Serial collection information" page for a serial of your choice
5) Click on "Generate next"
6) Change the status of the original serial from "late" to "expected"
7) Change the newly generated serial from "expected" to "delete"
8) Validate that there are no new serials created by instruction 7 and that the serial was deleted
9) Run ./t/db_dependent/Serials.t
With QA Fixes
- Use the constant instead of the code (1 vs EXPECTED)
- Avoid interpolation in query
- use selectall_arrayref instead of fetchall_arrayref
Signed-off-by: Liz Rea <liz at catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 10fd9f5ec0d5faa7b54b0bfaf5a7b8fccd665f0a)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
(cherry picked from commit 695dc4c370d4d170b41447c583c8bfe91b0609e2)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Serials.pm | 24 ++++++++++++++++++++++--
t/db_dependent/Serials.t | 30 +++++++++++++++++++++++++++++-
2 files changed, 51 insertions(+), 3 deletions(-)
mode change 100644 => 100755 t/db_dependent/Serials.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list