[koha-commits] main Koha release repository branch 3.20.x updated. v3.20.12-4-ge3381d0

Fri Jul 8 01:07:24 CEST 2016

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.20.x has been updated
       via  e3381d00710c29e706a797db6c7d844839013c25 (commit)
       via  e7fa1842a4c4d0389b31aa88d04659abe7f90155 (commit)
       via  ec5aa1a7de855345e35be16fd8ef07a9d5307d5e (commit)
       via  6a06f60a1ee928c2b6859b2e14e959dc98df2ce5 (commit)
      from  402c827fb9eca20089ecf328b576785298377545 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit e3381d00710c29e706a797db6c7d844839013c25
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Mon May 23 09:03:23 2016 +0200

    Bug 16502: Replace a few other ok-calls by is-calls

    Trivial changes that speak for themselves..

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    (cherry picked from commit 8204024f1c21102c0649dec70d10398131aab953)
    Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
    (cherry picked from commit 2b7a9479b601e224ff6cdbdcc3162426a4727406)
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
    (cherry picked from commit b58e8642b0d6b98a9e59a6e53d21472cb38a1e42)
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

commit e7fa1842a4c4d0389b31aa88d04659abe7f90155
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Mon May 23 08:58:02 2016 +0200

    Bug 16502: Adjust test for GetPlugins

    The current test assumes that GetPlugins will return the test plugin
    as the first one in the array. This is not correct.
    This patch adjusts the test to a grep.

    Test plan:
    Run the test.
    Bonus: Add additional plugins. Run the test again.

    Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    (cherry picked from commit 6ad5770786c6646ce68ffdfec9080645fc25772e)
    Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
    (cherry picked from commit 64382be0d45ad6d43bb86bda095ca1a3699d1265)
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
    (cherry picked from commit d1dff4c3bde88c2b7c2bb6722ef07d1fcf5f5cce)
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

commit ec5aa1a7de855345e35be16fd8ef07a9d5307d5e
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Mon May 16 19:00:16 2016 +0200

    Bug 16502: Add additional test to Plugins.t

    In order to verify if the delete now really works, we add one test
    in Plugins.t.

    Test plan:
    [1] Run the test.
    [2] Bonus: Comment line 63 in Plugins.t where delete is called.
        Run the test again. It should fail now.

    Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    (cherry picked from commit 959d69fa0107423ed31e20f4a6afb46d1e5c771c)
    Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
    (cherry picked from commit 0632256c1aca919ec055dd5f170ac10d84cc8ec7)
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
    (cherry picked from commit e41863bfa9bf73066d2ec43a3b8e843fa1f0222f)
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

commit 6a06f60a1ee928c2b6859b2e14e959dc98df2ce5
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Mon May 16 17:19:54 2016 +0200

    Bug 16502: Table koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped after running Plugin.t

    If you run Plugin.t, the above table will still be present (when you
    did not enable UseKohaPlugins). This would trigger a warning when
    running the test a second time.

    Why? The uninstall call does its work not completely due to a small
    inconsistency in Koha::Plugins::Handler::delete when calling run
    without the enable_plugins parameter.

    This patch resolves that inconsistency and also removes an unneeded skip
    in Plugin.t in case the KitchenSink module already exists.
    Note: This is a small fix. But I wonder if the Handler routines run and
    delete should not have been implemented in Koha::Plugins::Base.
    Also note that plugins/plugins-uninstall.pl will not be affacted by this
    change, since it checks whether the pref is enabled before calling the
    delete method.

    Test plan:
    [1] Do not yet install this patch.
    [2] Verify that plugins are enabled in koha-conf.xml.
    [3] Disable UseKohaPlugins in System Preferences!
    [4] Run t/db_dependent/Plugins.t.
    [5] Verify that table koha_plugin_com_bywatersolutions_kitchensink_mytable
        still exists. (It should have been deleted.) Remove it manually.
    [6] Apply this patch.
    [7] Run the test again.
    [8] Verify that the table does not exist.
    [9] Run the test again (without warnings).

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    (cherry picked from commit 4263ac2b92737024d8d620a751babf72b904b73a)
    Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
    (cherry picked from commit 4ebe7b489c9798d2456bd3de1d95ec6e027b2b21)
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
    (cherry picked from commit 752e31425efa34fa6f21446fb18cf34ba31fc441)
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Plugins/Handler.pm  |    9 ++++++++-
 t/db_dependent/Plugins.t |   26 +++++++++++++++-----------
 2 files changed, 23 insertions(+), 12 deletions(-)

hooks/post-receive
-- 
main Koha release repository