[koha-commits] main Koha release repository branch master updated. v16.05.00-238-g172ebfe

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  172ebfe520d34f8106ec011b7d707c0560d65760 (commit)
      from  1509322c9a813809ca453b476ea1163bbc9303ca (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 172ebfe520d34f8106ec011b7d707c0560d65760
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue May 3 14:34:33 2016 +0100

    Bug 16431: Use Koha::Cache to cache marc subfield structure
    
    The marc subfield structure is currently cached using a global variable
    of C4::Context. The infos are retrieved every time a new context is
    created.
    This patch suggests to use Koha::Cache instead.
    
    To achieve this goal, a new subroutine is created
    C4::Biblio::GetMarcSubfieldStructure, it will be called from code which
    needs to get the marc subfield structure. GetMarcFromKohaField,
    GetMarcSubfieldStructureFromKohaField, TransformKohaToMarc and
    _get_inverted_marc_field_map are modified accordingly and the cache is cleared
    when the table is updated (from the 3 pl scripts modified by this patch).
    
    The caching done in C4::Context (marcfromkohafield) is removed.
    
    Test plan:
    Play with the marc subfield structure (in the administration module),
    then add and edit records and make sure everything went fine.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Everything works as expected on my functional tests. I'm really happy to see the
    patch introduces relevant tests for previously untested functions.
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/AuthoritiesMarc.pm             |    1 -
 C4/Biblio.pm                      |  115 ++++++++++++++++++-----------------
 C4/Context.pm                     |   40 ------------
 admin/biblio_framework.pl         |    2 +
 admin/marc_subfields_structure.pl |    2 +
 admin/marctagstructure.pl         |    3 +
 t/db_dependent/Biblio.t           |  121 +++++++++++++++++--------------------
 t/db_dependent/Items.t            |   37 ++++++------
 8 files changed, 144 insertions(+), 177 deletions(-)


hooks/post-receive
-- 
main Koha release repository