[koha-commits] main Koha release repository branch master updated. v16.05.00-242-gc7596a4

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  c7596a489473bc294e04690f21b7a9d612f34abd (commit)
       via  eddc0a0e0a72264151e39f8a5d87d638a4208369 (commit)
       via  8f42c681b0208ace7ed7858cafdd8c9777debd96 (commit)
      from  3bb51d038639c7b197022a2c7c6ae864c834060f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c7596a489473bc294e04690f21b7a9d612f34abd
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Tue Jun 28 15:21:53 2016 +0200

    Bug 16671: [QA Follow-up] Replace remaining itemtype lines
    
    Instead of relying on existing data, we use new TestBuilder recs.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit eddc0a0e0a72264151e39f8a5d87d638a4208369
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Mon Jun 27 09:24:14 2016 +0200

    Bug 16671: [QA Follow-up] Add new itemtype and remove bailout
    
    No need to bail out, if we are using TestBuilder.
    Somehow, this test passes with me if we add a new record, and if
    we do not, it fails (using BK as the first itemtype with notforloan
    is 0).
    
    Looking further, we should imo remove the Koha::ItemTypes searches
    here and not depend on existing data. Just add some item types.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 8f42c681b0208ace7ed7858cafdd8c9777debd96
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Jun 6 14:00:56 2016 +0100

    Bug 16671: (bug 14828 follow-up) Pick the right itemtypes
    
    Looking at commit aafe73eefb5151454fa8957bf188768324d23955
      Bug 14828: Use Koha::ItemType[s] everywhere C4::ItemType was used
    -my @item_types = C4::ItemType->all;
    -my @for_loan = grep { $_->{notforloan} == 0 } @item_types
    -  or BAIL_OUT("No adequate itemtype");
    -my $itemtype = $for_loan[0]->{itemtype};
    +my $itemtype = Koha::ItemTypes->search({ notforloan => 1 })->next;
    +$itemtype or BAIL_OUT("No adequate itemtype"); #FIXME Should be $itemtype = $itemtype->itemtype
    
    It seems that the tests expect itemtypes for loan.
    
    Test plan:
      prove t/db_dependent/HoldsQueue.t
    should still return green
    
    Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
    Works as advertised. No qa test tool errors
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Adding follow-up.
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 t/db_dependent/HoldsQueue.t |   17 ++++++-----------
 1 file changed, 6 insertions(+), 11 deletions(-)


hooks/post-receive
-- 
main Koha release repository