[koha-commits] main Koha release repository branch master updated. v16.05.00-255-g5ec641f
Git repo owner
gitmaster at git.koha-community.org
Fri Jul 8 15:06:44 CEST 2016
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 5ec641fbbb67501e2a71be64b12c9224caee1b55 (commit)
from 5f147cc6bb8a018fd0af8b23789e795bf57ede72 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 5ec641fbbb67501e2a71be64b12c9224caee1b55
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Thu Jul 7 02:34:28 2016 -0400
Bug 16869: Silence and catch warnings in t/db_dependent/SuggestionEngine_ExplodedTerms.t
By properly defining a opachtdocs (intranethtdocs was done too)
in the mock function, uninitialized variable warnings are
eliminated. Given that we can check if $KOHA_CONF is defined or
not, we can catch the warning as part of testing, so the output
of the test is cleaner.
TEST PLAN
---------
1) unset KOHA_CONF
2) prove t/db_dependent/SuggestionEngine_ExplodedTerms.t
-- lots of noise
3) apply patch
4) prove t/db_dependent/SuggestionEngine_ExplodedTerms.t
-- no noise
5) prove -v t/db_dependent/SuggestionEngine_ExplodedTerms.t
-- see the warnings were caught and not just ignored.
6) run koha qa test tools
Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
No warnings. Works as advertised
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
t/db_dependent/SuggestionEngine_ExplodedTerms.t | 59 ++++++++++++++++++-----
1 file changed, 46 insertions(+), 13 deletions(-)
mode change 100755 => 100644 t/db_dependent/SuggestionEngine_ExplodedTerms.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list