[koha-commits] main Koha release repository branch master updated. v16.05.00-312-gdee29d9

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  dee29d9f0b2b43bc762cb82a2212cd8a3d243f45 (commit)
       via  c57655d4ad69f82831b7f1b54b31a69d0d8275ee (commit)
       via  5821ff3867c5291558238e54686c6834caa266c6 (commit)
      from  c9bb9dc14064ddecf767145b7a2bb26794ca090e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit dee29d9f0b2b43bc762cb82a2212cd8a3d243f45
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Thu Jun 23 14:51:26 2016 -0400

    Bug 16805: Log in with database admin user breaks OPAC
    
    TEST PLAN
    ---------
    1) Apply Jonathan's test patch
    2) prove t/db_dependent/Letters.t
       -- dies before finishing tests
    3) Apply second test patch
    4) prove t/db_dependent/Letters.t
       -- dies before finishing tests
       -- 'addalert' is changed to 'getalert'
    5) Log into OPAC with database admin user.
       -- see error given in comment #0
    6) Apply this patch
    7) prove t/db_dependent/Letters.t
       -- says 'getalert'
       -- all tests pass.
    8) Log into OPAC with database admin user.
       -- logs in, but gives warning with a nice logout button.
    9) run koha qa test tools.
    
    Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
    No kaha qa errors
    In debian display diferent error:
    Can't use an undefined value as an ARRAY reference at /usr/lib/perl5/DBI.pm line 2054.
    Works as advertised
    
    NOTE: Revised test plan, as Jonathan added useful test case.
          Works as I've tested above.
          Hector tested older test plan which was steps
          5,6,8 and 9.
    
          Revised test plan again while tweaking to address comment #9.
    
    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit c57655d4ad69f82831b7f1b54b31a69d0d8275ee
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Fri Jun 24 12:28:27 2016 -0400

    Bug 16805: Tweak new test message to say getalert
    
    It said 'addalert', which is likely a cut-paste typo.
    Plus, let's keep running the other tests if that one
    goes bad.
    
    TEST PLAN
    ---------
    1) Apply Jonathan's test patch
    2) prove t/db_dependent/Letters.t
       -- dies before finishing tests
    3) Apply this test patch
    4) prove t/db_dependent/Letters.t
       -- still dies before finished tests,
          'addalert' now is 'getalert' in message.
    5) run koha qa test tools.
    
    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 5821ff3867c5291558238e54686c6834caa266c6
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Jun 24 17:02:59 2016 +0100

    Bug 16805: Add test to getalert (no param passed)
    
    TEST PLAN
    ---------
    1) apply patch
    2) prove t/db_dependent/Letters.t
       -- fails
    3) run koha qa test tools
    
    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Letters.pm                                         |    9 ++++-----
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt |   12 ++++++++++++
 opac/opac-user.pl                                     |    4 ++++
 t/db_dependent/Letters.t                              |   10 ++++++----
 4 files changed, 26 insertions(+), 9 deletions(-)


hooks/post-receive
-- 
main Koha release repository