[koha-commits] main Koha release repository branch master updated. v16.05.00-342-gb51f2ba

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  b51f2baa7c1035657594f90d17c7c9eeedf4ea84 (commit)
      from  06fa67d75a10adcc5ac8cbefad498f0e0d254b03 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit b51f2baa7c1035657594f90d17c7c9eeedf4ea84
Author: Marc Véron <veron at veron.ch>
Date:   Tue Jul 5 19:23:59 2016 +0200

    Bug 14138: Patroncard: Warn user if PDF creation fails
    
    Change patroncards/create-pdf.pl to redirect with an error message
    instead of writing an invalid pdf that does not open in pdf viewer.
    
    To test:
    - Apply patch
    
    - Test that pdf creator behaves as before (with valid batches and
      patron lists)
    
    - While testing, copy pdf link address from window with title 'Click
      the following link(s) to download...'
    
    - Open another staff client browser tab
    
    - Paste link to browser address field, change batch id rsp. patron
      list id to an invalid value and submit
    
    - The window should redirect to cgi-bin/koha/patroncards/create-pdf.pl
      and display an error message
    
    - Bonus test 1: Create an empty patron list and test patron card
      creation. You should get an error message as appropriate.
    
    - Bonus test 2: Use a link with params like the following:
      ...create-pdf.pl?borrower_number=61&template_id=2&layout_id=1&start_card=1
      Verify that you can create a pdf with a valid borrower_number and that
      you get the error message with an invalid borrower number
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 .../prog/en/includes/patroncards-errors.inc        |   13 +++++-
 .../prog/en/modules/patroncards/manage.tt          |    1 +
 patroncards/create-pdf.pl                          |   45 +++++++++++++++-----
 3 files changed, 47 insertions(+), 12 deletions(-)


hooks/post-receive
-- 
main Koha release repository