From gitmaster at git.koha-community.org Fri Jun 3 08:22:58 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Jun 2016 06:22:58 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-24-g567a1a9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 567a1a9021aaea3bf42b19f493b79f682ed9042b (commit) via da94410ab5022c3bd97fba1878673149802db584 (commit) via 72bd06e3a88f62fcfe8710773091447ebafebcb3 (commit) from e0143f3205ebbf07aa479b89d8ba8aab426496b2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 567a1a9021aaea3bf42b19f493b79f682ed9042b Author: Marcel de Rooy Date: Tue May 31 14:16:07 2016 +0200 Bug 16504: [QA Follow-up] Make koha-qa happy with two newlines Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher commit da94410ab5022c3bd97fba1878673149802db584 Author: Jonathan Druart Date: Fri May 13 14:43:52 2016 +0100 Bug 16504: (follow-up for bug 15163) Do not remove attributes of other patrons Simple patch for a silly error, this single line is going to fix a critical bug. If a patron attribute is limited to a library, all the values for that attributes for every patrons will be deleted. Test plan: Create a patron attribute limited to a library Set the the attribute for a patron Set the the attribute for another patron => Without this patch applied, the attribute's value for the first patron is deleted => With this patch applied, the 2 values exist in the DB after the second edition Signed-off-by: Srdjan Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher commit 72bd06e3a88f62fcfe8710773091447ebafebcb3 Author: Jonathan Druart Date: Fri May 13 14:42:52 2016 +0100 Bug 16504: Add regression tests Signed-off-by: Srdjan Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: C4/Members/Attributes.pm | 4 +++- t/db_dependent/Members/Attributes.t | 34 +++++++++++++++++++++++++++++++++- 2 files changed, 36 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 3 08:27:06 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Jun 2016 06:27:06 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-26-g71f0370 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 71f0370ddde0d8b8e2a666a091081186fb6531e8 (commit) via cbdd9194eb3359d517fbda9a50a02fbc375bf5dd (commit) from 567a1a9021aaea3bf42b19f493b79f682ed9042b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 71f0370ddde0d8b8e2a666a091081186fb6531e8 Author: Kyle M Hall Date: Fri May 27 12:42:17 2016 +0000 Bug 16610 - Regression in SIP2 user password handling Previous to bug 14507, SIP2 only did internal authentication. A change to the way we check empty passwords has caused any empty password to send back a CQ of Y. Previous to that patch set, a CQ of Y would only be sent back of the patron password column was NULL. Now, an empty AD field *always* returns a CQ of Y. Test Plan: 1) Send a patron information request with an empty AD field Note: You must send the AD field or you won't get back a CQ field 2) Note you get back a CQ of Y 3) Apply this patch 4) Repeat step 1 5) Note you now get back a CQ of N Signed-off-by: Trent Roby Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher commit cbdd9194eb3359d517fbda9a50a02fbc375bf5dd Author: Marcel de Rooy Date: Wed Jun 1 15:34:56 2016 +0200 Bug 16610: [QA Follow-up] Add a test To verify the original patch, this test shows that before applying it the Patron Info request did not return CQ==N for an empty password. Note that the Patron Status did btw. After applying the original patch, the test passes for patron info as well as status. Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: C4/SIP/ILS/Patron.pm | 8 ++++---- t/db_dependent/SIP/Message.t | 26 ++++++++++++++++++++++++-- 2 files changed, 28 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 3 09:08:34 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Jun 2016 07:08:34 +0000 Subject: [koha-commits] main Koha release repository branch 16.05.x created. v16.05.00-6-gfa1dd40 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 16.05.x has been created at fa1dd408ca7714aed406ff75d3c4c55545b97cf0 (commit) - Log ----------------------------------------------------------------- ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 3 09:18:29 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Jun 2016 07:18:29 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-27-g5ba5f9e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 5ba5f9e0c5958b518bd648f08146329e355f3a7e (commit) from 71f0370ddde0d8b8e2a666a091081186fb6531e8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5ba5f9e0c5958b518bd648f08146329e355f3a7e Author: Mark Tompsett Date: Tue May 24 22:31:15 2016 -0400 Bug 16582 t/Price.t test should pass if Test::DBIx::Class is not available TEST PLAN --------- 1) prove t/Prices.t -- failure 2) apply patch 3) prove t/Prices.t -- nicely skipped when Test::DBIx::Class is not available. Signed-off-by: Srdjan Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: t/Prices.t | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 3 09:57:42 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Jun 2016 07:57:42 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-29-gc2f53bd Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via c2f53bd039aa2ce52c2ddc3a2314e32b44ae4ee8 (commit) via e7ac7abf16c76a00a5dcd8e8cd1e62522675b8ee (commit) from 5ba5f9e0c5958b518bd648f08146329e355f3a7e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c2f53bd039aa2ce52c2ddc3a2314e32b44ae4ee8 Author: Jonathan Druart Date: Fri May 13 15:28:50 2016 +0100 Bug 16388: Use existing 'execute' parameter instead of creating a new one An existing 'execute' parameter is already passed to the template when we need to display the 'Download' button, so let's use it instead of creating a new one. Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher commit e7ac7abf16c76a00a5dcd8e8cd1e62522675b8ee Author: Aleisha Date: Fri Apr 29 02:47:06 2016 +0000 Bug 16388: Move option to download report into reports toolbar To test: 1) Create a new SQL report or edit a report 2) Ensure that the download option does NOT show in the toolbar 3) Save and run the report 4) Confirm that download option DOES show in toolbar as a dropdown with the 3 options (csv, tab and ods) 5) Confirm that downloading all 3 file types works as expected Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/includes/reports-toolbar.inc | 12 ++++++++++++ .../prog/en/modules/reports/guided_reports_start.tt | 13 ------------- 2 files changed, 12 insertions(+), 13 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 3 10:08:34 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Jun 2016 08:08:34 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-30-g4c04f6f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 4c04f6f8e0068a7cce256c3cd8ffcf5acf682fe0 (commit) from c2f53bd039aa2ce52c2ddc3a2314e32b44ae4ee8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4c04f6f8e0068a7cce256c3cd8ffcf5acf682fe0 Author: Owen Leonard Date: Mon Apr 25 09:12:05 2016 -0400 Bug 16336 [Revised] UX of holds patron search with long lists of results Bug 15793 made a change to an interface which is also found in the place hold template. This patch creates a new include file to be used by both circulation.tt and request.tt so that these pages do not diverge. In the process, this patch removes some markup and JavaScript which was made obsolete by Bug 15793 and should have been removed. This patch also revises the sorting of the results table so that the patron name is sortable (Bug 16334) and the default sort is on card number (matching 3.20.x and 3.22.x). To test: In Circulation: - Perform a search by name for a patron which will return multiple search results. - The table of results which displays should look correct and work correctly, including DataTables sorting. - Clicking any table row should forward you to the checkout page for that patron. In the catalog: - Locate and place a hold on a title. - When prompted to select a patron to place the hold for, perform a search by name which will return multiple results. - Confirm that the table of patron results looks correct and works correctly. - Clicking any table row should forward you to the place hold page for that patron and the title you selected. Revision: Although the table row was clickable, you couldn't middle-click it to open the link in a new tab. The patron name is now a real link you can middle-click or right-click. The row is still clickable as well. Signed-off-by: Aleisha Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: .../en/includes/circ-patron-search-results.inc | 40 ++++++++++++++ .../prog/en/modules/circ/circulation.tt | 55 +------------------- .../prog/en/modules/reserve/request.tt | 46 ++-------------- 3 files changed, 45 insertions(+), 96 deletions(-) create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/circ-patron-search-results.inc hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 3 10:09:56 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Jun 2016 08:09:56 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-31-ged449a5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ed449a5b5be4da03443d214de5806f4a0273227b (commit) from 4c04f6f8e0068a7cce256c3cd8ffcf5acf682fe0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ed449a5b5be4da03443d214de5806f4a0273227b Author: Owen Leonard Date: Thu May 19 12:28:08 2016 -0400 Bug 16005 - Standardize use of icons for delete and cancel operations This patch makes changes to Font Awesome icons in order to make icon choice consistent for common actions. where something is deleted, removed, or emptied. where an operation is cancelled (also where selections are cancelled, as in checkboxes). for "close," as in baskets and windows. To test, apply the patch and view the following pages to confirm that the correct icon is used: - Acquisitions -> Vendor -> Vendor delete button. - Acquisitions -> Vendor -> Edit -> Delete contact button. - Acquisitions -> Invoices -> Delete menu item. - Cataloging -> Edit record -> Authority search pop-up (triggered from the tag editor for a tag linked to an authority) -> Clear field button - Authorities -> Authority detail -> Delete button. - Tools -> Quotes editor -> Quotes delete button. - Reports -> View saved report -> Delete button. - Reports -> Saved reports -> Delete menu item. - Serials -> Subscription details -> Subscription close button. - Administration -> Budgets -> Delete menu item. - Administration -> Item search fields -> Delete button. - Administration -> Z39.50/SRU servers -> Delete menu item. - Catalog -> Advanced search -> Clear fields link. - Cataloging -> Advanced editor -> Macros -> Delete macro button. - Circulation -> Checkout -> Check out an item which is on hold for another patron. "Cancel checkout and place hold" button now uses the icon used elsewhere for holds. - Course reserves -> Course -> Delete course button. - Patrons -> Patron lists -> Add patrons -> Remove selected button. - Acquisitions -> Suggestions -> Suggestion details -> Delete button. - Lists -> List contents -> Remove selected button. Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/includes/acquisitions-toolbar.inc | 2 +- .../intranet-tmpl/prog/en/includes/auth-finder-search.inc | 2 +- .../intranet-tmpl/prog/en/includes/authorities-toolbar.inc | 2 +- koha-tmpl/intranet-tmpl/prog/en/includes/quotes-toolbar.inc | 4 ++-- koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc | 2 +- .../prog/en/includes/rotating-collections-toolbar.inc | 4 ++-- koha-tmpl/intranet-tmpl/prog/en/includes/serials-toolbar.inc | 10 +++++----- koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt | 2 +- .../intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt | 2 +- .../prog/en/modules/admin/items_search_fields.tt | 2 +- .../intranet-tmpl/prog/en/modules/admin/z3950servers.tt | 2 +- .../intranet-tmpl/prog/en/modules/catalogue/advsearch.tt | 2 +- .../intranet-tmpl/prog/en/modules/cataloguing/editor.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 2 +- .../prog/en/modules/course_reserves/course-details.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt | 2 +- .../prog/en/modules/reports/guided_reports_start.tt | 2 +- .../intranet-tmpl/prog/en/modules/suggestion/suggestion.tt | 2 +- .../intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt | 2 +- 20 files changed, 26 insertions(+), 26 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 3 10:34:45 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Jun 2016 08:34:45 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-32-g6c733b2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6c733b2fda7cd94ae2997c1a058d229dd7819692 (commit) from ed449a5b5be4da03443d214de5806f4a0273227b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6c733b2fda7cd94ae2997c1a058d229dd7819692 Author: Aleisha Date: Thu May 12 04:41:09 2016 +0000 Bug 12402: Show patron category on pending patron modifications To test: 1) Go to OPAC and make a modification to user 2) Go to Staff Client and go to pending patron modifications 3) Notice that we have the user's surname, first name, branch and cardnumber 4) Apply patch and refresh page 5) Notice that patron category now shows after user's name Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 3 10:37:22 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Jun 2016 08:37:22 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-36-gedec592 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via edec5921b11afcbda44fbb6c45f26174768b1708 (commit) via 9c339f5941a3a628645e3f13c8fdbc92077ea4fc (commit) via 481fb09701b83a460f0eb93c0a11c48759aba5c1 (commit) via 46607f1098153008698023b538ab1391e782a6fc (commit) from 6c733b2fda7cd94ae2997c1a058d229dd7819692 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit edec5921b11afcbda44fbb6c45f26174768b1708 Author: Jonathan Druart Date: Fri May 20 16:29:01 2016 +0100 Bug 9543: Separate MTT with commas Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher commit 9c339f5941a3a628645e3f13c8fdbc92077ea4fc Author: Marc V?ron Date: Fri May 20 11:01:18 2016 +0200 Bug 9543 - (Follow-up) Show patrons messaging subscription on holds notification As of comment #19 - Code de-duplicated to a BLOCK statement - Variable renamed - Wording slightly changed. I like it that way, but feel free to change it in a follow-up Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher commit 481fb09701b83a460f0eb93c0a11c48759aba5c1 Author: Nick Clemens Date: Wed Apr 6 00:51:15 2016 +0000 Bug 9543 - Show patrons messaging subscription on holds notification not already waiting Same plan as previous patch, but this one should show the message for a hold not already waiting but not requiring a transfer (hold-found2 alert box) Signed-off-by: Chris Kirby Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher commit 46607f1098153008698023b538ab1391e782a6fc Author: Marc V?ron Date: Thu Mar 24 16:06:30 2016 +0100 Bug 9543 - Show patrons messaging subscription on holds notification Display an information about a patron's messaging preferences if an item is checked in where the patron has put a hold. To test: - Apply patch - Make sure that SMS driver and TalkingTech sysprefs are defined to enable SMS and Phone preferences for users (SMS driver can be a dummy value) - Place a hold for a patron - Set patron's messaging preferences to different choices (including none) - Check in the item that is on hold (it has not to be checked out for the test - Verify that below the message "Hold found (item is already waiting") an information appears about the patron's messaging preferences. Signed-off-by: Nick Clemens Signed-off-by: Chris Kirby Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: circ/returns.pl | 4 +++- .../intranet-tmpl/prog/en/modules/circ/returns.tt | 19 +++++++++++++++++++ 2 files changed, 22 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 3 11:13:38 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Jun 2016 09:13:38 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-37-ga01cd77 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a01cd77e19f810bf61c8d26ebb97f7c49f1d1f32 (commit) from edec5921b11afcbda44fbb6c45f26174768b1708 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a01cd77e19f810bf61c8d26ebb97f7c49f1d1f32 Author: Jonathan Druart Date: Mon May 23 12:19:46 2016 +0100 Bug 16565: Drop additional_fields and additional_field_values before creating them These 2 tables should be dropped before trying to create them Test plan: From the SQL CLI, source the kohastructure.sql file source it again => Without this patch you get 2 warnings ERROR 1050 (42S01) at line 3580 in file: 'installer/data/mysql/kohastructure.sql': Table 'additional_fields' already exi sts ERROR 1050 (42S01) at line 3596 in file: 'installer/data/mysql/kohastructure.sql': Table 'additional_field_values' alrea dy exists => With this patch, you won't get them Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/kohastructure.sql | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 3 12:52:53 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Jun 2016 10:52:53 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-38-g78b2fde Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 78b2fde34831a4840f6b89df054a5307f1ead54b (commit) from a01cd77e19f810bf61c8d26ebb97f7c49f1d1f32 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 78b2fde34831a4840f6b89df054a5307f1ead54b Author: Claire Gravely Date: Fri Jun 3 10:38:25 2016 +0200 Bug 16642 - Fix capitalisation for upload patron image To fix capitalisation on the staff interface when patronimages is turned on. Test plan: 1. In staff interface. Turn on patronimages sys preference. 2. Go to a patron without an image and check that the "Upload patron image" box heading now has correct capitalisation. 3. Go to a patron with an image already uploaded and check the "Manage patron image" box heading has correct capitalisation. Signed-off-by: Sofia Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 3 14:04:05 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Jun 2016 12:04:05 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-39-g84f7f16 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 84f7f1608553e3cd4610e96325eecff177da1d49 (commit) from 78b2fde34831a4840f6b89df054a5307f1ead54b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 84f7f1608553e3cd4610e96325eecff177da1d49 Author: Chris Cormack Date: Fri Jun 3 11:59:18 2016 +0000 Bug 7143 Updating the history.txt Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: docs/history.txt | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 3 14:37:51 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Jun 2016 12:37:51 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-41-g7e30240 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 7e30240e694c65bb635a495820cce8883d26baa5 (commit) via e1b5adec83febdb93e0045b711a19b84e5d06a4a (commit) from 84f7f1608553e3cd4610e96325eecff177da1d49 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7e30240e694c65bb635a495820cce8883d26baa5 Author: Chris Cormack Date: Fri Jun 3 12:09:33 2016 +0000 Bug 7143 : Ooops double counted a developer Signed-off-by: Brendan Gallagher commit e1b5adec83febdb93e0045b711a19b84e5d06a4a Author: Chris Cormack Date: Fri Jun 3 12:07:02 2016 +0000 Bug 7143: Updating about page for new developers Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: docs/history.txt | 5 ++--- koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 9 ++++++++- 2 files changed, 10 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 3 15:50:46 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Jun 2016 13:50:46 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-42-g87b181c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 87b181c6d40e7a811fee511648ddd3cb7d44c4e4 (commit) from 7e30240e694c65bb635a495820cce8883d26baa5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 87b181c6d40e7a811fee511648ddd3cb7d44c4e4 Author: Jonathan Druart Date: Wed May 4 19:53:46 2016 +0100 Bug 16442: Make C4::Ris plack safe C4::Ris incorrectly uses 4 package variables: - $utf: not used, can be removed - $intype: set to marcflavour once, but later it assumes that it is usmarc if not defined - $marcprint: always 0, so set it to 0 - $protoyear: only used in 1 subroutine, let's define it at this level Test plan: Just make sure the RIS export works as before this patch Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: C4/Ris.pm | 38 ++++++++++++++++---------------------- 1 file changed, 16 insertions(+), 22 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Jun 4 08:55:01 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sat, 04 Jun 2016 06:55:01 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-43-g6cd592b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6cd592ba3b18236a3c0f82873d4444c1f884f37c (commit) from 87b181c6d40e7a811fee511648ddd3cb7d44c4e4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6cd592ba3b18236a3c0f82873d4444c1f884f37c Author: Owen Leonard Date: Mon May 16 10:52:17 2016 -0400 Bug 16529 - Clean up and improve upload template This patch makes some fixes and improvements to the template for Tools -> Upload, including markup corrections, removal of 'onclick,' and conversion of some links to styled buttons. To test, apply the patch and go to Tools -> Upload. - Confirm that uploading a file works correctly. - Confirm that clicking 'Cancel' during a file upload works correctly. - Search existing uploads. - Confirm that the 'Download' and 'Delete' buttons look correct and work correctly. - In Administration -> MARC bibliographic framework, choose a framework and configure a tag subfield to use the upload plugin. - Create or edit a bibliographic record using the framework you modified. - Click the tag editor icon next to your modified subfield to trigger the pop-up window with the upload form. - Confirm that this window has a layout which is adjusted for the size of the window. - Confirm that uploading and selecting files from this window works correctly. Signed-off-by: Rocio Dressler Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/tools/upload.tt | 105 ++++++++++++-------- 1 file changed, 65 insertions(+), 40 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Jun 4 09:32:53 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sat, 04 Jun 2016 07:32:53 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-44-gfc35a50 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via fc35a5099f613c08d12be1d67fd027d4a5eaf99c (commit) from 6cd592ba3b18236a3c0f82873d4444c1f884f37c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fc35a5099f613c08d12be1d67fd027d4a5eaf99c Author: Jonathan Druart Date: Wed May 11 12:00:01 2016 +0100 Bug 16458: Update library when a guarantor is set If you edit a patron from the Edit link of the patron information block (step 1 of the memberentry script), the branchcode is not displayed. If you set a guarantor to a child from this form, a JavaScript error will be raised: JavaScript error form.branchcode is undefined It happens because there is the branchcode is not displayed and there is no element with a branchcode name. To avoid this issue, a branchcode hidden input is added to the form and it will be updated when a guarantor is selected (same behavior as when you edit a patron using the complete form). Test plan: Edit a patron using the Edit link of the patron info block (not the Edit button in the toolbar) Set a guarantor => Notice that the branchcode of the patron has been updated with the branchcode of the guarantor Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Jun 4 09:43:51 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sat, 04 Jun 2016 07:43:51 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-46-gb37d7c9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b37d7c993542f54a1821c99899c4f0772f5846b8 (commit) via f01a07a25e0503d9dbed3a4226cb51a155bcacd4 (commit) from fc35a5099f613c08d12be1d67fd027d4a5eaf99c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b37d7c993542f54a1821c99899c4f0772f5846b8 Author: Jonathan Druart Date: Wed May 11 13:13:38 2016 +0100 Bug 16088: Fix the number of tests to skip Signed-off-by: Jacek Ablewicz Signed-off-by: Jesse Weaver Signed-off-by: Brendan Gallagher commit f01a07a25e0503d9dbed3a4226cb51a155bcacd4 Author: Jonathan Druart Date: Mon May 9 17:27:51 2016 +0100 Bug 16088: Introduce Koha::Cache::Memory::Lite to cache the language The goal of this patch is to avoid unecessary flush of the L1 cache on creating a new CGI object each time C4::Languages::getlanguage is called without a CGI object. The new class Koha::Cache::Memory::Lite must be flushed by the CGI constructor overide done in the psgi file. This new class will ease caching of specific stuffs used by running script. Test plan: At the OPAC and the intranet interfaces: Open 2 different browser session to simulate several users - Clear the cookies of the browsers - User 1 (U1) an User 2 (U2) should be set to the default language (depending on the browser settings) - U1 chooses another language - U2 refreshes and the language used must be the default one - U2 chooses a third language - U1 refreshes and must be still using the one he has choosen. Try to use a language which is not defined: Add &language=es-ES (if es-ES is not translated) to the url, you should not see the Spanish interface. Signed-off-by: Jacek Ablewicz Signed-off-by: Jesse Weaver Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: C4/Languages.pm | 30 ++++++++++++------ C4/Templates.pm | 14 +++++---- Koha/Cache/Memory/Lite.pm | 72 +++++++++++++++++++++++++++++++++++++++++++ debian/templates/plack.psgi | 3 ++ misc/plack/koha.psgi | 2 ++ t/Cache.t | 42 +++++++++++++++++++++++-- 6 files changed, 145 insertions(+), 18 deletions(-) create mode 100644 Koha/Cache/Memory/Lite.pm hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Jun 4 09:54:24 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sat, 04 Jun 2016 07:54:24 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-47-gfff754a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via fff754a7fc7a99dad6a35129b8a7dd170684f2bf (commit) from b37d7c993542f54a1821c99899c4f0772f5846b8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fff754a7fc7a99dad6a35129b8a7dd170684f2bf Author: Jonathan Druart Date: Wed May 4 20:20:51 2016 +0100 Bug 16444: Make C4::Tags plack safe C4::Tags use a package variable to cache the pref TagsExternalDictionary, it's not needed and not safe. There is not test plan, just make sure the changes are consistent. Signed-off-by: Srdjan Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: C4/Tags.pm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Jun 4 11:51:05 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sat, 04 Jun 2016 09:51:05 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-48-ga589879 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a589879f495aeb25200119cb4f1bf76c28dce660 (commit) from fff754a7fc7a99dad6a35129b8a7dd170684f2bf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a589879f495aeb25200119cb4f1bf76c28dce660 Author: Rocio Dressler Date: Sat Jun 4 02:24:45 2016 -0700 Bug 16537 - Overdue and Status triggers grammar Test plan: 1) Go to the staff client 2) Click on Tools - Overdue notice/status triggers 3) Confirm that the first sentence reads "a" checkout rather than "an" checkout Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Jun 4 14:40:56 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sat, 04 Jun 2016 12:40:56 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-49-g6b7f4a3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6b7f4a3a9ec18b550d011a7eee9e7108b7042059 (commit) from a589879f495aeb25200119cb4f1bf76c28dce660 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6b7f4a3a9ec18b550d011a7eee9e7108b7042059 Author: Aliki Pavlidou Date: Sat Jun 4 12:10:38 2016 +0000 Bug 15641 - Typo in explanation for MembershipExpiryDaysNotice There's an extra period after the word "in" in the MembershipExpiryDaysNotice sys "Send an account expiration notice when a patron's card will expire in. [value box Bug fixed! Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Jun 4 14:46:43 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sat, 04 Jun 2016 12:46:43 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-51-gd9ef98b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d9ef98b9b66440240ae9a3baadbf9b1f665e8aab (commit) via 5ae16fa243f9e6843799f23437726d386f3e600b (commit) from 6b7f4a3a9ec18b550d011a7eee9e7108b7042059 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d9ef98b9b66440240ae9a3baadbf9b1f665e8aab Author: Brendan Gallagher Date: Sat Jun 4 15:42:52 2016 +0300 Revert "Bug 7143 - Bug for tracking changes to the about page" This reverts commit 6dc7401f2f631763ccae0db5bf52bb7731268fbc. commit 5ae16fa243f9e6843799f23437726d386f3e600b Author: Brendan Gallagher Date: Sat Jun 4 09:57:39 2016 +0000 Bug 7143 - Bug for tracking changes to the about page Adjusting the history file for new developers ----------------------------------------------------------------------- Summary of changes: hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jun 6 19:30:44 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 06 Jun 2016 17:30:44 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-52-gab1beed Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ab1beed06f249d1e7d0be5bb1b584e62f5b48783 (commit) from d9ef98b9b66440240ae9a3baadbf9b1f665e8aab (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ab1beed06f249d1e7d0be5bb1b584e62f5b48783 Author: Jonathan Druart Date: Fri May 13 20:46:42 2016 +0100 Bug 16518: Fix Plack variable scoping problem in opac-addbybiblionumber.pl The script opac/opac-addbybiblionumber.pl is not plack safe because the variable @biblios is declared with our and is not assigned to an empty array (so not reset). The issue: When trying to add items to a list (virtualshelf), the biblionumbers are added to the @biblios variable and the list is not reset between each run. Test plan: Check from records from the result list and add them to a list. Cancel or save and re-add them (or others) to a list (same or different). => Without this patch, the list of records will never stop growing, the previous items added are still listed when adding new ones. => With this patch, the behavior is the one expected. Signed-off-by: Srdjan Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: opac/opac-addbybiblionumber.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jun 6 19:35:14 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 06 Jun 2016 17:35:14 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-53-gf2fe433 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f2fe433cf9afce98957826bf2ade457557fe4eff (commit) from ab1beed06f249d1e7d0be5bb1b584e62f5b48783 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f2fe433cf9afce98957826bf2ade457557fe4eff Author: Jonathan Druart Date: Tue May 17 14:38:04 2016 +0100 Bug 16508: Updating a syspref requires parameters_remaining_permissions And not all of parameters flags. Test plan: 1/ Create a staff user. 2/ Go to details, select more->set permissions. 3/ Set catalogue, Manage Koha system settings (Administration panel), manage circulation rules, and Remaining system parameters permissions. 4/ Log in as the new staff user, go to administration > system preferences. Change a syspref and save it... it will save correctly. 5/ Log back in as superlibrarian 6/ On the 'set permissions' screen, un-check 'manage circulation rules' and save. 7/ Log back in to the new staff user, and try to change the same systemprefrence and save. Followed test plan, works as expected. Signed-off-by: Marc Veron Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: svc/config/systempreferences | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jun 6 19:36:01 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 06 Jun 2016 17:36:01 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-54-g7d916c3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 7d916c380a03904c47035f189d1ee666f00d9a11 (commit) from f2fe433cf9afce98957826bf2ade457557fe4eff (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7d916c380a03904c47035f189d1ee666f00d9a11 Author: Jonathan Druart Date: Thu May 5 16:58:06 2016 +0100 Bug 16455: Remove the "Too late to run INIT block" from C4::Tags The pref TagsExternalDictionary is used to tell Lingua::Ispell to use an other dictionary, different from the default one (/usr/bin/ispell). To do so we need to set $Lingua::Ispell::path to the expected path. It's currently done in the INIT block. If you try to use C4::Tags, you will get the famous "Too late to run INIT block at C4/Tags.pm line 74." warning. Plack use the INIT block to load functions at run time, when we are using C4::Tags when hitting a pl script, the compilation phase is finished and it's "too late to run INIT block" from C4::Tags. I do not really know if it has an impact on the behavior of Lingua::Ispell (i.e. is the path redefined?), but I know that this INIT block is not executed when we want. Test plan: under Plack, - hit /cgi-bin/koha/opac-search.pl and confirm that the warning does no longer appears - Use another dictionnary (??), fill TagsExternalDictionary with its path and confirm that it is used by the tags approval system Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: C4/Tags.pm | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 9 09:34:22 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 09 Jun 2016 07:34:22 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-3-g8480d4d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 8480d4d260981552e0952a74ff1c5b24d3f22fa4 (commit) via 0c61cb521473786727d5f6f07f42f7e594f9f16a (commit) from 72c54153efa531308ff4339fb91d3a99b261d7a2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8480d4d260981552e0952a74ff1c5b24d3f22fa4 Author: Marcel de Rooy Date: Fri May 20 10:14:28 2016 +0200 Bug 15333: [QA Follow-up] Add few tests This report had no test plan and no unit tests. Adding some lines to Holidays.t. Added a trivial line move in Calendar.pm. Test plan: Run t/db_dependent/Holidays.t with and without cache. Signed-off-by: Marcel de Rooy Tested with memcached, Cache::Memory and no cache (edit Cache.pm). Signed-off-by: Brendan Gallagher (cherry picked from commit 73aa490029b4b536c86c3ac59e53f9e118c7c292) Signed-off-by: Julian Maurice commit 0c61cb521473786727d5f6f07f42f7e594f9f16a Author: Jonathan Druart Date: Wed May 4 20:35:39 2016 +0100 Bug 15333: Use Koha::Cache to cache exception_holidays instead of a package variable On the same way as bug 14522, we should use Koha::Cache to cache exception_holidays. It's not safe to use a package variable if running under Plack. There is not test plan, just make sure the changes make sense. Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher (cherry picked from commit cbd375fab76a89b75f3795c9ebafe434bf79c878) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Calendar.pm | 7 +++++++ Koha/Calendar.pm | 22 +++++++------------- t/db_dependent/Holidays.t | 49 +++++++++++++++++++++++++++++++++++++++++---- 3 files changed, 59 insertions(+), 19 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 9 09:43:54 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 09 Jun 2016 07:43:54 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-4-g5aed72e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 5aed72e3a53df3f305776b3ee7b4edee01fec003 (commit) from 8480d4d260981552e0952a74ff1c5b24d3f22fa4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5aed72e3a53df3f305776b3ee7b4edee01fec003 Author: Katrin Fischer Date: Fri Apr 29 02:39:15 2016 +0200 Bug 16385: Fix breadcrumbs when ordering from subscription - Rephrase removing 'Shopping' - Fix link to vendor To test: - Create a subscription for vendor X - Create a baskest for vendor X - Choose: order from subscription - Check breadcrumbs: - Link to vendor works - 'Shopping' is gone, Basket remains Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit b1c97f0ff6202728b2e75de2eddbc5dcd84c04ed) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/acqui/newordersubscription.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 9 09:45:31 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 09 Jun 2016 07:45:31 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-6-g339f815 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 339f8156a7656e0dfd09a4775fc640d24b601585 (commit) via c265f1ea30bd5fe3fcd310d14b9fe54e3ae55881 (commit) from 5aed72e3a53df3f305776b3ee7b4edee01fec003 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 339f8156a7656e0dfd09a4775fc640d24b601585 Author: Jonathan Druart Date: Mon May 16 12:10:56 2016 +0100 Bug 16454: Remove another occurrence in comment Note that few other occurrences exist in DB. This patch also replaces a tab with 4 spaces. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 68280172e1446eaba07cf7ab5ac0135eff742b35) Signed-off-by: Julian Maurice commit c265f1ea30bd5fe3fcd310d14b9fe54e3ae55881 Author: Aleisha Date: Thu May 12 04:46:54 2016 +0000 Bug 16454: Use 'inventory' instead of 'inventory/stocktaking' To test: 1) Go to the tools home page. Confirm it says 'Inventory' instead of 'Inventory/stocktaking' in heading and in description 2) Click Inventory. Confirm heading now says 'Inventory' instead of 'Inventory/stocktaking' 3) Confirm that it now says 'Inventory' instead of 'Inventory/stocktaking' in the tools menu along the left of the page 4) Click Help in top right corner. Confirm help heading now says 'Inventory' instead of 'Inventory/stocktaking' 5) Go to user account page, go to Set Permissions 6) Expand Tools option and confirm it says 'inventory' instead of 'inventory (stocktaking)' Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 5d3ea96e578fa4b0a143cc26330c7d4ff689ef4b) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 2 +- koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc | 2 +- koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc | 2 +- .../intranet-tmpl/prog/en/modules/help/members/member-flags.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/help/tools/inventory.tt | 4 ++-- koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt | 4 ++-- 7 files changed, 9 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 9 10:02:28 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 09 Jun 2016 08:02:28 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-7-g2406ee2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 2406ee222de7b58ed327c2e298c18df33e7b562b (commit) from 339f8156a7656e0dfd09a4775fc640d24b601585 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2406ee222de7b58ed327c2e298c18df33e7b562b Author: Tomas Cohen Arazi Date: Wed Apr 6 12:44:25 2016 -0300 Bug 16216: Circulation_Branch.t doesn't set itemtype for test data This patch makes the tests create better data for them: - Run $ prove t/db_dependent/Circulation_Branch.t => FAIL: Warnings raised - Apply the patch - Run $ prove t/db_dependent/Circulation_Branch.t => SUCCESS: No warnings raised - Sign off Signed-off-by: Hector Castro Test pass successful Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher (cherry picked from commit 366e31f8c020080b9a0319abb7d2c02e10f42a40) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Circulation_Branch.t | 192 +++++++++++------------------------ 1 file changed, 62 insertions(+), 130 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 9 10:04:39 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 09 Jun 2016 08:04:39 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-8-g3b1a7ba Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 3b1a7ba719b02b5b2dfaa30ddc368d1c034b3cd6 (commit) from 2406ee222de7b58ed327c2e298c18df33e7b562b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3b1a7ba719b02b5b2dfaa30ddc368d1c034b3cd6 Author: Hector Castro Date: Thu Apr 28 13:34:13 2016 -0600 Bug 16343: 7XX XSLT subfields displaying out of order This patch respect previous css classes .authordates and .relatorcode but also include .titleportion .authordates {display: none;} .titleportion {display: none;} .relatorcode {display: none;} To test: - Stage the two record attached with titles: - Surface & coatings technology. - Women crime writers. - Reindex zebra (necessary to Opac and Itranet results) - Leave empty the OPACUserCSS and IntranetUserCSS sysprefs - Go to the new records in OPAC and Intranet detail page - See the wrong display of dates - Apply patch and refresh the page - Test in OPACUserCSS and IntranetUserCSS the css stated before - Play deleting or adding the classes - Test with multiple records with 700 (with and without dates, etc; 710 and 711) NOTE: dates in 710 and 711 can be hidden with .titleportion class; dates in this kind of heading go with another data for example: Catholic Church. Plenary Council of Baltimore (2nd : 1866) Patch rebased some typos fixed in comments Signed-off-by: Dani Elder Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit 0073a0c3f88276f6f5fac7b63ef6254cb8770e6b) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 220 +++++++++++++++----- .../prog/en/xslt/MARC21slim2intranetResults.xsl | 78 +++++-- .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 160 ++++++++++++-- .../bootstrap/en/xslt/MARC21slim2OPACResults.xsl | 80 +++++-- 4 files changed, 437 insertions(+), 101 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 10 18:35:28 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jun 2016 16:35:28 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-56-g30cf9ee Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 30cf9ee277481b54ed75e500c38f328f2d82b831 (commit) via 29e402d398f567e2526c89695384bce7f4e4b737 (commit) from 7d916c380a03904c47035f189d1ee666f00d9a11 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 30cf9ee277481b54ed75e500c38f328f2d82b831 Author: Marcel de Rooy Date: Fri Jun 10 11:49:45 2016 +0200 Bug 16443: [QA Follow-up] Add two tests for get_fields Adds t/db_dependent/Members/Statistics.t. Test plan: Run the test. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall commit 29e402d398f567e2526c89695384bce7f4e4b737 Author: Jonathan Druart Date: Wed May 4 20:08:53 2016 +0100 Bug 16443: Make C4::Members::Statistics plack safe If the prefs is updated, the fields won't be. To make sure we already fetch updated values, we should remove the package variable and define it in the subroutine. There is not test plan, just make sure the changes are consistent. Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Members/Statistics.pm | 5 +---- t/db_dependent/Members/Statistics.t | 20 ++++++++++++++++++++ 2 files changed, 21 insertions(+), 4 deletions(-) create mode 100644 t/db_dependent/Members/Statistics.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 10 18:37:54 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jun 2016 16:37:54 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-57-g8794348 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 8794348ccbb156ddd1ec53702b5afebea1747976 (commit) from 30cf9ee277481b54ed75e500c38f328f2d82b831 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8794348ccbb156ddd1ec53702b5afebea1747976 Author: Jonathan Druart Date: Tue May 24 19:57:16 2016 +0100 Bug 16570: Do not tell all checked-in items are part of a rotating collection When an item is checked-in a message will tell you it's part of a rotating collection, even if it's not true. Test plan: Make sure the message appears only when needed. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: circ/returns.pl | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 10 18:39:12 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jun 2016 16:39:12 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-58-g113adf6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 113adf68e56b6233b44a2b7a9b5dc60f6c4de0b7 (commit) from 8794348ccbb156ddd1ec53702b5afebea1747976 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 113adf68e56b6233b44a2b7a9b5dc60f6c4de0b7 Author: Jacek Ablewicz Date: Wed Jun 8 10:46:18 2016 +0200 Bug 16678: updatedatabase.pl 3.23.00.006 DB upgrade crashes if subscription_numberpatterns.numberingmethod contains parentheses It seems that if subscription_numberpatterns.numberingmethod contains parentheses, updatedatabase.pl crashes when running the 3.23.00.006 DB upgrade snippet, with the following error: [Mon Jun 6 09:06:54 2016] updatedatabase.pl: Unmatched ( in regex; marked by <-- HERE in m/ ( <-- HERE / at /home/koha/kohaclone/installer/data/mysql/updatedatabase.pl line 11498. Steps to reproduce: 1/ Have a Koha DB version<3.23.00.006 2/ Create a subscription numbering with parentheses in it: ie "Vol. (Month, Year)" with pattern Vol. {X} ({Y}, {Z}) 3/ Add some serials using that numbering method so that serialseq is filled in DB: ie "Vol. 16 (February, 2015)" 4/ Run the updatedatabase.pl script either from the cli or just start the webinstaller 5/ The error is produced To test: 1/ apply patch 2/ try to reproduce this issue once again, should be fixed now 3/ have a look at the code, make sure the changes are consistent Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Note: I have not tested the patch, but the diff looks good. Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/updatedatabase.pl | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 10 18:41:39 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jun 2016 16:41:39 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-60-g687a7e2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 687a7e22b6c630c3bbc06e1845854514f6fea5b0 (commit) via c4f388f64966f2202e9f3e3c16dad5cef3dbe0ac (commit) from 113adf68e56b6233b44a2b7a9b5dc60f6c4de0b7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 687a7e22b6c630c3bbc06e1845854514f6fea5b0 Author: Jonathan Druart Date: Tue Jun 7 11:48:46 2016 +0100 Bug 16441: Fix Letters.t These tests were wrong, but the package variable used to cache the letters hid the problem. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit c4f388f64966f2202e9f3e3c16dad5cef3dbe0ac Author: Jonathan Druart Date: Wed May 4 19:43:43 2016 +0100 Bug 16441: Do not use a package variable to cache C4::Letters::getletter C4::Letters::getletter use a package variable (%letter) to cache letter returned by the subroutine. I have not found any direct issues caused by that but it is safer to remove it. It won't be a big deal to hit the DBMS to get a valid letter when needed. No test plan here, just confirm that the changes make sense. Signed-off-by: Srdjan Signed-off-by: Marcel de Rooy Confirm that performance loss is just a millisecond or so per subsequent call of getletter. Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Letters.pm | 11 ----------- t/db_dependent/Letters.t | 4 ++-- 2 files changed, 2 insertions(+), 13 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 10 18:43:47 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jun 2016 16:43:47 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-62-g6a706b8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6a706b86a273672b1e1ca3f1456fde08dd7a0da2 (commit) via 52b1b8eae1136af1e901560214a641494acaf577 (commit) from 687a7e22b6c630c3bbc06e1845854514f6fea5b0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6a706b86a273672b1e1ca3f1456fde08dd7a0da2 Author: Marcel de Rooy Date: Wed May 11 15:47:46 2016 +0200 Bug 16428: [QA Follow-up] Useless call to GetMarcStructure in _build_default_values_for_mod_marc The routine calls GetMarcStructure and does not use its return value after all. Test plan: Run t/db_dependent/Items.t Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 52b1b8eae1136af1e901560214a641494acaf577 Author: Jonathan Druart Date: Tue May 3 11:03:52 2016 +0100 Bug 16428: Use the biblio framework to know if a field is mapped The subroutine _build_default_values_for_mod_marc takes the frameworkcode in parameter, but ModItemFromMarc did not pass it. It uses it to know if a field is mapped or not to a Koha field (C4::Koha::IsKohaFieldLinked). Consequently the default framework ("") was always used. This bug has been found working on bug 13074 and has been put on a separate bug report to ease the backport. Test plan: Without this change, the tests added by bug 16428 won't pass Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Items.pm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 10 18:45:16 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jun 2016 16:45:16 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-64-gaf59b66 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via af59b669413539606f10652230e5f96d43337cb5 (commit) via 27254de06d8ae6682b395be48d6ba02b69f9e917 (commit) from 6a706b86a273672b1e1ca3f1456fde08dd7a0da2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit af59b669413539606f10652230e5f96d43337cb5 Author: Jonathan Druart Date: Wed May 11 13:04:38 2016 +0100 Bug 16465: Fix typo issues vs checkouts Test plan: Confirm the wording is correct Signed-off-by: Srdjan Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit 27254de06d8ae6682b395be48d6ba02b69f9e917 Author: Jonathan Druart Date: Wed May 11 12:57:47 2016 +0100 Bug 16465: discharge - Add a title tag at the OPAC Test plan: Confirm that the opac-discharge.pl has now a title Signed-off-by: Srdjan Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/members/discharge.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-discharge.tt | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 10 18:49:28 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jun 2016 16:49:28 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-66-g3948102 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 3948102f2ad6e5382a31a00df0c8f52def3daf58 (commit) via 7d4844e171b1319b90e7bd73510bd97c2acbf635 (commit) from af59b669413539606f10652230e5f96d43337cb5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3948102f2ad6e5382a31a00df0c8f52def3daf58 Author: Jonathan Druart Date: Wed May 25 18:09:27 2016 +0100 Bug 16578: Same fix for the staff interface Signed-off-by: Bernardo Gonzalez Kriegel Works as first patch No errors Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 7d4844e171b1319b90e7bd73510bd97c2acbf635 Author: Tomas Cohen Arazi Date: Tue May 24 14:28:44 2016 -0300 Bug 16578: Fix wide character errors in opac-export.pl This simple patch fixes wide character warning raised by opac-export.pl when 'MARC (Unicode/UTF-8)' and 'MARC (Unicode/UTF-8, Standard)' formats are chosen for downloading records. To test: - Have records indexed - Open your OPAC logs: $ tail -f /var/log/koha/kohadev/opac-error.log - Open the detail page in the opac for a record - Choose Save record > MARC (Unicode/UTF-8) => FAIL: opac-export.pl: Wide character in print at /home/vagrant/kohaclone/opac/opac-export.pl line 116., referer: http://localh... - Choose Save record > MARC (Unicode/UTF-8, Standard) => FAILE opac-export.pl: Wide character in print... - Apply the patch - Choose Save record > MARC (Unicode/UTF-8) => SUCCESS: No warnings raised. - Choose Save record > MARC (Unicode/UTF-8, Standard) => SUCCESS: No warnings raised. - Sign off :-D Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: catalogue/export.pl | 3 +++ opac/opac-export.pl | 13 ++++++++----- 2 files changed, 11 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 10 18:51:12 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jun 2016 16:51:12 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-67-g04e5c26 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 04e5c2630c6e3b2962498b932bd8967478c940e5 (commit) from 3948102f2ad6e5382a31a00df0c8f52def3daf58 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 04e5c2630c6e3b2962498b932bd8967478c940e5 Author: Jonathan Druart Date: Thu May 26 10:55:09 2016 +0100 Bug 16596: Display library and patron category descriptions instead of their code Test plan: On circ/circulation-home.pl and reserve/request.pl, search for patrons The descriptions for the libraries and patron categories should be displayed. Signed-off-by: Bernardo Gonzalez Kriegel On top of Bug 13336 Works as described, now descriptions instead of codes. No errors Signed-off-by: Nick Clemens https://bugs.koha-community.org/show_bug.cgi?id=16455 Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/includes/circ-patron-search-results.inc | 4 ++-- koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 1 + koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 2 ++ 3 files changed, 5 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 10 18:57:10 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jun 2016 16:57:10 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-68-g5e6da05 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 5e6da05b101e014d2b2ecc80b4fc4474c54503bc (commit) from 04e5c2630c6e3b2962498b932bd8967478c940e5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5e6da05b101e014d2b2ecc80b4fc4474c54503bc Author: Mark Tompsett Date: Mon May 30 12:16:36 2016 -0400 Bug 16618: 00-load.t prematurely stops all testing Rather than add/remove regular expressions to skip modules (like bug 9054), encapsulate the decision logic into a separate function. Currently there are three libraries which trigger halts: Koha::NorwegianDB (which was already there) Koha::ElasticSearch::Indexer Koha::SearchEngine::Elasticsearch::Search TEST PLAN --------- 1) prove t/00-load.t -- should barf horribly on Catmandu stuff if not: sudo apt-get remove libcatmandu-marc-perl then repeat step. 2) apply patch 3) prove t/00-load.t -- should not barf horribly 4) run koha qa test tools NOTE: The four optional modules for Koha::NorwegianDB are listed in the PerlDependencies.pm, while there is no mention of Catmandu libraries at all there. This may be another bug which needs fixing. TECH NOTES (for ideas of how to tinker around): These three things should trigger the three module cases: sudo apt-get remove libcatmandu-marc-perl sudo apt-get remove libcatmandu-store-elasticsearch-perl sudo apt-get remove libconvert-basen-perl You probably had koha-perldeps installed before, so the following wil mostly fix: sudo apt-get install koha-perldeps libcatmandu-marc-perl And in case you didn't have elastic search stuff installed: echo deb http://packages.elastic.co/elasticsearch/1.7/debian stable main | sudo tee /etc/apt/sources.list.d/elasticsearch.list wget -O- https://packages.elastic.co/GPG-KEY-elasticsearch | sudo apt-key add - sudo apt-get update cd ~ wget http://debian.koha-community.org/koha/otherthings/elasticsearch_deps.tar.gz tar xvf elasticsearch_deps.tar.gz cd es_deps sudo dpkg i lib* sudo apt-get install -f Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: t/00-load.t | 43 ++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 40 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 10 18:59:28 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jun 2016 16:59:28 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-69-g0233848 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 023384811f54f18fbe585431c49b80cfc20e58dd (commit) from 5e6da05b101e014d2b2ecc80b4fc4474c54503bc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 023384811f54f18fbe585431c49b80cfc20e58dd Author: Jonathan Druart Date: Tue Jun 7 12:29:33 2016 +0100 Bug 16668: Fix t/Ris.t tests Caused by bug 16442. Now we need to mock the marcflavour pref Test plan: prove t/Ris.t should return green Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Ris.pm | 2 ++ t/Ris.t | 8 ++++---- 2 files changed, 6 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 10 19:03:08 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jun 2016 17:03:08 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-70-gb9b4eeb Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b9b4eeb849dcb52053a98440e1d8fb02011a9005 (commit) from 023384811f54f18fbe585431c49b80cfc20e58dd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b9b4eeb849dcb52053a98440e1d8fb02011a9005 Author: Galen Charlton Date: Tue Jun 7 01:42:59 2016 +0000 Bug 16675: fix breakage of t/Languages.t This patch fixes test breakage introduced by the patch for bug 16088, which added caching of getlanguages(). Upon inspection, it looks like the patch for 16088 does not introduce a regression on bug 10560, so this patch adds a couple cache-clearings. To test ------- [1] Verify that t/Languages.t passes. Signed-off-by: Galen Charlton Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: t/Languages.t | 3 +++ 1 file changed, 3 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 10 19:05:08 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jun 2016 17:05:08 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-71-gf976262 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f97626271ecf7ea90724cd7b131cf4eabb883c23 (commit) from b9b4eeb849dcb52053a98440e1d8fb02011a9005 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f97626271ecf7ea90724cd7b131cf4eabb883c23 Author: Jonathan Druart Date: Sat Jun 4 12:26:27 2016 +0100 Bug 16649: Make OpenLibrarySearch test pass even if launches offline Test plan: prove t/OpenLibrarySearch.t should return green even if you are offline Signed-off-by: Srdjan Signed-off-by: Mirko Tietgen Signed-off-by: Galen Charlton Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: t/OpenLibrarySearch.t | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 10 19:06:28 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jun 2016 17:06:28 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-72-g40f3d43 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 40f3d43f46cccb5bb8077aae64684c5c5a0ed781 (commit) from f97626271ecf7ea90724cd7b131cf4eabb883c23 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 40f3d43f46cccb5bb8077aae64684c5c5a0ed781 Author: Galen Charlton Date: Tue Jun 7 00:44:07 2016 +0000 Bug 16647: update debian/control for 16.* This patch updates debian/control* to match what was used for building the 16.05.00 packages, and includes changes to: - specify a floor for the Swagger2 version - add dep on libio-socket-ip-perl, which is needed for the package to work on Debian Wheezy - suggest libwww-youtube-download-perl Signed-off-by: Galen Charlton Signed-off-by: Hector Castro Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: debian/control | 12 +++++++----- debian/control.in | 3 ++- 2 files changed, 9 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 10 19:08:10 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jun 2016 17:08:10 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-73-ga4c44b9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a4c44b9f643ab9a31c4025f6001a823fdcbb8101 (commit) from 40f3d43f46cccb5bb8077aae64684c5c5a0ed781 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a4c44b9f643ab9a31c4025f6001a823fdcbb8101 Author: Jonathan Druart Date: Wed Jun 8 14:52:04 2016 +0100 Bug 16695: Require Exception::Class 1.38 instead of 1.39 Looking at http://cpansearch.perl.org/src/DROLSKY/Exception-Class-1.40/Changes there is no need to require 1.39 Signed-off-by: Jacek Ablewicz Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Installer/PerlDependencies.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 10 19:15:52 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jun 2016 17:15:52 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-77-gf17897f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f17897fb105fccb7edbf60b24c7d6e5362351cb2 (commit) via ff9de4138a7544f08f835acae93aca124c8efa89 (commit) via f863e478b994f2631d79821473c773099dc78172 (commit) via 255596ae6c483caf5746745f3656b56e0ea011b4 (commit) from a4c44b9f643ab9a31c4025f6001a823fdcbb8101 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f17897fb105fccb7edbf60b24c7d6e5362351cb2 Author: Kyle M Hall Date: Fri Jun 10 17:15:21 2016 +0000 Bug 10459 - DBRev 16.06.00.002 Signed-off-by: Kyle M Hall commit ff9de4138a7544f08f835acae93aca124c8efa89 Author: Jonathan Druart Date: Tue Jun 7 10:20:53 2016 +0100 Bug 10459: Add tests for borrowers.updated_on Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall commit f863e478b994f2631d79821473c773099dc78172 Author: Mark Tompsett Date: Wed May 25 21:57:34 2016 -0400 Bug 10459 renamed timestamp to updated_on Signed-off-by: Joy Nelson Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall commit 255596ae6c483caf5746745f3656b56e0ea011b4 Author: Marcel de Rooy Date: Mon Nov 10 14:17:40 2014 +0100 Bug 10459: Borrowers should have a timestamp This patch adds a timestamp column to the borrowers table in kohastructure and updatedatabase. (And also to the deletedborrowers table.) A timestamp may be useful in synchronizing with external systems (among other reasons). Test plan: Run updatestructure on an existing database, or install a new one. Verify that the borrowers table has a timestamp now. Signed-off-by: Marcel de Rooy Tested updatestructure and running kohastructure.sql. Passed t/db_dependent/Members.t. updatedatabase.pl did not apply. I edited and then run it. Columns were added as expected. Signed-off-by: Marc Veron Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Mark Tompsett Signed-off-by: Joy Nelson Bug 10459: Follow up to update to atomic update methodology Signed-off-by: Bernardo Gonzalez Kriegel New column created, no errors. Signed-off-by: Mark Tompsett Signed-off-by: Joy Nelson Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/kohastructure.sql | 2 ++ installer/data/mysql/updatedatabase.pl | 32 ++++++++++++++++++++++++++------ t/db_dependent/Patrons.t | 15 +++++++++++++-- 4 files changed, 42 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 10 19:31:52 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jun 2016 17:31:52 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-80-g4f30671 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 4f3067184d7dd3666d404a2165d72755cb0b227d (commit) via bb6e70fe7d4ba530fe64179fe6fde4d6b4ec5e35 (commit) via 90307bcbfaf4c2c8907be94eabca249ac173442e (commit) from f17897fb105fccb7edbf60b24c7d6e5362351cb2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4f3067184d7dd3666d404a2165d72755cb0b227d Author: Jonathan Druart Date: Wed Jun 8 15:32:31 2016 +0100 Bug 16492: Add a FIXME to explain the possible problem with no_set_userenv Signed-off-by: Kyle M Hall commit bb6e70fe7d4ba530fe64179fe6fde4d6b4ec5e35 Author: Jonathan Druart Date: Wed May 25 17:33:00 2016 +0100 Bug 16492: Test that no_set_userenv will not set userenv if not exist yet Signed-off-by: Kyle M Hall commit 90307bcbfaf4c2c8907be94eabca249ac173442e Author: Kyle M Hall Date: Tue May 10 16:36:03 2016 +0000 Bug 16492 - Checkouts ( and possibly checkins and other actions ) will use the patron home branch as the logged in library Bug 14507 introduced the use of checkpw in C4::SIP::ILS::Patron so that non-Koha internal authentication processes would be able to function via SIP ( LDAP et al ). The problem is that checkpw changes the userenv to that of the patron! This is not usually an issue in Koha because most of the time that patron running through checkpw is the one to be logged in. Aside from SIP2 the only other area where this may be an issue is in SCO when using SelfCheckoutByLogin. Test Plan: 1) On master, check out an item to a patron via SIP2 2) Note the checkout lists the item as having been checked out from the patron's home library not matter which library is was supposed to be checked out from. 3) Apply this patch 4) Re-checkout the item 5) The item should now be checked out as if it was checked out from the library as defined in the SIP configuration file. Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 15 ++++++++++----- C4/SIP/ILS/Patron.pm | 2 +- t/db_dependent/Auth.t | 42 +++++++++++++++++++++++++++++++----------- 3 files changed, 42 insertions(+), 17 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 10 19:33:55 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jun 2016 17:33:55 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-81-g63041c1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 63041c19c98b90c934ef89634dfdaf2d6abeb762 (commit) from 4f3067184d7dd3666d404a2165d72755cb0b227d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 63041c19c98b90c934ef89634dfdaf2d6abeb762 Author: Blou Date: Mon Jul 27 16:24:46 2015 -0400 Bug 14605 - Corrects the individual fine's description When paying a fine, the description is built out of the borrower's type and title, instead of the actual fine's description. STEPS: 1) in the staff, go to a user with a fine to pay. a) if none, go to a user and Fines>>"Create manual invoice" with a distinctive description. 2) In Fines>>Pay fines, click the "Pay" button on the line of the fine. 3) This will take you a "Pay an individual fine" screen, where the description will look like "Staff Mrs", for the category and title of the borrower. Signed-off-by: Mirko Tietgen Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt | 2 +- members/pay.pl | 1 + members/paycollect.pl | 3 ++- 3 files changed, 4 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 10 19:35:30 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jun 2016 17:35:30 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-82-g43d77fd Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 43d77fdcf01906fa535482691e5eade47287ab2f (commit) from 63041c19c98b90c934ef89634dfdaf2d6abeb762 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 43d77fdcf01906fa535482691e5eade47287ab2f Author: Dimitris Antonakis Date: Sat Jun 4 16:00:47 2016 +0300 Bug 14897 - Header name mismatch in ./modules/catalogue/detail.tt We changed the detail.tt file for staff interface from Publication details to "Serial enumeration / chronology" to match the cataloguing editor. Signed-off-by: Joy Nelson Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 10 19:36:43 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jun 2016 17:36:43 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-83-ge9d6ac9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e9d6ac9478606d9d123a22635719b99d985b9538 (commit) from 43d77fdcf01906fa535482691e5eade47287ab2f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e9d6ac9478606d9d123a22635719b99d985b9538 Author: Owen Leonard Date: Thu May 26 12:29:38 2016 -0400 Bug 15676 - Actions in pending offline circulation actions are not translatable This patch modifies the offline circulation transaction processing page so that English strings describing actions are processed in the template rather than being output directly from the script. To test, apply the patch and create an offline circulation file containing at least one checkout, one check-in, and one payment. - Upload the file and choose 'Add to offline circulation queue.' - View pending offline circulation actions - In the list of pending actions, the actions column should show "Check out" instead of "issue," "Check in" instead of "return," and "Payment" instead of "payment." Strings appear as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/offline_circ/list.tt | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 10 19:37:40 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jun 2016 17:37:40 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-84-g593dee4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 593dee4ea02971f8932d15fe1ba4dc157a379bac (commit) from e9d6ac9478606d9d123a22635719b99d985b9538 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 593dee4ea02971f8932d15fe1ba4dc157a379bac Author: Marc V?ron Date: Mon May 23 14:16:02 2016 +0200 Bug 16560: Translatability: Issues with "The entered " in opac-memberentry.tt This patch fixes two splitted sentences to avoid translation issues: The entered card number is the wrong length. The entered card number is already in use. To test: Apply patch and verify that html in the 2 that are changed is correct and that they are not splitted by a-tags. Note: I could not figure out under which conditions this code displays in the OPAC self registration form. Signed-off-by: Fr?d?ric Demians Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 10 19:38:57 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jun 2016 17:38:57 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-85-g8631eba Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 8631ebaf9f634976b076958707af355baf78cc2f (commit) from 593dee4ea02971f8932d15fe1ba4dc157a379bac (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8631ebaf9f634976b076958707af355baf78cc2f Author: Marc V?ron Date: Sat May 28 09:44:40 2016 +0200 Bug 16589 - Quote of the day: Fix upload with csv files associated to LibreOffice Calc To reproduce: - Install LibreOffice and make sure that csv files are associated to Calc (Note: tested with Firefox 46.0.1 on Windows 8) - Go to Home > Tools > Quote editor > Quote uploader - Try to upload a valid CSV (e.g. Example from Bug 15684) Result: File can not be uploaded (Incorrect filetype: application/vnd.sun.xml.calc) To test: - Apply patch - Try to upload again Expected result: Quotes are imported. Signed-off-by: Fr?d?ric Demians Can't reproduce on a Mac but get it fails on a Windows Box: fixed with this patch. Signed-off-by: Jonathan Druart Can't recreate on debian but the fix looks safe. Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes-upload.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 10 19:40:41 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jun 2016 17:40:41 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-87-gf38a992 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f38a9927a3d27709173564848bda4a4a61abeadb (commit) via ce979300168fc7a885463a1a2be519562319844a (commit) from 8631ebaf9f634976b076958707af355baf78cc2f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f38a9927a3d27709173564848bda4a4a61abeadb Author: Fridolin Somers Date: Fri May 27 10:50:00 2016 +0200 Bug 16608 - Missing entity nbsp in some XML files The special character "non breaking space"   is not contained in XML syntax by default. So we add it in the file header : ]> Even if the source code files do no contain this character, it can be that translated files contain it. French for example "Titre :". This entity is missing in all files in koha-tmpl/intranet-tmpl/prog/en/data/ and in some files of koha-tmpl/intranet-tmpl/prog/en/xslt. Test plan : - generate French templates: cd misc/translator ./translate install fr-FR cd ../.. - run test: prove -v t/00-valid-xml.t you get failing error message - apply this patch - translate again - run test again: it passes Signed-off-by: Bernardo Gonzalez Kriegel Works as described following test plan Tes pass, no errors. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit ce979300168fc7a885463a1a2be519562319844a Author: Fridolin Somers Date: Fri May 27 10:46:44 2016 +0200 Bug 16608 - Add xsd extension to t/00-valid-xml.t Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/data/marc21_field_006.xml | 3 +++ koha-tmpl/intranet-tmpl/prog/en/data/marc21_field_008.xml | 3 +++ koha-tmpl/intranet-tmpl/prog/en/data/marc21_field_CF.xsd | 3 +++ koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MADS.xsl | 3 +++ koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetDetail.xsl | 3 +++ koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslimUtils.xsl | 3 +++ .../intranet-tmpl/prog/en/xslt/UNIMARCslim2intranetResults.xsl | 3 +++ t/00-valid-xml.t | 2 +- 8 files changed, 22 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 10 19:41:56 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jun 2016 17:41:56 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-88-g740cb37 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 740cb37e94d80a8beb41710f5e57d6e4a46fc17a (commit) from f38a9927a3d27709173564848bda4a4a61abeadb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 740cb37e94d80a8beb41710f5e57d6e4a46fc17a Author: Marcel de Rooy Date: Fri May 27 14:02:42 2016 +0200 Bug 16609: Catch warning from Koha::Hold in Hold.t Before this patch, the suspend step triggers a warn from Koha::Hold. Now we catch it. Test plan: Run the test. Do not see the warning about unable to suspend. Signed-off-by: Marcel de Rooy NOTE: Nice clean up! Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Hold.t | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 10 19:42:48 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jun 2016 17:42:48 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-89-g2bff91e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2bff91eb4e733a5c658e17fb93f13497768ba2e6 (commit) from 740cb37e94d80a8beb41710f5e57d6e4a46fc17a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2bff91eb4e733a5c658e17fb93f13497768ba2e6 Author: Tomas Cohen Arazi Date: Sun Jun 5 08:46:06 2016 -0300 Bug 16667: Unused variable and function call in circulation.pl This patch removes an unused occurence of the $branches variable. Probably a leftover from a recent rewrite. To test: - Run: $ git grep '$branches' circ/circulation.pl => FAIL: Only on occurence of the variable - Apply the patch - Run: $ git grep '$branches' circ/circulation.pl => SUCCESS: The variable has been removed - Sign off :-D Regards Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: circ/circulation.pl | 2 -- 1 file changed, 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 10 19:44:38 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jun 2016 17:44:38 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-90-g6b432d2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6b432d2b213101d2e8d0bf41fbc4a0e5b4ecb4e1 (commit) from 2bff91eb4e733a5c658e17fb93f13497768ba2e6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6b432d2b213101d2e8d0bf41fbc4a0e5b4ecb4e1 Author: Marc V?ron Date: Wed Jun 1 16:41:55 2016 +0200 Bug 16540 - Clean up opac-auth.tt for translatability This patch fixes translatability issues in opac-auth.tt (ugly translations caused by sentence splitting). It was necessary to change indentation to make the the file more readable and to make sure that changes have no side effects. The changes do not touch the overall functionallity. To test: - Review code to verify that no functionality change is introduced and to verify that the text changes make sense. - Apply patch, verify that OPAC login page behaves as before. UPDATE: Amended for comment #10 / mv Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../opac-tmpl/bootstrap/en/modules/opac-auth.tt | 152 ++++++++++---------- 1 file changed, 75 insertions(+), 77 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 10 19:46:32 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jun 2016 17:46:32 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-91-gb6979db Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b6979db41057e5a9770789fdaf43a793b69601e6 (commit) from 6b432d2b213101d2e8d0bf41fbc4a0e5b4ecb4e1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b6979db41057e5a9770789fdaf43a793b69601e6 Author: Marc V?ron Date: Mon May 23 11:20:10 2016 +0200 Bug 16563: Translatability: Issues in opac-account.tt (sentence splitting) This patch removes splitting by -tags from 2 sentences. Signed-off-by: Bernardo Gonzalez Kriegel No errors Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 10 19:47:57 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jun 2016 17:47:57 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-92-gec66ff4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ec66ff457b6f1b682f7ad7d0e4f2df6656815848 (commit) from b6979db41057e5a9770789fdaf43a793b69601e6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ec66ff457b6f1b682f7ad7d0e4f2df6656815848 Author: phette23 Date: Fri May 27 10:13:14 2016 -0700 Bug 16613: fix MARC 09X help links The 09X MARC fields, such as 099 local call number or 090 locally-assigned Library of Congress call number, all point to non-existent pages on the LC website, e.g. http://www.loc.gov/marc/bibliographic/bd090.html Test plan: - enter the advanced cataloging editor - begin to input any MARC tag of form 09X - click the help link at the bottom of the browser window => Without this patch, taken to a URL of form `'http://www.loc.gov/marc/bibliographic/bd' + tag + '.html'` which is broken because the only documentation for these tags is at https://www.loc.gov/marc/bibliographic/bd09x.html => With this patch applied, the link is correct Signed-off-by: Nicole C Engard Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 10 19:50:44 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jun 2016 17:50:44 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-93-gb0ba450 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b0ba45058ab0221838f7563f761d283c377b829d (commit) from ec66ff457b6f1b682f7ad7d0e4f2df6656815848 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b0ba45058ab0221838f7563f761d283c377b829d Author: Marc V?ron Date: Tue May 31 10:17:13 2016 +0200 Bug 16620: Translatability: Fix problem with isolated word "please" in auth.tt This patch fixes a translatability problem (syntax in different languages) with a tag-isolated word "please" in koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt To test: - Verify in code that there is no sentence spliting by a-tags (lines 80/84). Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 10 19:51:40 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jun 2016 17:51:40 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-94-g203d34a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 203d34a3ca821e409cf612c29b918745a3ea8ddb (commit) from b0ba45058ab0221838f7563f761d283c377b829d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 203d34a3ca821e409cf612c29b918745a3ea8ddb Author: Marc V?ron Date: Wed Jun 1 21:26:55 2016 +0200 Bug 16633: Translatability: Issues in tags/review.tt (sentence splitting) This patch fixes translatability issues in koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt (isolated words by sentence splitting). To test: - Review code and verify that changes make sense. Signed-off-by: Rocio Dressler Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/tags/review.tt | 30 ++++++++++---------- 1 file changed, 15 insertions(+), 15 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 10 19:56:46 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jun 2016 17:56:46 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-95-g45dce0a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 45dce0ac795357f5111db8cd81473317613bdcc1 (commit) from 203d34a3ca821e409cf612c29b918745a3ea8ddb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 45dce0ac795357f5111db8cd81473317613bdcc1 Author: Marc V?ron Date: Wed Jun 1 22:28:51 2016 +0200 Bug 16634: Translatability: Fix issue in memberentrygen.tt This patch fixes a small translatability issue in koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt The sentence following sentence was splitted by HTML tags: "Attribute value xxxxx is already in use by another patron record." To test: - Review code - Apply patch - In Admin, create a unique patron attribute type and try to give two patrons the same value for this attribute type. Signed-off-by: Rocio Dressler Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 10 19:58:33 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jun 2016 17:58:33 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-97-g4fc8b3d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 4fc8b3d6cf6453f7ff550b9fbde1a7f6315dd066 (commit) via fd152d9e95a2236a00f3cb0284bdd2aa7cca6da2 (commit) from 45dce0ac795357f5111db8cd81473317613bdcc1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4fc8b3d6cf6453f7ff550b9fbde1a7f6315dd066 Author: Marcel de Rooy Date: Mon Jun 6 10:49:06 2016 +0200 Bug 16635: [QA Follow-up] Eliminate some global package vars [1] $branch is only related to line 123 as fallback. [2] $width moved to a constant; sub width is not used. Signed-off-by: Marcel de Rooy Tested the corresponding plugin in item editor. Test t/db_dependent/Barcodes.t and Barcodes_ValueBuilder.t still pass. Signed-off-by: Kyle M Hall commit fd152d9e95a2236a00f3cb0284bdd2aa7cca6da2 Author: Mark Tompsett Date: Wed Jun 1 20:41:27 2016 -0400 Bug 16635: t/00-load.t warning from C4/Barcodes/hbyymmincr.pm According to http://perldoc.perl.org/vars.html, "our" should be a reasonable substitute for the "use vars". By declaring as "our", and removing the INIT, prove t/00-load will no longer generate a warning about INIT for the C4/Barcodes/hbyymmincr.pm module. TEST PLAN --------- 1) prove t/00-load.t -- warnings about INIT for hbyymmincr 2) prove `git grep -l hbyymmincr | grep [.]t$` -- should all run okay 3) apply patch 4) repeat steps 1 and 2 -- warning should be gone, and everything else run okay 5) run koha qa test tools Signed-off-by: Srdjan Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Barcodes/hbyymmincr.pm | 27 ++++++++++++++------------- 1 file changed, 14 insertions(+), 13 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 10 20:02:30 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jun 2016 18:02:30 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-101-g1fda410 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 1fda4105a8a0f1e2165e27cea8314b578196dba2 (commit) via 7f4682df0dfa460c0e2ef9117e032165a45d6e79 (commit) via 5361440f6538127c8c3ec61d963d5f0692c64a71 (commit) via b4479624de2010fff8851732e94d086b2cca6921 (commit) from 4fc8b3d6cf6453f7ff550b9fbde1a7f6315dd066 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1fda4105a8a0f1e2165e27cea8314b578196dba2 Author: Kyle M Hall Date: Fri Jun 10 18:02:14 2016 +0000 Bug 16636 [QA Followup] - Move tests to t/External Signed-off-by: Kyle M Hall commit 7f4682df0dfa460c0e2ef9117e032165a45d6e79 Author: Marcel de Rooy Date: Fri Jun 10 10:31:34 2016 +0200 Bug 16636: [QA Follow-up] Move External_BakerTaylor.t to t When we mock the preferences completely now, we do not need db access anymore. Test plan: Run the test without exporting KOHA_CONF. The test passes with some warns about koha-conf.xml. If you point KOHA_CONF to etc/koha-conf.xml, you have no warns. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 5361440f6538127c8c3ec61d963d5f0692c64a71 Author: Marcel de Rooy Date: Fri Jun 10 09:30:51 2016 +0200 Bug 16636: [QA Follow-up] Make BakerTaylor plack safe Initialize file level lexicals each call. Do not call _initialize outside the module. Adjust test by mocking preferences. Test plan: Run t/db_dependent/External_BakerTaylor.t. Signed-off-by: Marcel de Rooy Tested module with trivial script under Plack/memcached by toggling the associated preferences. Signed-off-by: Kyle M Hall commit b4479624de2010fff8851732e94d086b2cca6921 Author: Mark Tompsett Date: Wed Jun 1 20:43:30 2016 -0400 Bug 16636: t/00-load.t warning from C4/External/BakerTaylor.pm Since the tests are expecting an initialize function, the initialize call was just moved outside of the INIT block. TEST PLAN --------- 1) prove t/00-load.t -- warnings about INIT for BakerTaylor 2) prove `git grep -l BakerTaylor | grep [.]t$` -- should all run okay 3) apply patch 4) repeat steps 1 and 2 -- warning should be gone, and everything else run okay 5) run koha qa test tools Signed-off-by: Srdjan Signed-off-by: Florent Mara NOTE: Tweaked test plan based on comment #4, Added sign off based on comment #6. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/External/BakerTaylor.pm | 23 ++++++++++----- t/External/BakerTaylor.t | 33 +++++++++++++++++++++ t/{External_Syndetics.t => External/Syndetics.t} | 0 t/db_dependent/External_BakerTaylor.t | 34 ---------------------- 4 files changed, 48 insertions(+), 42 deletions(-) create mode 100755 t/External/BakerTaylor.t rename t/{External_Syndetics.t => External/Syndetics.t} (100%) delete mode 100755 t/db_dependent/External_BakerTaylor.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 10 20:04:56 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jun 2016 18:04:56 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-102-gc91b16b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via c91b16bd9e82588c7625f69e37d6435dd378915e (commit) from 1fda4105a8a0f1e2165e27cea8314b578196dba2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c91b16bd9e82588c7625f69e37d6435dd378915e Author: Mark Tompsett Date: Sat Jun 4 11:11:00 2016 -0400 Bug 16637: Dependency for C4::Tags not listed Added optional dependency, so as to explain why testing explodes when the Enhanced Content system preference TagsExternalDictionary is set. It is optional, because not only does TagsExternalDictionary have to be set, but TagsEnabled must be 'Allow'. Also tweaked C4/Tags.pm to ignore TagsExternalDictionary, if Lingua::Ispell is not installed. A warning is given. TEST PLAN --------- 1) Set the Enhanced Content system preference TagsExternalDictionary to /usr/bin/ispell 2) sudo apt-get install liblingua-ispell-perl -- should be a new install 3) prove t/db_dependent/Tags.t -- should work fine 4) sudo apt-get remove liblingua-ispell-perl 5) prove t/db_dependent/Tags.t -- should explode 6) Clear the Enhanced Content system preference TagsExternalDictionary 7) prove t/db_dependent/Tags.t -- should work fine 8) apply patch 9) prove t/db_dependent/Tags.t -- should work fine 10) Set the Enhanced Content system preference TagsExternalDictionary to /usr/bin/ispell 11) prove t/db_dependent/Tags.t -- should work, with warning. 12) sudo apt-get install liblingua-ispell-perl 13) prove t/db_dependent/Tags.t -- should work fine 14) run koha qa test tools. Signed-off-by: Marcel de Rooy Post-hackfest hotel Olympia lobby signoff. Kalimera! Works as expected. At this moment the Tags.t test does not need the database btw, but the module should have much more test coverage. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Installer/PerlDependencies.pm | 5 +++++ C4/Tags.pm | 5 +++++ 2 files changed, 10 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 10 20:06:19 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jun 2016 18:06:19 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-103-g0427dfe Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 0427dfe8ee65e87e9442af16d4069afdfcde2801 (commit) from c91b16bd9e82588c7625f69e37d6435dd378915e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0427dfe8ee65e87e9442af16d4069afdfcde2801 Author: Liz Rea Date: Fri Nov 20 11:29:44 2015 +1300 Bug 15213 - Fix tools sidebar to highlight Patron lists when in that module To test: Add some patron lists, navigate through the lists interface and make sure that while you are in the module, that Patron lists is highlighted on the sidebar. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Amended patch: fix alignement Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 10 20:07:57 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jun 2016 18:07:57 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-104-g9066ae1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 9066ae153b15ae49b7d5832b331eed31c32ed583 (commit) from 0427dfe8ee65e87e9442af16d4069afdfcde2801 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9066ae153b15ae49b7d5832b331eed31c32ed583 Author: Claire Gravely Date: Sat Jun 4 13:30:30 2016 +0200 Bug 16165 - Include link to ILS-DI documentation page in ILS-DI system preference There is no clue in the system preference about the nice ILS-DI documentation once you turn it on. We should include a note and the link, similar to how we do it for the web self checkout. Test plan: Syspreference ILS-DI should now include URL in description. Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/admin/preferences/web_services.pref | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 10 20:09:52 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jun 2016 18:09:52 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-106-gdde0e01 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via dde0e0150344cecfcad5c81df3d00f216dbecbbb (commit) via d753644c2f09f6500b3c1690593f1e41922f0677 (commit) from 9066ae153b15ae49b7d5832b331eed31c32ed583 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit dde0e0150344cecfcad5c81df3d00f216dbecbbb Author: Jonathan Druart Date: Mon Jun 6 20:46:01 2016 +0100 Bug 16289: Refactore code and add tests Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit d753644c2f09f6500b3c1690593f1e41922f0677 Author: Karl Holten Date: Mon Apr 18 14:17:40 2016 -0500 Bug 16289: Abbreviated formatting for numbering patterns To test: 1) Go to Serials -> Manage numbering patterns 2) Create .New Numbering Pattern. 3) Type in a name of 'Day, Month, Season' and a numbering formula of '{X} {Y} {Z}'. 4) Set up the X field as following: add 1, every 1, set back to 1, when more than 30. 5) Select the formatting for X. There should be six options available instead of the original three. Use the formatting 'Name of Day (abbreviated)'. 5) Set up the Y field to add 1 every 30 reset back to 1 when more than 12. Use the formatting option 'Name of month (abbreviated)'. 6) Set up the Z field to add 1 every 90 reset back to 1 when more than 4. Use the formatting option 'Name of season (abbreviated)'. 8) Select a frequency of 1/day. 9) Select a first issue publication date of Jan 1, 2016. 10) Set X to begin with 5 and have an inner counter of 5. Set Z to begin with 3 and have an inner counter of 10. 11) Click the 'Test Pattern' button. 12) Abbreviated versions of the day, month and season should appear in the test pattern. Signed-off-by: sonia bouis Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Serials.pm | 19 +++-- .../prog/en/modules/serials/subscription-add.tt | 3 + .../modules/serials/subscription-numberpatterns.tt | 15 ++++ t/Serials/GetNextSeq.t | 76 ++++++++++---------- 4 files changed, 71 insertions(+), 42 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 10 20:17:35 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jun 2016 18:17:35 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-107-g71aa7d9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 71aa7d9ecfa5c5fa07e02dbb479c78f304338988 (commit) from dde0e0150344cecfcad5c81df3d00f216dbecbbb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 71aa7d9ecfa5c5fa07e02dbb479c78f304338988 Author: Owen Leonard Date: Thu May 26 07:26:33 2016 -0400 Bug 16592 - Use Bootstrap modal for MARC and Card preview on acquisitions receipt summary page This patch replaces Greybox modals on the acquisitions receipt summary page with Bootstrap modals. To test, apply the patch and go to Acquisitions -> Invoices -> View an invoice -> Go to receipt page. - In the list of pending orders, test the "MARC" and "Card" links for various titles. Each should trigger a Bootstrap modal with the correct content. - Repeat the same tests in the list of already received orders. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/acqui/parcel.tt | 33 ++++++++++++++++++-- 1 file changed, 30 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Jun 14 18:35:15 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 14 Jun 2016 16:35:15 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-108-g42cd9ca Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 42cd9ca1447f4d576d9f1ad51e275e70c8bf9249 (commit) from 71aa7d9ecfa5c5fa07e02dbb479c78f304338988 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 42cd9ca1447f4d576d9f1ad51e275e70c8bf9249 Author: Kyle M Hall Date: Tue Jun 14 16:35:49 2016 +0000 Bug 10459 - Update Schema Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/Schema/Result/Borrower.pm | 18 ++++++++++++++++-- Koha/Schema/Result/Deletedborrower.pm | 18 ++++++++++++++++-- 2 files changed, 32 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jun 15 09:14:47 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 15 Jun 2016 07:14:47 +0000 Subject: [koha-commits] main Koha release repository branch 16.05.x updated. v16.05.00-93-ga8534a4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 16.05.x has been updated via a8534a4da728030d51647285cfb30b3f25a835c5 (commit) via 903d0432c3dfc84236d1ff40606444e3a56c845b (commit) via 012de8ccdf0365601003a6ff10479782423f6c05 (commit) via 358e7a6d61d49c3ad8b57e2ad952f3fd9e4b83de (commit) via fcbb59f25e25d86cc5be82595d330aa1b534b3cc (commit) via af029c8655eb90e604286118ac6065851088bd57 (commit) via c8ef873ee9fe97210d00d450a19f6ad52036b400 (commit) via 9c7c4f02ddad4045fde7ecf68c03389bb6f10436 (commit) via 94d77bd9c2955f5bafa868f3e2aa375112383194 (commit) via 7fbfa01f78c79daf434a351d165d22382f13fd94 (commit) via cedc2b736e14381cc6830c6cb4b650ba19bc7719 (commit) via 98a8dca48298fd329c16831a6d5183421ceefd0d (commit) via 7f3243daec25a462d4c9244b8b7b7c8dd6f2fd3f (commit) via fe295fce2dec9626498154658bb45cd46ea09cb4 (commit) via 2abe013436c81748f3a4170ad93009eda8e79861 (commit) via 88c130eb43eacc8ce107509a6985a4d6eb4f0683 (commit) via 9d8b407d7e0fc220268c4df3a0bebe4f508eae25 (commit) via e8cca084407e888db19d13930c22e59662a9690f (commit) via 0cc550dcc3d0c05b9688bb590a827671f5f8ee95 (commit) via e6d820ade3821d7f2561babd5abfb3b29de43ace (commit) via 34f8ab6f4040aeaee2cf674a550c052bc3c1a9b8 (commit) via f13e8306299f274497a41a6df730209a76a71a04 (commit) via acc459fa1bae3b1abd13b826420bfb836a1250af (commit) via 4b3b7bbd8d6b497e17ad862737c607bcc5fd09e4 (commit) via 744b035932608a0ce3dd495765f9c249d1f527db (commit) via ac00e73077164db595432b723ee6f938e009dc7d (commit) via f69eeca6c4a7d7d4b0538e7964a0f5f190de4b4e (commit) via 57086a241e141e157d42b8af3f56ae9283d46ae9 (commit) via 700fbd0a35073dc3cef7b3e340ab806a21354ba1 (commit) via 22c1188c0ba96b1f783e9d72b81e542a506984f0 (commit) via 25c91b797afcc7bd976fd10299e0becf6c42ff34 (commit) via 213401821d56087e96da7383b1eb6ff5a97dbdad (commit) via a1f1ea03177204af1cb5dde29b5f18f339402bdb (commit) via 155d4ce1d2a90841dd37c496bcf2e3130a0b2cc0 (commit) via 7e1aeff2890e82d24e2f6473083a316355021c15 (commit) via 43002c3b0e1659edc910cae435c3715a46e80a76 (commit) via 164ffdb43c98b4d2fa193d80c48f5509294fa1ca (commit) via c5fc0fcd0e28309114c70333cb75a2aee11b35e0 (commit) via 5ce7baf937d8e7ddf56ca0ae4dde00690fe5a32c (commit) via b31ee2eaf9dd86171cac1598f3f9a611ea145f83 (commit) via 4ebfb709f6cdeb263b579f7a3538c1a1342a939a (commit) via a44040d07d24707d2cda51d989ad0fa495116608 (commit) via c63dccba27842ce92569625a03df55085bf5681a (commit) via 8e7e2c0db929fe9dab47f2cc71c353564e267850 (commit) via c0c00b80cd5aca3a0fe1903acbb03031fb654dd2 (commit) via 03d51281b079c379a2fba0caf8a9df8ec9c6d500 (commit) via 93ffd58fe32dd4e27056f5cebf18b975f3d0624b (commit) via 6ff159e214a2ebf904ff7f1b77f0f75162f8afe8 (commit) via 259fe9947b73023a22aceda2b7f7ad357500884f (commit) via 2729f038c34b5c4f0b713738c9bf4a94068f1b43 (commit) via e242625721b0dcd68cd7b3408ef9da5d367a878d (commit) via 020d755ed061cfc94ca12eace6fae7388cc89e3e (commit) via 97a3f03970e1aa8d3eba5e5502f092202e43349b (commit) via b7a0322258ad534ea8e5af34cb0581b0b5f174e8 (commit) via df36beeffd1be584478cc85764b55959ccf75da7 (commit) via a987ff3ba92e1558e11a63335895749b5efd1689 (commit) via 12f6f9438a426a12c408b7d27e1af2e0cd52d1a3 (commit) via 2d1488998758ddc7d558eaaf1f6acac07dff6cd7 (commit) via 316e1a672359c8ba8f065942945cfca183456e23 (commit) via 9a2c6bfde243f0fe41112fe1b651273ab091c901 (commit) via b49adab4a1c4bb08714371223572caf35460f0f4 (commit) via 14b9930b079c3f5518dce7a8cedc887790a2f27a (commit) via feabd6e38648b5f4efefd50772d78eebe6261d5c (commit) via 26afd665ecfeff6668216467cd77ac25d50f74e4 (commit) via acdc5f27a7625746d004e62f865c384c566fb2ef (commit) via 16a35fb6315567f2631ed1598031c94ef25505df (commit) via 65232361231f5006f25cc354e24b38b07f359d61 (commit) via 66c9ef12c16efeebf78e3a98be7b2ccc42d14e7a (commit) via 9f935b384fd01c863af1de195f4fe256450f4a46 (commit) via 5712275a4645d4d899815120fe79e730edf1034e (commit) via 247bd55876a4e930934419070fc926a656a0d9d7 (commit) via 5949faae071c317c029c9c89320c52d73cd7a362 (commit) via 385cf8e64100bfd18cabe1e2a5d7a37beeb4daad (commit) via 631e349ff2e751a43f9e0a426f94ab4b116ad8c7 (commit) via 10733c39399d4db48bd5a73a9c4a195531751875 (commit) via 92c08a6a4e177622a4513fa34c81dfcbec20ec57 (commit) via ddf80b2003522cc0542d4ee4f9b8e19fb7a8c4e0 (commit) via 0c4661110c467c8d11631cc627395acef941c9c9 (commit) via 300cfc1ac8ae979b737b584e303823059d34680e (commit) via 1f9e53f81c19dd56f7e77f40a05aa8433e2740d3 (commit) via 7626ecedc8c640cedd21463d90117aecad1e6a80 (commit) via d80368370258432aab4d4171b886af26442d08c1 (commit) via 326616d2bce77b245e0d38eb3df659e821130645 (commit) via 06d775c3b3e9a376bbd9e09fc4cac65d35ce7363 (commit) via 8b9812fa83c110c446b58b6b1188d67d20011430 (commit) via a85be57e1ce1d2adde6b9ee3dba55f7c5f2e06ab (commit) via a47180eb3bc0ca26a018f68ffcc4d5635f6f7789 (commit) from fa1dd408ca7714aed406ff75d3c4c55545b97cf0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a8534a4da728030d51647285cfb30b3f25a835c5 Author: Owen Leonard Date: Thu May 26 07:26:33 2016 -0400 Bug 16592 - Use Bootstrap modal for MARC and Card preview on acquisitions receipt summary page This patch replaces Greybox modals on the acquisitions receipt summary page with Bootstrap modals. To test, apply the patch and go to Acquisitions -> Invoices -> View an invoice -> Go to receipt page. - In the list of pending orders, test the "MARC" and "Card" links for various titles. Each should trigger a Bootstrap modal with the correct content. - Repeat the same tests in the list of already received orders. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 71aa7d9ecfa5c5fa07e02dbb479c78f304338988) Signed-off-by: Fr?d?ric Demians commit 903d0432c3dfc84236d1ff40606444e3a56c845b Author: Claire Gravely Date: Sat Jun 4 13:30:30 2016 +0200 Bug 16165 - Include link to ILS-DI documentation page in ILS-DI system preference There is no clue in the system preference about the nice ILS-DI documentation once you turn it on. We should include a note and the link, similar to how we do it for the web self checkout. Test plan: Syspreference ILS-DI should now include URL in description. Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 9066ae153b15ae49b7d5832b331eed31c32ed583) Signed-off-by: Fr?d?ric Demians commit 012de8ccdf0365601003a6ff10479782423f6c05 Author: Liz Rea Date: Fri Nov 20 11:29:44 2015 +1300 Bug 15213 - Fix tools sidebar to highlight Patron lists when in that module To test: Add some patron lists, navigate through the lists interface and make sure that while you are in the module, that Patron lists is highlighted on the sidebar. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Amended patch: fix alignement Signed-off-by: Kyle M Hall (cherry picked from commit 0427dfe8ee65e87e9442af16d4069afdfcde2801) Signed-off-by: Fr?d?ric Demians commit 358e7a6d61d49c3ad8b57e2ad952f3fd9e4b83de Author: Mark Tompsett Date: Sat Jun 4 11:11:00 2016 -0400 Bug 16637: Dependency for C4::Tags not listed Added optional dependency, so as to explain why testing explodes when the Enhanced Content system preference TagsExternalDictionary is set. It is optional, because not only does TagsExternalDictionary have to be set, but TagsEnabled must be 'Allow'. Also tweaked C4/Tags.pm to ignore TagsExternalDictionary, if Lingua::Ispell is not installed. A warning is given. TEST PLAN --------- 1) Set the Enhanced Content system preference TagsExternalDictionary to /usr/bin/ispell 2) sudo apt-get install liblingua-ispell-perl -- should be a new install 3) prove t/db_dependent/Tags.t -- should work fine 4) sudo apt-get remove liblingua-ispell-perl 5) prove t/db_dependent/Tags.t -- should explode 6) Clear the Enhanced Content system preference TagsExternalDictionary 7) prove t/db_dependent/Tags.t -- should work fine 8) apply patch 9) prove t/db_dependent/Tags.t -- should work fine 10) Set the Enhanced Content system preference TagsExternalDictionary to /usr/bin/ispell 11) prove t/db_dependent/Tags.t -- should work, with warning. 12) sudo apt-get install liblingua-ispell-perl 13) prove t/db_dependent/Tags.t -- should work fine 14) run koha qa test tools. Signed-off-by: Marcel de Rooy Post-hackfest hotel Olympia lobby signoff. Kalimera! Works as expected. At this moment the Tags.t test does not need the database btw, but the module should have much more test coverage. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit c91b16bd9e82588c7625f69e37d6435dd378915e) Signed-off-by: Fr?d?ric Demians commit fcbb59f25e25d86cc5be82595d330aa1b534b3cc Author: Kyle M Hall Date: Fri Jun 10 18:02:14 2016 +0000 Bug 16636 [QA Followup] - Move tests to t/External Signed-off-by: Kyle M Hall (cherry picked from commit 1fda4105a8a0f1e2165e27cea8314b578196dba2) Signed-off-by: Fr?d?ric Demians commit af029c8655eb90e604286118ac6065851088bd57 Author: Marcel de Rooy Date: Fri Jun 10 10:31:34 2016 +0200 Bug 16636: [QA Follow-up] Move External_BakerTaylor.t to t When we mock the preferences completely now, we do not need db access anymore. Test plan: Run the test without exporting KOHA_CONF. The test passes with some warns about koha-conf.xml. If you point KOHA_CONF to etc/koha-conf.xml, you have no warns. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit 7f4682df0dfa460c0e2ef9117e032165a45d6e79) Signed-off-by: Fr?d?ric Demians commit c8ef873ee9fe97210d00d450a19f6ad52036b400 Author: Marcel de Rooy Date: Fri Jun 10 09:30:51 2016 +0200 Bug 16636: [QA Follow-up] Make BakerTaylor plack safe Initialize file level lexicals each call. Do not call _initialize outside the module. Adjust test by mocking preferences. Test plan: Run t/db_dependent/External_BakerTaylor.t. Signed-off-by: Marcel de Rooy Tested module with trivial script under Plack/memcached by toggling the associated preferences. Signed-off-by: Kyle M Hall (cherry picked from commit 5361440f6538127c8c3ec61d963d5f0692c64a71) Signed-off-by: Fr?d?ric Demians commit 9c7c4f02ddad4045fde7ecf68c03389bb6f10436 Author: Mark Tompsett Date: Wed Jun 1 20:43:30 2016 -0400 Bug 16636: t/00-load.t warning from C4/External/BakerTaylor.pm Since the tests are expecting an initialize function, the initialize call was just moved outside of the INIT block. TEST PLAN --------- 1) prove t/00-load.t -- warnings about INIT for BakerTaylor 2) prove `git grep -l BakerTaylor | grep [.]t$` -- should all run okay 3) apply patch 4) repeat steps 1 and 2 -- warning should be gone, and everything else run okay 5) run koha qa test tools Signed-off-by: Srdjan Signed-off-by: Florent Mara NOTE: Tweaked test plan based on comment #4, Added sign off based on comment #6. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit b4479624de2010fff8851732e94d086b2cca6921) Signed-off-by: Fr?d?ric Demians commit 94d77bd9c2955f5bafa868f3e2aa375112383194 Author: Marcel de Rooy Date: Mon Jun 6 10:49:06 2016 +0200 Bug 16635: [QA Follow-up] Eliminate some global package vars [1] $branch is only related to line 123 as fallback. [2] $width moved to a constant; sub width is not used. Signed-off-by: Marcel de Rooy Tested the corresponding plugin in item editor. Test t/db_dependent/Barcodes.t and Barcodes_ValueBuilder.t still pass. Signed-off-by: Kyle M Hall (cherry picked from commit 4fc8b3d6cf6453f7ff550b9fbde1a7f6315dd066) Signed-off-by: Fr?d?ric Demians commit 7fbfa01f78c79daf434a351d165d22382f13fd94 Author: Mark Tompsett Date: Wed Jun 1 20:41:27 2016 -0400 Bug 16635: t/00-load.t warning from C4/Barcodes/hbyymmincr.pm According to http://perldoc.perl.org/vars.html, "our" should be a reasonable substitute for the "use vars". By declaring as "our", and removing the INIT, prove t/00-load will no longer generate a warning about INIT for the C4/Barcodes/hbyymmincr.pm module. TEST PLAN --------- 1) prove t/00-load.t -- warnings about INIT for hbyymmincr 2) prove `git grep -l hbyymmincr | grep [.]t$` -- should all run okay 3) apply patch 4) repeat steps 1 and 2 -- warning should be gone, and everything else run okay 5) run koha qa test tools Signed-off-by: Srdjan Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit fd152d9e95a2236a00f3cb0284bdd2aa7cca6da2) Signed-off-by: Fr?d?ric Demians commit cedc2b736e14381cc6830c6cb4b650ba19bc7719 Author: Marc V?ron Date: Wed Jun 1 22:28:51 2016 +0200 Bug 16634: Translatability: Fix issue in memberentrygen.tt This patch fixes a small translatability issue in koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt The sentence following sentence was splitted by HTML tags: "Attribute value xxxxx is already in use by another patron record." To test: - Review code - Apply patch - In Admin, create a unique patron attribute type and try to give two patrons the same value for this attribute type. Signed-off-by: Rocio Dressler Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 45dce0ac795357f5111db8cd81473317613bdcc1) Signed-off-by: Fr?d?ric Demians commit 98a8dca48298fd329c16831a6d5183421ceefd0d Author: Marc V?ron Date: Wed Jun 1 21:26:55 2016 +0200 Bug 16633: Translatability: Issues in tags/review.tt (sentence splitting) This patch fixes translatability issues in koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt (isolated words by sentence splitting). To test: - Review code and verify that changes make sense. Signed-off-by: Rocio Dressler Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 203d34a3ca821e409cf612c29b918745a3ea8ddb) Signed-off-by: Fr?d?ric Demians commit 7f3243daec25a462d4c9244b8b7b7c8dd6f2fd3f Author: Marc V?ron Date: Tue May 31 10:17:13 2016 +0200 Bug 16620: Translatability: Fix problem with isolated word "please" in auth.tt This patch fixes a translatability problem (syntax in different languages) with a tag-isolated word "please" in koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt To test: - Verify in code that there is no sentence spliting by a-tags (lines 80/84). Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit b0ba45058ab0221838f7563f761d283c377b829d) Signed-off-by: Fr?d?ric Demians commit fe295fce2dec9626498154658bb45cd46ea09cb4 Author: phette23 Date: Fri May 27 10:13:14 2016 -0700 Bug 16613: fix MARC 09X help links The 09X MARC fields, such as 099 local call number or 090 locally-assigned Library of Congress call number, all point to non-existent pages on the LC website, e.g. http://www.loc.gov/marc/bibliographic/bd090.html Test plan: - enter the advanced cataloging editor - begin to input any MARC tag of form 09X - click the help link at the bottom of the browser window => Without this patch, taken to a URL of form `'http://www.loc.gov/marc/bibliographic/bd' + tag + '.html'` which is broken because the only documentation for these tags is at https://www.loc.gov/marc/bibliographic/bd09x.html => With this patch applied, the link is correct Signed-off-by: Nicole C Engard Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit ec66ff457b6f1b682f7ad7d0e4f2df6656815848) Signed-off-by: Fr?d?ric Demians commit 2abe013436c81748f3a4170ad93009eda8e79861 Author: Marc V?ron Date: Mon May 23 11:20:10 2016 +0200 Bug 16563: Translatability: Issues in opac-account.tt (sentence splitting) This patch removes splitting by -tags from 2 sentences. Signed-off-by: Bernardo Gonzalez Kriegel No errors Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit b6979db41057e5a9770789fdaf43a793b69601e6) Signed-off-by: Fr?d?ric Demians commit 88c130eb43eacc8ce107509a6985a4d6eb4f0683 Author: Marc V?ron Date: Wed Jun 1 16:41:55 2016 +0200 Bug 16540 - Clean up opac-auth.tt for translatability This patch fixes translatability issues in opac-auth.tt (ugly translations caused by sentence splitting). It was necessary to change indentation to make the the file more readable and to make sure that changes have no side effects. The changes do not touch the overall functionallity. To test: - Review code to verify that no functionality change is introduced and to verify that the text changes make sense. - Apply patch, verify that OPAC login page behaves as before. UPDATE: Amended for comment #10 / mv Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 6b432d2b213101d2e8d0bf41fbc4a0e5b4ecb4e1) Signed-off-by: Fr?d?ric Demians commit 9d8b407d7e0fc220268c4df3a0bebe4f508eae25 Author: Tomas Cohen Arazi Date: Sun Jun 5 08:46:06 2016 -0300 Bug 16667: Unused variable and function call in circulation.pl This patch removes an unused occurence of the $branches variable. Probably a leftover from a recent rewrite. To test: - Run: $ git grep '$branches' circ/circulation.pl => FAIL: Only on occurence of the variable - Apply the patch - Run: $ git grep '$branches' circ/circulation.pl => SUCCESS: The variable has been removed - Sign off :-D Regards Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 2bff91eb4e733a5c658e17fb93f13497768ba2e6) Signed-off-by: Fr?d?ric Demians commit e8cca084407e888db19d13930c22e59662a9690f Author: Marcel de Rooy Date: Fri May 27 14:02:42 2016 +0200 Bug 16609: Catch warning from Koha::Hold in Hold.t Before this patch, the suspend step triggers a warn from Koha::Hold. Now we catch it. Test plan: Run the test. Do not see the warning about unable to suspend. Signed-off-by: Marcel de Rooy NOTE: Nice clean up! Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 740cb37e94d80a8beb41710f5e57d6e4a46fc17a) Signed-off-by: Fr?d?ric Demians commit 0cc550dcc3d0c05b9688bb590a827671f5f8ee95 Author: Fridolin Somers Date: Fri May 27 10:50:00 2016 +0200 Bug 16608 - Missing entity nbsp in some XML files The special character "non breaking space"   is not contained in XML syntax by default. So we add it in the file header : ]> Even if the source code files do no contain this character, it can be that translated files contain it. French for example "Titre :". This entity is missing in all files in koha-tmpl/intranet-tmpl/prog/en/data/ and in some files of koha-tmpl/intranet-tmpl/prog/en/xslt. Test plan : - generate French templates: cd misc/translator ./translate install fr-FR cd ../.. - run test: prove -v t/00-valid-xml.t you get failing error message - apply this patch - translate again - run test again: it passes Signed-off-by: Bernardo Gonzalez Kriegel Works as described following test plan Tes pass, no errors. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit f38a9927a3d27709173564848bda4a4a61abeadb) Signed-off-by: Fr?d?ric Demians commit e6d820ade3821d7f2561babd5abfb3b29de43ace Author: Fridolin Somers Date: Fri May 27 10:46:44 2016 +0200 Bug 16608 - Add xsd extension to t/00-valid-xml.t Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit ce979300168fc7a885463a1a2be519562319844a) Signed-off-by: Fr?d?ric Demians commit 34f8ab6f4040aeaee2cf674a550c052bc3c1a9b8 Author: Marc V?ron Date: Sat May 28 09:44:40 2016 +0200 Bug 16589 - Quote of the day: Fix upload with csv files associated to LibreOffice Calc To reproduce: - Install LibreOffice and make sure that csv files are associated to Calc (Note: tested with Firefox 46.0.1 on Windows 8) - Go to Home > Tools > Quote editor > Quote uploader - Try to upload a valid CSV (e.g. Example from Bug 15684) Result: File can not be uploaded (Incorrect filetype: application/vnd.sun.xml.calc) To test: - Apply patch - Try to upload again Expected result: Quotes are imported. Signed-off-by: Fr?d?ric Demians Can't reproduce on a Mac but get it fails on a Windows Box: fixed with this patch. Signed-off-by: Jonathan Druart Can't recreate on debian but the fix looks safe. Signed-off-by: Kyle M Hall (cherry picked from commit 8631ebaf9f634976b076958707af355baf78cc2f) Signed-off-by: Fr?d?ric Demians commit f13e8306299f274497a41a6df730209a76a71a04 Author: Marc V?ron Date: Mon May 23 14:16:02 2016 +0200 Bug 16560: Translatability: Issues with "The entered " in opac-memberentry.tt This patch fixes two splitted sentences to avoid translation issues: The entered card number is the wrong length. The entered card number is already in use. To test: Apply patch and verify that html in the 2 that are changed is correct and that they are not splitted by a-tags. Note: I could not figure out under which conditions this code displays in the OPAC self registration form. Signed-off-by: Fr?d?ric Demians Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 593dee4ea02971f8932d15fe1ba4dc157a379bac) Signed-off-by: Fr?d?ric Demians commit acc459fa1bae3b1abd13b826420bfb836a1250af Author: Owen Leonard Date: Thu May 26 12:29:38 2016 -0400 Bug 15676 - Actions in pending offline circulation actions are not translatable This patch modifies the offline circulation transaction processing page so that English strings describing actions are processed in the template rather than being output directly from the script. To test, apply the patch and create an offline circulation file containing at least one checkout, one check-in, and one payment. - Upload the file and choose 'Add to offline circulation queue.' - View pending offline circulation actions - In the list of pending actions, the actions column should show "Check out" instead of "issue," "Check in" instead of "return," and "Payment" instead of "payment." Strings appear as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit e9d6ac9478606d9d123a22635719b99d985b9538) Signed-off-by: Fr?d?ric Demians commit 4b3b7bbd8d6b497e17ad862737c607bcc5fd09e4 Author: Dimitris Antonakis Date: Sat Jun 4 16:00:47 2016 +0300 Bug 14897 - Header name mismatch in ./modules/catalogue/detail.tt We changed the detail.tt file for staff interface from Publication details to "Serial enumeration / chronology" to match the cataloguing editor. Signed-off-by: Joy Nelson Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 43d77fdcf01906fa535482691e5eade47287ab2f) Signed-off-by: Fr?d?ric Demians commit 744b035932608a0ce3dd495765f9c249d1f527db Author: Blou Date: Mon Jul 27 16:24:46 2015 -0400 Bug 14605 - Corrects the individual fine's description When paying a fine, the description is built out of the borrower's type and title, instead of the actual fine's description. STEPS: 1) in the staff, go to a user with a fine to pay. a) if none, go to a user and Fines>>"Create manual invoice" with a distinctive description. 2) In Fines>>Pay fines, click the "Pay" button on the line of the fine. 3) This will take you a "Pay an individual fine" screen, where the description will look like "Staff Mrs", for the category and title of the borrower. Signed-off-by: Mirko Tietgen Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit 63041c19c98b90c934ef89634dfdaf2d6abeb762) Signed-off-by: Fr?d?ric Demians commit ac00e73077164db595432b723ee6f938e009dc7d Author: Jonathan Druart Date: Wed Jun 8 15:32:31 2016 +0100 Bug 16492: Add a FIXME to explain the possible problem with no_set_userenv Signed-off-by: Kyle M Hall (cherry picked from commit 4f3067184d7dd3666d404a2165d72755cb0b227d) Signed-off-by: Fr?d?ric Demians commit f69eeca6c4a7d7d4b0538e7964a0f5f190de4b4e Author: Jonathan Druart Date: Wed May 25 17:33:00 2016 +0100 Bug 16492: Test that no_set_userenv will not set userenv if not exist yet Signed-off-by: Kyle M Hall (cherry picked from commit bb6e70fe7d4ba530fe64179fe6fde4d6b4ec5e35) Signed-off-by: Fr?d?ric Demians commit 57086a241e141e157d42b8af3f56ae9283d46ae9 Author: Kyle M Hall Date: Tue May 10 16:36:03 2016 +0000 Bug 16492 - Checkouts ( and possibly checkins and other actions ) will use the patron home branch as the logged in library Bug 14507 introduced the use of checkpw in C4::SIP::ILS::Patron so that non-Koha internal authentication processes would be able to function via SIP ( LDAP et al ). The problem is that checkpw changes the userenv to that of the patron! This is not usually an issue in Koha because most of the time that patron running through checkpw is the one to be logged in. Aside from SIP2 the only other area where this may be an issue is in SCO when using SelfCheckoutByLogin. Test Plan: 1) On master, check out an item to a patron via SIP2 2) Note the checkout lists the item as having been checked out from the patron's home library not matter which library is was supposed to be checked out from. 3) Apply this patch 4) Re-checkout the item 5) The item should now be checked out as if it was checked out from the library as defined in the SIP configuration file. Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall (cherry picked from commit 90307bcbfaf4c2c8907be94eabca249ac173442e) Signed-off-by: Fr?d?ric Demians commit 700fbd0a35073dc3cef7b3e340ab806a21354ba1 Author: Jonathan Druart Date: Wed Jun 8 14:52:04 2016 +0100 Bug 16695: Require Exception::Class 1.38 instead of 1.39 Looking at http://cpansearch.perl.org/src/DROLSKY/Exception-Class-1.40/Changes there is no need to require 1.39 Signed-off-by: Jacek Ablewicz Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit a4c44b9f643ab9a31c4025f6001a823fdcbb8101) Signed-off-by: Fr?d?ric Demians commit 22c1188c0ba96b1f783e9d72b81e542a506984f0 Author: Galen Charlton Date: Tue Jun 7 00:44:07 2016 +0000 Bug 16647: update debian/control for 16.* This patch updates debian/control* to match what was used for building the 16.05.00 packages, and includes changes to: - specify a floor for the Swagger2 version - add dep on libio-socket-ip-perl, which is needed for the package to work on Debian Wheezy - suggest libwww-youtube-download-perl Signed-off-by: Galen Charlton Signed-off-by: Hector Castro Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 40f3d43f46cccb5bb8077aae64684c5c5a0ed781) Signed-off-by: Fr?d?ric Demians commit 25c91b797afcc7bd976fd10299e0becf6c42ff34 Author: Jonathan Druart Date: Sat Jun 4 12:26:27 2016 +0100 Bug 16649: Make OpenLibrarySearch test pass even if launches offline Test plan: prove t/OpenLibrarySearch.t should return green even if you are offline Signed-off-by: Srdjan Signed-off-by: Mirko Tietgen Signed-off-by: Galen Charlton Signed-off-by: Kyle M Hall (cherry picked from commit f97626271ecf7ea90724cd7b131cf4eabb883c23) Signed-off-by: Fr?d?ric Demians commit 213401821d56087e96da7383b1eb6ff5a97dbdad Author: Galen Charlton Date: Tue Jun 7 01:42:59 2016 +0000 Bug 16675: fix breakage of t/Languages.t This patch fixes test breakage introduced by the patch for bug 16088, which added caching of getlanguages(). Upon inspection, it looks like the patch for 16088 does not introduce a regression on bug 10560, so this patch adds a couple cache-clearings. To test ------- [1] Verify that t/Languages.t passes. Signed-off-by: Galen Charlton Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit b9b4eeb849dcb52053a98440e1d8fb02011a9005) Signed-off-by: Fr?d?ric Demians commit a1f1ea03177204af1cb5dde29b5f18f339402bdb Author: Jonathan Druart Date: Tue Jun 7 12:29:33 2016 +0100 Bug 16668: Fix t/Ris.t tests Caused by bug 16442. Now we need to mock the marcflavour pref Test plan: prove t/Ris.t should return green Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit 023384811f54f18fbe585431c49b80cfc20e58dd) Signed-off-by: Fr?d?ric Demians commit 155d4ce1d2a90841dd37c496bcf2e3130a0b2cc0 Author: Mark Tompsett Date: Mon May 30 12:16:36 2016 -0400 Bug 16618: 00-load.t prematurely stops all testing Rather than add/remove regular expressions to skip modules (like bug 9054), encapsulate the decision logic into a separate function. Currently there are three libraries which trigger halts: Koha::NorwegianDB (which was already there) Koha::ElasticSearch::Indexer Koha::SearchEngine::Elasticsearch::Search TEST PLAN --------- 1) prove t/00-load.t -- should barf horribly on Catmandu stuff if not: sudo apt-get remove libcatmandu-marc-perl then repeat step. 2) apply patch 3) prove t/00-load.t -- should not barf horribly 4) run koha qa test tools NOTE: The four optional modules for Koha::NorwegianDB are listed in the PerlDependencies.pm, while there is no mention of Catmandu libraries at all there. This may be another bug which needs fixing. TECH NOTES (for ideas of how to tinker around): These three things should trigger the three module cases: sudo apt-get remove libcatmandu-marc-perl sudo apt-get remove libcatmandu-store-elasticsearch-perl sudo apt-get remove libconvert-basen-perl You probably had koha-perldeps installed before, so the following wil mostly fix: sudo apt-get install koha-perldeps libcatmandu-marc-perl And in case you didn't have elastic search stuff installed: echo deb http://packages.elastic.co/elasticsearch/1.7/debian stable main | sudo tee /etc/apt/sources.list.d/elasticsearch.list wget -O- https://packages.elastic.co/GPG-KEY-elasticsearch | sudo apt-key add - sudo apt-get update cd ~ wget http://debian.koha-community.org/koha/otherthings/elasticsearch_deps.tar.gz tar xvf elasticsearch_deps.tar.gz cd es_deps sudo dpkg i lib* sudo apt-get install -f Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton Signed-off-by: Kyle M Hall (cherry picked from commit 5e6da05b101e014d2b2ecc80b4fc4474c54503bc) Signed-off-by: Fr?d?ric Demians commit 7e1aeff2890e82d24e2f6473083a316355021c15 Author: Jonathan Druart Date: Thu May 26 10:55:09 2016 +0100 Bug 16596: Display library and patron category descriptions instead of their code Test plan: On circ/circulation-home.pl and reserve/request.pl, search for patrons The descriptions for the libraries and patron categories should be displayed. Signed-off-by: Bernardo Gonzalez Kriegel On top of Bug 13336 Works as described, now descriptions instead of codes. No errors Signed-off-by: Nick Clemens https://bugs.koha-community.org/show_bug.cgi?id=16455 Signed-off-by: Kyle M Hall (cherry picked from commit 04e5c2630c6e3b2962498b932bd8967478c940e5) Signed-off-by: Fr?d?ric Demians commit 43002c3b0e1659edc910cae435c3715a46e80a76 Author: Jonathan Druart Date: Wed May 25 18:09:27 2016 +0100 Bug 16578: Same fix for the staff interface Signed-off-by: Bernardo Gonzalez Kriegel Works as first patch No errors Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 3948102f2ad6e5382a31a00df0c8f52def3daf58) Signed-off-by: Fr?d?ric Demians commit 164ffdb43c98b4d2fa193d80c48f5509294fa1ca Author: Tomas Cohen Arazi Date: Tue May 24 14:28:44 2016 -0300 Bug 16578: Fix wide character errors in opac-export.pl This simple patch fixes wide character warning raised by opac-export.pl when 'MARC (Unicode/UTF-8)' and 'MARC (Unicode/UTF-8, Standard)' formats are chosen for downloading records. To test: - Have records indexed - Open your OPAC logs: $ tail -f /var/log/koha/kohadev/opac-error.log - Open the detail page in the opac for a record - Choose Save record > MARC (Unicode/UTF-8) => FAIL: opac-export.pl: Wide character in print at /home/vagrant/kohaclone/opac/opac-export.pl line 116., referer: http://localh... - Choose Save record > MARC (Unicode/UTF-8, Standard) => FAILE opac-export.pl: Wide character in print... - Apply the patch - Choose Save record > MARC (Unicode/UTF-8) => SUCCESS: No warnings raised. - Choose Save record > MARC (Unicode/UTF-8, Standard) => SUCCESS: No warnings raised. - Sign off :-D Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 7d4844e171b1319b90e7bd73510bd97c2acbf635) Signed-off-by: Fr?d?ric Demians commit c5fc0fcd0e28309114c70333cb75a2aee11b35e0 Author: Jonathan Druart Date: Wed May 11 13:04:38 2016 +0100 Bug 16465: Fix typo issues vs checkouts Test plan: Confirm the wording is correct Signed-off-by: Srdjan Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit af59b669413539606f10652230e5f96d43337cb5) Signed-off-by: Fr?d?ric Demians commit 5ce7baf937d8e7ddf56ca0ae4dde00690fe5a32c Author: Jonathan Druart Date: Wed May 11 12:57:47 2016 +0100 Bug 16465: discharge - Add a title tag at the OPAC Test plan: Confirm that the opac-discharge.pl has now a title Signed-off-by: Srdjan Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit 27254de06d8ae6682b395be48d6ba02b69f9e917) Signed-off-by: Fr?d?ric Demians commit b31ee2eaf9dd86171cac1598f3f9a611ea145f83 Author: Marcel de Rooy Date: Wed May 11 15:47:46 2016 +0200 Bug 16428: [QA Follow-up] Useless call to GetMarcStructure in _build_default_values_for_mod_marc The routine calls GetMarcStructure and does not use its return value after all. Test plan: Run t/db_dependent/Items.t Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit 6a706b86a273672b1e1ca3f1456fde08dd7a0da2) Signed-off-by: Fr?d?ric Demians commit 4ebfb709f6cdeb263b579f7a3538c1a1342a939a Author: Jonathan Druart Date: Tue May 3 11:03:52 2016 +0100 Bug 16428: Use the biblio framework to know if a field is mapped The subroutine _build_default_values_for_mod_marc takes the frameworkcode in parameter, but ModItemFromMarc did not pass it. It uses it to know if a field is mapped or not to a Koha field (C4::Koha::IsKohaFieldLinked). Consequently the default framework ("") was always used. This bug has been found working on bug 13074 and has been put on a separate bug report to ease the backport. Test plan: Without this change, the tests added by bug 16428 won't pass Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit 52b1b8eae1136af1e901560214a641494acaf577) Signed-off-by: Fr?d?ric Demians commit a44040d07d24707d2cda51d989ad0fa495116608 Author: Jonathan Druart Date: Tue Jun 7 11:48:46 2016 +0100 Bug 16441: Fix Letters.t These tests were wrong, but the package variable used to cache the letters hid the problem. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit 687a7e22b6c630c3bbc06e1845854514f6fea5b0) Signed-off-by: Fr?d?ric Demians commit c63dccba27842ce92569625a03df55085bf5681a Author: Jonathan Druart Date: Wed May 4 19:43:43 2016 +0100 Bug 16441: Do not use a package variable to cache C4::Letters::getletter C4::Letters::getletter use a package variable (%letter) to cache letter returned by the subroutine. I have not found any direct issues caused by that but it is safer to remove it. It won't be a big deal to hit the DBMS to get a valid letter when needed. No test plan here, just confirm that the changes make sense. Signed-off-by: Srdjan Signed-off-by: Marcel de Rooy Confirm that performance loss is just a millisecond or so per subsequent call of getletter. Signed-off-by: Kyle M Hall (cherry picked from commit c4f388f64966f2202e9f3e3c16dad5cef3dbe0ac) Signed-off-by: Fr?d?ric Demians commit 8e7e2c0db929fe9dab47f2cc71c353564e267850 Author: Jacek Ablewicz Date: Wed Jun 8 10:46:18 2016 +0200 Bug 16678: updatedatabase.pl 3.23.00.006 DB upgrade crashes if subscription_numberpatterns.numberingmethod contains parentheses It seems that if subscription_numberpatterns.numberingmethod contains parentheses, updatedatabase.pl crashes when running the 3.23.00.006 DB upgrade snippet, with the following error: [Mon Jun 6 09:06:54 2016] updatedatabase.pl: Unmatched ( in regex; marked by <-- HERE in m/ ( <-- HERE / at /home/koha/kohaclone/installer/data/mysql/updatedatabase.pl line 11498. Steps to reproduce: 1/ Have a Koha DB version<3.23.00.006 2/ Create a subscription numbering with parentheses in it: ie "Vol. (Month, Year)" with pattern Vol. {X} ({Y}, {Z}) 3/ Add some serials using that numbering method so that serialseq is filled in DB: ie "Vol. 16 (February, 2015)" 4/ Run the updatedatabase.pl script either from the cli or just start the webinstaller 5/ The error is produced To test: 1/ apply patch 2/ try to reproduce this issue once again, should be fixed now 3/ have a look at the code, make sure the changes are consistent Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Note: I have not tested the patch, but the diff looks good. Signed-off-by: Kyle M Hall (cherry picked from commit 113adf68e56b6233b44a2b7a9b5dc60f6c4de0b7) Signed-off-by: Fr?d?ric Demians commit c0c00b80cd5aca3a0fe1903acbb03031fb654dd2 Author: Jonathan Druart Date: Tue May 24 19:57:16 2016 +0100 Bug 16570: Do not tell all checked-in items are part of a rotating collection When an item is checked-in a message will tell you it's part of a rotating collection, even if it's not true. Test plan: Make sure the message appears only when needed. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit 8794348ccbb156ddd1ec53702b5afebea1747976) Signed-off-by: Fr?d?ric Demians commit 03d51281b079c379a2fba0caf8a9df8ec9c6d500 Author: Marcel de Rooy Date: Fri Jun 10 11:49:45 2016 +0200 Bug 16443: [QA Follow-up] Add two tests for get_fields Adds t/db_dependent/Members/Statistics.t. Test plan: Run the test. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall (cherry picked from commit 30cf9ee277481b54ed75e500c38f328f2d82b831) Signed-off-by: Fr?d?ric Demians commit 93ffd58fe32dd4e27056f5cebf18b975f3d0624b Author: Jonathan Druart Date: Wed May 4 20:08:53 2016 +0100 Bug 16443: Make C4::Members::Statistics plack safe If the prefs is updated, the fields won't be. To make sure we already fetch updated values, we should remove the package variable and define it in the subroutine. There is not test plan, just make sure the changes are consistent. Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall (cherry picked from commit 29e402d398f567e2526c89695384bce7f4e4b737) Signed-off-by: Fr?d?ric Demians commit 6ff159e214a2ebf904ff7f1b77f0f75162f8afe8 Author: Jonathan Druart Date: Thu May 5 16:58:06 2016 +0100 Bug 16455: Remove the "Too late to run INIT block" from C4::Tags The pref TagsExternalDictionary is used to tell Lingua::Ispell to use an other dictionary, different from the default one (/usr/bin/ispell). To do so we need to set $Lingua::Ispell::path to the expected path. It's currently done in the INIT block. If you try to use C4::Tags, you will get the famous "Too late to run INIT block at C4/Tags.pm line 74." warning. Plack use the INIT block to load functions at run time, when we are using C4::Tags when hitting a pl script, the compilation phase is finished and it's "too late to run INIT block" from C4::Tags. I do not really know if it has an impact on the behavior of Lingua::Ispell (i.e. is the path redefined?), but I know that this INIT block is not executed when we want. Test plan: under Plack, - hit /cgi-bin/koha/opac-search.pl and confirm that the warning does no longer appears - Use another dictionnary (??), fill TagsExternalDictionary with its path and confirm that it is used by the tags approval system Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher (cherry picked from commit 7d916c380a03904c47035f189d1ee666f00d9a11) Signed-off-by: Fr?d?ric Demians commit 259fe9947b73023a22aceda2b7f7ad357500884f Author: Jonathan Druart Date: Tue May 17 14:38:04 2016 +0100 Bug 16508: Updating a syspref requires parameters_remaining_permissions And not all of parameters flags. Test plan: 1/ Create a staff user. 2/ Go to details, select more->set permissions. 3/ Set catalogue, Manage Koha system settings (Administration panel), manage circulation rules, and Remaining system parameters permissions. 4/ Log in as the new staff user, go to administration > system preferences. Change a syspref and save it... it will save correctly. 5/ Log back in as superlibrarian 6/ On the 'set permissions' screen, un-check 'manage circulation rules' and save. 7/ Log back in to the new staff user, and try to change the same systemprefrence and save. Followed test plan, works as expected. Signed-off-by: Marc Veron Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher (cherry picked from commit f2fe433cf9afce98957826bf2ade457557fe4eff) Signed-off-by: Fr?d?ric Demians commit 2729f038c34b5c4f0b713738c9bf4a94068f1b43 Author: Jonathan Druart Date: Fri May 13 20:46:42 2016 +0100 Bug 16518: Fix Plack variable scoping problem in opac-addbybiblionumber.pl The script opac/opac-addbybiblionumber.pl is not plack safe because the variable @biblios is declared with our and is not assigned to an empty array (so not reset). The issue: When trying to add items to a list (virtualshelf), the biblionumbers are added to the @biblios variable and the list is not reset between each run. Test plan: Check from records from the result list and add them to a list. Cancel or save and re-add them (or others) to a list (same or different). => Without this patch, the list of records will never stop growing, the previous items added are still listed when adding new ones. => With this patch, the behavior is the one expected. Signed-off-by: Srdjan Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher (cherry picked from commit ab1beed06f249d1e7d0be5bb1b584e62f5b48783) Signed-off-by: Fr?d?ric Demians commit e242625721b0dcd68cd7b3408ef9da5d367a878d Author: Aliki Pavlidou Date: Sat Jun 4 12:10:38 2016 +0000 Bug 15641 - Typo in explanation for MembershipExpiryDaysNotice There's an extra period after the word "in" in the MembershipExpiryDaysNotice sys "Send an account expiration notice when a patron's card will expire in. [value box Bug fixed! Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher (cherry picked from commit 6b7f4a3a9ec18b550d011a7eee9e7108b7042059) Signed-off-by: Fr?d?ric Demians commit 020d755ed061cfc94ca12eace6fae7388cc89e3e Author: Rocio Dressler Date: Sat Jun 4 02:24:45 2016 -0700 Bug 16537 - Overdue and Status triggers grammar Test plan: 1) Go to the staff client 2) Click on Tools - Overdue notice/status triggers 3) Confirm that the first sentence reads "a" checkout rather than "an" checkout Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher (cherry picked from commit a589879f495aeb25200119cb4f1bf76c28dce660) Signed-off-by: Fr?d?ric Demians commit 97a3f03970e1aa8d3eba5e5502f092202e43349b Author: Jonathan Druart Date: Wed May 4 20:20:51 2016 +0100 Bug 16444: Make C4::Tags plack safe C4::Tags use a package variable to cache the pref TagsExternalDictionary, it's not needed and not safe. There is not test plan, just make sure the changes are consistent. Signed-off-by: Srdjan Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher (cherry picked from commit fff754a7fc7a99dad6a35129b8a7dd170684f2bf) Signed-off-by: Fr?d?ric Demians commit b7a0322258ad534ea8e5af34cb0581b0b5f174e8 Author: Jonathan Druart Date: Wed May 11 12:00:01 2016 +0100 Bug 16458: Update library when a guarantor is set If you edit a patron from the Edit link of the patron information block (step 1 of the memberentry script), the branchcode is not displayed. If you set a guarantor to a child from this form, a JavaScript error will be raised: JavaScript error form.branchcode is undefined It happens because there is the branchcode is not displayed and there is no element with a branchcode name. To avoid this issue, a branchcode hidden input is added to the form and it will be updated when a guarantor is selected (same behavior as when you edit a patron using the complete form). Test plan: Edit a patron using the Edit link of the patron info block (not the Edit button in the toolbar) Set a guarantor => Notice that the branchcode of the patron has been updated with the branchcode of the guarantor Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher (cherry picked from commit fc35a5099f613c08d12be1d67fd027d4a5eaf99c) Signed-off-by: Fr?d?ric Demians commit df36beeffd1be584478cc85764b55959ccf75da7 Author: Owen Leonard Date: Mon May 16 10:52:17 2016 -0400 Bug 16529 - Clean up and improve upload template This patch makes some fixes and improvements to the template for Tools -> Upload, including markup corrections, removal of 'onclick,' and conversion of some links to styled buttons. To test, apply the patch and go to Tools -> Upload. - Confirm that uploading a file works correctly. - Confirm that clicking 'Cancel' during a file upload works correctly. - Search existing uploads. - Confirm that the 'Download' and 'Delete' buttons look correct and work correctly. - In Administration -> MARC bibliographic framework, choose a framework and configure a tag subfield to use the upload plugin. - Create or edit a bibliographic record using the framework you modified. - Click the tag editor icon next to your modified subfield to trigger the pop-up window with the upload form. - Confirm that this window has a layout which is adjusted for the size of the window. - Confirm that uploading and selecting files from this window works correctly. Signed-off-by: Rocio Dressler Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher (cherry picked from commit 6cd592ba3b18236a3c0f82873d4444c1f884f37c) Signed-off-by: Fr?d?ric Demians commit a987ff3ba92e1558e11a63335895749b5efd1689 Author: Jonathan Druart Date: Wed May 4 19:53:46 2016 +0100 Bug 16442: Make C4::Ris plack safe C4::Ris incorrectly uses 4 package variables: - $utf: not used, can be removed - $intype: set to marcflavour once, but later it assumes that it is usmarc if not defined - $marcprint: always 0, so set it to 0 - $protoyear: only used in 1 subroutine, let's define it at this level Test plan: Just make sure the RIS export works as before this patch Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher (cherry picked from commit 87b181c6d40e7a811fee511648ddd3cb7d44c4e4) Signed-off-by: Fr?d?ric Demians commit 12f6f9438a426a12c408b7d27e1af2e0cd52d1a3 Author: Chris Cormack Date: Fri Jun 3 12:09:33 2016 +0000 Bug 7143 : Ooops double counted a developer Signed-off-by: Brendan Gallagher (cherry picked from commit 7e30240e694c65bb635a495820cce8883d26baa5) Signed-off-by: Fr?d?ric Demians commit 2d1488998758ddc7d558eaaf1f6acac07dff6cd7 Author: Chris Cormack Date: Fri Jun 3 12:07:02 2016 +0000 Bug 7143: Updating about page for new developers Signed-off-by: Brendan Gallagher (cherry picked from commit e1b5adec83febdb93e0045b711a19b84e5d06a4a) Signed-off-by: Fr?d?ric Demians commit 316e1a672359c8ba8f065942945cfca183456e23 Author: Chris Cormack Date: Fri Jun 3 11:59:18 2016 +0000 Bug 7143 Updating the history.txt Signed-off-by: Brendan Gallagher (cherry picked from commit 84f7f1608553e3cd4610e96325eecff177da1d49) Signed-off-by: Fr?d?ric Demians commit 9a2c6bfde243f0fe41112fe1b651273ab091c901 Author: Claire Gravely Date: Fri Jun 3 10:38:25 2016 +0200 Bug 16642 - Fix capitalisation for upload patron image To fix capitalisation on the staff interface when patronimages is turned on. Test plan: 1. In staff interface. Turn on patronimages sys preference. 2. Go to a patron without an image and check that the "Upload patron image" box heading now has correct capitalisation. 3. Go to a patron with an image already uploaded and check the "Manage patron image" box heading has correct capitalisation. Signed-off-by: Sofia Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher (cherry picked from commit 78b2fde34831a4840f6b89df054a5307f1ead54b) Signed-off-by: Fr?d?ric Demians commit b49adab4a1c4bb08714371223572caf35460f0f4 Author: Jonathan Druart Date: Mon May 23 12:19:46 2016 +0100 Bug 16565: Drop additional_fields and additional_field_values before creating them These 2 tables should be dropped before trying to create them Test plan: From the SQL CLI, source the kohastructure.sql file source it again => Without this patch you get 2 warnings ERROR 1050 (42S01) at line 3580 in file: 'installer/data/mysql/kohastructure.sql': Table 'additional_fields' already exi sts ERROR 1050 (42S01) at line 3596 in file: 'installer/data/mysql/kohastructure.sql': Table 'additional_field_values' alrea dy exists => With this patch, you won't get them Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher (cherry picked from commit a01cd77e19f810bf61c8d26ebb97f7c49f1d1f32) Signed-off-by: Fr?d?ric Demians commit 14b9930b079c3f5518dce7a8cedc887790a2f27a Author: Aleisha Date: Thu May 12 04:41:09 2016 +0000 Bug 12402: Show patron category on pending patron modifications To test: 1) Go to OPAC and make a modification to user 2) Go to Staff Client and go to pending patron modifications 3) Notice that we have the user's surname, first name, branch and cardnumber 4) Apply patch and refresh page 5) Notice that patron category now shows after user's name Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher (cherry picked from commit 6c733b2fda7cd94ae2997c1a058d229dd7819692) Signed-off-by: Fr?d?ric Demians commit feabd6e38648b5f4efefd50772d78eebe6261d5c Author: Owen Leonard Date: Thu May 19 12:28:08 2016 -0400 Bug 16005 - Standardize use of icons for delete and cancel operations This patch makes changes to Font Awesome icons in order to make icon choice consistent for common actions. where something is deleted, removed, or emptied. where an operation is cancelled (also where selections are cancelled, as in checkboxes). for "close," as in baskets and windows. To test, apply the patch and view the following pages to confirm that the correct icon is used: - Acquisitions -> Vendor -> Vendor delete button. - Acquisitions -> Vendor -> Edit -> Delete contact button. - Acquisitions -> Invoices -> Delete menu item. - Cataloging -> Edit record -> Authority search pop-up (triggered from the tag editor for a tag linked to an authority) -> Clear field button - Authorities -> Authority detail -> Delete button. - Tools -> Quotes editor -> Quotes delete button. - Reports -> View saved report -> Delete button. - Reports -> Saved reports -> Delete menu item. - Serials -> Subscription details -> Subscription close button. - Administration -> Budgets -> Delete menu item. - Administration -> Item search fields -> Delete button. - Administration -> Z39.50/SRU servers -> Delete menu item. - Catalog -> Advanced search -> Clear fields link. - Cataloging -> Advanced editor -> Macros -> Delete macro button. - Circulation -> Checkout -> Check out an item which is on hold for another patron. "Cancel checkout and place hold" button now uses the icon used elsewhere for holds. - Course reserves -> Course -> Delete course button. - Patrons -> Patron lists -> Add patrons -> Remove selected button. - Acquisitions -> Suggestions -> Suggestion details -> Delete button. - Lists -> List contents -> Remove selected button. Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher (cherry picked from commit ed449a5b5be4da03443d214de5806f4a0273227b) Signed-off-by: Fr?d?ric Demians commit 26afd665ecfeff6668216467cd77ac25d50f74e4 Author: Owen Leonard Date: Mon Apr 25 09:12:05 2016 -0400 Bug 16336 [Revised] UX of holds patron search with long lists of results Bug 15793 made a change to an interface which is also found in the place hold template. This patch creates a new include file to be used by both circulation.tt and request.tt so that these pages do not diverge. In the process, this patch removes some markup and JavaScript which was made obsolete by Bug 15793 and should have been removed. This patch also revises the sorting of the results table so that the patron name is sortable (Bug 16334) and the default sort is on card number (matching 3.20.x and 3.22.x). To test: In Circulation: - Perform a search by name for a patron which will return multiple search results. - The table of results which displays should look correct and work correctly, including DataTables sorting. - Clicking any table row should forward you to the checkout page for that patron. In the catalog: - Locate and place a hold on a title. - When prompted to select a patron to place the hold for, perform a search by name which will return multiple results. - Confirm that the table of patron results looks correct and works correctly. - Clicking any table row should forward you to the place hold page for that patron and the title you selected. Revision: Although the table row was clickable, you couldn't middle-click it to open the link in a new tab. The patron name is now a real link you can middle-click or right-click. The row is still clickable as well. Signed-off-by: Aleisha Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher (cherry picked from commit 4c04f6f8e0068a7cce256c3cd8ffcf5acf682fe0) Signed-off-by: Fr?d?ric Demians commit acdc5f27a7625746d004e62f865c384c566fb2ef Author: Jonathan Druart Date: Fri May 13 15:28:50 2016 +0100 Bug 16388: Use existing 'execute' parameter instead of creating a new one An existing 'execute' parameter is already passed to the template when we need to display the 'Download' button, so let's use it instead of creating a new one. Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher (cherry picked from commit c2f53bd039aa2ce52c2ddc3a2314e32b44ae4ee8) Signed-off-by: Fr?d?ric Demians commit 16a35fb6315567f2631ed1598031c94ef25505df Author: Aleisha Date: Fri Apr 29 02:47:06 2016 +0000 Bug 16388: Move option to download report into reports toolbar To test: 1) Create a new SQL report or edit a report 2) Ensure that the download option does NOT show in the toolbar 3) Save and run the report 4) Confirm that download option DOES show in toolbar as a dropdown with the 3 options (csv, tab and ods) 5) Confirm that downloading all 3 file types works as expected Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher (cherry picked from commit e7ac7abf16c76a00a5dcd8e8cd1e62522675b8ee) Signed-off-by: Fr?d?ric Demians commit 65232361231f5006f25cc354e24b38b07f359d61 Author: Mark Tompsett Date: Tue May 24 22:31:15 2016 -0400 Bug 16582 t/Price.t test should pass if Test::DBIx::Class is not available TEST PLAN --------- 1) prove t/Prices.t -- failure 2) apply patch 3) prove t/Prices.t -- nicely skipped when Test::DBIx::Class is not available. Signed-off-by: Srdjan Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher (cherry picked from commit 5ba5f9e0c5958b518bd648f08146329e355f3a7e) Signed-off-by: Fr?d?ric Demians commit 66c9ef12c16efeebf78e3a98be7b2ccc42d14e7a Author: Kyle M Hall Date: Fri May 27 12:42:17 2016 +0000 Bug 16610 - Regression in SIP2 user password handling Previous to bug 14507, SIP2 only did internal authentication. A change to the way we check empty passwords has caused any empty password to send back a CQ of Y. Previous to that patch set, a CQ of Y would only be sent back of the patron password column was NULL. Now, an empty AD field *always* returns a CQ of Y. Test Plan: 1) Send a patron information request with an empty AD field Note: You must send the AD field or you won't get back a CQ field 2) Note you get back a CQ of Y 3) Apply this patch 4) Repeat step 1 5) Note you now get back a CQ of N Signed-off-by: Trent Roby Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher (cherry picked from commit 71f0370ddde0d8b8e2a666a091081186fb6531e8) Signed-off-by: Fr?d?ric Demians commit 9f935b384fd01c863af1de195f4fe256450f4a46 Author: Marcel de Rooy Date: Wed Jun 1 15:34:56 2016 +0200 Bug 16610: [QA Follow-up] Add a test To verify the original patch, this test shows that before applying it the Patron Info request did not return CQ==N for an empty password. Note that the Patron Status did btw. After applying the original patch, the test passes for patron info as well as status. Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher (cherry picked from commit cbdd9194eb3359d517fbda9a50a02fbc375bf5dd) Signed-off-by: Fr?d?ric Demians commit 5712275a4645d4d899815120fe79e730edf1034e Author: Marcel de Rooy Date: Tue May 31 14:16:07 2016 +0200 Bug 16504: [QA Follow-up] Make koha-qa happy with two newlines Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher (cherry picked from commit 567a1a9021aaea3bf42b19f493b79f682ed9042b) Signed-off-by: Fr?d?ric Demians commit 247bd55876a4e930934419070fc926a656a0d9d7 Author: Jonathan Druart Date: Fri May 13 14:43:52 2016 +0100 Bug 16504: (follow-up for bug 15163) Do not remove attributes of other patrons Simple patch for a silly error, this single line is going to fix a critical bug. If a patron attribute is limited to a library, all the values for that attributes for every patrons will be deleted. Test plan: Create a patron attribute limited to a library Set the the attribute for a patron Set the the attribute for another patron => Without this patch applied, the attribute's value for the first patron is deleted => With this patch applied, the 2 values exist in the DB after the second edition Signed-off-by: Srdjan Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher (cherry picked from commit da94410ab5022c3bd97fba1878673149802db584) Signed-off-by: Fr?d?ric Demians commit 5949faae071c317c029c9c89320c52d73cd7a362 Author: Jonathan Druart Date: Fri May 13 14:42:52 2016 +0100 Bug 16504: Add regression tests Signed-off-by: Srdjan Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher (cherry picked from commit 72bd06e3a88f62fcfe8710773091447ebafebcb3) Signed-off-by: Fr?d?ric Demians commit 385cf8e64100bfd18cabe1e2a5d7a37beeb4daad Author: Jonathan Druart Date: Fri May 20 15:40:24 2016 +0100 Bug 16437 - (follow-up) Automatic item modifications by age needs prettying Do not move the scrollbar to the top when removing a 'block' to a new rule. Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher (cherry picked from commit e0143f3205ebbf07aa479b89d8ba8aab426496b2) Signed-off-by: Fr?d?ric Demians commit 631e349ff2e751a43f9e0a426f94ab4b116ad8c7 Author: Owen Leonard Date: Fri Mar 25 13:06:03 2016 -0400 Bug 16437 - Automatic item modifications by age needs prettying This patch makes layout and behavior changes to the automatic item modifications by age interface, bringing some aspects of it closer into conformance with established interface patterns. - The intial view is now a standard table of information about existing rules, or a message dialog saying there are no rules. - If there are no rules, a toolbar button reads "Add rules." - If there are existing rules, the toolbar button reads "Edit rules." - Clicking the button leads to the rules edit interface, which now has a floating toolbar with "Add rule," "Save," and "Cancel" buttons. - Clicking the "Add rule" button displays a blank rule block. - If you are adding a rule to existing rules, the new block is appended at the bottom, and the page scrolls to the new rule. - As you add or remove rule blocks, the legend containing the rule count updates so that the numbers are sequential. - In each rule block, "age" and "substitutions" are now required. The age field is now validated to require a number. - The add/remove condition/substitution links now have more descriptive text labels. - The control to remove a rule is now a link in the element associated with each rule. - Most JavaScript for this page is now in a separate file. - Breadcrumbs are updated to be a little more specific. To test, apply the patch and clear your browser cache if necessary. - Go to Tools -> Automatic item modifications by age. - Test adding and removing rules. - Test removing all rules. - Test adding and removing conditions and substitutions within rules. - Test submitting the form without filling in required fields. Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher (cherry picked from commit 22b18ba988c72b6802421ae2e96237a716ae436e) Signed-off-by: Fr?d?ric Demians commit 10733c39399d4db48bd5a73a9c4a195531751875 Author: Owen Leonard Date: Wed May 4 09:34:46 2016 -0400 Bug 16450 - Remove the use of "onclick" from guarantor search template This patch updates the guarantor search template so that event definition is done in the script rather than in an onclick attribute. This patch also increases the size of the popup window to help prevent the need for horizontal scrolling and adds Bootstrap style to the "select" button. To test, apply the patch and clear your browser cache if necessary. - Go to Patrons and add a patron with a "child" category type. - In the "Guarantor information" section, click the "Set to patron" button. - In the pop-up window, search for a patron. - Click the "Select" button next to a patron. - The window should close, and the patron you selected should now appear as the guarantor. The guarantor's address information should be added to the "Main address" section. Tested on top of Bug 13041 and Bug 16386, works as expected, however see Bug 16458 Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher (cherry picked from commit fdf4101fb17d8f45487a9ba6ba248e8edf245cf6) Signed-off-by: Fr?d?ric Demians commit 92c08a6a4e177622a4513fa34c81dfcbec20ec57 Author: Aleisha Date: Fri May 13 00:46:40 2016 +0000 Bug 16511: Making contracts actions buttons To test: 1) Go to Acqui -> find a vendor 2) On Vendor details page (supplier.pl) confirm that Contracts table now has one column called Actions 3) Confirm that Edit and Delete show as buttons 4) Confirm that buttons don't wrap on a narrower browser 5) Click Contracts tab 6) Confirm Actions column, Edit and Delete buttons, and button's don't wrap Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher (cherry picked from commit 23c8dc0e6384779c0eaf8441d598b60ac6aea46e) Signed-off-by: Fr?d?ric Demians commit ddf80b2003522cc0542d4ee4f9b8e19fb7a8c4e0 Author: Aleisha Date: Tue May 17 00:22:09 2016 +0000 Bug 16524: Use floating toolbar on item search To test: 1) Go to item search 2) Confirm toolbar at top of page with Search button, goes down page as you scroll 3) Confirm search button has been removed from final output fieldset 4) Confirm everything works as expected Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher (cherry picked from commit 2afff4e8502d724f4f9e46bd406e1f00263b2b21) Signed-off-by: Fr?d?ric Demians commit 0c4661110c467c8d11631cc627395acef941c9c9 Author: Aleisha Date: Mon May 16 01:10:43 2016 +0000 Bug 16525: Have cancel button when adding new aq budget At the moment you only see the cancel button on the form if editing an existing budget. This patch adds a cancel button to the form which adds a budget. Also changes the wording of the save button from 'Save changes' to just 'Save' so it makes more sense when adding a new budget To test: 1) Go to Admin -> Budgets -> New budget 2) Notice 'Save changes' button and no cancel 3) Apply patch and refresh page 4) Notice 'Save' button and 'cancel' link 5) Click 'cancel' - should be taken to Budgets administration page 6) Edit an existing budget 7) Click 'cancel' - should be taken to the funds page for that budget Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Sabine Liebmann Signed-off-by: Jonathan Druart Still an issue: If edit a budget fron aqbudgets.pl, then cancel, you get aqbudgets.pl?budget_period_id=XX. But existed before this patch. Signed-off-by: Brendan Gallagher (cherry picked from commit c4f17a6eb3e5688b1d1f3c4b578f17ae80e46f8f) Signed-off-by: Fr?d?ric Demians commit 300cfc1ac8ae979b737b584e303823059d34680e Author: Owen Leonard Date: Mon Mar 7 12:12:40 2016 -0500 Bug 16001 - Use standard message dialog when there are no cities to list If there are no existing cities in Administration -> Cities and Towns, the message saying so should be in the standard message dialog. Another minor change: Edit the message to say "There are no cities defined," which I think reads better in English. To test you must have no cities and towns defined. Apply this patch and go to Administration -> Cities and Towns. You should see a message displayed in a standard "message" style dialog. Signed-off-by: Bernardo Gonzalez Kriegel Better view, no errors Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher (cherry picked from commit 89b41ede653227c5b4f777d6a4b30422ab473153) Signed-off-by: Fr?d?ric Demians commit 1f9e53f81c19dd56f7e77f40a05aa8433e2740d3 Author: Aleisha Date: Tue May 17 05:04:08 2016 +0000 Bug 16532: Groups showing empty tables if no groups defined EDIT: Same change for libraries To test: 1) Go to Admin -> Libraries and Groups 2) Notice empty tables if nothing defined 3) Apply patch and refresh page 4) Empty tables should not show 5) Add a new group 6) Confirm table shows correctly Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher (cherry picked from commit ca36a74c868f25217e0db0900f043b4403aa9e01) Signed-off-by: Fr?d?ric Demians commit 7626ecedc8c640cedd21463d90117aecad1e6a80 Author: Brendan Gallagher Date: Tue May 31 08:56:42 2016 +0000 DBRev up for Bug 16200 - 'Hold waiting too long' fee has a translation problem Signed-off-by: Brendan Gallagher (cherry picked from commit bae0eb9ab702f3fe4351e7b3b23a332a998ed6b1) Signed-off-by: Fr?d?ric Demians commit d80368370258432aab4d4171b886af26442d08c1 Author: Lari Taskula Date: Tue May 17 14:44:45 2016 +0300 Bug 16200: Convert all existing expired holds accounttype to HE Before Bug 16200 expired holds have used accounttype F which is also used by other type of fines. This patch updates all existing expired holds to new accounttype HE (Hold Expired). To test: -1. Make sure you translated the string in previous patch of this buug 1. Find a Patron with "Hold waiting too long" fines and go to his Fines tab 2. Change Koha's language to some other than English 3. Observe that "Hold waiting too long" is still in English 4. Apply patch and run database update 5. Go back to Patron's Fines tab 6. Observe that "Hold waiting too long" is now translated Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher (cherry picked from commit 09de19c427c1e99d7e921210ed39cb6a19737317) Signed-off-by: Fr?d?ric Demians commit 326616d2bce77b245e0d38eb3df659e821130645 Author: Lari Taskula Date: Tue May 17 14:33:57 2016 +0300 Bug 16200: Make 'Hold waiting too long' translatable and give it an unique accounttype Holds that have expired have been untranslatable in Patron's Fines-tab. Also, they are mixed with other type of fines with accounttype "F". This patch gives expired holds an own accounttype "HE" (Hold Expired) and modifies the boraccount to recognize this new accounttype in order to make it translatable. To test: 1. Make a hold and let it expire 2. Go to Patron's Fines tab 3. Change Koha's language to some other than English 4. Observe that there is a "Hold waiting too long" fine described in English 5. Apply patch 6. Make another hold and let it expire 7. Update translations 8. Find "Hold waiting too long" from your .po file 9. Translate it and install translations 10. Go back to Fines tab and observe that the new expired hold is translated Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher (cherry picked from commit 7163fcfeea382e1e042a47a76d384155e8c69bc0) Signed-off-by: Fr?d?ric Demians commit 06d775c3b3e9a376bbd9e09fc4cac65d35ce7363 Author: Liz Date: Mon May 30 23:21:49 2016 +0000 Bug 16619 - installer stuck in infinite loop To test: run the web installer on master, it should not get stuck in an infinite loop. Signed-off-by: Brendan Gallagher (cherry picked from commit 3311ab44cfffcd152e7de4652637eb95a265308e) Signed-off-by: Fr?d?ric Demians commit 8b9812fa83c110c446b58b6b1188d67d20011430 Author: Robin Sheat Date: Wed May 25 16:19:09 2016 +0200 Bug 16617 - fix issues with debian/control Signed-off-by: Chris Cormack Signed-off-by: Jesse Weaver Signed-off-by: Brendan Gallagher (cherry picked from commit e604538283ef3531aaa769dee70c83cdec942656) Signed-off-by: Fr?d?ric Demians commit a85be57e1ce1d2adde6b9ee3dba55f7c5f2e06ab Author: Owen Leonard Date: Wed May 18 19:45:27 2016 -0400 Bug 16548 - All libraries selected on Tools -> Export Data screen This patch adds "select all" and "select none" links to the display of libraries in the export bibliographic records form. Also modified: call number range and accession date fields have been grouped in their own fieldsets in the hopes that this is more readable. Page title and breadcrumbs have been corrected to read "Export data" instead of "MARC export," matching menu items. To test, apply the patch and go to Tools -> Export data. - Test the select all/select none links and confirm that they work as expected. - Confirm that the structural changes to the form look okay. Signed-off-by: Nick Clemens Post sign-off revision: Use the standard "Clear all" instead of "Select none." Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher (cherry picked from commit 06b9194cdd178f14347b8f9090657dbf5b712450) Signed-off-by: Fr?d?ric Demians commit a47180eb3bc0ca26a018f68ffcc4d5635f6f7789 Author: Kyle M Hall Date: Mon May 23 14:28:10 2016 +0000 Bug 16569 - Message box for "too many checked out" is empty if AllowTooManyOverride is not enabled If the limit for number of items checked out is reached, the message box shows up but is empty. Test Plan: 1) Disable AllowTooManyOverride 2) Check out items to a patron until the patron has reached the limit of checkouts he or she can have 3) Try to check out one more item 4) Note the empty message box 5) Apply this patch 6) Try to check out one more item again 7) Note the message is now visible Signed-off-by: Nicolas Legrand Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher (cherry picked from commit af43f91335b2258ea39b40247a1492ca41dafe2a) Signed-off-by: Fr?d?ric Demians ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 15 +- C4/Barcodes/hbyymmincr.pm | 27 +- C4/Circulation.pm | 2 +- C4/External/BakerTaylor.pm | 23 +- C4/Installer/PerlDependencies.pm | 9 +- C4/Items.pm | 3 +- C4/Letters.pm | 11 - C4/Members/Attributes.pm | 4 +- C4/Members/Statistics.pm | 5 +- C4/Reserves.pm | 2 +- C4/Ris.pm | 40 ++- C4/SIP/ILS/Patron.pm | 10 +- C4/Tags.pm | 19 +- Koha.pm | 2 +- catalogue/export.pl | 3 + circ/circulation.pl | 2 - circ/returns.pl | 22 +- debian/control | 22 +- debian/control.in | 3 +- docs/history.txt | 9 +- installer/data/mysql/kohastructure.sql | 2 + installer/data/mysql/updatedatabase.pl | 16 +- koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 25 +- .../prog/en/data/marc21_field_006.xml | 3 + .../prog/en/data/marc21_field_008.xml | 3 + .../intranet-tmpl/prog/en/data/marc21_field_CF.xsd | 3 + .../prog/en/includes/acquisitions-toolbar.inc | 2 +- .../prog/en/includes/auth-finder-search.inc | 2 +- .../prog/en/includes/authorities-toolbar.inc | 2 +- .../prog/en/includes/branch-selector.inc | 5 +- .../prog/en/includes/cateditor-ui.inc | 2 + .../en/includes/circ-patron-search-results.inc | 40 +++ .../prog/en/includes/quotes-toolbar.inc | 4 +- .../prog/en/includes/reports-toolbar.inc | 14 +- .../en/includes/rotating-collections-toolbar.inc | 4 +- .../prog/en/includes/serials-toolbar.inc | 10 +- .../intranet-tmpl/prog/en/includes/tools-menu.inc | 2 + koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 9 +- .../prog/en/modules/acqui/invoices.tt | 2 +- .../intranet-tmpl/prog/en/modules/acqui/parcel.tt | 33 +- .../prog/en/modules/acqui/supplier.tt | 13 +- .../prog/en/modules/admin/aqbudgetperiods.tt | 10 +- .../prog/en/modules/admin/aqcontract.tt | 8 +- .../prog/en/modules/admin/branches.tt | 4 +- .../intranet-tmpl/prog/en/modules/admin/cities.tt | 6 +- .../prog/en/modules/admin/items_search_fields.tt | 2 +- .../prog/en/modules/admin/preferences/patrons.pref | 2 +- .../en/modules/admin/preferences/web_services.pref | 2 +- .../prog/en/modules/admin/z3950servers.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt | 5 +- .../prog/en/modules/catalogue/advsearch.tt | 2 +- .../prog/en/modules/catalogue/detail.tt | 2 +- .../prog/en/modules/catalogue/itemsearch.tt | 12 +- .../prog/en/modules/cataloguing/editor.tt | 2 +- .../prog/en/modules/circ/circulation.tt | 58 +--- .../prog/en/modules/common/patron_search.tt | 8 + .../en/modules/course_reserves/course-details.tt | 2 +- .../prog/en/modules/members/boraccount.tt | 1 + .../prog/en/modules/members/discharge.tt | 2 +- .../prog/en/modules/members/memberentrygen.tt | 8 +- .../prog/en/modules/members/members-update.tt | 3 +- .../prog/en/modules/members/moremember.tt | 4 +- .../intranet-tmpl/prog/en/modules/members/pay.tt | 1 + .../prog/en/modules/members/paycollect.tt | 2 +- .../en/modules/members/tables/guarantor_search.tt | 2 +- .../prog/en/modules/offline_circ/list.tt | 13 +- .../prog/en/modules/patron_lists/list.tt | 2 +- .../en/modules/reports/guided_reports_start.tt | 15 +- .../prog/en/modules/reserve/request.tt | 48 +-- .../prog/en/modules/suggestion/suggestion.tt | 2 +- .../intranet-tmpl/prog/en/modules/tags/review.tt | 30 +- .../tools/automatic_item_modification_by_age.tt | 321 ++++++++------------ .../intranet-tmpl/prog/en/modules/tools/export.tt | 69 +++-- .../prog/en/modules/tools/overduerules.tt | 2 +- .../prog/en/modules/tools/quotes-upload.tt | 2 +- .../intranet-tmpl/prog/en/modules/tools/upload.tt | 105 ++++--- .../prog/en/modules/virtualshelves/shelves.tt | 2 +- .../intranet-tmpl/prog/en/xslt/MARC21slim2MADS.xsl | 3 + .../prog/en/xslt/NORMARCslim2intranetDetail.xsl | 3 + .../prog/en/xslt/NORMARCslimUtils.xsl | 3 + .../prog/en/xslt/UNIMARCslim2intranetResults.xsl | 3 + .../prog/js/automatic_item_modification_by_age.js | 125 ++++++++ koha-tmpl/intranet-tmpl/prog/js/members.js | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-account.tt | 5 +- .../opac-tmpl/bootstrap/en/modules/opac-auth.tt | 152 +++++---- .../bootstrap/en/modules/opac-discharge.tt | 4 +- .../bootstrap/en/modules/opac-memberentry.tt | 4 +- members/pay.pl | 1 + members/paycollect.pl | 3 +- opac/opac-addbybiblionumber.pl | 2 +- opac/opac-export.pl | 13 +- svc/config/systempreferences | 2 +- t/00-load.t | 43 ++- t/00-valid-xml.t | 2 +- t/External/BakerTaylor.t | 33 ++ t/{External_Syndetics.t => External/Syndetics.t} | 0 t/Languages.t | 3 + t/OpenLibrarySearch.t | 10 +- t/Prices.t | 20 +- t/Ris.t | 8 +- t/db_dependent/Auth.t | 42 ++- t/db_dependent/External_BakerTaylor.t | 34 --- t/db_dependent/Hold.t | 6 +- t/db_dependent/Letters.t | 4 +- t/db_dependent/Members/Attributes.t | 34 ++- t/db_dependent/Members/Statistics.t | 20 ++ t/db_dependent/SIP/Message.t | 26 +- 107 files changed, 1077 insertions(+), 723 deletions(-) create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/circ-patron-search-results.inc create mode 100644 koha-tmpl/intranet-tmpl/prog/js/automatic_item_modification_by_age.js create mode 100755 t/External/BakerTaylor.t rename t/{External_Syndetics.t => External/Syndetics.t} (100%) delete mode 100755 t/db_dependent/External_BakerTaylor.t create mode 100644 t/db_dependent/Members/Statistics.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jun 15 14:17:24 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 15 Jun 2016 12:17:24 +0000 Subject: [koha-commits] main Koha release repository branch 16.05.x updated. v16.05.00-99-ga0fb3fd Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 16.05.x has been updated via a0fb3fdf1a057dba56eb05ba6997d901bfcb9645 (commit) via ac71c2e7da2777e3bb1cb4c457412dc7b0e94776 (commit) via b68e1038feffc75b1c81cee193e80564213f30d3 (commit) via 947690e2324c72cba4ceca8790a98bcdf30752a8 (commit) via b4d40f7d00b38eeb006da58f016a109abae6235b (commit) via 9ef9f94707e7540cdda9b3bdc71a427a0b74e24d (commit) from a8534a4da728030d51647285cfb30b3f25a835c5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a0fb3fdf1a057dba56eb05ba6997d901bfcb9645 Author: Kyle M Hall Date: Tue Jun 14 16:35:49 2016 +0000 Bug 10459 - Update Schema Signed-off-by: Kyle M Hall (cherry picked from commit 42cd9ca1447f4d576d9f1ad51e275e70c8bf9249) Signed-off-by: Fr?d?ric Demians commit ac71c2e7da2777e3bb1cb4c457412dc7b0e94776 Author: Fr?d?ric Demians Date: Fri Jun 10 17:15:21 2016 +0000 Bug 10459 - DBRev 16.05.00.002 Signed-off-by: Fr?d?ric Demians commit b68e1038feffc75b1c81cee193e80564213f30d3 Author: Jonathan Druart Date: Tue Jun 7 10:20:53 2016 +0100 Bug 10459: Add tests for borrowers.updated_on Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall (cherry picked from commit ff9de4138a7544f08f835acae93aca124c8efa89) Signed-off-by: Fr?d?ric Demians commit 947690e2324c72cba4ceca8790a98bcdf30752a8 Author: Mark Tompsett Date: Wed May 25 21:57:34 2016 -0400 Bug 10459 renamed timestamp to updated_on Signed-off-by: Joy Nelson Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall (cherry picked from commit f863e478b994f2631d79821473c773099dc78172) Signed-off-by: Fr?d?ric Demians commit b4d40f7d00b38eeb006da58f016a109abae6235b Author: Marcel de Rooy Date: Mon Nov 10 14:17:40 2014 +0100 Bug 10459: Borrowers should have a timestamp This patch adds a timestamp column to the borrowers table in kohastructure and updatedatabase. (And also to the deletedborrowers table.) A timestamp may be useful in synchronizing with external systems (among other reasons). Test plan: Run updatestructure on an existing database, or install a new one. Verify that the borrowers table has a timestamp now. Signed-off-by: Marcel de Rooy Tested updatestructure and running kohastructure.sql. Passed t/db_dependent/Members.t. updatedatabase.pl did not apply. I edited and then run it. Columns were added as expected. Signed-off-by: Marc Veron Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Mark Tompsett Signed-off-by: Joy Nelson Bug 10459: Follow up to update to atomic update methodology Signed-off-by: Bernardo Gonzalez Kriegel New column created, no errors. Signed-off-by: Mark Tompsett Signed-off-by: Joy Nelson Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall (cherry picked from commit 255596ae6c483caf5746745f3656b56e0ea011b4) Signed-off-by: Fr?d?ric Demians commit 9ef9f94707e7540cdda9b3bdc71a427a0b74e24d Author: Fr?d?ric Demians Date: Wed Jun 15 13:56:19 2016 +0200 RMaint: Fix numbering mix with master ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- Koha/Schema/Result/Borrower.pm | 18 ++++++++++++++++-- Koha/Schema/Result/Deletedborrower.pm | 18 ++++++++++++++++-- installer/data/mysql/kohastructure.sql | 2 ++ installer/data/mysql/updatedatabase.pl | 30 ++++++++++++++++++++++-------- t/db_dependent/Patrons.t | 15 +++++++++++++-- 6 files changed, 70 insertions(+), 15 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 09:03:49 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 07:03:49 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-14-g954e410 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 954e4107c575a68f708f56ee6e11dd0f5cc28bab (commit) via 3454c9a658335aae8c1c4ccc9dedfd36dcbcb163 (commit) via 8d6486013b504fa652b43b2a20c3bb4da25034fd (commit) via 5d1f6b08cc7ef12975eb6637459204b9153de5a2 (commit) via dd94d1bc4ca68d8466b4d7fb154c6714a7782b58 (commit) via 858e3b2043e0eb1ce5bb9a6c36b3b87afb69ae22 (commit) from 3b1a7ba719b02b5b2dfaa30ddc368d1c034b3cd6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 954e4107c575a68f708f56ee6e11dd0f5cc28bab Author: Kyle M Hall Date: Mon May 23 14:28:10 2016 +0000 Bug 16569 - Message box for "too many checked out" is empty if AllowTooManyOverride is not enabled If the limit for number of items checked out is reached, the message box shows up but is empty. Test Plan: 1) Disable AllowTooManyOverride 2) Check out items to a patron until the patron has reached the limit of checkouts he or she can have 3) Try to check out one more item 4) Note the empty message box 5) Apply this patch 6) Try to check out one more item again 7) Note the message is now visible Signed-off-by: Nicolas Legrand Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher (cherry picked from commit af43f91335b2258ea39b40247a1492ca41dafe2a) Signed-off-by: Fr?d?ric Demians (cherry picked from commit a47180eb3bc0ca26a018f68ffcc4d5635f6f7789) Signed-off-by: Julian Maurice commit 3454c9a658335aae8c1c4ccc9dedfd36dcbcb163 Author: Jonathan Druart Date: Thu May 26 11:07:47 2016 +0100 Bug 16597: Fix XSS in shelves.pl Reported by Alex Middleton at Dionach Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher (cherry picked from commit fa1dd408ca7714aed406ff75d3c4c55545b97cf0) Signed-off-by: Julian Maurice commit 8d6486013b504fa652b43b2a20c3bb4da25034fd Author: Chris Cormack Date: Thu May 26 21:33:33 2016 +1200 Bug 16597: Fix XSS in opac-shareshelf To test 1/ Go to /cgi-bin/koha/opac-shareshelf.pl?op=">&shelfnumber=5 2/ Notice you see a js alert 3/ Apply patch 4/ It is gone Reported by Alex Middleton at Dionach Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher (cherry picked from commit c47c835672a8fcd8c7df79663443f01639fc7657) Signed-off-by: Julian Maurice commit 5d1f6b08cc7ef12975eb6637459204b9153de5a2 Author: Chris Cormack Date: Thu May 26 21:06:18 2016 +1200 Bug 16597: Fix XSS in opac-shelves.pl To test 1/ Hit /cgi-bin/koha/opac-shelves.pl?shelfnumber=5&category=1&op=edit_form&referer="> 2/ Notice JS is executed 3/ Apply patch 4/ Notice it's fixed This bug reported by Alex Middleton at Dionach Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher (cherry picked from commit 344033c32490df3e396ed530dcbf250086483371) Signed-off-by: Julian Maurice commit dd94d1bc4ca68d8466b4d7fb154c6714a7782b58 Author: Jonathan Druart Date: Thu May 26 12:08:30 2016 +0100 Bug 16599: Fix other potentials XSS for shelfname Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher (cherry picked from commit bb4543f7db62836b048c632a0a184acb021286ad) Signed-off-by: Julian Maurice commit 858e3b2043e0eb1ce5bb9a6c36b3b87afb69ae22 Author: Jonathan Druart Date: Thu May 26 12:03:55 2016 +0100 Bug 16599: Fix XSS in opac-shareshelf.pl Test plan: - Create a list with the name "" - On the shelf list, click on share => Without this patch you will see the JS alert => With this patch applied you won't see it Reported by Kaybee at Dionach Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher (cherry picked from commit a44a930c076fceca0f7193f488e187d9849f89b6) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 2 +- .../intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadshelf.tt | 6 +++--- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt | 6 +++--- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves-rss.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 2 +- 7 files changed, 11 insertions(+), 11 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 09:09:04 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 07:09:04 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-15-g12904eb Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 12904eb27fb3909205321b6c662c62ed5cb72bd5 (commit) from 954e4107c575a68f708f56ee6e11dd0f5cc28bab (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 12904eb27fb3909205321b6c662c62ed5cb72bd5 Author: Owen Leonard Date: Wed May 18 19:45:27 2016 -0400 Bug 16548 - All libraries selected on Tools -> Export Data screen This patch adds "select all" and "select none" links to the display of libraries in the export bibliographic records form. Also modified: call number range and accession date fields have been grouped in their own fieldsets in the hopes that this is more readable. Page title and breadcrumbs have been corrected to read "Export data" instead of "MARC export," matching menu items. To test, apply the patch and go to Tools -> Export data. - Test the select all/select none links and confirm that they work as expected. - Confirm that the structural changes to the form look okay. Signed-off-by: Nick Clemens Post sign-off revision: Use the standard "Clear all" instead of "Select none." Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher (cherry picked from commit 06b9194cdd178f14347b8f9090657dbf5b712450) Signed-off-by: Fr?d?ric Demians (cherry picked from commit a85be57e1ce1d2adde6b9ee3dba55f7c5f2e06ab) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: .../prog/en/includes/branch-selector.inc | 5 +- .../intranet-tmpl/prog/en/modules/tools/export.tt | 69 +++++++++++++------- 2 files changed, 50 insertions(+), 24 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 09:18:14 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 07:18:14 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-16-g8474209 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 8474209c40f3364b2a85bec3f1e4ed6ece9c4bba (commit) from 12904eb27fb3909205321b6c662c62ed5cb72bd5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8474209c40f3364b2a85bec3f1e4ed6ece9c4bba Author: Robin Sheat Date: Wed May 25 16:19:09 2016 +0200 Bug 16617 - fix issues with debian/control Signed-off-by: Chris Cormack Signed-off-by: Jesse Weaver Signed-off-by: Brendan Gallagher (cherry picked from commit e604538283ef3531aaa769dee70c83cdec942656) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 8b9812fa83c110c446b58b6b1188d67d20011430) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: debian/control | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 09:25:37 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 07:25:37 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-19-gd4bf05b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via d4bf05b0544e2b7336bd76c7d8b319cc9d2a362c (commit) via 36303e71f60f6ba21b7349b37682db202e93e329 (commit) via 17514959011434f9d868b8f7f553104228718789 (commit) from 8474209c40f3364b2a85bec3f1e4ed6ece9c4bba (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d4bf05b0544e2b7336bd76c7d8b319cc9d2a362c Author: Brendan Gallagher Date: Tue May 31 08:56:42 2016 +0000 Bug 16200: Update DB rev (3.22.07.001) commit 36303e71f60f6ba21b7349b37682db202e93e329 Author: Lari Taskula Date: Tue May 17 14:44:45 2016 +0300 Bug 16200: Convert all existing expired holds accounttype to HE Before Bug 16200 expired holds have used accounttype F which is also used by other type of fines. This patch updates all existing expired holds to new accounttype HE (Hold Expired). To test: -1. Make sure you translated the string in previous patch of this buug 1. Find a Patron with "Hold waiting too long" fines and go to his Fines tab 2. Change Koha's language to some other than English 3. Observe that "Hold waiting too long" is still in English 4. Apply patch and run database update 5. Go back to Patron's Fines tab 6. Observe that "Hold waiting too long" is now translated Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher (cherry picked from commit 09de19c427c1e99d7e921210ed39cb6a19737317) Signed-off-by: Fr?d?ric Demians (cherry picked from commit d80368370258432aab4d4171b886af26442d08c1) Signed-off-by: Julian Maurice commit 17514959011434f9d868b8f7f553104228718789 Author: Lari Taskula Date: Tue May 17 14:33:57 2016 +0300 Bug 16200: Make 'Hold waiting too long' translatable and give it an unique accounttype Holds that have expired have been untranslatable in Patron's Fines-tab. Also, they are mixed with other type of fines with accounttype "F". This patch gives expired holds an own accounttype "HE" (Hold Expired) and modifies the boraccount to recognize this new accounttype in order to make it translatable. To test: 1. Make a hold and let it expire 2. Go to Patron's Fines tab 3. Change Koha's language to some other than English 4. Observe that there is a "Hold waiting too long" fine described in English 5. Apply patch 6. Make another hold and let it expire 7. Update translations 8. Find "Hold waiting too long" from your .po file 9. Translate it and install translations 10. Go back to Fines tab and observe that the new expired hold is translated Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher (cherry picked from commit 7163fcfeea382e1e042a47a76d384155e8c69bc0) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 326616d2bce77b245e0d38eb3df659e821130645) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Reserves.pm | 2 +- Koha.pm | 2 +- installer/data/mysql/updatedatabase.pl | 12 ++++++++++++ .../intranet-tmpl/prog/en/modules/members/boraccount.tt | 1 + koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt | 1 + koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account.tt | 1 + 6 files changed, 17 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 09:38:33 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 07:38:33 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-20-ge876a71 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via e876a7112b27be193f41d474c08136594e05aecf (commit) from d4bf05b0544e2b7336bd76c7d8b319cc9d2a362c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e876a7112b27be193f41d474c08136594e05aecf Author: Owen Leonard Date: Mon Mar 7 12:12:40 2016 -0500 Bug 16001 - Use standard message dialog when there are no cities to list If there are no existing cities in Administration -> Cities and Towns, the message saying so should be in the standard message dialog. Another minor change: Edit the message to say "There are no cities defined," which I think reads better in English. To test you must have no cities and towns defined. Apply this patch and go to Administration -> Cities and Towns. You should see a message displayed in a standard "message" style dialog. Signed-off-by: Bernardo Gonzalez Kriegel Better view, no errors Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher (cherry picked from commit 89b41ede653227c5b4f777d6a4b30422ab473153) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 300cfc1ac8ae979b737b584e303823059d34680e) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 09:42:10 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 07:42:10 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-21-gbe21661 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via be21661a31faf90b5384f2807e92d938c2dfb848 (commit) from e876a7112b27be193f41d474c08136594e05aecf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit be21661a31faf90b5384f2807e92d938c2dfb848 Author: Aleisha Date: Mon May 16 01:10:43 2016 +0000 Bug 16525: Have cancel button when adding new aq budget At the moment you only see the cancel button on the form if editing an existing budget. This patch adds a cancel button to the form which adds a budget. Also changes the wording of the save button from 'Save changes' to just 'Save' so it makes more sense when adding a new budget To test: 1) Go to Admin -> Budgets -> New budget 2) Notice 'Save changes' button and no cancel 3) Apply patch and refresh page 4) Notice 'Save' button and 'cancel' link 5) Click 'cancel' - should be taken to Budgets administration page 6) Edit an existing budget 7) Click 'cancel' - should be taken to the funds page for that budget Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Sabine Liebmann Signed-off-by: Jonathan Druart Still an issue: If edit a budget fron aqbudgets.pl, then cancel, you get aqbudgets.pl?budget_period_id=XX. But existed before this patch. Signed-off-by: Brendan Gallagher (cherry picked from commit c4f17a6eb3e5688b1d1f3c4b578f17ae80e46f8f) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 0c4661110c467c8d11631cc627395acef941c9c9) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 09:45:19 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 07:45:19 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-22-g26cd82e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 26cd82e15c912785a035cae12a06e090620d4acf (commit) from be21661a31faf90b5384f2807e92d938c2dfb848 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 26cd82e15c912785a035cae12a06e090620d4acf Author: Aleisha Date: Fri May 13 00:46:40 2016 +0000 Bug 16511: Making contracts actions buttons To test: 1) Go to Acqui -> find a vendor 2) On Vendor details page (supplier.pl) confirm that Contracts table now has one column called Actions 3) Confirm that Edit and Delete show as buttons 4) Confirm that buttons don't wrap on a narrower browser 5) Click Contracts tab 6) Confirm Actions column, Edit and Delete buttons, and button's don't wrap Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher (cherry picked from commit 23c8dc0e6384779c0eaf8441d598b60ac6aea46e) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 92c08a6a4e177622a4513fa34c81dfcbec20ec57) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt | 11 ++++++----- koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqcontract.tt | 8 +++++--- 2 files changed, 11 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 09:52:16 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 07:52:16 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-25-g8d9a484 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 8d9a4841e4be97f53c94282f08f0e53bdaf6487f (commit) via ea598df62484d62db140f988002ae2cbcf16d98e (commit) via fc2776a5c9ca3015b86de2db763de1c8fe59d249 (commit) from 26cd82e15c912785a035cae12a06e090620d4acf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8d9a4841e4be97f53c94282f08f0e53bdaf6487f Author: Marcel de Rooy Date: Tue May 31 14:16:07 2016 +0200 Bug 16504: [QA Follow-up] Make koha-qa happy with two newlines Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher (cherry picked from commit 567a1a9021aaea3bf42b19f493b79f682ed9042b) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 5712275a4645d4d899815120fe79e730edf1034e) Signed-off-by: Julian Maurice commit ea598df62484d62db140f988002ae2cbcf16d98e Author: Jonathan Druart Date: Fri May 13 14:43:52 2016 +0100 Bug 16504: (follow-up for bug 15163) Do not remove attributes of other patrons Simple patch for a silly error, this single line is going to fix a critical bug. If a patron attribute is limited to a library, all the values for that attributes for every patrons will be deleted. Test plan: Create a patron attribute limited to a library Set the the attribute for a patron Set the the attribute for another patron => Without this patch applied, the attribute's value for the first patron is deleted => With this patch applied, the 2 values exist in the DB after the second edition Signed-off-by: Srdjan Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher (cherry picked from commit da94410ab5022c3bd97fba1878673149802db584) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 247bd55876a4e930934419070fc926a656a0d9d7) Signed-off-by: Julian Maurice commit fc2776a5c9ca3015b86de2db763de1c8fe59d249 Author: Jonathan Druart Date: Fri May 13 14:42:52 2016 +0100 Bug 16504: Add regression tests Signed-off-by: Srdjan Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher (cherry picked from commit 72bd06e3a88f62fcfe8710773091447ebafebcb3) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 5949faae071c317c029c9c89320c52d73cd7a362) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Members/Attributes.pm | 4 +++- t/db_dependent/Members_Attributes.t | 34 +++++++++++++++++++++++++++++++++- 2 files changed, 36 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 09:55:50 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 07:55:50 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-26-g3cd0ac2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 3cd0ac25fa7f3bc4aa60d2b4b24f0ddd05839606 (commit) from 8d9a4841e4be97f53c94282f08f0e53bdaf6487f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3cd0ac25fa7f3bc4aa60d2b4b24f0ddd05839606 Author: Kyle M Hall Date: Fri May 27 12:42:17 2016 +0000 Bug 16610 - Regression in SIP2 user password handling Previous to bug 14507, SIP2 only did internal authentication. A change to the way we check empty passwords has caused any empty password to send back a CQ of Y. Previous to that patch set, a CQ of Y would only be sent back of the patron password column was NULL. Now, an empty AD field *always* returns a CQ of Y. Test Plan: 1) Send a patron information request with an empty AD field Note: You must send the AD field or you won't get back a CQ field 2) Note you get back a CQ of Y 3) Apply this patch 4) Repeat step 1 5) Note you now get back a CQ of N Signed-off-by: Trent Roby Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher (cherry picked from commit 71f0370ddde0d8b8e2a666a091081186fb6531e8) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 66c9ef12c16efeebf78e3a98be7b2ccc42d14e7a) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/SIP/ILS/Patron.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 09:59:03 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 07:59:03 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-27-g2131a6d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 2131a6dec2a7588be8b6061e97b945fa69da0953 (commit) from 3cd0ac25fa7f3bc4aa60d2b4b24f0ddd05839606 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2131a6dec2a7588be8b6061e97b945fa69da0953 Author: Mark Tompsett Date: Tue May 24 22:31:15 2016 -0400 Bug 16582 t/Price.t test should pass if Test::DBIx::Class is not available TEST PLAN --------- 1) prove t/Prices.t -- failure 2) apply patch 3) prove t/Prices.t -- nicely skipped when Test::DBIx::Class is not available. Signed-off-by: Srdjan Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher (cherry picked from commit 5ba5f9e0c5958b518bd648f08146329e355f3a7e) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 65232361231f5006f25cc354e24b38b07f359d61) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: t/Prices.t | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 10:03:23 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 08:03:23 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-28-g8f8ba80 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 8f8ba80f2e290765d8c7307f812f39e00cc48fa1 (commit) from 2131a6dec2a7588be8b6061e97b945fa69da0953 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8f8ba80f2e290765d8c7307f812f39e00cc48fa1 Author: Jonathan Druart Date: Mon May 23 12:19:46 2016 +0100 Bug 16565: Drop additional_fields and additional_field_values before creating them These 2 tables should be dropped before trying to create them Test plan: From the SQL CLI, source the kohastructure.sql file source it again => Without this patch you get 2 warnings ERROR 1050 (42S01) at line 3580 in file: 'installer/data/mysql/kohastructure.sql': Table 'additional_fields' already exi sts ERROR 1050 (42S01) at line 3596 in file: 'installer/data/mysql/kohastructure.sql': Table 'additional_field_values' alrea dy exists => With this patch, you won't get them Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher (cherry picked from commit a01cd77e19f810bf61c8d26ebb97f7c49f1d1f32) Signed-off-by: Fr?d?ric Demians (cherry picked from commit b49adab4a1c4bb08714371223572caf35460f0f4) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/kohastructure.sql | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 10:03:56 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 08:03:56 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-29-g5976b4f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 5976b4f16fb356179c7185161f61febb13eda6f5 (commit) from 8f8ba80f2e290765d8c7307f812f39e00cc48fa1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5976b4f16fb356179c7185161f61febb13eda6f5 Author: Claire Gravely Date: Fri Jun 3 10:38:25 2016 +0200 Bug 16642 - Fix capitalisation for upload patron image To fix capitalisation on the staff interface when patronimages is turned on. Test plan: 1. In staff interface. Turn on patronimages sys preference. 2. Go to a patron without an image and check that the "Upload patron image" box heading now has correct capitalisation. 3. Go to a patron with an image already uploaded and check the "Manage patron image" box heading has correct capitalisation. Signed-off-by: Sofia Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher (cherry picked from commit 78b2fde34831a4840f6b89df054a5307f1ead54b) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 9a2c6bfde243f0fe41112fe1b651273ab091c901) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 10:05:27 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 08:05:27 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-30-gb5934c4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via b5934c48ad71efb7d9929d74e2c9729d33d5d9fc (commit) from 5976b4f16fb356179c7185161f61febb13eda6f5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b5934c48ad71efb7d9929d74e2c9729d33d5d9fc Author: Jonathan Druart Date: Wed May 4 19:53:46 2016 +0100 Bug 16442: Make C4::Ris plack safe C4::Ris incorrectly uses 4 package variables: - $utf: not used, can be removed - $intype: set to marcflavour once, but later it assumes that it is usmarc if not defined - $marcprint: always 0, so set it to 0 - $protoyear: only used in 1 subroutine, let's define it at this level Test plan: Just make sure the RIS export works as before this patch Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher (cherry picked from commit 87b181c6d40e7a811fee511648ddd3cb7d44c4e4) Signed-off-by: Fr?d?ric Demians (cherry picked from commit a987ff3ba92e1558e11a63335895749b5efd1689) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Ris.pm | 38 ++++++++++++++++---------------------- 1 file changed, 16 insertions(+), 22 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 10:21:34 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 08:21:34 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-31-g2bb2e25 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 2bb2e2520cf0c03b4902816f29c98a67b9645b64 (commit) from b5934c48ad71efb7d9929d74e2c9729d33d5d9fc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2bb2e2520cf0c03b4902816f29c98a67b9645b64 Author: Jonathan Druart Date: Wed May 11 12:00:01 2016 +0100 Bug 16458: Update library when a guarantor is set If you edit a patron from the Edit link of the patron information block (step 1 of the memberentry script), the branchcode is not displayed. If you set a guarantor to a child from this form, a JavaScript error will be raised: JavaScript error form.branchcode is undefined It happens because there is the branchcode is not displayed and there is no element with a branchcode name. To avoid this issue, a branchcode hidden input is added to the form and it will be updated when a guarantor is selected (same behavior as when you edit a patron using the complete form). Test plan: Edit a patron using the Edit link of the patron info block (not the Edit button in the toolbar) Set a guarantor => Notice that the branchcode of the patron has been updated with the branchcode of the guarantor Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher (cherry picked from commit fc35a5099f613c08d12be1d67fd027d4a5eaf99c) Signed-off-by: Fr?d?ric Demians (cherry picked from commit b7a0322258ad534ea8e5af34cb0581b0b5f174e8) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 10:23:32 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 08:23:32 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-32-g73df494 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 73df494cca052a794525562aa4da85ada1ad2d47 (commit) from 2bb2e2520cf0c03b4902816f29c98a67b9645b64 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 73df494cca052a794525562aa4da85ada1ad2d47 Author: Jonathan Druart Date: Wed May 4 20:20:51 2016 +0100 Bug 16444: Make C4::Tags plack safe C4::Tags use a package variable to cache the pref TagsExternalDictionary, it's not needed and not safe. There is not test plan, just make sure the changes are consistent. Signed-off-by: Srdjan Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher (cherry picked from commit fff754a7fc7a99dad6a35129b8a7dd170684f2bf) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 97a3f03970e1aa8d3eba5e5502f092202e43349b) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Tags.pm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 10:24:48 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 08:24:48 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-33-g20cbdd2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 20cbdd23116d112ce61be170fe47ec047b08b840 (commit) from 73df494cca052a794525562aa4da85ada1ad2d47 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 20cbdd23116d112ce61be170fe47ec047b08b840 Author: Rocio Dressler Date: Sat Jun 4 02:24:45 2016 -0700 Bug 16537 - Overdue and Status triggers grammar Test plan: 1) Go to the staff client 2) Click on Tools - Overdue notice/status triggers 3) Confirm that the first sentence reads "a" checkout rather than "an" checkout Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher (cherry picked from commit a589879f495aeb25200119cb4f1bf76c28dce660) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 020d755ed061cfc94ca12eace6fae7388cc89e3e) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 10:25:49 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 08:25:49 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-34-g825d496 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 825d4961940ff069d50e0ded05c4c5f2187afe98 (commit) from 20cbdd23116d112ce61be170fe47ec047b08b840 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 825d4961940ff069d50e0ded05c4c5f2187afe98 Author: Aliki Pavlidou Date: Sat Jun 4 12:10:38 2016 +0000 Bug 15641 - Typo in explanation for MembershipExpiryDaysNotice There's an extra period after the word "in" in the MembershipExpiryDaysNotice sys "Send an account expiration notice when a patron's card will expire in. [value box Bug fixed! Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher (cherry picked from commit 6b7f4a3a9ec18b550d011a7eee9e7108b7042059) Signed-off-by: Fr?d?ric Demians (cherry picked from commit e242625721b0dcd68cd7b3408ef9da5d367a878d) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 10:27:08 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 08:27:08 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-35-g37a0ba4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 37a0ba4f1079e9874684b01dad12203519e8cfe3 (commit) from 825d4961940ff069d50e0ded05c4c5f2187afe98 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 37a0ba4f1079e9874684b01dad12203519e8cfe3 Author: Jonathan Druart Date: Fri May 13 20:46:42 2016 +0100 Bug 16518: Fix Plack variable scoping problem in opac-addbybiblionumber.pl The script opac/opac-addbybiblionumber.pl is not plack safe because the variable @biblios is declared with our and is not assigned to an empty array (so not reset). The issue: When trying to add items to a list (virtualshelf), the biblionumbers are added to the @biblios variable and the list is not reset between each run. Test plan: Check from records from the result list and add them to a list. Cancel or save and re-add them (or others) to a list (same or different). => Without this patch, the list of records will never stop growing, the previous items added are still listed when adding new ones. => With this patch, the behavior is the one expected. Signed-off-by: Srdjan Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher (cherry picked from commit ab1beed06f249d1e7d0be5bb1b584e62f5b48783) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 2729f038c34b5c4f0b713738c9bf4a94068f1b43) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: opac/opac-addbybiblionumber.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 10:27:52 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 08:27:52 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-36-g13bb412 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 13bb412c73ce433fc82c9829502860eee0f1a397 (commit) from 37a0ba4f1079e9874684b01dad12203519e8cfe3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 13bb412c73ce433fc82c9829502860eee0f1a397 Author: Jonathan Druart Date: Tue May 17 14:38:04 2016 +0100 Bug 16508: Updating a syspref requires parameters_remaining_permissions And not all of parameters flags. Test plan: 1/ Create a staff user. 2/ Go to details, select more->set permissions. 3/ Set catalogue, Manage Koha system settings (Administration panel), manage circulation rules, and Remaining system parameters permissions. 4/ Log in as the new staff user, go to administration > system preferences. Change a syspref and save it... it will save correctly. 5/ Log back in as superlibrarian 6/ On the 'set permissions' screen, un-check 'manage circulation rules' and save. 7/ Log back in to the new staff user, and try to change the same systemprefrence and save. Followed test plan, works as expected. Signed-off-by: Marc Veron Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher (cherry picked from commit f2fe433cf9afce98957826bf2ade457557fe4eff) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 259fe9947b73023a22aceda2b7f7ad357500884f) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: svc/config/systempreferences | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 10:30:25 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 08:30:25 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-37-g2074138 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 207413828318c4515053c7043dadb5ee934f3b2f (commit) from 13bb412c73ce433fc82c9829502860eee0f1a397 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 207413828318c4515053c7043dadb5ee934f3b2f Author: Jonathan Druart Date: Thu May 5 16:58:06 2016 +0100 Bug 16455: Remove the "Too late to run INIT block" from C4::Tags The pref TagsExternalDictionary is used to tell Lingua::Ispell to use an other dictionary, different from the default one (/usr/bin/ispell). To do so we need to set $Lingua::Ispell::path to the expected path. It's currently done in the INIT block. If you try to use C4::Tags, you will get the famous "Too late to run INIT block at C4/Tags.pm line 74." warning. Plack use the INIT block to load functions at run time, when we are using C4::Tags when hitting a pl script, the compilation phase is finished and it's "too late to run INIT block" from C4::Tags. I do not really know if it has an impact on the behavior of Lingua::Ispell (i.e. is the path redefined?), but I know that this INIT block is not executed when we want. Test plan: under Plack, - hit /cgi-bin/koha/opac-search.pl and confirm that the warning does no longer appears - Use another dictionnary (??), fill TagsExternalDictionary with its path and confirm that it is used by the tags approval system Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher (cherry picked from commit 7d916c380a03904c47035f189d1ee666f00d9a11) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 6ff159e214a2ebf904ff7f1b77f0f75162f8afe8) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Tags.pm | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 10:31:41 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 08:31:41 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-39-gbf40e2b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via bf40e2b333dd4705983686d60e4c7dd4c83c4a2e (commit) via bd17c1f8749e97aa773dffe5b5d787c676a5e2f3 (commit) from 207413828318c4515053c7043dadb5ee934f3b2f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bf40e2b333dd4705983686d60e4c7dd4c83c4a2e Author: Marcel de Rooy Date: Fri Jun 10 11:49:45 2016 +0200 Bug 16443: [QA Follow-up] Add two tests for get_fields Adds t/db_dependent/Members/Statistics.t. Test plan: Run the test. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall (cherry picked from commit 30cf9ee277481b54ed75e500c38f328f2d82b831) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 03d51281b079c379a2fba0caf8a9df8ec9c6d500) Signed-off-by: Julian Maurice commit bd17c1f8749e97aa773dffe5b5d787c676a5e2f3 Author: Jonathan Druart Date: Wed May 4 20:08:53 2016 +0100 Bug 16443: Make C4::Members::Statistics plack safe If the prefs is updated, the fields won't be. To make sure we already fetch updated values, we should remove the package variable and define it in the subroutine. There is not test plan, just make sure the changes are consistent. Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall (cherry picked from commit 29e402d398f567e2526c89695384bce7f4e4b737) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 93ffd58fe32dd4e27056f5cebf18b975f3d0624b) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Members/Statistics.pm | 5 +---- t/db_dependent/Members/Statistics.t | 20 ++++++++++++++++++++ 2 files changed, 21 insertions(+), 4 deletions(-) create mode 100644 t/db_dependent/Members/Statistics.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 10:38:36 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 08:38:36 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-41-g679d041 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 679d0414a02d2704508aa9ff7fd0b528c7578013 (commit) via 799ac3cb869adc134bd1aa420fc99a79b335ad24 (commit) from bf40e2b333dd4705983686d60e4c7dd4c83c4a2e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 679d0414a02d2704508aa9ff7fd0b528c7578013 Author: Jonathan Druart Date: Tue Jun 7 11:48:46 2016 +0100 Bug 16441: Fix Letters.t These tests were wrong, but the package variable used to cache the letters hid the problem. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit 687a7e22b6c630c3bbc06e1845854514f6fea5b0) Signed-off-by: Fr?d?ric Demians (cherry picked from commit a44040d07d24707d2cda51d989ad0fa495116608) Signed-off-by: Julian Maurice commit 799ac3cb869adc134bd1aa420fc99a79b335ad24 Author: Jonathan Druart Date: Wed May 4 19:43:43 2016 +0100 Bug 16441: Do not use a package variable to cache C4::Letters::getletter C4::Letters::getletter use a package variable (%letter) to cache letter returned by the subroutine. I have not found any direct issues caused by that but it is safer to remove it. It won't be a big deal to hit the DBMS to get a valid letter when needed. No test plan here, just confirm that the changes make sense. Signed-off-by: Srdjan Signed-off-by: Marcel de Rooy Confirm that performance loss is just a millisecond or so per subsequent call of getletter. Signed-off-by: Kyle M Hall (cherry picked from commit c4f388f64966f2202e9f3e3c16dad5cef3dbe0ac) Signed-off-by: Fr?d?ric Demians (cherry picked from commit c63dccba27842ce92569625a03df55085bf5681a) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Letters.pm | 11 ----------- t/db_dependent/Letters.t | 4 ++-- 2 files changed, 2 insertions(+), 13 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 10:41:59 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 08:41:59 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-43-gea04333 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via ea04333e539a40e663f8194996c6782ea12be547 (commit) via 9c03081053408aafe2d45afaea4761d46da2b36f (commit) from 679d0414a02d2704508aa9ff7fd0b528c7578013 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ea04333e539a40e663f8194996c6782ea12be547 Author: Marcel de Rooy Date: Wed May 11 15:47:46 2016 +0200 Bug 16428: [QA Follow-up] Useless call to GetMarcStructure in _build_default_values_for_mod_marc The routine calls GetMarcStructure and does not use its return value after all. Test plan: Run t/db_dependent/Items.t Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit 6a706b86a273672b1e1ca3f1456fde08dd7a0da2) Signed-off-by: Fr?d?ric Demians (cherry picked from commit b31ee2eaf9dd86171cac1598f3f9a611ea145f83) Signed-off-by: Julian Maurice commit 9c03081053408aafe2d45afaea4761d46da2b36f Author: Jonathan Druart Date: Tue May 3 11:03:52 2016 +0100 Bug 16428: Use the biblio framework to know if a field is mapped The subroutine _build_default_values_for_mod_marc takes the frameworkcode in parameter, but ModItemFromMarc did not pass it. It uses it to know if a field is mapped or not to a Koha field (C4::Koha::IsKohaFieldLinked). Consequently the default framework ("") was always used. This bug has been found working on bug 13074 and has been put on a separate bug report to ease the backport. Test plan: Without this change, the tests added by bug 16428 won't pass Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit 52b1b8eae1136af1e901560214a641494acaf577) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 4ebfb709f6cdeb263b579f7a3538c1a1342a939a) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Items.pm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 10:43:12 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 08:43:12 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-45-g0be92bc Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 0be92bcc013d715f2d63377cd98e4bfe9fb2b942 (commit) via d79a51ae9fbc6ff4966d247f6b9f906b75c197f3 (commit) from ea04333e539a40e663f8194996c6782ea12be547 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0be92bcc013d715f2d63377cd98e4bfe9fb2b942 Author: Jonathan Druart Date: Wed May 11 13:04:38 2016 +0100 Bug 16465: Fix typo issues vs checkouts Test plan: Confirm the wording is correct Signed-off-by: Srdjan Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit af59b669413539606f10652230e5f96d43337cb5) Signed-off-by: Fr?d?ric Demians (cherry picked from commit c5fc0fcd0e28309114c70333cb75a2aee11b35e0) Signed-off-by: Julian Maurice commit d79a51ae9fbc6ff4966d247f6b9f906b75c197f3 Author: Jonathan Druart Date: Wed May 11 12:57:47 2016 +0100 Bug 16465: discharge - Add a title tag at the OPAC Test plan: Confirm that the opac-discharge.pl has now a title Signed-off-by: Srdjan Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit 27254de06d8ae6682b395be48d6ba02b69f9e917) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 5ce7baf937d8e7ddf56ca0ae4dde00690fe5a32c) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/members/discharge.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-discharge.tt | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 10:44:41 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 08:44:41 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-47-geb8c112 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via eb8c112456fe874ef7065c62fa2a3bc20ca3f2ab (commit) via 27e63b7867d28da3e56830a80bbf36ff1f37e1a3 (commit) from 0be92bcc013d715f2d63377cd98e4bfe9fb2b942 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit eb8c112456fe874ef7065c62fa2a3bc20ca3f2ab Author: Jonathan Druart Date: Wed May 25 18:09:27 2016 +0100 Bug 16578: Same fix for the staff interface Signed-off-by: Bernardo Gonzalez Kriegel Works as first patch No errors Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 3948102f2ad6e5382a31a00df0c8f52def3daf58) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 43002c3b0e1659edc910cae435c3715a46e80a76) Signed-off-by: Julian Maurice commit 27e63b7867d28da3e56830a80bbf36ff1f37e1a3 Author: Tomas Cohen Arazi Date: Tue May 24 14:28:44 2016 -0300 Bug 16578: Fix wide character errors in opac-export.pl This simple patch fixes wide character warning raised by opac-export.pl when 'MARC (Unicode/UTF-8)' and 'MARC (Unicode/UTF-8, Standard)' formats are chosen for downloading records. To test: - Have records indexed - Open your OPAC logs: $ tail -f /var/log/koha/kohadev/opac-error.log - Open the detail page in the opac for a record - Choose Save record > MARC (Unicode/UTF-8) => FAIL: opac-export.pl: Wide character in print at /home/vagrant/kohaclone/opac/opac-export.pl line 116., referer: http://localh... - Choose Save record > MARC (Unicode/UTF-8, Standard) => FAILE opac-export.pl: Wide character in print... - Apply the patch - Choose Save record > MARC (Unicode/UTF-8) => SUCCESS: No warnings raised. - Choose Save record > MARC (Unicode/UTF-8, Standard) => SUCCESS: No warnings raised. - Sign off :-D Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 7d4844e171b1319b90e7bd73510bd97c2acbf635) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 164ffdb43c98b4d2fa193d80c48f5509294fa1ca) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: catalogue/export.pl | 3 +++ opac/opac-export.pl | 13 ++++++++----- 2 files changed, 11 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 10:53:18 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 08:53:18 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-48-g0bd65b6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 0bd65b6e1117470dfb5eebbd753babee02a839a1 (commit) from eb8c112456fe874ef7065c62fa2a3bc20ca3f2ab (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0bd65b6e1117470dfb5eebbd753babee02a839a1 Author: Jonathan Druart Date: Tue Apr 5 07:52:50 2016 +0100 Bug 16199: Remove C4::Ris::charconv This subroutine always returns what has been sent in parameter. It is unecessary and can be removed. Test plan: prove t/Ris.t should not be noisy Export a catalogue record in Ris should generate the same file with and without this patch NOTE: With/Without were identical in my testing. t/Ris.t is nicely silenced. Signed-off-by: Mark Tompsett Signed-off-by: Tomas Cohen Arazi Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com (cherry picked from commit 88dc70f7e691da61742f79c46c601de82a1d7e56) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Ris.pm | 53 ++++++++++++++++------------------------------------- t/Ris.t | 5 +---- 2 files changed, 17 insertions(+), 41 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 10:58:46 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 08:58:46 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-49-g6f26745 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 6f26745c21522465bd1d3d7c3368a6df650a4cea (commit) from 0bd65b6e1117470dfb5eebbd753babee02a839a1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6f26745c21522465bd1d3d7c3368a6df650a4cea Author: Jonathan Druart Date: Tue Jun 7 12:29:33 2016 +0100 Bug 16668: Fix t/Ris.t tests Caused by bug 16442. Now we need to mock the marcflavour pref Test plan: prove t/Ris.t should return green Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit 023384811f54f18fbe585431c49b80cfc20e58dd) Signed-off-by: Fr?d?ric Demians (cherry picked from commit a1f1ea03177204af1cb5dde29b5f18f339402bdb) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Ris.pm | 2 ++ t/Ris.t | 8 ++++---- 2 files changed, 6 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 11:09:00 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 09:09:00 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-50-g32bf30d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 32bf30da9d5cf182171861b5b2dadcab60d1c4b3 (commit) from 6f26745c21522465bd1d3d7c3368a6df650a4cea (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 32bf30da9d5cf182171861b5b2dadcab60d1c4b3 Author: Jonathan Druart Date: Wed Jun 8 14:52:04 2016 +0100 Bug 16695: Require Exception::Class 1.38 instead of 1.39 Looking at http://cpansearch.perl.org/src/DROLSKY/Exception-Class-1.40/Changes there is no need to require 1.39 Signed-off-by: Jacek Ablewicz Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit a4c44b9f643ab9a31c4025f6001a823fdcbb8101) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 700fbd0a35073dc3cef7b3e340ab806a21354ba1) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Installer/PerlDependencies.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 11:12:41 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 09:12:41 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-53-g51417fd Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 51417fde52baefbf8750f5690fb75c86820238fc (commit) via f952cf0b7f45d36a795db6fd8ac3ce8019e32488 (commit) via 853d297415c20a6a4fa42362185572006ee64192 (commit) from 32bf30da9d5cf182171861b5b2dadcab60d1c4b3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 51417fde52baefbf8750f5690fb75c86820238fc Author: Jonathan Druart Date: Wed Jun 8 15:32:31 2016 +0100 Bug 16492: Add a FIXME to explain the possible problem with no_set_userenv Signed-off-by: Kyle M Hall (cherry picked from commit 4f3067184d7dd3666d404a2165d72755cb0b227d) Signed-off-by: Fr?d?ric Demians (cherry picked from commit ac00e73077164db595432b723ee6f938e009dc7d) Signed-off-by: Julian Maurice commit f952cf0b7f45d36a795db6fd8ac3ce8019e32488 Author: Jonathan Druart Date: Wed May 25 17:33:00 2016 +0100 Bug 16492: Test that no_set_userenv will not set userenv if not exist yet Signed-off-by: Kyle M Hall (cherry picked from commit bb6e70fe7d4ba530fe64179fe6fde4d6b4ec5e35) Signed-off-by: Fr?d?ric Demians (cherry picked from commit f69eeca6c4a7d7d4b0538e7964a0f5f190de4b4e) Signed-off-by: Julian Maurice commit 853d297415c20a6a4fa42362185572006ee64192 Author: Kyle M Hall Date: Tue May 10 16:36:03 2016 +0000 Bug 16492 - Checkouts ( and possibly checkins and other actions ) will use the patron home branch as the logged in library Bug 14507 introduced the use of checkpw in C4::SIP::ILS::Patron so that non-Koha internal authentication processes would be able to function via SIP ( LDAP et al ). The problem is that checkpw changes the userenv to that of the patron! This is not usually an issue in Koha because most of the time that patron running through checkpw is the one to be logged in. Aside from SIP2 the only other area where this may be an issue is in SCO when using SelfCheckoutByLogin. Test Plan: 1) On master, check out an item to a patron via SIP2 2) Note the checkout lists the item as having been checked out from the patron's home library not matter which library is was supposed to be checked out from. 3) Apply this patch 4) Re-checkout the item 5) The item should now be checked out as if it was checked out from the library as defined in the SIP configuration file. Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall (cherry picked from commit 90307bcbfaf4c2c8907be94eabca249ac173442e) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 57086a241e141e157d42b8af3f56ae9283d46ae9) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 15 ++++++++++----- C4/SIP/ILS/Patron.pm | 2 +- t/db_dependent/Auth.t | 42 +++++++++++++++++++++++++++++++----------- 3 files changed, 42 insertions(+), 17 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 11:15:15 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 09:15:15 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-54-g9c7fbad Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 9c7fbadac0f61c8596c7a4891e3534d5b6bae433 (commit) from 51417fde52baefbf8750f5690fb75c86820238fc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9c7fbadac0f61c8596c7a4891e3534d5b6bae433 Author: Blou Date: Mon Jul 27 16:24:46 2015 -0400 Bug 14605 - Corrects the individual fine's description When paying a fine, the description is built out of the borrower's type and title, instead of the actual fine's description. STEPS: 1) in the staff, go to a user with a fine to pay. a) if none, go to a user and Fines>>"Create manual invoice" with a distinctive description. 2) In Fines>>Pay fines, click the "Pay" button on the line of the fine. 3) This will take you a "Pay an individual fine" screen, where the description will look like "Staff Mrs", for the category and title of the borrower. Signed-off-by: Mirko Tietgen Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit 63041c19c98b90c934ef89634dfdaf2d6abeb762) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 744b035932608a0ce3dd495765f9c249d1f527db) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt | 2 +- members/pay.pl | 1 + members/paycollect.pl | 3 ++- 3 files changed, 4 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 11:16:15 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 09:16:15 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-55-gf6d2b24 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via f6d2b24938c4c7375b4963631d24e06fbab33fb9 (commit) from 9c7fbadac0f61c8596c7a4891e3534d5b6bae433 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f6d2b24938c4c7375b4963631d24e06fbab33fb9 Author: Dimitris Antonakis Date: Sat Jun 4 16:00:47 2016 +0300 Bug 14897 - Header name mismatch in ./modules/catalogue/detail.tt We changed the detail.tt file for staff interface from Publication details to "Serial enumeration / chronology" to match the cataloguing editor. Signed-off-by: Joy Nelson Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 43d77fdcf01906fa535482691e5eade47287ab2f) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 4b3b7bbd8d6b497e17ad862737c607bcc5fd09e4) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 11:17:25 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 09:17:25 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-56-ga97e139 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via a97e139921c6dbd264b194cdc422dbe362b08231 (commit) from f6d2b24938c4c7375b4963631d24e06fbab33fb9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a97e139921c6dbd264b194cdc422dbe362b08231 Author: Owen Leonard Date: Thu May 26 12:29:38 2016 -0400 Bug 15676 - Actions in pending offline circulation actions are not translatable This patch modifies the offline circulation transaction processing page so that English strings describing actions are processed in the template rather than being output directly from the script. To test, apply the patch and create an offline circulation file containing at least one checkout, one check-in, and one payment. - Upload the file and choose 'Add to offline circulation queue.' - View pending offline circulation actions - In the list of pending actions, the actions column should show "Check out" instead of "issue," "Check in" instead of "return," and "Payment" instead of "payment." Strings appear as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit e9d6ac9478606d9d123a22635719b99d985b9538) Signed-off-by: Fr?d?ric Demians (cherry picked from commit acc459fa1bae3b1abd13b826420bfb836a1250af) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/offline_circ/list.tt | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 11:20:34 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 09:20:34 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-57-g17ed90f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 17ed90f215656dd201fdf434ecd8fe7ea888e97a (commit) from a97e139921c6dbd264b194cdc422dbe362b08231 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 17ed90f215656dd201fdf434ecd8fe7ea888e97a Author: Marc V?ron Date: Sat May 28 09:44:40 2016 +0200 Bug 16589 - Quote of the day: Fix upload with csv files associated to LibreOffice Calc To reproduce: - Install LibreOffice and make sure that csv files are associated to Calc (Note: tested with Firefox 46.0.1 on Windows 8) - Go to Home > Tools > Quote editor > Quote uploader - Try to upload a valid CSV (e.g. Example from Bug 15684) Result: File can not be uploaded (Incorrect filetype: application/vnd.sun.xml.calc) To test: - Apply patch - Try to upload again Expected result: Quotes are imported. Signed-off-by: Fr?d?ric Demians Can't reproduce on a Mac but get it fails on a Windows Box: fixed with this patch. Signed-off-by: Jonathan Druart Can't recreate on debian but the fix looks safe. Signed-off-by: Kyle M Hall (cherry picked from commit 8631ebaf9f634976b076958707af355baf78cc2f) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 34f8ab6f4040aeaee2cf674a550c052bc3c1a9b8) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes-upload.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 11:22:38 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 09:22:38 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-59-gb8c64ec Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via b8c64ec224bb9fae1f855bda015000ec70763a05 (commit) via 5844ed5b59a3e68578e06bf1abec4e4275264c1d (commit) from 17ed90f215656dd201fdf434ecd8fe7ea888e97a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b8c64ec224bb9fae1f855bda015000ec70763a05 Author: Fridolin Somers Date: Fri May 27 10:50:00 2016 +0200 Bug 16608 - Missing entity nbsp in some XML files The special character "non breaking space"   is not contained in XML syntax by default. So we add it in the file header : ]> Even if the source code files do no contain this character, it can be that translated files contain it. French for example "Titre :". This entity is missing in all files in koha-tmpl/intranet-tmpl/prog/en/data/ and in some files of koha-tmpl/intranet-tmpl/prog/en/xslt. Test plan : - generate French templates: cd misc/translator ./translate install fr-FR cd ../.. - run test: prove -v t/00-valid-xml.t you get failing error message - apply this patch - translate again - run test again: it passes Signed-off-by: Bernardo Gonzalez Kriegel Works as described following test plan Tes pass, no errors. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit f38a9927a3d27709173564848bda4a4a61abeadb) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 0cc550dcc3d0c05b9688bb590a827671f5f8ee95) Signed-off-by: Julian Maurice commit 5844ed5b59a3e68578e06bf1abec4e4275264c1d Author: Fridolin Somers Date: Fri May 27 10:46:44 2016 +0200 Bug 16608 - Add xsd extension to t/00-valid-xml.t Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit ce979300168fc7a885463a1a2be519562319844a) Signed-off-by: Fr?d?ric Demians (cherry picked from commit e6d820ade3821d7f2561babd5abfb3b29de43ace) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/data/marc21_field_006.xml | 3 +++ koha-tmpl/intranet-tmpl/prog/en/data/marc21_field_008.xml | 3 +++ koha-tmpl/intranet-tmpl/prog/en/data/marc21_field_CF.xsd | 3 +++ koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MADS.xsl | 3 +++ koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetDetail.xsl | 3 +++ koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslimUtils.xsl | 3 +++ .../intranet-tmpl/prog/en/xslt/UNIMARCslim2intranetResults.xsl | 3 +++ t/00-valid-xml.t | 2 +- 8 files changed, 22 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 11:46:16 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 09:46:16 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-60-g3672be7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 3672be7315f7f4edcfe1a69fdd049e4f39a1d923 (commit) from b8c64ec224bb9fae1f855bda015000ec70763a05 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3672be7315f7f4edcfe1a69fdd049e4f39a1d923 Author: Tomas Cohen Arazi Date: Sun Jun 5 08:46:06 2016 -0300 Bug 16667: Unused variable and function call in circulation.pl This patch removes an unused occurence of the $branches variable. Probably a leftover from a recent rewrite. To test: - Run: $ git grep '$branches' circ/circulation.pl => FAIL: Only on occurence of the variable - Apply the patch - Run: $ git grep '$branches' circ/circulation.pl => SUCCESS: The variable has been removed - Sign off :-D Regards Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 2bff91eb4e733a5c658e17fb93f13497768ba2e6) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 9d8b407d7e0fc220268c4df3a0bebe4f508eae25) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: circ/circulation.pl | 2 -- 1 file changed, 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 11:54:45 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 09:54:45 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-61-gb214110 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via b2141103eefd64710a0786e01c9572469c04276f (commit) from 3672be7315f7f4edcfe1a69fdd049e4f39a1d923 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b2141103eefd64710a0786e01c9572469c04276f Author: Marc V?ron Date: Wed Jun 1 16:41:55 2016 +0200 Bug 16540 - Clean up opac-auth.tt for translatability This patch fixes translatability issues in opac-auth.tt (ugly translations caused by sentence splitting). It was necessary to change indentation to make the the file more readable and to make sure that changes have no side effects. The changes do not touch the overall functionallity. To test: - Review code to verify that no functionality change is introduced and to verify that the text changes make sense. - Apply patch, verify that OPAC login page behaves as before. UPDATE: Amended for comment #10 / mv Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 6b432d2b213101d2e8d0bf41fbc4a0e5b4ecb4e1) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 88c130eb43eacc8ce107509a6985a4d6eb4f0683) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: .../opac-tmpl/bootstrap/en/modules/opac-auth.tt | 130 ++++++++++---------- 1 file changed, 64 insertions(+), 66 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 11:58:39 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 09:58:39 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-62-g4f3f4da Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 4f3f4daf980ee51c3941d1683d98eb642e97e76c (commit) from b2141103eefd64710a0786e01c9572469c04276f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4f3f4daf980ee51c3941d1683d98eb642e97e76c Author: phette23 Date: Fri May 27 10:13:14 2016 -0700 Bug 16613: fix MARC 09X help links The 09X MARC fields, such as 099 local call number or 090 locally-assigned Library of Congress call number, all point to non-existent pages on the LC website, e.g. http://www.loc.gov/marc/bibliographic/bd090.html Test plan: - enter the advanced cataloging editor - begin to input any MARC tag of form 09X - click the help link at the bottom of the browser window => Without this patch, taken to a URL of form `'http://www.loc.gov/marc/bibliographic/bd' + tag + '.html'` which is broken because the only documentation for these tags is at https://www.loc.gov/marc/bibliographic/bd09x.html => With this patch applied, the link is correct Signed-off-by: Nicole C Engard Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit ec66ff457b6f1b682f7ad7d0e4f2df6656815848) Signed-off-by: Fr?d?ric Demians (cherry picked from commit fe295fce2dec9626498154658bb45cd46ea09cb4) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 11:59:48 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 09:59:48 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-63-g42ddeb3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 42ddeb3dd0fad962f6c2c3a4cd980e267b971bad (commit) from 4f3f4daf980ee51c3941d1683d98eb642e97e76c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 42ddeb3dd0fad962f6c2c3a4cd980e267b971bad Author: Marc V?ron Date: Tue May 31 10:17:13 2016 +0200 Bug 16620: Translatability: Fix problem with isolated word "please" in auth.tt This patch fixes a translatability problem (syntax in different languages) with a tag-isolated word "please" in koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt To test: - Verify in code that there is no sentence spliting by a-tags (lines 80/84). Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit b0ba45058ab0221838f7563f761d283c377b829d) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 7f3243daec25a462d4c9244b8b7b7c8dd6f2fd3f) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 12:00:17 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 10:00:17 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-64-g6b34cc9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 6b34cc972c33f722cf14126180fe8eab76d67eb4 (commit) from 42ddeb3dd0fad962f6c2c3a4cd980e267b971bad (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6b34cc972c33f722cf14126180fe8eab76d67eb4 Author: Marc V?ron Date: Wed Jun 1 21:26:55 2016 +0200 Bug 16633: Translatability: Issues in tags/review.tt (sentence splitting) This patch fixes translatability issues in koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt (isolated words by sentence splitting). To test: - Review code and verify that changes make sense. Signed-off-by: Rocio Dressler Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 203d34a3ca821e409cf612c29b918745a3ea8ddb) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 98a8dca48298fd329c16831a6d5183421ceefd0d) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/tags/review.tt | 30 ++++++++++---------- 1 file changed, 15 insertions(+), 15 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 12:00:53 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 10:00:53 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-65-g4f8e1dc Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 4f8e1dc5d89dfc5ec60bc722cb092ea7a831acbc (commit) from 6b34cc972c33f722cf14126180fe8eab76d67eb4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4f8e1dc5d89dfc5ec60bc722cb092ea7a831acbc Author: Marc V?ron Date: Wed Jun 1 22:28:51 2016 +0200 Bug 16634: Translatability: Fix issue in memberentrygen.tt This patch fixes a small translatability issue in koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt The sentence following sentence was splitted by HTML tags: "Attribute value xxxxx is already in use by another patron record." To test: - Review code - Apply patch - In Admin, create a unique patron attribute type and try to give two patrons the same value for this attribute type. Signed-off-by: Rocio Dressler Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 45dce0ac795357f5111db8cd81473317613bdcc1) Signed-off-by: Fr?d?ric Demians (cherry picked from commit cedc2b736e14381cc6830c6cb4b650ba19bc7719) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 12:03:24 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 10:03:24 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-67-gfbc8114 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via fbc8114f54dd2f684f4fbdb0fbf4a5d44b534136 (commit) via 8a5e451e7f3c8e982fc5372b7f3224052ff3726b (commit) from 4f8e1dc5d89dfc5ec60bc722cb092ea7a831acbc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fbc8114f54dd2f684f4fbdb0fbf4a5d44b534136 Author: Marcel de Rooy Date: Mon Jun 6 10:49:06 2016 +0200 Bug 16635: [QA Follow-up] Eliminate some global package vars [1] $branch is only related to line 123 as fallback. [2] $width moved to a constant; sub width is not used. Signed-off-by: Marcel de Rooy Tested the corresponding plugin in item editor. Test t/db_dependent/Barcodes.t and Barcodes_ValueBuilder.t still pass. Signed-off-by: Kyle M Hall (cherry picked from commit 4fc8b3d6cf6453f7ff550b9fbde1a7f6315dd066) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 94d77bd9c2955f5bafa868f3e2aa375112383194) Signed-off-by: Julian Maurice commit 8a5e451e7f3c8e982fc5372b7f3224052ff3726b Author: Mark Tompsett Date: Wed Jun 1 20:41:27 2016 -0400 Bug 16635: t/00-load.t warning from C4/Barcodes/hbyymmincr.pm According to http://perldoc.perl.org/vars.html, "our" should be a reasonable substitute for the "use vars". By declaring as "our", and removing the INIT, prove t/00-load will no longer generate a warning about INIT for the C4/Barcodes/hbyymmincr.pm module. TEST PLAN --------- 1) prove t/00-load.t -- warnings about INIT for hbyymmincr 2) prove `git grep -l hbyymmincr | grep [.]t$` -- should all run okay 3) apply patch 4) repeat steps 1 and 2 -- warning should be gone, and everything else run okay 5) run koha qa test tools Signed-off-by: Srdjan Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit fd152d9e95a2236a00f3cb0284bdd2aa7cca6da2) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 7fbfa01f78c79daf434a351d165d22382f13fd94) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Barcodes/hbyymmincr.pm | 27 ++++++++++++++------------- 1 file changed, 14 insertions(+), 13 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 12:06:04 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 10:06:04 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-71-g7c2ed6d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 7c2ed6d4863ef7904241529e5764baf8a094a38b (commit) via 9b3e91c218683fa486416ad1a65f468b8874c5d8 (commit) via 17bd3a5debfcdce5e1b2fa55a3cdebcc4850ab8e (commit) via cd8fc9afcdf6a9c0b8420882ac32e81db9ecfd72 (commit) from fbc8114f54dd2f684f4fbdb0fbf4a5d44b534136 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7c2ed6d4863ef7904241529e5764baf8a094a38b Author: Kyle M Hall Date: Fri Jun 10 18:02:14 2016 +0000 Bug 16636 [QA Followup] - Move tests to t/External Signed-off-by: Kyle M Hall (cherry picked from commit 1fda4105a8a0f1e2165e27cea8314b578196dba2) Signed-off-by: Fr?d?ric Demians (cherry picked from commit fcbb59f25e25d86cc5be82595d330aa1b534b3cc) Signed-off-by: Julian Maurice commit 9b3e91c218683fa486416ad1a65f468b8874c5d8 Author: Marcel de Rooy Date: Fri Jun 10 10:31:34 2016 +0200 Bug 16636: [QA Follow-up] Move External_BakerTaylor.t to t When we mock the preferences completely now, we do not need db access anymore. Test plan: Run the test without exporting KOHA_CONF. The test passes with some warns about koha-conf.xml. If you point KOHA_CONF to etc/koha-conf.xml, you have no warns. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit 7f4682df0dfa460c0e2ef9117e032165a45d6e79) Signed-off-by: Fr?d?ric Demians (cherry picked from commit af029c8655eb90e604286118ac6065851088bd57) Signed-off-by: Julian Maurice commit 17bd3a5debfcdce5e1b2fa55a3cdebcc4850ab8e Author: Marcel de Rooy Date: Fri Jun 10 09:30:51 2016 +0200 Bug 16636: [QA Follow-up] Make BakerTaylor plack safe Initialize file level lexicals each call. Do not call _initialize outside the module. Adjust test by mocking preferences. Test plan: Run t/db_dependent/External_BakerTaylor.t. Signed-off-by: Marcel de Rooy Tested module with trivial script under Plack/memcached by toggling the associated preferences. Signed-off-by: Kyle M Hall (cherry picked from commit 5361440f6538127c8c3ec61d963d5f0692c64a71) Signed-off-by: Fr?d?ric Demians (cherry picked from commit c8ef873ee9fe97210d00d450a19f6ad52036b400) Signed-off-by: Julian Maurice commit cd8fc9afcdf6a9c0b8420882ac32e81db9ecfd72 Author: Mark Tompsett Date: Wed Jun 1 20:43:30 2016 -0400 Bug 16636: t/00-load.t warning from C4/External/BakerTaylor.pm Since the tests are expecting an initialize function, the initialize call was just moved outside of the INIT block. TEST PLAN --------- 1) prove t/00-load.t -- warnings about INIT for BakerTaylor 2) prove `git grep -l BakerTaylor | grep [.]t$` -- should all run okay 3) apply patch 4) repeat steps 1 and 2 -- warning should be gone, and everything else run okay 5) run koha qa test tools Signed-off-by: Srdjan Signed-off-by: Florent Mara NOTE: Tweaked test plan based on comment #4, Added sign off based on comment #6. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit b4479624de2010fff8851732e94d086b2cca6921) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 9c7c4f02ddad4045fde7ecf68c03389bb6f10436) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/External/BakerTaylor.pm | 23 ++++++++++----- t/External/BakerTaylor.t | 33 +++++++++++++++++++++ t/{External_Syndetics.t => External/Syndetics.t} | 0 t/db_dependent/External_BakerTaylor.t | 34 ---------------------- 4 files changed, 48 insertions(+), 42 deletions(-) create mode 100755 t/External/BakerTaylor.t rename t/{External_Syndetics.t => External/Syndetics.t} (100%) delete mode 100755 t/db_dependent/External_BakerTaylor.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 12:07:14 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 10:07:14 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-72-g7ebf5fe Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 7ebf5feec925052535bf1edfe17df6983e0f7056 (commit) from 7c2ed6d4863ef7904241529e5764baf8a094a38b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7ebf5feec925052535bf1edfe17df6983e0f7056 Author: Mark Tompsett Date: Sat Jun 4 11:11:00 2016 -0400 Bug 16637: Dependency for C4::Tags not listed Added optional dependency, so as to explain why testing explodes when the Enhanced Content system preference TagsExternalDictionary is set. It is optional, because not only does TagsExternalDictionary have to be set, but TagsEnabled must be 'Allow'. Also tweaked C4/Tags.pm to ignore TagsExternalDictionary, if Lingua::Ispell is not installed. A warning is given. TEST PLAN --------- 1) Set the Enhanced Content system preference TagsExternalDictionary to /usr/bin/ispell 2) sudo apt-get install liblingua-ispell-perl -- should be a new install 3) prove t/db_dependent/Tags.t -- should work fine 4) sudo apt-get remove liblingua-ispell-perl 5) prove t/db_dependent/Tags.t -- should explode 6) Clear the Enhanced Content system preference TagsExternalDictionary 7) prove t/db_dependent/Tags.t -- should work fine 8) apply patch 9) prove t/db_dependent/Tags.t -- should work fine 10) Set the Enhanced Content system preference TagsExternalDictionary to /usr/bin/ispell 11) prove t/db_dependent/Tags.t -- should work, with warning. 12) sudo apt-get install liblingua-ispell-perl 13) prove t/db_dependent/Tags.t -- should work fine 14) run koha qa test tools. Signed-off-by: Marcel de Rooy Post-hackfest hotel Olympia lobby signoff. Kalimera! Works as expected. At this moment the Tags.t test does not need the database btw, but the module should have much more test coverage. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit c91b16bd9e82588c7625f69e37d6435dd378915e) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 358e7a6d61d49c3ad8b57e2ad952f3fd9e4b83de) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Installer/PerlDependencies.pm | 5 +++++ C4/Tags.pm | 5 +++++ 2 files changed, 10 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 12:09:21 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 10:09:21 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-73-g6236084 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 6236084603d4976c562c8c5e646aaeea31b37f63 (commit) from 7ebf5feec925052535bf1edfe17df6983e0f7056 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6236084603d4976c562c8c5e646aaeea31b37f63 Author: Claire Gravely Date: Sat Jun 4 13:30:30 2016 +0200 Bug 16165 - Include link to ILS-DI documentation page in ILS-DI system preference There is no clue in the system preference about the nice ILS-DI documentation once you turn it on. We should include a note and the link, similar to how we do it for the web self checkout. Test plan: Syspreference ILS-DI should now include URL in description. Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 9066ae153b15ae49b7d5832b331eed31c32ed583) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 903d0432c3dfc84236d1ff40606444e3a56c845b) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/admin/preferences/web_services.pref | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 12:49:36 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 10:49:36 +0000 Subject: [koha-commits] main Koha release repository branch 16.05.x updated. v16.05.00-101-g4d2f605 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 16.05.x has been updated via 4d2f605b37a5a4ac9087e7d26cffe22d75455d10 (commit) via 0a7dc07cb5051b7f2ae6e676c9b01ecf7b9c41e9 (commit) from a0fb3fdf1a057dba56eb05ba6997d901bfcb9645 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4d2f605b37a5a4ac9087e7d26cffe22d75455d10 Author: Jonathan Druart Date: Wed May 11 13:13:38 2016 +0100 Bug 16088: Fix the number of tests to skip Signed-off-by: Jacek Ablewicz Signed-off-by: Jesse Weaver Signed-off-by: Brendan Gallagher (cherry picked from commit b37d7c993542f54a1821c99899c4f0772f5846b8) Signed-off-by: Fr?d?ric Demians commit 0a7dc07cb5051b7f2ae6e676c9b01ecf7b9c41e9 Author: Jonathan Druart Date: Mon May 9 17:27:51 2016 +0100 Bug 16088: Introduce Koha::Cache::Memory::Lite to cache the language The goal of this patch is to avoid unecessary flush of the L1 cache on creating a new CGI object each time C4::Languages::getlanguage is called without a CGI object. The new class Koha::Cache::Memory::Lite must be flushed by the CGI constructor overide done in the psgi file. This new class will ease caching of specific stuffs used by running script. Test plan: At the OPAC and the intranet interfaces: Open 2 different browser session to simulate several users - Clear the cookies of the browsers - User 1 (U1) an User 2 (U2) should be set to the default language (depending on the browser settings) - U1 chooses another language - U2 refreshes and the language used must be the default one - U2 chooses a third language - U1 refreshes and must be still using the one he has choosen. Try to use a language which is not defined: Add &language=es-ES (if es-ES is not translated) to the url, you should not see the Spanish interface. Signed-off-by: Jacek Ablewicz Signed-off-by: Jesse Weaver Signed-off-by: Brendan Gallagher (cherry picked from commit f01a07a25e0503d9dbed3a4226cb51a155bcacd4) Signed-off-by: Fr?d?ric Demians ----------------------------------------------------------------------- Summary of changes: C4/Languages.pm | 30 ++++++++++++------ C4/Templates.pm | 14 +++++---- Koha/Cache/Memory/Lite.pm | 72 +++++++++++++++++++++++++++++++++++++++++++ debian/templates/plack.psgi | 3 ++ misc/plack/koha.psgi | 2 ++ t/Cache.t | 42 +++++++++++++++++++++++-- 6 files changed, 145 insertions(+), 18 deletions(-) create mode 100644 Koha/Cache/Memory/Lite.pm hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 16 14:00:50 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jun 2016 12:00:50 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.07-81-gc4be995 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via c4be9951a7c15a12ba4901c2632681cec8e68978 (commit) via 620023209f10d55db9ca3900dfa20c5532c2e411 (commit) via 6c360763e80e9d85c11af4395778dca936e8850a (commit) via bc2a946f7c331b3535c1a5c6a31534b4ca8aa7fd (commit) via acb6f4ba41df93dccc3a715b74f12d866e97c890 (commit) via 0f082e6583aba50835c1c688599d510e117b2f20 (commit) via 7040625691d33ff223a2f4af0205b2c7580db9a1 (commit) via af168f1706c4048d65771112f5e4a25c8fdd76f9 (commit) from 6236084603d4976c562c8c5e646aaeea31b37f63 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c4be9951a7c15a12ba4901c2632681cec8e68978 Author: Galen Charlton Date: Tue Jun 7 01:42:59 2016 +0000 Bug 16675: fix breakage of t/Languages.t This patch fixes test breakage introduced by the patch for bug 16088, which added caching of getlanguages(). Upon inspection, it looks like the patch for 16088 does not introduce a regression on bug 10560, so this patch adds a couple cache-clearings. To test ------- [1] Verify that t/Languages.t passes. Signed-off-by: Galen Charlton Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit b9b4eeb849dcb52053a98440e1d8fb02011a9005) Signed-off-by: Julian Maurice commit 620023209f10d55db9ca3900dfa20c5532c2e411 Author: Jonathan Druart Date: Mon May 9 17:27:51 2016 +0100 Bug 16088: Introduce Koha::Cache::Memory::Lite to cache the language The goal of this patch is to avoid unecessary flush of the L1 cache on creating a new CGI object each time C4::Languages::getlanguage is called without a CGI object. The new class Koha::Cache::Memory::Lite must be flushed by the CGI constructor overide done in the psgi file. This new class will ease caching of specific stuffs used by running script. Test plan: At the OPAC and the intranet interfaces: Open 2 different browser session to simulate several users - Clear the cookies of the browsers - User 1 (U1) an User 2 (U2) should be set to the default language (depending on the browser settings) - U1 chooses another language - U2 refreshes and the language used must be the default one - U2 chooses a third language - U1 refreshes and must be still using the one he has choosen. Try to use a language which is not defined: Add &language=es-ES (if es-ES is not translated) to the url, you should not see the Spanish interface. Signed-off-by: Jacek Ablewicz Signed-off-by: Jesse Weaver Signed-off-by: Brendan Gallagher (cherry picked from commit f01a07a25e0503d9dbed3a4226cb51a155bcacd4) Signed-off-by: Julian Maurice commit 6c360763e80e9d85c11af4395778dca936e8850a Author: Jonathan Druart Date: Thu Mar 24 20:47:47 2016 +0000 Bug 16044: Populate the L1 cache when L2 is fetched The whole patch set is not very pertinent if the L1 cache is not populated when L2 is fetched! This patch fixes this inconsistency. Signed-off-by: Jesse Weaver Signed-off-by: Jacek Ablewicz Signed-off-by: Brendan A Gallagher (cherry picked from commit c75271a741632b4aa9af0c6c342cdbf1c77e699f) Signed-off-by: Julian Maurice commit bc2a946f7c331b3535c1a5c6a31534b4ca8aa7fd Author: Jonathan Druart Date: Tue Mar 15 16:40:14 2016 +0000 Bug 16044: Add an unsafe flag to Koha::Cache->get_from_cache If the caller/developer knows what he is doing, he can decide not to deep copy the structure. It will be faster but unsafe! If the structure is modified, the cache will also be updated. This option must be used with care and is not the default behavior. Signed-off-by: Jesse Weaver Signed-off-by: Tomas Cohen Arazi Signed-off-by: Brendan A Gallagher (cherry picked from commit b0bbace4dd8c19488110bf5c06817077abaa3f1c) Signed-off-by: Julian Maurice commit acb6f4ba41df93dccc3a715b74f12d866e97c890 Author: Jonathan Druart Date: Tue Mar 15 16:17:32 2016 +0000 Bug 16044: Add deep cloning To avoid the cache to be modified unfortunately, the default behavior of get_from_cache will be to deep copy if we are getting a structure. If the item is a scalar, it's simply returned. Signed-off-by: Jesse Weaver Signed-off-by: Tomas Cohen Arazi Signed-off-by: Brendan A Gallagher (cherry picked from commit 2e0af6e6df279aa08603e9696d35fc7def7bd7d3) Signed-off-by: Julian Maurice commit 0f082e6583aba50835c1c688599d510e117b2f20 Author: Jonathan Druart Date: Tue Mar 15 15:50:15 2016 +0000 Bug 16044: Add tests to make sure structures will be copied Signed-off-by: Jesse Weaver Signed-off-by: Tomas Cohen Arazi Signed-off-by: Brendan A Gallagher (cherry picked from commit 3bfe541d0d97cdad08f9be2cff20c04a03424a25) Signed-off-by: Julian Maurice commit 7040625691d33ff223a2f4af0205b2c7580db9a1 Author: Jonathan Druart Date: Tue Mar 15 15:45:20 2016 +0000 Bug 16044: Make tests from t/Cache.t pass The timeout does not impact the L1 cache (it would be to time consuming and not really useful to do that for this cache). To simulate the real timeout, we need to flush this L1 cache when needed. It would be also done adding a disable_L1_cache method. Signed-off-by: Jesse Weaver Signed-off-by: Tomas Cohen Arazi Signed-off-by: Brendan A Gallagher (cherry picked from commit bbfe394bb6e1ac8851b3c73826ea6fa5e7a0c94c) Signed-off-by: Julian Maurice commit af168f1706c4048d65771112f5e4a25c8fdd76f9 Author: Jonathan Druart Date: Thu Mar 10 15:54:28 2016 +0000 Bug 16044: Use the L1 cache for any objects set in cache Signed-off-by: Jesse Weaver Signed-off-by: Tomas Cohen Arazi Signed-off-by: Brendan A Gallagher (cherry picked from commit dda7a0a25ff480abda219084686e8138341fbba3) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Context.pm | 14 --------- C4/Languages.pm | 30 ++++++++++++------ C4/Templates.pm | 14 +++++---- Koha/Cache.pm | 49 ++++++++++++++++++++++++++--- Koha/Cache/Memory/Lite.pm | 72 ++++++++++++++++++++++++++++++++++++++++++ debian/templates/plack.psgi | 5 ++- misc/plack/koha.psgi | 5 ++- t/Cache.t | 73 +++++++++++++++++++++++++++++++++++++++++-- t/Languages.t | 3 ++ 9 files changed, 227 insertions(+), 38 deletions(-) create mode 100644 Koha/Cache/Memory/Lite.pm hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 17 16:26:02 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 17 Jun 2016 14:26:02 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-113-g30946ef Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 30946eff3cda31d0cc97c6c1c4f1e757dbc4c366 (commit) via 44062c07b7703190b46701a3fa31665d998eadfb (commit) via 273d5e53289536797281ca5eb323d5c373d9ea41 (commit) via 1bd5a177d0870332a959e9c773aaec80beeba74b (commit) via 10fd9f5ec0d5faa7b54b0bfaf5a7b8fccd665f0a (commit) from 42cd9ca1447f4d576d9f1ad51e275e70c8bf9249 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 30946eff3cda31d0cc97c6c1c4f1e757dbc4c366 Author: Jonathan Druart Date: Tue Jun 14 10:49:41 2016 +0100 Bug 12748: findSerialByStatus has been renamed with findSerialsByStatus Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 44062c07b7703190b46701a3fa31665d998eadfb Author: Jonathan Druart Date: Tue Jun 14 10:43:14 2016 +0100 Bug 12748: Code tidy Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 273d5e53289536797281ca5eb323d5c373d9ea41 Author: Jonathan Druart Date: Tue Jun 14 10:39:08 2016 +0100 Bug 12748: Remove warning 'masks earlier declaration in same scope' Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 1bd5a177d0870332a959e9c773aaec80beeba74b Author: remi Date: Mon Feb 8 15:04:07 2016 -0500 Bug 12748 - Add test for step 7 and 8 and rename findSerialByStatus https://bugs.koha-community.org/show_bug.cgi?id=12478 Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 10fd9f5ec0d5faa7b54b0bfaf5a7b8fccd665f0a Author: remi Date: Tue Aug 11 11:10:45 2015 -0400 Bug 12748 - Fixes duplicate serials with an "expected" status bug Added a new sub to Serials.pm to be able to get serials with their statuses. Now the sub ModSerialStatus checks for other serials with an "expected" status before doing anything. Also modified Serials.t to be able to test those changes. Test Plan 1) Apply patch 2) Run ./t/db_dependent/Serials.t 3) Validate that there are no errors 4) Go on "Serial collection information" page for a serial of your choice 5) Click on "Generate next" 6) Change the status of the original serial from "late" to "expected" 7) Change the newly generated serial from "expected" to "delete" 8) Validate that there are no new serials created by instruction 7 and that the serial was deleted 9) Run ./t/db_dependent/Serials.t With QA Fixes - Use the constant instead of the code (1 vs EXPECTED) - Avoid interpolation in query - use selectall_arrayref instead of fetchall_arrayref Signed-off-by: Liz Rea Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Serials.pm | 24 ++++++++++++++++++++++-- t/db_dependent/Serials.t | 30 +++++++++++++++++++++++++++++- 2 files changed, 51 insertions(+), 3 deletions(-) mode change 100644 => 100755 t/db_dependent/Serials.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 17 16:29:32 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 17 Jun 2016 14:29:32 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-115-gde6c137 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via de6c1375f76b562970d7515192a002af8babc740 (commit) via 8c14c25521eac92a2cb62ab5330deac2e2d5343d (commit) from 30946eff3cda31d0cc97c6c1c4f1e757dbc4c366 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit de6c1375f76b562970d7515192a002af8babc740 Author: Tomas Cohen Arazi Date: Mon May 9 11:13:38 2016 -0300 Bug 13074: (followup) remove useless diag On running all Items-related tests some useless diag showed up. Removing it. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit 8c14c25521eac92a2cb62ab5330deac2e2d5343d Author: Jonathan Druart Date: Tue May 3 11:08:47 2016 +0100 Bug 13074: Use Koha::Cache to cache the defaults values of a MARC record With the global %default_values_for_mod_from_marc variable, the changes made to the marc_subfield_structure table and especially the links between MARC and DB fields are not safe and might be outdated (if a field is linked/unlinked) Test plan: Under Plack: - Link the barcode field, edit a record and set a barcode. - Remove the mapping for the barcode field and then update again the barcode of the record. The items.barcode DB field must not have been updated. Without this patch, the field should have been updated. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Items.pm | 17 ++-- admin/biblio_framework.pl | 2 + admin/marc_subfields_structure.pl | 2 + admin/marctagstructure.pl | 3 + t/db_dependent/Items.t | 116 ++++++++++++++++++++++++++- t/db_dependent/Items/GetItemsForInventory.t | 2 - 6 files changed, 132 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 17 16:33:40 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 17 Jun 2016 14:33:40 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-119-g8204024 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 8204024f1c21102c0649dec70d10398131aab953 (commit) via 6ad5770786c6646ce68ffdfec9080645fc25772e (commit) via 959d69fa0107423ed31e20f4a6afb46d1e5c771c (commit) via 4263ac2b92737024d8d620a751babf72b904b73a (commit) from de6c1375f76b562970d7515192a002af8babc740 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8204024f1c21102c0649dec70d10398131aab953 Author: Marcel de Rooy Date: Mon May 23 09:03:23 2016 +0200 Bug 16502: Replace a few other ok-calls by is-calls Trivial changes that speak for themselves.. Signed-off-by: Marcel de Rooy Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 6ad5770786c6646ce68ffdfec9080645fc25772e Author: Marcel de Rooy Date: Mon May 23 08:58:02 2016 +0200 Bug 16502: Adjust test for GetPlugins The current test assumes that GetPlugins will return the test plugin as the first one in the array. This is not correct. This patch adjusts the test to a grep. Test plan: Run the test. Bonus: Add additional plugins. Run the test again. Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 959d69fa0107423ed31e20f4a6afb46d1e5c771c Author: Marcel de Rooy Date: Mon May 16 19:00:16 2016 +0200 Bug 16502: Add additional test to Plugins.t In order to verify if the delete now really works, we add one test in Plugins.t. Test plan: [1] Run the test. [2] Bonus: Comment line 63 in Plugins.t where delete is called. Run the test again. It should fail now. Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 4263ac2b92737024d8d620a751babf72b904b73a Author: Marcel de Rooy Date: Mon May 16 17:19:54 2016 +0200 Bug 16502: Table koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped after running Plugin.t If you run Plugin.t, the above table will still be present (when you did not enable UseKohaPlugins). This would trigger a warning when running the test a second time. Why? The uninstall call does its work not completely due to a small inconsistency in Koha::Plugins::Handler::delete when calling run without the enable_plugins parameter. This patch resolves that inconsistency and also removes an unneeded skip in Plugin.t in case the KitchenSink module already exists. Note: This is a small fix. But I wonder if the Handler routines run and delete should not have been implemented in Koha::Plugins::Base. Also note that plugins/plugins-uninstall.pl will not be affacted by this change, since it checks whether the pref is enabled before calling the delete method. Test plan: [1] Do not yet install this patch. [2] Verify that plugins are enabled in koha-conf.xml. [3] Disable UseKohaPlugins in System Preferences! [4] Run t/db_dependent/Plugins.t. [5] Verify that table koha_plugin_com_bywatersolutions_kitchensink_mytable still exists. (It should have been deleted.) Remove it manually. [6] Apply this patch. [7] Run the test again. [8] Verify that the table does not exist. [9] Run the test again (without warnings). Signed-off-by: Marcel de Rooy Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/Plugins/Handler.pm | 9 ++++++++- t/db_dependent/Plugins.t | 26 +++++++++++++++----------- 2 files changed, 23 insertions(+), 12 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 17 16:35:32 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 17 Jun 2016 14:35:32 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-120-g5820744 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 58207446755cb2533fac48252c3b70154b164feb (commit) from 8204024f1c21102c0649dec70d10398131aab953 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 58207446755cb2533fac48252c3b70154b164feb Author: Jonathan Druart Date: Mon Jun 6 13:31:29 2016 +0100 Bug 16670: (bug 15823 follow-up) CGI->param should not be called in list context Signed-off-by: Jacek Ablewicz Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: circ/circulation.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 17 16:36:37 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 17 Jun 2016 14:36:37 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-121-g557a598 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 557a5989093982f41173df8267658cb1d90e76cd (commit) from 58207446755cb2533fac48252c3b70154b164feb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 557a5989093982f41173df8267658cb1d90e76cd Author: Kyle M Hall Date: Wed Jun 8 10:24:56 2016 +0000 Bug 16692 - Error "No method update!" when creating new serial issue An improper method call was left over in C4::Serials::NewIssue from the switch from DBIx::Class to Koha::Object. Test Plan: 1) prove t/db_dependent/Serials.t 2) Note the errors 3) Apply this patch 4) prove t/db_dependent/Serials.t 5) No errors! Signed-off-by: Jacek Ablewicz Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Serials.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 17 16:37:30 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 17 Jun 2016 14:37:30 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-122-gb8c950a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b8c950a4c1b1ead8a58686b27c95f9891cdccbae (commit) from 557a5989093982f41173df8267658cb1d90e76cd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b8c950a4c1b1ead8a58686b27c95f9891cdccbae Author: Tomas Cohen Arazi Date: Mon Jun 13 13:04:25 2016 -0300 Bug 16720: Remove DBIx ActionLogs.pm The update_dbix_class_files.pl script generates ActionLog.pm instead, which is already on the source tree. To test: - Apply the patch => SUCCESS: Koha/Schema/Result/ActionLogs.pm is removed - Run: $ mysql -uroot > CREATE DATABASE dbic; \q $ mysql -uroot dbic < kohaclone/installer/data/mysql/kohastructure.sql $ misc/devel/update_dbix_class_files.pl --db_name dbic --db_user root => SUCCESS: Koha/Schema/Result/ActionLogs.pm is not re-generated - Run: $ git grep ActionLogs => SUCCESS: There's no code using it - Sign off Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/Schema/Result/ActionLogs.pm | 90 -------------------------------------- 1 file changed, 90 deletions(-) delete mode 100644 Koha/Schema/Result/ActionLogs.pm hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 17 16:41:53 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 17 Jun 2016 14:41:53 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-124-g63fbb33 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 63fbb336bd90991a8b86ca6fe54d5a069c129373 (commit) via 395ac8835a582a2bb38aaa3259c4196b81142dd4 (commit) from b8c950a4c1b1ead8a58686b27c95f9891cdccbae (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 63fbb336bd90991a8b86ca6fe54d5a069c129373 Author: Marcel de Rooy Date: Thu May 26 21:56:50 2016 +0200 Bug 16500: [QA Follow-up] Catch warning if branch MPL already exists The current test had no warnings, when you have no MPL branch, and only catches the warn from the second build on line 57. If you do have MPL, a warning comes from line 56. This patch fixes it by removing MPL from the test. A new branch is created first and then we try to create it again. Test plan: Run the test. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 395ac8835a582a2bb38aaa3259c4196b81142dd4 Author: Marcel de Rooy Date: Wed May 11 14:49:07 2016 +0200 Bug 16500: Catch two warns in TestBuilder.t with warning_like When testing a wrong case in TestBuilder.t, two warns show up. We can catch them with warning_like. Test plan: Run t/db_dependent/TestBuilder.t Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: t/db_dependent/TestBuilder.t | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 17 16:44:11 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 17 Jun 2016 14:44:11 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-125-g2d9c270 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2d9c270886b547c1c4973cef3c20f18e6998530a (commit) from 63fbb336bd90991a8b86ca6fe54d5a069c129373 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2d9c270886b547c1c4973cef3c20f18e6998530a Author: Marcel de Rooy Date: Fri May 27 08:35:57 2016 +0200 Bug 16607: Remove CPL/MPL from two unit tests Test t/db_dependent/Accounts.t: This test created a MPL branch, but did not use it any more. Test t/db_dependent/Items/AutomaticItemModificationByAge.t: This test still used CPL/MPL branches. Now it uses two new branches. Test plan: [1] Run t/db_dependent/Accounts.t. [2] Run t/db_dependent/Items/AutomaticItemModificationByAge.t. Signed-off-by: Marcel de Rooy Both tests pass OK Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Accounts.t | 4 +--- t/db_dependent/Items/AutomaticItemModificationByAge.t | 16 ++++++++-------- 2 files changed, 9 insertions(+), 11 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 17 16:45:30 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 17 Jun 2016 14:45:30 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-127-gf8b73de Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f8b73deaec5c7f55d66d52c2ca05d419f4a7c178 (commit) via a4690353d9a20a7c991787a1ffe3040eb3834a5a (commit) from 2d9c270886b547c1c4973cef3c20f18e6998530a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f8b73deaec5c7f55d66d52c2ca05d419f4a7c178 Author: Jonathan Druart Date: Tue Jun 14 11:18:32 2016 +0100 Bug 16717: Improve variable naming $category was a categorycode, to help the readability it's better to name it $categorycode or assign a Category to $category Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit a4690353d9a20a7c991787a1ffe3040eb3834a5a Author: Marcel de Rooy Date: Fri May 27 13:48:10 2016 +0200 Bug 16717: Remove hardcoded category from Holds.t There is actually no need to use the hardcoded patron category S in this test. Test plan: Run t/db_dependent/Holds.t. Signed-off-by: Marcel de Rooy Test passes OK Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Holds.t | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 17 16:53:35 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 17 Jun 2016 14:53:35 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-129-g64efee0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 64efee0b5cc975b3b80db1841321355eeb39fb48 (commit) via d4394d88eaeff5df6bf0a28ec3e6faed853b202b (commit) from f8b73deaec5c7f55d66d52c2ca05d419f4a7c178 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 64efee0b5cc975b3b80db1841321355eeb39fb48 Author: Jonathan Druart Date: Sat Jun 11 14:32:05 2016 +0100 Bug 16594: Fix obvious QA issues from bug 11371 Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit d4394d88eaeff5df6bf0a28ec3e6faed853b202b Author: Hector Castro Date: Thu May 26 08:41:08 2016 -0600 Bug 16594: Orders by fund report has wrong link to css and other issues Orders by fund has wrong link to css and other issues -> The example in the wiki is wrong: [% INCLUDE 'datatables.inc' %] -> Must be: -> Missing in tag -> Wrong word used "Date deceived" should be "Date received" NOTE: Wiki needs to be updated To test: -Look the code and notice about if else cluase without curly brackets -Go to Reports > Orders by fund -Play with: in filters 'All fund' Output: 'to screen into the browser' -You will see a DataTable displayed in screen clutter -Notice about 'Date deceived' and the foot of table -Apply patch -Refresh or execute again the report Signed-off-by: Sinziana Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/reports/orders_by_budget.tt | 11 ++++++----- reports/orders_by_fund.pl | 12 ++++++------ 2 files changed, 12 insertions(+), 11 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 17 17:21:51 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 17 Jun 2016 15:21:51 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-130-g981302a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 981302a47322857b080107a71c47db2345ef5286 (commit) from 64efee0b5cc975b3b80db1841321355eeb39fb48 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 981302a47322857b080107a71c47db2345ef5286 Author: Owen Leonard Date: Tue May 31 10:08:03 2016 -0400 Bug 16127 - Add discharge menu item to patron toolbar This patch changes the "Discharge" menu in the patron sidebar to read "Discharges," and adds a "Discharge" menu item to the patron toolbar. This adds some redunancy, but fits with the pattern of including "views" in the sidebar and "actions" in the menu. The discharge feature can be thought of either way. To test you must have the 'useDischarge' system preference enabled. - View the detail page for any patron. - Confirm that the sidebar menu reads "Discharges." - Confirm that the "More" menu contains a "Discharge" link which works correctly. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc | 2 +- koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 17 17:40:04 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 17 Jun 2016 15:40:04 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-132-g45fbcb9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 45fbcb9fda8776dc78556efd99076ce8fc8b4f97 (commit) via 2a6a3de7c407724d2778be8bf422b1222910e4a7 (commit) from 981302a47322857b080107a71c47db2345ef5286 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 45fbcb9fda8776dc78556efd99076ce8fc8b4f97 Author: Jonathan Druart Date: Tue Jun 14 11:09:42 2016 +0100 Bug 16456: Reintroduce wording "Delete tag" "Delete tag" seems more appropriate than "Delete" on this tag, but I may be wrong. This patch also removes an extra space. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 2a6a3de7c407724d2778be8bf422b1222910e4a7 Author: Hector Castro Date: Fri May 13 23:40:25 2016 -0600 Bug 16456: Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation Add Font Awesome Icons to section Patrons and circulation in Tools module. Also correct a error dialog in JQuery functions To test: -Apply patch -Goto Tools -> Patron list -> my_list_saved -> Add patrons -> Remove selected patrons, Clear all, Select all. -Add new patron list and add some patrons, notice about the trash icon. -Make some comments in some bib records and goto Tools->Comments you will presented with two tabs "Approved comments" and "Comments awaiting moderation". See the three new buttons: Approve, Delete, Unapprove. -Set syspref TagsModeration to Require. This will show all pending tags to review. -Make some tags in bib records and goto Tools -> Tags. -Notice about the new look. -In the new screen look the icons in buttons "Apply filter(s)", "Test", "Approved", "Reject". Notice about the new header bar above the DataTable with options: Select all, Clear all, Select all pending. -Play with filters; Check if terms exist or not in appoved/rejected lists -Play with Terms summary and see if DataTable is working as expected -Click in some term tag with multiple titles -A table with titles tagged with the term is presented -See the new button 'Remove' -Verify if you can remove tag from a selected title. -Verify that all tools work as expected NOTE: The Tag and Comments tools has been revised to fit with others interfaces in Koha. Bug ammended according with QA comment 5 Bug rebased because bug 16005 Test plan amended for clarity Clock icon for "Select all pending" removed (QA comment 23). Fix some forbidden patterns (tab char) in review.tt according by IRC comment by Marc Veron Followed test plan, looks and works as expected Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/js/autocomplete/patrons.js | 2 +- .../prog/en/modules/patron_lists/list.tt | 6 +- .../prog/en/modules/reviews/reviewswaiting.tt | 4 +- .../intranet-tmpl/prog/en/modules/tags/list.tt | 2 +- .../intranet-tmpl/prog/en/modules/tags/review.tt | 104 ++++++++++++-------- 5 files changed, 69 insertions(+), 49 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 17 17:42:51 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 17 Jun 2016 15:42:51 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-133-g51a11d2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 51a11d279457f97ac1b30e99d1af38a344d01725 (commit) from 45fbcb9fda8776dc78556efd99076ce8fc8b4f97 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 51a11d279457f97ac1b30e99d1af38a344d01725 Author: Owen Leonard Date: Wed May 25 10:56:13 2016 -0400 Bug 16541 - Make edit and delete links styled buttons in cities administration This patch modifies the cities administration page, converting edit and delete links to Bootstrap buttons with Font Awesome icons. To test, apply the patch and go to Administration -> Cities and towns. The 'Edit' and 'Delete' buttons should look correct and work correctly. Signed-off-by: rainer Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 17 17:43:33 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 17 Jun 2016 15:43:33 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-134-gae4be45 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ae4be45444dd8e6a65dc7170cfc43c60de328f38 (commit) from 51a11d279457f97ac1b30e99d1af38a344d01725 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ae4be45444dd8e6a65dc7170cfc43c60de328f38 Author: Owen Leonard Date: Wed May 25 10:49:26 2016 -0400 Bug 16543 - Make edit and delete links styled buttons in patron attribute types administration This patch modifies the Patron attribute types page, converting edit and delete links to Bootstrap buttons with Font Awesome icons. To test, apply the patch and go to Administration -> Patron attribute types. The 'Edit' and 'Delete' buttons should look correct and work correctly. Signed-off-by: Jan Kissig Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 17 17:45:26 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 17 Jun 2016 15:45:26 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-137-g8fac12d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 8fac12d7f1ecfd44f9288aea6cf54efecc883b84 (commit) via a98a3bea2a5e98eda794e0ed25ab03fa57f9d85f (commit) via bf6300975889c65cd2e9e867fe2a261ff973bbaf (commit) from ae4be45444dd8e6a65dc7170cfc43c60de328f38 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8fac12d7f1ecfd44f9288aea6cf54efecc883b84 Author: Jonathan Druart Date: Tue Jun 14 10:15:58 2016 +0100 Bug 16672: Fix typo unqiue vs unique Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit a98a3bea2a5e98eda794e0ed25ab03fa57f9d85f Author: Kyle M Hall Date: Mon Jun 13 18:26:22 2016 +0000 Bug 16672 [QA Followup] - Convert negative days to positive days Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit bf6300975889c65cd2e9e867fe2a261ff973bbaf Author: Kyle M Hall Date: Mon Jun 6 13:52:45 2016 +0000 Bug 16672 - Add ability to remove expired holidays from special_holidays It would be very helpful if the cleanup_database.pl script had the ability to delete holidays from the special_holidays table there were older than a given number of days in the past. Test Plan: 1) Apply this patch 2) Create some unique holidays in the past of varying ages 3) Test the new switch '--unique-holidays DAYS' for cleanup_database.pl 4) Verify only holidays older then the specified number of days are removed NOTE: The language 'unique holdays' is used in the interface to match it's use in the staff web interface. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: misc/cronjobs/cleanup_database.pl | 55 +++++++++++++++++++++++++------------ 1 file changed, 37 insertions(+), 18 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 17 17:57:38 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 17 Jun 2016 15:57:38 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-138-gc92d082 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via c92d0823f8b79c1bb8f01b4a429961e5f3e5574c (commit) from 8fac12d7f1ecfd44f9288aea6cf54efecc883b84 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c92d0823f8b79c1bb8f01b4a429961e5f3e5574c Author: Julian Maurice Date: Wed Jun 8 13:47:58 2016 +0200 Bug 16693: Remove reserve/renewscript.pl It is not used since bug 11703 Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: reserve/renewscript.pl | 142 ------------------------------------------------ 1 file changed, 142 deletions(-) delete mode 100755 reserve/renewscript.pl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 17 18:07:31 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 17 Jun 2016 16:07:31 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-139-g555f406 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 555f40626ab34eccadec66091e54e203a9be4440 (commit) from c92d0823f8b79c1bb8f01b4a429961e5f3e5574c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 555f40626ab34eccadec66091e54e203a9be4440 Author: Marc V?ron Date: Tue Jun 14 07:07:05 2016 +0200 Bug 16729: Use member-display-address-style*-includes when printing user summary This patch replaces the address part in moremember-print.tt to print identical address information as displayed on the screen (including street numer, formatted as required by syspref 'AddressFormat' To test: - Apply patch - Search for a user with all address information filled - Verify that 'Print summmary' displays the same information as displayed on the screen. - Change value of syspref 'AdressFormat' - Verify that address format on 'Print summary' changes as appropriate Signed-off-by: mehdi Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/members/moremember-print.tt | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 17 18:11:26 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 17 Jun 2016 16:11:26 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-144-ga96d496 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a96d496c9b8860e493f2d6993ba033b13b8b8b80 (commit) via 8fd3170296aec71d9a3d97937d27c93c299033ee (commit) via fe32cc2a309b39930c42c9be73f372a80aac54ba (commit) via 2d15bc5355cb53780e5cdbf410c787a5d6ac16a7 (commit) via f75befdbedd2dd8540c8c3fcfa81c12af45c438e (commit) from 555f40626ab34eccadec66091e54e203a9be4440 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a96d496c9b8860e493f2d6993ba033b13b8b8b80 Author: Kyle M Hall Date: Fri Jun 17 15:37:24 2016 +0000 Bug 16148 [Follow-up] - Use Font Awesome for arrows instead of images Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall commit 8fd3170296aec71d9a3d97937d27c93c299033ee Author: Jonathan Druart Date: Tue Jun 14 16:16:13 2016 +0100 Bug 16148: Fix submit button text The text of the submit button should be init getting the val(), and not the text(). Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit fe32cc2a309b39930c42c9be73f372a80aac54ba Author: Owen Leonard Date: Tue Jun 14 10:26:25 2016 -0400 Bug 16148 [Follow-up] Revised layout and behavior of marc modification template management This follow-up corrects a JavaScript error by using jQuery, which is is more forgiving when selecting elements which may not exist on the page. Also changed: Corrected a duplicate class attribute and fixed a jshint error. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 2d15bc5355cb53780e5cdbf410c787a5d6ac16a7 Author: Jonathan Druart Date: Mon Jun 6 14:43:37 2016 +0100 Bug 16148: Add preventDefault to avoid the scrollbar to move to the top .. when click on buttons Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit f75befdbedd2dd8540c8c3fcfa81c12af45c438e Author: Owen Leonard Date: Fri Mar 25 09:47:11 2016 -0400 Bug 16148 - Revised layout and behavior of marc modification template management This patch makes changes to the layout and behavior of the marc modification template management page to make it adhere better to common interaction patterns in Koha. - The initial view shows a list of templates rather than pre-selecting the first available template for editing. - A toolbar has been added with a "New template" button. - The initial view of existing templates has an actions menu containing menu items for 'Edit actions,' 'Duplicate,' and 'Delete.' It doesn't appear to be possible to edit an existing template's name. - The "Create template" form is no longer shown all the time. - Clicking the "New template" toolbar button triggers a modal with the form for creating a template. An existing template can be chosen to duplicate. - Choosing "Duplicate" from one of the template menus triggers the "New template" modal and preselects the corresponding template in the "duplicate"