[koha-commits] main Koha release repository branch master updated. v16.05.00-54-g7d916c3

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  7d916c380a03904c47035f189d1ee666f00d9a11 (commit)
      from  f2fe433cf9afce98957826bf2ade457557fe4eff (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 7d916c380a03904c47035f189d1ee666f00d9a11
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu May 5 16:58:06 2016 +0100

    Bug 16455: Remove the "Too late to run INIT block" from C4::Tags
    
    The pref TagsExternalDictionary is used to tell Lingua::Ispell to use an
    other dictionary, different from the default one (/usr/bin/ispell).
    
    To do so we need to set $Lingua::Ispell::path to the expected path.
    It's currently done in the INIT block.
    
    If you try to use C4::Tags, you will get the famous "Too late to run
    INIT block at C4/Tags.pm line 74." warning. Plack use the INIT block to
    load functions at run time, when we are using C4::Tags when hitting a pl
    script, the compilation phase is finished and it's "too late to run INIT
    block" from C4::Tags.
    
    I do not really know if it has an impact on the behavior of
    Lingua::Ispell (i.e. is the path redefined?), but I know that this INIT
    block is not executed when we want.
    
    Test plan:
    under Plack,
    - hit /cgi-bin/koha/opac-search.pl and confirm that the warning does no
    longer appears
    - Use another dictionnary (??), fill TagsExternalDictionary with its
      path and confirm that it is used by the tags approval system
    
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Tags.pm |   10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)


hooks/post-receive
-- 
main Koha release repository