[koha-commits] main Koha release repository branch master updated. v16.05.00-80-g4f30671

Git repo owner gitmaster at git.koha-community.org
Fri Jun 10 19:31:52 CEST 2016


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  4f3067184d7dd3666d404a2165d72755cb0b227d (commit)
       via  bb6e70fe7d4ba530fe64179fe6fde4d6b4ec5e35 (commit)
       via  90307bcbfaf4c2c8907be94eabca249ac173442e (commit)
      from  f17897fb105fccb7edbf60b24c7d6e5362351cb2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4f3067184d7dd3666d404a2165d72755cb0b227d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Jun 8 15:32:31 2016 +0100

    Bug 16492: Add a FIXME to explain the possible problem with no_set_userenv
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit bb6e70fe7d4ba530fe64179fe6fde4d6b4ec5e35
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed May 25 17:33:00 2016 +0100

    Bug 16492: Test that no_set_userenv will not set userenv if not exist yet
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 90307bcbfaf4c2c8907be94eabca249ac173442e
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Tue May 10 16:36:03 2016 +0000

    Bug 16492 - Checkouts ( and possibly checkins and other actions ) will use the patron home branch as the logged in library
    
    Bug 14507 introduced the use of checkpw in C4::SIP::ILS::Patron so that
    non-Koha internal authentication processes would be able to function via
    SIP ( LDAP et al ).
    
    The problem is that checkpw changes the userenv to that of the patron!
    This is not usually an issue in Koha because most of the time that
    patron running through checkpw is the one to be logged in.
    
    Aside from SIP2 the only other area where this may be an issue is in SCO
    when using SelfCheckoutByLogin.
    
    Test Plan:
    1) On master, check out an item to a patron via SIP2
    2) Note the checkout lists the item as having been checked out
       from the patron's home library not matter which library is was
       supposed to be checked out from.
    3) Apply this patch
    4) Re-checkout the item
    5) The item should now be checked out as if it was checked out from
       the library as defined in the SIP configuration file.
    
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Auth.pm            |   15 ++++++++++-----
 C4/SIP/ILS/Patron.pm  |    2 +-
 t/db_dependent/Auth.t |   42 +++++++++++++++++++++++++++++++-----------
 3 files changed, 42 insertions(+), 17 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list