[koha-commits] main Koha release repository branch master updated. v16.05.00-97-g4fc8b3d
Git repo owner
gitmaster at git.koha-community.org
Fri Jun 10 19:58:33 CEST 2016
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 4fc8b3d6cf6453f7ff550b9fbde1a7f6315dd066 (commit)
via fd152d9e95a2236a00f3cb0284bdd2aa7cca6da2 (commit)
from 45dce0ac795357f5111db8cd81473317613bdcc1 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 4fc8b3d6cf6453f7ff550b9fbde1a7f6315dd066
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Mon Jun 6 10:49:06 2016 +0200
Bug 16635: [QA Follow-up] Eliminate some global package vars
[1] $branch is only related to line 123 as fallback.
[2] $width moved to a constant; sub width is not used.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested the corresponding plugin in item editor.
Test t/db_dependent/Barcodes.t and Barcodes_ValueBuilder.t still pass.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit fd152d9e95a2236a00f3cb0284bdd2aa7cca6da2
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Wed Jun 1 20:41:27 2016 -0400
Bug 16635: t/00-load.t warning from C4/Barcodes/hbyymmincr.pm
According to http://perldoc.perl.org/vars.html, "our" should
be a reasonable substitute for the "use vars". By declaring as
"our", and removing the INIT, prove t/00-load will no longer
generate a warning about INIT for the C4/Barcodes/hbyymmincr.pm
module.
TEST PLAN
---------
1) prove t/00-load.t
-- warnings about INIT for hbyymmincr
2) prove `git grep -l hbyymmincr | grep [.]t$`
-- should all run okay
3) apply patch
4) repeat steps 1 and 2
-- warning should be gone, and everything else run okay
5) run koha qa test tools
Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Barcodes/hbyymmincr.pm | 27 ++++++++++++++-------------
1 file changed, 14 insertions(+), 13 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list