[koha-commits] main Koha release repository branch 16.05.x updated. v16.05.00-93-ga8534a4
Git repo owner
gitmaster at git.koha-community.org
Wed Jun 15 09:14:47 CEST 2016
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 16.05.x has been updated
via a8534a4da728030d51647285cfb30b3f25a835c5 (commit)
via 903d0432c3dfc84236d1ff40606444e3a56c845b (commit)
via 012de8ccdf0365601003a6ff10479782423f6c05 (commit)
via 358e7a6d61d49c3ad8b57e2ad952f3fd9e4b83de (commit)
via fcbb59f25e25d86cc5be82595d330aa1b534b3cc (commit)
via af029c8655eb90e604286118ac6065851088bd57 (commit)
via c8ef873ee9fe97210d00d450a19f6ad52036b400 (commit)
via 9c7c4f02ddad4045fde7ecf68c03389bb6f10436 (commit)
via 94d77bd9c2955f5bafa868f3e2aa375112383194 (commit)
via 7fbfa01f78c79daf434a351d165d22382f13fd94 (commit)
via cedc2b736e14381cc6830c6cb4b650ba19bc7719 (commit)
via 98a8dca48298fd329c16831a6d5183421ceefd0d (commit)
via 7f3243daec25a462d4c9244b8b7b7c8dd6f2fd3f (commit)
via fe295fce2dec9626498154658bb45cd46ea09cb4 (commit)
via 2abe013436c81748f3a4170ad93009eda8e79861 (commit)
via 88c130eb43eacc8ce107509a6985a4d6eb4f0683 (commit)
via 9d8b407d7e0fc220268c4df3a0bebe4f508eae25 (commit)
via e8cca084407e888db19d13930c22e59662a9690f (commit)
via 0cc550dcc3d0c05b9688bb590a827671f5f8ee95 (commit)
via e6d820ade3821d7f2561babd5abfb3b29de43ace (commit)
via 34f8ab6f4040aeaee2cf674a550c052bc3c1a9b8 (commit)
via f13e8306299f274497a41a6df730209a76a71a04 (commit)
via acc459fa1bae3b1abd13b826420bfb836a1250af (commit)
via 4b3b7bbd8d6b497e17ad862737c607bcc5fd09e4 (commit)
via 744b035932608a0ce3dd495765f9c249d1f527db (commit)
via ac00e73077164db595432b723ee6f938e009dc7d (commit)
via f69eeca6c4a7d7d4b0538e7964a0f5f190de4b4e (commit)
via 57086a241e141e157d42b8af3f56ae9283d46ae9 (commit)
via 700fbd0a35073dc3cef7b3e340ab806a21354ba1 (commit)
via 22c1188c0ba96b1f783e9d72b81e542a506984f0 (commit)
via 25c91b797afcc7bd976fd10299e0becf6c42ff34 (commit)
via 213401821d56087e96da7383b1eb6ff5a97dbdad (commit)
via a1f1ea03177204af1cb5dde29b5f18f339402bdb (commit)
via 155d4ce1d2a90841dd37c496bcf2e3130a0b2cc0 (commit)
via 7e1aeff2890e82d24e2f6473083a316355021c15 (commit)
via 43002c3b0e1659edc910cae435c3715a46e80a76 (commit)
via 164ffdb43c98b4d2fa193d80c48f5509294fa1ca (commit)
via c5fc0fcd0e28309114c70333cb75a2aee11b35e0 (commit)
via 5ce7baf937d8e7ddf56ca0ae4dde00690fe5a32c (commit)
via b31ee2eaf9dd86171cac1598f3f9a611ea145f83 (commit)
via 4ebfb709f6cdeb263b579f7a3538c1a1342a939a (commit)
via a44040d07d24707d2cda51d989ad0fa495116608 (commit)
via c63dccba27842ce92569625a03df55085bf5681a (commit)
via 8e7e2c0db929fe9dab47f2cc71c353564e267850 (commit)
via c0c00b80cd5aca3a0fe1903acbb03031fb654dd2 (commit)
via 03d51281b079c379a2fba0caf8a9df8ec9c6d500 (commit)
via 93ffd58fe32dd4e27056f5cebf18b975f3d0624b (commit)
via 6ff159e214a2ebf904ff7f1b77f0f75162f8afe8 (commit)
via 259fe9947b73023a22aceda2b7f7ad357500884f (commit)
via 2729f038c34b5c4f0b713738c9bf4a94068f1b43 (commit)
via e242625721b0dcd68cd7b3408ef9da5d367a878d (commit)
via 020d755ed061cfc94ca12eace6fae7388cc89e3e (commit)
via 97a3f03970e1aa8d3eba5e5502f092202e43349b (commit)
via b7a0322258ad534ea8e5af34cb0581b0b5f174e8 (commit)
via df36beeffd1be584478cc85764b55959ccf75da7 (commit)
via a987ff3ba92e1558e11a63335895749b5efd1689 (commit)
via 12f6f9438a426a12c408b7d27e1af2e0cd52d1a3 (commit)
via 2d1488998758ddc7d558eaaf1f6acac07dff6cd7 (commit)
via 316e1a672359c8ba8f065942945cfca183456e23 (commit)
via 9a2c6bfde243f0fe41112fe1b651273ab091c901 (commit)
via b49adab4a1c4bb08714371223572caf35460f0f4 (commit)
via 14b9930b079c3f5518dce7a8cedc887790a2f27a (commit)
via feabd6e38648b5f4efefd50772d78eebe6261d5c (commit)
via 26afd665ecfeff6668216467cd77ac25d50f74e4 (commit)
via acdc5f27a7625746d004e62f865c384c566fb2ef (commit)
via 16a35fb6315567f2631ed1598031c94ef25505df (commit)
via 65232361231f5006f25cc354e24b38b07f359d61 (commit)
via 66c9ef12c16efeebf78e3a98be7b2ccc42d14e7a (commit)
via 9f935b384fd01c863af1de195f4fe256450f4a46 (commit)
via 5712275a4645d4d899815120fe79e730edf1034e (commit)
via 247bd55876a4e930934419070fc926a656a0d9d7 (commit)
via 5949faae071c317c029c9c89320c52d73cd7a362 (commit)
via 385cf8e64100bfd18cabe1e2a5d7a37beeb4daad (commit)
via 631e349ff2e751a43f9e0a426f94ab4b116ad8c7 (commit)
via 10733c39399d4db48bd5a73a9c4a195531751875 (commit)
via 92c08a6a4e177622a4513fa34c81dfcbec20ec57 (commit)
via ddf80b2003522cc0542d4ee4f9b8e19fb7a8c4e0 (commit)
via 0c4661110c467c8d11631cc627395acef941c9c9 (commit)
via 300cfc1ac8ae979b737b584e303823059d34680e (commit)
via 1f9e53f81c19dd56f7e77f40a05aa8433e2740d3 (commit)
via 7626ecedc8c640cedd21463d90117aecad1e6a80 (commit)
via d80368370258432aab4d4171b886af26442d08c1 (commit)
via 326616d2bce77b245e0d38eb3df659e821130645 (commit)
via 06d775c3b3e9a376bbd9e09fc4cac65d35ce7363 (commit)
via 8b9812fa83c110c446b58b6b1188d67d20011430 (commit)
via a85be57e1ce1d2adde6b9ee3dba55f7c5f2e06ab (commit)
via a47180eb3bc0ca26a018f68ffcc4d5635f6f7789 (commit)
from fa1dd408ca7714aed406ff75d3c4c55545b97cf0 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit a8534a4da728030d51647285cfb30b3f25a835c5
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu May 26 07:26:33 2016 -0400
Bug 16592 - Use Bootstrap modal for MARC and Card preview on acquisitions receipt summary page
This patch replaces Greybox modals on the acquisitions receipt summary
page with Bootstrap modals.
To test, apply the patch and go to Acquisitions -> Invoices -> View an
invoice -> Go to receipt page.
- In the list of pending orders, test the "MARC" and "Card" links for
various titles. Each should trigger a Bootstrap modal with the correct
content.
- Repeat the same tests in the list of already received orders.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 71aa7d9ecfa5c5fa07e02dbb479c78f304338988)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 903d0432c3dfc84236d1ff40606444e3a56c845b
Author: Claire Gravely <c.gravely at arts.ac.uk>
Date: Sat Jun 4 13:30:30 2016 +0200
Bug 16165 - Include link to ILS-DI documentation page in ILS-DI system preference
There is no clue in the system preference about the nice ILS-DI documentation
once you turn it on. We should include a note and the link, similar to how we
do it for the web self checkout.
Test plan:
Syspreference ILS-DI should now include URL in description.
Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 9066ae153b15ae49b7d5832b331eed31c32ed583)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 012de8ccdf0365601003a6ff10479782423f6c05
Author: Liz Rea <liz at catalyst.net.nz>
Date: Fri Nov 20 11:29:44 2015 +1300
Bug 15213 - Fix tools sidebar to highlight Patron lists when in that module
To test:
Add some patron lists, navigate through the lists interface and make
sure that while you are in the module, that Patron lists is highlighted
on the sidebar.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Amended patch: fix alignement
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 0427dfe8ee65e87e9442af16d4069afdfcde2801)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 358e7a6d61d49c3ad8b57e2ad952f3fd9e4b83de
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Sat Jun 4 11:11:00 2016 -0400
Bug 16637: Dependency for C4::Tags not listed
Added optional dependency, so as to explain why testing
explodes when the Enhanced Content system preference
TagsExternalDictionary is set. It is optional, because not only
does TagsExternalDictionary have to be set, but TagsEnabled
must be 'Allow'.
Also tweaked C4/Tags.pm to ignore TagsExternalDictionary,
if Lingua::Ispell is not installed. A warning is given.
TEST PLAN
---------
1) Set the Enhanced Content system preference
TagsExternalDictionary to /usr/bin/ispell
2) sudo apt-get install liblingua-ispell-perl
-- should be a new install
3) prove t/db_dependent/Tags.t
-- should work fine
4) sudo apt-get remove liblingua-ispell-perl
5) prove t/db_dependent/Tags.t
-- should explode
6) Clear the Enhanced Content system preference
TagsExternalDictionary
7) prove t/db_dependent/Tags.t
-- should work fine
8) apply patch
9) prove t/db_dependent/Tags.t
-- should work fine
10) Set the Enhanced Content system preference
TagsExternalDictionary to /usr/bin/ispell
11) prove t/db_dependent/Tags.t
-- should work, with warning.
12) sudo apt-get install liblingua-ispell-perl
13) prove t/db_dependent/Tags.t
-- should work fine
14) run koha qa test tools.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Post-hackfest hotel Olympia lobby signoff. Kalimera!
Works as expected.
At this moment the Tags.t test does not need the database btw,
but the module should have much more test coverage.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit c91b16bd9e82588c7625f69e37d6435dd378915e)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit fcbb59f25e25d86cc5be82595d330aa1b534b3cc
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Jun 10 18:02:14 2016 +0000
Bug 16636 [QA Followup] - Move tests to t/External
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 1fda4105a8a0f1e2165e27cea8314b578196dba2)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit af029c8655eb90e604286118ac6065851088bd57
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Jun 10 10:31:34 2016 +0200
Bug 16636: [QA Follow-up] Move External_BakerTaylor.t to t
When we mock the preferences completely now, we do not need
db access anymore.
Test plan:
Run the test without exporting KOHA_CONF.
The test passes with some warns about koha-conf.xml.
If you point KOHA_CONF to etc/koha-conf.xml, you have no warns.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 7f4682df0dfa460c0e2ef9117e032165a45d6e79)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit c8ef873ee9fe97210d00d450a19f6ad52036b400
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Jun 10 09:30:51 2016 +0200
Bug 16636: [QA Follow-up] Make BakerTaylor plack safe
Initialize file level lexicals each call. Do not call _initialize
outside the module.
Adjust test by mocking preferences.
Test plan:
Run t/db_dependent/External_BakerTaylor.t.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested module with trivial script under Plack/memcached by toggling
the associated preferences.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 5361440f6538127c8c3ec61d963d5f0692c64a71)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 9c7c4f02ddad4045fde7ecf68c03389bb6f10436
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Wed Jun 1 20:43:30 2016 -0400
Bug 16636: t/00-load.t warning from C4/External/BakerTaylor.pm
Since the tests are expecting an initialize function, the
initialize call was just moved outside of the INIT block.
TEST PLAN
---------
1) prove t/00-load.t
-- warnings about INIT for BakerTaylor
2) prove `git grep -l BakerTaylor | grep [.]t$`
-- should all run okay
3) apply patch
4) repeat steps 1 and 2
-- warning should be gone, and everything else run okay
5) run koha qa test tools
Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
Signed-off-by: Florent Mara <florent.mara at gmail.com>
NOTE: Tweaked test plan based on comment #4,
Added sign off based on comment #6.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit b4479624de2010fff8851732e94d086b2cca6921)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 94d77bd9c2955f5bafa868f3e2aa375112383194
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Mon Jun 6 10:49:06 2016 +0200
Bug 16635: [QA Follow-up] Eliminate some global package vars
[1] $branch is only related to line 123 as fallback.
[2] $width moved to a constant; sub width is not used.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested the corresponding plugin in item editor.
Test t/db_dependent/Barcodes.t and Barcodes_ValueBuilder.t still pass.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 4fc8b3d6cf6453f7ff550b9fbde1a7f6315dd066)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 7fbfa01f78c79daf434a351d165d22382f13fd94
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Wed Jun 1 20:41:27 2016 -0400
Bug 16635: t/00-load.t warning from C4/Barcodes/hbyymmincr.pm
According to http://perldoc.perl.org/vars.html, "our" should
be a reasonable substitute for the "use vars". By declaring as
"our", and removing the INIT, prove t/00-load will no longer
generate a warning about INIT for the C4/Barcodes/hbyymmincr.pm
module.
TEST PLAN
---------
1) prove t/00-load.t
-- warnings about INIT for hbyymmincr
2) prove `git grep -l hbyymmincr | grep [.]t$`
-- should all run okay
3) apply patch
4) repeat steps 1 and 2
-- warning should be gone, and everything else run okay
5) run koha qa test tools
Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit fd152d9e95a2236a00f3cb0284bdd2aa7cca6da2)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit cedc2b736e14381cc6830c6cb4b650ba19bc7719
Author: Marc Véron <veron at veron.ch>
Date: Wed Jun 1 22:28:51 2016 +0200
Bug 16634: Translatability: Fix issue in memberentrygen.tt
This patch fixes a small translatability issue in
koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
The sentence following sentence was splitted by HTML tags:
"Attribute value xxxxx is already in use by another patron record."
To test:
- Review code
- Apply patch
- In Admin, create a unique patron attribute type and try to give
two patrons the same value for this attribute type.
Signed-off-by: Rocio Dressler <rocio at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 45dce0ac795357f5111db8cd81473317613bdcc1)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 98a8dca48298fd329c16831a6d5183421ceefd0d
Author: Marc Véron <veron at veron.ch>
Date: Wed Jun 1 21:26:55 2016 +0200
Bug 16633: Translatability: Issues in tags/review.tt (sentence splitting)
This patch fixes translatability issues in
koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt
(isolated words by sentence splitting).
To test:
- Review code and verify that changes make sense.
Signed-off-by: Rocio Dressler <rocio at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 203d34a3ca821e409cf612c29b918745a3ea8ddb)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 7f3243daec25a462d4c9244b8b7b7c8dd6f2fd3f
Author: Marc Véron <veron at veron.ch>
Date: Tue May 31 10:17:13 2016 +0200
Bug 16620: Translatability: Fix problem with isolated word "please" in auth.tt
This patch fixes a translatability problem (syntax in different languages) with a tag-isolated word "please"
in koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt
To test:
- Verify in code that there is no sentence spliting by a-tags (lines 80/84).
Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit b0ba45058ab0221838f7563f761d283c377b829d)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit fe295fce2dec9626498154658bb45cd46ea09cb4
Author: phette23 <phette23 at gmail.com>
Date: Fri May 27 10:13:14 2016 -0700
Bug 16613: fix MARC 09X help links
The 09X MARC fields, such as 099 local call number or 090
locally-assigned Library of Congress call number, all point to
non-existent pages on the LC website, e.g.
http://www.loc.gov/marc/bibliographic/bd090.html
Test plan:
- enter the advanced cataloging editor
- begin to input any MARC tag of form 09X
- click the help link at the bottom of the browser window
=> Without this patch, taken to a URL of form `'http://www.loc.gov/marc/bibliographic/bd' +
tag + '.html'` which is broken because the only documentation for
these tags is at https://www.loc.gov/marc/bibliographic/bd09x.html
=> With this patch applied, the link is correct
Signed-off-by: Nicole C Engard <nengard at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit ec66ff457b6f1b682f7ad7d0e4f2df6656815848)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 2abe013436c81748f3a4170ad93009eda8e79861
Author: Marc Véron <veron at veron.ch>
Date: Mon May 23 11:20:10 2016 +0200
Bug 16563: Translatability: Issues in opac-account.tt (sentence splitting)
This patch removes splitting by <i>-tags from 2 sentences.
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
No errors
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit b6979db41057e5a9770789fdaf43a793b69601e6)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 88c130eb43eacc8ce107509a6985a4d6eb4f0683
Author: Marc Véron <veron at veron.ch>
Date: Wed Jun 1 16:41:55 2016 +0200
Bug 16540 - Clean up opac-auth.tt for translatability
This patch fixes translatability issues in opac-auth.tt (ugly
translations caused by sentence splitting).
It was necessary to change indentation to make the the file more
readable and to make sure that changes have no side effects.
The changes do not touch the overall functionallity.
To test:
- Review code to verify that no functionality change is introduced
and to verify that the text changes make sense.
- Apply patch, verify that OPAC login page behaves as before.
UPDATE: Amended for comment #10 / mv
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 6b432d2b213101d2e8d0bf41fbc4a0e5b4ecb4e1)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 9d8b407d7e0fc220268c4df3a0bebe4f508eae25
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Sun Jun 5 08:46:06 2016 -0300
Bug 16667: Unused variable and function call in circulation.pl
This patch removes an unused occurence of the $branches variable. Probably a
leftover from a recent rewrite.
To test:
- Run:
$ git grep '$branches' circ/circulation.pl
=> FAIL: Only on occurence of the variable
- Apply the patch
- Run:
$ git grep '$branches' circ/circulation.pl
=> SUCCESS: The variable has been removed
- Sign off :-D
Regards
Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 2bff91eb4e733a5c658e17fb93f13497768ba2e6)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit e8cca084407e888db19d13930c22e59662a9690f
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri May 27 14:02:42 2016 +0200
Bug 16609: Catch warning from Koha::Hold in Hold.t
Before this patch, the suspend step triggers a warn from Koha::Hold.
Now we catch it.
Test plan:
Run the test. Do not see the warning about unable to suspend.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
NOTE: Nice clean up!
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 740cb37e94d80a8beb41710f5e57d6e4a46fc17a)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 0cc550dcc3d0c05b9688bb590a827671f5f8ee95
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Fri May 27 10:50:00 2016 +0200
Bug 16608 - Missing entity nbsp in some XML files
The special character "non breaking space" is not contained in XML
syntax by default. So we add it in the file header :
<!DOCTYPE stylesheet [<!ENTITY nbsp " " >]>
Even if the source code files do no contain this character, it can be that
translated files contain it. French for example "Titre :".
This entity is missing in all files in koha-tmpl/intranet-tmpl/prog/en/data/
and in some files of koha-tmpl/intranet-tmpl/prog/en/xslt.
Test plan :
- generate French templates:
cd misc/translator
./translate install fr-FR
cd ../..
- run test:
prove -v t/00-valid-xml.t
you get failing error message
- apply this patch
- translate again
- run test again: it passes
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Works as described following test plan
Tes pass, no errors.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit f38a9927a3d27709173564848bda4a4a61abeadb)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit e6d820ade3821d7f2561babd5abfb3b29de43ace
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Fri May 27 10:46:44 2016 +0200
Bug 16608 - Add xsd extension to t/00-valid-xml.t
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit ce979300168fc7a885463a1a2be519562319844a)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 34f8ab6f4040aeaee2cf674a550c052bc3c1a9b8
Author: Marc Véron <veron at veron.ch>
Date: Sat May 28 09:44:40 2016 +0200
Bug 16589 - Quote of the day: Fix upload with csv files associated to LibreOffice Calc
To reproduce:
- Install LibreOffice and make sure that csv files are associated to Calc
(Note: tested with Firefox 46.0.1 on Windows 8)
- Go to Home > Tools > Quote editor > Quote uploader
- Try to upload a valid CSV (e.g. Example from Bug 15684)
Result: File can not be uploaded
(Incorrect filetype: application/vnd.sun.xml.calc)
To test:
- Apply patch
- Try to upload again
Expected result: Quotes are imported.
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
Can't reproduce on a Mac but get it fails on a Windows Box: fixed with this
patch.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Can't recreate on debian but the fix looks safe.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 8631ebaf9f634976b076958707af355baf78cc2f)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit f13e8306299f274497a41a6df730209a76a71a04
Author: Marc Véron <veron at veron.ch>
Date: Mon May 23 14:16:02 2016 +0200
Bug 16560: Translatability: Issues with "The entered " in opac-memberentry.tt
This patch fixes two splitted sentences to avoid translation issues:
The entered <a href="#borrower_cardnumber">card number</a> is the wrong length.
The entered <a href="#borrower_cardnumber">card number</a> is already in use.
To test:
Apply patch and verify that html in the 2 that are changed is correct and that
they are not splitted by a-tags.
Note: I could not figure out under which conditions this code displays in
the OPAC self registration form.
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 593dee4ea02971f8932d15fe1ba4dc157a379bac)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit acc459fa1bae3b1abd13b826420bfb836a1250af
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu May 26 12:29:38 2016 -0400
Bug 15676 - Actions in pending offline circulation actions are not translatable
This patch modifies the offline circulation transaction processing page
so that English strings describing actions are processed in the template
rather than being output directly from the script.
To test, apply the patch and create an offline circulation file
containing at least one checkout, one check-in, and one payment.
- Upload the file and choose 'Add to offline circulation queue.'
- View pending offline circulation actions
- In the list of pending actions, the actions column should show "Check
out" instead of "issue," "Check in" instead of "return," and "Payment"
instead of "payment."
Strings appear as expected.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit e9d6ac9478606d9d123a22635719b99d985b9538)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 4b3b7bbd8d6b497e17ad862737c607bcc5fd09e4
Author: Dimitris Antonakis <dimantonak at gmail.com>
Date: Sat Jun 4 16:00:47 2016 +0300
Bug 14897 - Header name mismatch in ./modules/catalogue/detail.tt
We changed the detail.tt file for staff interface from Publication details to
"Serial enumeration / chronology" to match the cataloguing editor.
Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 43d77fdcf01906fa535482691e5eade47287ab2f)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 744b035932608a0ce3dd495765f9c249d1f527db
Author: Blou <philippe.blouin at inlibro.com>
Date: Mon Jul 27 16:24:46 2015 -0400
Bug 14605 - Corrects the individual fine's description
When paying a fine, the description is built out of the borrower's type and title, instead of the actual fine's description.
STEPS:
1) in the staff, go to a user with a fine to pay.
a) if none, go to a user and Fines>>"Create manual invoice" with a
distinctive description.
2) In Fines>>Pay fines, click the "Pay" button on the line of the fine.
3) This will take you a "Pay an individual fine" screen, where the description
will look like "Staff Mrs", for the category and title of the borrower.
Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 63041c19c98b90c934ef89634dfdaf2d6abeb762)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit ac00e73077164db595432b723ee6f938e009dc7d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jun 8 15:32:31 2016 +0100
Bug 16492: Add a FIXME to explain the possible problem with no_set_userenv
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 4f3067184d7dd3666d404a2165d72755cb0b227d)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit f69eeca6c4a7d7d4b0538e7964a0f5f190de4b4e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed May 25 17:33:00 2016 +0100
Bug 16492: Test that no_set_userenv will not set userenv if not exist yet
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit bb6e70fe7d4ba530fe64179fe6fde4d6b4ec5e35)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 57086a241e141e157d42b8af3f56ae9283d46ae9
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue May 10 16:36:03 2016 +0000
Bug 16492 - Checkouts ( and possibly checkins and other actions ) will use the patron home branch as the logged in library
Bug 14507 introduced the use of checkpw in C4::SIP::ILS::Patron so that
non-Koha internal authentication processes would be able to function via
SIP ( LDAP et al ).
The problem is that checkpw changes the userenv to that of the patron!
This is not usually an issue in Koha because most of the time that
patron running through checkpw is the one to be logged in.
Aside from SIP2 the only other area where this may be an issue is in SCO
when using SelfCheckoutByLogin.
Test Plan:
1) On master, check out an item to a patron via SIP2
2) Note the checkout lists the item as having been checked out
from the patron's home library not matter which library is was
supposed to be checked out from.
3) Apply this patch
4) Re-checkout the item
5) The item should now be checked out as if it was checked out from
the library as defined in the SIP configuration file.
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 90307bcbfaf4c2c8907be94eabca249ac173442e)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 700fbd0a35073dc3cef7b3e340ab806a21354ba1
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jun 8 14:52:04 2016 +0100
Bug 16695: Require Exception::Class 1.38 instead of 1.39
Looking at
http://cpansearch.perl.org/src/DROLSKY/Exception-Class-1.40/Changes
there is no need to require 1.39
Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit a4c44b9f643ab9a31c4025f6001a823fdcbb8101)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 22c1188c0ba96b1f783e9d72b81e542a506984f0
Author: Galen Charlton <gmcharlt at gmail.com>
Date: Tue Jun 7 00:44:07 2016 +0000
Bug 16647: update debian/control for 16.*
This patch updates debian/control* to match what
was used for building the 16.05.00 packages, and includes
changes to:
- specify a floor for the Swagger2 version
- add dep on libio-socket-ip-perl, which is needed
for the package to work on Debian Wheezy
- suggest libwww-youtube-download-perl
Signed-off-by: Galen Charlton <gmcharlt at gmail.com>
Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 40f3d43f46cccb5bb8077aae64684c5c5a0ed781)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 25c91b797afcc7bd976fd10299e0becf6c42ff34
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Sat Jun 4 12:26:27 2016 +0100
Bug 16649: Make OpenLibrarySearch test pass even if launches offline
Test plan:
prove t/OpenLibrarySearch.t
should return green even if you are offline
Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
Signed-off-by: Galen Charlton <gmcharlt at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit f97626271ecf7ea90724cd7b131cf4eabb883c23)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 213401821d56087e96da7383b1eb6ff5a97dbdad
Author: Galen Charlton <gmcharlt at gmail.com>
Date: Tue Jun 7 01:42:59 2016 +0000
Bug 16675: fix breakage of t/Languages.t
This patch fixes test breakage introduced by the patch for bug 16088,
which added caching of getlanguages(). Upon inspection, it looks like
the patch for 16088 does not introduce a regression on bug 10560,
so this patch adds a couple cache-clearings.
To test
-------
[1] Verify that t/Languages.t passes.
Signed-off-by: Galen Charlton <gmcharlt at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit b9b4eeb849dcb52053a98440e1d8fb02011a9005)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit a1f1ea03177204af1cb5dde29b5f18f339402bdb
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jun 7 12:29:33 2016 +0100
Bug 16668: Fix t/Ris.t tests
Caused by bug 16442.
Now we need to mock the marcflavour pref
Test plan:
prove t/Ris.t
should return green
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 023384811f54f18fbe585431c49b80cfc20e58dd)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 155d4ce1d2a90841dd37c496bcf2e3130a0b2cc0
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Mon May 30 12:16:36 2016 -0400
Bug 16618: 00-load.t prematurely stops all testing
Rather than add/remove regular expressions to skip modules (like bug 9054), encapsulate the decision logic into a separate function.
Currently there are three libraries which trigger halts:
Koha::NorwegianDB (which was already there)
Koha::ElasticSearch::Indexer
Koha::SearchEngine::Elasticsearch::Search
TEST PLAN
---------
1) prove t/00-load.t
-- should barf horribly on Catmandu stuff
if not: sudo apt-get remove libcatmandu-marc-perl
then repeat step.
2) apply patch
3) prove t/00-load.t
-- should not barf horribly
4) run koha qa test tools
NOTE: The four optional modules for Koha::NorwegianDB are
listed in the PerlDependencies.pm, while there is
no mention of Catmandu libraries at all there.
This may be another bug which needs fixing.
TECH NOTES (for ideas of how to tinker around):
These three things should trigger the three module cases:
sudo apt-get remove libcatmandu-marc-perl
sudo apt-get remove libcatmandu-store-elasticsearch-perl
sudo apt-get remove libconvert-basen-perl
You probably had koha-perldeps installed before, so the following wil mostly fix:
sudo apt-get install koha-perldeps libcatmandu-marc-perl
And in case you didn't have elastic search stuff installed:
echo deb http://packages.elastic.co/elasticsearch/1.7/debian stable main | sudo tee /etc/apt/sources.list.d/elasticsearch.list
wget -O- https://packages.elastic.co/GPG-KEY-elasticsearch | sudo apt-key add -
sudo apt-get update
cd ~
wget http://debian.koha-community.org/koha/otherthings/elasticsearch_deps.tar.gz
tar xvf elasticsearch_deps.tar.gz
cd es_deps
sudo dpkg i lib*
sudo apt-get install -f
Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Galen Charlton <gmcharlt at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 5e6da05b101e014d2b2ecc80b4fc4474c54503bc)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 7e1aeff2890e82d24e2f6473083a316355021c15
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu May 26 10:55:09 2016 +0100
Bug 16596: Display library and patron category descriptions instead of their code
Test plan:
On circ/circulation-home.pl and reserve/request.pl, search for patrons
The descriptions for the libraries and patron categories should be
displayed.
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
On top of Bug 13336
Works as described, now descriptions instead of codes.
No errors
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
https://bugs.koha-community.org/show_bug.cgi?id=16455
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 04e5c2630c6e3b2962498b932bd8967478c940e5)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 43002c3b0e1659edc910cae435c3715a46e80a76
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed May 25 18:09:27 2016 +0100
Bug 16578: Same fix for the staff interface
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Works as first patch
No errors
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 3948102f2ad6e5382a31a00df0c8f52def3daf58)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 164ffdb43c98b4d2fa193d80c48f5509294fa1ca
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue May 24 14:28:44 2016 -0300
Bug 16578: Fix wide character errors in opac-export.pl
This simple patch fixes wide character warning raised by opac-export.pl when
'MARC (Unicode/UTF-8)' and 'MARC (Unicode/UTF-8, Standard)' formats are chosen
for downloading records.
To test:
- Have records indexed
- Open your OPAC logs:
$ tail -f /var/log/koha/kohadev/opac-error.log
- Open the detail page in the opac for a record
- Choose Save record > MARC (Unicode/UTF-8)
=> FAIL: opac-export.pl: Wide character in print at /home/vagrant/kohaclone/opac/opac-export.pl line 116., referer: http://localh...
- Choose Save record > MARC (Unicode/UTF-8, Standard)
=> FAILE opac-export.pl: Wide character in print...
- Apply the patch
- Choose Save record > MARC (Unicode/UTF-8)
=> SUCCESS: No warnings raised.
- Choose Save record > MARC (Unicode/UTF-8, Standard)
=> SUCCESS: No warnings raised.
- Sign off :-D
Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 7d4844e171b1319b90e7bd73510bd97c2acbf635)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit c5fc0fcd0e28309114c70333cb75a2aee11b35e0
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed May 11 13:04:38 2016 +0100
Bug 16465: Fix typo issues vs checkouts
Test plan:
Confirm the wording is correct
Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit af59b669413539606f10652230e5f96d43337cb5)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 5ce7baf937d8e7ddf56ca0ae4dde00690fe5a32c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed May 11 12:57:47 2016 +0100
Bug 16465: discharge - Add a title tag at the OPAC
Test plan:
Confirm that the opac-discharge.pl has now a title
Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 27254de06d8ae6682b395be48d6ba02b69f9e917)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit b31ee2eaf9dd86171cac1598f3f9a611ea145f83
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed May 11 15:47:46 2016 +0200
Bug 16428: [QA Follow-up] Useless call to GetMarcStructure in _build_default_values_for_mod_marc
The routine calls GetMarcStructure and does not use its return value
after all.
Test plan:
Run t/db_dependent/Items.t
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 6a706b86a273672b1e1ca3f1456fde08dd7a0da2)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 4ebfb709f6cdeb263b579f7a3538c1a1342a939a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue May 3 11:03:52 2016 +0100
Bug 16428: Use the biblio framework to know if a field is mapped
The subroutine _build_default_values_for_mod_marc takes the
frameworkcode in parameter, but ModItemFromMarc did not pass it.
It uses it to know if a field is mapped or not to a Koha field
(C4::Koha::IsKohaFieldLinked).
Consequently the default framework ("") was always used.
This bug has been found working on bug 13074 and has been put on a
separate bug report to ease the backport.
Test plan:
Without this change, the tests added by bug 16428 won't pass
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 52b1b8eae1136af1e901560214a641494acaf577)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit a44040d07d24707d2cda51d989ad0fa495116608
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jun 7 11:48:46 2016 +0100
Bug 16441: Fix Letters.t
These tests were wrong, but the package variable used to cache the
letters hid the problem.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 687a7e22b6c630c3bbc06e1845854514f6fea5b0)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit c63dccba27842ce92569625a03df55085bf5681a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed May 4 19:43:43 2016 +0100
Bug 16441: Do not use a package variable to cache C4::Letters::getletter
C4::Letters::getletter use a package variable (%letter) to cache letter
returned by the subroutine.
I have not found any direct issues caused by that but it is safer to
remove it.
It won't be a big deal to hit the DBMS to get a valid letter when
needed.
No test plan here, just confirm that the changes make sense.
Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Confirm that performance loss is just a millisecond or so per
subsequent call of getletter.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit c4f388f64966f2202e9f3e3c16dad5cef3dbe0ac)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 8e7e2c0db929fe9dab47f2cc71c353564e267850
Author: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Date: Wed Jun 8 10:46:18 2016 +0200
Bug 16678: updatedatabase.pl 3.23.00.006 DB upgrade crashes if subscription_numberpatterns.numberingmethod contains parentheses
It seems that if subscription_numberpatterns.numberingmethod contains
parentheses, updatedatabase.pl crashes when running the 3.23.00.006 DB upgrade
snippet, with the following error:
[Mon Jun 6 09:06:54 2016] updatedatabase.pl: Unmatched ( in regex; marked by
<-- HERE in m/ ( <-- HERE / at
/home/koha/kohaclone/installer/data/mysql/updatedatabase.pl line 11498.
Steps to reproduce:
1/ Have a Koha DB version<3.23.00.006
2/ Create a subscription numbering with parentheses in it:
ie "Vol. (Month, Year)" with pattern
Vol. {X} ({Y}, {Z})
3/ Add some serials using that numbering method so that serialseq is filled in DB:
ie "Vol. 16 (February, 2015)"
4/ Run the updatedatabase.pl script either from the cli or just start the webinstaller
5/ The error is produced
To test:
1/ apply patch
2/ try to reproduce this issue once again, should be fixed now
3/ have a look at the code, make sure the changes are consistent
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Note: I have not tested the patch, but the diff looks good.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 113adf68e56b6233b44a2b7a9b5dc60f6c4de0b7)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit c0c00b80cd5aca3a0fe1903acbb03031fb654dd2
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue May 24 19:57:16 2016 +0100
Bug 16570: Do not tell all checked-in items are part of a rotating collection
When an item is checked-in a message will tell you it's part of a
rotating collection, even if it's not true.
Test plan:
Make sure the message appears only when needed.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 8794348ccbb156ddd1ec53702b5afebea1747976)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 03d51281b079c379a2fba0caf8a9df8ec9c6d500
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Jun 10 11:49:45 2016 +0200
Bug 16443: [QA Follow-up] Add two tests for get_fields
Adds t/db_dependent/Members/Statistics.t.
Test plan:
Run the test.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 30cf9ee277481b54ed75e500c38f328f2d82b831)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 93ffd58fe32dd4e27056f5cebf18b975f3d0624b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed May 4 20:08:53 2016 +0100
Bug 16443: Make C4::Members::Statistics plack safe
If the prefs is updated, the fields won't be.
To make sure we already fetch updated values, we should remove the
package variable and define it in the subroutine.
There is not test plan, just make sure the changes are consistent.
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 29e402d398f567e2526c89695384bce7f4e4b737)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 6ff159e214a2ebf904ff7f1b77f0f75162f8afe8
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu May 5 16:58:06 2016 +0100
Bug 16455: Remove the "Too late to run INIT block" from C4::Tags
The pref TagsExternalDictionary is used to tell Lingua::Ispell to use an
other dictionary, different from the default one (/usr/bin/ispell).
To do so we need to set $Lingua::Ispell::path to the expected path.
It's currently done in the INIT block.
If you try to use C4::Tags, you will get the famous "Too late to run
INIT block at C4/Tags.pm line 74." warning. Plack use the INIT block to
load functions at run time, when we are using C4::Tags when hitting a pl
script, the compilation phase is finished and it's "too late to run INIT
block" from C4::Tags.
I do not really know if it has an impact on the behavior of
Lingua::Ispell (i.e. is the path redefined?), but I know that this INIT
block is not executed when we want.
Test plan:
under Plack,
- hit /cgi-bin/koha/opac-search.pl and confirm that the warning does no
longer appears
- Use another dictionnary (??), fill TagsExternalDictionary with its
path and confirm that it is used by the tags approval system
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 7d916c380a03904c47035f189d1ee666f00d9a11)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 259fe9947b73023a22aceda2b7f7ad357500884f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue May 17 14:38:04 2016 +0100
Bug 16508: Updating a syspref requires parameters_remaining_permissions
And not all of parameters flags.
Test plan:
1/ Create a staff user.
2/ Go to details, select more->set permissions.
3/ Set catalogue, Manage Koha system settings (Administration panel),
manage circulation rules, and Remaining system parameters permissions.
4/ Log in as the new staff user, go to administration > system
preferences. Change a syspref and save it... it will save correctly.
5/ Log back in as superlibrarian
6/ On the 'set permissions' screen, un-check 'manage circulation rules'
and save.
7/ Log back in to the new staff user, and try to change the same
systemprefrence and save.
Followed test plan, works as expected.
Signed-off-by: Marc Veron <veron at veron.ch>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit f2fe433cf9afce98957826bf2ade457557fe4eff)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 2729f038c34b5c4f0b713738c9bf4a94068f1b43
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri May 13 20:46:42 2016 +0100
Bug 16518: Fix Plack variable scoping problem in opac-addbybiblionumber.pl
The script opac/opac-addbybiblionumber.pl is not plack safe because the
variable @biblios is declared with our and is not assigned to an empty
array (so not reset).
The issue:
When trying to add items to a list (virtualshelf), the biblionumbers are
added to the @biblios variable and the list is not reset between each
run.
Test plan:
Check from records from the result list and add them
to a list.
Cancel or save and re-add them (or others) to a list (same or
different).
=> Without this patch, the list of records will never stop growing, the
previous items added are still listed when adding new ones.
=> With this patch, the behavior is the one expected.
Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit ab1beed06f249d1e7d0be5bb1b584e62f5b48783)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit e242625721b0dcd68cd7b3408ef9da5d367a878d
Author: Aliki Pavlidou <pavlidoualiki at gmail.com>
Date: Sat Jun 4 12:10:38 2016 +0000
Bug 15641 - Typo in explanation for MembershipExpiryDaysNotice
There's an extra period after the word "in" in the MembershipExpiryDaysNotice
sys "Send an account expiration notice when a patron's card will expire in.
[value box
Bug fixed!
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 6b7f4a3a9ec18b550d011a7eee9e7108b7042059)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 020d755ed061cfc94ca12eace6fae7388cc89e3e
Author: Rocio Dressler <rocio at bwstest.bywatersolutions.com>
Date: Sat Jun 4 02:24:45 2016 -0700
Bug 16537 - Overdue and Status triggers grammar
Test plan:
1) Go to the staff client
2) Click on Tools - Overdue notice/status triggers
3) Confirm that the first sentence reads "a" checkout rather than "an" checkout
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit a589879f495aeb25200119cb4f1bf76c28dce660)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 97a3f03970e1aa8d3eba5e5502f092202e43349b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed May 4 20:20:51 2016 +0100
Bug 16444: Make C4::Tags plack safe
C4::Tags use a package variable to cache the pref
TagsExternalDictionary, it's not needed and not safe.
There is not test plan, just make sure the changes are consistent.
Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit fff754a7fc7a99dad6a35129b8a7dd170684f2bf)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit b7a0322258ad534ea8e5af34cb0581b0b5f174e8
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed May 11 12:00:01 2016 +0100
Bug 16458: Update library when a guarantor is set
If you edit a patron from the Edit link of the patron information block
(step 1 of the memberentry script), the branchcode is not displayed. If
you set a guarantor to a child from this form, a JavaScript error will
be raised:
JavaScript error form.branchcode is undefined
It happens because there is the branchcode is not displayed and there is
no element with a branchcode name.
To avoid this issue, a branchcode hidden input is added to the form and
it will be updated when a guarantor is selected (same behavior as when
you edit a patron using the complete form).
Test plan:
Edit a patron using the Edit link of the patron info block (not the Edit
button in the toolbar)
Set a guarantor
=> Notice that the branchcode of the patron has been updated with the
branchcode of the guarantor
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit fc35a5099f613c08d12be1d67fd027d4a5eaf99c)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit df36beeffd1be584478cc85764b55959ccf75da7
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon May 16 10:52:17 2016 -0400
Bug 16529 - Clean up and improve upload template
This patch makes some fixes and improvements to the template for Tools
-> Upload, including markup corrections, removal of 'onclick,' and
conversion of some links to styled buttons.
To test, apply the patch and go to Tools -> Upload.
- Confirm that uploading a file works correctly.
- Confirm that clicking 'Cancel' during a file upload works correctly.
- Search existing uploads.
- Confirm that the 'Download' and 'Delete' buttons look correct and
work correctly.
- In Administration -> MARC bibliographic framework, choose a
framework and configure a tag subfield to use the upload plugin.
- Create or edit a bibliographic record using the framework you
modified.
- Click the tag editor icon next to your modified subfield to trigger
the pop-up window with the upload form.
- Confirm that this window has a layout which is adjusted for the size
of the window.
- Confirm that uploading and selecting files from this window works
correctly.
Signed-off-by: Rocio Dressler <rocio at bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 6cd592ba3b18236a3c0f82873d4444c1f884f37c)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit a987ff3ba92e1558e11a63335895749b5efd1689
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed May 4 19:53:46 2016 +0100
Bug 16442: Make C4::Ris plack safe
C4::Ris incorrectly uses 4 package variables:
- $utf: not used, can be removed
- $intype: set to marcflavour once, but later it assumes that it is
usmarc if not defined
- $marcprint: always 0, so set it to 0
- $protoyear: only used in 1 subroutine, let's define it at this
level
Test plan:
Just make sure the RIS export works as before this patch
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 87b181c6d40e7a811fee511648ddd3cb7d44c4e4)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 12f6f9438a426a12c408b7d27e1af2e0cd52d1a3
Author: Chris Cormack <chris at bigballofwax.co.nz>
Date: Fri Jun 3 12:09:33 2016 +0000
Bug 7143 : Ooops double counted a developer
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 7e30240e694c65bb635a495820cce8883d26baa5)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 2d1488998758ddc7d558eaaf1f6acac07dff6cd7
Author: Chris Cormack <chris at bigballofwax.co.nz>
Date: Fri Jun 3 12:07:02 2016 +0000
Bug 7143: Updating about page for new developers
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit e1b5adec83febdb93e0045b711a19b84e5d06a4a)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 316e1a672359c8ba8f065942945cfca183456e23
Author: Chris Cormack <chris at bigballofwax.co.nz>
Date: Fri Jun 3 11:59:18 2016 +0000
Bug 7143 Updating the history.txt
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 84f7f1608553e3cd4610e96325eecff177da1d49)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 9a2c6bfde243f0fe41112fe1b651273ab091c901
Author: Claire Gravely <c.gravely at arts.ac.uk>
Date: Fri Jun 3 10:38:25 2016 +0200
Bug 16642 - Fix capitalisation for upload patron image
To fix capitalisation on the staff interface when patronimages is turned on.
Test plan:
1. In staff interface. Turn on patronimages sys preference.
2. Go to a patron without an image and check that the "Upload
patron image" box heading now has correct capitalisation.
3. Go to a patron with an image already uploaded and check the
"Manage patron image" box heading has correct capitalisation.
Signed-off-by: Sofia <szapoun at lib.auth.gr>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 78b2fde34831a4840f6b89df054a5307f1ead54b)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit b49adab4a1c4bb08714371223572caf35460f0f4
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon May 23 12:19:46 2016 +0100
Bug 16565: Drop additional_fields and additional_field_values before creating them
These 2 tables should be dropped before trying to create them
Test plan:
From the SQL CLI, source the kohastructure.sql file
source it again
=> Without this patch you get 2 warnings
ERROR 1050 (42S01) at line 3580 in file:
'installer/data/mysql/kohastructure.sql': Table
'additional_fields' already exi
sts
ERROR 1050 (42S01) at line 3596 in file:
'installer/data/mysql/kohastructure.sql': Table
'additional_field_values' alrea
dy exists
=> With this patch, you won't get them
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit a01cd77e19f810bf61c8d26ebb97f7c49f1d1f32)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 14b9930b079c3f5518dce7a8cedc887790a2f27a
Author: Aleisha <aleishaamohia at hotmail.com>
Date: Thu May 12 04:41:09 2016 +0000
Bug 12402: Show patron category on pending patron modifications
To test:
1) Go to OPAC and make a modification to user
2) Go to Staff Client and go to pending patron modifications
3) Notice that we have the user's surname, first name, branch and
cardnumber
4) Apply patch and refresh page
5) Notice that patron category now shows after user's name
Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 6c733b2fda7cd94ae2997c1a058d229dd7819692)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit feabd6e38648b5f4efefd50772d78eebe6261d5c
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu May 19 12:28:08 2016 -0400
Bug 16005 - Standardize use of icons for delete and cancel operations
This patch makes changes to Font Awesome icons in order to make icon
choice consistent for common actions.
<i class="fa fa-trash"></i> where something is deleted, removed, or
emptied.
<i class="fa fa-remove"></i> where an operation is cancelled (also where
selections are cancelled, as in checkboxes).
<i class="fa fa-times-circle"></i> for "close," as in baskets and
windows.
To test, apply the patch and view the following pages to confirm that
the correct icon is used:
- Acquisitions -> Vendor -> Vendor delete button.
- Acquisitions -> Vendor -> Edit -> Delete contact button.
- Acquisitions -> Invoices -> Delete menu item.
- Cataloging -> Edit record -> Authority search pop-up (triggered from
the tag editor for a tag linked to an authority) -> Clear field button
- Authorities -> Authority detail -> Delete button.
- Tools -> Quotes editor -> Quotes delete button.
- Reports -> View saved report -> Delete button.
- Reports -> Saved reports -> Delete menu item.
- Serials -> Subscription details -> Subscription close button.
- Administration -> Budgets -> Delete menu item.
- Administration -> Item search fields -> Delete button.
- Administration -> Z39.50/SRU servers -> Delete menu item.
- Catalog -> Advanced search -> Clear fields link.
- Cataloging -> Advanced editor -> Macros -> Delete macro button.
- Circulation -> Checkout -> Check out an item which is on hold for
another patron. "Cancel checkout and place hold" button now uses the
icon used elsewhere for holds.
- Course reserves -> Course -> Delete course button.
- Patrons -> Patron lists -> Add patrons -> Remove selected button.
- Acquisitions -> Suggestions -> Suggestion details -> Delete button.
- Lists -> List contents -> Remove selected button.
Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit ed449a5b5be4da03443d214de5806f4a0273227b)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 26afd665ecfeff6668216467cd77ac25d50f74e4
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Apr 25 09:12:05 2016 -0400
Bug 16336 [Revised] UX of holds patron search with long lists of results
Bug 15793 made a change to an interface which is also found in the place
hold template. This patch creates a new include file to be used by both
circulation.tt and request.tt so that these pages do not diverge.
In the process, this patch removes some markup and JavaScript which was
made obsolete by Bug 15793 and should have been removed.
This patch also revises the sorting of the results table so that the
patron name is sortable (Bug 16334) and the default sort is on card
number (matching 3.20.x and 3.22.x).
To test:
In Circulation:
- Perform a search by name for a patron which will
return multiple search results.
- The table of results which displays should look correct and work
correctly, including DataTables sorting.
- Clicking any table row should forward you to the checkout page for
that patron.
In the catalog:
- Locate and place a hold on a title.
- When prompted to select a patron to place the hold for, perform a
search by name which will return multiple results.
- Confirm that the table of patron results looks correct and works
correctly.
- Clicking any table row should forward you to the place hold page for
that patron and the title you selected.
Revision: Although the table row was clickable, you couldn't
middle-click it to open the link in a new tab. The patron name is now a
real link you can middle-click or right-click. The row is still
clickable as well.
Signed-off-by: Aleisha <aleishaamohia at hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 4c04f6f8e0068a7cce256c3cd8ffcf5acf682fe0)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit acdc5f27a7625746d004e62f865c384c566fb2ef
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri May 13 15:28:50 2016 +0100
Bug 16388: Use existing 'execute' parameter instead of creating a new one
An existing 'execute' parameter is already passed to the template when
we need to display the 'Download' button, so let's use it instead of
creating a new one.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit c2f53bd039aa2ce52c2ddc3a2314e32b44ae4ee8)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 16a35fb6315567f2631ed1598031c94ef25505df
Author: Aleisha <aleishaamohia at hotmail.com>
Date: Fri Apr 29 02:47:06 2016 +0000
Bug 16388: Move option to download report into reports toolbar
To test:
1) Create a new SQL report or edit a report
2) Ensure that the download option does NOT show in the toolbar
3) Save and run the report
4) Confirm that download option DOES show in toolbar as a dropdown with
the 3 options (csv, tab and ods)
5) Confirm that downloading all 3 file types works as expected
Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit e7ac7abf16c76a00a5dcd8e8cd1e62522675b8ee)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 65232361231f5006f25cc354e24b38b07f359d61
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Tue May 24 22:31:15 2016 -0400
Bug 16582 t/Price.t test should pass if Test::DBIx::Class is not available
TEST PLAN
---------
1) prove t/Prices.t
-- failure
2) apply patch
3) prove t/Prices.t
-- nicely skipped when Test::DBIx::Class is not available.
Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 5ba5f9e0c5958b518bd648f08146329e355f3a7e)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 66c9ef12c16efeebf78e3a98be7b2ccc42d14e7a
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri May 27 12:42:17 2016 +0000
Bug 16610 - Regression in SIP2 user password handling
Previous to bug 14507, SIP2 only did internal authentication. A change
to the way we check empty passwords has caused any empty password to
send back a CQ of Y. Previous to that patch set, a CQ of Y would only be
sent back of the patron password column was NULL. Now, an empty AD field
*always* returns a CQ of Y.
Test Plan:
1) Send a patron information request with an empty AD field
Note: You must send the AD field or you won't get back a CQ field
2) Note you get back a CQ of Y
3) Apply this patch
4) Repeat step 1
5) Note you now get back a CQ of N
Signed-off-by: Trent Roby <troby at bclib.info>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 71f0370ddde0d8b8e2a666a091081186fb6531e8)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 9f935b384fd01c863af1de195f4fe256450f4a46
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed Jun 1 15:34:56 2016 +0200
Bug 16610: [QA Follow-up] Add a test
To verify the original patch, this test shows that before applying
it the Patron Info request did not return CQ==N for an empty
password. Note that the Patron Status did btw.
After applying the original patch, the test passes for patron
info as well as status.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit cbdd9194eb3359d517fbda9a50a02fbc375bf5dd)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 5712275a4645d4d899815120fe79e730edf1034e
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Tue May 31 14:16:07 2016 +0200
Bug 16504: [QA Follow-up] Make koha-qa happy with two newlines
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 567a1a9021aaea3bf42b19f493b79f682ed9042b)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 247bd55876a4e930934419070fc926a656a0d9d7
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri May 13 14:43:52 2016 +0100
Bug 16504: (follow-up for bug 15163) Do not remove attributes of other patrons
Simple patch for a silly error, this single line is going to fix a
critical bug.
If a patron attribute is limited to a library, all the values for that attributes
for every patrons will be deleted.
Test plan:
Create a patron attribute limited to a library
Set the the attribute for a patron
Set the the attribute for another patron
=> Without this patch applied, the attribute's value for the first
patron is deleted
=> With this patch applied, the 2 values exist in the DB after the
second edition
Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit da94410ab5022c3bd97fba1878673149802db584)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 5949faae071c317c029c9c89320c52d73cd7a362
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri May 13 14:42:52 2016 +0100
Bug 16504: Add regression tests
Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 72bd06e3a88f62fcfe8710773091447ebafebcb3)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 385cf8e64100bfd18cabe1e2a5d7a37beeb4daad
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri May 20 15:40:24 2016 +0100
Bug 16437 - (follow-up) Automatic item modifications by age needs prettying
Do not move the scrollbar to the top when removing a 'block' to a new
rule.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit e0143f3205ebbf07aa479b89d8ba8aab426496b2)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 631e349ff2e751a43f9e0a426f94ab4b116ad8c7
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Mar 25 13:06:03 2016 -0400
Bug 16437 - Automatic item modifications by age needs prettying
This patch makes layout and behavior changes to the automatic item
modifications by age interface, bringing some aspects of it closer into
conformance with established interface patterns.
- The intial view is now a standard table of information about existing
rules, or a message dialog saying there are no rules.
- If there are no rules, a toolbar button reads "Add rules."
- If there are existing rules, the toolbar button reads "Edit rules."
- Clicking the button leads to the rules edit interface, which now has
a floating toolbar with "Add rule," "Save," and "Cancel" buttons.
- Clicking the "Add rule" button displays a blank rule block.
- If you are adding a rule to existing rules, the new block is
appended at the bottom, and the page scrolls to the new rule.
- As you add or remove rule blocks, the legend containing the rule
count updates so that the numbers are sequential.
- In each rule block, "age" and "substitutions" are now required.
The age field is now validated to require a number.
- The add/remove condition/substitution links now have more
descriptive text labels.
- The control to remove a rule is now a link in the <legend> element
associated with each rule.
- Most JavaScript for this page is now in a separate file.
- Breadcrumbs are updated to be a little more specific.
To test, apply the patch and clear your browser cache if necessary.
- Go to Tools -> Automatic item modifications by age.
- Test adding and removing rules.
- Test removing all rules.
- Test adding and removing conditions and substitutions within rules.
- Test submitting the form without filling in required fields.
Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 22b18ba988c72b6802421ae2e96237a716ae436e)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 10733c39399d4db48bd5a73a9c4a195531751875
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed May 4 09:34:46 2016 -0400
Bug 16450 - Remove the use of "onclick" from guarantor search template
This patch updates the guarantor search template so that event
definition is done in the script rather than in an onclick attribute.
This patch also increases the size of the popup window to help prevent
the need for horizontal scrolling and adds Bootstrap style to the
"select" button.
To test, apply the patch and clear your browser cache if necessary.
- Go to Patrons and add a patron with a "child" category type.
- In the "Guarantor information" section, click the "Set to patron"
button.
- In the pop-up window, search for a patron.
- Click the "Select" button next to a patron.
- The window should close, and the patron you selected should now appear
as the guarantor. The guarantor's address information should be added
to the "Main address" section.
Tested on top of Bug 13041 and Bug 16386, works as expected, however see
Bug 16458
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit fdf4101fb17d8f45487a9ba6ba248e8edf245cf6)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 92c08a6a4e177622a4513fa34c81dfcbec20ec57
Author: Aleisha <aleishaamohia at hotmail.com>
Date: Fri May 13 00:46:40 2016 +0000
Bug 16511: Making contracts actions buttons
To test:
1) Go to Acqui -> find a vendor
2) On Vendor details page (supplier.pl) confirm that Contracts table now
has one column called Actions
3) Confirm that Edit and Delete show as buttons
4) Confirm that buttons don't wrap on a narrower browser
5) Click Contracts tab
6) Confirm Actions column, Edit and Delete buttons, and button's don't
wrap
Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 23c8dc0e6384779c0eaf8441d598b60ac6aea46e)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit ddf80b2003522cc0542d4ee4f9b8e19fb7a8c4e0
Author: Aleisha <aleishaamohia at hotmail.com>
Date: Tue May 17 00:22:09 2016 +0000
Bug 16524: Use floating toolbar on item search
To test:
1) Go to item search
2) Confirm toolbar at top of page with Search button, goes down page as
you scroll
3) Confirm search button has been removed from final output fieldset
4) Confirm everything works as expected
Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 2afff4e8502d724f4f9e46bd406e1f00263b2b21)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 0c4661110c467c8d11631cc627395acef941c9c9
Author: Aleisha <aleishaamohia at hotmail.com>
Date: Mon May 16 01:10:43 2016 +0000
Bug 16525: Have cancel button when adding new aq budget
At the moment you only see the cancel button on the form if editing an
existing budget. This patch adds a cancel button to the form which adds
a budget. Also changes the wording of the save button from 'Save
changes' to just 'Save' so it makes more sense when adding a new budget
To test:
1) Go to Admin -> Budgets -> New budget
2) Notice 'Save changes' button and no cancel
3) Apply patch and refresh page
4) Notice 'Save' button and 'cancel' link
5) Click 'cancel' - should be taken to Budgets administration page
6) Edit an existing budget
7) Click 'cancel' - should be taken to the funds page for that budget
Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Sabine Liebmann <Liebmann at dipf.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Still an issue: If edit a budget fron aqbudgets.pl, then cancel, you get
aqbudgets.pl?budget_period_id=XX. But existed before this patch.
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit c4f17a6eb3e5688b1d1f3c4b578f17ae80e46f8f)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 300cfc1ac8ae979b737b584e303823059d34680e
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Mar 7 12:12:40 2016 -0500
Bug 16001 - Use standard message dialog when there are no cities to list
If there are no existing cities in Administration -> Cities and Towns,
the message saying so should be in the standard message dialog.
Another minor change: Edit the message to say "There are no cities
defined," which I think reads better in English.
To test you must have no cities and towns defined.
Apply this patch and go to Administration -> Cities and Towns. You
should see a message displayed in a standard "message" style dialog.
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Better view, no errors
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 89b41ede653227c5b4f777d6a4b30422ab473153)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 1f9e53f81c19dd56f7e77f40a05aa8433e2740d3
Author: Aleisha <aleishaamohia at hotmail.com>
Date: Tue May 17 05:04:08 2016 +0000
Bug 16532: Groups showing empty tables if no groups defined
EDIT: Same change for libraries
To test:
1) Go to Admin -> Libraries and Groups
2) Notice empty tables if nothing defined
3) Apply patch and refresh page
4) Empty tables should not show
5) Add a new group
6) Confirm table shows correctly
Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit ca36a74c868f25217e0db0900f043b4403aa9e01)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 7626ecedc8c640cedd21463d90117aecad1e6a80
Author: Brendan Gallagher <brendan at bywatersolutions.com>
Date: Tue May 31 08:56:42 2016 +0000
DBRev up for Bug 16200 - 'Hold waiting too long' fee has a translation
problem
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit bae0eb9ab702f3fe4351e7b3b23a332a998ed6b1)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit d80368370258432aab4d4171b886af26442d08c1
Author: Lari Taskula <larit at student.uef.fi>
Date: Tue May 17 14:44:45 2016 +0300
Bug 16200: Convert all existing expired holds accounttype to HE
Before Bug 16200 expired holds have used accounttype F which is also used by
other type of fines. This patch updates all existing expired holds to new
accounttype HE (Hold Expired).
To test:
-1. Make sure you translated the string in previous patch of this buug
1. Find a Patron with "Hold waiting too long" fines and go to his Fines tab
2. Change Koha's language to some other than English
3. Observe that "Hold waiting too long" is still in English
4. Apply patch and run database update
5. Go back to Patron's Fines tab
6. Observe that "Hold waiting too long" is now translated
Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 09de19c427c1e99d7e921210ed39cb6a19737317)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 326616d2bce77b245e0d38eb3df659e821130645
Author: Lari Taskula <larit at student.uef.fi>
Date: Tue May 17 14:33:57 2016 +0300
Bug 16200: Make 'Hold waiting too long' translatable and give it an unique accounttype
Holds that have expired have been untranslatable in Patron's Fines-tab. Also, they are
mixed with other type of fines with accounttype "F". This patch gives expired holds an
own accounttype "HE" (Hold Expired) and modifies the boraccount to recognize this new
accounttype in order to make it translatable.
To test:
1. Make a hold and let it expire
2. Go to Patron's Fines tab
3. Change Koha's language to some other than English
4. Observe that there is a "Hold waiting too long" fine described in English
5. Apply patch
6. Make another hold and let it expire
7. Update translations
8. Find "Hold waiting too long" from your .po file
9. Translate it and install translations
10. Go back to Fines tab and observe that the new expired hold is translated
Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 7163fcfeea382e1e042a47a76d384155e8c69bc0)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 06d775c3b3e9a376bbd9e09fc4cac65d35ce7363
Author: Liz <liz at catalyst.net.nz>
Date: Mon May 30 23:21:49 2016 +0000
Bug 16619 - installer stuck in infinite loop
To test: run the web installer on master, it should not get stuck in an infinite loop.
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 3311ab44cfffcd152e7de4652637eb95a265308e)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 8b9812fa83c110c446b58b6b1188d67d20011430
Author: Robin Sheat <robin at kallisti.net.nz>
Date: Wed May 25 16:19:09 2016 +0200
Bug 16617 - fix issues with debian/control
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Jesse Weaver <jweaver at bywatersolutions.com>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit e604538283ef3531aaa769dee70c83cdec942656)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit a85be57e1ce1d2adde6b9ee3dba55f7c5f2e06ab
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed May 18 19:45:27 2016 -0400
Bug 16548 - All libraries selected on Tools -> Export Data screen
This patch adds "select all" and "select none" links to the display of
libraries in the export bibliographic records form.
Also modified: call number range and accession date fields have been
grouped in their own fieldsets in the hopes that this is more readable.
Page title and breadcrumbs have been corrected to read "Export data"
instead of "MARC export," matching menu items.
To test, apply the patch and go to Tools -> Export data.
- Test the select all/select none links and confirm that they work as
expected.
- Confirm that the structural changes to the form look okay.
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Post sign-off revision: Use the standard "Clear all" instead of "Select
none."
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 06b9194cdd178f14347b8f9090657dbf5b712450)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit a47180eb3bc0ca26a018f68ffcc4d5635f6f7789
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon May 23 14:28:10 2016 +0000
Bug 16569 - Message box for "too many checked out" is empty if AllowTooManyOverride is not enabled
If the limit for number of items checked out is reached, the message box
shows up but is empty.
Test Plan:
1) Disable AllowTooManyOverride
2) Check out items to a patron until the patron has reached the limit
of checkouts he or she can have
3) Try to check out one more item
4) Note the empty message box
5) Apply this patch
6) Try to check out one more item again
7) Note the message is now visible
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit af43f91335b2258ea39b40247a1492ca41dafe2a)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
-----------------------------------------------------------------------
Summary of changes:
C4/Auth.pm | 15 +-
C4/Barcodes/hbyymmincr.pm | 27 +-
C4/Circulation.pm | 2 +-
C4/External/BakerTaylor.pm | 23 +-
C4/Installer/PerlDependencies.pm | 9 +-
C4/Items.pm | 3 +-
C4/Letters.pm | 11 -
C4/Members/Attributes.pm | 4 +-
C4/Members/Statistics.pm | 5 +-
C4/Reserves.pm | 2 +-
C4/Ris.pm | 40 ++-
C4/SIP/ILS/Patron.pm | 10 +-
C4/Tags.pm | 19 +-
Koha.pm | 2 +-
catalogue/export.pl | 3 +
circ/circulation.pl | 2 -
circ/returns.pl | 22 +-
debian/control | 22 +-
debian/control.in | 3 +-
docs/history.txt | 9 +-
installer/data/mysql/kohastructure.sql | 2 +
installer/data/mysql/updatedatabase.pl | 16 +-
koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 25 +-
.../prog/en/data/marc21_field_006.xml | 3 +
.../prog/en/data/marc21_field_008.xml | 3 +
.../intranet-tmpl/prog/en/data/marc21_field_CF.xsd | 3 +
.../prog/en/includes/acquisitions-toolbar.inc | 2 +-
.../prog/en/includes/auth-finder-search.inc | 2 +-
.../prog/en/includes/authorities-toolbar.inc | 2 +-
.../prog/en/includes/branch-selector.inc | 5 +-
.../prog/en/includes/cateditor-ui.inc | 2 +
.../en/includes/circ-patron-search-results.inc | 40 +++
.../prog/en/includes/quotes-toolbar.inc | 4 +-
.../prog/en/includes/reports-toolbar.inc | 14 +-
.../en/includes/rotating-collections-toolbar.inc | 4 +-
.../prog/en/includes/serials-toolbar.inc | 10 +-
.../intranet-tmpl/prog/en/includes/tools-menu.inc | 2 +
koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 9 +-
.../prog/en/modules/acqui/invoices.tt | 2 +-
.../intranet-tmpl/prog/en/modules/acqui/parcel.tt | 33 +-
.../prog/en/modules/acqui/supplier.tt | 13 +-
.../prog/en/modules/admin/aqbudgetperiods.tt | 10 +-
.../prog/en/modules/admin/aqcontract.tt | 8 +-
.../prog/en/modules/admin/branches.tt | 4 +-
.../intranet-tmpl/prog/en/modules/admin/cities.tt | 6 +-
.../prog/en/modules/admin/items_search_fields.tt | 2 +-
.../prog/en/modules/admin/preferences/patrons.pref | 2 +-
.../en/modules/admin/preferences/web_services.pref | 2 +-
.../prog/en/modules/admin/z3950servers.tt | 2 +-
koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt | 5 +-
.../prog/en/modules/catalogue/advsearch.tt | 2 +-
.../prog/en/modules/catalogue/detail.tt | 2 +-
.../prog/en/modules/catalogue/itemsearch.tt | 12 +-
.../prog/en/modules/cataloguing/editor.tt | 2 +-
.../prog/en/modules/circ/circulation.tt | 58 +---
.../prog/en/modules/common/patron_search.tt | 8 +
.../en/modules/course_reserves/course-details.tt | 2 +-
.../prog/en/modules/members/boraccount.tt | 1 +
.../prog/en/modules/members/discharge.tt | 2 +-
.../prog/en/modules/members/memberentrygen.tt | 8 +-
.../prog/en/modules/members/members-update.tt | 3 +-
.../prog/en/modules/members/moremember.tt | 4 +-
.../intranet-tmpl/prog/en/modules/members/pay.tt | 1 +
.../prog/en/modules/members/paycollect.tt | 2 +-
.../en/modules/members/tables/guarantor_search.tt | 2 +-
.../prog/en/modules/offline_circ/list.tt | 13 +-
.../prog/en/modules/patron_lists/list.tt | 2 +-
.../en/modules/reports/guided_reports_start.tt | 15 +-
.../prog/en/modules/reserve/request.tt | 48 +--
.../prog/en/modules/suggestion/suggestion.tt | 2 +-
.../intranet-tmpl/prog/en/modules/tags/review.tt | 30 +-
.../tools/automatic_item_modification_by_age.tt | 321 ++++++++------------
.../intranet-tmpl/prog/en/modules/tools/export.tt | 69 +++--
.../prog/en/modules/tools/overduerules.tt | 2 +-
.../prog/en/modules/tools/quotes-upload.tt | 2 +-
.../intranet-tmpl/prog/en/modules/tools/upload.tt | 105 ++++---
.../prog/en/modules/virtualshelves/shelves.tt | 2 +-
.../intranet-tmpl/prog/en/xslt/MARC21slim2MADS.xsl | 3 +
.../prog/en/xslt/NORMARCslim2intranetDetail.xsl | 3 +
.../prog/en/xslt/NORMARCslimUtils.xsl | 3 +
.../prog/en/xslt/UNIMARCslim2intranetResults.xsl | 3 +
.../prog/js/automatic_item_modification_by_age.js | 125 ++++++++
koha-tmpl/intranet-tmpl/prog/js/members.js | 2 +-
.../opac-tmpl/bootstrap/en/modules/opac-account.tt | 5 +-
.../opac-tmpl/bootstrap/en/modules/opac-auth.tt | 152 +++++----
.../bootstrap/en/modules/opac-discharge.tt | 4 +-
.../bootstrap/en/modules/opac-memberentry.tt | 4 +-
members/pay.pl | 1 +
members/paycollect.pl | 3 +-
opac/opac-addbybiblionumber.pl | 2 +-
opac/opac-export.pl | 13 +-
svc/config/systempreferences | 2 +-
t/00-load.t | 43 ++-
t/00-valid-xml.t | 2 +-
t/External/BakerTaylor.t | 33 ++
t/{External_Syndetics.t => External/Syndetics.t} | 0
t/Languages.t | 3 +
t/OpenLibrarySearch.t | 10 +-
t/Prices.t | 20 +-
t/Ris.t | 8 +-
t/db_dependent/Auth.t | 42 ++-
t/db_dependent/External_BakerTaylor.t | 34 ---
t/db_dependent/Hold.t | 6 +-
t/db_dependent/Letters.t | 4 +-
t/db_dependent/Members/Attributes.t | 34 ++-
t/db_dependent/Members/Statistics.t | 20 ++
t/db_dependent/SIP/Message.t | 26 +-
107 files changed, 1077 insertions(+), 723 deletions(-)
create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/circ-patron-search-results.inc
create mode 100644 koha-tmpl/intranet-tmpl/prog/js/automatic_item_modification_by_age.js
create mode 100755 t/External/BakerTaylor.t
rename t/{External_Syndetics.t => External/Syndetics.t} (100%)
delete mode 100755 t/db_dependent/External_BakerTaylor.t
create mode 100644 t/db_dependent/Members/Statistics.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list