[koha-commits] main Koha release repository branch master updated. v16.05.00-119-g8204024

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  8204024f1c21102c0649dec70d10398131aab953 (commit)
       via  6ad5770786c6646ce68ffdfec9080645fc25772e (commit)
       via  959d69fa0107423ed31e20f4a6afb46d1e5c771c (commit)
       via  4263ac2b92737024d8d620a751babf72b904b73a (commit)
      from  de6c1375f76b562970d7515192a002af8babc740 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8204024f1c21102c0649dec70d10398131aab953
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Mon May 23 09:03:23 2016 +0200

    Bug 16502: Replace a few other ok-calls by is-calls
    
    Trivial changes that speak for themselves..
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 6ad5770786c6646ce68ffdfec9080645fc25772e
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Mon May 23 08:58:02 2016 +0200

    Bug 16502: Adjust test for GetPlugins
    
    The current test assumes that GetPlugins will return the test plugin
    as the first one in the array. This is not correct.
    This patch adjusts the test to a grep.
    
    Test plan:
    Run the test.
    Bonus: Add additional plugins. Run the test again.
    
    Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 959d69fa0107423ed31e20f4a6afb46d1e5c771c
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Mon May 16 19:00:16 2016 +0200

    Bug 16502: Add additional test to Plugins.t
    
    In order to verify if the delete now really works, we add one test
    in Plugins.t.
    
    Test plan:
    [1] Run the test.
    [2] Bonus: Comment line 63 in Plugins.t where delete is called.
        Run the test again. It should fail now.
    
    Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 4263ac2b92737024d8d620a751babf72b904b73a
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Mon May 16 17:19:54 2016 +0200

    Bug 16502: Table koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped after running Plugin.t
    
    If you run Plugin.t, the above table will still be present (when you
    did not enable UseKohaPlugins). This would trigger a warning when
    running the test a second time.
    
    Why? The uninstall call does its work not completely due to a small
    inconsistency in Koha::Plugins::Handler::delete when calling run
    without the enable_plugins parameter.
    
    This patch resolves that inconsistency and also removes an unneeded skip
    in Plugin.t in case the KitchenSink module already exists.
    Note: This is a small fix. But I wonder if the Handler routines run and
    delete should not have been implemented in Koha::Plugins::Base.
    Also note that plugins/plugins-uninstall.pl will not be affacted by this
    change, since it checks whether the pref is enabled before calling the
    delete method.
    
    Test plan:
    [1] Do not yet install this patch.
    [2] Verify that plugins are enabled in koha-conf.xml.
    [3] Disable UseKohaPlugins in System Preferences!
    [4] Run t/db_dependent/Plugins.t.
    [5] Verify that table koha_plugin_com_bywatersolutions_kitchensink_mytable
        still exists. (It should have been deleted.) Remove it manually.
    [6] Apply this patch.
    [7] Run the test again.
    [8] Verify that the table does not exist.
    [9] Run the test again (without warnings).
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Plugins/Handler.pm  |    9 ++++++++-
 t/db_dependent/Plugins.t |   26 +++++++++++++++-----------
 2 files changed, 23 insertions(+), 12 deletions(-)


hooks/post-receive
-- 
main Koha release repository