[koha-commits] main Koha release repository branch 16.05.x updated. v16.05.00-130-g29e0eb0
Git repo owner
gitmaster at git.koha-community.org
Fri Jun 24 07:48:43 CEST 2016
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 16.05.x has been updated
via 29e0eb0f4b62fb0a31545c22c43a305cbe69d972 (commit)
via 546b95aee4fd4065090f4337a2e3e910f2767b39 (commit)
via 5fd657a8fcb8445bc510260c8e28813da3687098 (commit)
via 1dfbe758c22fa117814142c5eb0532274d7582fa (commit)
via ef948191c6a44d2ef896e40b7f71bdfcfc7d0cfc (commit)
via 8971ff67b671ef4dcbddcde1c8cd9a4dbd4a15d3 (commit)
via f941f67897994e31b22617cf0e38661fba403af1 (commit)
via 43b4a740dcc5a13e1726a15da14493b57366a0e8 (commit)
via 5a39b1b3a2d846e02ebf7d00ccfa8f1c35fcfb79 (commit)
via f9bb33c1cb4cb3d42a536c90a0ac2d3a2076be1f (commit)
via 8ebe3a0a42b8b63a3ef8b1486a30cd3b335d12b9 (commit)
via 5321959b458b39860192846cd466a05df893aa53 (commit)
via 739d44a6a21ace7e77959747d4c7d9c8848fed17 (commit)
via 358f2770178547abcb9216285fe670a7a1e102d4 (commit)
via 9cb9d3c30689170cd21aa22333a9ad3a28774400 (commit)
via c0d3e6db1191e2bb63da70cf1d3280f25efe7bfa (commit)
via dfb6ca49d85a3d66f0628b8c5cc3f9b8ba65c430 (commit)
via 302ac5e2a88d73601ee36fcc7460beca281b6fb7 (commit)
via 2b7a9479b601e224ff6cdbdcc3162426a4727406 (commit)
via 64382be0d45ad6d43bb86bda095ca1a3699d1265 (commit)
via 0632256c1aca919ec055dd5f170ac10d84cc8ec7 (commit)
via 4ebe7b489c9798d2456bd3de1d95ec6e027b2b21 (commit)
via 5185adc1bae9241f919c8ecd5fc98c4b0b6bd6a4 (commit)
via a50e5f141b14c1ba6f9c491a40db1270a8c7be99 (commit)
via 9710f07575ea7a56000058a687b1a9e835396b86 (commit)
via 69e4c39c213192b46c4e231d40b7a34d676e6b4a (commit)
via 67b4f25a69b370bb441ed09555ef49e0dd2a1e10 (commit)
via 2351db01d32726809e2a00b2c8020e497c2c3931 (commit)
via 695dc4c370d4d170b41447c583c8bfe91b0609e2 (commit)
from 4d2f605b37a5a4ac9087e7d26cffe22d75455d10 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 29e0eb0f4b62fb0a31545c22c43a305cbe69d972
Author: Marc Véron <veron at veron.ch>
Date: Thu Jun 16 09:27:55 2016 +0200
Bug 16747 - Patron card creator broken with version 16.05
To reproduce:
- Prepare a patron car layout with Image 1 using Patron Image
- Create a patron card for a patron without patron image
Result: OK, PDF can be opened wit PDF viewer
- Try to create a patron card with a patron who has a patron image
Result: The PDF file is corrupt (contains text only with error message)
intranet error log contains: create-pdf.pl: Illegal division
by zero at /usr/share/kohaclone/patroncards/create-pdf.pl line 200
To test:
- Apply patch
- Create a patron card with a patron who has a patron image
Result: PDF is OK and contains the image
Bonus test: Do the same with a card layout with an additional image
(Image 2: Image source: Other image)
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Test and bonus test pass: PDF generated without errors.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 87dbed0abd67e88ae85f633d9f4c63c38a2f7e24)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 546b95aee4fd4065090f4337a2e3e910f2767b39
Author: Marc Véron <veron at veron.ch>
Date: Tue Jun 14 07:07:05 2016 +0200
Bug 16729: Use member-display-address-style*-includes when printing user summary
This patch replaces the address part in moremember-print.tt to print identical
address information as displayed on the screen (including street numer, formatted as required by syspref 'AddressFormat'
To test:
- Apply patch
- Search for a user with all address information filled
- Verify that 'Print summmary' displays the same information
as displayed on the screen.
- Change value of syspref 'AdressFormat'
- Verify that address format on 'Print summary' changes
as appropriate
Signed-off-by: mehdi <mehdi at inlibro.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 555f40626ab34eccadec66091e54e203a9be4440)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 5fd657a8fcb8445bc510260c8e28813da3687098
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Wed Jun 8 13:47:58 2016 +0200
Bug 16693: Remove reserve/renewscript.pl
It is not used since bug 11703
Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit c92d0823f8b79c1bb8f01b4a429961e5f3e5574c)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 1dfbe758c22fa117814142c5eb0532274d7582fa
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed May 25 10:49:26 2016 -0400
Bug 16543 - Make edit and delete links styled buttons in patron attribute types administration
This patch modifies the Patron attribute types page, converting edit and
delete links to Bootstrap buttons with Font Awesome icons.
To test, apply the patch and go to Administration -> Patron attribute
types. The 'Edit' and 'Delete' buttons should look correct and work
correctly.
Signed-off-by: Jan Kissig <jkissig at th-wildau.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit ae4be45444dd8e6a65dc7170cfc43c60de328f38)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit ef948191c6a44d2ef896e40b7f71bdfcfc7d0cfc
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed May 25 10:56:13 2016 -0400
Bug 16541 - Make edit and delete links styled buttons in cities administration
This patch modifies the cities administration page, converting edit and
delete links to Bootstrap buttons with Font Awesome icons.
To test, apply the patch and go to Administration -> Cities and towns.
The 'Edit' and 'Delete' buttons should look correct and work correctly.
Signed-off-by: rainer <archiv at a-bibliothek.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 51a11d279457f97ac1b30e99d1af38a344d01725)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 8971ff67b671ef4dcbddcde1c8cd9a4dbd4a15d3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jun 14 11:09:42 2016 +0100
Bug 16456: Reintroduce wording "Delete tag"
"Delete tag" seems more appropriate than "Delete" on this tag, but I may
be wrong.
This patch also removes an extra space.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 45fbcb9fda8776dc78556efd99076ce8fc8b4f97)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit f941f67897994e31b22617cf0e38661fba403af1
Author: Hector Castro <hector.hecaxmmx at gmail.com>
Date: Fri May 13 23:40:25 2016 -0600
Bug 16456: Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation
Add Font Awesome Icons to section Patrons and circulation in Tools module.
Also correct a error dialog in JQuery functions
To test:
-Apply patch
-Goto Tools -> Patron list -> my_list_saved -> Add patrons -> Remove selected patrons,
Clear all, Select all.
-Add new patron list and add some patrons, notice about the trash icon.
-Make some comments in some bib records and goto Tools->Comments
you will presented with two tabs "Approved comments" and
"Comments awaiting moderation".
See the three new buttons: Approve, Delete, Unapprove.
-Set syspref TagsModeration to Require. This will show all pending tags to review.
-Make some tags in bib records and goto Tools -> Tags.
-Notice about the new look.
-In the new screen look the icons in buttons "Apply filter(s)", "Test", "Approved",
"Reject". Notice about the new header bar above the DataTable with options: Select all,
Clear all, Select all pending.
-Play with filters; Check if terms exist or not in appoved/rejected lists
-Play with Terms summary and see if DataTable is working as expected
-Click in some term tag with multiple titles
-A table with titles tagged with the term is presented
-See the new button 'Remove'
-Verify if you can remove tag from a selected title.
-Verify that all tools work as expected
NOTE: The Tag and Comments tools has been revised to fit with others
interfaces in Koha.
Bug ammended according with QA comment 5
Bug rebased because bug 16005
Test plan amended for clarity
Clock icon for "Select all pending" removed (QA comment 23).
Fix some forbidden patterns (tab char) in review.tt according by IRC comment
by Marc Veron
Followed test plan, looks and works as expected
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 2a6a3de7c407724d2778be8bf422b1222910e4a7)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 43b4a740dcc5a13e1726a15da14493b57366a0e8
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue May 31 10:08:03 2016 -0400
Bug 16127 - Add discharge menu item to patron toolbar
This patch changes the "Discharge" menu in the patron sidebar to read
"Discharges," and adds a "Discharge" menu item to the patron toolbar.
This adds some redunancy, but fits with the pattern of including "views"
in the sidebar and "actions" in the menu. The discharge feature can be
thought of either way.
To test you must have the 'useDischarge' system preference enabled.
- View the detail page for any patron.
- Confirm that the sidebar menu reads "Discharges."
- Confirm that the "More" menu contains a "Discharge" link which works
correctly.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 981302a47322857b080107a71c47db2345ef5286)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 5a39b1b3a2d846e02ebf7d00ccfa8f1c35fcfb79
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Sat Jun 11 14:32:05 2016 +0100
Bug 16594: Fix obvious QA issues from bug 11371
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 64efee0b5cc975b3b80db1841321355eeb39fb48)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit f9bb33c1cb4cb3d42a536c90a0ac2d3a2076be1f
Author: Hector Castro <hector.hecaxmmx at gmail.com>
Date: Thu May 26 08:41:08 2016 -0600
Bug 16594: Orders by fund report has wrong link to css and other issues
Orders by fund has wrong link to css and other issues
-> The example in the wiki is wrong: <https://wiki.koha-community.org/wiki/DataTables_HowTo>
<link rel="stylesheet" type="text/css" href="[% themelang %]/css/datatables.css" />
[% INCLUDE 'datatables.inc' %]
-> Must be:
<link rel="stylesheet" type="text/css" href="[% interface %]/[% theme %]/css/datatables.css" />
-> Missing <th></th> in <tfoot> tag
-> Wrong word used "Date deceived" should be "Date received"
NOTE: Wiki needs to be updated
To test:
-Look the code and notice about if else cluase without curly brackets
-Go to Reports > Orders by fund
-Play with: in filters 'All fund' Output: 'to screen into the browser'
-You will see a DataTable displayed in screen clutter
-Notice about 'Date deceived' and the foot of table
-Apply patch
-Refresh or execute again the report
Signed-off-by: Sinziana <s.paltineanu at berlin.bard.edu>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit d4394d88eaeff5df6bf0a28ec3e6faed853b202b)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 8ebe3a0a42b8b63a3ef8b1486a30cd3b335d12b9
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jun 14 11:18:32 2016 +0100
Bug 16717: Improve variable naming
$category was a categorycode, to help the readability it's better to
name it $categorycode or assign a Category to $category
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit f8b73deaec5c7f55d66d52c2ca05d419f4a7c178)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 5321959b458b39860192846cd466a05df893aa53
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri May 27 13:48:10 2016 +0200
Bug 16717: Remove hardcoded category from Holds.t
There is actually no need to use the hardcoded patron category S in
this test.
Test plan:
Run t/db_dependent/Holds.t.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Test passes OK
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit a4690353d9a20a7c991787a1ffe3040eb3834a5a)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 739d44a6a21ace7e77959747d4c7d9c8848fed17
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri May 27 08:35:57 2016 +0200
Bug 16607: Remove CPL/MPL from two unit tests
Test t/db_dependent/Accounts.t:
This test created a MPL branch, but did not use it any more.
Test t/db_dependent/Items/AutomaticItemModificationByAge.t:
This test still used CPL/MPL branches. Now it uses two new branches.
Test plan:
[1] Run t/db_dependent/Accounts.t.
[2] Run t/db_dependent/Items/AutomaticItemModificationByAge.t.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Both tests pass OK
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 2d9c270886b547c1c4973cef3c20f18e6998530a)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 358f2770178547abcb9216285fe670a7a1e102d4
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Thu May 26 21:56:50 2016 +0200
Bug 16500: [QA Follow-up] Catch warning if branch MPL already exists
The current test had no warnings, when you have no MPL branch, and only
catches the warn from the second build on line 57. If you do have MPL,
a warning comes from line 56.
This patch fixes it by removing MPL from the test. A new branch is created
first and then we try to create it again.
Test plan:
Run the test.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 63fbb336bd90991a8b86ca6fe54d5a069c129373)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 9cb9d3c30689170cd21aa22333a9ad3a28774400
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed May 11 14:49:07 2016 +0200
Bug 16500: Catch two warns in TestBuilder.t with warning_like
When testing a wrong case in TestBuilder.t, two warns show up.
We can catch them with warning_like.
Test plan:
Run t/db_dependent/TestBuilder.t
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 395ac8835a582a2bb38aaa3259c4196b81142dd4)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit c0d3e6db1191e2bb63da70cf1d3280f25efe7bfa
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Jun 13 13:04:25 2016 -0300
Bug 16720: Remove DBIx ActionLogs.pm
The update_dbix_class_files.pl script generates ActionLog.pm instead, which is
already on the source tree.
To test:
- Apply the patch
=> SUCCESS: Koha/Schema/Result/ActionLogs.pm is removed
- Run:
$ mysql -uroot
> CREATE DATABASE dbic; \q
$ mysql -uroot dbic < kohaclone/installer/data/mysql/kohastructure.sql
$ misc/devel/update_dbix_class_files.pl --db_name dbic --db_user root
=> SUCCESS: Koha/Schema/Result/ActionLogs.pm is not re-generated
- Run:
$ git grep ActionLogs
=> SUCCESS: There's no code using it
- Sign off
Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit b8c950a4c1b1ead8a58686b27c95f9891cdccbae)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit dfb6ca49d85a3d66f0628b8c5cc3f9b8ba65c430
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed Jun 8 10:24:56 2016 +0000
Bug 16692 - Error "No method update!" when creating new serial issue
An improper method call was left over in C4::Serials::NewIssue from the
switch from DBIx::Class to Koha::Object.
Test Plan:
1) prove t/db_dependent/Serials.t
2) Note the errors
3) Apply this patch
4) prove t/db_dependent/Serials.t
5) No errors!
Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 557a5989093982f41173df8267658cb1d90e76cd)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 302ac5e2a88d73601ee36fcc7460beca281b6fb7
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Jun 6 13:31:29 2016 +0100
Bug 16670: (bug 15823 follow-up) CGI->param should not be called in list context
Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 58207446755cb2533fac48252c3b70154b164feb)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 2b7a9479b601e224ff6cdbdcc3162426a4727406
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Mon May 23 09:03:23 2016 +0200
Bug 16502: Replace a few other ok-calls by is-calls
Trivial changes that speak for themselves..
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 8204024f1c21102c0649dec70d10398131aab953)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 64382be0d45ad6d43bb86bda095ca1a3699d1265
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Mon May 23 08:58:02 2016 +0200
Bug 16502: Adjust test for GetPlugins
The current test assumes that GetPlugins will return the test plugin
as the first one in the array. This is not correct.
This patch adjusts the test to a grep.
Test plan:
Run the test.
Bonus: Add additional plugins. Run the test again.
Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 6ad5770786c6646ce68ffdfec9080645fc25772e)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 0632256c1aca919ec055dd5f170ac10d84cc8ec7
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Mon May 16 19:00:16 2016 +0200
Bug 16502: Add additional test to Plugins.t
In order to verify if the delete now really works, we add one test
in Plugins.t.
Test plan:
[1] Run the test.
[2] Bonus: Comment line 63 in Plugins.t where delete is called.
Run the test again. It should fail now.
Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 959d69fa0107423ed31e20f4a6afb46d1e5c771c)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 4ebe7b489c9798d2456bd3de1d95ec6e027b2b21
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Mon May 16 17:19:54 2016 +0200
Bug 16502: Table koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped after running Plugin.t
If you run Plugin.t, the above table will still be present (when you
did not enable UseKohaPlugins). This would trigger a warning when
running the test a second time.
Why? The uninstall call does its work not completely due to a small
inconsistency in Koha::Plugins::Handler::delete when calling run
without the enable_plugins parameter.
This patch resolves that inconsistency and also removes an unneeded skip
in Plugin.t in case the KitchenSink module already exists.
Note: This is a small fix. But I wonder if the Handler routines run and
delete should not have been implemented in Koha::Plugins::Base.
Also note that plugins/plugins-uninstall.pl will not be affacted by this
change, since it checks whether the pref is enabled before calling the
delete method.
Test plan:
[1] Do not yet install this patch.
[2] Verify that plugins are enabled in koha-conf.xml.
[3] Disable UseKohaPlugins in System Preferences!
[4] Run t/db_dependent/Plugins.t.
[5] Verify that table koha_plugin_com_bywatersolutions_kitchensink_mytable
still exists. (It should have been deleted.) Remove it manually.
[6] Apply this patch.
[7] Run the test again.
[8] Verify that the table does not exist.
[9] Run the test again (without warnings).
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 4263ac2b92737024d8d620a751babf72b904b73a)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 5185adc1bae9241f919c8ecd5fc98c4b0b6bd6a4
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon May 9 11:13:38 2016 -0300
Bug 13074: (followup) remove useless diag
On running all Items-related tests some useless diag showed up. Removing it.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit de6c1375f76b562970d7515192a002af8babc740)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit a50e5f141b14c1ba6f9c491a40db1270a8c7be99
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue May 3 11:08:47 2016 +0100
Bug 13074: Use Koha::Cache to cache the defaults values of a MARC record
With the global %default_values_for_mod_from_marc variable, the changes
made to the marc_subfield_structure table and especially the links
between MARC and DB fields are not safe and might be outdated (if a
field is linked/unlinked)
Test plan:
Under Plack:
- Link the barcode field, edit a record and set a barcode.
- Remove the mapping for the barcode field and then update again the
barcode of the record.
The items.barcode DB field must not have been updated.
Without this patch, the field should have been updated.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 8c14c25521eac92a2cb62ab5330deac2e2d5343d)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 9710f07575ea7a56000058a687b1a9e835396b86
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jun 14 10:49:41 2016 +0100
Bug 12748: findSerialByStatus has been renamed with findSerialsByStatus
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 30946eff3cda31d0cc97c6c1c4f1e757dbc4c366)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 69e4c39c213192b46c4e231d40b7a34d676e6b4a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jun 14 10:43:14 2016 +0100
Bug 12748: Code tidy
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 44062c07b7703190b46701a3fa31665d998eadfb)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 67b4f25a69b370bb441ed09555ef49e0dd2a1e10
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jun 14 10:39:08 2016 +0100
Bug 12748: Remove warning 'masks earlier declaration in same scope'
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 273d5e53289536797281ca5eb323d5c373d9ea41)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 2351db01d32726809e2a00b2c8020e497c2c3931
Author: remi <remi.mayrand-provencher at inLibro.com>
Date: Mon Feb 8 15:04:07 2016 -0500
Bug 12748 - Add test for step 7 and 8 and rename findSerialByStatus
https://bugs.koha-community.org/show_bug.cgi?id=12478
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 1bd5a177d0870332a959e9c773aaec80beeba74b)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 695dc4c370d4d170b41447c583c8bfe91b0609e2
Author: remi <remi.mayrand-provencher at inLibro.com>
Date: Tue Aug 11 11:10:45 2015 -0400
Bug 12748 - Fixes duplicate serials with an "expected" status bug
Added a new sub to Serials.pm to be able to get serials with their statuses.
Now the sub ModSerialStatus checks for other serials with an "expected" status before doing anything.
Also modified Serials.t to be able to test those changes.
Test Plan
1) Apply patch
2) Run ./t/db_dependent/Serials.t
3) Validate that there are no errors
4) Go on "Serial collection information" page for a serial of your choice
5) Click on "Generate next"
6) Change the status of the original serial from "late" to "expected"
7) Change the newly generated serial from "expected" to "delete"
8) Validate that there are no new serials created by instruction 7 and that the serial was deleted
9) Run ./t/db_dependent/Serials.t
With QA Fixes
- Use the constant instead of the code (1 vs EXPECTED)
- Avoid interpolation in query
- use selectall_arrayref instead of fetchall_arrayref
Signed-off-by: Liz Rea <liz at catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 10fd9f5ec0d5faa7b54b0bfaf5a7b8fccd665f0a)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
-----------------------------------------------------------------------
Summary of changes:
C4/Items.pm | 17 ++-
C4/Serials.pm | 26 +++-
Koha/Plugins/Handler.pm | 9 +-
Koha/Schema/Result/ActionLogs.pm | 90 -------------
admin/biblio_framework.pl | 2 +
admin/marc_subfields_structure.pl | 2 +
admin/marctagstructure.pl | 3 +
circ/circulation.pl | 2 +-
koha-tmpl/intranet-tmpl/js/autocomplete/patrons.js | 2 +-
.../intranet-tmpl/prog/en/includes/circ-menu.inc | 2 +-
.../prog/en/includes/members-toolbar.inc | 3 +
.../intranet-tmpl/prog/en/modules/admin/cities.tt | 9 +-
.../prog/en/modules/admin/patron-attr-types.tt | 6 +-
.../prog/en/modules/members/moremember-print.tt | 7 +-
.../prog/en/modules/patron_lists/list.tt | 6 +-
.../prog/en/modules/reports/orders_by_budget.tt | 11 +-
.../prog/en/modules/reviews/reviewswaiting.tt | 4 +-
.../intranet-tmpl/prog/en/modules/tags/list.tt | 2 +-
.../intranet-tmpl/prog/en/modules/tags/review.tt | 104 ++++++++------
patroncards/create-pdf.pl | 7 +-
reports/orders_by_fund.pl | 12 +-
reserve/renewscript.pl | 142 --------------------
t/db_dependent/Accounts.t | 4 +-
t/db_dependent/Holds.t | 8 +-
t/db_dependent/Items.t | 116 +++++++++++++++-
.../Items/AutomaticItemModificationByAge.t | 16 +--
t/db_dependent/Items/GetItemsForInventory.t | 2 -
t/db_dependent/Plugins.t | 26 ++--
t/db_dependent/Serials.t | 30 ++++-
t/db_dependent/TestBuilder.t | 12 +-
30 files changed, 331 insertions(+), 351 deletions(-)
delete mode 100644 Koha/Schema/Result/ActionLogs.pm
delete mode 100755 reserve/renewscript.pl
mode change 100644 => 100755 t/db_dependent/Serials.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list