[koha-commits] main Koha release repository branch master updated. v16.05.00-194-g24729ff
Git repo owner
gitmaster at git.koha-community.org
Fri Jun 24 15:41:18 CEST 2016
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 24729ff8f99e3e96cb5fd1b3cd9af0616cc38e55 (commit)
from 7a3b5ee04b801a5d7bfaf190c6cbc5bb53359fff (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 24729ff8f99e3e96cb5fd1b3cd9af0616cc38e55
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon May 9 11:15:28 2016 -0400
Bug 16477 - Improve staff client cart JavaScript and template
This patch makes several changes to the cart JavaScript and template. In
the template:
- Remove "onclick" attributes in favor of defining events in the
JavaScript.
- Add a [% BLOCK %] section for some repeated markup.
- Add some Font Awesome icons (I didn't add icons to all controls
because I thought it looked cluttered).
- Move the batch modification control out of the toolbar and into the
group of controls which affects selected records. I think this is a
logical grouping, and makes more sense than having a drop-down menu in
the toolbar with a single menu item.
JavaScript:
- Created separate "cart.js" file so that JS could be moved out of the
template without loading up basket.js with event functions which are
not needed on every page in the staff client.
- Fix JSHint errors.
To test, apply the patch and clear your browser cache if necessary.
- Add multiple items to the cart in the staff client and open the cart.
- Confirm correct functionality of these toolbar buttons:
- "More details" (and the corresponding "Show less")
- "Send"
- "Print"
- "Empty and close"
- Confirm the correct functionality of all the selection controls:
Select all, clear all, Remove, Add to a list, Place hold, Batch
modify, and Batch delete.
- Confirm that clicking any title in the cart opens the correct detail
page in the parent window.
Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
https://bugs.koha-community.org/show_bug.cgi?id=1647
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
.../intranet-tmpl/prog/en/modules/basket/basket.tt | 183 +++++---------------
koha-tmpl/intranet-tmpl/prog/js/basket.js | 5 +-
koha-tmpl/intranet-tmpl/prog/js/cart.js | 156 +++++++++++++++++
3 files changed, 198 insertions(+), 146 deletions(-)
create mode 100644 koha-tmpl/intranet-tmpl/prog/js/cart.js
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list