, matching other fields in the entry form which offer details about entry guidelines. To test, apply the patch and open the new patron entry form. Test for various values of CardnumberLength, and with 'cardnumber' mandatory or not mandatory as defined in BorrowerMandatoryField. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com (cherry picked from commit 9f172a3c1bc8c7cd1664eabac81c5b66877b3952) Signed-off-by: Julian Maurice (cherry picked from commit 276b59e5bcce0f68dfbce32f2c94e8d5178500a7) Signed-off-by: Fr?d?ric Demians commit bfd565089ec4845b1390b760a30b922a6445116b Author: Jonathan Druart Date: Mon Feb 29 07:32:14 2016 +0000 Bug 15674: Make "Column visibility" translatable The "Column visibility" text button was not translatable, now it is. Test plan: 1/ Update the template for a given language and translate the "Column visibility" string 2/ Go on admin/currency.pl => The string should be translated. Signed-off-by: Julian Maurice (cherry picked from commit 2c186dd5a00cf8cb18fb596957a5ddfa9559bc42) Signed-off-by: Fr?d?ric Demians commit d2111ff7cf6107639ba332fae18b32609b6c1d53 Author: Jonathan Druart Date: Wed Jan 27 10:33:24 2016 +0000 Bug 15605: Remove the cursor:pointer style. Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com (cherry picked from commit effe1e27819a3b7d156e4abf5c96dd34d529246f) Signed-off-by: Julian Maurice (cherry picked from commit 8d58579d6b5a4a287c3283284a2c4b8618ec763b) Signed-off-by: Fr?d?ric Demians commit cef47596049765dd595517dc7d637b0bbe87cef6 Author: Natasha Date: Wed Jan 20 02:11:37 2016 +0000 Bug 15605 - Accessibility: Can't tab to add link in serials routing list add user popup To Test - 1. Go to Serials and search for a title and then click on it. 2. Click routing list and then Add recipients. 3. Search for a patron. 4. Using the tab key try to navigate onto the Add link. 5. Notice it skips Add. 6. Apply the patch and then repeat steps 1-4, notice the Add link can now be accessed through using the keyboard. Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com (cherry picked from commit c76549dd7b4a090844a5a51664409417f9838923) Signed-off-by: Julian Maurice (cherry picked from commit da966cef92701e9d2469be784cc773d815769ffe) Signed-off-by: Fr?d?ric Demians commit ce80123c2fdf0470420f70d936ac2377ccd75140 Author: Jonathan Druart Date: Mon Jan 25 10:31:34 2016 +0000 Bug 14244: Does not display patron's info in the checkout history if not authorised The librarian needs CAN_user_circulate_circulate_remaining_permissions to see the checkouts patron's information. Test plan: The "Patron" column of the checkout history page should only be displayed of you have the circulate > circulate_remaining_permissions permission. Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com (cherry picked from commit 818b1871519f0348cc54a60c76e2c8192f36bb3c) Signed-off-by: Julian Maurice (cherry picked from commit fd65d2264e830c1a41e2cbfbe94049ca7d1eddda) Signed-off-by: Fr?d?ric Demians commit fd51df2ccfc3a52676dd1a1922cbd05fc546a61e Author: Thomas Misilo Date: Wed Sep 16 13:43:28 2015 -0400 Bug 14244: viewing a bib item's circ history requires circulation permissions On issuehistory.pl you have: flagsrequired => { circulate => "circulate_remaining_permissions" }, But that really doesn't make sense. People should be able to view the history of circulation without having permission to circulate items themselves This patch changes the required permissions from circulate to catalogue. Test Plan: 1. Login as user without the circulate_remaining_permissions 2. Attempt to view Circulation History of an Item 3. Does not work 4. Apply Patch 5. Attempt to view circulation history with a user that has access to the staff side. 6. Can view circulation history now Signed-off-by: Nicole Engard Signed-off-by: Jonathan Druart Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com (cherry picked from commit e8c5fb11fbebc86742325aea745bc7253d9110d8) Signed-off-by: Julian Maurice (cherry picked from commit a835060b9c10272fccf5262f5c77cc9d0031de7f) Signed-off-by: Fr?d?ric Demians commit f0198977186b722e43f9489d6a44856b9603f1ed Author: Fr?d?ric Demians Date: Tue Mar 15 07:53:59 2016 +0100 Bug 15736 DB rev 3.20.09.001 commit 56f83da3939dcaaf0ee8a5a672045ac4e9cde714 Author: Kyle M Hall Date: Sun Feb 14 14:12:50 2016 +0000 Bug 15736 [QA Followup] - Make add more details to the syspref description Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com (cherry picked from commit f92ef6207bc7346825f097f61e696b4b3685a737) Signed-off-by: Julian Maurice (cherry picked from commit 59d2298865fee7abb91b24833b4bff2f627bbcd6) Signed-off-by: Fr?d?ric Demians commit 7827be93a74c9f828e99001cffb6964683f45913 Author: Jonathan Druart Date: Fri Feb 12 09:07:09 2016 +0000 Bug 15736: Add ShowAllCheckins pref to control the display of checked-in item list on checking Bug 14821 removed the items which were not checked out, but some libraries considered it as a bug. So let's add a new pref to control this behavior. Test plan: 0/ Execute the updatedb entry and set ShowAllCheckins to "Do not show" (default) 1/ Check an item in. If the item was not checked out, it won't be listed 2/ Turn the pref to "Show" 3/ Check an item in If the item was not checked out, it should be listed Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com (cherry picked from commit ce6c3bb88b426b0d0b945b9e71c695017dcb0fed) Signed-off-by: Julian Maurice (cherry picked from commit 21ebaf949e0d3822e313ff76a32c23a97be0a78e) Signed-off-by: Fr?d?ric Demians ----------------------------------------------------------------------- Summary of changes: C4/Biblio.pm | 2 +- C4/Context.pm | 3 +- C4/Languages.pm | 6 ++- C4/Templates.pm | 4 +- Koha.pm | 2 +- about.pl | 21 ++++------ catalogue/issuehistory.pl | 2 +- circ/returns.pl | 5 +++ installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 9 +++++ .../prog/en/includes/columns_settings.inc | 5 ++- .../prog/en/modules/admin/aqcontract.tt | 20 +++++----- .../en/modules/admin/auth_subfields_structure.tt | 13 ------ .../prog/en/modules/admin/biblio_framework.tt | 21 +++++++--- .../prog/en/modules/admin/branches.tt | 15 +++++-- .../prog/en/modules/admin/clone-rules.tt | 13 +++--- .../en/modules/admin/marc_subfields_structure.tt | 42 +++++++++++--------- .../prog/en/modules/admin/oai_sets.tt | 12 +++++- .../prog/en/modules/admin/preferences.tt | 2 +- .../en/modules/admin/preferences/circulation.pref | 6 +++ .../prog/en/modules/catalogue/issuehistory.tt | 6 ++- .../prog/en/modules/circ/circulation.tt | 6 +-- .../intranet-tmpl/prog/en/modules/circ/renew.tt | 4 +- .../en/modules/help/admin/items_search_fields.tt | 25 ++++++++++++ .../prog/en/modules/members/memberentrygen.tt | 17 +++++--- .../en/modules/serials/subscription-frequencies.tt | 25 +++++++----- .../modules/serials/subscription-numberpatterns.tt | 36 ++++++++++++----- .../en/modules/serials/tables/members_results.tt | 2 +- .../prog/en/modules/tools/quotes-upload.tt | 1 + .../intranet-tmpl/prog/en/modules/tools/viewlog.tt | 7 +++- .../bootstrap/en/modules/opac-course-reserves.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 4 +- t/Languages.t | 10 ++++- 33 files changed, 230 insertions(+), 119 deletions(-) create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/items_search_fields.tt hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 17 08:46:53 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 17 Mar 2016 07:46:53 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.04-79-gf9b2589 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via f9b25894dd9095f130f8139ae63a5d955759ea5a (commit) from d409b437528748c41e108998231312d74e28d826 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f9b25894dd9095f130f8139ae63a5d955759ea5a Author: Jonathan Druart Date: Fri Mar 11 12:47:26 2016 +0000 Bug 16054: Fix variable scope error in paycollect.pl $borrower, $borrowernumber and $template and not visible in the subroutine. Using $b_ref and passing $template fixes the issue. Test plan: Under plack, use the pay selected button. On the paycollect page, you should see the image of the patron It certainly fixes some other bugs. Signed-off-by: Srdjan Signed-off-by: Tomas Cohen Arazi Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com (cherry picked from commit da21ad065939d0789bb90d8fd6d088b781688aa3) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: members/paycollect.pl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 18 08:00:32 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 18 Mar 2016 07:00:32 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-885-g9ecb394 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 9ecb394a8036f916bfc57ad696345cefcc6b9131 (commit) via ddfd58a13ce8b56746e01f078175129aceea7f00 (commit) from da21ad065939d0789bb90d8fd6d088b781688aa3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9ecb394a8036f916bfc57ad696345cefcc6b9131 Author: Owen Leonard Date: Fri Mar 11 08:28:18 2016 -0500 Bug 16036 [Follow-up] Making basket actions buttons This trivial follow-up adds an "actions" class to the table cell containing the new buttons. In conjunction with the style update in Bug 16048, this will prevent the buttons from wrapping at narrow browser window widths. To test, apply the patch for Bug 16048 and search for a vendor in Acquisitions which has at least one open basket. Confirm that the "View" and "Add to basket" buttons look correct and do not wrap when you make your browser window narrower. Signed-off-by: Aleisha Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit ddfd58a13ce8b56746e01f078175129aceea7f00 Author: Aleisha Date: Thu Mar 10 03:35:08 2016 +0000 Bug 16036: Making basket actions buttons To test: 1) Go to Acqui -> do a vendor search 2) Confirm actions 'View' and 'Add to basket' are now buttons and behave as expected Sponsored-by: Catalyst IT Signed-off-by: Fr?d?ric Demians Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 18 08:01:45 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 18 Mar 2016 07:01:45 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-887-gc21a291 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via c21a2917476b874e2640593dd12cfc4d3e925598 (commit) via 37ee31318063272e258c3762634fe8a676e18622 (commit) from 9ecb394a8036f916bfc57ad696345cefcc6b9131 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c21a2917476b874e2640593dd12cfc4d3e925598 Author: Owen Leonard Date: Fri Mar 11 11:47:01 2016 -0500 Bug 15995 [Follow-up] Making libraries actions buttons This trivial follow-up adds an "actions" class to the table cell containing the new buttons. In conjunction with the style update in Bug 16048, this will prevent the buttons from wrapping at narrow browser window widths. To test, apply the patch for Bug 16048 and go to Administration -> Libraries and Groups. Confirm that the "Edit" and "Delete" buttons do not wrap even at narrow browser window widths. Signed-off-by: Aleisha You forgot to add the class to one of the tables, but I have added it Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit 37ee31318063272e258c3762634fe8a676e18622 Author: Aleisha Date: Thu Mar 10 01:59:20 2016 +0000 Bug 15995: Making libraries actions buttons To test: 1) Go to Administration -> Libraries and Groups 2) Confirm that the actions 'Edit' and 'Delete' are now buttons for BOTH tables under one column 'Actions' and buttons behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/admin/branches.tt | 24 ++++++++------------ 1 file changed, 9 insertions(+), 15 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 18 08:02:44 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 18 Mar 2016 07:02:44 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-889-g9752d14 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 9752d147964e1e59b60ceb2f00fa2de25d2c3f59 (commit) via 2e7d614997f1f3d16d43dd5b3aba592dd7de8ca8 (commit) from c21a2917476b874e2640593dd12cfc4d3e925598 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9752d147964e1e59b60ceb2f00fa2de25d2c3f59 Author: Owen Leonard Date: Fri Mar 11 11:13:08 2016 -0500 Bug 15993 [Follow-up] Making currency actions buttons This trivial follow-up adds an "actions" class to the table cell containing the new buttons. In conjunction with the style update in Bug 16048, this will prevent the buttons from wrapping at narrow browser window widths. To test, apply the patch for Bug 16048 and go to Administration -> Currencies and exchange rates. In the table of currencies, confirm that the "Edit" and "Delete" buttons are not stacked one on top of the other even at narrow browser window widths. Signed-off-by: Aleisha Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit 2e7d614997f1f3d16d43dd5b3aba592dd7de8ca8 Author: Aleisha Date: Thu Mar 10 01:53:30 2016 +0000 Bug 15993: Making currency actions buttons To test: 1) Go to Administration -> Currencies and exchange rates 2) Confirm that the actions 'Edit' and 'Delete' are now buttons and behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 18 08:03:41 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 18 Mar 2016 07:03:41 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-891-ga5519b3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a5519b36a8b232066bdde3a94733619eaf56eb62 (commit) via 6638d3f73f3395f936868fcdab2b82b0c7f15860 (commit) from 9752d147964e1e59b60ceb2f00fa2de25d2c3f59 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a5519b36a8b232066bdde3a94733619eaf56eb62 Author: Jonathan Druart Date: Mon Mar 14 16:49:50 2016 +0000 Bug 15990: (follow-up) Making record matching rules actions buttons Adds the actions class to the td elt to keep the buttons next to each other. Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit 6638d3f73f3395f936868fcdab2b82b0c7f15860 Author: Aleisha Date: Thu Mar 10 01:46:57 2016 +0000 Bug 15990: Making record matching rules actions buttons To test: 1) Go to Administration -> Record matching rules 2) Confirm that the actions 'Edit' and 'Delete' are not buttons and behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/matching-rules.tt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 21 16:58:53 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 21 Mar 2016 15:58:53 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-893-g52c77ad Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 52c77ad9145fd17b6cd263e3981dd59aad9e5b76 (commit) via d003b2453268036dfbbc02248e94f4571f2ce71e (commit) from a5519b36a8b232066bdde3a94733619eaf56eb62 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 52c77ad9145fd17b6cd263e3981dd59aad9e5b76 Author: Marc V?ron Date: Thu Mar 17 17:10:54 2016 +0100 Bug 16089: (Follow up) Display currency symbol properly This patch fixes the display of the currency symbol on invoice.tt See comment #5 Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit d003b2453268036dfbbc02248e94f4571f2ce71e Author: Marc V?ron Date: Thu Mar 17 16:02:02 2016 +0100 Bug 16089: Acquisitions -> Invoice broken by Bug 15084 To test: - Reproduce error described in first comment. - Apply patch - Try to reproduce error. Page will display as expected. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: acqui/invoice.pl | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 21 17:00:17 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 21 Mar 2016 16:00:17 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-895-g8d64bb9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 8d64bb9eb0555983936077b5fab4ca1a648b6871 (commit) via cfa76a35771bb5035e51ff70f8b35439a77cac2a (commit) from 52c77ad9145fd17b6cd263e3981dd59aad9e5b76 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8d64bb9eb0555983936077b5fab4ca1a648b6871 Author: Jonathan Druart Date: Wed Mar 16 09:32:58 2016 +0000 Bug 16073: (follow-up) Fix software error in circulation.pl Do not crash if the patron does not exist. Test plan: Access circ/circulation.pl?borrowernumber=42424242 you should get an error without this patch With this patch, you will get an empty patron detail page (should be fixed in another patch, but this behavior exists for a while) Signed-off-by: Tomas Cohen Arazi Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit cfa76a35771bb5035e51ff70f8b35439a77cac2a Author: Jonathan Druart Date: Mon Mar 14 18:41:02 2016 +0000 Bug 16073: Fix software error in circulation.pl Can't call method "guarantor" on an undefined value at /home/koha/src/circ/circulation.pl line 588. at /home/koha/src/circ/circulation.pl line 673 Introduced by bug 15656 Test plan: Just trigger circ/circulation.pl Signed-off-by: Jacek Ablewicz Triggered circ/circulation.pl - nothing exploded, and error is gone Signed-off-by: Tomas Cohen Arazi Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: circ/circulation.pl | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 21 17:49:52 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 21 Mar 2016 16:49:52 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-896-g4a34045 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 4a3404594ff326e0babb8b7bee8e65f5646ff9f9 (commit) from 8d64bb9eb0555983936077b5fab4ca1a648b6871 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4a3404594ff326e0babb8b7bee8e65f5646ff9f9 Author: Jonathan Druart Date: Mon Feb 22 10:08:55 2016 +0000 Bug 15163: Do not erase patron attributes if limited to another library The patron attributes displayed on editing a patron are not displayed if limited to another library. C4::Members::Attributes::SetBorrowerAttributes will now only delete attributes the librarian is editing. SetBorrowerAttributes takes a new $no_branch_limit parameter. If set, the branch limitations have not effect and all attributes are deleted (same behavior as before this patch). Test plan: 1/ Create 2 patron attributes, without branch limitations. 2/ Edit a patron and set a value for these attributes 3/ Limit a patron attributes to a library (one you are not logged in with). 4/ Edit again the patron. => You should not see the limited attributes 5/ Edit the patron attributes and remove the branch limitation => Without this patch, it has been removed from the database and is not displayed anymore. => With this patch, you should see it. Signed-off-by: Jesse Weaver Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: C4/Auth_with_ldap.pm | 2 +- C4/Members/Attributes.pm | 39 +++++++++++++++-- members/nl-search.pl | 2 +- t/db_dependent/Members_Attributes.t | 79 +++++++++++++++++++++++------------ tools/import_borrowers.pl | 2 +- 5 files changed, 92 insertions(+), 32 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 21 17:51:25 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 21 Mar 2016 16:51:25 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-897-g7aedcf6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 7aedcf643e6f7793b4ebf55b1c7cdec7ec04a25d (commit) from 4a3404594ff326e0babb8b7bee8e65f5646ff9f9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7aedcf643e6f7793b4ebf55b1c7cdec7ec04a25d Author: Jonathan Druart Date: Wed Mar 16 10:01:18 2016 +0000 Bug 16082: Display a friendly "patron does not exist" message if that's the case - circulation.pl The major part of pages you can access from a patron detail page (menu) does not take into consideration the 'patron does not exist' case. If the borrowernumber is linked to a deleted patron, a friendly message should be displayed instead of an empty patron detail page. Test plan: Go on circ/circulation.pl?borrowernumber=424242 and circ/circulation.pl?borrowernumber=424242&batch=1 Notice the difference before and after this patch Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: circ/circulation.pl | 2 +- .../prog/en/modules/circ/circulation.tt | 16 ++++++----- .../en/modules/circ/circulation_batch_checkouts.tt | 28 +++++++++++++------- 3 files changed, 28 insertions(+), 18 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 21 19:20:01 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 21 Mar 2016 18:20:01 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-898-g99f2fee Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 99f2feeed94cb88bb14653231735f35c0787cb27 (commit) from 7aedcf643e6f7793b4ebf55b1c7cdec7ec04a25d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 99f2feeed94cb88bb14653231735f35c0787cb27 Author: Jonathan Druart Date: Wed Mar 9 12:21:14 2016 +0000 Bug 16015: Restore the ability to delete a group of libraries If a group of libraries is linked to at least 1 library, the group cannot be delete and the librarian should get a warning message. But if no libraries are linked, the deletion should be allowed. Since bug 15294 this behavior is broken: The deletion is always blocked: "This library category cannot be deleted. 0 libraries are still using it", hum... Test plan: Create a group of libraries, delete it Signed-off-by: Srdjan Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: admin/branches.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 21 19:21:45 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 21 Mar 2016 18:21:45 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-899-gec33871 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ec3387185dc9d388bf586abd84cfbba2f3153215 (commit) from 99f2feeed94cb88bb14653231735f35c0787cb27 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ec3387185dc9d388bf586abd84cfbba2f3153215 Author: Jonathan Druart Date: Wed Mar 9 08:20:04 2016 +0000 Bug 16010: follow-up of 15381 - FIX merge_authorities migration script Caused by commit 7e70202d34d75f988fbaea9b911347417c203aac Bug 15381: Remove GetAuthType and GetAuthTypeCode If you execute perl misc/migration_tools/merge_authority.pl -f 1 -t 2 you will get: Can't locate object method "authtypecode" via package "1" (perhaps you forgot to load "1"?) at misc/migration_tools/merge_authority.pl line 58. GetAuthority does not return a Koha::Authority but a MARC::Record: there is no authtype code method! Test plan: perl misc/migration_tools/merge_authority.pl -f X -t Y Should not return any error. Note that if the authid X or Y does not exist, the script will die. Signed-off-by: Fr?d?ric Demians Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: misc/migration_tools/merge_authority.pl | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 21 21:37:51 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 21 Mar 2016 20:37:51 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-900-g6c1b39b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6c1b39b4cbceb1a414a91865e15612385c2eb5b7 (commit) from ec3387185dc9d388bf586abd84cfbba2f3153215 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6c1b39b4cbceb1a414a91865e15612385c2eb5b7 Author: Jonathan Druart Date: Fri Mar 18 08:34:22 2016 +0000 Bug 16095: Remove target="_blank" when a link refer to an external link If you click on a link that opens a new tab/window to another site, that tab has access to the original window through JavaScript. The browsing context is related, even if the domains are totally different. The tab retains access to the original window's object via window.opener, even if you navigate to another page or domain, in the new or original window. Access to the Window object means the new window can use Window.location to open a different URL in the original window, perfect for phishing attacks. Depending on the site's Same-Origin Policy settings, the new window may have access to other parts of the original window's DOM as well. Any 'A HREF' that contains a target of of '_blank' or '_new' or a fixed name is vulnerable. Previous security best practice often suggested creating a random fixed name for an unpredictable namespace - that won't help with this problem! Targets of '_self' and '_parent' are safe. We do not use _new (at first glance) but several _blank. Some are used to refer internal url, we do not need to update or remove them. Others are used to satisfy OPACURLOpenInNewWindow, in these case, we should add the rel="noreferrer" attribute to the a tags. In other cases, we can simply remove them and let the users discover that a mouse has more than one button (we are in 2016, they can do it!) Signed-off-by: Chris Signed-off-by: Jesse Weaver Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 4 +-- .../prog/en/modules/acqui/supplier.tt | 2 +- .../intranet-tmpl/prog/en/modules/basket/basket.tt | 2 +- .../prog/en/modules/catalogue/detail.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-basket.tt | 4 +-- .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 32 ++++++++++---------- .../opac-tmpl/bootstrap/en/modules/opac-idref.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/js/google-jackets.js | 2 +- 8 files changed, 25 insertions(+), 25 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 21 22:17:17 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 21 Mar 2016 21:17:17 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-901-gf1e1564 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f1e156453a1bc636914bc5c969e1665d7108cb95 (commit) from 6c1b39b4cbceb1a414a91865e15612385c2eb5b7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f1e156453a1bc636914bc5c969e1665d7108cb95 Author: Jonathan Druart Date: Wed Feb 17 16:21:50 2016 +0000 Bug 15840: Catch errors if userid already exists when importing patrons Import borrowers tool explodes if userid already exists. This error should be caught to avoid the script to explodes. TEST PLAN --------- 1) back up DB 2) drop DB, create empty DB 3) Apply patch 15842 4) web install all the sample data 5) login as system user and import patron data -- sample provided to trigger error. -- you will get a DBIx::class exception "Duplicate entry ' for key 'userid'" 6) Apply this patch 7) Repeat steps 2-5 -- patrons won't be inserted but an error will be nicely displayed in the error list. 8) run koha qa test tools Note that it would be easy to insert the patrons anyway and generate a userid based on the surname and firstname. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/tools/import_borrowers.tt | 5 +++++ tools/import_borrowers.pl | 7 +++++++ 2 files changed, 12 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 21 22:22:25 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 21 Mar 2016 21:22:25 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-902-gad8e96b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ad8e96b83b184fbd8b09253dee8c4ada088e4992 (commit) from f1e156453a1bc636914bc5c969e1665d7108cb95 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ad8e96b83b184fbd8b09253dee8c4ada088e4992 Author: Owen Leonard Date: Mon Mar 14 11:07:14 2016 -0400 Bug 16065 - Use Font Awesome icons in dialog when duplicate patron is suspected This patch updates the new patron template to use Font Awesome icons in the dialog which is shown when a duplicate patron is suspected. The patch modifies the CSS rules for a dialog button with "white-space: pre-line" so that line breaks in button text markup are treated as line breaks on display. Allowing the text to wrap prevents the buttons from being too wide and stacking one below the other. To test, apply the patch and go to Patrons -> New patron. - Attempt to save a new patron with details matching an existing patron in order to trigger the duplicate patron warning. - Confirm that the resulting dialog is styled correctly. - Confirm the behavior of both the 'Edit existing' and 'Save as new' buttons. Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css | 1 + .../intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 8 +++++--- 2 files changed, 6 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 21 22:23:14 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 21 Mar 2016 21:23:14 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-903-g974ea0c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 974ea0c8bdc15eb357d5f3f31ecb6cf0ae3fbace (commit) from ad8e96b83b184fbd8b09253dee8c4ada088e4992 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 974ea0c8bdc15eb357d5f3f31ecb6cf0ae3fbace Author: Owen Leonard Date: Mon Mar 14 10:12:38 2016 -0400 Bug 16064 - Remove use of image to indicate approval in tags moderation This patch updates the tags moderation template to use text labels to mark tag moderation status, eliminating the use of an image file to signify approval. To test you should have some tags in each approval state: pending, approved, and rejected. - Apply the patch and go to Tools -> Tags. - Confirm that the status of each tag is clearly shown with a text label. Works as expected (Do not forget to set filter at the left to 'all' for testing) Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/tags/review.tt | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 21 22:24:27 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 21 Mar 2016 21:24:27 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-904-gaa6457f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via aa6457f38f33df9e01a554165bcd1f6f075b4cd2 (commit) from 974ea0c8bdc15eb357d5f3f31ecb6cf0ae3fbace (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit aa6457f38f33df9e01a554165bcd1f6f075b4cd2 Author: Owen Leonard Date: Tue Mar 8 14:40:02 2016 -0500 Bug 16061: Use Font Awesome icons in reports when filter returns no results In Reports -> Saved reports, when the filter form returns no results a dialog is shown. This patch updates the dialog to use Font Awesome icons. Also changed: The dialog now includes a button for creating a new SQL report, not just one to create a new guided report. The "clear" link in the sidebar has been modified to pass HTML validation. To test, apply the patch and go to Reports -> Saved reports. - In the left-hand sidebar filter, submit terms which will return no results. - Verify that the resulting dialog is correctly styled. - Confirm that all three buttons in the dialog work correctly: New guided report, new SQL report, and Cancel. Signed-off-by: Marc V?ron Signed-off-by: Tomas Cohen Arazi I'm passing this one, while I don't like it is hardcoding a URL path, because it will make is easier to spot it when time comes and we make Koha delpoyable in any endpoint. Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/reports/guided_reports_start.tt | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 21 22:25:15 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 21 Mar 2016 21:25:15 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-905-gfbcc350 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via fbcc350e9176a1da3fe839240502909d745a2b31 (commit) from aa6457f38f33df9e01a554165bcd1f6f075b4cd2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fbcc350e9176a1da3fe839240502909d745a2b31 Author: Owen Leonard Date: Thu Mar 10 09:19:14 2016 -0500 Bug 16060 - Add Font Awesome icon to Z39.50 search button when no results are found When a staff client catalog search returns no results, a Z39.50/SRU search button is shown. This patch adds a Font Awesome icon to that button. Also changed: A stray extra double quote has been removed. The onclick attribute has been removed from the search button in favor of an event already defined. To test, apply the patch and perform a search in the staff client catalog which will return no results. - Confirm that the Z39.50/SRU button looks correct and works correctly. - Validate the HTML of the page and confirm that no unexpected errors are returned. NOTE: Pretty! Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 21 22:26:54 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 21 Mar 2016 21:26:54 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-906-g101ba17 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 101ba17685513364f80ec574cabd144d81570ddc (commit) from fbcc350e9176a1da3fe839240502909d745a2b31 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 101ba17685513364f80ec574cabd144d81570ddc Author: Owen Leonard Date: Mon Mar 14 11:36:19 2016 -0400 Bug 16066 - JavaScript error on new patron form when duplicate is suspected When a new patron is submitted which is suspected to be a duplicate, the entry form is redisplayed with a new name attribute, "form_nodouble." Other scripts on the page still look for a form named "form," so there is an error. This patch removes the use of "form_nodouble" on the assumption that it is unnecessary to name the form something different when a duplicate is suspected. All the same validation scripts should be run on the form either way. To test, apply the patch and clear your cache if necessary. - Go to Patrons -> New patron and add a patron which matches an existing one in order to trigger the duplicate warning. - Confirm that Firebug (or similar) is not reporting a JavaScript error. - Confirm that the 'Edit existing' and 'Save as new' buttons work correctly. Reproduced JavaScript error and verified that it no longer appears with this patch. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/js/members.js | 6 +++--- .../intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 21 22:28:03 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 21 Mar 2016 21:28:03 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-908-g4f85765 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 4f857659940434ad804603b0efa24dee141e2711 (commit) via b656d90147fc1cd20434c812129a1c2603aee185 (commit) from 101ba17685513364f80ec574cabd144d81570ddc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4f857659940434ad804603b0efa24dee141e2711 Author: Jonathan Druart Date: Fri Mar 11 11:42:09 2016 +0000 Bug 16053: Do not remove the active flag when editing the active currency From commit b574b615919a6463708d4c1d7b1153a061c1ea0a Bug 15084: Make sure the previous active currency is marked as inactive When a currency is stored, all the active flags of all currencies are unset. Only the active ones and different than the one we are editing should be updated. Test plan: Edit the active currency => Without this patch the active flag was removed => With this patch, the active flag is kept Edit another currency and set it the active flag => The active flag must have been removed from the previously active currency. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit b656d90147fc1cd20434c812129a1c2603aee185 Author: Jonathan Druart Date: Fri Mar 11 11:32:22 2016 +0000 Bug 16053: Add tests Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: Koha/Acquisition/Currency.pm | 8 +++++++- t/db_dependent/Koha/Acquisition/Currencies.t | 6 +++++- 2 files changed, 12 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 21 23:31:58 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 21 Mar 2016 22:31:58 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-909-g6045a80 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6045a808f34f544e7713c462f41a5c1c95ff2d10 (commit) from 4f857659940434ad804603b0efa24dee141e2711 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6045a808f34f544e7713c462f41a5c1c95ff2d10 Author: Jonathan Druart Date: Wed Mar 16 10:14:44 2016 +0000 Bug 16030: Add 'Automatic item modifications by age' to the tool sidebar Test plan: Go on a page of the tools module You should see a "Automatic item modifications by age" link Click on it The list should not be styled to highlight the fact that you are on this page. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc | 3 +++ 1 file changed, 3 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 21 23:33:37 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 21 Mar 2016 22:33:37 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-910-gf646331 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f6463317db08b9a4218ad94a2d191a5f5216c8c5 (commit) from 6045a808f34f544e7713c462f41a5c1c95ff2d10 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f6463317db08b9a4218ad94a2d191a5f5216c8c5 Author: Jonathan Druart Date: Wed Mar 9 11:28:04 2016 +0000 Bug 16013: Make classification sources deletable Because of a wrong variable scope, the classification sources are not deletable. Test plan: Create a classification sources (admin/classsources.pl) Try to delete it Without this patch, the classification source won't be deleted With this patch, it will work! Signed-off-by: Srdjan Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: admin/classsources.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 21 23:34:43 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 21 Mar 2016 22:34:43 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-911-g804e7d3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 804e7d377bf513671c1b0904c97bd378c8e6965f (commit) from f6463317db08b9a4218ad94a2d191a5f5216c8c5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 804e7d377bf513671c1b0904c97bd378c8e6965f Author: Jonathan Druart Date: Wed Mar 9 11:16:07 2016 +0000 Bug 16012: Restore the ability to edit default authority type Bug 15380 introduced a regression on the authority types admin page: the default authority type (authtypecode="") is no longer editable. Test plan: Edit the authority type to update the summary => Without this patch you will get the "add a new authority type" form => With this patch applied, the correct behavior will be restored Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: admin/authtypes.pl | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 21 23:48:11 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 21 Mar 2016 22:48:11 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-912-g7e1ccbd Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 7e1ccbd6069658540dd352f63ade3ef7b19de282 (commit) from 804e7d377bf513671c1b0904c97bd378c8e6965f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7e1ccbd6069658540dd352f63ade3ef7b19de282 Author: Kyle M Hall Date: Mon Mar 7 14:04:44 2016 +0000 Bug 15997 - Hold Ratios for ordered items doesn't count orders where AcqCreateItem is set to 'receiving' Currently, the hold ratios script only counts on order items where the record item is created at the time the order is placed, and not if the item is created when the item is received. Test Plan: 1) Set AcqCreateItem to recieving 2) Run the hold ratios report with "include ordered" checked 3) From aquisitions, order some additional items for the record 4) Re-run the hold ratios report, not there is no change in the ratio for that record 5) Apply this patch 6) Re-run the hold ratios reporat again, the ratio should now have changed Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: circ/reserveratios.pl | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 21 23:49:10 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 21 Mar 2016 22:49:10 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-914-gfdac3ee Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via fdac3eecf857ef6ff85b6cc971bb0c4de2c368a1 (commit) via 5896770e079840f91e048de59b9c235d3974698c (commit) from 7e1ccbd6069658540dd352f63ade3ef7b19de282 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fdac3eecf857ef6ff85b6cc971bb0c4de2c368a1 Author: Jonathan Druart Date: Tue Mar 8 10:46:46 2016 +0000 Bug 15962: Block the currency deletion if used A currency should not be deleted if used by a vendor or a basket. Test plan: 1/ Add a new currency 2/ Create a vendor using this currency 3/ Create a basket using this currency 4/ Try to delete the currency 5/ Delete the basket 6/ Try to delete the currency 7/ Delete the vendor 8/ Delete the currency Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit 5896770e079840f91e048de59b9c235d3974698c Author: Jonathan Druart Date: Tue Mar 8 10:38:37 2016 +0000 Bug 15962: Add messages on the currency admin page Bug 15084 rewrote the currency admin page but forgot to add the messages block. Test plan: Add/update/delete vendors. You should get information messages. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: Koha/Acquisition/Bookseller.pm | 2 -- admin/currency.pl | 3 ++ .../prog/en/modules/admin/currency.tt | 34 ++++++++++++++++++-- 3 files changed, 35 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Mar 22 01:09:14 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 22 Mar 2016 00:09:14 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-915-g6ca12c8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6ca12c8a72628fbb4b1f968d249232a573375468 (commit) from fdac3eecf857ef6ff85b6cc971bb0c4de2c368a1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6ca12c8a72628fbb4b1f968d249232a573375468 Author: Jonathan Druart Date: Tue Mar 8 11:07:43 2016 +0000 Bug 15868: Ask for confirmation when deleting a MMT action Test plan: Create marc modification template Add an action Delete it With this patch you must get a confirmation mesg Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/js/marc_modification_templates.js | 9 ++++++--- .../prog/en/modules/tools/marc_modification_templates.tt | 5 +++-- 2 files changed, 9 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Mar 22 01:36:12 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 22 Mar 2016 00:36:12 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-916-g0e2787e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 0e2787e3790e42f31a4b949f585676abe49efb73 (commit) from 6ca12c8a72628fbb4b1f968d249232a573375468 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0e2787e3790e42f31a4b949f585676abe49efb73 Author: Owen Leonard Date: Tue Mar 15 10:02:22 2016 -0400 Bug 16077 - Remove unused script and template card-print I can find no reference to card-print.pl being used in Koha. This patch deletes it and its associated template. To test, apply the patch and search for references to "card-print" in Koha. There should be none. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart This script does not work, it fails with 'Undefined subroutine get_label_output_formats'. This subroutine was in C4::Labels::Lib which has been removed by 2433a91 (Feb 8 2010): Removing depricated file from the C4::Labels module. Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/patroncards/card-print.tt | 165 -------------------- patroncards/card-print.pl | 131 ---------------- 2 files changed, 296 deletions(-) delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/card-print.tt delete mode 100755 patroncards/card-print.pl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Mar 22 01:48:48 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 22 Mar 2016 00:48:48 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-918-gdf127eb Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via df127ebad814ad1710b161b85a69d408de95de85 (commit) via 577aa86eb96160088c70008bfe85ae2c0820f547 (commit) from 0e2787e3790e42f31a4b949f585676abe49efb73 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit df127ebad814ad1710b161b85a69d408de95de85 Author: Owen Leonard Date: Thu Mar 17 09:08:39 2016 -0400 Bug 16047 [Follow-up] Software error on deleting a group with no category code This follow-up take the original patch a little further, making category name required on the entry form as well. Without a category name there is no label in the interface when selecting a category. That doens't make any sense. Also changed on the group entry form: - Added "required" attribute to labels on required fields. - Changed "Update" submit button label to "Submit." - Added a "Cancel" link. - Added the "validated" class to the form so that our built-in validation script will process it (not strictly necessary but makes the validation appearance more consistent). Followed test plan, form displays and behaves as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit 577aa86eb96160088c70008bfe85ae2c0820f547 Author: Aleisha Date: Thu Mar 10 21:49:57 2016 +0000 Bug 16047: Making category code a required field on creating a group This will prevent users from creating a group without a category code, which causes a software error when you try to delete it To test: 1) Go to Admin -> Libraries and groups 2) Create new group without category code 3) Attempt to delete the group you just created and notice software error 4) Apply patch 5) Create new group without category code 6) Notice you now cannot save the group without putting in a category code Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/admin/branches.tt | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Mar 22 01:49:56 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 22 Mar 2016 00:49:56 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-919-g1870141 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 1870141874667d854f9b5508c563169baefb2328 (commit) from df127ebad814ad1710b161b85a69d408de95de85 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1870141874667d854f9b5508c563169baefb2328 Author: Aleisha Date: Sun Mar 13 23:40:53 2016 +0000 Bug 16029: Hide patron toolbar if patron does not exist To test: 1) Create a patron, take note of the borrower number 2) Delete the patron 3) Navigate to the page of the patron you just deleted by typing the url (ie /cgi-bin/koha/members/moremember.pl?borrowernumber=X) 4) Confirm that the patron toolbar is not showing on the page 5) The message now has a link that says 'Find another patron?'. Click this link and confirm you are taken to the member home pgae. Sponsored-by: Catalyst IT Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Mar 22 01:50:49 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 22 Mar 2016 00:50:49 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-920-g5d26669 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 5d266693edc042c0a2f795588058ae8b3d12da22 (commit) from 1870141874667d854f9b5508c563169baefb2328 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5d266693edc042c0a2f795588058ae8b3d12da22 Author: Owen Leonard Date: Wed Mar 9 10:02:08 2016 -0500 Bug 16023 - Use Font Awesome icons on audio alerts page The audio alerts management page uses Glyphicons in a few places. This patch replaces them with Font Awesome icons. To test, apply the patch for Bug 15886 if necessary and enable the AudioAlerts system preference. - Go to Administration -> Audio alerts - Confirm that icons for "Edit" and "Delete selected" look correct. - Edit an existing alert and confirm that the "play" button looks correct and works correctly. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/audio_alerts.tt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Mar 22 01:51:59 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 22 Mar 2016 00:51:59 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-921-g8e37e34 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 8e37e3454138e75a38ec5a65d202692700b4ba20 (commit) from 5d266693edc042c0a2f795588058ae8b3d12da22 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8e37e3454138e75a38ec5a65d202692700b4ba20 Author: Owen Leonard Date: Wed Mar 9 09:20:14 2016 -0500 Bug 16020 - Remove unused CSS and images following label creator UX changes Since the changes made by Bug 16020, some CSS and images are no longer needed by the label and patron card creator modules. This patch removes the unnecessary files and CSS. To test, apply the patch and go to Tools -> Label creator. - Confirm that the label creator home page doesn't look broken. - Go to Tools -> Patron card creator and confirm that the page doesn't look broken. - Search Koha files for references to label-creator-image.png. There should be none. Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/css/card.css | 37 -------------------- koha-tmpl/intranet-tmpl/prog/en/css/label.css | 37 -------------------- .../intranet-tmpl/prog/en/css/right-to-left.css | 24 ------------- .../prog/en/modules/labels/label-home.tt | 1 - .../prog/en/modules/patroncards/home.tt | 1 - .../intranet-tmpl/prog/img/label-creator-image.png | Bin 154915 -> 0 bytes 6 files changed, 100 deletions(-) delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/css/card.css delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/css/label.css delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/label-creator-image.png hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Mar 22 01:56:22 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 22 Mar 2016 00:56:22 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-924-gb129de0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b129de03555f3557a860b3630b689ae9905e9466 (commit) via 48afb232e1b3e84f21b0e8552d61f02aeac22902 (commit) via 3b96bf7516e011a83b988855ebe806bd485edb8e (commit) from 8e37e3454138e75a38ec5a65d202692700b4ba20 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b129de03555f3557a860b3630b689ae9905e9466 Author: Brendan Gallagher Date: Tue Mar 22 01:03:03 2016 +0000 DBREV for Bug 16019 - Remove unused blue.css Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit 48afb232e1b3e84f21b0e8552d61f02aeac22902 Author: Owen Leonard Date: Wed Mar 9 08:51:26 2016 -0500 Bug 16019 - Remove unused blue.css This patch removes blue.css and one image which was used only by blue.css, css_header.png. To test, apply the patch and search Koha files for references to blue.css and css_header.png. There should be none. Signed-off-by: Fr?d?ric Demians Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit 3b96bf7516e011a83b988855ebe806bd485edb8e Author: Jonathan Druart Date: Fri Mar 18 16:34:09 2016 +0000 Bug 16019: Add a warning in the update DB process if intranetcolorstylesheet=blue.css Signed-off-by: Katrin Fischer ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/updatedatabase.pl | 14 +++ koha-tmpl/intranet-tmpl/prog/en/css/blue.css | 110 ----------------------- koha-tmpl/intranet-tmpl/prog/img/css_header.png | Bin 897 -> 0 bytes 4 files changed, 15 insertions(+), 111 deletions(-) delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/css/blue.css delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/css_header.png hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Mar 22 02:06:38 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 22 Mar 2016 01:06:38 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-925-g98a9e30 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 98a9e30f040661e0a67a594f72abd8ab02cf9ad6 (commit) from b129de03555f3557a860b3630b689ae9905e9466 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 98a9e30f040661e0a67a594f72abd8ab02cf9ad6 Author: Owen Leonard Date: Fri Mar 18 09:41:15 2016 -0400 Bug 15984 - Correct templates which use the phrase "issuing rules" This patch corrects two places in the templates where the phrase "issuing rules" is used instead of "circulation and fine rules." To test, apply the patch and view the help pages for Administration -> Circulation and fine rules; and Tools -> Automatic item modification by age. Confirm that the term "circulation and fine rules" is used instead of "issuing rules." Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/smart-rules.tt | 2 +- .../prog/en/modules/help/tools/automatic_item_modification_by_age.tt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Mar 22 02:39:38 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 22 Mar 2016 01:39:38 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-926-ga9d7292 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a9d7292a103918ecddcfabc430ea07cdd3513148 (commit) from 98a9e30f040661e0a67a594f72abd8ab02cf9ad6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a9d7292a103918ecddcfabc430ea07cdd3513148 Author: Aleisha Date: Thu Mar 17 22:34:08 2016 +0000 Bug 15421: Show 'Duplicate' and 'Schedule' on Reports toolbar To test: 1) Go to Reports -> Use saved 2) Click 'Show' on the dropdown for any report 3) Confirm that 'Duplicate and 'Schedule' are now on the toolbar and work as expected Sponsored-by: Catalyst IT Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/includes/reports-toolbar.inc | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Mar 22 02:40:55 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 22 Mar 2016 01:40:55 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-927-g515e2d7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 515e2d7c9d2b5afe3f7c0618596f1d9e5e699315 (commit) from a9d7292a103918ecddcfabc430ea07cdd3513148 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 515e2d7c9d2b5afe3f7c0618596f1d9e5e699315 Author: Colin Campbell Date: Fri Mar 18 13:49:56 2016 +0000 Bug 16106 Correct loose to lose in comment Comment was using incorrect (but similarly spelled) word, obscuring the meaning slightly. Also corrected the release note altering the grammar there additionally as it should have been 3rd person singular so that it now reads more clearly Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: misc/plack/koha.psgi | 2 +- misc/release_notes/release_notes_3_22_0.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 23 00:01:19 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 22 Mar 2016 23:01:19 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-929-g08eabd2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 08eabd2b9688d8394f07af118beabb3980b0b1d0 (commit) via db0ecc3cc5dbde028db8b083dbe5d75740552445 (commit) from 515e2d7c9d2b5afe3f7c0618596f1d9e5e699315 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 08eabd2b9688d8394f07af118beabb3980b0b1d0 Author: Jonathan Druart Date: Tue Mar 22 11:04:41 2016 +0000 Bug 15585: Remove "shift on reference is experimental" warning Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com commit db0ecc3cc5dbde028db8b083dbe5d75740552445 Author: charles Date: Wed Jan 27 15:17:32 2016 -0500 Bug 15585 - Move C4::Passwordrecovery to the new namespace Koha::Patron::Password::Reset As promised, here is the long-awaited sequel to #8753. What has changed : - The Koha::Patron::Password::Reset is now used in place of C4::Passwordrecovery - That ugly shift-grep contraption is no more (goodbye old friend) - The generated unique key won't end in a dot anymore Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: .../Patron/Password/Recovery.pm | 15 +++--- opac/opac-password-recovery.pl | 15 +++--- t/db_dependent/Passwordrecovery.t | 52 ++++++++++---------- 3 files changed, 44 insertions(+), 38 deletions(-) rename C4/Passwordrecovery.pm => Koha/Patron/Password/Recovery.pm (91%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 23 00:16:36 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 22 Mar 2016 23:16:36 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-930-g94dde6b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 94dde6b48d6e20a5260ea49f9b98ec884c2c25b5 (commit) from 08eabd2b9688d8394f07af118beabb3980b0b1d0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 94dde6b48d6e20a5260ea49f9b98ec884c2c25b5 Author: Jonathan Druart Date: Fri Feb 12 11:32:02 2016 +0000 Bug 15809: Redefine multi_param is CGI < 4.08 is used On debian Jessie, the CGI version is >= 4.08 Since this version, the param method raise a warning "CGI::param called in list context". Indeed, it can cause vulnerability if called in list context https://metacpan.org/pod/CGI#Fetching-the-value-or-values-of-a-single-named-parameter http://blog.gerv.net/2014/10/new-class-of-vulnerability-in-perl-web-applications/ There is a long journey to get rid of these warnings. First I suggest to redefine the multi_param method when the CGI version installed is < 4.08, it will allow us to move the wrong ->param calls to ->multi_param without waiting for everybody to upgrade. The different ways to call these 2 methods are: my $foo = $cgi->param('foo'); # OK my @foo = $cgi->param('foo'); # NOK, will raise the warning my @foo = $cgi->multi_param('foo'); #OK $template->param( foo => $cgi->param('foo') ); # NOK, will raise the warning # and vulnerable $template->param( foo => scalar $cgi->param('foo') ); # OK Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Tested a call to multi_param with CGI < 4.08. With reference to the comments on Bugzilla, this workaround is arguable, but provides a base to move to multi_param. If we come up with a better solution, it should be easy to adjust. Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: C4/Context.pm | 9 +++++++++ 1 file changed, 9 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 23 00:46:27 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 22 Mar 2016 23:46:27 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-931-ge884a62 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e884a627bbc85c7ce1ced2861bbc5467ff7a192c (commit) from 94dde6b48d6e20a5260ea49f9b98ec884c2c25b5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e884a627bbc85c7ce1ced2861bbc5467ff7a192c Author: Zeno Tajoli Date: Tue Mar 1 11:18:04 2016 +0100 Bug 15946 Valid namespace for OAI marcxml schema This path fixes the value of xml schema variable and the link to Library of Congress. For Dublin Core format those values are defined in UNIMARCslim2OAIDC.xsl and MARC21slim2OAIDC.xsl. For MARCXML those values are written into the code To test it: 1) Setup OAI-PMH 2) Test the site inserting the BaseURL into http://validator.oaipmh.com 3) See the problem with ListMetadataFormats [link: http://validator.oaipmh.com/#ListMetadataFormats] 4) Insert the patch 5) See the problem is over Signed-off-by: Fr?d?ric Demians Invalid before patch, valid after. Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: Koha/OAI/Server/ListMetadataFormats.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 23 00:52:28 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 22 Mar 2016 23:52:28 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-932-gdfb8982 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via dfb8982ca79595297c7430243ad90b77e21d8a67 (commit) from e884a627bbc85c7ce1ced2861bbc5467ff7a192c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit dfb8982ca79595297c7430243ad90b77e21d8a67 Author: Owen Leonard Date: Wed Mar 9 10:27:03 2016 -0500 Bug 16025 [Revised] Use Font Awesome icons on item types localization page The item types localization page uses a Glyphicon. This patch converts it to a Font Awesome icon. Also changed in this patch: "Delete" text has been added to the delete link, and a dummy "href" attribute has been added to the link so that it triggers the right kind of cursor. The deletion confirmation JavaScript has been edited to ignore the default click action. To test, apply the patch and go to Administration -> Item types. - Edit any existing item type and click the "Translate into other languages" link. - If there is not an existing translation, add one. Close the modal window and click the "Translate into other languages" link again to redisplay it. - Confirm that there is a "Delete" link next to your translation which is styled correctly. - Confirm that the behavior of the "Delete" link is correct both when confirming and when canceling. Revision adds the "actions" class to the table cell with the delete link to prevent a line break between the icon and the text. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/localization.tt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 23 00:53:44 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 22 Mar 2016 23:53:44 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-933-gb72f9b8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b72f9b8c51eb11861b931f193628460e2219a4fc (commit) from dfb8982ca79595297c7430243ad90b77e21d8a67 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b72f9b8c51eb11861b931f193628460e2219a4fc Author: Aleisha Date: Sun Mar 20 23:37:38 2016 +0000 Bug 15861: Isolated 'The' in help files untranslatable Changes made: help/reports/reports-home.tt Line 11: Koha database schema: shows the entire Koha database structure so that you can write effective SQL Queries Line 12: Koha reports library: lists reports written by Koha users around the world. help/rotating_collections/rotatingCollections.tt Line 7: Important: AutomaticItemReturn (system preference) must be set to .. TEST PLAN --------- 1) Log in to staff client 2) Click 'Reports' 3) Click 'Help' -- Notice the two lines starting with 'The' 4) Click 'Tools' 5) Click 'Rotating collections' in the Catalog column 6) Click 'Help' -- Notice the Important has a 'The' 7) Apply patch 8) Repeat steps 2-6 -- Notice the wording has changed to eliminate 'The' 9) Run koha qa test tools Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/help/reports/reports-home.tt | 6 +++--- .../en/modules/help/rotating_collections/rotatingCollections.tt | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 23 00:54:58 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 22 Mar 2016 23:54:58 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-934-g70eedf2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 70eedf2217e1bfde1c56bc77c8dd0dc039124f47 (commit) from b72f9b8c51eb11861b931f193628460e2219a4fc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 70eedf2217e1bfde1c56bc77c8dd0dc039124f47 Author: Jonathan Druart Date: Wed Jan 6 13:10:00 2016 +0000 Bug 15119: Hide search header text boxes on render When the page rendering is slow or the page is heavy, the tabs in the header shown be not correctly displayed as tabs. This patch suggests to hide them, display the first one, and wait for the JS code to display them nicely. To easily reproduced the ergonomic issue, go on the circulation home page (/cgi-bin/koha/circ/circulation.pl) and search for a patron 'a' or 'd', you will get a lot of result and the page will be slow to be fully displayed. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Owen Leonard Signed-off-by: Christopher Brannon Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css | 9 +++++++++ koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js | 2 ++ 2 files changed, 11 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 23 00:56:00 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 22 Mar 2016 23:56:00 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-935-g71a878b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 71a878bdf3b8545f2e7f3b3332f182e328736d85 (commit) from 70eedf2217e1bfde1c56bc77c8dd0dc039124f47 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 71a878bdf3b8545f2e7f3b3332f182e328736d85 Author: Aleisha Date: Sat Mar 19 21:43:36 2016 +0000 Bug 16110: Making lists actions buttons To test: 1) Go to Lists 2) Confirm that actions (Edit and Delete) now show as font awesome buttons and work as expected for both Public and Private lists Sponsored-by: Catalyst IT NOTE: Pretty! :) Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/virtualshelves/tables/shelves_results.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 23 01:31:15 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 23 Mar 2016 00:31:15 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-936-g0b33801 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 0b338019767f049f4853d52caa9e192710cc1d66 (commit) from 71a878bdf3b8545f2e7f3b3332f182e328736d85 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0b338019767f049f4853d52caa9e192710cc1d66 Author: Aleisha Date: Fri Mar 18 00:02:20 2016 +0000 Bug 16099: Make name required field when creating subscription field To test: 1) Notice behaviour when adding subcription field (Serials) without a name 2) Apply patch 3) Attempt to create subscription field without a name and click Save 4) Notice that you not cannot submit the form without adding the name Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 23 01:35:46 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 23 Mar 2016 00:35:46 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-937-g9ee04af Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 9ee04af76c4cc781b7662628c971e50be96fa6a0 (commit) from 0b338019767f049f4853d52caa9e192710cc1d66 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9ee04af76c4cc781b7662628c971e50be96fa6a0 Author: Aleisha Date: Thu Mar 17 23:52:14 2016 +0000 Bug 16098: Making subscription fields actions buttons To test: 1) Go to Serials -> Add subscription fields 2) Confirm actions "Edit" and "Delete" now show as buttons and work as expected 3) When you make your browser narrow, confirm that the Actions column does not wrap 4) Confirm that you cannot sort on the Actions column Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 23 01:38:35 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 23 Mar 2016 00:38:35 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-938-gd04bfed Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d04bfed58ca6472950766cae8bd71c48a33d798f (commit) from 9ee04af76c4cc781b7662628c971e50be96fa6a0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d04bfed58ca6472950766cae8bd71c48a33d798f Author: Aleisha Date: Thu Mar 17 23:15:40 2016 +0000 Bug 16097: Making messages for subscription fields more user friendly To test: 1) Go to Serials -> Add Subscription fields 2) Create a field, confirm message. 3) Attempt to create a new field that has the same name as an existing field, confirm message. 4) Create another field with a different name. Attempt to edit this field to have the same name as another field. Confirm message 5) Edit field (change name to something different) 6) Delete field, confirm message. 6) Turn off permissions to delete subcriptions ONLY. Attempt to delete a field, confirm message. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/serials/add_fields.tt | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 23 01:54:56 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 23 Mar 2016 00:54:56 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-939-g2e3c110 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2e3c1104664a1534bad727da79cfc9a0e953166c (commit) from d04bfed58ca6472950766cae8bd71c48a33d798f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2e3c1104664a1534bad727da79cfc9a0e953166c Author: Aleisha Date: Thu Mar 17 22:39:57 2016 +0000 Bug 16096: Change 'modify' to 'edit' for OAI sets config To test: 1) Go to Admin > OAI Sets Configuration 2) Confirm button in dropdown now says 'Edit'. Click button 3) Confirm heading of page now says 'Edit' and says 'Edit' in breadcrumbs Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/oai_sets.tt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 23 01:55:52 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 23 Mar 2016 00:55:52 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-940-g3da052f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 3da052f16c7b677c28b8d5865bcebfbc73f0df90 (commit) from 2e3c1104664a1534bad727da79cfc9a0e953166c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3da052f16c7b677c28b8d5865bcebfbc73f0df90 Author: Aleisha Date: Wed Mar 16 03:25:58 2016 +0000 Bug 16081: Making Koha to MARC mapping actions buttons To test: 1) Go to Admin -> Koha to MARC mapping 2) Confirm that Edit shows as a font awesome button and works as expected. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/koha2marclinks.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 23 01:56:42 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 23 Mar 2016 00:56:42 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-941-g4cfee1f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 4cfee1fb9eb6bb724fa92425e93902e051bcff47 (commit) from 3da052f16c7b677c28b8d5865bcebfbc73f0df90 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4cfee1fb9eb6bb724fa92425e93902e051bcff47 Author: Owen Leonard Date: Tue Mar 15 09:58:22 2016 -0400 Bug 16078 [Revised] Remove unused YUI CSS The YUI CSS file "skin.css" is no longer relevant to the staff client templates and can be removed. Other references to YUI-related classes, with the exception of grids, can also be removed. This patch removes references in CSS to: .yuimenuitemlabel .yui-button .yui-menu-button ...and removes the "yui-skin-sam" class from two templates' body tag. skin.css is also included in a list of assets cached by the offline circulation page. It can be safely removed. To test, apply the patch and clear your cache if necessary. Look around and confirm that the style of the staff client is unchanged. Search for references to the listed classes and confirm that none are found. Revised patch squashes in the follow-up as well as a missing commit removing skin.css from staff-global.css. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/css/right-to-left.css | 1 - .../intranet-tmpl/prog/en/css/staff-global.css | 38 ++------------------ koha-tmpl/intranet-tmpl/prog/en/lib/yui/skin.css | 23 ------------ .../en/modules/cataloguing/value_builder/macles.tt | 2 +- .../prog/en/modules/circ/offline-mf.tt | 1 - .../prog/en/modules/serials/serials-collection.tt | 2 +- 6 files changed, 5 insertions(+), 62 deletions(-) delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/lib/yui/skin.css hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 23 01:57:37 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 23 Mar 2016 00:57:37 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-942-g44b37f3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 44b37f3bc8ff1fecdb4a4e99759e91efc16d5714 (commit) from 4cfee1fb9eb6bb724fa92425e93902e051bcff47 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 44b37f3bc8ff1fecdb4a4e99759e91efc16d5714 Author: Aleisha Date: Tue Mar 15 06:26:06 2016 +0000 Bug 16075: Making numbering patterns actions buttons To test: 1) Go to Serials -> Manage numbering patterns 2) Confirm that buttons 'Edit' and 'Delete' show as buttons and work as expected 3) Confirm that when you make your window narrow, the column with the buttons does not wrap 4) Confirm that column heading is now 'Actions' Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Buttons look correct and work correctly. Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/serials/subscription-numberpatterns.tt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 23 01:59:02 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 23 Mar 2016 00:59:02 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-943-g6a078fb Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6a078fb1b34ad9585ccd4c717723dfca2a91df80 (commit) from 44b37f3bc8ff1fecdb4a4e99759e91efc16d5714 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6a078fb1b34ad9585ccd4c717723dfca2a91df80 Author: Jonathan Druart Date: Tue Mar 22 09:38:52 2016 +0000 Bug 16114: Koha::ItemType->translated_description should return a string This patch fixes a regression introduce by bug 14828. If an itemtype is translated, its description won't be displayed correctly on the item search form. Koha::ItemType->translated_description is only used once. Test plan: - define a translation for an item type (Administration -> Item types -> Edit -> Translate into other languages) - go on the item search form, the item type should be displayed correctly. QA note: This module is not covered by tests, it seems that I forgot to write them... Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: Koha/ItemType.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 23 01:59:51 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 23 Mar 2016 00:59:51 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.22.00-944-g39597b8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 39597b86ae299a9b4c0c1e8221f51f9e8dd300ed (commit) from 6a078fb1b34ad9585ccd4c717723dfca2a91df80 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 39597b86ae299a9b4c0c1e8221f51f9e8dd300ed Author: Jonathan Druart Date: Tue Feb 9 17:02:05 2016 +0000 Bug 15773: Fix and standardise checkboxes code in framework When creating a new subfield for an authority framework, the checkboxes don't behave as they should. If you click on the 'repeatable', 'mandatory' or 'is url' checkbox's label, the checkbox from the second tab will be checked/unchecked. This is caused by a non-unique id of the input element. I have found this bug when working on the removal of CGI::checkbox in both admin/auth_subfields_structure.pl and admin/marc_subfields_structure.pl scripts. This patch remove the use of CGI::checkbox as well as the generation of html code from these 2 pl scripts (which should be avoided). The code these scripts are now pretty similar. Test plan: Add/modify/remove subfield for a MARC framework and an Authority framework. Use as many field as possible and confirm that the values are correctly inserted/displayed. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com ----------------------------------------------------------------------- Summary of changes: admin/auth_subfields_structure.pl | 179 ++++++------------- admin/marc_subfields_structure.pl | 183 ++++++-------------- .../en/modules/admin/auth_subfields_structure.tt | 100 +++++++---- .../en/modules/admin/marc_subfields_structure.tt | 74 +++++--- 4 files changed, 209 insertions(+), 327 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 23 07:32:16 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 23 Mar 2016 06:32:16 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.04-80-g0d904b6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 0d904b655e65f70476c5d7daf355cc7c3cf0976b (commit) from f9b25894dd9095f130f8139ae63a5d955759ea5a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0d904b655e65f70476c5d7daf355cc7c3cf0976b Author: Jonathan Druart Date: Mon Feb 22 10:08:55 2016 +0000 Bug 15163: Do not erase patron attributes if limited to another library The patron attributes displayed on editing a patron are not displayed if limited to another library. C4::Members::Attributes::SetBorrowerAttributes will now only delete attributes the librarian is editing. SetBorrowerAttributes takes a new $no_branch_limit parameter. If set, the branch limitations have not effect and all attributes are deleted (same behavior as before this patch). Test plan: 1/ Create 2 patron attributes, without branch limitations. 2/ Edit a patron and set a value for these attributes 3/ Limit a patron attributes to a library (one you are not logged in with). 4/ Edit again the patron. => You should not see the limited attributes 5/ Edit the patron attributes and remove the branch limitation => Without this patch, it has been removed from the database and is not displayed anymore. => With this patch, you should see it. Signed-off-by: Jesse Weaver Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com (cherry picked from commit 4a3404594ff326e0babb8b7bee8e65f5646ff9f9) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Auth_with_ldap.pm | 2 +- C4/Members/Attributes.pm | 39 +++++++++++++++-- members/nl-search.pl | 2 +- t/db_dependent/Members_Attributes.t | 79 +++++++++++++++++++++++------------ tools/import_borrowers.pl | 2 +- 5 files changed, 92 insertions(+), 32 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 23 07:54:08 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 23 Mar 2016 06:54:08 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.04-89-g25fdc18 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 25fdc18f77edf29a94527ad812481c91c80c701c (commit) via d786b63fb595ca681834d801741738ea6688f8bc (commit) via 8c2186b402e2b00f6ca110589a0774046be51211 (commit) via 748b3d5522aab2e7fe76d6fc309a199cada79625 (commit) via 38820140fc17cbc6926aa6d369c8be415a54b640 (commit) via dcf02d0a1a497bdaf473bf11e2c72b3af7e4076d (commit) via 65b1618e9c4197718c59950767692e0502fee689 (commit) via e6b03cf3a0fe369a41a2d3f3b7460c84d299d4f0 (commit) via c65c69a4cb3a3aae2097bcaff5f406349d0415a8 (commit) from 0d904b655e65f70476c5d7daf355cc7c3cf0976b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 25fdc18f77edf29a94527ad812481c91c80c701c Author: Jonathan Druart Date: Thu Mar 10 09:12:52 2016 +0000 Bug 11998: Clear L1 cache from psgi files Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jacek Ablewicz Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com (cherry picked from commit 55b78f1a5dbbff5a790971e2f5a99ebdd6a3f18a) Signed-off-by: Julian Maurice commit d786b63fb595ca681834d801741738ea6688f8bc Author: Jonathan Druart Date: Thu Mar 10 08:55:27 2016 +0000 Bug 11998: Add a L1 cache for sysprefs Accessing to the cache for each call to C4::Context->preference might have an impact on performances. To avoid that this patch introduces a L1 cache (simple hashref). It will be populated by accessing the L2 cache (Koha::Cache). If a pref is retrieved 10x, the first one will get the value from the L2 cache, then the L1 cache will be check. To do so we will need to clear the L1 cache every time a page is loaded. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jacek Ablewicz Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com (cherry picked from commit 47fbbb7cf5e7ef2f9ef422e2fd9232066100a64b) Signed-off-by: Julian Maurice commit 8c2186b402e2b00f6ca110589a0774046be51211 Author: Jonathan Druart Date: Thu Mar 3 16:52:51 2016 +0000 Bug 11998: follow-up for the debian package psgi file Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jacek Ablewicz Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com (cherry picked from commit 2eaf2cd71b9620c0d5782c7c78f86a5e323c89a4) Signed-off-by: Julian Maurice commit 748b3d5522aab2e7fe76d6fc309a199cada79625 Author: Jonathan Druart Date: Thu Mar 3 16:45:07 2016 +0000 Bug 11998: Revert "Bug 13805: (Plack) Disable syspref cache" This reverts commit ca00f0ddaeb76106b4aa274fd1848844ae042f58. Bug 13805 fixes an installer bug by disabling the syspref cache. It was not a good idea, it introduced performance issues (see bug 13805 comment 14). Test plan: Test plan: 0/ Create a new database and fill the database entry in the koha conf with its name 1/ Go on the mainpage, you should be redirected to the installer 2/ Try to log in You should not get the login form again. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jacek Ablewicz Test plan not followed by me for this patch, due to lack of working plack setup, but I don't expect it to cause any problems, and performace gain for plack will be tremendous Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com (cherry picked from commit d4039ce09347c342f8ac048814ee10b47819df48) Signed-off-by: Julian Maurice commit 38820140fc17cbc6926aa6d369c8be415a54b640 Author: Jonathan Druart Date: Thu Mar 3 17:17:40 2016 +0000 Bug 11998: Do not clear syspref cache in psgi file This in only in koha.psgi, it has been introduced by bug 13815 but should not have been added by this patch. Removing it should not introduce any changes. Not that it won't impact debian packages. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jacek Ablewicz Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com (cherry picked from commit f25e3ed90b55b657c71e117a1e9a8bc2c3a1809f) Signed-off-by: Julian Maurice commit dcf02d0a1a497bdaf473bf11e2c72b3af7e4076d Author: Jonathan Druart Date: Mon Mar 7 09:24:14 2016 +0000 Bug 11998: Make HoldsQueue.t tests pass [TO REVERT] This patch should not be the way to make these tests pass. The prefs should not be updated using set_preference, it will modify the values in the cache. I have no idea how to make them pass using the correct way, please help :) Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jacek Ablewicz Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com (cherry picked from commit 3907401a6d293872ca1fb46c90da029b91d37e31) Signed-off-by: Julian Maurice commit 65b1618e9c4197718c59950767692e0502fee689 Author: Jonathan Druart Date: Fri Mar 4 13:21:39 2016 +0000 Bug 11998: Use C4::Context->preference in Koha/Schema/Result/Item.pm Otherwise some tests won't pass Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jacek Ablewicz Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com (cherry picked from commit a691e88a4ebf57e9ebda8afb5f8e6bac33bc6ad6) Signed-off-by: Julian Maurice commit e6b03cf3a0fe369a41a2d3f3b7460c84d299d4f0 Author: Jonathan Druart Date: Fri Mar 4 13:14:59 2016 +0000 Bug 11998: Use t::lib::Mocks::mock_preference in tests Unless in t/db_dependent/Context.t where we want to test the cache behaviors. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jacek Ablewicz Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com (cherry picked from commit 56a782c666d1d05215e49101e33fce0a3cd30377) Signed-off-by: Julian Maurice commit c65c69a4cb3a3aae2097bcaff5f406349d0415a8 Author: Jonathan Druart Date: Thu Mar 3 16:54:30 2016 +0000 Bug 11998: Use Koha::Cache to cache sysprefs At the moment, the sysprefs are only cache in the thread memory executing the processus When using Plack, that means we need to clear the syspref cache on each page. To avoid that, we can use Koha::Cache to cache the sysprefs correctly. A big part of the authorship of this patch goes to Robin Sheat. Test plan: 1/ Add/Update/Delete local use prefs 2/ Update pref values and confirm that the changes are correctly taken into account Signed-off-by: Chris Signed-off-by: Josef Moravec Tested with plack with syspref cache enabled, there is some time between setting the syspref and applying it, but it takes just one reload of page, it shouldn't be problem, should it? Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jacek Ablewicz Tested with CGI and CGI + memcache; some small issues still remain, but it would be better to deal with them in separate bug reports if necessary Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com (cherry picked from commit 9820f9dfbd63ecc812b6b2a4ec71af91f303f933) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Context.pm | 106 +++++++++++++++++----- Koha/Config/SysPref.pm | 32 +++++++ Koha/Schema/Result/Item.pm | 8 +- admin/preferences.pl | 1 - admin/systempreferences.pl | 61 +++---------- debian/templates/plack.psgi | 3 +- misc/admin/koha-preferences | 2 +- misc/plack/koha.psgi | 4 +- svc/config/systempreferences | 2 - t/db_dependent/Amazon.t | 19 ++-- t/db_dependent/Auth.t | 7 +- t/db_dependent/Auth_with_cas.t | 5 +- t/db_dependent/Bookseller.t | 5 +- t/db_dependent/Circulation.t | 41 +++++---- t/db_dependent/Circulation/GetTopIssues.t | 3 +- t/db_dependent/Circulation/Returns.t | 5 +- t/db_dependent/Circulation_Branch.t | 3 +- t/db_dependent/Circulation_issue.t | 5 +- t/db_dependent/Context.t | 11 ++- t/db_dependent/Hold.t | 7 +- t/db_dependent/Holds.t | 12 +-- t/db_dependent/Items.t | 26 +++--- t/db_dependent/Koha_template_plugin_KohaDates.t | 7 +- t/db_dependent/Languages.t | 5 +- t/db_dependent/Letters.t | 2 +- t/db_dependent/Members.t | 19 ++-- t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t | 5 +- t/db_dependent/QueryParser.t | 3 +- t/db_dependent/Record.t | 7 +- t/db_dependent/Reserves.t | 32 +++---- t/db_dependent/Suggestions.t | 5 +- t/db_dependent/XISBN.t | 9 +- t/db_dependent/default_search_class.pl | 3 +- t/db_dependent/sysprefs.t | 15 ++- 34 files changed, 286 insertions(+), 194 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 23 08:00:00 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 23 Mar 2016 07:00:00 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.04-90-g8d0a57f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 8d0a57f5241a911d7e95a24ddb01acd824451c99 (commit) from 25fdc18f77edf29a94527ad812481c91c80c701c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8d0a57f5241a911d7e95a24ddb01acd824451c99 Author: Jonathan Druart Date: Wed Feb 17 16:21:50 2016 +0000 Bug 15840: Catch errors if userid already exists when importing patrons Import borrowers tool explodes if userid already exists. This error should be caught to avoid the script to explodes. TEST PLAN --------- 1) back up DB 2) drop DB, create empty DB 3) Apply patch 15842 4) web install all the sample data 5) login as system user and import patron data -- sample provided to trigger error. -- you will get a DBIx::class exception "Duplicate entry ' for key 'userid'" 6) Apply this patch 7) Repeat steps 2-5 -- patrons won't be inserted but an error will be nicely displayed in the error list. 8) run koha qa test tools Note that it would be easy to insert the patrons anyway and generate a userid based on the surname and firstname. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com (cherry picked from commit f1e156453a1bc636914bc5c969e1665d7108cb95) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/tools/import_borrowers.tt | 5 +++++ tools/import_borrowers.pl | 7 +++++++ 2 files changed, 12 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 23 08:11:48 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 23 Mar 2016 07:11:48 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.04-91-gbf55fbd Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via bf55fbd4d42058487f1fef30f7dbfc24e6f8bad3 (commit) from 8d0a57f5241a911d7e95a24ddb01acd824451c99 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bf55fbd4d42058487f1fef30f7dbfc24e6f8bad3 Author: Jonathan Druart Date: Fri Mar 18 08:34:22 2016 +0000 Bug 16095: Remove target="_blank" when a link refer to an external link If you click on a link that opens a new tab/window to another site, that tab has access to the original window through JavaScript. The browsing context is related, even if the domains are totally different. The tab retains access to the original window's object via window.opener, even if you navigate to another page or domain, in the new or original window. Access to the Window object means the new window can use Window.location to open a different URL in the original window, perfect for phishing attacks. Depending on the site's Same-Origin Policy settings, the new window may have access to other parts of the original window's DOM as well. Any 'A HREF' that contains a target of of '_blank' or '_new' or a fixed name is vulnerable. Previous security best practice often suggested creating a random fixed name for an unpredictable namespace - that won't help with this problem! Targets of '_self' and '_parent' are safe. We do not use _new (at first glance) but several _blank. Some are used to refer internal url, we do not need to update or remove them. Others are used to satisfy OPACURLOpenInNewWindow, in these case, we should add the rel="noreferrer" attribute to the a tags. In other cases, we can simply remove them and let the users discover that a mouse has more than one button (we are in 2016, they can do it!) Signed-off-by: Chris Signed-off-by: Jesse Weaver Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com (cherry picked from commit 6c1b39b4cbceb1a414a91865e15612385c2eb5b7) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 4 +-- .../prog/en/modules/acqui/supplier.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-basket.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 30 ++++++++++---------- .../opac-tmpl/bootstrap/en/modules/opac-idref.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/js/google-jackets.js | 2 +- 6 files changed, 21 insertions(+), 21 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 23 08:49:54 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 23 Mar 2016 07:49:54 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.04-92-g26f05af Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 26f05afd0b66b4903e6c41a3e21150c34d024b2c (commit) from bf55fbd4d42058487f1fef30f7dbfc24e6f8bad3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 26f05afd0b66b4903e6c41a3e21150c34d024b2c Author: Kyle M Hall Date: Mon Mar 7 14:04:44 2016 +0000 Bug 15997 - Hold Ratios for ordered items doesn't count orders where AcqCreateItem is set to 'receiving' Currently, the hold ratios script only counts on order items where the record item is created at the time the order is placed, and not if the item is created when the item is received. Test Plan: 1) Set AcqCreateItem to recieving 2) Run the hold ratios report with "include ordered" checked 3) From aquisitions, order some additional items for the record 4) Re-run the hold ratios report, not there is no change in the ratio for that record 5) Apply this patch 6) Re-run the hold ratios reporat again, the ratio should now have changed Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com (cherry picked from commit 7e1ccbd6069658540dd352f63ade3ef7b19de282) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: circ/reserveratios.pl | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 23 08:53:23 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 23 Mar 2016 07:53:23 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.04-93-g145e4f7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 145e4f7a1e104416da3fe5866ae537e68e4e9480 (commit) from 26f05afd0b66b4903e6c41a3e21150c34d024b2c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 145e4f7a1e104416da3fe5866ae537e68e4e9480 Author: Jonathan Druart Date: Wed Mar 9 11:28:04 2016 +0000 Bug 16013: Make classification sources deletable Because of a wrong variable scope, the classification sources are not deletable. Test plan: Create a classification sources (admin/classsources.pl) Try to delete it Without this patch, the classification source won't be deleted With this patch, it will work! Signed-off-by: Srdjan Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com (cherry picked from commit f6463317db08b9a4218ad94a2d191a5f5216c8c5) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: admin/classsources.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 23 09:49:12 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 23 Mar 2016 08:49:12 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.04-94-g631b932 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 631b93204579bb2d85fc29af2500370449b07439 (commit) from 145e4f7a1e104416da3fe5866ae537e68e4e9480 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 631b93204579bb2d85fc29af2500370449b07439 Author: Zeno Tajoli Date: Tue Mar 1 11:44:42 2016 +0100 Bug 15946 Valid namespace for OAI marcxml schema (3.22/3.20) As the patch for master, this patch apply on 3.22 (and 3.20 probably). This path fixes the value of xml schema variable and the link to Library of Congress. For Dublin Core format those values are defined in UNIMARCslim2OAIDC.xsl and MARC21slim2OAIDC.xsl. For MARCXML those values are written into the code To test it: 1) Setup OAI-PMH 2) Test the site inserting the BaseURL into http://validator.oaipmh.com 3) See the problem with ListMetadataFormats [link: http://validator.oaipmh.com/#ListMetadataFormats] 4) Insert the patch 5) See the problem is over Signed-off-by: Fr?d?ric Demians Invalid before patch, valid after. Signed-off-by: Katrin Fischer ----------------------------------------------------------------------- Summary of changes: opac/oai.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 23 10:13:01 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 23 Mar 2016 09:13:01 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.04-95-g0d01864 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 0d018647849724bacc40be7360e56a29c1a7fb53 (commit) from 631b93204579bb2d85fc29af2500370449b07439 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0d018647849724bacc40be7360e56a29c1a7fb53 Author: Jonathan Druart Date: Wed Jan 6 13:10:00 2016 +0000 Bug 15119: Hide search header text boxes on render When the page rendering is slow or the page is heavy, the tabs in the header shown be not correctly displayed as tabs. This patch suggests to hide them, display the first one, and wait for the JS code to display them nicely. To easily reproduced the ergonomic issue, go on the circulation home page (/cgi-bin/koha/circ/circulation.pl) and search for a patron 'a' or 'd', you will get a lot of result and the page will be slow to be fully displayed. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Owen Leonard Signed-off-by: Christopher Brannon Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com (cherry picked from commit 70eedf2217e1bfde1c56bc77c8dd0dc039124f47) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css | 9 +++++++++ koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js | 2 ++ 2 files changed, 11 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 23 10:57:06 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 23 Mar 2016 09:57:06 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.04-96-g0ab731a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 0ab731ae7659554734d09d86ee4d02419c02fa98 (commit) from 0d018647849724bacc40be7360e56a29c1a7fb53 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0ab731ae7659554734d09d86ee4d02419c02fa98 Author: Colin Campbell Date: Fri Mar 18 13:49:56 2016 +0000 Bug 16106 Correct loose to lose in comment Comment was using incorrect (but similarly spelled) word, obscuring the meaning slightly. Also corrected the release note altering the grammar there additionally as it should have been 3rd person singular so that it now reads more clearly Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com (cherry picked from commit 515e2d7c9d2b5afe3f7c0618596f1d9e5e699315) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: misc/plack/koha.psgi | 2 +- misc/release_notes/release_notes_3_22_0.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 23 14:10:59 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 23 Mar 2016 13:10:59 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.04-97-gf89c350 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via f89c350f7216619bbf327bc700b0c4cd8be0486f (commit) from 0ab731ae7659554734d09d86ee4d02419c02fa98 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f89c350f7216619bbf327bc700b0c4cd8be0486f Author: Julian Maurice