[koha-commits] main Koha release repository branch master updated. v3.22.00-723-g0fdc102

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  0fdc1021d4477d838c6b38a1172137a5eec08978 (commit)
      from  10a9a1e147699bdb1fd2b58ab93fe87cb82074cf (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 0fdc1021d4477d838c6b38a1172137a5eec08978
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Feb 10 15:37:30 2016 +0000

    Bug 15800: Koha::AuthorisedValues - Remove C4::Koha::IsAuthorisedValueCategory
    
    C4::Koha::IsAuthorisedValueCategory contains only 2 useful calls, from
    C4::Reports::Guided and reports/guided_reports.pl
    It can be replaced with
      Koha::AuthorisedValues->search({ category => $authorised_value})->count
    
    Test plan:
    1/ Create a sql report using an authorised value category, something
    like:
      SELECT COUNT(*) FROM items where itemlost=<<lost|LOST>>
    2/ Execute the report and confirm that everything works fine.
    3/ Create a sql report using a nonexistent authorised value categor,
    something like:
      SELECT COUNT(*) FROM items where itemlost=<<lost|NONEXIST>>
    4/ When saving the report, you should get a warning message
      "lost: The authorized value category (NONEXIST) you selected does not exist."
    5/ Save anyway and execute the report, you should get the same warning
    message.
    
    QA:
      git grep IsAuthorisedValueCategory
    should not return any results
      prove t/db_dependent/ReportsGuided.t
    should return green
    
    Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
    Works as described
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com

-----------------------------------------------------------------------

Summary of changes:
 C4/Koha.pm                     |   23 -----------------------
 C4/Reports/Guided.pm           |    4 +++-
 reports/guided_reports.pl      |    5 +++--
 t/Koha.t                       |   22 +++++-----------------
 t/db_dependent/ReportsGuided.t |   27 +++++----------------------
 5 files changed, 16 insertions(+), 65 deletions(-)


hooks/post-receive
-- 
main Koha release repository