[koha-commits] main Koha release repository branch master updated. v3.22.00-743-gfd74b27

Git repo owner gitmaster at git.koha-community.org
Wed Mar 2 23:30:40 CET 2016


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  fd74b271db61bf88368c803b1b2bfb76e62b0e6f (commit)
      from  255c0af9893b745d2f1a233a9aea8b7f1281546e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit fd74b271db61bf88368c803b1b2bfb76e62b0e6f
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue Feb 23 14:27:31 2016 -0500

     Bug 15887: Revise layout and behavior of item search fields management
    
    This patch adds some JavaScript to the item search fields management
    page so that the add form is not displayed by default. This simplifies
    the interface and makes it more consistent with other similar
    interfaces.
    
    Also changed in this patch:
    - Changing instances of "Items search fields" to "Item search fields."
    - Correct form structure to use ordered list
    - Add "required" classes and enable built-in JS form validation.
    - Add explicitly labeled "Choose" options to <select>s.
    - Add missing ids to form fields (labels don't work without them).
    - Correct classes of message and alert dialogs.
    - Add JS confirmation of deletions.
    - Convert MARC tag and subfield dropdowns to regular inputs (Bug 15384).
    
    To test, apply the patch and go to Administration.
    
    - Confirm that the "Item search fields" link is correct.
    - Follow the link and confirm that the list of existing fields is shown
      by default, or a message saying there are no existing fields.
    - Click the "New search field" button and confirm that it displays the
      entry form.
      - Confirm that submitting an empty form does not work.
      - Confirm that clicking the "Cancel" link correctly hides the form.
      - Confirm that submitting valid data works correctly.
    - In the table of existing item search fields, confirm that the "Edit"
      button works correctly.
      - Confirm that submitting edits works correctly.
    - In the table of existing item search fields, confirm that clicking
      "Delete" highlights the row in question and a confirmation dialog
      appears.
      - Test both canceling and confirming deletion.
    
    Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
    Works as described. JSHint OK, koha-qa OK.
    
    Revision per QA: Undid the change making tag and subfield inputs text
    fields.
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 .../intranet-tmpl/prog/en/css/staff-global.css     |    3 +-
 .../en/includes/admin-items-search-field-form.inc  |   40 ++++----
 .../intranet-tmpl/prog/en/includes/admin-menu.inc  |    2 +-
 .../intranet-tmpl/prog/en/js/item_search_fields.js |   24 +++++
 .../prog/en/modules/admin/admin-home.tt            |    4 +-
 .../prog/en/modules/admin/items_search_field.tt    |   16 +--
 .../prog/en/modules/admin/items_search_fields.tt   |  105 ++++++++++++--------
 7 files changed, 120 insertions(+), 74 deletions(-)
 create mode 100644 koha-tmpl/intranet-tmpl/prog/en/js/item_search_fields.js


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list