[koha-commits] main Koha release repository branch master updated. v3.22.00-754-g9bd9476

Thu Mar 3 21:10:35 CET 2016

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  9bd9476b1d7c7b20c046213fd40910e0181b3757 (commit)
       via  fbb7097b1daba6502b8b25efccafe4319cc5d7e8 (commit)
       via  0813c72b1fe8880f319a8259e1f0b3efff80fa32 (commit)
       via  05ea6ba1a87ec74ac3d47aebcc177c454448bcda (commit)
      from  256785f5db4ae2ad45de2b3658ce25d462687164 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 9bd9476b1d7c7b20c046213fd40910e0181b3757
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Mon Feb 15 09:13:58 2016 +0100

     Bug 12426: [QA Follow-up] Clear to_address to force update

    When resending an email from the Notices tab in Patrons, we would like
    to use the recent email address.

    Test plan:
    [1] Look up a patron with some notices sent.
    [2] Adjust the patron email address (watch AutoEmailPrimaryAddress).
    [3] Resend the notice. Verify if the new address was used.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

commit fbb7097b1daba6502b8b25efccafe4319cc5d7e8
Author: Lari Taskula <larit at student.uef.fi>
Date:   Wed Sep 16 18:31:57 2015 +0300

     Bug 12426: Allow resend for sent messages

    This patch allows to resend both sent and failed messages.

    With messages in 'sent' status, we have to be careful not to accidentally send
    sent messages again. With the previous patch using GET request, this was likely
    to happen because of browser storing the GET parameters.

    This patch changes request method from GET to POST. Instead of a simple link,
    we now have a form element.

    In notices.pl we redirect back to notices.pl, because with POST there is a risk
    of resending the message accidentally by form resubmission at refresh.

    To test, find/create a Patron that has sent or failed notices in message_queue:
    1. Enable EnchancedMessagingPreferences system preference
    2. Go to Patrons -> Notices
    3. In the Notice column, click the title of the sent or failed message
    4. Observe that there is nothing for resending the sent or failed message
    5. Apply the patches.
    6. Reload Notices page and repeat step 3
    7. Observe that there is now a link "Resend" in the Status-column
    8. Click Resend
    9. Observe that the message gets into 'pending' status

    Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

commit 0813c72b1fe8880f319a8259e1f0b3efff80fa32
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Sep 14 11:35:56 2015 +0100

     Bug 12426: Simplify the code adding a new subroutine GetMessage

    The C4::Letters module does not have a GetMessage subroutine, which
    could be quite useful.
    This patch adds it and simplifies the code added by the previous patch.
    It also adds a few tests and fixes POD typos.

    Note that ResendNotice only resends failed messages. This will avoid to
    resend already sent messages (using an url from the browser history for
    instance).

    Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

commit 05ea6ba1a87ec74ac3d47aebcc177c454448bcda
Author: Lari Taskula <larit at student.uef.fi>
Date:   Thu Sep 3 14:42:02 2015 +0300

     Bug 12426: Allow resending of messages from the notices tab in the patron account

    This patch adds a link 'Resend' under a notice in 'failed' status
    in the Patron's Notices tab.

    By clicking the link, we will request notices.pl with parameter
    "resendnotice=XXXXX" where XXXXX is message_id. In notices.pl,
    we then check whether the given message is actually in 'failed'
    status. If so, we use the C4::Letters::ResendMessage(123) to
    change the status of the message into 'pending'. This way it
    will be processed again by the cronjob process_message_queue.pl.

    To test, find/create a Patron that has failed notices in message_queue:
    1. Enable EnchancedMessagingPreferences system preference
    2. Go to Patrons -> Notices
    3. In the Notice column, click the title of the failed message
    4. Observe that there is nothing for resending the failed message
    5. Apply patch.
    6. Reload Notices page and repeat step 3
    7. Observe that there is now a link "Resend" in the Status-column
    8. Click Resend
    9. Observe that the message gets into 'pending' status

    Works as expected.
    Signed-off-by: Marc Véron <veron at veron.ch>

    Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Letters.pm                                      |   50 ++++++++++++++++++++
 .../prog/en/modules/members/notices.tt             |   12 ++++-
 members/notices.pl                                 |   12 +++++
 t/db_dependent/Letters.t                           |   12 ++++-
 4 files changed, 84 insertions(+), 2 deletions(-)

hooks/post-receive
-- 
main Koha release repository