[koha-commits] main Koha release repository branch master updated. v3.22.00-780-gd53daa3
Git repo owner
gitmaster at git.koha-community.org
Thu Mar 3 22:17:14 CET 2016
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via d53daa339212c025be637adf37df732e1ba08e5b (commit)
via 55ad33ba2e5db1ef07862e0517278b6b34d3b42d (commit)
via 774993ae2d06627b245c0192bbdd923756aab337 (commit)
via 3917867b41971b0562d2e162304181f5a9a9ad0b (commit)
via ff5b23f94aa87624a10321f455b9a6862aaafc1c (commit)
via 2d74d926ce54c95f3a638709935f56a90fa7752f (commit)
via 74180472ad563cf0435d4af80ad50c90d2565df8 (commit)
via e6bd28682e284ab9a6ff3b00afeaa1113112af15 (commit)
via d9c983c5680a877fad0dcef383c9af2b565862e4 (commit)
via b842a08589427e628b609d779fc665613eb3c9ba (commit)
via dd31253441d99c4b2a2feba6d505c6a44e5584ce (commit)
from e88457a9fab442979a7422ce33970b60753cfc06 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit d53daa339212c025be637adf37df732e1ba08e5b
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Feb 11 10:05:21 2016 +0000
Bug 15632 [QA Followup] - Change method type to _type for bug 15446
Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
commit 55ad33ba2e5db1ef07862e0517278b6b34d3b42d
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Feb 11 09:38:33 2016 +0000
Bug 15632 [QA Followup] - Undo changes needed for Bug 13618 which was reverted
Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
commit 774993ae2d06627b245c0192bbdd923756aab337
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Feb 11 08:09:03 2016 +0000
Bug 15632 [QA Followup] - Get rid of use of uninitialized value errors for unit tests
* Set $user to "" if not passed
* Tidy sub
Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
commit 3917867b41971b0562d2e162304181f5a9a9ad0b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Feb 1 17:20:21 2016 +0000
Bug 15632: Koha::Patron::Messages - (follow-up) Remove AddMessage
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
commit ff5b23f94aa87624a10321f455b9a6862aaafc1c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jan 20 18:28:40 2016 +0000
Bug 15632: Koha::Patron::Messages - Remove tests
The messages related tests in t/db_dependent/Members.t are not
deprecated and can be removed.
Test plan:
git grep AddMessage
git grep DeleteMessage
git grep GetMessagesCount
git grep GetMessages
should not return any result.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
commit 2d74d926ce54c95f3a638709935f56a90fa7752f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jan 20 18:28:55 2016 +0000
Bug 15632: Koha::Patron::Messages - Remove GetMessages
This subroutine just retrieved the messages given some parameters.
Some job should not have been done in this subroutine.
It was called only 3 times, in circ/circulation.pl and opac-user.pl.
Basically it was used to retrieved the message to displaye for a given
patron ($borrowernumber) at the OPAC (B) or Staff (L).
For the 3 calls, the 2 parameters $borrowernumber and $type
(message_type) were passed, the "%" trick at the beginning of the
subroutine was useless.
Moreover, the date formatting should be done on the TT side, not in
subroutine.
The can_delete flag was set if the branchcode given in parameter was the
same as the one of the message. This has been delegated to the template.
Indeed the can_delete was not valid, since it must depend on the
AllowAllMessageDeletion pref.
The test is now:
IF message.branchcode == branch OR
Koha.Preference('AllowAllMessageDeletion'')
There is not specific test plan for this patch, the changes have already
been tested in previous patches.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
commit 74180472ad563cf0435d4af80ad50c90d2565df8
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jan 20 17:58:45 2016 +0000
Bug 15632: Koha::Patron::Messages - Remove GetMessagesCount
The GetMessageCount subroutine was only used once, in opac-user.pl, to
know if some messages will be displayed.
Test plan:
1/ Create messages to display at the OPAC for a patron
2/ Logged this patron in at the OPAC, you should see the messages
displayed.
Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
commit e6bd28682e284ab9a6ff3b00afeaa1113112af15
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jan 20 17:57:55 2016 +0000
Bug 15632: Koha::Patron::Messages - Remove DeleteMessage
The DeleteMessage just deleted and logged if needed.
This is now be done by Koha::Patron::Message->delete.
Test plan:
1/ Go on the "check out" page of a patron
2/ Delete some messages
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
commit d9c983c5680a877fad0dcef383c9af2b565862e4
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jan 20 17:56:58 2016 +0000
Bug 15632: Koha::Patron::Messages - Remove AddMessage
The AddMessage subroutine just
1. checked if all the parameters were passed
2. inserted the message in the DB
3. logged the action if needed
These 3 jobs are now done by the overloaded store method of
Koha::Patron::Message.
Test plan:
1/ Go on the "check out" page of a patron
2/ Add different new messages
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
commit b842a08589427e628b609d779fc665613eb3c9ba
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jan 20 17:56:07 2016 +0000
Bug 15632: Koha::Patron::Messages - Be sure add and delete will log
If the pref BorrowersLog is on, the store and delete method should log
into the action_logs table.
Easy to do by overloading them.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
commit dd31253441d99c4b2a2feba6d505c6a44e5584ce
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jan 20 17:31:50 2016 +0000
Bug 15632: Koha::Patron::Messages - Add new classes
The following 4 CRUD subroutines in C4::Members:
- AddMessage
- DeleteMessage
- GetMessagesCount
- GetMessages
could be replaced with a new package based on Koha::Objets.
This patchset will add the 2 Koha::Patron::Message[s] classes, then use
it to replace the different calls to these subroutine.
It will slightly reduce the size of C4::Members
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Log.pm | 55 +++++----
C4/Members.pm | 129 --------------------
Koha/{AudioAlert.pm => Patron/Message.pm} | 50 ++++----
Koha/{Cities.pm => Patron/Messages.pm} | 12 +-
circ/add_message.pl | 20 +--
circ/circulation.pl | 26 ++--
circ/del_message.pl | 14 +--
.../prog/en/modules/circ/circulation.tt | 49 ++++----
.../opac-tmpl/bootstrap/en/modules/opac-user.tt | 9 +-
opac/opac-user.pl | 11 +-
t/db_dependent/Koha/Patron/Messages.t | 83 +++++++++++++
t/db_dependent/Members.t | 46 +------
12 files changed, 215 insertions(+), 289 deletions(-)
copy Koha/{AudioAlert.pm => Patron/Message.pm} (55%)
copy Koha/{Cities.pm => Patron/Messages.pm} (82%)
create mode 100644 t/db_dependent/Koha/Patron/Messages.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list