[koha-commits] main Koha release repository branch master updated. v3.22.00-799-g838a939
Git repo owner
gitmaster at git.koha-community.org
Fri Mar 4 13:49:29 CET 2016
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 838a939c9febba76968132af542e282326efa863 (commit)
via b0eef880ff9ede7e2d998684a082480d64416ede (commit)
via 545b64f8690e32b1cda5e95891d10250bfcf0e95 (commit)
via 85633155f48494c2495d4bf261c7f7f453399425 (commit)
via d8980b60ee3144ab8ebf2d3bbf6847c622443425 (commit)
via b6aa77ac4901e8ad00e941247d7a35c8c47f75bd (commit)
from de23e3f2fb1e5c376f29953c7f93b721405d7739 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 838a939c9febba76968132af542e282326efa863
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Feb 19 14:55:53 2016 +0000
Bug 15635 [QA Followup] - Fix number of unit tests
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit b0eef880ff9ede7e2d998684a082480d64416ede
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Feb 16 11:14:55 2016 +0000
Bug 15635: Change method type to _type for bug 15446
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 545b64f8690e32b1cda5e95891d10250bfcf0e95
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Jan 21 13:04:09 2016 +0000
Bug 15635: Koha::Patron::Images - Remove GetPatronImage
To retrieve a patron image, we can call Koha::Patron::Images->find or
Koha::Patrons->find->image
Both will return a Koha::Patron::Image object.
Test plan:
1/ From the patron/member module, open all tabs on the left (Checkouts,
detail, fines, etc.)
The image should be correctly displayed.
2/ At the OPAC, on the patron details page (opac-memberentry.pl) the
image should be displayed as well.
3/ Same on the sco module.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 85633155f48494c2495d4bf261c7f7f453399425
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Jan 21 12:37:41 2016 +0000
Bug 15635: Koha::Patron::Images - Remove RmPatronImage
The C4::Members::RmPatronImage just removed a row in patronimage.
This can be accomplished using the delete method of Koha::Patron::Image.
Test plan:
From the patron defail page, try to delete the image of a patron.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit d8980b60ee3144ab8ebf2d3bbf6847c622443425
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Jan 21 12:32:28 2016 +0000
Bug 15635: Koha::Patron::Images - Remove PutPatronImage
The C4::Members::PutPatronImage inserted/updated the image of a patron.
This can be done easily with ->find->set->store or ->new->store
Test plan:
1/ Modify the image of a patron from the patron detail page
2/ Add an image to a new patron
3/ Use the "Upload patron images" tools (tools/picture-upload.pl) to add
or modify the image of a patron
4/ Use the "Upload patron images" tools (tools/picture-upload.pl) to add
or modify the image of several patrons, using a zip file.
Stress the script trying to get as many errors as possible (wrong
cardnumber, wrong mimetype, file does not exist, etc.)
With this patch, if the cardnumber does not exist, you will get a
specific error "Image not imported because this patron does not exist in
the database"
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit b6aa77ac4901e8ad00e941247d7a35c8c47f75bd
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Jan 21 12:33:25 2016 +0000
Bug 15635: Koha::Patron::Images - Add new classes
There are 3 subroutines in C4::Members to get, add and delete patron
images:
- GetPatronImage
- PutPatronImage
- RmPatronImage
By creating these 2 Koha::Patron::Image[s] classes, we could remove them easily.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Members.pm | 66 +----------------
Koha/Patron.pm | 7 ++
Koha/{City.pm => Patron/Image.pm} | 8 +-
Koha/Patron/{Messages.pm => Images.pm} | 10 +--
circ/circulation.pl | 5 +-
.../prog/en/modules/tools/picture-upload.tt | 1 +
members/boraccount.pl | 5 +-
members/deletemem.pl | 5 +-
members/discharge.pl | 5 +-
members/files.pl | 5 +-
members/mancredit.pl | 5 +-
members/maninvoice.pl | 5 +-
members/member-flags.pl | 5 +-
members/member-password.pl | 5 +-
members/moremember.pl | 5 +-
members/notices.pl | 5 +-
members/patronimage.pl | 12 +--
members/pay.pl | 10 +--
members/paycollect.pl | 5 +-
members/printfeercpt.pl | 5 +-
members/printinvoice.pl | 5 +-
members/purchase-suggestions.pl | 5 +-
members/readingrec.pl | 6 +-
members/routing-lists.pl | 5 +-
members/statistics.pl | 5 +-
opac/opac-memberentry.pl | 9 +--
opac/opac-patron-image.pl | 17 ++---
opac/sco/sco-main.pl | 13 ++--
opac/sco/sco-patron-image.pl | 17 ++---
patroncards/create-pdf.pl | 9 ++-
t/db_dependent/Koha/Patron/Images.t | 54 ++++++++++++++
tools/picture-upload.pl | 77 +++++++++++++-------
tools/viewlog.pl | 5 +-
33 files changed, 216 insertions(+), 190 deletions(-)
copy Koha/{City.pm => Patron/Image.pm} (87%)
copy Koha/Patron/{Messages.pm => Images.pm} (83%)
create mode 100644 t/db_dependent/Koha/Patron/Images.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list