[koha-commits] main Koha release repository branch master updated. v3.22.00-811-g76308f8
Git repo owner
gitmaster at git.koha-community.org
Mon Mar 7 18:28:31 CET 2016
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 76308f809af1e07e4a8d61db28f6a31f516660b8 (commit)
via 1307f26bd17767a563857e6d8334e7d69686f918 (commit)
via 2237e0f871fa1bcf0009346022fa854aedf0b7f8 (commit)
from 617b72a54eb80fd7ea5e55be9484cf1dbf5e292f (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 76308f809af1e07e4a8d61db28f6a31f516660b8
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Mar 4 11:54:07 2016 +0100
Bug 5404: [QA Follow-up] Add test descriptions
Adding descriptions for changes in t/db_dependent/Biblio.t.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
commit 1307f26bd17767a563857e6d8334e7d69686f918
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Feb 29 10:04:51 2016 +0000
Bug 5404: Move the test to a new IsMarcStructureInternal sub
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
commit 2237e0f871fa1bcf0009346022fa854aedf0b7f8
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Feb 12 12:36:16 2016 +0000
Bug 5404: C4::Koha - remove subfield_is_koha_internal_p
The commit b5ecefd485a75d54a5fa26fff5a0cc890541e2c3
Date: Mon Feb 3 18:46:00 2003 +0000
had a funny description:
Added function to check if a MARC subfield name is "koha-internal"
(instead of checking it for 'lib' and 'tag' everywhere); temporarily
added to Koha.pm
"Temporarily", since 2003, everything is relative, isn't it? :)
The thing is that GetMarcStructure returns hash like
field_200 => {
subfield_a => {
%attributes_of_subfield_a
},
%attributes_of_field_200
}
The attributes for field_200 can be 'repeatable', 'mandatory', 'tag', 'lib'.
We don't want to loop on these values when looping on subfields.
Since there are just { k => v } with v is a scalar (string), it's easier
to test if we are processing a subfield testing the reference.
At some places, we don't need to test that, we are looping on values
from MARC::Field->subfields which are always valid subfields.
Test plan:
1/ Edit items using the batch item mod tool
2/ display and edit items via the cataloguing module.
You should not see any changes between before and after the patch
applied.
Tech notes:
We need to check what we are processing when we loop on 'subfields' from
GetMarcStructure, not from MARC::Field->subfields.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Acquisition.pm | 4 ++--
C4/Biblio.pm | 22 ++++++++++++++++++++
C4/Items.pm | 2 +-
C4/Koha.pm | 12 -----------
authorities/authorities-home.pl | 2 +-
authorities/authorities.pl | 2 +-
cataloguing/addbiblio.pl | 4 ++--
cataloguing/additem.pl | 9 ++++----
labels/label-item-search.pl | 2 +-
opac/opac-authorities-home.pl | 2 +-
reports/guided_reports.pl | 2 +-
t/db_dependent/Acquisition/FillWithDefaultValues.t | 8 +++++--
t/db_dependent/Biblio.t | 22 +++++++++++++++++++-
tools/batchMod.pl | 6 +++---
14 files changed, 66 insertions(+), 33 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list