[koha-commits] main Koha release repository branch master updated. v3.22.00-829-g859e3ce
Git repo owner
gitmaster at git.koha-community.org
Tue Mar 8 22:50:34 CET 2016
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 859e3ce41b69692471e9a1e37d646f9ed0bfe6dd (commit)
from 357ddab7c6519fdbb57e448c28170c267035a130 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 859e3ce41b69692471e9a1e37d646f9ed0bfe6dd
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Feb 19 20:24:46 2016 -0500
Bug 15936 - Revise layout and behavior of SMS cellular providers management
This patch changes the behavior of the SMS cellular providers management
page so that sections of the page are shown or hidden based on what the
current task is. Other changes include:
- Moving JavaScript to a separate file
- Adding a toolbar with a "New SMS provider" button.
- Adding the "generic" catalog search header form to the top of the
page.
- Adding "Required" classes to required fields so that the staff
client's built-in JS validation library can be used.
To test, the SMSSendDriver system preference must be set to "Email."
Apply the patch and go to Administration -> SMS cellular providers.
- Confirm that the add/edit form is hidden initially. A toolbar with a
"New SMS provider" button should appear with existing SMS cellular
providers in a table below. If there are no existing providers a
message dialog should say so.
- Confirm that the "New SMS provider" button works:
- The table should be hidden and an empty "add" form displayed.
- Confirm that an empty form cannot be submitted.
- Confirm that submitting valid data works.
- Confirm that clicking the "Cancel" button hides the form and
redisplays the table.
- Test the "edit" button for an existing provider:
- Confirm that the edit form is displayed and populated with the
correct data.
- Confirm that edits are saved correctly.
- When viewing the table of existing providers, confirm that clicking
the "Delete" button triggers a confirmation dialog. Test both
cancelling and confirming that dialog.
- Ponder whether all this is an improvement or not.
Signed-off-by: Nicole C Engard <nengard at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
.../intranet-tmpl/prog/en/js/sms_providers.js | 58 ++++++
.../prog/en/modules/admin/sms_providers.tt | 191 +++++++++-----------
2 files changed, 144 insertions(+), 105 deletions(-)
create mode 100644 koha-tmpl/intranet-tmpl/prog/en/js/sms_providers.js
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list